'
### Version information
- **Homeserver**:
own closed down non-federated homeserver.
- **Version**:
{
""python_version"": ""3.6.9"",
""server_version"": ""1.12.4""
}
- **Install method**:
ubuntu - package manager
- **Platform**:
ubuntu 18.04.4 LTS
",
790,https://api.github.com/repos/matrix-org/synapse/issues/7498,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7498/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7498/comments,https://api.github.com/repos/matrix-org/synapse/issues/7498/events,https://github.com/matrix-org/synapse/issues/7498,618068549,MDU6SXNzdWU2MTgwNjg1NDk=,7498,"""Failed to handle device list update warnings"" warnings","{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}","[{'id': 477043173, 'node_id': 'MDU6TGFiZWw0NzcwNDMxNzM=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/p2', 'name': 'p2', 'color': 'fbca04', 'default': False, 'description': None}]",open,False,,[],,0,2020-05-14T09:19:01Z,2020-05-15T16:40:42Z,,MEMBER,,,"We have quite a lot of entries in the log that look like `2020-05-14 09:13:01,090 - synapse.handlers.device - 700 - WARNING - POST-5412 - Failed to handle device list update for {user}`, with no clues as to why the failure happened, nor of its impact. If it's worth warning about, we need more details.",
791,https://api.github.com/repos/matrix-org/synapse/issues/7497,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7497/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7497/comments,https://api.github.com/repos/matrix-org/synapse/issues/7497/events,https://github.com/matrix-org/synapse/pull/7497,617877417,MDExOlB1bGxSZXF1ZXN0NDE3NzEzMTMz,7497,Omit displayname or avatar_url if they aren't set instead of returning null,"{'login': 'aaronraimist', 'id': 5855073, 'node_id': 'MDQ6VXNlcjU4NTUwNzM=', 'avatar_url': 'https://avatars2.githubusercontent.com/u/5855073?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/aaronraimist', 'html_url': 'https://github.com/aaronraimist', 'followers_url': 'https://api.github.com/users/aaronraimist/followers', 'following_url': 'https://api.github.com/users/aaronraimist/following{/other_user}', 'gists_url': 'https://api.github.com/users/aaronraimist/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/aaronraimist/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/aaronraimist/subscriptions', 'organizations_url': 'https://api.github.com/users/aaronraimist/orgs', 'repos_url': 'https://api.github.com/users/aaronraimist/repos', 'events_url': 'https://api.github.com/users/aaronraimist/events{/privacy}', 'received_events_url': 'https://api.github.com/users/aaronraimist/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,2,2020-05-14T02:32:41Z,2020-05-25T04:41:45Z,2020-05-19T09:31:25Z,CONTRIBUTOR,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7497', 'html_url': 'https://github.com/matrix-org/synapse/pull/7497', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7497.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7497.patch'}","# Pull Request Checklist
* [x] Pull request is based on the develop branch
* [x] Pull request includes a [changelog file](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#changelog). The entry should:
- Be a short description of your change which makes sense to users. ""Fixed a bug that prevented receiving messages from other servers."" instead of ""Moved X method from `EventStore` to `EventWorkerStore`."".
- Use markdown where necessary, mostly for `code blocks`.
- End with either a period (.) or an exclamation mark (!).
- Start with a capital letter.
* [x] Pull request includes a [sign off](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#sign-off)
* [x] Code style is correct (run the [linters](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#code-style))
Per https://github.com/matrix-org/matrix-doc/issues/1436#issuecomment-410089470 they should be omitted instead of returning null or """". They aren't marked as required in the spec.
Fixes https://github.com/matrix-org/synapse/issues/7333",
792,https://api.github.com/repos/matrix-org/synapse/issues/7496,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7496/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7496/comments,https://api.github.com/repos/matrix-org/synapse/issues/7496/events,https://github.com/matrix-org/synapse/pull/7496,617699321,MDExOlB1bGxSZXF1ZXN0NDE3NTY2NTc0,7496,Notes on using git,"{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,0,2020-05-13T19:29:52Z,2020-05-15T10:10:17Z,2020-05-14T17:03:10Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7496', 'html_url': 'https://github.com/matrix-org/synapse/pull/7496', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7496.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7496.patch'}",I wrote down some stuff about git.,
793,https://api.github.com/repos/matrix-org/synapse/issues/7495,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7495/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7495/comments,https://api.github.com/repos/matrix-org/synapse/issues/7495/events,https://github.com/matrix-org/synapse/pull/7495,617606032,MDExOlB1bGxSZXF1ZXN0NDE3NDkwNTkz,7495,Add `instance_map` config and route replication calls,"{'login': 'erikjohnston', 'id': 8428120, 'node_id': 'MDQ6VXNlcjg0MjgxMjA=', 'avatar_url': 'https://avatars0.githubusercontent.com/u/8428120?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/erikjohnston', 'html_url': 'https://github.com/erikjohnston', 'followers_url': 'https://api.github.com/users/erikjohnston/followers', 'following_url': 'https://api.github.com/users/erikjohnston/following{/other_user}', 'gists_url': 'https://api.github.com/users/erikjohnston/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/erikjohnston/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/erikjohnston/subscriptions', 'organizations_url': 'https://api.github.com/users/erikjohnston/orgs', 'repos_url': 'https://api.github.com/users/erikjohnston/repos', 'events_url': 'https://api.github.com/users/erikjohnston/events{/privacy}', 'received_events_url': 'https://api.github.com/users/erikjohnston/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,2,2020-05-13T16:55:48Z,2020-05-14T13:01:00Z,2020-05-14T13:00:58Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7495', 'html_url': 'https://github.com/matrix-org/synapse/pull/7495', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7495.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7495.patch'}","This will allow us, for example, to configure where instances talk to to send events.
For now this remains hidden, experimental and undocumented. ",
794,https://api.github.com/repos/matrix-org/synapse/issues/7494,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7494/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7494/comments,https://api.github.com/repos/matrix-org/synapse/issues/7494/events,https://github.com/matrix-org/synapse/issues/7494,617583428,MDU6SXNzdWU2MTc1ODM0Mjg=,7494,Server notice user's avatar and displayname are only set on initial creation of the user,"{'login': 'anoadragon453', 'id': 1342360, 'node_id': 'MDQ6VXNlcjEzNDIzNjA=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1342360?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/anoadragon453', 'html_url': 'https://github.com/anoadragon453', 'followers_url': 'https://api.github.com/users/anoadragon453/followers', 'following_url': 'https://api.github.com/users/anoadragon453/following{/other_user}', 'gists_url': 'https://api.github.com/users/anoadragon453/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/anoadragon453/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/anoadragon453/subscriptions', 'organizations_url': 'https://api.github.com/users/anoadragon453/orgs', 'repos_url': 'https://api.github.com/users/anoadragon453/repos', 'events_url': 'https://api.github.com/users/anoadragon453/events{/privacy}', 'received_events_url': 'https://api.github.com/users/anoadragon453/received_events', 'type': 'User', 'site_admin': False}","[{'id': 121086031, 'node_id': 'MDU6TGFiZWwxMjEwODYwMzE=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/enhancement', 'name': 'enhancement', 'color': '84b6eb', 'default': True, 'description': None}, {'id': 950651954, 'node_id': 'MDU6TGFiZWw5NTA2NTE5NTQ=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/good%20first%20issue', 'name': 'good first issue', 'color': '0bba0e', 'default': True, 'description': ''}, {'id': 477050471, 'node_id': 'MDU6TGFiZWw0NzcwNTA0NzE=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/p3', 'name': 'p3', 'color': '0e8a16', 'default': False, 'description': None}]",open,False,,[],,0,2020-05-13T16:21:49Z,2020-06-08T10:19:35Z,,MEMBER,,,"If you've already created a server notices user, say with the following config:
```yaml
server_notices:
system_mxid_localpart: 'notices'
system_mxid_display_name: 'Server Notices'
system_mxid_avatar_url: 'mxc://example.com/abcde12345'
room_name: 'Server Notices'
```
change either `system_mxid_display_name` or `system_mxid_avatar_url` will not update the user's avatar or display name. These are only set on initial creation of the user, thus changing `system_mxid_localpart` will apply the changes, but in the process create a new user.
The code for setting the displayname and avatar is:
https://github.com/matrix-org/synapse/blob/28c98e51ffa166bd717646b0b34228e59f253485/synapse/server_notices/server_notices_manager.py#L125-L139
Instead, Synapse should check to see if the displayname or avatar has changed after a server restart, and update them accordingly.",
795,https://api.github.com/repos/matrix-org/synapse/issues/7493,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7493/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7493/comments,https://api.github.com/repos/matrix-org/synapse/issues/7493/events,https://github.com/matrix-org/synapse/pull/7493,617534915,MDExOlB1bGxSZXF1ZXN0NDE3NDMyMzQ0,7493,Move EventStream handling into default ReplicationDataHandler,"{'login': 'erikjohnston', 'id': 8428120, 'node_id': 'MDQ6VXNlcjg0MjgxMjA=', 'avatar_url': 'https://avatars0.githubusercontent.com/u/8428120?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/erikjohnston', 'html_url': 'https://github.com/erikjohnston', 'followers_url': 'https://api.github.com/users/erikjohnston/followers', 'following_url': 'https://api.github.com/users/erikjohnston/following{/other_user}', 'gists_url': 'https://api.github.com/users/erikjohnston/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/erikjohnston/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/erikjohnston/subscriptions', 'organizations_url': 'https://api.github.com/users/erikjohnston/orgs', 'repos_url': 'https://api.github.com/users/erikjohnston/repos', 'events_url': 'https://api.github.com/users/erikjohnston/events{/privacy}', 'received_events_url': 'https://api.github.com/users/erikjohnston/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,0,2020-05-13T15:15:02Z,2020-05-14T13:01:42Z,2020-05-14T13:01:40Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7493', 'html_url': 'https://github.com/matrix-org/synapse/pull/7493', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7493.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7493.patch'}",This is so that the logic can happen on both master and workers when we move event persistence out.,
796,https://api.github.com/repos/matrix-org/synapse/issues/7492,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7492/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7492/comments,https://api.github.com/repos/matrix-org/synapse/issues/7492/events,https://github.com/matrix-org/synapse/pull/7492,617518055,MDExOlB1bGxSZXF1ZXN0NDE3NDE4NzAz,7492,Allow censoring of events to happen on workers.,"{'login': 'erikjohnston', 'id': 8428120, 'node_id': 'MDQ6VXNlcjg0MjgxMjA=', 'avatar_url': 'https://avatars0.githubusercontent.com/u/8428120?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/erikjohnston', 'html_url': 'https://github.com/erikjohnston', 'followers_url': 'https://api.github.com/users/erikjohnston/followers', 'following_url': 'https://api.github.com/users/erikjohnston/following{/other_user}', 'gists_url': 'https://api.github.com/users/erikjohnston/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/erikjohnston/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/erikjohnston/subscriptions', 'organizations_url': 'https://api.github.com/users/erikjohnston/orgs', 'repos_url': 'https://api.github.com/users/erikjohnston/repos', 'events_url': 'https://api.github.com/users/erikjohnston/events{/privacy}', 'received_events_url': 'https://api.github.com/users/erikjohnston/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,0,2020-05-13T14:54:10Z,2020-05-13T16:15:42Z,2020-05-13T16:15:41Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7492', 'html_url': 'https://github.com/matrix-org/synapse/pull/7492', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7492.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7492.patch'}","This is safe as we can now write to cache invalidation stream on workers, and is required for when we move event persistence off master.",
797,https://api.github.com/repos/matrix-org/synapse/issues/7491,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7491/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7491/comments,https://api.github.com/repos/matrix-org/synapse/issues/7491/events,https://github.com/matrix-org/synapse/pull/7491,617490026,MDExOlB1bGxSZXF1ZXN0NDE3Mzk2MTUy,7491,Move event stream handling out of slave store.,"{'login': 'erikjohnston', 'id': 8428120, 'node_id': 'MDQ6VXNlcjg0MjgxMjA=', 'avatar_url': 'https://avatars0.githubusercontent.com/u/8428120?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/erikjohnston', 'html_url': 'https://github.com/erikjohnston', 'followers_url': 'https://api.github.com/users/erikjohnston/followers', 'following_url': 'https://api.github.com/users/erikjohnston/following{/other_user}', 'gists_url': 'https://api.github.com/users/erikjohnston/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/erikjohnston/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/erikjohnston/subscriptions', 'organizations_url': 'https://api.github.com/users/erikjohnston/orgs', 'repos_url': 'https://api.github.com/users/erikjohnston/repos', 'events_url': 'https://api.github.com/users/erikjohnston/events{/privacy}', 'received_events_url': 'https://api.github.com/users/erikjohnston/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,0,2020-05-13T14:20:10Z,2020-05-15T15:44:01Z,2020-05-15T15:44:00Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7491', 'html_url': 'https://github.com/matrix-org/synapse/pull/7491', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7491.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7491.patch'}","This allows us to have the logic on both master and workers, which is necessary to move event persistence off master.
We also combine the instantiation of ID generators from DataStore and slave stores to the base worker stores. This allows us to select which process writes events independently of the master/worker splits.
~~Based on #7490~~",
798,https://api.github.com/repos/matrix-org/synapse/issues/7490,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7490/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7490/comments,https://api.github.com/repos/matrix-org/synapse/issues/7490/events,https://github.com/matrix-org/synapse/pull/7490,617482335,MDExOlB1bGxSZXF1ZXN0NDE3Mzg5OTE0,7490,Clean up replication unit tests.,"{'login': 'erikjohnston', 'id': 8428120, 'node_id': 'MDQ6VXNlcjg0MjgxMjA=', 'avatar_url': 'https://avatars0.githubusercontent.com/u/8428120?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/erikjohnston', 'html_url': 'https://github.com/erikjohnston', 'followers_url': 'https://api.github.com/users/erikjohnston/followers', 'following_url': 'https://api.github.com/users/erikjohnston/following{/other_user}', 'gists_url': 'https://api.github.com/users/erikjohnston/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/erikjohnston/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/erikjohnston/subscriptions', 'organizations_url': 'https://api.github.com/users/erikjohnston/orgs', 'repos_url': 'https://api.github.com/users/erikjohnston/repos', 'events_url': 'https://api.github.com/users/erikjohnston/events{/privacy}', 'received_events_url': 'https://api.github.com/users/erikjohnston/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,0,2020-05-13T14:10:31Z,2020-05-13T15:01:48Z,2020-05-13T15:01:47Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7490', 'html_url': 'https://github.com/matrix-org/synapse/pull/7490', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7490.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7490.patch'}","This mainly makes `tests.replication.slave` tests use the same base class as `tests.replication.tcp`, so that we can remove the various gut wrenching that takes place in `tests.replication.slave` and instead properly spawn two separate HS objects like we do for the `tcp` tests.",
799,https://api.github.com/repos/matrix-org/synapse/issues/7489,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7489/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7489/comments,https://api.github.com/repos/matrix-org/synapse/issues/7489/events,https://github.com/matrix-org/synapse/pull/7489,617367534,MDExOlB1bGxSZXF1ZXN0NDE3Mjk3MjM4,7489,Fix new flake8 errors,"{'login': 'clokep', 'id': 517124, 'node_id': 'MDQ6VXNlcjUxNzEyNA==', 'avatar_url': 'https://avatars2.githubusercontent.com/u/517124?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/clokep', 'html_url': 'https://github.com/clokep', 'followers_url': 'https://api.github.com/users/clokep/followers', 'following_url': 'https://api.github.com/users/clokep/following{/other_user}', 'gists_url': 'https://api.github.com/users/clokep/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/clokep/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/clokep/subscriptions', 'organizations_url': 'https://api.github.com/users/clokep/orgs', 'repos_url': 'https://api.github.com/users/clokep/repos', 'events_url': 'https://api.github.com/users/clokep/events{/privacy}', 'received_events_url': 'https://api.github.com/users/clokep/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,0,2020-05-13T11:24:50Z,2020-05-13T12:24:52Z,2020-05-13T12:24:51Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7489', 'html_url': 'https://github.com/matrix-org/synapse/pull/7489', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7489.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7489.patch'}","This cherry picks #7470 / 1a1da60ad2c9172fe487cd38a164b39df60f4cb5 to the release branch to get builds working there again.
(I would have pinned flake8, but I'm unsure how to do that on a specific branch since it seems part of buildkite pipelines.)",
800,https://api.github.com/repos/matrix-org/synapse/issues/7488,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7488/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7488/comments,https://api.github.com/repos/matrix-org/synapse/issues/7488/events,https://github.com/matrix-org/synapse/issues/7488,617309441,MDU6SXNzdWU2MTczMDk0NDE=,7488,implement MSC2176: Update the redaction rules,"{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}","[{'id': 477043173, 'node_id': 'MDU6TGFiZWw0NzcwNDMxNzM=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/p2', 'name': 'p2', 'color': 'fbca04', 'default': False, 'description': None}]",open,False,,[],,1,2020-05-13T09:52:12Z,2020-05-14T19:47:39Z,,MEMBER,,,It would sure be nice to implement [MSC2176](https://github.com/matrix-org/matrix-doc/pull/2176) - maybe even in time to get it into [room v6](https://github.com/matrix-org/matrix-doc/pull/2240).,
801,https://api.github.com/repos/matrix-org/synapse/issues/7487,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7487/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7487/comments,https://api.github.com/repos/matrix-org/synapse/issues/7487/events,https://github.com/matrix-org/synapse/issues/7487,617307255,MDU6SXNzdWU2MTczMDcyNTU=,7487,implement MSC2175: Remove the `creator` field from `m.room.create` events,"{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}","[{'id': 477043173, 'node_id': 'MDU6TGFiZWw0NzcwNDMxNzM=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/p2', 'name': 'p2', 'color': 'fbca04', 'default': False, 'description': None}]",open,False,,[],,1,2020-05-13T09:48:49Z,2020-05-14T19:47:48Z,,MEMBER,,,It would sure be nice to implement [MSC2175](https://github.com/matrix-org/matrix-doc/pull/2175) - maybe even in time to get it into [room v6](https://github.com/matrix-org/matrix-doc/pull/2240).,
802,https://api.github.com/repos/matrix-org/synapse/issues/7486,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7486/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7486/comments,https://api.github.com/repos/matrix-org/synapse/issues/7486/events,https://github.com/matrix-org/synapse/issues/7486,617304611,MDU6SXNzdWU2MTczMDQ2MTE=,7486,implement MSC2174: Move the `redacts` key to a sane place,"{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}","[{'id': 477043173, 'node_id': 'MDU6TGFiZWw0NzcwNDMxNzM=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/p2', 'name': 'p2', 'color': 'fbca04', 'default': False, 'description': None}]",open,False,,[],,5,2020-05-13T09:44:53Z,2020-05-15T11:20:19Z,,MEMBER,,,It would sure be nice to implement [MSC2174](https://github.com/matrix-org/matrix-doc/pull/2174) - maybe even in time to get it into [room v6](https://github.com/matrix-org/matrix-doc/pull/2240).,
803,https://api.github.com/repos/matrix-org/synapse/issues/7485,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7485/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7485/comments,https://api.github.com/repos/matrix-org/synapse/issues/7485/events,https://github.com/matrix-org/synapse/issues/7485,617289128,MDU6SXNzdWU2MTcyODkxMjg=,7485,Enable Desktop notifications from homesever.yaml,"{'login': 'Ismathena', 'id': 56560988, 'node_id': 'MDQ6VXNlcjU2NTYwOTg4', 'avatar_url': 'https://avatars2.githubusercontent.com/u/56560988?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Ismathena', 'html_url': 'https://github.com/Ismathena', 'followers_url': 'https://api.github.com/users/Ismathena/followers', 'following_url': 'https://api.github.com/users/Ismathena/following{/other_user}', 'gists_url': 'https://api.github.com/users/Ismathena/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/Ismathena/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/Ismathena/subscriptions', 'organizations_url': 'https://api.github.com/users/Ismathena/orgs', 'repos_url': 'https://api.github.com/users/Ismathena/repos', 'events_url': 'https://api.github.com/users/Ismathena/events{/privacy}', 'received_events_url': 'https://api.github.com/users/Ismathena/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,2,2020-05-13T09:22:03Z,2020-05-18T08:19:24Z,2020-05-14T19:49:41Z,NONE,,,"hi,
I need to enable desktop notifications from homeserver.yaml without do it from interface.
Thanks for help .
",
804,https://api.github.com/repos/matrix-org/synapse/issues/7484,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7484/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7484/comments,https://api.github.com/repos/matrix-org/synapse/issues/7484/events,https://github.com/matrix-org/synapse/issues/7484,617245991,MDU6SXNzdWU2MTcyNDU5OTE=,7484,"""Missing string query parameter b'RelayState'"" during SAML re-authentication","{'login': 'sephii', 'id': 754333, 'node_id': 'MDQ6VXNlcjc1NDMzMw==', 'avatar_url': 'https://avatars0.githubusercontent.com/u/754333?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sephii', 'html_url': 'https://github.com/sephii', 'followers_url': 'https://api.github.com/users/sephii/followers', 'following_url': 'https://api.github.com/users/sephii/following{/other_user}', 'gists_url': 'https://api.github.com/users/sephii/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/sephii/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/sephii/subscriptions', 'organizations_url': 'https://api.github.com/users/sephii/orgs', 'repos_url': 'https://api.github.com/users/sephii/repos', 'events_url': 'https://api.github.com/users/sephii/events{/privacy}', 'received_events_url': 'https://api.github.com/users/sephii/received_events', 'type': 'User', 'site_admin': False}","[{'id': 121086029, 'node_id': 'MDU6TGFiZWwxMjEwODYwMjk=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/bug', 'name': 'bug', 'color': 'fc2929', 'default': True, 'description': None}, {'id': 828666468, 'node_id': 'MDU6TGFiZWw4Mjg2NjY0Njg=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/release%20blocker', 'name': 'release blocker', 'color': '880000', 'default': False, 'description': None}]",closed,False,"{'login': 'clokep', 'id': 517124, 'node_id': 'MDQ6VXNlcjUxNzEyNA==', 'avatar_url': 'https://avatars2.githubusercontent.com/u/517124?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/clokep', 'html_url': 'https://github.com/clokep', 'followers_url': 'https://api.github.com/users/clokep/followers', 'following_url': 'https://api.github.com/users/clokep/following{/other_user}', 'gists_url': 'https://api.github.com/users/clokep/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/clokep/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/clokep/subscriptions', 'organizations_url': 'https://api.github.com/users/clokep/orgs', 'repos_url': 'https://api.github.com/users/clokep/repos', 'events_url': 'https://api.github.com/users/clokep/events{/privacy}', 'received_events_url': 'https://api.github.com/users/clokep/received_events', 'type': 'User', 'site_admin': False}","[{'login': 'clokep', 'id': 517124, 'node_id': 'MDQ6VXNlcjUxNzEyNA==', 'avatar_url': 'https://avatars2.githubusercontent.com/u/517124?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/clokep', 'html_url': 'https://github.com/clokep', 'followers_url': 'https://api.github.com/users/clokep/followers', 'following_url': 'https://api.github.com/users/clokep/following{/other_user}', 'gists_url': 'https://api.github.com/users/clokep/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/clokep/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/clokep/subscriptions', 'organizations_url': 'https://api.github.com/users/clokep/orgs', 'repos_url': 'https://api.github.com/users/clokep/repos', 'events_url': 'https://api.github.com/users/clokep/events{/privacy}', 'received_events_url': 'https://api.github.com/users/clokep/received_events', 'type': 'User', 'site_admin': False}]",,22,2020-05-13T08:21:40Z,2020-05-22T11:18:05Z,2020-05-22T11:17:31Z,NONE,,,"# Description
When using the SAML re-authentication flow (eg. when deleting devices from an account), the page with the text ""A client is trying to remove device(s) from your account. To confirm this action, re-authenticate with single sign-on. If you did not expect this, your account may be compromised!"" redirects to the IDP page without the `RelayState` parameter, causing the authentication to redirect to `/_matrix/saml2/authn_response` without any `RelayState` parameter, causing a 400 error with `Missing string query parameter b'RelayState'`.
i think the problem comes from [this line](https://github.com/matrix-org/synapse/blob/51fb0fc2e55baa76fcc6e04f81194fa5f8a44639/synapse/rest/client/v2_alpha/auth.py#L175), which initiates the redirect with an empty URL ([used as `RelayState` by `handle_redirect_request`](https://github.com/matrix-org/synapse/blob/51fb0fc2e55baa76fcc6e04f81194fa5f8a44639/synapse/handlers/saml_handler.py#L100)).
SSO login works fine on the other hand, where `RelayState` is correctly added to the IDP URL. I'm using Google as a SAML IDP.
### Steps to reproduce
- Log in on riot web with SAML auth (SAML being the only authentication scheme enabled)
- Go to your user settings, go to the ""security and privacy tab""
- Select a session to delete, click on the ""delete"" button
- A modal asking you to use SSO to continue opens, click on the SSO button
- A page asking you to confirm you want to delete these devices opens, click on the link
- You're redirected to the SAML login page, without a RelayState parameter
- Log in on the IDP, you're redirected to `/_matrix/saml2/authn_response` without a `RelayState` parameter, and you get the 400 error described.
i'd expect the authentication to succeed.
### Version information
- **Homeserver**: https://matrix.asso-pea.ch/
- **Version**: 1.13.0rc1
- **Client**: riot-web 1.6.0
- **Install method**: pip
- **Platform**: Debian buster",
805,https://api.github.com/repos/matrix-org/synapse/issues/7483,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7483/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7483/comments,https://api.github.com/repos/matrix-org/synapse/issues/7483/events,https://github.com/matrix-org/synapse/pull/7483,616888009,MDExOlB1bGxSZXF1ZXN0NDE2OTEyNTUw,7483,"Warn, instead of erroring, if the client dict changes during UI Auth.","{'login': 'clokep', 'id': 517124, 'node_id': 'MDQ6VXNlcjUxNzEyNA==', 'avatar_url': 'https://avatars2.githubusercontent.com/u/517124?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/clokep', 'html_url': 'https://github.com/clokep', 'followers_url': 'https://api.github.com/users/clokep/followers', 'following_url': 'https://api.github.com/users/clokep/following{/other_user}', 'gists_url': 'https://api.github.com/users/clokep/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/clokep/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/clokep/subscriptions', 'organizations_url': 'https://api.github.com/users/clokep/orgs', 'repos_url': 'https://api.github.com/users/clokep/repos', 'events_url': 'https://api.github.com/users/clokep/events{/privacy}', 'received_events_url': 'https://api.github.com/users/clokep/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,2,2020-05-12T19:03:17Z,2020-05-13T18:26:46Z,2020-05-13T18:26:45Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7483', 'html_url': 'https://github.com/matrix-org/synapse/pull/7483', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7483.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7483.patch'}","Per some of our discussions we need to back-off on verifying the client dictionary since it seems these frequently change in a non-compliant way during UI authentication operations. We do still verify that the URI and method haven't been modified, but only warn loudly if the client dictionary has been.
This will not warn for the registration endpoint, but will persist the modifications to the client dict.
It is our intention in a future version to tighten this up again, but that might need some spec work.
Fixes #7471
## Questions
* Do we need to always persist the modifications to the client dict?
* Do we want to log the device or anything in the warning? The log line should include the user already I think.
* Should the changelog entry be different than the original PRs now that we've done an RC?",
806,https://api.github.com/repos/matrix-org/synapse/issues/7482,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7482/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7482/comments,https://api.github.com/repos/matrix-org/synapse/issues/7482/events,https://github.com/matrix-org/synapse/pull/7482,616757391,MDExOlB1bGxSZXF1ZXN0NDE2ODA3NDQx,7482,Fix Redis reconnection logic,"{'login': 'erikjohnston', 'id': 8428120, 'node_id': 'MDQ6VXNlcjg0MjgxMjA=', 'avatar_url': 'https://avatars0.githubusercontent.com/u/8428120?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/erikjohnston', 'html_url': 'https://github.com/erikjohnston', 'followers_url': 'https://api.github.com/users/erikjohnston/followers', 'following_url': 'https://api.github.com/users/erikjohnston/following{/other_user}', 'gists_url': 'https://api.github.com/users/erikjohnston/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/erikjohnston/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/erikjohnston/subscriptions', 'organizations_url': 'https://api.github.com/users/erikjohnston/orgs', 'repos_url': 'https://api.github.com/users/erikjohnston/repos', 'events_url': 'https://api.github.com/users/erikjohnston/events{/privacy}', 'received_events_url': 'https://api.github.com/users/erikjohnston/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,2,2020-05-12T15:38:18Z,2020-05-14T16:57:58Z,2020-05-13T08:57:16Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7482', 'html_url': 'https://github.com/matrix-org/synapse/pull/7482', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7482.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7482.patch'}","This does two things:
~~1. Ensures we only send a `REPLICATE` when we (re)connect *after* we successfully subscribe. This ensures we are subscribed to hear responses to `REPLICATE` (in practice this is unlikely to be an issue as we'll almost certainly finish subscribing by the time other instances have received and responded to the `REPLICATE`).~~ Actually, this is spurious.
2. Proactively send out `POSITION` commands (as if we had just received a `REPLICATE`) when we connect to Redis. This is important as other instances won't notice we've connected to issue a `REPLICATE` command (unlike for direct TCP connections). This is only currently an issue if master process reconnects without restarting (if it restarts then it won't have written anything and so other instances probably won't have missed anything). ",
807,https://api.github.com/repos/matrix-org/synapse/issues/7481,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7481/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7481/comments,https://api.github.com/repos/matrix-org/synapse/issues/7481/events,https://github.com/matrix-org/synapse/pull/7481,616736619,MDExOlB1bGxSZXF1ZXN0NDE2NzkxMDc2,7481,Add device management to admin API,"{'login': 'dklimpel', 'id': 5740567, 'node_id': 'MDQ6VXNlcjU3NDA1Njc=', 'avatar_url': 'https://avatars2.githubusercontent.com/u/5740567?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/dklimpel', 'html_url': 'https://github.com/dklimpel', 'followers_url': 'https://api.github.com/users/dklimpel/followers', 'following_url': 'https://api.github.com/users/dklimpel/following{/other_user}', 'gists_url': 'https://api.github.com/users/dklimpel/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/dklimpel/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/dklimpel/subscriptions', 'organizations_url': 'https://api.github.com/users/dklimpel/orgs', 'repos_url': 'https://api.github.com/users/dklimpel/repos', 'events_url': 'https://api.github.com/users/dklimpel/events{/privacy}', 'received_events_url': 'https://api.github.com/users/dklimpel/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,0,2020-05-12T15:11:21Z,2020-06-05T13:58:49Z,2020-06-05T12:07:23Z,CONTRIBUTOR,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7481', 'html_url': 'https://github.com/matrix-org/synapse/pull/7481', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7481.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7481.patch'}","Add device management to admin API
Endpoins like https://matrix.org/docs/spec/client_server/r0.6.0#id73
- Admin is able to
- change displaynames
- delete devices
- list devices
- get device informations
Fixes #7330
### Pull Request Checklist
* [x] Pull request is based on the develop branch
* [x] Pull request includes a [changelog file](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#changelog). The entry should:
- Be a short description of your change which makes sense to users. ""Fixed a bug that prevented receiving messages from other servers."" instead of ""Moved X method from `EventStore` to `EventWorkerStore`."".
- Use markdown where necessary, mostly for `code blocks`.
- End with either a period (.) or an exclamation mark (!).
- Start with a capital letter.
* [x] Pull request includes a [sign off](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#sign-off)
* [x] Code style is correct (run the [linters](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#code-style))
",
808,https://api.github.com/repos/matrix-org/synapse/issues/7480,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7480/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7480/comments,https://api.github.com/repos/matrix-org/synapse/issues/7480/events,https://github.com/matrix-org/synapse/pull/7480,616734985,MDExOlB1bGxSZXF1ZXN0NDE2Nzg5NzY4,7480,Use default room_invite_state_types on Docker config template,"{'login': 'landergate', 'id': 904839, 'node_id': 'MDQ6VXNlcjkwNDgzOQ==', 'avatar_url': 'https://avatars3.githubusercontent.com/u/904839?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/landergate', 'html_url': 'https://github.com/landergate', 'followers_url': 'https://api.github.com/users/landergate/followers', 'following_url': 'https://api.github.com/users/landergate/following{/other_user}', 'gists_url': 'https://api.github.com/users/landergate/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/landergate/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/landergate/subscriptions', 'organizations_url': 'https://api.github.com/users/landergate/orgs', 'repos_url': 'https://api.github.com/users/landergate/repos', 'events_url': 'https://api.github.com/users/landergate/events{/privacy}', 'received_events_url': 'https://api.github.com/users/landergate/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,1,2020-05-12T15:09:17Z,2020-05-12T20:31:39Z,2020-05-12T16:31:54Z,NONE,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7480', 'html_url': 'https://github.com/matrix-org/synapse/pull/7480', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7480.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7480.patch'}","Related to #7479
### Pull Request Checklist
* [x] Pull request is based on the develop branch
* [x] Pull request includes a [changelog file](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#changelog). The entry should:
- Be a short description of your change which makes sense to users. ""Fixed a bug that prevented receiving messages from other servers."" instead of ""Moved X method from `EventStore` to `EventWorkerStore`."".
- Use markdown where necessary, mostly for `code blocks`.
- End with either a period (.) or an exclamation mark (!).
- Start with a capital letter.
* [x] Pull request includes a [sign off](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#sign-off)
* [x] Code style is correct (run the [linters](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#code-style))
",
809,https://api.github.com/repos/matrix-org/synapse/issues/7479,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7479/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7479/comments,https://api.github.com/repos/matrix-org/synapse/issues/7479/events,https://github.com/matrix-org/synapse/pull/7479,616704740,MDExOlB1bGxSZXF1ZXN0NDE2NzY1MDAx,7479,Add missing event type at Docker conf template,"{'login': 'landergate', 'id': 904839, 'node_id': 'MDQ6VXNlcjkwNDgzOQ==', 'avatar_url': 'https://avatars3.githubusercontent.com/u/904839?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/landergate', 'html_url': 'https://github.com/landergate', 'followers_url': 'https://api.github.com/users/landergate/followers', 'following_url': 'https://api.github.com/users/landergate/following{/other_user}', 'gists_url': 'https://api.github.com/users/landergate/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/landergate/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/landergate/subscriptions', 'organizations_url': 'https://api.github.com/users/landergate/orgs', 'repos_url': 'https://api.github.com/users/landergate/repos', 'events_url': 'https://api.github.com/users/landergate/events{/privacy}', 'received_events_url': 'https://api.github.com/users/landergate/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,"{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}","[{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}]",,5,2020-05-12T14:31:12Z,2020-05-12T16:41:24Z,2020-05-12T15:02:28Z,NONE,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7479', 'html_url': 'https://github.com/matrix-org/synapse/pull/7479', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7479.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7479.patch'}","### Pull Request Checklist
* [x] Pull request is based on the develop branch
* [x] Pull request includes a [changelog file](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#changelog). The entry should:
- Be a short description of your change which makes sense to users. ""Fixed a bug that prevented receiving messages from other servers."" instead of ""Moved X method from `EventStore` to `EventWorkerStore`."".
- Use markdown where necessary, mostly for `code blocks`.
- End with either a period (.) or an exclamation mark (!).
- Start with a capital letter.
* [x] Pull request includes a [sign off](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#sign-off)
* [x] Code style is correct (run the [linters](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#code-style))
",
810,https://api.github.com/repos/matrix-org/synapse/issues/7478,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7478/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7478/comments,https://api.github.com/repos/matrix-org/synapse/issues/7478/events,https://github.com/matrix-org/synapse/issues/7478,616702145,MDU6SXNzdWU2MTY3MDIxNDU=,7478,Changing server_notices_mxid_avatar_url does not change notices user avatar image,"{'login': 'ptman', 'id': 24669, 'node_id': 'MDQ6VXNlcjI0NjY5', 'avatar_url': 'https://avatars0.githubusercontent.com/u/24669?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/ptman', 'html_url': 'https://github.com/ptman', 'followers_url': 'https://api.github.com/users/ptman/followers', 'following_url': 'https://api.github.com/users/ptman/following{/other_user}', 'gists_url': 'https://api.github.com/users/ptman/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/ptman/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/ptman/subscriptions', 'organizations_url': 'https://api.github.com/users/ptman/orgs', 'repos_url': 'https://api.github.com/users/ptman/repos', 'events_url': 'https://api.github.com/users/ptman/events{/privacy}', 'received_events_url': 'https://api.github.com/users/ptman/received_events', 'type': 'User', 'site_admin': False}","[{'id': 1311133228, 'node_id': 'MDU6TGFiZWwxMzExMTMzMjI4', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/info-needed', 'name': 'info-needed', 'color': 'a1e8ea', 'default': False, 'description': ''}]",closed,False,,[],,6,2020-05-12T14:27:46Z,2020-05-22T15:24:37Z,2020-05-22T15:24:37Z,CONTRIBUTOR,,,"### Description
The server notices user (and room) avatar doesn't work. Instead riot shows an S.
### Steps to reproduce
```yaml
server_notices:
system_mxid_localpart: 'notices'
system_mxid_display_name: 'Server Notices'
system_mxid_avatar_url: 'mxc://.../...'
room_name: 'Server Notices'
```
### Version information
- **Version**: 1.12.4+bionic1
- **Install method**: apt
- **Platform**: ubuntu 18.04",
811,https://api.github.com/repos/matrix-org/synapse/issues/7477,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7477/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7477/comments,https://api.github.com/repos/matrix-org/synapse/issues/7477/events,https://github.com/matrix-org/synapse/pull/7477,616698307,MDExOlB1bGxSZXF1ZXN0NDE2NzU5ODMx,7477,Fix copypasted comment,"{'login': 'ptman', 'id': 24669, 'node_id': 'MDQ6VXNlcjI0NjY5', 'avatar_url': 'https://avatars0.githubusercontent.com/u/24669?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/ptman', 'html_url': 'https://github.com/ptman', 'followers_url': 'https://api.github.com/users/ptman/followers', 'following_url': 'https://api.github.com/users/ptman/following{/other_user}', 'gists_url': 'https://api.github.com/users/ptman/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/ptman/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/ptman/subscriptions', 'organizations_url': 'https://api.github.com/users/ptman/orgs', 'repos_url': 'https://api.github.com/users/ptman/repos', 'events_url': 'https://api.github.com/users/ptman/events{/privacy}', 'received_events_url': 'https://api.github.com/users/ptman/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,0,2020-05-12T14:22:36Z,2020-05-14T04:58:41Z,2020-05-13T15:55:44Z,CONTRIBUTOR,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7477', 'html_url': 'https://github.com/matrix-org/synapse/pull/7477', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7477.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7477.patch'}","### Pull Request Checklist
* [x] Pull request is based on the develop branch
* [x] Pull request includes a [sign off](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#sign-off)
",
812,https://api.github.com/repos/matrix-org/synapse/issues/7476,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7476/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7476/comments,https://api.github.com/repos/matrix-org/synapse/issues/7476/events,https://github.com/matrix-org/synapse/pull/7476,616694703,MDExOlB1bGxSZXF1ZXN0NDE2NzU2OTEz,7476,Add missing event type at Docker conf template,"{'login': 'landergate', 'id': 904839, 'node_id': 'MDQ6VXNlcjkwNDgzOQ==', 'avatar_url': 'https://avatars3.githubusercontent.com/u/904839?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/landergate', 'html_url': 'https://github.com/landergate', 'followers_url': 'https://api.github.com/users/landergate/followers', 'following_url': 'https://api.github.com/users/landergate/following{/other_user}', 'gists_url': 'https://api.github.com/users/landergate/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/landergate/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/landergate/subscriptions', 'organizations_url': 'https://api.github.com/users/landergate/orgs', 'repos_url': 'https://api.github.com/users/landergate/repos', 'events_url': 'https://api.github.com/users/landergate/events{/privacy}', 'received_events_url': 'https://api.github.com/users/landergate/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,0,2020-05-12T14:17:51Z,2020-05-12T14:28:13Z,2020-05-12T14:27:52Z,NONE,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7476', 'html_url': 'https://github.com/matrix-org/synapse/pull/7476', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7476.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7476.patch'}","Fixed missing room_invite_state_types entry from Docker config template.
### Pull Request Checklist
* [ ] Pull request is based on the develop branch
* [x] Pull request includes a [changelog file](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#changelog). The entry should:
- Be a short description of your change which makes sense to users. ""Fixed a bug that prevented receiving messages from other servers."" instead of ""Moved X method from `EventStore` to `EventWorkerStore`."".
- Use markdown where necessary, mostly for `code blocks`.
- End with either a period (.) or an exclamation mark (!).
- Start with a capital letter.
* [x] Pull request includes a [sign off](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#sign-off)
* [x] Code style is correct (run the [linters](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#code-style))
",
813,https://api.github.com/repos/matrix-org/synapse/issues/7475,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7475/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7475/comments,https://api.github.com/repos/matrix-org/synapse/issues/7475/events,https://github.com/matrix-org/synapse/pull/7475,616689742,MDExOlB1bGxSZXF1ZXN0NDE2NzUyNzU0,7475,Have all instances correctly respond to REPLICATE command.,"{'login': 'erikjohnston', 'id': 8428120, 'node_id': 'MDQ6VXNlcjg0MjgxMjA=', 'avatar_url': 'https://avatars0.githubusercontent.com/u/8428120?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/erikjohnston', 'html_url': 'https://github.com/erikjohnston', 'followers_url': 'https://api.github.com/users/erikjohnston/followers', 'following_url': 'https://api.github.com/users/erikjohnston/following{/other_user}', 'gists_url': 'https://api.github.com/users/erikjohnston/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/erikjohnston/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/erikjohnston/subscriptions', 'organizations_url': 'https://api.github.com/users/erikjohnston/orgs', 'repos_url': 'https://api.github.com/users/erikjohnston/repos', 'events_url': 'https://api.github.com/users/erikjohnston/events{/privacy}', 'received_events_url': 'https://api.github.com/users/erikjohnston/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,0,2020-05-12T14:11:36Z,2020-05-13T09:27:04Z,2020-05-13T09:27:03Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7475', 'html_url': 'https://github.com/matrix-org/synapse/pull/7475', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7475.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7475.patch'}","Before all streams were only written to from master, so only master needed to respond to `REPLICATE` commands.
Currently all instances can write to the cache invalidation stream, but don't respond to `REPLICATE`. This is a bug, which can lead to missed rows from cache invalidation stream if an instance is restarted, however all the caches will be empty in that case so its not a problem.",
814,https://api.github.com/repos/matrix-org/synapse/issues/7474,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7474/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7474/comments,https://api.github.com/repos/matrix-org/synapse/issues/7474/events,https://github.com/matrix-org/synapse/issues/7474,616682159,MDU6SXNzdWU2MTY2ODIxNTk=,7474,State changed from starting to crashed,"{'login': 'ajay-aditatechnologies', 'id': 63399965, 'node_id': 'MDQ6VXNlcjYzMzk5OTY1', 'avatar_url': 'https://avatars0.githubusercontent.com/u/63399965?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/ajay-aditatechnologies', 'html_url': 'https://github.com/ajay-aditatechnologies', 'followers_url': 'https://api.github.com/users/ajay-aditatechnologies/followers', 'following_url': 'https://api.github.com/users/ajay-aditatechnologies/following{/other_user}', 'gists_url': 'https://api.github.com/users/ajay-aditatechnologies/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/ajay-aditatechnologies/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/ajay-aditatechnologies/subscriptions', 'organizations_url': 'https://api.github.com/users/ajay-aditatechnologies/orgs', 'repos_url': 'https://api.github.com/users/ajay-aditatechnologies/repos', 'events_url': 'https://api.github.com/users/ajay-aditatechnologies/events{/privacy}', 'received_events_url': 'https://api.github.com/users/ajay-aditatechnologies/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,2,2020-05-12T14:01:49Z,2020-05-12T15:02:32Z,2020-05-12T15:02:32Z,NONE,,,"**Description:**
Docker installation on Heroku at the end giving error
2020-05-12T12:57:35.324374+00:00 app[api]: Release v3 created by user ajay.s@aditatechnologies.com
2020-05-12T12:57:44.116031+00:00 heroku[web.1]: State changed from starting to crashed
2020-05-12T12:57:44.119339+00:00 heroku[web.1]: State changed from crashed to starting
2020-05-12T12:57:44.017657+00:00 app[web.1]: Unknown execution mode '/start.py'
2020-05-12T12:57:53.256910+00:00 heroku[web.1]: State changed from starting to crashed
2020-05-12T12:57:53.156967+00:00 app[web.1]: Unknown execution mode '/start.py'
2020-05-12T12:58:24.081803+00:00 heroku[router]: at=error code=H10 desc=""App crashed"" method=GET path=""/"" host=morning-bastion-44451.herokuapp.com request_id=dbb3f2b2-b496-4b0a-9238-59880ee2ec9d fwd=""223.185.136.39"" dyno= connect= service= status=503 bytes= protocol=https
2020-05-12T12:58:25.602419+00:00 heroku[router]: at=error code=H10 desc=""App crashed"" method=GET path=""/favicon.ico"" host=morning-bastion-44451.herokuapp.com request_id=7e47257e-c1fd-40b3-8493-ea8f02c64553 fwd=""223.185.136.39"" dyno= connect= service= status=503 bytes= protocol=https
2020-05-12T13:12:40.147929+00:00 heroku[router]: at=error code=H10 desc=""App crashed"" method=GET path=""/"" host=morning-bastion-44451.herokuapp.com request_id=46179e31-b870-4ca4-a76d-f2425abd6efe fwd=""223.185.136.39"" dyno= connect= service= status=503 bytes= protocol=https
2020-05-12T13:12:41.501210+00:00 heroku[router]: at=error code=H10 desc=""App crashed"" method=GET path=""/favicon.ico"" host=morning-bastion-44451.herokuapp.com request_id=8acc2279-27a7-4482-978b-80fef1bcf001 fwd=""223.185.136.39"" dyno= connect= service= status=503 bytes= protocol=https
2020-05-12T13:18:30.153579+00:00 heroku[web.1]: State changed from crashed to starting
2020-05-12T13:18:39.817410+00:00 heroku[web.1]: State changed from starting to crashed
2020-05-12T13:18:39.734816+00:00 app[web.1]: Unknown execution mode '/start.py'
2020-05-12T13:28:37.989601+00:00 heroku[router]: at=error code=H10 desc=""App crashed"" method=GET path=""/"" host=morning-bastion-44451.herokuapp.com request_id=6be480e8-6d06-495f-b4d1-bda89136e71a fwd=""223.185.136.39"" dyno= connect= service= status=503 bytes= protocol=https
2020-05-12T13:28:39.500961+00:00 heroku[router]: at=error code=H10 desc=""App crashed"" method=GET path=""/favicon.ico"" host=morning-bastion-44451.herokuapp.com request_id=c7f6cb41-d253-4c8c-9abe-4ad491cc1eb1 fwd=""223.185.136.39"" dyno= connect= service= status=503 bytes= protocol=https
2020-05-12T13:32:04.189323+00:00 heroku[router]: at=error code=H10 desc=""App crashed"" method=GET path=""/"" host=morning-bastion-44451.herokuapp.com request_id=35d9ab91-3d8e-4675-bbe1-20de9fc9e4a8 fwd=""223.185.136.39"" dyno= connect= service= status=503 bytes= protocol=https
2020-05-12T13:32:05.512366+00:00 heroku[router]: at=error code=H10 desc=""App crashed"" method=GET path=""/favicon.ico"" host=morning-bastion-44451.herokuapp.com request_id=7c28fe1e-59c1-4e06-8b8e-3013a29cd5b1 fwd=""223.185.136.39"" dyno= connect= service= status=503 bytes= protocol=https
",
815,https://api.github.com/repos/matrix-org/synapse/issues/7473,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7473/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7473/comments,https://api.github.com/repos/matrix-org/synapse/issues/7473/events,https://github.com/matrix-org/synapse/pull/7473,616668809,MDExOlB1bGxSZXF1ZXN0NDE2NzM1NDg5,7473,Workaround for failure to wrap reason in Failure,"{'login': 'anoadragon453', 'id': 1342360, 'node_id': 'MDQ6VXNlcjEzNDIzNjA=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1342360?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/anoadragon453', 'html_url': 'https://github.com/anoadragon453', 'followers_url': 'https://api.github.com/users/anoadragon453/followers', 'following_url': 'https://api.github.com/users/anoadragon453/following{/other_user}', 'gists_url': 'https://api.github.com/users/anoadragon453/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/anoadragon453/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/anoadragon453/subscriptions', 'organizations_url': 'https://api.github.com/users/anoadragon453/orgs', 'repos_url': 'https://api.github.com/users/anoadragon453/repos', 'events_url': 'https://api.github.com/users/anoadragon453/events{/privacy}', 'received_events_url': 'https://api.github.com/users/anoadragon453/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,0,2020-05-12T13:44:12Z,2020-05-14T16:07:26Z,2020-05-14T16:07:25Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7473', 'html_url': 'https://github.com/matrix-org/synapse/pull/7473', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7473.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7473.patch'}","Fixes https://github.com/matrix-org/synapse/issues/7441
Checks that `reason` has been properly wrapped in a `Failure`. If not, wraps it manually.",
816,https://api.github.com/repos/matrix-org/synapse/issues/7472,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7472/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7472/comments,https://api.github.com/repos/matrix-org/synapse/issues/7472/events,https://github.com/matrix-org/synapse/issues/7472,616576941,MDU6SXNzdWU2MTY1NzY5NDE=,7472,Ways to decrease size of Synapse database - state_groups_state table is too large,"{'login': 'MurzNN', 'id': 336662, 'node_id': 'MDQ6VXNlcjMzNjY2Mg==', 'avatar_url': 'https://avatars1.githubusercontent.com/u/336662?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/MurzNN', 'html_url': 'https://github.com/MurzNN', 'followers_url': 'https://api.github.com/users/MurzNN/followers', 'following_url': 'https://api.github.com/users/MurzNN/following{/other_user}', 'gists_url': 'https://api.github.com/users/MurzNN/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/MurzNN/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/MurzNN/subscriptions', 'organizations_url': 'https://api.github.com/users/MurzNN/orgs', 'repos_url': 'https://api.github.com/users/MurzNN/repos', 'events_url': 'https://api.github.com/users/MurzNN/events{/privacy}', 'received_events_url': 'https://api.github.com/users/MurzNN/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,5,2020-05-12T11:21:55Z,2020-06-23T12:53:21Z,2020-05-12T14:30:14Z,NONE,,,"Problem with very large size of Synapse PostgreSQL database table is very popular, and I can't find any good instructions how to decrease the size, so fill support issue here for make it available for others via googling.
Our public homeserver ru-matrix.org with about 20 local users - after 2 years of working got total size of pgsql table is 123GB!
As I understand, main tables, that store all events are `events` (8gb) and `event_json` (22gb), all other tables is generate data from it.
But in our database most size eats `state_groups_state` table, that have 274 millions of rows and 51GB size!
Is there any ways exists for reduce it size? Maybe exists some scripts for compress, deduplicate, regenerate, optimize, purge old/unused data in it?
I already try execution [synapse-compress-state](https://github.com/matrix-org/rust-synapse-compress-state) on larger rooms in my homeserver (Matrix HQ, Riot-*, KDE, etc), but the total size of `state_groups_state` table is still large, so I can't understand what to do next.
Comparing with real state storage table `state_events`, that have 5 millions of rows, I can't understand why `state_groups_state` so large?
Is it store many duplicates of data from `state_events`? If yes, maybe exists ways to deduplicate it?
If this is not duplicates, maybe I can purge old or rarely used data from local database, to sync it on demand from other servers via federatation?",
817,https://api.github.com/repos/matrix-org/synapse/issues/7471,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7471/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7471/comments,https://api.github.com/repos/matrix-org/synapse/issues/7471/events,https://github.com/matrix-org/synapse/issues/7471,616520440,MDU6SXNzdWU2MTY1MjA0NDA=,7471,Requested operation has changed during the UI authentication session - when trying to deactivate user with erasure,"{'login': 'Twi1ightSparkle', 'id': 19155609, 'node_id': 'MDQ6VXNlcjE5MTU1NjA5', 'avatar_url': 'https://avatars0.githubusercontent.com/u/19155609?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Twi1ightSparkle', 'html_url': 'https://github.com/Twi1ightSparkle', 'followers_url': 'https://api.github.com/users/Twi1ightSparkle/followers', 'following_url': 'https://api.github.com/users/Twi1ightSparkle/following{/other_user}', 'gists_url': 'https://api.github.com/users/Twi1ightSparkle/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/Twi1ightSparkle/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/Twi1ightSparkle/subscriptions', 'organizations_url': 'https://api.github.com/users/Twi1ightSparkle/orgs', 'repos_url': 'https://api.github.com/users/Twi1ightSparkle/repos', 'events_url': 'https://api.github.com/users/Twi1ightSparkle/events{/privacy}', 'received_events_url': 'https://api.github.com/users/Twi1ightSparkle/received_events', 'type': 'User', 'site_admin': False}","[{'id': 121086029, 'node_id': 'MDU6TGFiZWwxMjEwODYwMjk=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/bug', 'name': 'bug', 'color': 'fc2929', 'default': True, 'description': None}, {'id': 477045093, 'node_id': 'MDU6TGFiZWw0NzcwNDUwOTM=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/p1', 'name': 'p1', 'color': 'd93f0b', 'default': False, 'description': None}, {'id': 828666468, 'node_id': 'MDU6TGFiZWw4Mjg2NjY0Njg=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/release%20blocker', 'name': 'release blocker', 'color': '880000', 'default': False, 'description': None}]",closed,False,"{'login': 'clokep', 'id': 517124, 'node_id': 'MDQ6VXNlcjUxNzEyNA==', 'avatar_url': 'https://avatars2.githubusercontent.com/u/517124?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/clokep', 'html_url': 'https://github.com/clokep', 'followers_url': 'https://api.github.com/users/clokep/followers', 'following_url': 'https://api.github.com/users/clokep/following{/other_user}', 'gists_url': 'https://api.github.com/users/clokep/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/clokep/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/clokep/subscriptions', 'organizations_url': 'https://api.github.com/users/clokep/orgs', 'repos_url': 'https://api.github.com/users/clokep/repos', 'events_url': 'https://api.github.com/users/clokep/events{/privacy}', 'received_events_url': 'https://api.github.com/users/clokep/received_events', 'type': 'User', 'site_admin': False}","[{'login': 'clokep', 'id': 517124, 'node_id': 'MDQ6VXNlcjUxNzEyNA==', 'avatar_url': 'https://avatars2.githubusercontent.com/u/517124?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/clokep', 'html_url': 'https://github.com/clokep', 'followers_url': 'https://api.github.com/users/clokep/followers', 'following_url': 'https://api.github.com/users/clokep/following{/other_user}', 'gists_url': 'https://api.github.com/users/clokep/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/clokep/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/clokep/subscriptions', 'organizations_url': 'https://api.github.com/users/clokep/orgs', 'repos_url': 'https://api.github.com/users/clokep/repos', 'events_url': 'https://api.github.com/users/clokep/events{/privacy}', 'received_events_url': 'https://api.github.com/users/clokep/received_events', 'type': 'User', 'site_admin': False}]",,5,2020-05-12T09:52:25Z,2020-05-13T18:27:12Z,2020-05-13T18:27:12Z,MEMBER,,,"
### Description
Deactivating an account with ""Please forget all messages I have sent when my account is deactivated"" checked does not work. You get the error ""There was a problem communicating with the server. Please try again.""
Network tab show 401 for `deactivate`, then 200, then 403.
The spinner thing goes on forever (at least a couple of hours before I gave up)
I tested this with an almost new account with very few messages. A customer also reported this, awaiting rageshake from them. My rageshake is linked
https://newvector.zammad.com/#ticket/zoom/3216
(customer email copy-pasted to my rageshake)
### Steps to reproduce
- Create a matrix.org
- Settings
- Deactivate Account
- Check ""Please forget all messages I have sent when my account is deactivated""
- Enter password
- Click Continue
### Version information
Matrix.org, account deletion does work on my Modular server
- **Homeserver**: matrix.org
- **Version**: ""1.12.4 (b=matrix-org-hotfixes,309e30bae)""
- **Install method**:
- **Platform**:
",
818,https://api.github.com/repos/matrix-org/synapse/issues/7470,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7470/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7470/comments,https://api.github.com/repos/matrix-org/synapse/issues/7470/events,https://github.com/matrix-org/synapse/pull/7470,616515882,MDExOlB1bGxSZXF1ZXN0NDE2NjEwOTE3,7470,Fix new flake8 errors,"{'login': 'erikjohnston', 'id': 8428120, 'node_id': 'MDQ6VXNlcjg0MjgxMjA=', 'avatar_url': 'https://avatars0.githubusercontent.com/u/8428120?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/erikjohnston', 'html_url': 'https://github.com/erikjohnston', 'followers_url': 'https://api.github.com/users/erikjohnston/followers', 'following_url': 'https://api.github.com/users/erikjohnston/following{/other_user}', 'gists_url': 'https://api.github.com/users/erikjohnston/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/erikjohnston/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/erikjohnston/subscriptions', 'organizations_url': 'https://api.github.com/users/erikjohnston/orgs', 'repos_url': 'https://api.github.com/users/erikjohnston/repos', 'events_url': 'https://api.github.com/users/erikjohnston/events{/privacy}', 'received_events_url': 'https://api.github.com/users/erikjohnston/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,0,2020-05-12T09:45:23Z,2020-05-12T10:20:50Z,2020-05-12T10:20:49Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7470', 'html_url': 'https://github.com/matrix-org/synapse/pull/7470', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7470.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7470.patch'}",New error: https://www.flake8rules.com/rules/E741.html,
819,https://api.github.com/repos/matrix-org/synapse/issues/7469,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7469/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7469/comments,https://api.github.com/repos/matrix-org/synapse/issues/7469/events,https://github.com/matrix-org/synapse/issues/7469,616500843,MDU6SXNzdWU2MTY1MDA4NDM=,7469,Duplicate key violation when persisting read markers,"{'login': 'djschilling', 'id': 3503166, 'node_id': 'MDQ6VXNlcjM1MDMxNjY=', 'avatar_url': 'https://avatars0.githubusercontent.com/u/3503166?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/djschilling', 'html_url': 'https://github.com/djschilling', 'followers_url': 'https://api.github.com/users/djschilling/followers', 'following_url': 'https://api.github.com/users/djschilling/following{/other_user}', 'gists_url': 'https://api.github.com/users/djschilling/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/djschilling/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/djschilling/subscriptions', 'organizations_url': 'https://api.github.com/users/djschilling/orgs', 'repos_url': 'https://api.github.com/users/djschilling/repos', 'events_url': 'https://api.github.com/users/djschilling/events{/privacy}', 'received_events_url': 'https://api.github.com/users/djschilling/received_events', 'type': 'User', 'site_admin': False}","[{'id': 121086029, 'node_id': 'MDU6TGFiZWwxMjEwODYwMjk=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/bug', 'name': 'bug', 'color': 'fc2929', 'default': True, 'description': None}, {'id': 477050471, 'node_id': 'MDU6TGFiZWw0NzcwNTA0NzE=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/p3', 'name': 'p3', 'color': '0e8a16', 'default': False, 'description': None}]",closed,False,,[],,3,2020-05-12T09:22:39Z,2020-06-01T09:53:07Z,2020-06-01T09:53:07Z,NONE,,,"### Description
In the homeserver.log i have some requests with error code 500.
Most of them look like that:
2020-05-10 12:10:29,843 - synapse.access.http.8008 - 302 - INFO - POST-1674964 - 84.163.97.55 - 8008 - {@*****:chat.church.tools} Processed request: 0.024sec/0.003sec (0.005sec, 0.000sec) (0.002sec/0.014sec/1) 55B 500 ""POST /_matrix/client/r0/rooms/!*****%3Achat.church.tools/read_markers?access_token= HTTP/1.1"" ""ChurchTools/115 CFNetwork/1125.2 Darwin/19.4.0"" [0 dbevts]
One log message is more detailed. I'm not sure if they are related:
2020-05-10 12:10:29,844 - synapse.http.server - 110 - ERROR - POST-1674961 - Failed handle request via 'ReadMarkerRestServlet':
Traceback (most recent call last):
File ""/opt/venvs/matrix-synapse/lib/python3.6/site-packages/synapse/http/server.py"", line 78, in wrapped_request_handler
await h(self, request)
File ""/opt/venvs/matrix-synapse/lib/python3.6/site-packages/synapse/http/server.py"", line 331, in _async_render
callback_return = await callback_return
File ""/opt/venvs/matrix-synapse/lib/python3.6/site-packages/synapse/rest/client/v2_alpha/read_marker.py"", line 48, in on_POST
event_id=read_event_id,
File ""/opt/venvs/matrix-synapse/lib/python3.6/site-packages/synapse/handlers/receipts.py"", line 121, in received_client_receipt
is_new = await self._handle_new_receipts([receipt])
File ""/opt/venvs/matrix-synapse/lib/python3.6/site-packages/synapse/handlers/receipts.py"", line 79, in _handle_new_receipts
receipt.data,
File ""/opt/venvs/matrix-synapse/lib/python3.6/site-packages/twisted/internet/defer.py"", line 1416, in _inlineCallbacks
result = result.throwExceptionIntoGenerator(g)
File ""/opt/venvs/matrix-synapse/lib/python3.6/site-packages/twisted/python/failure.py"", line 512, in throwExceptionIntoGenerator
return g.throw(self.type, self.value, self.tb)
File ""/opt/venvs/matrix-synapse/lib/python3.6/site-packages/synapse/storage/data_stores/main/receipts.py"", line 473, in insert_receipt
stream_id=stream_id,
File ""/opt/venvs/matrix-synapse/lib/python3.6/site-packages/twisted/internet/defer.py"", line 1416, in _inlineCallbacks
result = result.throwExceptionIntoGenerator(g)
File ""/opt/venvs/matrix-synapse/lib/python3.6/site-packages/twisted/python/failure.py"", line 512, in throwExceptionIntoGenerator
return g.throw(self.type, self.value, self.tb)
File ""/opt/venvs/matrix-synapse/lib/python3.6/site-packages/synapse/storage/database.py"", line 524, in runInteraction
**kwargs
File ""/opt/venvs/matrix-synapse/lib/python3.6/site-packages/twisted/internet/defer.py"", line 1416, in _inlineCallbacks
result = result.throwExceptionIntoGenerator(g)
File ""/opt/venvs/matrix-synapse/lib/python3.6/site-packages/twisted/python/failure.py"", line 512, in throwExceptionIntoGenerator
return g.throw(self.type, self.value, self.tb)
File ""/opt/venvs/matrix-synapse/lib/python3.6/site-packages/synapse/storage/database.py"", line 574, in runWithConnection
self._db_pool.runWithConnection(inner_func, *args, **kwargs)
File ""/opt/venvs/matrix-synapse/lib/python3.6/site-packages/twisted/python/threadpool.py"", line 250, in inContext
result = inContext.theWork()
File ""/opt/venvs/matrix-synapse/lib/python3.6/site-packages/twisted/python/threadpool.py"", line 266, in
inContext.theWork = lambda: context.call(ctx, func, *args, **kw)
File ""/opt/venvs/matrix-synapse/lib/python3.6/site-packages/twisted/python/context.py"", line 122, in callWithContext
return self.currentContext().callWithContext(ctx, func, *args, **kw)
File ""/opt/venvs/matrix-synapse/lib/python3.6/site-packages/twisted/python/context.py"", line 85, in callWithContext
return func(*args,**kw)
File ""/opt/venvs/matrix-synapse/lib/python3.6/site-packages/twisted/enterprise/adbapi.py"", line 306, in _runWithConnection
compat.reraise(excValue, excTraceback)
File ""/opt/venvs/matrix-synapse/lib/python3.6/site-packages/twisted/python/compat.py"", line 464, in reraise
raise exception.with_traceback(traceback)
File ""/opt/venvs/matrix-synapse/lib/python3.6/site-packages/twisted/enterprise/adbapi.py"", line 297, in _runWithConnection
result = func(conn, *args, **kw)
File ""/opt/venvs/matrix-synapse/lib/python3.6/site-packages/synapse/storage/database.py"", line 571, in inner_func
return func(conn, *args, **kwargs)
File ""/opt/venvs/matrix-synapse/lib/python3.6/site-packages/synapse/storage/database.py"", line 407, in new_transaction
r = func(cursor, *args, **kwargs)
File ""/opt/venvs/matrix-synapse/lib/python3.6/site-packages/synapse/storage/data_stores/main/receipts.py"", line 413, in insert_linearized_receipt_txn
""data"": json.dumps(data),
File ""/opt/venvs/matrix-synapse/lib/python3.6/site-packages/synapse/storage/database.py"", line 652, in simple_insert_txn
txn.execute(sql, vals)
File ""/opt/venvs/matrix-synapse/lib/python3.6/site-packages/synapse/storage/database.py"", line 199, in execute
self._do_execute(self.txn.execute, sql, *args)
File ""/opt/venvs/matrix-synapse/lib/python3.6/site-packages/synapse/storage/database.py"", line 225, in _do_execute
return func(sql, *args)
psycopg2.errors.UniqueViolation: duplicate key value violates unique constraint ""receipts_linearized_uniqueness""
DETAIL: Key (room_id, receipt_type, user_id)=(!*****.church.tools, m.read, @*****:chat.church.tools) already exists.
These errors happen sometime but i'm not able to reproduce them by myself.
I guess it's a bug, because it is a 500 internal server error.
### Version information
What version of Synapse is running?
- **Version**: 1.12.3
- **Install method**: package manager
- **Platform**: vm",
820,https://api.github.com/repos/matrix-org/synapse/issues/7468,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7468/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7468/comments,https://api.github.com/repos/matrix-org/synapse/issues/7468/events,https://github.com/matrix-org/synapse/pull/7468,616240386,MDExOlB1bGxSZXF1ZXN0NDE2MzkwOTc4,7468,Fix snap building,"{'login': 'woutervb', 'id': 1595768, 'node_id': 'MDQ6VXNlcjE1OTU3Njg=', 'avatar_url': 'https://avatars2.githubusercontent.com/u/1595768?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/woutervb', 'html_url': 'https://github.com/woutervb', 'followers_url': 'https://api.github.com/users/woutervb/followers', 'following_url': 'https://api.github.com/users/woutervb/following{/other_user}', 'gists_url': 'https://api.github.com/users/woutervb/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/woutervb/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/woutervb/subscriptions', 'organizations_url': 'https://api.github.com/users/woutervb/orgs', 'repos_url': 'https://api.github.com/users/woutervb/repos', 'events_url': 'https://api.github.com/users/woutervb/events{/privacy}', 'received_events_url': 'https://api.github.com/users/woutervb/received_events', 'type': 'User', 'site_admin': False}","[{'id': 955488836, 'node_id': 'MDU6TGFiZWw5NTU0ODg4MzY=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/awaiting%20changes', 'name': 'awaiting changes', 'color': 'cfe886', 'default': False, 'description': ''}]",closed,False,"{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}","[{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}]",,8,2020-05-11T22:56:36Z,2020-07-02T16:04:15Z,2020-07-02T16:04:15Z,NONE,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7468', 'html_url': 'https://github.com/matrix-org/synapse/pull/7468', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7468.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7468.patch'}","### Pull Request Checklist
* [x] Pull request is based on the develop branch
* [x] Pull request includes a [changelog file](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#changelog).
* [x] Pull request includes a [sign off](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#sign-off)
* [x] Code style is correct (run the [linters](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#code-style))
",
821,https://api.github.com/repos/matrix-org/synapse/issues/7467,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7467/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7467/comments,https://api.github.com/repos/matrix-org/synapse/issues/7467/events,https://github.com/matrix-org/synapse/pull/7467,616239827,MDExOlB1bGxSZXF1ZXN0NDE2MzkwNTA5,7467,Fix snap building,"{'login': 'woutervb', 'id': 1595768, 'node_id': 'MDQ6VXNlcjE1OTU3Njg=', 'avatar_url': 'https://avatars2.githubusercontent.com/u/1595768?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/woutervb', 'html_url': 'https://github.com/woutervb', 'followers_url': 'https://api.github.com/users/woutervb/followers', 'following_url': 'https://api.github.com/users/woutervb/following{/other_user}', 'gists_url': 'https://api.github.com/users/woutervb/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/woutervb/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/woutervb/subscriptions', 'organizations_url': 'https://api.github.com/users/woutervb/orgs', 'repos_url': 'https://api.github.com/users/woutervb/repos', 'events_url': 'https://api.github.com/users/woutervb/events{/privacy}', 'received_events_url': 'https://api.github.com/users/woutervb/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,0,2020-05-11T22:55:14Z,2020-05-11T22:55:40Z,2020-05-11T22:55:40Z,NONE,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7467', 'html_url': 'https://github.com/matrix-org/synapse/pull/7467', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7467.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7467.patch'}","### Pull Request Checklist
* [x] Pull request is based on the develop branch
* [ ] Pull request includes a [changelog file](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#changelog).
* [x] Pull request includes a [sign off](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#sign-off)
* [x] Code style is correct (run the [linters](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#code-style))
",
822,https://api.github.com/repos/matrix-org/synapse/issues/7466,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7466/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7466/comments,https://api.github.com/repos/matrix-org/synapse/issues/7466/events,https://github.com/matrix-org/synapse/issues/7466,616237130,MDU6SXNzdWU2MTYyMzcxMzA=,7466,user_directory.notify_new_event and stats.notify_new_event exceptions,"{'login': 'krystiancha', 'id': 2893599, 'node_id': 'MDQ6VXNlcjI4OTM1OTk=', 'avatar_url': 'https://avatars0.githubusercontent.com/u/2893599?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/krystiancha', 'html_url': 'https://github.com/krystiancha', 'followers_url': 'https://api.github.com/users/krystiancha/followers', 'following_url': 'https://api.github.com/users/krystiancha/following{/other_user}', 'gists_url': 'https://api.github.com/users/krystiancha/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/krystiancha/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/krystiancha/subscriptions', 'organizations_url': 'https://api.github.com/users/krystiancha/orgs', 'repos_url': 'https://api.github.com/users/krystiancha/repos', 'events_url': 'https://api.github.com/users/krystiancha/events{/privacy}', 'received_events_url': 'https://api.github.com/users/krystiancha/received_events', 'type': 'User', 'site_admin': False}","[{'id': 121086029, 'node_id': 'MDU6TGFiZWwxMjEwODYwMjk=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/bug', 'name': 'bug', 'color': 'fc2929', 'default': True, 'description': None}, {'id': 1311133228, 'node_id': 'MDU6TGFiZWwxMzExMTMzMjI4', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/info-needed', 'name': 'info-needed', 'color': 'a1e8ea', 'default': False, 'description': ''}]",closed,False,,[],,4,2020-05-11T22:48:32Z,2020-07-14T16:38:15Z,2020-07-14T16:38:15Z,NONE,,,"### Description
I changed the user directory configuration. I flipped the `search_all_users` option to true.
Then, as the comment in config says, I ran the query linked in [this doc](https://github.com/matrix-org/synapse/blob/master/docs/user_directory.md).
Now I get exceptions in my synapse logs.
https://gist.github.com/krystiancha/45d78bd0b4436f054090328a72186a7b
### Steps to reproduce
- change `search_all_users` option to true
- run the queries from the doc linked above
- restart synapse
### Version information
- **Homeserver**: self hosted
If not matrix.org:
- **Version**: 1.12.4
- **Install method**: pacman
- **Platform**: Arch Linux
",
823,https://api.github.com/repos/matrix-org/synapse/issues/7465,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7465/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7465/comments,https://api.github.com/repos/matrix-org/synapse/issues/7465/events,https://github.com/matrix-org/synapse/pull/7465,616082591,MDExOlB1bGxSZXF1ZXN0NDE2MjY0MDkx,7465,Prevent 0-member/null room_version rooms from appearing in group room queries,"{'login': 'anoadragon453', 'id': 1342360, 'node_id': 'MDQ6VXNlcjEzNDIzNjA=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1342360?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/anoadragon453', 'html_url': 'https://github.com/anoadragon453', 'followers_url': 'https://api.github.com/users/anoadragon453/followers', 'following_url': 'https://api.github.com/users/anoadragon453/following{/other_user}', 'gists_url': 'https://api.github.com/users/anoadragon453/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/anoadragon453/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/anoadragon453/subscriptions', 'organizations_url': 'https://api.github.com/users/anoadragon453/orgs', 'repos_url': 'https://api.github.com/users/anoadragon453/repos', 'events_url': 'https://api.github.com/users/anoadragon453/events{/privacy}', 'received_events_url': 'https://api.github.com/users/anoadragon453/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,"{'login': 'anoadragon453', 'id': 1342360, 'node_id': 'MDQ6VXNlcjEzNDIzNjA=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1342360?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/anoadragon453', 'html_url': 'https://github.com/anoadragon453', 'followers_url': 'https://api.github.com/users/anoadragon453/followers', 'following_url': 'https://api.github.com/users/anoadragon453/following{/other_user}', 'gists_url': 'https://api.github.com/users/anoadragon453/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/anoadragon453/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/anoadragon453/subscriptions', 'organizations_url': 'https://api.github.com/users/anoadragon453/orgs', 'repos_url': 'https://api.github.com/users/anoadragon453/repos', 'events_url': 'https://api.github.com/users/anoadragon453/events{/privacy}', 'received_events_url': 'https://api.github.com/users/anoadragon453/received_events', 'type': 'User', 'site_admin': False}","[{'login': 'anoadragon453', 'id': 1342360, 'node_id': 'MDQ6VXNlcjEzNDIzNjA=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1342360?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/anoadragon453', 'html_url': 'https://github.com/anoadragon453', 'followers_url': 'https://api.github.com/users/anoadragon453/followers', 'following_url': 'https://api.github.com/users/anoadragon453/following{/other_user}', 'gists_url': 'https://api.github.com/users/anoadragon453/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/anoadragon453/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/anoadragon453/subscriptions', 'organizations_url': 'https://api.github.com/users/anoadragon453/orgs', 'repos_url': 'https://api.github.com/users/anoadragon453/repos', 'events_url': 'https://api.github.com/users/anoadragon453/events{/privacy}', 'received_events_url': 'https://api.github.com/users/anoadragon453/received_events', 'type': 'User', 'site_admin': False}]",,0,2020-05-11T18:16:24Z,2020-05-15T16:17:44Z,2020-05-15T16:17:43Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7465', 'html_url': 'https://github.com/matrix-org/synapse/pull/7465', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7465.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7465.patch'}","Fixes https://github.com/matrix-org/synapse/issues/4891
Prevents group servlets from acting on rooms without any members (dead rooms) or with a NULL/empty `room_version` string.
The added docstrings may help in our community rewrite later on as we'll have a better understanding of the current community functionality.
TODO:
- [x] Also check `local_users_in_room` is not 0.
I'm not sure whether this is a plaster on an existing problem or not, but either way it's a quick fix to a communities problems that will eventually be written over with comms v2 anyways.",
824,https://api.github.com/repos/matrix-org/synapse/issues/7464,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7464/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7464/comments,https://api.github.com/repos/matrix-org/synapse/issues/7464/events,https://github.com/matrix-org/synapse/issues/7464,616040277,MDU6SXNzdWU2MTYwNDAyNzc=,7464,Synapse fails silently if postgresql connection fails,"{'login': 'DataBeaver', 'id': 1126732, 'node_id': 'MDQ6VXNlcjExMjY3MzI=', 'avatar_url': 'https://avatars0.githubusercontent.com/u/1126732?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/DataBeaver', 'html_url': 'https://github.com/DataBeaver', 'followers_url': 'https://api.github.com/users/DataBeaver/followers', 'following_url': 'https://api.github.com/users/DataBeaver/following{/other_user}', 'gists_url': 'https://api.github.com/users/DataBeaver/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/DataBeaver/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/DataBeaver/subscriptions', 'organizations_url': 'https://api.github.com/users/DataBeaver/orgs', 'repos_url': 'https://api.github.com/users/DataBeaver/repos', 'events_url': 'https://api.github.com/users/DataBeaver/events{/privacy}', 'received_events_url': 'https://api.github.com/users/DataBeaver/received_events', 'type': 'User', 'site_admin': False}",[],open,False,,[],,6,2020-05-11T17:08:51Z,2020-05-19T19:10:23Z,,NONE,,,"### Description
If the database parameters are incorrect such that synapse can't connect to postgresql, it will exit without printing any kind of error message. The log shows ""setting up"" as the last line.
### Steps to reproduce
- Have an incorrect database configuration (in my case I had no matching entry in pg_hba.conf so postgresql was refusing the connection)
- Try to start synapse
I would expect to see some kind of error message pointing me at the database configuration, not a silent exit.
### Version information
Synapse 1.12.4, installed from Debian's (unstable/sid) repository.",
825,https://api.github.com/repos/matrix-org/synapse/issues/7463,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7463/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7463/comments,https://api.github.com/repos/matrix-org/synapse/issues/7463/events,https://github.com/matrix-org/synapse/pull/7463,615488748,MDExOlB1bGxSZXF1ZXN0NDE1Nzg5ODE0,7463,Add Caddy 2 example to reverse proxy doc,"{'login': 'jpeeler', 'id': 834161, 'node_id': 'MDQ6VXNlcjgzNDE2MQ==', 'avatar_url': 'https://avatars1.githubusercontent.com/u/834161?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/jpeeler', 'html_url': 'https://github.com/jpeeler', 'followers_url': 'https://api.github.com/users/jpeeler/followers', 'following_url': 'https://api.github.com/users/jpeeler/following{/other_user}', 'gists_url': 'https://api.github.com/users/jpeeler/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/jpeeler/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/jpeeler/subscriptions', 'organizations_url': 'https://api.github.com/users/jpeeler/orgs', 'repos_url': 'https://api.github.com/users/jpeeler/repos', 'events_url': 'https://api.github.com/users/jpeeler/events{/privacy}', 'received_events_url': 'https://api.github.com/users/jpeeler/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,0,2020-05-10T22:18:57Z,2020-05-15T13:36:02Z,2020-05-15T13:36:02Z,CONTRIBUTOR,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7463', 'html_url': 'https://github.com/matrix-org/synapse/pull/7463', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7463.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7463.patch'}","The specific headers that are passed using this new configuration format are Host and X-Forwarded-For, which should be all that's required (https://caddy.community/t/v2-reverse-proxy-transparent/6480/8).
FWIW, it sounds like Caddy 1 is going to become unsupported in the very near future.
### Pull Request Checklist
* [x] Pull request is based on the develop branch
* [x] Pull request includes a [changelog file](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#changelog). The entry should:
- Be a short description of your change which makes sense to users. ""Fixed a bug that prevented receiving messages from other servers."" instead of ""Moved X method from `EventStore` to `EventWorkerStore`."".
- Use markdown where necessary, mostly for `code blocks`.
- End with either a period (.) or an exclamation mark (!).
- Start with a capital letter.
* [x] Pull request includes a [sign off](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#sign-off)
* [x] Code style is correct (run the [linters](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#code-style))
",
826,https://api.github.com/repos/matrix-org/synapse/issues/7462,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7462/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7462/comments,https://api.github.com/repos/matrix-org/synapse/issues/7462/events,https://github.com/matrix-org/synapse/issues/7462,615255710,MDU6SXNzdWU2MTUyNTU3MTA=,7462,restore forbidden room,"{'login': 'oeai', 'id': 2557665, 'node_id': 'MDQ6VXNlcjI1NTc2NjU=', 'avatar_url': 'https://avatars3.githubusercontent.com/u/2557665?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/oeai', 'html_url': 'https://github.com/oeai', 'followers_url': 'https://api.github.com/users/oeai/followers', 'following_url': 'https://api.github.com/users/oeai/following{/other_user}', 'gists_url': 'https://api.github.com/users/oeai/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/oeai/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/oeai/subscriptions', 'organizations_url': 'https://api.github.com/users/oeai/orgs', 'repos_url': 'https://api.github.com/users/oeai/repos', 'events_url': 'https://api.github.com/users/oeai/events{/privacy}', 'received_events_url': 'https://api.github.com/users/oeai/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,2,2020-05-09T20:39:00Z,2020-05-11T21:16:43Z,2020-05-11T19:13:32Z,NONE,,,"i've made a room public, then i decided to clean it with new text and deleted the room,
it was riot.im and it was moved to history, then i press forget and it was removed.
But it was written in my community and the community room list is now stuck and not resolving.
Now i try to join the room - no luck
> request failed: CORS request rejected:
i wanted to create the room once again to solve it - the room name is not free
i did relog, tried with html client - no way.
i want to restore the room and join it / change name or make the room name free somehow
i need my community room list working (is it resolving by name or UID?)
> room previews are disabled (M_FORBIDDEN)
",
827,https://api.github.com/repos/matrix-org/synapse/issues/7461,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7461/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7461/comments,https://api.github.com/repos/matrix-org/synapse/issues/7461/events,https://github.com/matrix-org/synapse/issues/7461,614934101,MDU6SXNzdWU2MTQ5MzQxMDE=,7461,Room directory member count is wrong and overcounts.,"{'login': 'ara4n', 'id': 1294269, 'node_id': 'MDQ6VXNlcjEyOTQyNjk=', 'avatar_url': 'https://avatars2.githubusercontent.com/u/1294269?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/ara4n', 'html_url': 'https://github.com/ara4n', 'followers_url': 'https://api.github.com/users/ara4n/followers', 'following_url': 'https://api.github.com/users/ara4n/following{/other_user}', 'gists_url': 'https://api.github.com/users/ara4n/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/ara4n/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/ara4n/subscriptions', 'organizations_url': 'https://api.github.com/users/ara4n/orgs', 'repos_url': 'https://api.github.com/users/ara4n/repos', 'events_url': 'https://api.github.com/users/ara4n/events{/privacy}', 'received_events_url': 'https://api.github.com/users/ara4n/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,3,2020-05-08T19:19:29Z,2020-05-11T17:43:52Z,2020-05-11T17:43:52Z,MEMBER,,,"This must be a dup, but i can't find the original one.
Sounds like we increment the running total of the member count used by the room directory every time we see a m.room.member with membership join - i.e. counting nick changes as joins. We should only count if they were a transition from parted or null to join.",
828,https://api.github.com/repos/matrix-org/synapse/issues/7460,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7460/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7460/comments,https://api.github.com/repos/matrix-org/synapse/issues/7460/events,https://github.com/matrix-org/synapse/pull/7460,614887101,MDExOlB1bGxSZXF1ZXN0NDE1MzUxMTAy,7460,Convert search code to async/await.,"{'login': 'clokep', 'id': 517124, 'node_id': 'MDQ6VXNlcjUxNzEyNA==', 'avatar_url': 'https://avatars2.githubusercontent.com/u/517124?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/clokep', 'html_url': 'https://github.com/clokep', 'followers_url': 'https://api.github.com/users/clokep/followers', 'following_url': 'https://api.github.com/users/clokep/following{/other_user}', 'gists_url': 'https://api.github.com/users/clokep/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/clokep/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/clokep/subscriptions', 'organizations_url': 'https://api.github.com/users/clokep/orgs', 'repos_url': 'https://api.github.com/users/clokep/repos', 'events_url': 'https://api.github.com/users/clokep/events{/privacy}', 'received_events_url': 'https://api.github.com/users/clokep/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,0,2020-05-08T17:47:25Z,2020-05-11T19:12:41Z,2020-05-11T19:12:40Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7460', 'html_url': 'https://github.com/matrix-org/synapse/pull/7460', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7460.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7460.patch'}",Converts the search handler to async/await.,
829,https://api.github.com/repos/matrix-org/synapse/issues/7459,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7459/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7459/comments,https://api.github.com/repos/matrix-org/synapse/issues/7459/events,https://github.com/matrix-org/synapse/pull/7459,614883786,MDExOlB1bGxSZXF1ZXN0NDE1MzQ4NDg1,7459,Convert federation handler to async/await.,"{'login': 'clokep', 'id': 517124, 'node_id': 'MDQ6VXNlcjUxNzEyNA==', 'avatar_url': 'https://avatars2.githubusercontent.com/u/517124?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/clokep', 'html_url': 'https://github.com/clokep', 'followers_url': 'https://api.github.com/users/clokep/followers', 'following_url': 'https://api.github.com/users/clokep/following{/other_user}', 'gists_url': 'https://api.github.com/users/clokep/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/clokep/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/clokep/subscriptions', 'organizations_url': 'https://api.github.com/users/clokep/orgs', 'repos_url': 'https://api.github.com/users/clokep/repos', 'events_url': 'https://api.github.com/users/clokep/events{/privacy}', 'received_events_url': 'https://api.github.com/users/clokep/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,0,2020-05-08T17:40:53Z,2020-05-11T19:12:48Z,2020-05-11T19:12:47Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7459', 'html_url': 'https://github.com/matrix-org/synapse/pull/7459', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7459.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7459.patch'}",This converts the remaining bits of the federation handler code to async/await.,
830,https://api.github.com/repos/matrix-org/synapse/issues/7458,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7458/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7458/comments,https://api.github.com/repos/matrix-org/synapse/issues/7458/events,https://github.com/matrix-org/synapse/pull/7458,614758174,MDExOlB1bGxSZXF1ZXN0NDE1MjQ3NDA0,7458,Update documentation about SSO mapping providers,"{'login': 'clokep', 'id': 517124, 'node_id': 'MDQ6VXNlcjUxNzEyNA==', 'avatar_url': 'https://avatars2.githubusercontent.com/u/517124?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/clokep', 'html_url': 'https://github.com/clokep', 'followers_url': 'https://api.github.com/users/clokep/followers', 'following_url': 'https://api.github.com/users/clokep/following{/other_user}', 'gists_url': 'https://api.github.com/users/clokep/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/clokep/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/clokep/subscriptions', 'organizations_url': 'https://api.github.com/users/clokep/orgs', 'repos_url': 'https://api.github.com/users/clokep/repos', 'events_url': 'https://api.github.com/users/clokep/events{/privacy}', 'received_events_url': 'https://api.github.com/users/clokep/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,1,2020-05-08T13:54:55Z,2020-05-12T14:51:10Z,2020-05-12T14:51:09Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7458', 'html_url': 'https://github.com/matrix-org/synapse/pull/7458', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7458.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7458.patch'}","This updates the documentation for SSO mapping providers by:
* Adding information about OpenID (#7256)
* Updating the SAML information with a variety of changes that were made.
The first commit renames the file, the second makes the changes. Unfortunately GitHub seems to have made a mess of the diff and just shows the file as all new.",
831,https://api.github.com/repos/matrix-org/synapse/issues/7457,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7457/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7457/comments,https://api.github.com/repos/matrix-org/synapse/issues/7457/events,https://github.com/matrix-org/synapse/pull/7457,614716085,MDExOlB1bGxSZXF1ZXN0NDE1MjEzMzE2,7457,Support UI Authentication for OpenID Connect accounts,"{'login': 'clokep', 'id': 517124, 'node_id': 'MDQ6VXNlcjUxNzEyNA==', 'avatar_url': 'https://avatars2.githubusercontent.com/u/517124?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/clokep', 'html_url': 'https://github.com/clokep', 'followers_url': 'https://api.github.com/users/clokep/followers', 'following_url': 'https://api.github.com/users/clokep/following{/other_user}', 'gists_url': 'https://api.github.com/users/clokep/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/clokep/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/clokep/subscriptions', 'organizations_url': 'https://api.github.com/users/clokep/orgs', 'repos_url': 'https://api.github.com/users/clokep/repos', 'events_url': 'https://api.github.com/users/clokep/events{/privacy}', 'received_events_url': 'https://api.github.com/users/clokep/received_events', 'type': 'User', 'site_admin': False}","[{'id': 828666468, 'node_id': 'MDU6TGFiZWw4Mjg2NjY0Njg=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/release%20blocker', 'name': 'release blocker', 'color': '880000', 'default': False, 'description': None}]",closed,False,,[],,3,2020-05-08T12:35:58Z,2020-05-15T16:26:05Z,2020-05-15T16:26:03Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7457', 'html_url': 'https://github.com/matrix-org/synapse/pull/7457', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7457.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7457.patch'}","This is similar to #7102 / #7186, but for OpenID (added in #7256).
It also cleans up a little bit of code to make things consistent between the various SSO workflows.
CC @sandhose",
832,https://api.github.com/repos/matrix-org/synapse/issues/7456,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7456/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7456/comments,https://api.github.com/repos/matrix-org/synapse/issues/7456/events,https://github.com/matrix-org/synapse/issues/7456,614706725,MDU6SXNzdWU2MTQ3MDY3MjU=,7456,UISIs between mozilla.org and matrix.org,"{'login': 'ara4n', 'id': 1294269, 'node_id': 'MDQ6VXNlcjEyOTQyNjk=', 'avatar_url': 'https://avatars2.githubusercontent.com/u/1294269?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/ara4n', 'html_url': 'https://github.com/ara4n', 'followers_url': 'https://api.github.com/users/ara4n/followers', 'following_url': 'https://api.github.com/users/ara4n/following{/other_user}', 'gists_url': 'https://api.github.com/users/ara4n/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/ara4n/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/ara4n/subscriptions', 'organizations_url': 'https://api.github.com/users/ara4n/orgs', 'repos_url': 'https://api.github.com/users/ara4n/repos', 'events_url': 'https://api.github.com/users/ara4n/events{/privacy}', 'received_events_url': 'https://api.github.com/users/ara4n/received_events', 'type': 'User', 'site_admin': False}","[{'id': 477045093, 'node_id': 'MDU6TGFiZWw0NzcwNDUwOTM=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/p1', 'name': 'p1', 'color': 'd93f0b', 'default': False, 'description': None}, {'id': 1828503314, 'node_id': 'MDU6TGFiZWwxODI4NTAzMzE0', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/uisi', 'name': 'uisi', 'color': 'def495', 'default': False, 'description': ''}]",closed,False,,[],,3,2020-05-08T12:16:29Z,2020-07-21T10:45:40Z,2020-07-21T10:45:39Z,MEMBER,,,"Around 19:15 UK time on May 7th 2020 the mozilla.org server had a glitch with its federation sender and sync 4 restarting:
![image](https://user-images.githubusercontent.com/1294269/81404608-d917e880-912d-11ea-8b4c-0f56c1863f47.png)
E2EE messages sent from mozilla.org users to matrix.org users in that timeframe were undecryptable and never recovered, which feels very worrying. https://github.com/vector-im/riot-web/issues/13587 is the Riot side of it.",
833,https://api.github.com/repos/matrix-org/synapse/issues/7455,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7455/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7455/comments,https://api.github.com/repos/matrix-org/synapse/issues/7455/events,https://github.com/matrix-org/synapse/pull/7455,614228442,MDExOlB1bGxSZXF1ZXN0NDE0ODI2MTAx,7455,Rework UI Auth session validation,"{'login': 'clokep', 'id': 517124, 'node_id': 'MDQ6VXNlcjUxNzEyNA==', 'avatar_url': 'https://avatars2.githubusercontent.com/u/517124?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/clokep', 'html_url': 'https://github.com/clokep', 'followers_url': 'https://api.github.com/users/clokep/followers', 'following_url': 'https://api.github.com/users/clokep/following{/other_user}', 'gists_url': 'https://api.github.com/users/clokep/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/clokep/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/clokep/subscriptions', 'organizations_url': 'https://api.github.com/users/clokep/orgs', 'repos_url': 'https://api.github.com/users/clokep/repos', 'events_url': 'https://api.github.com/users/clokep/events{/privacy}', 'received_events_url': 'https://api.github.com/users/clokep/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,2,2020-05-07T17:36:23Z,2020-05-08T20:09:00Z,2020-05-08T20:08:59Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7455', 'html_url': 'https://github.com/matrix-org/synapse/pull/7455', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7455.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7455.patch'}","This reworks the UI Auth session validation per #7452.
* The registration endpoint is less strict on ensuring that the given parameters have changed during registration. This is a backwards compatibility path for clients.
* The client dict gets persisted at each step of the authentication for registration.
* The UI Auth tests are heavily modified to clean them up and add a few other scenarios.
It is worth comparing this code to the v1.12.4:
https://github.com/matrix-org/synapse/blob/release-v1.12.4/synapse/handlers/auth.py#L265-L278
The overall structure is much more similar now, but sometimes we validate and sometimes we persist.",
834,https://api.github.com/repos/matrix-org/synapse/issues/7454,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7454/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7454/comments,https://api.github.com/repos/matrix-org/synapse/issues/7454/events,https://github.com/matrix-org/synapse/pull/7454,614177982,MDExOlB1bGxSZXF1ZXN0NDE0Nzg0Njky,7454,Fix errors from malformed log line,"{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}","[{'id': 828666468, 'node_id': 'MDU6TGFiZWw4Mjg2NjY0Njg=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/release%20blocker', 'name': 'release blocker', 'color': '880000', 'default': False, 'description': None}]",closed,False,,[],,0,2020-05-07T16:12:04Z,2020-05-07T18:51:40Z,2020-05-07T18:51:39Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7454', 'html_url': 'https://github.com/matrix-org/synapse/pull/7454', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7454.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7454.patch'}",,
835,https://api.github.com/repos/matrix-org/synapse/issues/7453,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7453/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7453/comments,https://api.github.com/repos/matrix-org/synapse/issues/7453/events,https://github.com/matrix-org/synapse/pull/7453,614168520,MDExOlB1bGxSZXF1ZXN0NDE0Nzc3MDM4,7453,Retry to sync out of sync device lists,"{'login': 'babolivier', 'id': 5547783, 'node_id': 'MDQ6VXNlcjU1NDc3ODM=', 'avatar_url': 'https://avatars3.githubusercontent.com/u/5547783?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/babolivier', 'html_url': 'https://github.com/babolivier', 'followers_url': 'https://api.github.com/users/babolivier/followers', 'following_url': 'https://api.github.com/users/babolivier/following{/other_user}', 'gists_url': 'https://api.github.com/users/babolivier/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/babolivier/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/babolivier/subscriptions', 'organizations_url': 'https://api.github.com/users/babolivier/orgs', 'repos_url': 'https://api.github.com/users/babolivier/repos', 'events_url': 'https://api.github.com/users/babolivier/events{/privacy}', 'received_events_url': 'https://api.github.com/users/babolivier/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,7,2020-05-07T15:58:16Z,2020-05-21T15:41:15Z,2020-05-21T15:41:14Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7453', 'html_url': 'https://github.com/matrix-org/synapse/pull/7453', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7453.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7453.patch'}","When a call to `user_device_resync` fails, we don't currently mark the remote user's device list as out of sync, nor do we retry to sync it.
https://github.com/matrix-org/synapse/pull/6776 introduced some code infrastructure to mark device lists as stale/out of sync.
This PR uses that code infrastructure to mark device lists as out of sync if processing an incoming device list update makes the device handler realise that the device list is out of sync, but we can't resync right now.
It also adds a looping call to retry all failed resync every 30s. I'm not entirely sure about that retry logic right now so would like some opinions on it. It shouldn't cause too much spam in the logs as I removed the ""Failed to handle device list update for..."" warning logs when catching `NotRetryingDestination`.
Fixes #7418
~TODO: Write some tests~",
836,https://api.github.com/repos/matrix-org/synapse/issues/7452,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7452/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7452/comments,https://api.github.com/repos/matrix-org/synapse/issues/7452/events,https://github.com/matrix-org/synapse/issues/7452,614156615,MDU6SXNzdWU2MTQxNTY2MTU=,7452,Registration broken during UI Auth process,"{'login': 'clokep', 'id': 517124, 'node_id': 'MDQ6VXNlcjUxNzEyNA==', 'avatar_url': 'https://avatars2.githubusercontent.com/u/517124?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/clokep', 'html_url': 'https://github.com/clokep', 'followers_url': 'https://api.github.com/users/clokep/followers', 'following_url': 'https://api.github.com/users/clokep/following{/other_user}', 'gists_url': 'https://api.github.com/users/clokep/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/clokep/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/clokep/subscriptions', 'organizations_url': 'https://api.github.com/users/clokep/orgs', 'repos_url': 'https://api.github.com/users/clokep/repos', 'events_url': 'https://api.github.com/users/clokep/events{/privacy}', 'received_events_url': 'https://api.github.com/users/clokep/received_events', 'type': 'User', 'site_admin': False}","[{'id': 828666468, 'node_id': 'MDU6TGFiZWw4Mjg2NjY0Njg=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/release%20blocker', 'name': 'release blocker', 'color': '880000', 'default': False, 'description': None}]",closed,False,"{'login': 'clokep', 'id': 517124, 'node_id': 'MDQ6VXNlcjUxNzEyNA==', 'avatar_url': 'https://avatars2.githubusercontent.com/u/517124?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/clokep', 'html_url': 'https://github.com/clokep', 'followers_url': 'https://api.github.com/users/clokep/followers', 'following_url': 'https://api.github.com/users/clokep/following{/other_user}', 'gists_url': 'https://api.github.com/users/clokep/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/clokep/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/clokep/subscriptions', 'organizations_url': 'https://api.github.com/users/clokep/orgs', 'repos_url': 'https://api.github.com/users/clokep/repos', 'events_url': 'https://api.github.com/users/clokep/events{/privacy}', 'received_events_url': 'https://api.github.com/users/clokep/received_events', 'type': 'User', 'site_admin': False}","[{'login': 'clokep', 'id': 517124, 'node_id': 'MDQ6VXNlcjUxNzEyNA==', 'avatar_url': 'https://avatars2.githubusercontent.com/u/517124?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/clokep', 'html_url': 'https://github.com/clokep', 'followers_url': 'https://api.github.com/users/clokep/followers', 'following_url': 'https://api.github.com/users/clokep/following{/other_user}', 'gists_url': 'https://api.github.com/users/clokep/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/clokep/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/clokep/subscriptions', 'organizations_url': 'https://api.github.com/users/clokep/orgs', 'repos_url': 'https://api.github.com/users/clokep/repos', 'events_url': 'https://api.github.com/users/clokep/events{/privacy}', 'received_events_url': 'https://api.github.com/users/clokep/received_events', 'type': 'User', 'site_admin': False}]",,1,2020-05-07T15:41:27Z,2020-05-08T20:09:11Z,2020-05-08T20:09:11Z,MEMBER,,,"As part of #5667 we made quite a few changes to the UI Authentication process and some of these changes broke registration for riot-ios and riot-android (riotx was not affected). When attempting to register with those the user would be shown the ""Requested operation has changed during UI authentication session"" error added in #7068. Additionally #7268 made some changes which caused an updated client dict to be ignored.
This was noticed after a deploy on May 1 to matrix.org.
The specification is somewhat unclear whether the parameters in the client dict should be provided for each request during registration (a UI authentication cycle), although it [does suggest they should be](https://matrix.org/docs/spec/client_server/r0.6.0#user-interactive-authentication-api):
> It does this by resubmitting the same request with the addition of an `auth` key in the object that it submits.
",
837,https://api.github.com/repos/matrix-org/synapse/issues/7451,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7451/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7451/comments,https://api.github.com/repos/matrix-org/synapse/issues/7451/events,https://github.com/matrix-org/synapse/issues/7451,614026087,MDU6SXNzdWU2MTQwMjYwODc=,7451,Adding an alt_alias with a bad server causes a 500,"{'login': 'foldleft', 'id': 3935731, 'node_id': 'MDQ6VXNlcjM5MzU3MzE=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/3935731?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/foldleft', 'html_url': 'https://github.com/foldleft', 'followers_url': 'https://api.github.com/users/foldleft/followers', 'following_url': 'https://api.github.com/users/foldleft/following{/other_user}', 'gists_url': 'https://api.github.com/users/foldleft/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/foldleft/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/foldleft/subscriptions', 'organizations_url': 'https://api.github.com/users/foldleft/orgs', 'repos_url': 'https://api.github.com/users/foldleft/repos', 'events_url': 'https://api.github.com/users/foldleft/events{/privacy}', 'received_events_url': 'https://api.github.com/users/foldleft/received_events', 'type': 'User', 'site_admin': False}","[{'id': 121086029, 'node_id': 'MDU6TGFiZWwxMjEwODYwMjk=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/bug', 'name': 'bug', 'color': 'fc2929', 'default': True, 'description': None}, {'id': 477050471, 'node_id': 'MDU6TGFiZWw0NzcwNTA0NzE=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/p3', 'name': 'p3', 'color': '0e8a16', 'default': False, 'description': None}]",closed,False,,[],,3,2020-05-07T12:40:20Z,2020-07-02T16:33:11Z,2020-07-02T16:33:10Z,NONE,,,"Attempting to add a bad server causes a 500 error:
```2020-05-07 12:36:31,038 - synapse.http.matrixfederationclient - 497 - WARNING - PUT-21 - {GET-O-1} [notaserver] Request failed: GET matrix://notaserver/_matrix/federation/v1/query/directory?room_alias=%23fake%3Anotaserver: DNSLookupError('no results for hostname lookup: notaserver')
2020-05-07 12:36:31,039 - synapse.http.server - 110 - ERROR - PUT-21 - Failed handle request via 'RoomStateEventRestServlet':
Traceback (most recent call last):
File ""/usr/local/lib/python3.7/site-packages/synapse/http/matrixfederationclient.py"", line 430, in _send_request
response = yield request_deferred
File ""/usr/local/lib/python3.7/site-packages/twisted/internet/defer.py"", line 1416, in _inlineCallbacks
result = result.throwExceptionIntoGenerator(g)
File ""/usr/local/lib/python3.7/site-packages/twisted/python/failure.py"", line 512, in throwExceptionIntoGenerator
return g.throw(self.type, self.value, self.tb)
File ""/usr/local/lib/python3.7/site-packages/synapse/http/federation/matrix_federation_agent.py"", line 162, in request
self._agent.request(method, uri, headers, bodyProducer)
File ""/usr/local/lib/python3.7/site-packages/twisted/internet/defer.py"", line 1416, in _inlineCallbacks
result = result.throwExceptionIntoGenerator(g)
File ""/usr/local/lib/python3.7/site-packages/twisted/python/failure.py"", line 512, in throwExceptionIntoGenerator
return g.throw(self.type, self.value, self.tb)
File ""/usr/local/lib/python3.7/site-packages/synapse/http/federation/matrix_federation_agent.py"", line 260, in _do_connect
raise first_exception
File ""/usr/local/lib/python3.7/site-packages/synapse/http/federation/matrix_federation_agent.py"", line 247, in _do_connect
endpoint.connect(protocol_factory)
File ""/usr/local/lib/python3.7/site-packages/twisted/internet/defer.py"", line 654, in _runCallbacks
current.result = callback(current.result, *args, **kw)
File ""/usr/local/lib/python3.7/site-packages/twisted/internet/endpoints.py"", line 982, in startConnectionAttempts
""no results for hostname lookup: {}"".format(self._hostStr)
twisted.internet.error.DNSLookupError: DNS lookup failed: no results for hostname lookup: notaserver.
```
Similarly if the domain exists but isn't running a server:
```
2020-05-07 12:37:19,885 - synapse.http.server - 110 - ERROR - PUT-25 - Failed handle request via 'RoomStateEventRestServlet':
Traceback (most recent call last):
File ""/usr/local/lib/python3.7/site-packages/synapse/http/matrixfederationclient.py"", line 430, in _send_request
response = yield request_deferred
twisted.internet.error.ConnectingCancelledError: HostnameAddress(hostname=b'example.com', port=8448)
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
File ""/usr/local/lib/python3.7/site-packages/synapse/http/server.py"", line 78, in wrapped_request_handler
await h(self, request)
File ""/usr/local/lib/python3.7/site-packages/synapse/http/server.py"", line 331, in _async_render
callback_return = await callback_return
File ""/usr/local/lib/python3.7/site-packages/synapse/rest/client/v1/room.py"", line 214, in on_PUT
requester, event_dict, txn_id=txn_id
File ""/usr/local/lib/python3.7/site-packages/synapse/handlers/message.py"", line 711, in create_and_send_nonmember_event
requester, event, context, ratelimit=ratelimit
File ""/usr/local/lib/python3.7/site-packages/synapse/handlers/message.py"", line 659, in send_nonmember_event
requester=requester, event=event, context=context, ratelimit=ratelimit
File ""/usr/local/lib/python3.7/site-packages/synapse/util/metrics.py"", line 73, in measured_func
r = await func(self, *args, **kwargs)
File ""/usr/local/lib/python3.7/site-packages/synapse/handlers/message.py"", line 839, in handle_new_client_event
requester, event, context, ratelimit=ratelimit, extra_users=extra_users
File ""/usr/local/lib/python3.7/site-packages/synapse/handlers/message.py"", line 957, in persist_and_notify_client_event
directory_handler, alias_str, event.room_id
File ""/usr/local/lib/python3.7/site-packages/twisted/internet/defer.py"", line 1416, in _inlineCallbacks
result = result.throwExceptionIntoGenerator(g)
File ""/usr/local/lib/python3.7/site-packages/twisted/python/failure.py"", line 512, in throwExceptionIntoGenerator
return g.throw(self.type, self.value, self.tb)
File ""/usr/local/lib/python3.7/site-packages/synapse/handlers/message.py"", line 865, in _validate_canonical_alias
mapping = yield directory_handler.get_association(room_alias)
File ""/usr/local/lib/python3.7/site-packages/twisted/internet/defer.py"", line 1416, in _inlineCallbacks
result = result.throwExceptionIntoGenerator(g)
File ""/usr/local/lib/python3.7/site-packages/twisted/python/failure.py"", line 512, in throwExceptionIntoGenerator
return g.throw(self.type, self.value, self.tb)
File ""/usr/local/lib/python3.7/site-packages/synapse/handlers/directory.py"", line 248, in get_association
ignore_backoff=True,
File ""/usr/local/lib/python3.7/site-packages/twisted/internet/defer.py"", line 1416, in _inlineCallbacks
result = result.throwExceptionIntoGenerator(g)
File ""/usr/local/lib/python3.7/site-packages/twisted/python/failure.py"", line 512, in throwExceptionIntoGenerator
return g.throw(self.type, self.value, self.tb)
File ""/usr/local/lib/python3.7/site-packages/synapse/federation/transport/client.py"", line 183, in make_query
ignore_backoff=ignore_backoff,
File ""/usr/local/lib/python3.7/site-packages/twisted/internet/defer.py"", line 1416, in _inlineCallbacks
result = result.throwExceptionIntoGenerator(g)
File ""/usr/local/lib/python3.7/site-packages/twisted/python/failure.py"", line 512, in throwExceptionIntoGenerator
return g.throw(self.type, self.value, self.tb)
File ""/usr/local/lib/python3.7/site-packages/synapse/http/matrixfederationclient.py"", line 786, in get_json
timeout=timeout,
File ""/usr/local/lib/python3.7/site-packages/twisted/internet/defer.py"", line 1416, in _inlineCallbacks
result = result.throwExceptionIntoGenerator(g)
File ""/usr/local/lib/python3.7/site-packages/twisted/python/failure.py"", line 512, in throwExceptionIntoGenerator
return g.throw(self.type, self.value, self.tb)
File ""/usr/local/lib/python3.7/site-packages/synapse/http/matrixfederationclient.py"", line 246, in _send_request_with_optional_trailing_slash
response = yield self._send_request(request, **send_request_args)
File ""/usr/local/lib/python3.7/site-packages/twisted/internet/defer.py"", line 1416, in _inlineCallbacks
result = result.throwExceptionIntoGenerator(g)
File ""/usr/local/lib/python3.7/site-packages/twisted/python/failure.py"", line 512, in throwExceptionIntoGenerator
return g.throw(self.type, self.value, self.tb)
File ""/usr/local/lib/python3.7/site-packages/synapse/http/matrixfederationclient.py"", line 435, in _send_request
raise_from(RequestSendFailed(e, can_retry=True), e)
File """", line 3, in raise_from
synapse.api.errors.RequestSendFailed: Failed to send request: ConnectingCancelledError: HostnameAddress(hostname=b'example.com', port=8448)
```
Or if the server denies the request:
```2020-05-07 12:39:13,714 - synapse.http.server - 110 - ERROR - PUT-37 - Failed handle request via 'RoomStateEventRestServlet':
Traceback (most recent call last):
File ""/usr/local/lib/python3.7/site-packages/synapse/http/server.py"", line 78, in wrapped_request_handler
await h(self, request)
File ""/usr/local/lib/python3.7/site-packages/synapse/http/server.py"", line 331, in _async_render
callback_return = await callback_return
File ""/usr/local/lib/python3.7/site-packages/synapse/rest/client/v1/room.py"", line 214, in on_PUT
requester, event_dict, txn_id=txn_id
File ""/usr/local/lib/python3.7/site-packages/synapse/handlers/message.py"", line 711, in create_and_send_nonmember_event
requester, event, context, ratelimit=ratelimit
File ""/usr/local/lib/python3.7/site-packages/synapse/handlers/message.py"", line 659, in send_nonmember_event
requester=requester, event=event, context=context, ratelimit=ratelimit
File ""/usr/local/lib/python3.7/site-packages/synapse/util/metrics.py"", line 73, in measured_func
r = await func(self, *args, **kwargs)
File ""/usr/local/lib/python3.7/site-packages/synapse/handlers/message.py"", line 839, in handle_new_client_event
requester, event, context, ratelimit=ratelimit, extra_users=extra_users
File ""/usr/local/lib/python3.7/site-packages/synapse/handlers/message.py"", line 957, in persist_and_notify_client_event
directory_handler, alias_str, event.room_id
File ""/usr/local/lib/python3.7/site-packages/twisted/internet/defer.py"", line 1416, in _inlineCallbacks
result = result.throwExceptionIntoGenerator(g)
File ""/usr/local/lib/python3.7/site-packages/twisted/python/failure.py"", line 512, in throwExceptionIntoGenerator
return g.throw(self.type, self.value, self.tb)
File ""/usr/local/lib/python3.7/site-packages/synapse/handlers/message.py"", line 865, in _validate_canonical_alias
mapping = yield directory_handler.get_association(room_alias)
File ""/usr/local/lib/python3.7/site-packages/twisted/internet/defer.py"", line 1416, in _inlineCallbacks
result = result.throwExceptionIntoGenerator(g)
File ""/usr/local/lib/python3.7/site-packages/twisted/python/failure.py"", line 512, in throwExceptionIntoGenerator
return g.throw(self.type, self.value, self.tb)
File ""/usr/local/lib/python3.7/site-packages/synapse/handlers/directory.py"", line 248, in get_association
ignore_backoff=True,
File ""/usr/local/lib/python3.7/site-packages/twisted/internet/defer.py"", line 1416, in _inlineCallbacks
result = result.throwExceptionIntoGenerator(g)
File ""/usr/local/lib/python3.7/site-packages/twisted/python/failure.py"", line 512, in throwExceptionIntoGenerator
return g.throw(self.type, self.value, self.tb)
File ""/usr/local/lib/python3.7/site-packages/synapse/federation/transport/client.py"", line 183, in make_query
ignore_backoff=ignore_backoff,
File ""/usr/local/lib/python3.7/site-packages/twisted/internet/defer.py"", line 1416, in _inlineCallbacks
result = result.throwExceptionIntoGenerator(g)
File ""/usr/local/lib/python3.7/site-packages/twisted/python/failure.py"", line 512, in throwExceptionIntoGenerator
return g.throw(self.type, self.value, self.tb)
File ""/usr/local/lib/python3.7/site-packages/synapse/http/matrixfederationclient.py"", line 786, in get_json
timeout=timeout,
File ""/usr/local/lib/python3.7/site-packages/twisted/internet/defer.py"", line 1416, in _inlineCallbacks
result = result.throwExceptionIntoGenerator(g)
File ""/usr/local/lib/python3.7/site-packages/twisted/python/failure.py"", line 512, in throwExceptionIntoGenerator
return g.throw(self.type, self.value, self.tb)
File ""/usr/local/lib/python3.7/site-packages/synapse/http/matrixfederationclient.py"", line 246, in _send_request_with_optional_trailing_slash
response = yield self._send_request(request, **send_request_args)
File ""/usr/local/lib/python3.7/site-packages/twisted/internet/defer.py"", line 1418, in _inlineCallbacks
result = g.send(result)
File ""/usr/local/lib/python3.7/site-packages/synapse/http/matrixfederationclient.py"", line 487, in _send_request
raise e
synapse.api.errors.HttpResponseException: 401: b'Unauthorized'
```",
838,https://api.github.com/repos/matrix-org/synapse/issues/7450,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7450/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7450/comments,https://api.github.com/repos/matrix-org/synapse/issues/7450/events,https://github.com/matrix-org/synapse/pull/7450,614024131,MDExOlB1bGxSZXF1ZXN0NDE0NjU4OTYz,7450,Drop support for redis.dbid,"{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,0,2020-05-07T12:37:17Z,2020-05-07T15:46:17Z,2020-05-07T15:46:15Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7450', 'html_url': 'https://github.com/matrix-org/synapse/pull/7450', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7450.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7450.patch'}","Since we only use pubsub, the dbid is irrelevant.",
839,https://api.github.com/repos/matrix-org/synapse/issues/7449,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7449/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7449/comments,https://api.github.com/repos/matrix-org/synapse/issues/7449/events,https://github.com/matrix-org/synapse/pull/7449,613994137,MDExOlB1bGxSZXF1ZXN0NDE0NjM1MTY1,7449,Fixes typo (bellow -> below),"{'login': 'clokep', 'id': 517124, 'node_id': 'MDQ6VXNlcjUxNzEyNA==', 'avatar_url': 'https://avatars2.githubusercontent.com/u/517124?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/clokep', 'html_url': 'https://github.com/clokep', 'followers_url': 'https://api.github.com/users/clokep/followers', 'following_url': 'https://api.github.com/users/clokep/following{/other_user}', 'gists_url': 'https://api.github.com/users/clokep/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/clokep/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/clokep/subscriptions', 'organizations_url': 'https://api.github.com/users/clokep/orgs', 'repos_url': 'https://api.github.com/users/clokep/repos', 'events_url': 'https://api.github.com/users/clokep/events{/privacy}', 'received_events_url': 'https://api.github.com/users/clokep/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,0,2020-05-07T11:49:13Z,2020-05-07T13:31:08Z,2020-05-07T13:31:07Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7449', 'html_url': 'https://github.com/matrix-org/synapse/pull/7449', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7449.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7449.patch'}",Fixes a couple of typos.,
840,https://api.github.com/repos/matrix-org/synapse/issues/7448,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7448/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7448/comments,https://api.github.com/repos/matrix-org/synapse/issues/7448/events,https://github.com/matrix-org/synapse/pull/7448,613961083,MDExOlB1bGxSZXF1ZXN0NDE0NjA4NjEz,7448,Remove unused store method get_hosts_in_room,"{'login': 'anoadragon453', 'id': 1342360, 'node_id': 'MDQ6VXNlcjEzNDIzNjA=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1342360?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/anoadragon453', 'html_url': 'https://github.com/anoadragon453', 'followers_url': 'https://api.github.com/users/anoadragon453/followers', 'following_url': 'https://api.github.com/users/anoadragon453/following{/other_user}', 'gists_url': 'https://api.github.com/users/anoadragon453/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/anoadragon453/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/anoadragon453/subscriptions', 'organizations_url': 'https://api.github.com/users/anoadragon453/orgs', 'repos_url': 'https://api.github.com/users/anoadragon453/repos', 'events_url': 'https://api.github.com/users/anoadragon453/events{/privacy}', 'received_events_url': 'https://api.github.com/users/anoadragon453/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,0,2020-05-07T10:52:29Z,2020-05-11T15:55:59Z,2020-05-11T15:55:57Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7448', 'html_url': 'https://github.com/matrix-org/synapse/pull/7448', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7448.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7448.patch'}",This method does not have any callers.,
841,https://api.github.com/repos/matrix-org/synapse/issues/7447,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7447/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7447/comments,https://api.github.com/repos/matrix-org/synapse/issues/7447/events,https://github.com/matrix-org/synapse/issues/7447,613920585,MDU6SXNzdWU2MTM5MjA1ODU=,7447,Allow sharding of media repository,"{'login': 'erikjohnston', 'id': 8428120, 'node_id': 'MDQ6VXNlcjg0MjgxMjA=', 'avatar_url': 'https://avatars0.githubusercontent.com/u/8428120?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/erikjohnston', 'html_url': 'https://github.com/erikjohnston', 'followers_url': 'https://api.github.com/users/erikjohnston/followers', 'following_url': 'https://api.github.com/users/erikjohnston/following{/other_user}', 'gists_url': 'https://api.github.com/users/erikjohnston/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/erikjohnston/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/erikjohnston/subscriptions', 'organizations_url': 'https://api.github.com/users/erikjohnston/orgs', 'repos_url': 'https://api.github.com/users/erikjohnston/repos', 'events_url': 'https://api.github.com/users/erikjohnston/events{/privacy}', 'received_events_url': 'https://api.github.com/users/erikjohnston/received_events', 'type': 'User', 'site_admin': False}","[{'id': 600557921, 'node_id': 'MDU6TGFiZWw2MDA1NTc5MjE=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/performance', 'name': 'performance', 'color': 'fef2c0', 'default': False, 'description': None}]",closed,False,"{'login': 'erikjohnston', 'id': 8428120, 'node_id': 'MDQ6VXNlcjg0MjgxMjA=', 'avatar_url': 'https://avatars0.githubusercontent.com/u/8428120?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/erikjohnston', 'html_url': 'https://github.com/erikjohnston', 'followers_url': 'https://api.github.com/users/erikjohnston/followers', 'following_url': 'https://api.github.com/users/erikjohnston/following{/other_user}', 'gists_url': 'https://api.github.com/users/erikjohnston/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/erikjohnston/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/erikjohnston/subscriptions', 'organizations_url': 'https://api.github.com/users/erikjohnston/orgs', 'repos_url': 'https://api.github.com/users/erikjohnston/repos', 'events_url': 'https://api.github.com/users/erikjohnston/events{/privacy}', 'received_events_url': 'https://api.github.com/users/erikjohnston/received_events', 'type': 'User', 'site_admin': False}","[{'login': 'erikjohnston', 'id': 8428120, 'node_id': 'MDQ6VXNlcjg0MjgxMjA=', 'avatar_url': 'https://avatars0.githubusercontent.com/u/8428120?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/erikjohnston', 'html_url': 'https://github.com/erikjohnston', 'followers_url': 'https://api.github.com/users/erikjohnston/followers', 'following_url': 'https://api.github.com/users/erikjohnston/following{/other_user}', 'gists_url': 'https://api.github.com/users/erikjohnston/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/erikjohnston/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/erikjohnston/subscriptions', 'organizations_url': 'https://api.github.com/users/erikjohnston/orgs', 'repos_url': 'https://api.github.com/users/erikjohnston/repos', 'events_url': 'https://api.github.com/users/erikjohnston/events{/privacy}', 'received_events_url': 'https://api.github.com/users/erikjohnston/received_events', 'type': 'User', 'site_admin': False}]",,5,2020-05-07T09:46:31Z,2020-06-18T09:17:14Z,2020-06-18T09:17:14Z,MEMBER,,,"Looks like the media repository on matrix.org has high CPU usage, so we should investigate how we can scale it out a bit.
The main sources of CPU usage seem to be:
- S3 storage provider
- URL previews (I think due to SSL overhead maybe?)",
842,https://api.github.com/repos/matrix-org/synapse/issues/7446,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7446/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7446/comments,https://api.github.com/repos/matrix-org/synapse/issues/7446/events,https://github.com/matrix-org/synapse/pull/7446,613623559,MDExOlB1bGxSZXF1ZXN0NDE0MzQyNjc4,7446,Documentation on setting up redis,"{'login': 'neilisfragile', 'id': 451032, 'node_id': 'MDQ6VXNlcjQ1MTAzMg==', 'avatar_url': 'https://avatars2.githubusercontent.com/u/451032?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/neilisfragile', 'html_url': 'https://github.com/neilisfragile', 'followers_url': 'https://api.github.com/users/neilisfragile/followers', 'following_url': 'https://api.github.com/users/neilisfragile/following{/other_user}', 'gists_url': 'https://api.github.com/users/neilisfragile/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/neilisfragile/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/neilisfragile/subscriptions', 'organizations_url': 'https://api.github.com/users/neilisfragile/orgs', 'repos_url': 'https://api.github.com/users/neilisfragile/repos', 'events_url': 'https://api.github.com/users/neilisfragile/events{/privacy}', 'received_events_url': 'https://api.github.com/users/neilisfragile/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,2,2020-05-06T21:26:13Z,2020-05-11T12:21:17Z,2020-05-11T12:21:15Z,CONTRIBUTOR,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7446', 'html_url': 'https://github.com/matrix-org/synapse/pull/7446', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7446.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7446.patch'}",https://github.com/matrix-org/synapse/issues/7402,
843,https://api.github.com/repos/matrix-org/synapse/issues/7445,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7445/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7445/comments,https://api.github.com/repos/matrix-org/synapse/issues/7445/events,https://github.com/matrix-org/synapse/pull/7445,613525380,MDExOlB1bGxSZXF1ZXN0NDE0MjYyNTIy,7445,Add more type hints to SAML handler.,"{'login': 'clokep', 'id': 517124, 'node_id': 'MDQ6VXNlcjUxNzEyNA==', 'avatar_url': 'https://avatars2.githubusercontent.com/u/517124?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/clokep', 'html_url': 'https://github.com/clokep', 'followers_url': 'https://api.github.com/users/clokep/followers', 'following_url': 'https://api.github.com/users/clokep/following{/other_user}', 'gists_url': 'https://api.github.com/users/clokep/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/clokep/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/clokep/subscriptions', 'organizations_url': 'https://api.github.com/users/clokep/orgs', 'repos_url': 'https://api.github.com/users/clokep/repos', 'events_url': 'https://api.github.com/users/clokep/events{/privacy}', 'received_events_url': 'https://api.github.com/users/clokep/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,0,2020-05-06T18:32:02Z,2020-05-07T13:30:47Z,2020-05-07T13:30:45Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7445', 'html_url': 'https://github.com/matrix-org/synapse/pull/7445', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7445.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7445.patch'}",While reviewing #7256 I realized that the SAML handler never got added to the tox config for mypy. Most of this was already typed.,
844,https://api.github.com/repos/matrix-org/synapse/issues/7444,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7444/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7444/comments,https://api.github.com/repos/matrix-org/synapse/issues/7444/events,https://github.com/matrix-org/synapse/issues/7444,613493587,MDU6SXNzdWU2MTM0OTM1ODc=,7444,consider handling incoming replication queues in a more efficient way,"{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}","[{'id': 2011569249, 'node_id': 'MDU6TGFiZWwyMDExNTY5MjQ5', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/operation%20gemini', 'name': 'operation gemini', 'color': '006b75', 'default': False, 'description': 'Part of the project to fix the cpu bottleneck on'}, {'id': 600557921, 'node_id': 'MDU6TGFiZWw2MDA1NTc5MjE=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/performance', 'name': 'performance', 'color': 'fef2c0', 'default': False, 'description': None}]",closed,False,"{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}","[{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}]",,2,2020-05-06T17:37:13Z,2020-07-16T14:49:38Z,2020-07-16T14:49:38Z,MEMBER,,,"if we get behind on replication (eg because the connection dropped and we have to process a POSITION, which is slowish), we stack up background processes on a linearizer; bg processes are heavy (particularly with respect to prometheus metrics) and linearizers aren't terribly efficient once the queue gets long either.",
845,https://api.github.com/repos/matrix-org/synapse/issues/7443,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7443/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7443/comments,https://api.github.com/repos/matrix-org/synapse/issues/7443/events,https://github.com/matrix-org/synapse/pull/7443,613491649,MDExOlB1bGxSZXF1ZXN0NDE0MjM1MzAy,7443,Allow expired accounts to logout,"{'login': 'anoadragon453', 'id': 1342360, 'node_id': 'MDQ6VXNlcjEzNDIzNjA=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1342360?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/anoadragon453', 'html_url': 'https://github.com/anoadragon453', 'followers_url': 'https://api.github.com/users/anoadragon453/followers', 'following_url': 'https://api.github.com/users/anoadragon453/following{/other_user}', 'gists_url': 'https://api.github.com/users/anoadragon453/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/anoadragon453/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/anoadragon453/subscriptions', 'organizations_url': 'https://api.github.com/users/anoadragon453/orgs', 'repos_url': 'https://api.github.com/users/anoadragon453/repos', 'events_url': 'https://api.github.com/users/anoadragon453/events{/privacy}', 'received_events_url': 'https://api.github.com/users/anoadragon453/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,0,2020-05-06T17:33:54Z,2020-05-14T15:32:51Z,2020-05-14T15:32:50Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7443', 'html_url': 'https://github.com/matrix-org/synapse/pull/7443', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7443.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7443.patch'}","Fixes https://github.com/matrix-org/synapse/issues/5756
This PR prevents an `InvalidClientTokenError` or `AuthError` being raised when a user is expired for the `/logout` and `/logout/all` endpoints.",
846,https://api.github.com/repos/matrix-org/synapse/issues/7442,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7442/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7442/comments,https://api.github.com/repos/matrix-org/synapse/issues/7442/events,https://github.com/matrix-org/synapse/pull/7442,613463902,MDExOlB1bGxSZXF1ZXN0NDE0MjEyODYz,7442,Port group attestation renewal slow down from matrix-org-hotfixes,"{'login': 'anoadragon453', 'id': 1342360, 'node_id': 'MDQ6VXNlcjEzNDIzNjA=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1342360?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/anoadragon453', 'html_url': 'https://github.com/anoadragon453', 'followers_url': 'https://api.github.com/users/anoadragon453/followers', 'following_url': 'https://api.github.com/users/anoadragon453/following{/other_user}', 'gists_url': 'https://api.github.com/users/anoadragon453/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/anoadragon453/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/anoadragon453/subscriptions', 'organizations_url': 'https://api.github.com/users/anoadragon453/orgs', 'repos_url': 'https://api.github.com/users/anoadragon453/repos', 'events_url': 'https://api.github.com/users/anoadragon453/events{/privacy}', 'received_events_url': 'https://api.github.com/users/anoadragon453/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,0,2020-05-06T16:48:59Z,2020-05-06T19:21:41Z,2020-05-06T19:21:40Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7442', 'html_url': 'https://github.com/matrix-org/synapse/pull/7442', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7442.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7442.patch'}","Fixes: https://github.com/matrix-org/synapse/issues/7411
Port of https://github.com/matrix-org/synapse/commit/14bb4cff99ddd8b5eb1816c5405d52a8f13e29d6 from the `matrix-org-hotfixes` branch to mainline.",
847,https://api.github.com/repos/matrix-org/synapse/issues/7441,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7441/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7441/comments,https://api.github.com/repos/matrix-org/synapse/issues/7441/events,https://github.com/matrix-org/synapse/issues/7441,613419970,MDU6SXNzdWU2MTM0MTk5NzA=,7441,Synapse stops responding after Twisted 20.3.0 upgrade,"{'login': 'AluisioASG', 'id': 1904165, 'node_id': 'MDQ6VXNlcjE5MDQxNjU=', 'avatar_url': 'https://avatars2.githubusercontent.com/u/1904165?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/AluisioASG', 'html_url': 'https://github.com/AluisioASG', 'followers_url': 'https://api.github.com/users/AluisioASG/followers', 'following_url': 'https://api.github.com/users/AluisioASG/following{/other_user}', 'gists_url': 'https://api.github.com/users/AluisioASG/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/AluisioASG/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/AluisioASG/subscriptions', 'organizations_url': 'https://api.github.com/users/AluisioASG/orgs', 'repos_url': 'https://api.github.com/users/AluisioASG/repos', 'events_url': 'https://api.github.com/users/AluisioASG/events{/privacy}', 'received_events_url': 'https://api.github.com/users/AluisioASG/received_events', 'type': 'User', 'site_admin': False}","[{'id': 2021736922, 'node_id': 'MDU6TGFiZWwyMDIxNzM2OTIy', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/upstream-bug', 'name': 'upstream-bug', 'color': 'bfdadc', 'default': False, 'description': ''}]",closed,False,"{'login': 'anoadragon453', 'id': 1342360, 'node_id': 'MDQ6VXNlcjEzNDIzNjA=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1342360?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/anoadragon453', 'html_url': 'https://github.com/anoadragon453', 'followers_url': 'https://api.github.com/users/anoadragon453/followers', 'following_url': 'https://api.github.com/users/anoadragon453/following{/other_user}', 'gists_url': 'https://api.github.com/users/anoadragon453/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/anoadragon453/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/anoadragon453/subscriptions', 'organizations_url': 'https://api.github.com/users/anoadragon453/orgs', 'repos_url': 'https://api.github.com/users/anoadragon453/repos', 'events_url': 'https://api.github.com/users/anoadragon453/events{/privacy}', 'received_events_url': 'https://api.github.com/users/anoadragon453/received_events', 'type': 'User', 'site_admin': False}","[{'login': 'anoadragon453', 'id': 1342360, 'node_id': 'MDQ6VXNlcjEzNDIzNjA=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1342360?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/anoadragon453', 'html_url': 'https://github.com/anoadragon453', 'followers_url': 'https://api.github.com/users/anoadragon453/followers', 'following_url': 'https://api.github.com/users/anoadragon453/following{/other_user}', 'gists_url': 'https://api.github.com/users/anoadragon453/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/anoadragon453/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/anoadragon453/subscriptions', 'organizations_url': 'https://api.github.com/users/anoadragon453/orgs', 'repos_url': 'https://api.github.com/users/anoadragon453/repos', 'events_url': 'https://api.github.com/users/anoadragon453/events{/privacy}', 'received_events_url': 'https://api.github.com/users/anoadragon453/received_events', 'type': 'User', 'site_admin': False}]",,6,2020-05-06T15:42:23Z,2020-06-17T10:40:04Z,2020-05-14T16:42:57Z,NONE,,,"### Description
After upgrading a FreeBSD server to Synapse 1.12.4 and Twisted 20.3.0, the status page endpoint (`/_matrix/static/`) stops responding and Riot thinks it's offline a few minutes after the server starts. Rolling Twisted back to 18.9.0 and restarting Synapse makes it work again.
I've traced the error to the following call; `reason` sometimes lacks the `type` attribute and causes a critical, unhandled error. Removing the reference to `reason.type` fixed it for me, even after re-upgrading Twisted to 20.3.0.
https://github.com/matrix-org/synapse/blob/ce9b62e13f7d653e5099ae4a159c0e5cde419cf8/synapse/http/site.py#L202-L204
Oddly enough, errors logged after fixing that line do seem to have a `type`; I'm guessing it may be masquerading an incompatibility somewhere else.
### Steps to reproduce
- Upgrade Twisted to 20.3.0
- Start the server
- Wait a few minutes; it will stop responding to (some) requests
### Stack trace
The `TWISTED DEBUG` lines output `type(reason)`, `repr(reason)` and `dir(reason)`, and are printed just before the previous snippet.
```
2020-05-06 13:39:51,471 - synapse.http.site - 202 - WARNING - GET-208- TWISTED DEBUG(type = , repr = ConnectionLost('Stream reset with code ErrorCodes.CANCEL',), dir = ['__cause__', '__class__', '__context__', '__delattr__', '__dict__', '__dir__', '__doc__', '__eq__', '__format__', '__ge__', '__getattribute__', '__gt__', '__hash__', '__init__', '__init_subclass__', '__le__', '__lt__', '__module__', '__ne__', '__new__', '__reduce__', '__reduce_ex__', '__repr__', '__setattr__', '__setstate__', '__sizeof__', '__str__', '__subclasshook__', '__suppress_context__', '__traceback__', '__weakref__', 'args', 'with_traceback'])
2020-05-06 13:39:51,479 - twisted - 192 - CRITICAL - - Unhandled Error
Traceback (most recent call last):
File ""/usr/local/lib/python3.6/site-packages/twisted/python/log.py"", line 103, in callWithLogger
return callWithContext({""system"": lp}, func, *args, **kw)
File ""/usr/local/lib/python3.6/site-packages/twisted/python/log.py"", line 86, in callWithContext
return context.call({ILogContext: newCtx}, func, *args, **kw)
File ""/usr/local/lib/python3.6/site-packages/twisted/python/context.py"", line 122, in callWithContext
return self.currentContext().callWithContext(ctx, func, *args, **kw)
File ""/usr/local/lib/python3.6/site-packages/twisted/python/context.py"", line 85, in callWithContext
return func(*args,**kw)
--- ---
File ""/usr/local/lib/python3.6/site-packages/twisted/internet/posixbase.py"", line 614, in _doReadOrWrite
why = selectable.doRead()
File ""/usr/local/lib/python3.6/site-packages/twisted/internet/tcp.py"", line 243, in doRead
return self._dataReceived(data)
File ""/usr/local/lib/python3.6/site-packages/twisted/internet/tcp.py"", line 249, in _dataReceived
rval = self.protocol.dataReceived(data)
File ""/usr/local/lib/python3.6/site-packages/twisted/protocols/tls.py"", line 330, in dataReceived
self._flushReceiveBIO()
File ""/usr/local/lib/python3.6/site-packages/twisted/protocols/tls.py"", line 295, in _flushReceiveBIO
ProtocolWrapper.dataReceived(self, bytes)
File ""/usr/local/lib/python3.6/site-packages/twisted/protocols/policies.py"", line 120, in dataReceived
self.wrappedProtocol.dataReceived(data)
File ""/usr/local/lib/python3.6/site-packages/twisted/web/http.py"", line 3024, in dataReceived
return self._channel.dataReceived(data)
File ""/usr/local/lib/python3.6/site-packages/twisted/web/_http2.py"", line 196, in dataReceived
self._requestAborted(event)
File ""/usr/local/lib/python3.6/site-packages/twisted/web/_http2.py"", line 528, in _requestAborted
ConnectionLost(""Stream reset with code %s"" % event.error_code)
File ""/usr/local/lib/python3.6/site-packages/twisted/web/_http2.py"", line 1077, in connectionLost
self._request.connectionLost(reason)
File ""/usr/local/lib/python3.6/site-packages/synapse/http/site.py"", line 204, in connectionLost
""Error processing request %r: %s %s"", self, reason.type, reason.value
builtins.AttributeError: 'ConnectionLost' object has no attribute 'type'
2020-05-06 13:39:51,480 - synapse.http.site - 202 - WARNING - GET-140- TWISTED DEBUG(type = , repr = ConnectionLost('Producing stopped',), dir = ['__cause__', '__class__', '__context__', '__delattr__', '__dict__', '__dir__', '__doc__', '__eq__', '__format__', '__ge__', '__getattribute__', '__gt__', '__hash__', '__init__', '__init_subclass__', '__le__', '__lt__', '__module__', '__ne__', '__new__', '__reduce__', '__reduce_ex__', '__repr__', '__setattr__', '__setstate__', '__sizeof__', '__str__', '__subclasshook__', '__suppress_context__', '__traceback__', '__weakref__', 'args', 'with_traceback'])
2020-05-06 13:39:51,484 - twisted - 192 - CRITICAL - - Unhandled Error
Traceback (most recent call last):
File ""/usr/local/lib/python3.6/site-packages/synapse/app/_base.py"", line 114, in run
run_command()
File ""/usr/local/lib/python3.6/site-packages/twisted/internet/base.py"", line 1283, in run
self.mainLoop()
File ""/usr/local/lib/python3.6/site-packages/twisted/internet/base.py"", line 1295, in mainLoop
self.doIteration(t)
File ""/usr/local/lib/python3.6/site-packages/twisted/internet/pollreactor.py"", line 169, in doPoll
log.callWithLogger(selectable, _drdw, selectable, fd, event)
--- ---
File ""/usr/local/lib/python3.6/site-packages/twisted/python/log.py"", line 103, in callWithLogger
return callWithContext({""system"": lp}, func, *args, **kw)
File ""/usr/local/lib/python3.6/site-packages/twisted/python/log.py"", line 86, in callWithContext
return context.call({ILogContext: newCtx}, func, *args, **kw)
File ""/usr/local/lib/python3.6/site-packages/twisted/python/context.py"", line 122, in callWithContext
return self.currentContext().callWithContext(ctx, func, *args, **kw)
File ""/usr/local/lib/python3.6/site-packages/twisted/python/context.py"", line 85, in callWithContext
return func(*args,**kw)
File ""/usr/local/lib/python3.6/site-packages/twisted/internet/posixbase.py"", line 627, in _doReadOrWrite
self._disconnectSelectable(selectable, why, inRead)
File ""/usr/local/lib/python3.6/site-packages/twisted/internet/posixbase.py"", line 258, in _disconnectSelectable
selectable.connectionLost(failure.Failure(why))
File ""/usr/local/lib/python3.6/site-packages/twisted/internet/tcp.py"", line 321, in connectionLost
abstract.FileDescriptor.connectionLost(self, reason)
File ""/usr/local/lib/python3.6/site-packages/twisted/internet/abstract.py"", line 205, in connectionLost
self.producer.stopProducing()
File ""/usr/local/lib/python3.6/site-packages/twisted/protocols/tls.py"", line 111, in stopProducing
self._producer.stopProducing()
File ""/usr/local/lib/python3.6/site-packages/twisted/web/_http2.py"", line 353, in stopProducing
self.connectionLost(ConnectionLost(""Producing stopped""))
File ""/usr/local/lib/python3.6/site-packages/twisted/web/_http2.py"", line 290, in connectionLost
stream.connectionLost(reason)
File ""/usr/local/lib/python3.6/site-packages/twisted/web/_http2.py"", line 1077, in connectionLost
self._request.connectionLost(reason)
File ""/usr/local/lib/python3.6/site-packages/synapse/http/site.py"", line 204, in connectionLost
""Error processing request %r: %s %s"", self, reason.type, reason.value
builtins.AttributeError: 'ConnectionLost' object has no attribute 'type'
```
### Version information
- **Homeserver**: matrix.aasg.name
- **Version**: 1.12.4
- **Install method**: FreeBSD ports
- **Platform**: FreeBSD 11.3 jail, with Python 3.6.9
",
848,https://api.github.com/repos/matrix-org/synapse/issues/7440,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7440/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7440/comments,https://api.github.com/repos/matrix-org/synapse/issues/7440/events,https://github.com/matrix-org/synapse/pull/7440,613406371,MDExOlB1bGxSZXF1ZXN0NDE0MTY2NDEz,7440,Shuffle persist event data store functions.,"{'login': 'erikjohnston', 'id': 8428120, 'node_id': 'MDQ6VXNlcjg0MjgxMjA=', 'avatar_url': 'https://avatars0.githubusercontent.com/u/8428120?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/erikjohnston', 'html_url': 'https://github.com/erikjohnston', 'followers_url': 'https://api.github.com/users/erikjohnston/followers', 'following_url': 'https://api.github.com/users/erikjohnston/following{/other_user}', 'gists_url': 'https://api.github.com/users/erikjohnston/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/erikjohnston/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/erikjohnston/subscriptions', 'organizations_url': 'https://api.github.com/users/erikjohnston/orgs', 'repos_url': 'https://api.github.com/users/erikjohnston/repos', 'events_url': 'https://api.github.com/users/erikjohnston/events{/privacy}', 'received_events_url': 'https://api.github.com/users/erikjohnston/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,9,2020-05-06T15:23:37Z,2020-05-13T12:38:24Z,2020-05-13T12:38:23Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7440', 'html_url': 'https://github.com/matrix-org/synapse/pull/7440', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7440.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7440.patch'}","The aim here is to get to a stage where we have a `PersistEventStore` that holds all the write methods used during event persistence, so that we can take that class out of the `DataStore` mixin and instansiate it separately. This will allow us to instansiate it on processes other than master, while also ensuring it is only available on processes that are configured to write to events stream.
This is a bit of an architectural change, where we end up with multiple classes per data store (rather than one per data store we have now). We end up having:
1. Storage classes that provide high level APIs that can talk to multiple data stores.
2. Data store modules that consist of classes that must point at the same database instance.
3. Classes in a data store that can be instantiated on processes depending on config.
Thoughts welcome if this is the right approach.",
849,https://api.github.com/repos/matrix-org/synapse/issues/7439,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7439/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7439/comments,https://api.github.com/repos/matrix-org/synapse/issues/7439/events,https://github.com/matrix-org/synapse/pull/7439,613403056,MDExOlB1bGxSZXF1ZXN0NDE0MTYzNzMw,7439,Make redis go faster with hiredis,"{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,1,2020-05-06T15:18:59Z,2020-05-06T16:36:48Z,2020-05-06T16:36:47Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7439', 'html_url': 'https://github.com/matrix-org/synapse/pull/7439', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7439.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7439.patch'}","For the record, the reason we need this is as follows:
each RDATA command comes down the redis pipe as a subscription message. txredisapi as written needs at least three reactor ticks to read each subscription message from the tcp buffer. Hence, once the process gets loaded, it starts getting behind, and eventually redis knifes the connection. it then takes ages for the master to work its way through the backlog, before it reconnects again, during which any commands from any workers are dropped.",
850,https://api.github.com/repos/matrix-org/synapse/issues/7438,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7438/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7438/comments,https://api.github.com/repos/matrix-org/synapse/issues/7438/events,https://github.com/matrix-org/synapse/pull/7438,613400867,MDExOlB1bGxSZXF1ZXN0NDE0MTYxOTY3,7438,Allow for `identifier` dicts in User Interactive Auth dicts,"{'login': 'anoadragon453', 'id': 1342360, 'node_id': 'MDQ6VXNlcjEzNDIzNjA=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1342360?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/anoadragon453', 'html_url': 'https://github.com/anoadragon453', 'followers_url': 'https://api.github.com/users/anoadragon453/followers', 'following_url': 'https://api.github.com/users/anoadragon453/following{/other_user}', 'gists_url': 'https://api.github.com/users/anoadragon453/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/anoadragon453/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/anoadragon453/subscriptions', 'organizations_url': 'https://api.github.com/users/anoadragon453/orgs', 'repos_url': 'https://api.github.com/users/anoadragon453/repos', 'events_url': 'https://api.github.com/users/anoadragon453/events{/privacy}', 'received_events_url': 'https://api.github.com/users/anoadragon453/received_events', 'type': 'User', 'site_admin': False}",[],open,False,"{'login': 'clokep', 'id': 517124, 'node_id': 'MDQ6VXNlcjUxNzEyNA==', 'avatar_url': 'https://avatars2.githubusercontent.com/u/517124?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/clokep', 'html_url': 'https://github.com/clokep', 'followers_url': 'https://api.github.com/users/clokep/followers', 'following_url': 'https://api.github.com/users/clokep/following{/other_user}', 'gists_url': 'https://api.github.com/users/clokep/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/clokep/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/clokep/subscriptions', 'organizations_url': 'https://api.github.com/users/clokep/orgs', 'repos_url': 'https://api.github.com/users/clokep/repos', 'events_url': 'https://api.github.com/users/clokep/events{/privacy}', 'received_events_url': 'https://api.github.com/users/clokep/received_events', 'type': 'User', 'site_admin': False}","[{'login': 'clokep', 'id': 517124, 'node_id': 'MDQ6VXNlcjUxNzEyNA==', 'avatar_url': 'https://avatars2.githubusercontent.com/u/517124?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/clokep', 'html_url': 'https://github.com/clokep', 'followers_url': 'https://api.github.com/users/clokep/followers', 'following_url': 'https://api.github.com/users/clokep/following{/other_user}', 'gists_url': 'https://api.github.com/users/clokep/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/clokep/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/clokep/subscriptions', 'organizations_url': 'https://api.github.com/users/clokep/orgs', 'repos_url': 'https://api.github.com/users/clokep/repos', 'events_url': 'https://api.github.com/users/clokep/events{/privacy}', 'received_events_url': 'https://api.github.com/users/clokep/received_events', 'type': 'User', 'site_admin': False}]",,1,2020-05-06T15:16:02Z,2020-08-26T11:22:44Z,,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7438', 'html_url': 'https://github.com/matrix-org/synapse/pull/7438', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7438.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7438.patch'}","A stab at fixing https://github.com/matrix-org/synapse/issues/5665
Allows `identifier` dicts to be used in UIA flows and relaxes the requirement of a `user` parameter, which has since been deprecated. Relevant spec: https://matrix.org/docs/spec/client_server/r0.6.1#identifier-types
**Warning:** This deals with UIA and login and may break both - careful review required.
Requires: https://github.com/matrix-org/synapse/pull/7687
Should be reviewable commit-by-commit.
Note: This PR reworks the end of `_check_auth_dict`, which was essentially the place where `m.login.password` UI Auth steps were handled. In a future PR, it may be cleaner to move that code into an instance of `UserInteractiveAuthChecker` in [synapse/handlers/ui_auth/checkers.py](https://github.com/matrix-org/synapse/blob/a3fbc23c39c0366392fd51faf0b1696f1f1d21c7/synapse/handlers/ui_auth/checkers.py#L29).",
851,https://api.github.com/repos/matrix-org/synapse/issues/7437,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7437/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7437/comments,https://api.github.com/repos/matrix-org/synapse/issues/7437/events,https://github.com/matrix-org/synapse/issues/7437,613281450,MDU6SXNzdWU2MTMyODE0NTA=,7437,background update in #7429 doesn't work,"{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}","[{'id': 828666468, 'node_id': 'MDU6TGFiZWw4Mjg2NjY0Njg=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/release%20blocker', 'name': 'release blocker', 'color': '880000', 'default': False, 'description': None}]",closed,False,"{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}","[{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}]",,1,2020-05-06T12:28:48Z,2020-05-26T10:43:19Z,2020-05-26T10:43:19Z,MEMBER,,,#7429 tries to create a new index in the background; this plain doesn't work because it keeps getting interrupted by transactions which want to take a lock. The index only took a minute or two to build - I think we should just do that.,
852,https://api.github.com/repos/matrix-org/synapse/issues/7436,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7436/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7436/comments,https://api.github.com/repos/matrix-org/synapse/issues/7436/events,https://github.com/matrix-org/synapse/pull/7436,613251490,MDExOlB1bGxSZXF1ZXN0NDE0MDQwNjkx,7436,Support any process writing to cache invalidation stream.,"{'login': 'erikjohnston', 'id': 8428120, 'node_id': 'MDQ6VXNlcjg0MjgxMjA=', 'avatar_url': 'https://avatars0.githubusercontent.com/u/8428120?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/erikjohnston', 'html_url': 'https://github.com/erikjohnston', 'followers_url': 'https://api.github.com/users/erikjohnston/followers', 'following_url': 'https://api.github.com/users/erikjohnston/following{/other_user}', 'gists_url': 'https://api.github.com/users/erikjohnston/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/erikjohnston/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/erikjohnston/subscriptions', 'organizations_url': 'https://api.github.com/users/erikjohnston/orgs', 'repos_url': 'https://api.github.com/users/erikjohnston/repos', 'events_url': 'https://api.github.com/users/erikjohnston/events{/privacy}', 'received_events_url': 'https://api.github.com/users/erikjohnston/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,2,2020-05-06T11:35:24Z,2020-05-07T12:51:10Z,2020-05-07T12:51:09Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7436', 'html_url': 'https://github.com/matrix-org/synapse/pull/7436', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7436.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7436.patch'}","This is done via two big changes:
1. Change the cache stream to use the new `MultiWriterIdGenerator`
2. Change the definition of `Stream.current_token` to accept an instance name parameter, which allows us to support the idea of there being multiple writers and so multiple positions to keep track of.
Its probably worth going through commit by commit, as there is a bit of boiler plate refactoring going on.",
853,https://api.github.com/repos/matrix-org/synapse/issues/7435,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7435/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7435/comments,https://api.github.com/repos/matrix-org/synapse/issues/7435/events,https://github.com/matrix-org/synapse/pull/7435,613242168,MDExOlB1bGxSZXF1ZXN0NDE0MDMzMTEy,7435,Extend spam checker to allow for multiple modules,"{'login': 'anoadragon453', 'id': 1342360, 'node_id': 'MDQ6VXNlcjEzNDIzNjA=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1342360?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/anoadragon453', 'html_url': 'https://github.com/anoadragon453', 'followers_url': 'https://api.github.com/users/anoadragon453/followers', 'following_url': 'https://api.github.com/users/anoadragon453/following{/other_user}', 'gists_url': 'https://api.github.com/users/anoadragon453/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/anoadragon453/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/anoadragon453/subscriptions', 'organizations_url': 'https://api.github.com/users/anoadragon453/orgs', 'repos_url': 'https://api.github.com/users/anoadragon453/repos', 'events_url': 'https://api.github.com/users/anoadragon453/events{/privacy}', 'received_events_url': 'https://api.github.com/users/anoadragon453/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,1,2020-05-06T11:19:03Z,2020-05-08T18:25:50Z,2020-05-08T18:25:49Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7435', 'html_url': 'https://github.com/matrix-org/synapse/pull/7435', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7435.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7435.patch'}","Fixes: https://github.com/matrix-org/synapse/issues/6758
Allows a sysadmin to run multiple spam checker modules at once. Keeps backwards compatibility with the old config. Improves config format/documentation in the process.",
854,https://api.github.com/repos/matrix-org/synapse/issues/7434,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7434/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7434/comments,https://api.github.com/repos/matrix-org/synapse/issues/7434/events,https://github.com/matrix-org/synapse/issues/7434,613190901,MDU6SXNzdWU2MTMxOTA5MDE=,7434,Push Notification,"{'login': 'GenaIT', 'id': 64897721, 'node_id': 'MDQ6VXNlcjY0ODk3NzIx', 'avatar_url': 'https://avatars1.githubusercontent.com/u/64897721?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/GenaIT', 'html_url': 'https://github.com/GenaIT', 'followers_url': 'https://api.github.com/users/GenaIT/followers', 'following_url': 'https://api.github.com/users/GenaIT/following{/other_user}', 'gists_url': 'https://api.github.com/users/GenaIT/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/GenaIT/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/GenaIT/subscriptions', 'organizations_url': 'https://api.github.com/users/GenaIT/orgs', 'repos_url': 'https://api.github.com/users/GenaIT/repos', 'events_url': 'https://api.github.com/users/GenaIT/events{/privacy}', 'received_events_url': 'https://api.github.com/users/GenaIT/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,0,2020-05-06T09:50:11Z,2020-05-06T09:58:48Z,2020-05-06T09:58:48Z,NONE,,,"Hi guys.
After today's update of the Application Riot
push notifications stopped coming (from group or private messages)
OS: Win Server 2012R2",
855,https://api.github.com/repos/matrix-org/synapse/issues/7433,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7433/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7433/comments,https://api.github.com/repos/matrix-org/synapse/issues/7433/events,https://github.com/matrix-org/synapse/issues/7433,613185837,MDU6SXNzdWU2MTMxODU4Mzc=,7433,Add option for disable all E2E encription stuff on server side,"{'login': 'MurzNN', 'id': 336662, 'node_id': 'MDQ6VXNlcjMzNjY2Mg==', 'avatar_url': 'https://avatars1.githubusercontent.com/u/336662?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/MurzNN', 'html_url': 'https://github.com/MurzNN', 'followers_url': 'https://api.github.com/users/MurzNN/followers', 'following_url': 'https://api.github.com/users/MurzNN/following{/other_user}', 'gists_url': 'https://api.github.com/users/MurzNN/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/MurzNN/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/MurzNN/subscriptions', 'organizations_url': 'https://api.github.com/users/MurzNN/orgs', 'repos_url': 'https://api.github.com/users/MurzNN/repos', 'events_url': 'https://api.github.com/users/MurzNN/events{/privacy}', 'received_events_url': 'https://api.github.com/users/MurzNN/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,1,2020-05-06T09:41:47Z,2020-05-06T11:07:19Z,2020-05-06T11:07:19Z,NONE,,,"Some organizations needs, that all messages will be available on server side unencrypted, without E2EE. So we need the way to disable all E2EE stuff globally on server side.
Can you provide some option in Synapse config to disable all E2EE features on current server?",
856,https://api.github.com/repos/matrix-org/synapse/issues/7432,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7432/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7432/comments,https://api.github.com/repos/matrix-org/synapse/issues/7432/events,https://github.com/matrix-org/synapse/issues/7432,613177554,MDU6SXNzdWU2MTMxNzc1NTQ=,7432,Ignore sending PUSH notifications for muted rooms,"{'login': 'MurzNN', 'id': 336662, 'node_id': 'MDQ6VXNlcjMzNjY2Mg==', 'avatar_url': 'https://avatars1.githubusercontent.com/u/336662?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/MurzNN', 'html_url': 'https://github.com/MurzNN', 'followers_url': 'https://api.github.com/users/MurzNN/followers', 'following_url': 'https://api.github.com/users/MurzNN/following{/other_user}', 'gists_url': 'https://api.github.com/users/MurzNN/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/MurzNN/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/MurzNN/subscriptions', 'organizations_url': 'https://api.github.com/users/MurzNN/orgs', 'repos_url': 'https://api.github.com/users/MurzNN/repos', 'events_url': 'https://api.github.com/users/MurzNN/events{/privacy}', 'received_events_url': 'https://api.github.com/users/MurzNN/received_events', 'type': 'User', 'site_admin': False}","[{'id': 1311133228, 'node_id': 'MDU6TGFiZWwxMzExMTMzMjI4', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/info-needed', 'name': 'info-needed', 'color': 'a1e8ea', 'default': False, 'description': ''}]",closed,False,,[],,5,2020-05-06T09:27:49Z,2020-05-06T13:47:50Z,2020-05-06T13:23:11Z,NONE,,,"At now, as I understand, Synapse sends PUSH notifications for all new messages, even if room is muted. This way unnecessary eats battery&traffic on mobile devices, because users not often reads muted rooms. So sending only one first PUSH for make room ""bold"" on new unread message is enough for most users.
Can we add feature to disable sending unnecessary PUSH notifications to devices from muted rooms? Related Riot issue is https://github.com/vector-im/riot-web/issues/7438",
857,https://api.github.com/repos/matrix-org/synapse/issues/7431,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7431/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7431/comments,https://api.github.com/repos/matrix-org/synapse/issues/7431/events,https://github.com/matrix-org/synapse/issues/7431,613050041,MDU6SXNzdWU2MTMwNTAwNDE=,7431,How to disable encryption e2e permanently ,"{'login': 'anilk9096', 'id': 43886849, 'node_id': 'MDQ6VXNlcjQzODg2ODQ5', 'avatar_url': 'https://avatars1.githubusercontent.com/u/43886849?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/anilk9096', 'html_url': 'https://github.com/anilk9096', 'followers_url': 'https://api.github.com/users/anilk9096/followers', 'following_url': 'https://api.github.com/users/anilk9096/following{/other_user}', 'gists_url': 'https://api.github.com/users/anilk9096/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/anilk9096/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/anilk9096/subscriptions', 'organizations_url': 'https://api.github.com/users/anilk9096/orgs', 'repos_url': 'https://api.github.com/users/anilk9096/repos', 'events_url': 'https://api.github.com/users/anilk9096/events{/privacy}', 'received_events_url': 'https://api.github.com/users/anilk9096/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,1,2020-05-06T04:57:04Z,2020-05-06T08:36:30Z,2020-05-06T08:36:30Z,NONE,,,"Hi,
Thanks for synapse it was nice. My requirement was internal usage for communication on multiple devices same time . E2E creating lot of problems . Can you please guide me to disable E22 permanently for DIRECT MESSAGES, ROOMS from home server .
Note : I dont need federation
",
858,https://api.github.com/repos/matrix-org/synapse/issues/7430,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7430/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7430/comments,https://api.github.com/repos/matrix-org/synapse/issues/7430/events,https://github.com/matrix-org/synapse/issues/7430,613040405,MDU6SXNzdWU2MTMwNDA0MDU=,7430,Potential loop deadlock when AS doesn't keep track of local room alias,"{'login': 'berniezhao11', 'id': 37089290, 'node_id': 'MDQ6VXNlcjM3MDg5Mjkw', 'avatar_url': 'https://avatars1.githubusercontent.com/u/37089290?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/berniezhao11', 'html_url': 'https://github.com/berniezhao11', 'followers_url': 'https://api.github.com/users/berniezhao11/followers', 'following_url': 'https://api.github.com/users/berniezhao11/following{/other_user}', 'gists_url': 'https://api.github.com/users/berniezhao11/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/berniezhao11/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/berniezhao11/subscriptions', 'organizations_url': 'https://api.github.com/users/berniezhao11/orgs', 'repos_url': 'https://api.github.com/users/berniezhao11/repos', 'events_url': 'https://api.github.com/users/berniezhao11/events{/privacy}', 'received_events_url': 'https://api.github.com/users/berniezhao11/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,1,2020-05-06T04:23:45Z,2020-05-06T04:59:53Z,2020-05-06T04:59:53Z,NONE,,,"### Description
We register an AS to handle room creation as bot. The AS does not have local database of room alias but rather relying on HS for alias.
When creating room (with alias), AS will check with HS if alias already exists by `directory/room/{alias}`.
This will trigger HS to lookup back to AS asking if alias exists. Since AS doesn't know locally it can only ask HS again...hence AS to lookup to HS...repeat.
### Steps to reproduce
- Register AS with alias
```
aliases:
- exclusive: false
regex: '#foo.*'
```
- Now AS wants to create a room with alias `#foo.bar`
- AS calls `directory/room/{alias}` to check if `#foo.bar` to avoid duplicate before creating room
- HS will ask AS ""does #foo.bar exists?""
- AS calls `directory/room/{alias}` in order to respond to HS
- HS will ask AS ""does #foo.bar exists?""
- ...
### Version information
- **Version**: 1.12.3
- **Install method**:
package manager
- **Platform**:
Ubuntu 18.04
",
859,https://api.github.com/repos/matrix-org/synapse/issues/7429,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7429/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7429/comments,https://api.github.com/repos/matrix-org/synapse/issues/7429/events,https://github.com/matrix-org/synapse/pull/7429,612972718,MDExOlB1bGxSZXF1ZXN0NDEzODE2MjIz,7429,use an upsert to update device_lists_outbound_last_success,"{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,0,2020-05-06T00:21:04Z,2020-05-06T10:53:20Z,2020-05-06T10:53:19Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7429', 'html_url': 'https://github.com/matrix-org/synapse/pull/7429', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7429.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7429.patch'}",I rather hope that this will be more efficient than the current round-the-houses thing it does.,
860,https://api.github.com/repos/matrix-org/synapse/issues/7428,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7428/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7428/comments,https://api.github.com/repos/matrix-org/synapse/issues/7428/events,https://github.com/matrix-org/synapse/pull/7428,612949333,MDExOlB1bGxSZXF1ZXN0NDEzNzk3MTcx,7428,Make get_e2e_cross_signing_key delegate to get_e2e_cross_signing_keys_bulk,"{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,0,2020-05-05T23:11:27Z,2020-05-06T11:00:03Z,2020-05-06T11:00:02Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7428', 'html_url': 'https://github.com/matrix-org/synapse/pull/7428', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7428.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7428.patch'}","... mostly because the latter has a cache.
Also (in a separate commit), some fixes for the batching in the bulk lookup methods.",
861,https://api.github.com/repos/matrix-org/synapse/issues/7427,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7427/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7427/comments,https://api.github.com/repos/matrix-org/synapse/issues/7427/events,https://github.com/matrix-org/synapse/pull/7427,612822298,MDExOlB1bGxSZXF1ZXN0NDEzNjk0MDE1,7427,Fix lost events on replication reconnection,"{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,1,2020-05-05T18:56:28Z,2020-05-06T09:54:27Z,2020-05-06T09:54:26Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7427', 'html_url': 'https://github.com/matrix-org/synapse/pull/7427', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7427.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7427.patch'}","There were two separate (but related) problems:
1. when we connected to redis, we would immediately send a REPLICATE command, without waiting for our SUBSCRIBE to complete. That could result in us missing the POSITION responses.
2. but that bug was masked by another one, which was that we didn't mark streams as disconnected when we lost the replication connection, which meant that we didn't wait for the POSITION when we reconnected.
(also a bit of logging to help with debugging this stuff)",
862,https://api.github.com/repos/matrix-org/synapse/issues/7426,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7426/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7426/comments,https://api.github.com/repos/matrix-org/synapse/issues/7426/events,https://github.com/matrix-org/synapse/pull/7426,612789466,MDExOlB1bGxSZXF1ZXN0NDEzNjY3NjE5,7426,Improve per-block CPU and DB usage metrics,"{'login': 'clokep', 'id': 517124, 'node_id': 'MDQ6VXNlcjUxNzEyNA==', 'avatar_url': 'https://avatars2.githubusercontent.com/u/517124?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/clokep', 'html_url': 'https://github.com/clokep', 'followers_url': 'https://api.github.com/users/clokep/followers', 'following_url': 'https://api.github.com/users/clokep/following{/other_user}', 'gists_url': 'https://api.github.com/users/clokep/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/clokep/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/clokep/subscriptions', 'organizations_url': 'https://api.github.com/users/clokep/orgs', 'repos_url': 'https://api.github.com/users/clokep/repos', 'events_url': 'https://api.github.com/users/clokep/events{/privacy}', 'received_events_url': 'https://api.github.com/users/clokep/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,1,2020-05-05T17:59:22Z,2020-05-06T20:43:41Z,2020-05-06T20:43:39Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7426', 'html_url': 'https://github.com/matrix-org/synapse/pull/7426', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7426.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7426.patch'}","This reworks the code to incrementally report the resource usage of a context to a context's parent, but avoids resetting the resource usage.
Fixes #7370",
863,https://api.github.com/repos/matrix-org/synapse/issues/7425,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7425/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7425/comments,https://api.github.com/repos/matrix-org/synapse/issues/7425/events,https://github.com/matrix-org/synapse/issues/7425,612738082,MDU6SXNzdWU2MTI3MzgwODI=,7425,Synapse receiving improper federation traffic,"{'login': 'kazomi', 'id': 4442088, 'node_id': 'MDQ6VXNlcjQ0NDIwODg=', 'avatar_url': 'https://avatars2.githubusercontent.com/u/4442088?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/kazomi', 'html_url': 'https://github.com/kazomi', 'followers_url': 'https://api.github.com/users/kazomi/followers', 'following_url': 'https://api.github.com/users/kazomi/following{/other_user}', 'gists_url': 'https://api.github.com/users/kazomi/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/kazomi/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/kazomi/subscriptions', 'organizations_url': 'https://api.github.com/users/kazomi/orgs', 'repos_url': 'https://api.github.com/users/kazomi/repos', 'events_url': 'https://api.github.com/users/kazomi/events{/privacy}', 'received_events_url': 'https://api.github.com/users/kazomi/received_events', 'type': 'User', 'site_admin': False}","[{'id': 121086029, 'node_id': 'MDU6TGFiZWwxMjEwODYwMjk=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/bug', 'name': 'bug', 'color': 'fc2929', 'default': True, 'description': None}, {'id': 477050471, 'node_id': 'MDU6TGFiZWw0NzcwNTA0NzE=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/p3', 'name': 'p3', 'color': '0e8a16', 'default': False, 'description': None}]",closed,False,,[],,11,2020-05-05T16:35:11Z,2020-05-22T15:14:50Z,2020-05-12T14:11:27Z,NONE,,,"### Description
After leaving various federated rooms, homeserver.log is still showing federation traffic from other homeservers.
### Steps to reproduce
- Join any room from the Matrix.org room list
- Leave it
### `homeserver.log` snippets:
```
2020-05-05 12:27:07,176 - synapse.federation.transport.server - 406 - INFO - PUT-928 - Received txn 1585878971193 from [redacted]. (PDUs: 0, EDUs: 1)
2020-05-05 12:27:07,194 - synapse.access.http.8008 - 302 - INFO - PUT-928 - [redacted] - 8008 - {[redacted]} Processed request: 0.020sec/0.001sec (0.005sec, 0.000sec) (0.002sec/0.011sec/3) 12B 200 ""PUT /_matrix/federation/v1/send/1585878971193 HTTP/1.1"" ""Synapse/1.12.2"" [0 dbevts]
2020-05-05 12:27:07,254 - synapse.federation.transport.server - 406 - INFO - PUT-929 - Received txn 1588117400422 from [redacted]. (PDUs: 0, EDUs: 1)
2020-05-05 12:27:07,277 - synapse.access.http.8008 - 302 - INFO - PUT-929 - [redacted] - 8008 - {[redacted]} Processed request: 0.026sec/0.000sec (0.001sec, 0.002sec) (0.002sec/0.018sec/4) 12B 200 ""PUT /_matrix/federation/v1/send/1588117400422 HTTP/1.1"" ""Synapse/1.12.4"" [0 dbevts]
2020-05-05 12:27:07,890 - synapse.federation.transport.server - 406 - INFO - PUT-930 - Received txn 1588117402383 from [redacted]. (PDUs: 0, EDUs: 1)
2020-05-05 12:27:07,902 - synapse.access.http.8008 - 302 - INFO - PUT-930 - [redacted] - 8008 - {[redacted]} Processed request: 0.014sec/0.000sec (0.001sec, 0.000sec) (0.001sec/0.008sec/2) 12B 200 ""PUT /_matrix/federation/v1/send/1588117402383 HTTP/1.1"" ""Synapse/1.12.4"" [0 dbevts]
```
### Version information
- **Version**:
```
{
""python_version"": ""3.6.9"",
""server_version"": ""1.12.4""
}
```
- **Install method**: `pip`
- **Platform**:
Running on Ubuntu Server 18.04 LTS on a Dell Optiplex 790, baremetal.
Experienced this issue when running in a VM as well.",
864,https://api.github.com/repos/matrix-org/synapse/issues/7424,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7424/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7424/comments,https://api.github.com/repos/matrix-org/synapse/issues/7424/events,https://github.com/matrix-org/synapse/issues/7424,612732270,MDU6SXNzdWU2MTI3MzIyNzA=,7424,Room power levels for community members,"{'login': 'jonsutherland', 'id': 884351, 'node_id': 'MDQ6VXNlcjg4NDM1MQ==', 'avatar_url': 'https://avatars3.githubusercontent.com/u/884351?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/jonsutherland', 'html_url': 'https://github.com/jonsutherland', 'followers_url': 'https://api.github.com/users/jonsutherland/followers', 'following_url': 'https://api.github.com/users/jonsutherland/following{/other_user}', 'gists_url': 'https://api.github.com/users/jonsutherland/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/jonsutherland/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/jonsutherland/subscriptions', 'organizations_url': 'https://api.github.com/users/jonsutherland/orgs', 'repos_url': 'https://api.github.com/users/jonsutherland/repos', 'events_url': 'https://api.github.com/users/jonsutherland/events{/privacy}', 'received_events_url': 'https://api.github.com/users/jonsutherland/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,1,2020-05-05T16:26:17Z,2020-05-07T10:59:06Z,2020-05-07T10:58:54Z,NONE,,,"**Description:**
It would be useful to be able to set power levels for community members for a room. So if a user is a member of a community, I should be able to set all community members for a room to have moderator level permissions for a room, or give community members elevated power levels for a room.
Something like setting a rooms m.room.power_levels but with +community_name@homeserver.url groupId you're setting power levels for?",
865,https://api.github.com/repos/matrix-org/synapse/issues/7423,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7423/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7423/comments,https://api.github.com/repos/matrix-org/synapse/issues/7423/events,https://github.com/matrix-org/synapse/pull/7423,612721359,MDExOlB1bGxSZXF1ZXN0NDEzNjEyMzYw,7423,Speed up fetching device lists changes in sync.,"{'login': 'erikjohnston', 'id': 8428120, 'node_id': 'MDQ6VXNlcjg0MjgxMjA=', 'avatar_url': 'https://avatars0.githubusercontent.com/u/8428120?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/erikjohnston', 'html_url': 'https://github.com/erikjohnston', 'followers_url': 'https://api.github.com/users/erikjohnston/followers', 'following_url': 'https://api.github.com/users/erikjohnston/following{/other_user}', 'gists_url': 'https://api.github.com/users/erikjohnston/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/erikjohnston/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/erikjohnston/subscriptions', 'organizations_url': 'https://api.github.com/users/erikjohnston/orgs', 'repos_url': 'https://api.github.com/users/erikjohnston/repos', 'events_url': 'https://api.github.com/users/erikjohnston/events{/privacy}', 'received_events_url': 'https://api.github.com/users/erikjohnston/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,0,2020-05-05T16:10:17Z,2020-05-06T10:14:15Z,2020-05-06T10:14:14Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7423', 'html_url': 'https://github.com/matrix-org/synapse/pull/7423', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7423.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7423.patch'}","Currently we copy `users_who_share_room` needlessly about three times,
which is expensive when the set is large (which it can easily be).
This is based off a commit that is common to `develop` and `matrix-org-hotfixes`",
866,https://api.github.com/repos/matrix-org/synapse/issues/7422,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7422/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7422/comments,https://api.github.com/repos/matrix-org/synapse/issues/7422/events,https://github.com/matrix-org/synapse/pull/7422,612697993,MDExOlB1bGxSZXF1ZXN0NDEzNTkzMzkx,7422,Add a configuration setting for the dummy event threshold,"{'login': 'babolivier', 'id': 5547783, 'node_id': 'MDQ6VXNlcjU1NDc3ODM=', 'avatar_url': 'https://avatars3.githubusercontent.com/u/5547783?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/babolivier', 'html_url': 'https://github.com/babolivier', 'followers_url': 'https://api.github.com/users/babolivier/followers', 'following_url': 'https://api.github.com/users/babolivier/following{/other_user}', 'gists_url': 'https://api.github.com/users/babolivier/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/babolivier/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/babolivier/subscriptions', 'organizations_url': 'https://api.github.com/users/babolivier/orgs', 'repos_url': 'https://api.github.com/users/babolivier/repos', 'events_url': 'https://api.github.com/users/babolivier/events{/privacy}', 'received_events_url': 'https://api.github.com/users/babolivier/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,0,2020-05-05T15:36:24Z,2020-05-07T09:35:25Z,2020-05-07T09:35:24Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7422', 'html_url': 'https://github.com/matrix-org/synapse/pull/7422', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7422.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7422.patch'}","Add `dummy_events_threshold` which allows configuring the number of forward extremities a room needs for Synapse to send forward extremities in it.
~I decided not to expose it in the sample config as the flag to enable/disable that feature is also hidden from there.~
Fixes https://github.com/matrix-org/synapse/issues/7413",
867,https://api.github.com/repos/matrix-org/synapse/issues/7421,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7421/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7421/comments,https://api.github.com/repos/matrix-org/synapse/issues/7421/events,https://github.com/matrix-org/synapse/pull/7421,612679926,MDExOlB1bGxSZXF1ZXN0NDEzNTc4Njgy,7421,Move logs about discarded RDATA to debug,"{'login': 'babolivier', 'id': 5547783, 'node_id': 'MDQ6VXNlcjU1NDc3ODM=', 'avatar_url': 'https://avatars3.githubusercontent.com/u/5547783?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/babolivier', 'html_url': 'https://github.com/babolivier', 'followers_url': 'https://api.github.com/users/babolivier/followers', 'following_url': 'https://api.github.com/users/babolivier/following{/other_user}', 'gists_url': 'https://api.github.com/users/babolivier/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/babolivier/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/babolivier/subscriptions', 'organizations_url': 'https://api.github.com/users/babolivier/orgs', 'repos_url': 'https://api.github.com/users/babolivier/repos', 'events_url': 'https://api.github.com/users/babolivier/events{/privacy}', 'received_events_url': 'https://api.github.com/users/babolivier/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,0,2020-05-05T15:11:46Z,2020-05-05T19:07:35Z,2020-05-05T19:07:34Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7421', 'html_url': 'https://github.com/matrix-org/synapse/pull/7421', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7421.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7421.patch'}","Cherry-pick of https://github.com/matrix-org/synapse/commit/105cadbc9afd89be72762160d53c9f782b9be133
Fixes https://github.com/matrix-org/synapse/issues/7412",
868,https://api.github.com/repos/matrix-org/synapse/issues/7420,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7420/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7420/comments,https://api.github.com/repos/matrix-org/synapse/issues/7420/events,https://github.com/matrix-org/synapse/pull/7420,612664992,MDExOlB1bGxSZXF1ZXN0NDEzNTY2NjM0,7420,Stop Auth methods from polling the config on every req.,"{'login': 'anoadragon453', 'id': 1342360, 'node_id': 'MDQ6VXNlcjEzNDIzNjA=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1342360?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/anoadragon453', 'html_url': 'https://github.com/anoadragon453', 'followers_url': 'https://api.github.com/users/anoadragon453/followers', 'following_url': 'https://api.github.com/users/anoadragon453/following{/other_user}', 'gists_url': 'https://api.github.com/users/anoadragon453/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/anoadragon453/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/anoadragon453/subscriptions', 'organizations_url': 'https://api.github.com/users/anoadragon453/orgs', 'repos_url': 'https://api.github.com/users/anoadragon453/repos', 'events_url': 'https://api.github.com/users/anoadragon453/events{/privacy}', 'received_events_url': 'https://api.github.com/users/anoadragon453/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,0,2020-05-05T14:51:47Z,2020-05-06T14:55:00Z,2020-05-06T14:54:59Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7420', 'html_url': 'https://github.com/matrix-org/synapse/pull/7420', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7420.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7420.patch'}","Fixes https://github.com/matrix-org/synapse/issues/7419
Polls all the config options on server setup instead of every req. `check_auth_blocking`, which used the majority of the config options, was moved to a separate class to keep `Auth` clean.
Merging to the release branch to help get this out on matrix.org.
Edit: Lots of tests needed to be updated as they modified the hs' config after the hs had been initialized, which means `check_auth_blocking`, which pulls options on hs intiialization, would be using stale values. These tests were changed such that they modify values in the new `AuthBlocking` class instead of the hs' config.",
869,https://api.github.com/repos/matrix-org/synapse/issues/7419,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7419/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7419/comments,https://api.github.com/repos/matrix-org/synapse/issues/7419/events,https://github.com/matrix-org/synapse/issues/7419,612620853,MDU6SXNzdWU2MTI2MjA4NTM=,7419,check_auth_blocking is burning 5% CPU,"{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}","[{'id': 477045093, 'node_id': 'MDU6TGFiZWw0NzcwNDUwOTM=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/p1', 'name': 'p1', 'color': 'd93f0b', 'default': False, 'description': None}, {'id': 600557921, 'node_id': 'MDU6TGFiZWw2MDA1NTc5MjE=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/performance', 'name': 'performance', 'color': 'fef2c0', 'default': False, 'description': None}]",closed,False,"{'login': 'anoadragon453', 'id': 1342360, 'node_id': 'MDQ6VXNlcjEzNDIzNjA=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1342360?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/anoadragon453', 'html_url': 'https://github.com/anoadragon453', 'followers_url': 'https://api.github.com/users/anoadragon453/followers', 'following_url': 'https://api.github.com/users/anoadragon453/following{/other_user}', 'gists_url': 'https://api.github.com/users/anoadragon453/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/anoadragon453/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/anoadragon453/subscriptions', 'organizations_url': 'https://api.github.com/users/anoadragon453/orgs', 'repos_url': 'https://api.github.com/users/anoadragon453/repos', 'events_url': 'https://api.github.com/users/anoadragon453/events{/privacy}', 'received_events_url': 'https://api.github.com/users/anoadragon453/received_events', 'type': 'User', 'site_admin': False}","[{'login': 'anoadragon453', 'id': 1342360, 'node_id': 'MDQ6VXNlcjEzNDIzNjA=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1342360?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/anoadragon453', 'html_url': 'https://github.com/anoadragon453', 'followers_url': 'https://api.github.com/users/anoadragon453/followers', 'following_url': 'https://api.github.com/users/anoadragon453/following{/other_user}', 'gists_url': 'https://api.github.com/users/anoadragon453/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/anoadragon453/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/anoadragon453/subscriptions', 'organizations_url': 'https://api.github.com/users/anoadragon453/orgs', 'repos_url': 'https://api.github.com/users/anoadragon453/repos', 'events_url': 'https://api.github.com/users/anoadragon453/events{/privacy}', 'received_events_url': 'https://api.github.com/users/anoadragon453/received_events', 'type': 'User', 'site_admin': False}]",,2,2020-05-05T13:53:20Z,2020-05-06T15:23:08Z,2020-05-06T15:23:08Z,MEMBER,,,"mostly because it looks up a load of config settings on each call, each of which is reasonably expensive. we don't even use auth_blocking on matrix.org. it needs to be made less inefficient.",
870,https://api.github.com/repos/matrix-org/synapse/issues/7418,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7418/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7418/comments,https://api.github.com/repos/matrix-org/synapse/issues/7418/events,https://github.com/matrix-org/synapse/issues/7418,612614423,MDU6SXNzdWU2MTI2MTQ0MjM=,7418,Cross-signing signatures not being always federated correctly,"{'login': 'babolivier', 'id': 5547783, 'node_id': 'MDQ6VXNlcjU1NDc3ODM=', 'avatar_url': 'https://avatars3.githubusercontent.com/u/5547783?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/babolivier', 'html_url': 'https://github.com/babolivier', 'followers_url': 'https://api.github.com/users/babolivier/followers', 'following_url': 'https://api.github.com/users/babolivier/following{/other_user}', 'gists_url': 'https://api.github.com/users/babolivier/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/babolivier/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/babolivier/subscriptions', 'organizations_url': 'https://api.github.com/users/babolivier/orgs', 'repos_url': 'https://api.github.com/users/babolivier/repos', 'events_url': 'https://api.github.com/users/babolivier/events{/privacy}', 'received_events_url': 'https://api.github.com/users/babolivier/received_events', 'type': 'User', 'site_admin': False}","[{'id': 121086029, 'node_id': 'MDU6TGFiZWwxMjEwODYwMjk=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/bug', 'name': 'bug', 'color': 'fc2929', 'default': True, 'description': None}, {'id': 2038497284, 'node_id': 'MDU6TGFiZWwyMDM4NDk3Mjg0', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/cross-signing', 'name': 'cross-signing', 'color': 'cceaff', 'default': False, 'description': ''}, {'id': 477043173, 'node_id': 'MDU6TGFiZWw0NzcwNDMxNzM=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/p2', 'name': 'p2', 'color': 'fbca04', 'default': False, 'description': None}, {'id': 1709952128, 'node_id': 'MDU6TGFiZWwxNzA5OTUyMTI4', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/story:1', 'name': 'story:1', 'color': 'b4f291', 'default': False, 'description': 'As a user I want to cross-sign my own devices'}]",closed,False,"{'login': 'babolivier', 'id': 5547783, 'node_id': 'MDQ6VXNlcjU1NDc3ODM=', 'avatar_url': 'https://avatars3.githubusercontent.com/u/5547783?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/babolivier', 'html_url': 'https://github.com/babolivier', 'followers_url': 'https://api.github.com/users/babolivier/followers', 'following_url': 'https://api.github.com/users/babolivier/following{/other_user}', 'gists_url': 'https://api.github.com/users/babolivier/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/babolivier/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/babolivier/subscriptions', 'organizations_url': 'https://api.github.com/users/babolivier/orgs', 'repos_url': 'https://api.github.com/users/babolivier/repos', 'events_url': 'https://api.github.com/users/babolivier/events{/privacy}', 'received_events_url': 'https://api.github.com/users/babolivier/received_events', 'type': 'User', 'site_admin': False}","[{'login': 'babolivier', 'id': 5547783, 'node_id': 'MDQ6VXNlcjU1NDc3ODM=', 'avatar_url': 'https://avatars3.githubusercontent.com/u/5547783?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/babolivier', 'html_url': 'https://github.com/babolivier', 'followers_url': 'https://api.github.com/users/babolivier/followers', 'following_url': 'https://api.github.com/users/babolivier/following{/other_user}', 'gists_url': 'https://api.github.com/users/babolivier/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/babolivier/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/babolivier/subscriptions', 'organizations_url': 'https://api.github.com/users/babolivier/orgs', 'repos_url': 'https://api.github.com/users/babolivier/repos', 'events_url': 'https://api.github.com/users/babolivier/events{/privacy}', 'received_events_url': 'https://api.github.com/users/babolivier/received_events', 'type': 'User', 'site_admin': False}]",,14,2020-05-05T13:44:38Z,2020-05-21T15:45:06Z,2020-05-21T15:41:13Z,MEMBER,,,"Over the past couple of days I've seen a few occurrences of people on other servers verifying a new device, but my server not receiving the resulting signature, thus leaving them with a red shield from my pov. I've also seen people saying they were seeing others with a red shield whereas I would see them with a green one.
@bwindels had a look at my Riot logs upon failing to see one of @anoadragon453's devices as verified, and could see that it was indeed missing a signature, with the signatures on Andrew's device being:
```json
""signatures"": {
""@andrewm:amorgan.xyz"": {
""ed25519:ZYMXYYQZTP"": ""aBAnNnO3Qzz8xMLXtSjnwDummc4F4vewygUBvdRKJWd2/326Se4knYkJkp/TKa0sXjeGKIUko8JXNorN2m9TDw"",
""ed25519:QjSD8srN17RiDzIBgzVbncj+NMdvDHRY4N2b8w+oq9Y"": ""FV5bCKEdp1q9SFvy7MzUgTj3SzAeHwuK4vvtgnIp/WFxdnYQ4XL2C64dW28oJsK4yJ95NkuFcL9uCTPaDKPoAw""
}
}
```
and the ones my Riot would see for that same device being:
```json
""signatures"": {
""@andrewm:amorgan.xyz"": {
""ed25519:ZYMXYYQZTP"": ""aBAnNnO3Qzz8xMLXtSjnwDummc4F4vewygUBvdRKJWd2/326Se4knYkJkp/TKa0sXjeGKIUko8JXNorN2m9TDw""
}
}
```
Looking at the `device_lists_remote_cache` on my homeserver's database, I can see that it's indeed missing the signature from Andrew's self-signing key (`ed25519:QjSD8srN17RiDzIBgzVbncj+NMdvDHRY4N2b8w+oq9Y`).
https://github.com/matrix-org/riot-web-rageshakes/issues/2740#issuecomment-623992322 provides more info about that specific occurrence.",
871,https://api.github.com/repos/matrix-org/synapse/issues/7417,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7417/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7417/comments,https://api.github.com/repos/matrix-org/synapse/issues/7417/events,https://github.com/matrix-org/synapse/issues/7417,612488295,MDU6SXNzdWU2MTI0ODgyOTU=,7417,Unique constraints seem to be disappearing from the database,"{'login': 'babolivier', 'id': 5547783, 'node_id': 'MDQ6VXNlcjU1NDc3ODM=', 'avatar_url': 'https://avatars3.githubusercontent.com/u/5547783?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/babolivier', 'html_url': 'https://github.com/babolivier', 'followers_url': 'https://api.github.com/users/babolivier/followers', 'following_url': 'https://api.github.com/users/babolivier/following{/other_user}', 'gists_url': 'https://api.github.com/users/babolivier/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/babolivier/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/babolivier/subscriptions', 'organizations_url': 'https://api.github.com/users/babolivier/orgs', 'repos_url': 'https://api.github.com/users/babolivier/repos', 'events_url': 'https://api.github.com/users/babolivier/events{/privacy}', 'received_events_url': 'https://api.github.com/users/babolivier/received_events', 'type': 'User', 'site_admin': False}","[{'id': 121086029, 'node_id': 'MDU6TGFiZWwxMjEwODYwMjk=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/bug', 'name': 'bug', 'color': 'fc2929', 'default': True, 'description': None}, {'id': 477043173, 'node_id': 'MDU6TGFiZWw0NzcwNDMxNzM=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/p2', 'name': 'p2', 'color': 'fbca04', 'default': False, 'description': None}]",closed,False,,[],,2,2020-05-05T10:11:49Z,2020-05-05T12:58:07Z,2020-05-05T12:58:07Z,MEMBER,,,"https://github.com/matrix-org/synapse/issues/7399 and https://github.com/matrix-org/synapse/issues/7416 both look like a different unique constraint suddenly disappeared from their database (respectively `account_data_uniqueness` and `device_uniqueness`).
This doesn't seem to be related to sqlite -> postgres migrations, and both these constraints are added during table creation, outside of a background update, so it's not clear to me how this could happen.",
872,https://api.github.com/repos/matrix-org/synapse/issues/7416,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7416/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7416/comments,https://api.github.com/repos/matrix-org/synapse/issues/7416/events,https://github.com/matrix-org/synapse/issues/7416,612469266,MDU6SXNzdWU2MTI0NjkyNjY=,7416,Outgoing federation breaks on client re-opening,"{'login': 'n0emis', 'id': 22817873, 'node_id': 'MDQ6VXNlcjIyODE3ODcz', 'avatar_url': 'https://avatars3.githubusercontent.com/u/22817873?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/n0emis', 'html_url': 'https://github.com/n0emis', 'followers_url': 'https://api.github.com/users/n0emis/followers', 'following_url': 'https://api.github.com/users/n0emis/following{/other_user}', 'gists_url': 'https://api.github.com/users/n0emis/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/n0emis/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/n0emis/subscriptions', 'organizations_url': 'https://api.github.com/users/n0emis/orgs', 'repos_url': 'https://api.github.com/users/n0emis/repos', 'events_url': 'https://api.github.com/users/n0emis/events{/privacy}', 'received_events_url': 'https://api.github.com/users/n0emis/received_events', 'type': 'User', 'site_admin': False}","[{'id': 1311133228, 'node_id': 'MDU6TGFiZWwxMzExMTMzMjI4', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/info-needed', 'name': 'info-needed', 'color': 'a1e8ea', 'default': False, 'description': ''}]",closed,False,,[],,7,2020-05-05T09:36:33Z,2020-06-24T16:06:27Z,2020-06-24T16:06:27Z,NONE,,,"### Description
Yesterday we migrated our synapse installation (which has about 80 users) from a docker-based installation into a virtualenv. Also we upgraded the version in this progress from version 1.12.3 to 1.12.4. Since that we have had the following issue **multiple times**:
- We saw that the server stopped federating. (Only outgoing federation breaks, not incoming.) The log was showing the following error many times (for each other hs we tried to federate with):
```
May 04 20:05:50 chaos matrix-synapse[2450]: 2020-05-04 20:05:50,798 - synapse.federation.sender.per_destination_queue - 332 - ERROR - federation_transaction_transmission_loop-23058 - TX [h-ws.de] Failed to send transaction
May 04 20:05:50 chaos matrix-synapse[2450]: Traceback (most recent call last):
May 04 20:05:50 chaos matrix-synapse[2450]: File ""/opt/venvs/matrix-synapse/lib/python3.6/site-packages/synapse/federation/sender/per_destination_queue.py"", line 201, in _transaction_transmission_loop
May 04 20:05:50 chaos matrix-synapse[2450]: limit
May 04 20:05:50 chaos matrix-synapse[2450]: File ""/opt/venvs/matrix-synapse/lib/python3.6/site-packages/synapse/federation/sender/per_destination_queue.py"", line 368, in _get_device_update_edus
May 04 20:05:50 chaos matrix-synapse[2450]: self._destination, last_device_list, limit=limit
May 04 20:05:50 chaos matrix-synapse[2450]: File ""/opt/venvs/matrix-synapse/lib/python3.6/site-packages/twisted/internet/defer.py"", line 1416, in _inlineCallbacks
May 04 20:05:50 chaos matrix-synapse[2450]: result = result.throwExceptionIntoGenerator(g)
May 04 20:05:50 chaos matrix-synapse[2450]: File ""/opt/venvs/matrix-synapse/lib/python3.6/site-packages/twisted/python/failure.py"", line 512, in throwExceptionIntoGenerator
May 04 20:05:50 chaos matrix-synapse[2450]: return g.throw(self.type, self.value, self.tb)
May 04 20:05:50 chaos matrix-synapse[2450]: File ""/opt/venvs/matrix-synapse/lib/python3.6/site-packages/synapse/storage/data_stores/main/devices.py"", line 233, in get_device_updates_by_remote
May 04 20:05:50 chaos matrix-synapse[2450]: destination, from_stream_id, query_map
May 04 20:05:50 chaos matrix-synapse[2450]: File ""/opt/venvs/matrix-synapse/lib/python3.6/site-packages/twisted/internet/defer.py"", line 1416, in _inlineCallbacks
May 04 20:05:50 chaos matrix-synapse[2450]: result = result.throwExceptionIntoGenerator(g)
May 04 20:05:50 chaos matrix-synapse[2450]: File ""/opt/venvs/matrix-synapse/lib/python3.6/site-packages/twisted/python/failure.py"", line 512, in throwExceptionIntoGenerator
May 04 20:05:50 chaos matrix-synapse[2450]: return g.throw(self.type, self.value, self.tb)
May 04 20:05:50 chaos matrix-synapse[2450]: File ""/opt/venvs/matrix-synapse/lib/python3.6/site-packages/synapse/storage/data_stores/main/devices.py"", line 294, in _get_device_update_edus_by_remote
May 04 20:05:50 chaos matrix-synapse[2450]: else {}
May 04 20:05:50 chaos matrix-synapse[2450]: File ""/opt/venvs/matrix-synapse/lib/python3.6/site-packages/twisted/internet/defer.py"", line 1416, in _inlineCallbacks
May 04 20:05:50 chaos matrix-synapse[2450]: result = result.throwExceptionIntoGenerator(g)
May 04 20:05:50 chaos matrix-synapse[2450]: File ""/opt/venvs/matrix-synapse/lib/python3.6/site-packages/twisted/python/failure.py"", line 512, in throwExceptionIntoGenerator
May 04 20:05:50 chaos matrix-synapse[2450]: return g.throw(self.type, self.value, self.tb)
May 04 20:05:50 chaos matrix-synapse[2450]: File ""/opt/venvs/matrix-synapse/lib/python3.6/site-packages/synapse/storage/database.py"", line 524, in runInteraction
May 04 20:05:50 chaos matrix-synapse[2450]: **kwargs
May 04 20:05:50 chaos matrix-synapse[2450]: File ""/opt/venvs/matrix-synapse/lib/python3.6/site-packages/twisted/internet/defer.py"", line 1416, in _inlineCallbacks
May 04 20:05:50 chaos matrix-synapse[2450]: result = result.throwExceptionIntoGenerator(g)
May 04 20:05:50 chaos matrix-synapse[2450]: File ""/opt/venvs/matrix-synapse/lib/python3.6/site-packages/twisted/python/failure.py"", line 512, in throwExceptionIntoGenerator
May 04 20:05:50 chaos matrix-synapse[2450]: return g.throw(self.type, self.value, self.tb)
May 04 20:05:50 chaos matrix-synapse[2450]: File ""/opt/venvs/matrix-synapse/lib/python3.6/site-packages/synapse/storage/database.py"", line 574, in runWithConnection
May 04 20:05:50 chaos matrix-synapse[2450]: self._db_pool.runWithConnection(inner_func, *args, **kwargs)
May 04 20:05:50 chaos matrix-synapse[2450]: File ""/opt/venvs/matrix-synapse/lib/python3.6/site-packages/twisted/python/threadpool.py"", line 250, in inContext
May 04 20:05:50 chaos matrix-synapse[2450]: result = inContext.theWork()
May 04 20:05:50 chaos matrix-synapse[2450]: File ""/opt/venvs/matrix-synapse/lib/python3.6/site-packages/twisted/python/threadpool.py"", line 266, in
May 04 20:05:50 chaos matrix-synapse[2450]: inContext.theWork = lambda: context.call(ctx, func, *args, **kw)
May 04 20:05:50 chaos matrix-synapse[2450]: File ""/opt/venvs/matrix-synapse/lib/python3.6/site-packages/twisted/python/context.py"", line 122, in callWithContext
May 04 20:05:50 chaos matrix-synapse[2450]: return self.currentContext().callWithContext(ctx, func, *args, **kw)
May 04 20:05:50 chaos matrix-synapse[2450]: File ""/opt/venvs/matrix-synapse/lib/python3.6/site-packages/twisted/python/context.py"", line 85, in callWithContext
May 04 20:05:50 chaos matrix-synapse[2450]: return func(*args,**kw)
May 04 20:05:50 chaos matrix-synapse[2450]: File ""/opt/venvs/matrix-synapse/lib/python3.6/site-packages/twisted/enterprise/adbapi.py"", line 306, in _runWithConnection
May 04 20:05:50 chaos matrix-synapse[2450]: compat.reraise(excValue, excTraceback)
May 04 20:05:50 chaos matrix-synapse[2450]: File ""/opt/venvs/matrix-synapse/lib/python3.6/site-packages/twisted/python/compat.py"", line 464, in reraise
May 04 20:05:50 chaos matrix-synapse[2450]: raise exception.with_traceback(traceback)
May 04 20:05:50 chaos matrix-synapse[2450]: File ""/opt/venvs/matrix-synapse/lib/python3.6/site-packages/twisted/enterprise/adbapi.py"", line 297, in _runWithConnection
May 04 20:05:50 chaos matrix-synapse[2450]: result = func(conn, *args, **kw)
May 04 20:05:50 chaos matrix-synapse[2450]: File ""/opt/venvs/matrix-synapse/lib/python3.6/site-packages/synapse/storage/database.py"", line 571, in inner_func
May 04 20:05:50 chaos matrix-synapse[2450]: return func(conn, *args, **kwargs)
May 04 20:05:50 chaos matrix-synapse[2450]: File ""/opt/venvs/matrix-synapse/lib/python3.6/site-packages/synapse/storage/database.py"", line 407, in new_transaction
May 04 20:05:50 chaos matrix-synapse[2450]: r = func(cursor, *args, **kwargs)
May 04 20:05:50 chaos matrix-synapse[2450]: File ""/opt/venvs/matrix-synapse/lib/python3.6/site-packages/synapse/logging/opentracing.py"", line 709, in _trace_inner
May 04 20:05:50 chaos matrix-synapse[2450]: return func(*args, **kwargs)
May 04 20:05:50 chaos matrix-synapse[2450]: File ""/opt/venvs/matrix-synapse/lib/python3.6/site-packages/synapse/storage/data_stores/main/end_to_end_keys.py"", line 136, in _get_e2e_device_keys_txn
May 04 20:05:50 chaos matrix-synapse[2450]: deleted_devices.remove((row[""user_id""], row[""device_id""]))
May 04 20:05:50 chaos matrix-synapse[2450]: KeyError: ('@n0emis:chaos.jetzt', 'OBAEIZMRVE')
```
- When looking in the database, we saw that the user `@n0emis:chaos.jetzt` and their device `OBAEIZMRVE` had multiple entries in the `devices` table in the database. (See the bottom most entries of the following screenshot)
![Screenshot from 2020-05-04 20-48-03](https://user-images.githubusercontent.com/22817873/81052866-82f43c80-8ec4-11ea-88f5-54cd0968383a.png)
- after deleting one of the entries (one had `display_name` == `none`) the error was fixed and outgoing federation was working again.
- *Sometimes* when a user re-opens their client or clears their client cache, their device gets duplicated.
- Then outgoing federation breaks again.
- We had this happen on many different clients (e.g. RiotWeb, Minivector etc...)
- We have not yet figured out a way to trigger this bug on-purpose.
We have currently setup a cronjob, which runs the following SQL-Query and notifies us via email. Any further feedback on this would be much appreciated...
```sql
select device_id, user_id, count(*)
from devices
group by device_id, user_id
HAVING count(*) > 1
```
### Version information
- **Homeserver**: matrix.chaos.jetzt
- **Version**: 1.12.4
- **Install method**: pip into a virtualenv
- **Platform**: hetzner-vm, Ubuntu 18.04.4 LTS, 4.15.0-99-generic
",
873,https://api.github.com/repos/matrix-org/synapse/issues/7415,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7415/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7415/comments,https://api.github.com/repos/matrix-org/synapse/issues/7415/events,https://github.com/matrix-org/synapse/issues/7415,612464852,MDU6SXNzdWU2MTI0NjQ4NTI=,7415,synchrotrons and federation sender are getting behind on replication,"{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}","[{'id': 2011569249, 'node_id': 'MDU6TGFiZWwyMDExNTY5MjQ5', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/operation%20gemini', 'name': 'operation gemini', 'color': '006b75', 'default': False, 'description': 'Part of the project to fix the cpu bottleneck on'}]",closed,False,,[],,4,2020-05-05T09:28:37Z,2020-05-06T14:27:56Z,2020-05-06T14:27:55Z,MEMBER,,,"I think we might now be processing replication data in smaller chunks than we were before, leading to more /sync wakeups and more outgoing federation requests. Mitigated by adding more synchrotrons but that doesn't solve the problem for federation.",
874,https://api.github.com/repos/matrix-org/synapse/issues/7414,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7414/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7414/comments,https://api.github.com/repos/matrix-org/synapse/issues/7414/events,https://github.com/matrix-org/synapse/issues/7414,612461751,MDU6SXNzdWU2MTI0NjE3NTE=,7414,assertionerrors from dummy event sending process,"{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}","[{'id': 121086029, 'node_id': 'MDU6TGFiZWwxMjEwODYwMjk=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/bug', 'name': 'bug', 'color': 'fc2929', 'default': True, 'description': None}]",closed,False,"{'login': 'anoadragon453', 'id': 1342360, 'node_id': 'MDQ6VXNlcjEzNDIzNjA=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1342360?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/anoadragon453', 'html_url': 'https://github.com/anoadragon453', 'followers_url': 'https://api.github.com/users/anoadragon453/followers', 'following_url': 'https://api.github.com/users/anoadragon453/following{/other_user}', 'gists_url': 'https://api.github.com/users/anoadragon453/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/anoadragon453/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/anoadragon453/subscriptions', 'organizations_url': 'https://api.github.com/users/anoadragon453/orgs', 'repos_url': 'https://api.github.com/users/anoadragon453/repos', 'events_url': 'https://api.github.com/users/anoadragon453/events{/privacy}', 'received_events_url': 'https://api.github.com/users/anoadragon453/received_events', 'type': 'User', 'site_admin': False}","[{'login': 'anoadragon453', 'id': 1342360, 'node_id': 'MDQ6VXNlcjEzNDIzNjA=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1342360?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/anoadragon453', 'html_url': 'https://github.com/anoadragon453', 'followers_url': 'https://api.github.com/users/anoadragon453/followers', 'following_url': 'https://api.github.com/users/anoadragon453/following{/other_user}', 'gists_url': 'https://api.github.com/users/anoadragon453/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/anoadragon453/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/anoadragon453/subscriptions', 'organizations_url': 'https://api.github.com/users/anoadragon453/orgs', 'repos_url': 'https://api.github.com/users/anoadragon453/repos', 'events_url': 'https://api.github.com/users/anoadragon453/events{/privacy}', 'received_events_url': 'https://api.github.com/users/anoadragon453/received_events', 'type': 'User', 'site_admin': False}]",,3,2020-05-05T09:23:08Z,2020-05-13T16:11:47Z,2020-05-13T16:11:47Z,MEMBER,,,"after I lowered the threshold for dummy events (#7413) the logs started filling up with assertionerrors with little clue as to which assertion was failing. I'm fairly sure that wasn't due to my hackery, so this must be an underlying issue. I'd like us to understand the problem here.",
875,https://api.github.com/repos/matrix-org/synapse/issues/7413,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7413/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7413/comments,https://api.github.com/repos/matrix-org/synapse/issues/7413/events,https://github.com/matrix-org/synapse/issues/7413,612460369,MDU6SXNzdWU2MTI0NjAzNjk=,7413,threshold for dummy event sending should be configurable,"{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}","[{'id': 477045093, 'node_id': 'MDU6TGFiZWw0NzcwNDUwOTM=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/p1', 'name': 'p1', 'color': 'd93f0b', 'default': False, 'description': None}, {'id': 600557921, 'node_id': 'MDU6TGFiZWw2MDA1NTc5MjE=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/performance', 'name': 'performance', 'color': 'fef2c0', 'default': False, 'description': None}]",closed,False,"{'login': 'babolivier', 'id': 5547783, 'node_id': 'MDQ6VXNlcjU1NDc3ODM=', 'avatar_url': 'https://avatars3.githubusercontent.com/u/5547783?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/babolivier', 'html_url': 'https://github.com/babolivier', 'followers_url': 'https://api.github.com/users/babolivier/followers', 'following_url': 'https://api.github.com/users/babolivier/following{/other_user}', 'gists_url': 'https://api.github.com/users/babolivier/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/babolivier/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/babolivier/subscriptions', 'organizations_url': 'https://api.github.com/users/babolivier/orgs', 'repos_url': 'https://api.github.com/users/babolivier/repos', 'events_url': 'https://api.github.com/users/babolivier/events{/privacy}', 'received_events_url': 'https://api.github.com/users/babolivier/received_events', 'type': 'User', 'site_admin': False}","[{'login': 'babolivier', 'id': 5547783, 'node_id': 'MDQ6VXNlcjU1NDc3ODM=', 'avatar_url': 'https://avatars3.githubusercontent.com/u/5547783?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/babolivier', 'html_url': 'https://github.com/babolivier', 'followers_url': 'https://api.github.com/users/babolivier/followers', 'following_url': 'https://api.github.com/users/babolivier/following{/other_user}', 'gists_url': 'https://api.github.com/users/babolivier/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/babolivier/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/babolivier/subscriptions', 'organizations_url': 'https://api.github.com/users/babolivier/orgs', 'repos_url': 'https://api.github.com/users/babolivier/repos', 'events_url': 'https://api.github.com/users/babolivier/events{/privacy}', 'received_events_url': 'https://api.github.com/users/babolivier/received_events', 'type': 'User', 'site_admin': False}]",,2,2020-05-05T09:20:32Z,2020-05-11T13:12:11Z,2020-05-11T13:12:11Z,MEMBER,,,we're spending quite a lot of effort doing state res when we get typing notifications in large rooms with 10 extremities. hacking the code (https://github.com/matrix-org/synapse/compare/14bb4cff99ddd8b5eb1816c5405d52a8f13e29d6...1d41815b0980a6c9d6a581e78d2606a41d1d4485) to lower the threshold seemed to improve things. Please can it be configurable?,
876,https://api.github.com/repos/matrix-org/synapse/issues/7412,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7412/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7412/comments,https://api.github.com/repos/matrix-org/synapse/issues/7412/events,https://github.com/matrix-org/synapse/issues/7412,612457521,MDU6SXNzdWU2MTI0NTc1MjE=,7412,synchrotron logs are full of 'Discarding RDATA for unconnected stream federation',"{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}","[{'id': 828666468, 'node_id': 'MDU6TGFiZWw4Mjg2NjY0Njg=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/release%20blocker', 'name': 'release blocker', 'color': '880000', 'default': False, 'description': None}]",closed,False,"{'login': 'babolivier', 'id': 5547783, 'node_id': 'MDQ6VXNlcjU1NDc3ODM=', 'avatar_url': 'https://avatars3.githubusercontent.com/u/5547783?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/babolivier', 'html_url': 'https://github.com/babolivier', 'followers_url': 'https://api.github.com/users/babolivier/followers', 'following_url': 'https://api.github.com/users/babolivier/following{/other_user}', 'gists_url': 'https://api.github.com/users/babolivier/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/babolivier/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/babolivier/subscriptions', 'organizations_url': 'https://api.github.com/users/babolivier/orgs', 'repos_url': 'https://api.github.com/users/babolivier/repos', 'events_url': 'https://api.github.com/users/babolivier/events{/privacy}', 'received_events_url': 'https://api.github.com/users/babolivier/received_events', 'type': 'User', 'site_admin': False}","[{'login': 'babolivier', 'id': 5547783, 'node_id': 'MDQ6VXNlcjU1NDc3ODM=', 'avatar_url': 'https://avatars3.githubusercontent.com/u/5547783?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/babolivier', 'html_url': 'https://github.com/babolivier', 'followers_url': 'https://api.github.com/users/babolivier/followers', 'following_url': 'https://api.github.com/users/babolivier/following{/other_user}', 'gists_url': 'https://api.github.com/users/babolivier/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/babolivier/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/babolivier/subscriptions', 'organizations_url': 'https://api.github.com/users/babolivier/orgs', 'repos_url': 'https://api.github.com/users/babolivier/repos', 'events_url': 'https://api.github.com/users/babolivier/events{/privacy}', 'received_events_url': 'https://api.github.com/users/babolivier/received_events', 'type': 'User', 'site_admin': False}]",,2,2020-05-05T09:15:40Z,2020-05-06T11:32:56Z,2020-05-06T11:32:56Z,MEMBER,,,"this may be fixed in some of erik's forthcoming work, but if not we need to do https://github.com/matrix-org/synapse/commit/105cadbc9afd89be72762160d53c9f782b9be133",
877,https://api.github.com/repos/matrix-org/synapse/issues/7411,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7411/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7411/comments,https://api.github.com/repos/matrix-org/synapse/issues/7411/events,https://github.com/matrix-org/synapse/issues/7411,612456586,MDU6SXNzdWU2MTI0NTY1ODY=,7411,renew_attestations uses a lot of CPU,"{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}","[{'id': 600557921, 'node_id': 'MDU6TGFiZWw2MDA1NTc5MjE=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/performance', 'name': 'performance', 'color': 'fef2c0', 'default': False, 'description': None}, {'id': 828666468, 'node_id': 'MDU6TGFiZWw4Mjg2NjY0Njg=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/release%20blocker', 'name': 'release blocker', 'color': '880000', 'default': False, 'description': None}]",closed,False,"{'login': 'anoadragon453', 'id': 1342360, 'node_id': 'MDQ6VXNlcjEzNDIzNjA=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1342360?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/anoadragon453', 'html_url': 'https://github.com/anoadragon453', 'followers_url': 'https://api.github.com/users/anoadragon453/followers', 'following_url': 'https://api.github.com/users/anoadragon453/following{/other_user}', 'gists_url': 'https://api.github.com/users/anoadragon453/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/anoadragon453/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/anoadragon453/subscriptions', 'organizations_url': 'https://api.github.com/users/anoadragon453/orgs', 'repos_url': 'https://api.github.com/users/anoadragon453/repos', 'events_url': 'https://api.github.com/users/anoadragon453/events{/privacy}', 'received_events_url': 'https://api.github.com/users/anoadragon453/received_events', 'type': 'User', 'site_admin': False}","[{'login': 'anoadragon453', 'id': 1342360, 'node_id': 'MDQ6VXNlcjEzNDIzNjA=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1342360?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/anoadragon453', 'html_url': 'https://github.com/anoadragon453', 'followers_url': 'https://api.github.com/users/anoadragon453/followers', 'following_url': 'https://api.github.com/users/anoadragon453/following{/other_user}', 'gists_url': 'https://api.github.com/users/anoadragon453/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/anoadragon453/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/anoadragon453/subscriptions', 'organizations_url': 'https://api.github.com/users/anoadragon453/orgs', 'repos_url': 'https://api.github.com/users/anoadragon453/repos', 'events_url': 'https://api.github.com/users/anoadragon453/events{/privacy}', 'received_events_url': 'https://api.github.com/users/anoadragon453/received_events', 'type': 'User', 'site_admin': False}]",,6,2020-05-05T09:14:12Z,2020-05-22T11:26:34Z,2020-05-07T09:22:36Z,MEMBER,,,I had to slow it down on matrix.org: https://github.com/matrix-org/synapse/commit/14bb4cff99ddd8b5eb1816c5405d52a8f13e29d6. We should probably make that permanent,
878,https://api.github.com/repos/matrix-org/synapse/issues/7410,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7410/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7410/comments,https://api.github.com/repos/matrix-org/synapse/issues/7410/events,https://github.com/matrix-org/synapse/issues/7410,612127827,MDU6SXNzdWU2MTIxMjc4Mjc=,7410,Sync returns my join event twice when I join a room,"{'login': 'babolivier', 'id': 5547783, 'node_id': 'MDQ6VXNlcjU1NDc3ODM=', 'avatar_url': 'https://avatars3.githubusercontent.com/u/5547783?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/babolivier', 'html_url': 'https://github.com/babolivier', 'followers_url': 'https://api.github.com/users/babolivier/followers', 'following_url': 'https://api.github.com/users/babolivier/following{/other_user}', 'gists_url': 'https://api.github.com/users/babolivier/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/babolivier/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/babolivier/subscriptions', 'organizations_url': 'https://api.github.com/users/babolivier/orgs', 'repos_url': 'https://api.github.com/users/babolivier/repos', 'events_url': 'https://api.github.com/users/babolivier/events{/privacy}', 'received_events_url': 'https://api.github.com/users/babolivier/received_events', 'type': 'User', 'site_admin': False}","[{'id': 121086029, 'node_id': 'MDU6TGFiZWwxMjEwODYwMjk=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/bug', 'name': 'bug', 'color': 'fc2929', 'default': True, 'description': None}, {'id': 477043173, 'node_id': 'MDU6TGFiZWw0NzcwNDMxNzM=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/p2', 'name': 'p2', 'color': 'fbca04', 'default': False, 'description': None}]",closed,False,,[],,2,2020-05-04T19:54:43Z,2020-05-04T19:57:28Z,2020-05-04T19:57:28Z,MEMBER,,,"It looks like that, upon joining a room, Synapse will send your join event to your client twice in the corresponding `/sync` response:
```json
{
[...]
""rooms"": {
""join"": {
""!nDwcyFoxOpmMvQwqit:matrix.org"": {
""timeline"": {
""events"": [
{
""type"": ""m.room.member"",
""sender"": ""@brendan:abolivier.bzh"",
""content"": {
""membership"": ""join"",
""displayname"": ""Brendan Abolivier"",
""avatar_url"": ""mxc://abolivier.bzh/cWLwioWMoPgoIFMpXWzKaTik""
},
""state_key"": ""@brendan:abolivier.bzh"",
""origin_server_ts"": 1588621547892,
""unsigned"": {
""age"": 8864
},
""event_id"": ""$fIgY5jNrKRwHKOjym6tiD39LlhYyjGindKlNaMEwxiY""
},
{
""type"": ""m.room.member"",
""sender"": ""@brendan:abolivier.bzh"",
""content"": {
""membership"": ""join"",
""displayname"": ""Brendan Abolivier"",
""avatar_url"": ""mxc://abolivier.bzh/cWLwioWMoPgoIFMpXWzKaTik""
},
""state_key"": ""@brendan:abolivier.bzh"",
""origin_server_ts"": 1588621547892,
""unsigned"": {
""age"": 8864
},
""event_id"": ""$fIgY5jNrKRwHKOjym6tiD39LlhYyjGindKlNaMEwxiY""
}
],
""prev_batch"": ""s3442614_108988523_15_7453837_195569_609_100948_1046939_20"",
""limited"": true
},
},
""account_data"": {
""events"": []
},
""ephemeral"": {
""events"": []
},
""unread_notifications"": {},
""summary"": {
""m.joined_member_count"": 2,
""m.invited_member_count"": 0
}
}
},
""invite"": {},
""leave"": {}
},
[...]
}
```
This was observed both when accepting an invite and joining a public room, and right now I can reproduce that reliably both on matrix.org and on abolivier.bzh (which runs latest develop).
It can potentially be very annoying to bots devs if their bot rely on doing something (e.g. sending a welcome message) upon joining a room, as that action is then done twice.",
879,https://api.github.com/repos/matrix-org/synapse/issues/7409,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7409/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7409/comments,https://api.github.com/repos/matrix-org/synapse/issues/7409/events,https://github.com/matrix-org/synapse/issues/7409,612018056,MDU6SXNzdWU2MTIwMTgwNTY=,7409,Stuck messages again,"{'login': 'turt2live', 'id': 1190097, 'node_id': 'MDQ6VXNlcjExOTAwOTc=', 'avatar_url': 'https://avatars2.githubusercontent.com/u/1190097?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/turt2live', 'html_url': 'https://github.com/turt2live', 'followers_url': 'https://api.github.com/users/turt2live/followers', 'following_url': 'https://api.github.com/users/turt2live/following{/other_user}', 'gists_url': 'https://api.github.com/users/turt2live/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/turt2live/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/turt2live/subscriptions', 'organizations_url': 'https://api.github.com/users/turt2live/orgs', 'repos_url': 'https://api.github.com/users/turt2live/repos', 'events_url': 'https://api.github.com/users/turt2live/events{/privacy}', 'received_events_url': 'https://api.github.com/users/turt2live/received_events', 'type': 'User', 'site_admin': False}","[{'id': 121086029, 'node_id': 'MDU6TGFiZWwxMjEwODYwMjk=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/bug', 'name': 'bug', 'color': 'fc2929', 'default': True, 'description': None}, {'id': 477045093, 'node_id': 'MDU6TGFiZWw0NzcwNDUwOTM=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/p1', 'name': 'p1', 'color': 'd93f0b', 'default': False, 'description': None}, {'id': 828666468, 'node_id': 'MDU6TGFiZWw4Mjg2NjY0Njg=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/release%20blocker', 'name': 'release blocker', 'color': '880000', 'default': False, 'description': None}]",closed,False,"{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}","[{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}]",,1,2020-05-04T16:48:29Z,2020-05-06T16:54:35Z,2020-05-06T16:54:34Z,MEMBER,,,"Parent: https://github.com/vector-im/riot-web/issues/10032
Prior history: https://github.com/matrix-org/synapse/issues/7206
Opening this on the Synapse side as it seems related to load issues on matrix.org",
880,https://api.github.com/repos/matrix-org/synapse/issues/7408,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7408/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7408/comments,https://api.github.com/repos/matrix-org/synapse/issues/7408/events,https://github.com/matrix-org/synapse/pull/7408,611930287,MDExOlB1bGxSZXF1ZXN0NDEyOTk1MTgw,7408,Add backwards compatibility codepath to LoggingContext.,"{'login': 'clokep', 'id': 517124, 'node_id': 'MDQ6VXNlcjUxNzEyNA==', 'avatar_url': 'https://avatars2.githubusercontent.com/u/517124?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/clokep', 'html_url': 'https://github.com/clokep', 'followers_url': 'https://api.github.com/users/clokep/followers', 'following_url': 'https://api.github.com/users/clokep/following{/other_user}', 'gists_url': 'https://api.github.com/users/clokep/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/clokep/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/clokep/subscriptions', 'organizations_url': 'https://api.github.com/users/clokep/orgs', 'repos_url': 'https://api.github.com/users/clokep/repos', 'events_url': 'https://api.github.com/users/clokep/events{/privacy}', 'received_events_url': 'https://api.github.com/users/clokep/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,6,2020-05-04T14:43:28Z,2020-05-05T13:21:36Z,2020-05-05T13:21:35Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7408', 'html_url': 'https://github.com/matrix-org/synapse/pull/7408', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7408.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7408.patch'}","The [synapse-s3-storage-provider](https://github.com/matrix-org/synapse-s3-storage-provider) depends on `LoggingContext.current_context` which was removed in #7120. We add this back (as a pass through to `current_context`). I'll make a separate PR for ss3sp to update the reference there too.
Note this PR is made against the release branch so it will go out with #7120.
Should we mention any changes to `LoggingContext` in the changelog?
Fixes #7400",
881,https://api.github.com/repos/matrix-org/synapse/issues/7407,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7407/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7407/comments,https://api.github.com/repos/matrix-org/synapse/issues/7407/events,https://github.com/matrix-org/synapse/issues/7407,611851091,MDU6SXNzdWU2MTE4NTEwOTE=,7407,Can't connect to room #neb:matrix.org,"{'login': 'atomtm', 'id': 6628454, 'node_id': 'MDQ6VXNlcjY2Mjg0NTQ=', 'avatar_url': 'https://avatars0.githubusercontent.com/u/6628454?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/atomtm', 'html_url': 'https://github.com/atomtm', 'followers_url': 'https://api.github.com/users/atomtm/followers', 'following_url': 'https://api.github.com/users/atomtm/following{/other_user}', 'gists_url': 'https://api.github.com/users/atomtm/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/atomtm/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/atomtm/subscriptions', 'organizations_url': 'https://api.github.com/users/atomtm/orgs', 'repos_url': 'https://api.github.com/users/atomtm/repos', 'events_url': 'https://api.github.com/users/atomtm/events{/privacy}', 'received_events_url': 'https://api.github.com/users/atomtm/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,1,2020-05-04T12:50:48Z,2020-05-04T12:57:16Z,2020-05-04T12:57:16Z,NONE,,,"### Description
Trying to connect to `#neb:matrix.org` from my homeserver and I get :
![image](https://user-images.githubusercontent.com/6628454/80966801-e24b4180-8e1d-11ea-9ed2-0d1c469d73c2.png)
From Riot developer tools I get : `Failed to load resource: the server responded with a status of 502 (Bad Gateway)`
and the address it is trying to access is:
`chat.avlikos.gr/_matrix/client/r0/join/%23neb%3Amatrix.org`
### Steps to reproduce
- on a room enter `/join #neb:matrix.org`
### Version information
This was identified on my homeserver . Same does not apply from my `matrix.org` account
- **Version**:
1.12.4
- **Install method**:
pip
- **Platform**:
NAME=""Ubuntu""
VERSION=""16.04.6 LTS (Xenial Xerus)""
ID=ubuntu
ID_LIKE=debian
PRETTY_NAME=""Ubuntu 16.04.6 LTS""
VERSION_ID=""16.04""
",
882,https://api.github.com/repos/matrix-org/synapse/issues/7406,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7406/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7406/comments,https://api.github.com/repos/matrix-org/synapse/issues/7406/events,https://github.com/matrix-org/synapse/issues/7406,611849404,MDU6SXNzdWU2MTE4NDk0MDQ=,7406,Invites are not always included in sync,"{'login': 'schmop', 'id': 1284227, 'node_id': 'MDQ6VXNlcjEyODQyMjc=', 'avatar_url': 'https://avatars2.githubusercontent.com/u/1284227?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/schmop', 'html_url': 'https://github.com/schmop', 'followers_url': 'https://api.github.com/users/schmop/followers', 'following_url': 'https://api.github.com/users/schmop/following{/other_user}', 'gists_url': 'https://api.github.com/users/schmop/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/schmop/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/schmop/subscriptions', 'organizations_url': 'https://api.github.com/users/schmop/orgs', 'repos_url': 'https://api.github.com/users/schmop/repos', 'events_url': 'https://api.github.com/users/schmop/events{/privacy}', 'received_events_url': 'https://api.github.com/users/schmop/received_events', 'type': 'User', 'site_admin': False}","[{'id': 121086029, 'node_id': 'MDU6TGFiZWwxMjEwODYwMjk=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/bug', 'name': 'bug', 'color': 'fc2929', 'default': True, 'description': None}, {'id': 477043173, 'node_id': 'MDU6TGFiZWw0NzcwNDMxNzM=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/p2', 'name': 'p2', 'color': 'fbca04', 'default': False, 'description': None}, {'id': 2038475067, 'node_id': 'MDU6TGFiZWwyMDM4NDc1MDY3', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/sync', 'name': 'sync', 'color': 'ac8bd6', 'default': False, 'description': ''}]",open,False,,[],,1,2020-05-04T12:48:05Z,2020-06-12T11:47:25Z,,NONE,,,"### Description
On fast changing membership states the sync will not reliably include rooms a user was invited to.
It might be related to issues
https://github.com/matrix-org/synapse/issues/4533 and
https://github.com/matrix-org/synapse/issues/4422
### Reproduction
This is not easily reproducable, an attempt should look as follows:
- Roomadmin a invites user b into rooms r_a and r_b
- a kicks b from r_a before he accepts the invite
- a changes room_state of r_b multiple times
- b retrieves current rooms via (initial)sync, r_b doesn't show
### Version information
We used the synapse version v1.12.0.
Installed per git clone
And is operating in a debian stretch docker container.
### Hotfix
A possibility to fix it temporarly is to restart the server or invalidate the caches.
We debugged this issue for quite some time and are using a hotfix, that stops caching from
`get_forgotten_rooms_for_user` in roommember.py by removing following line:
https://github.com/matrix-org/synapse/blob/9c1b83b0078aa9cc1bb902e14d3f7302625ba099/synapse/storage/data_stores/main/roommember.py#L797
",
883,https://api.github.com/repos/matrix-org/synapse/issues/7405,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7405/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7405/comments,https://api.github.com/repos/matrix-org/synapse/issues/7405/events,https://github.com/matrix-org/synapse/issues/7405,611802029,MDU6SXNzdWU2MTE4MDIwMjk=,7405,UIA stage m.login.password requires too many keys,"{'login': 'Sorunome', 'id': 2433620, 'node_id': 'MDQ6VXNlcjI0MzM2MjA=', 'avatar_url': 'https://avatars3.githubusercontent.com/u/2433620?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Sorunome', 'html_url': 'https://github.com/Sorunome', 'followers_url': 'https://api.github.com/users/Sorunome/followers', 'following_url': 'https://api.github.com/users/Sorunome/following{/other_user}', 'gists_url': 'https://api.github.com/users/Sorunome/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/Sorunome/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/Sorunome/subscriptions', 'organizations_url': 'https://api.github.com/users/Sorunome/orgs', 'repos_url': 'https://api.github.com/users/Sorunome/repos', 'events_url': 'https://api.github.com/users/Sorunome/events{/privacy}', 'received_events_url': 'https://api.github.com/users/Sorunome/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,1,2020-05-04T11:29:11Z,2020-05-04T11:33:53Z,2020-05-04T11:33:53Z,CONTRIBUTOR,,,"The UIA stage `m.login.password` requires too many arguments. You have to send an additional `user` key not defined in the spec (as things moved to `identifier`).
So, according to spec you have to send as auth dict:
```
{
""type"": ""m.login.password"",
""identifier"": {
""type"": ""m.id.user"",
""user"": """"
},
""password"": """",
""session"": """"
}
```
But in reality you have to send
```
{
""type"": ""m.login.password"",
""identifier"": {
""type"": ""m.id.user"",
""user"": """"
},
""user"": """",
""password"": """",
""session"": """"
}
```
Failure to do so will result in synapse just sending `{""errcode"":""M_MISSING_PARAM"",""error"":""""}` as reply (not very descriptive).
### Version information
- **Version**:
```
sorunome@sorunome-desktop ~ $ curl http://localhost:8008/_synapse/admin/v1/server_version
{
""python_version"": ""3.8.2"",
""server_version"": ""1.12.4 (b=master,204664d1a)""
}
```
- **Install method**: git
- **Platform**: archlinux
",
884,https://api.github.com/repos/matrix-org/synapse/issues/7404,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7404/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7404/comments,https://api.github.com/repos/matrix-org/synapse/issues/7404/events,https://github.com/matrix-org/synapse/pull/7404,611797631,MDExOlB1bGxSZXF1ZXN0NDEyODkwNzM5,7404,Fix MANIFEST.in,"{'login': 'babolivier', 'id': 5547783, 'node_id': 'MDQ6VXNlcjU1NDc3ODM=', 'avatar_url': 'https://avatars3.githubusercontent.com/u/5547783?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/babolivier', 'html_url': 'https://github.com/babolivier', 'followers_url': 'https://api.github.com/users/babolivier/followers', 'following_url': 'https://api.github.com/users/babolivier/following{/other_user}', 'gists_url': 'https://api.github.com/users/babolivier/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/babolivier/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/babolivier/subscriptions', 'organizations_url': 'https://api.github.com/users/babolivier/orgs', 'repos_url': 'https://api.github.com/users/babolivier/repos', 'events_url': 'https://api.github.com/users/babolivier/events{/privacy}', 'received_events_url': 'https://api.github.com/users/babolivier/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,0,2020-05-04T11:21:59Z,2020-05-04T14:24:17Z,2020-05-04T14:24:16Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7404', 'html_url': 'https://github.com/matrix-org/synapse/pull/7404', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7404.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7404.patch'}","An update of check-manifest shone some light on some issues with `MANIFEST.in`, specifically that we didn't exclude/prune the contrib directory, and that we were using `prune` instead of `exclude` for files. This fixes both issues.
Fixes #7403
---
This broke in `check-manifest` v0.42 ~anoa",
885,https://api.github.com/repos/matrix-org/synapse/issues/7403,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7403/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7403/comments,https://api.github.com/repos/matrix-org/synapse/issues/7403/events,https://github.com/matrix-org/synapse/issues/7403,611782247,MDU6SXNzdWU2MTE3ODIyNDc=,7403,check-manifest is broken,"{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}","[{'id': 828666468, 'node_id': 'MDU6TGFiZWw4Mjg2NjY0Njg=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/release%20blocker', 'name': 'release blocker', 'color': '880000', 'default': False, 'description': None}]",closed,False,"{'login': 'babolivier', 'id': 5547783, 'node_id': 'MDQ6VXNlcjU1NDc3ODM=', 'avatar_url': 'https://avatars3.githubusercontent.com/u/5547783?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/babolivier', 'html_url': 'https://github.com/babolivier', 'followers_url': 'https://api.github.com/users/babolivier/followers', 'following_url': 'https://api.github.com/users/babolivier/following{/other_user}', 'gists_url': 'https://api.github.com/users/babolivier/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/babolivier/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/babolivier/subscriptions', 'organizations_url': 'https://api.github.com/users/babolivier/orgs', 'repos_url': 'https://api.github.com/users/babolivier/repos', 'events_url': 'https://api.github.com/users/babolivier/events{/privacy}', 'received_events_url': 'https://api.github.com/users/babolivier/received_events', 'type': 'User', 'site_admin': False}","[{'login': 'babolivier', 'id': 5547783, 'node_id': 'MDQ6VXNlcjU1NDc3ODM=', 'avatar_url': 'https://avatars3.githubusercontent.com/u/5547783?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/babolivier', 'html_url': 'https://github.com/babolivier', 'followers_url': 'https://api.github.com/users/babolivier/followers', 'following_url': 'https://api.github.com/users/babolivier/following{/other_user}', 'gists_url': 'https://api.github.com/users/babolivier/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/babolivier/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/babolivier/subscriptions', 'organizations_url': 'https://api.github.com/users/babolivier/orgs', 'repos_url': 'https://api.github.com/users/babolivier/repos', 'events_url': 'https://api.github.com/users/babolivier/events{/privacy}', 'received_events_url': 'https://api.github.com/users/babolivier/received_events', 'type': 'User', 'site_admin': False}]",,2,2020-05-04T10:54:59Z,2020-05-04T14:35:04Z,2020-05-04T14:35:03Z,MEMBER,,,,
886,https://api.github.com/repos/matrix-org/synapse/issues/7402,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7402/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7402/comments,https://api.github.com/repos/matrix-org/synapse/issues/7402/events,https://github.com/matrix-org/synapse/issues/7402,611782012,MDU6SXNzdWU2MTE3ODIwMTI=,7402,write some words about redis,"{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}","[{'id': 845245048, 'node_id': 'MDU6TGFiZWw4NDUyNDUwNDg=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/docs', 'name': 'docs', 'color': '0e8a16', 'default': False, 'description': ''}, {'id': 828666468, 'node_id': 'MDU6TGFiZWw4Mjg2NjY0Njg=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/release%20blocker', 'name': 'release blocker', 'color': '880000', 'default': False, 'description': None}]",closed,False,"{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}","[{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}]",,4,2020-05-04T10:54:35Z,2020-05-11T13:46:20Z,2020-05-11T13:46:19Z,MEMBER,,,,
887,https://api.github.com/repos/matrix-org/synapse/issues/7401,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7401/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7401/comments,https://api.github.com/repos/matrix-org/synapse/issues/7401/events,https://github.com/matrix-org/synapse/pull/7401,611771644,MDExOlB1bGxSZXF1ZXN0NDEyODcwMTcw,7401,Fix redis password support.,"{'login': 'erikjohnston', 'id': 8428120, 'node_id': 'MDQ6VXNlcjg0MjgxMjA=', 'avatar_url': 'https://avatars0.githubusercontent.com/u/8428120?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/erikjohnston', 'html_url': 'https://github.com/erikjohnston', 'followers_url': 'https://api.github.com/users/erikjohnston/followers', 'following_url': 'https://api.github.com/users/erikjohnston/following{/other_user}', 'gists_url': 'https://api.github.com/users/erikjohnston/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/erikjohnston/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/erikjohnston/subscriptions', 'organizations_url': 'https://api.github.com/users/erikjohnston/orgs', 'repos_url': 'https://api.github.com/users/erikjohnston/repos', 'events_url': 'https://api.github.com/users/erikjohnston/events{/privacy}', 'received_events_url': 'https://api.github.com/users/erikjohnston/received_events', 'type': 'User', 'site_admin': False}","[{'id': 828666468, 'node_id': 'MDU6TGFiZWw4Mjg2NjY0Njg=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/release%20blocker', 'name': 'release blocker', 'color': '880000', 'default': False, 'description': None}]",closed,False,,[],,1,2020-05-04T10:36:46Z,2020-05-04T13:04:11Z,2020-05-04T13:04:10Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7401', 'html_url': 'https://github.com/matrix-org/synapse/pull/7401', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7401.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7401.patch'}","We forgot to set the password on the subscriber connection, as well as
not calling super methods for overridden connectionMade/connectionLost
functions.",
888,https://api.github.com/repos/matrix-org/synapse/issues/7400,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7400/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7400/comments,https://api.github.com/repos/matrix-org/synapse/issues/7400/events,https://github.com/matrix-org/synapse/issues/7400,611710295,MDU6SXNzdWU2MTE3MTAyOTU=,7400,StopIteration / LoggingContext has no current_context errors with some remote thumbnailing and media downloads,"{'login': 'michaelkaye', 'id': 1917473, 'node_id': 'MDQ6VXNlcjE5MTc0NzM=', 'avatar_url': 'https://avatars0.githubusercontent.com/u/1917473?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/michaelkaye', 'html_url': 'https://github.com/michaelkaye', 'followers_url': 'https://api.github.com/users/michaelkaye/followers', 'following_url': 'https://api.github.com/users/michaelkaye/following{/other_user}', 'gists_url': 'https://api.github.com/users/michaelkaye/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/michaelkaye/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/michaelkaye/subscriptions', 'organizations_url': 'https://api.github.com/users/michaelkaye/orgs', 'repos_url': 'https://api.github.com/users/michaelkaye/repos', 'events_url': 'https://api.github.com/users/michaelkaye/events{/privacy}', 'received_events_url': 'https://api.github.com/users/michaelkaye/received_events', 'type': 'User', 'site_admin': False}","[{'id': 828666468, 'node_id': 'MDU6TGFiZWw4Mjg2NjY0Njg=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/release%20blocker', 'name': 'release blocker', 'color': '880000', 'default': False, 'description': None}]",closed,False,"{'login': 'clokep', 'id': 517124, 'node_id': 'MDQ6VXNlcjUxNzEyNA==', 'avatar_url': 'https://avatars2.githubusercontent.com/u/517124?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/clokep', 'html_url': 'https://github.com/clokep', 'followers_url': 'https://api.github.com/users/clokep/followers', 'following_url': 'https://api.github.com/users/clokep/following{/other_user}', 'gists_url': 'https://api.github.com/users/clokep/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/clokep/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/clokep/subscriptions', 'organizations_url': 'https://api.github.com/users/clokep/orgs', 'repos_url': 'https://api.github.com/users/clokep/repos', 'events_url': 'https://api.github.com/users/clokep/events{/privacy}', 'received_events_url': 'https://api.github.com/users/clokep/received_events', 'type': 'User', 'site_admin': False}","[{'login': 'clokep', 'id': 517124, 'node_id': 'MDQ6VXNlcjUxNzEyNA==', 'avatar_url': 'https://avatars2.githubusercontent.com/u/517124?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/clokep', 'html_url': 'https://github.com/clokep', 'followers_url': 'https://api.github.com/users/clokep/followers', 'following_url': 'https://api.github.com/users/clokep/following{/other_user}', 'gists_url': 'https://api.github.com/users/clokep/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/clokep/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/clokep/subscriptions', 'organizations_url': 'https://api.github.com/users/clokep/orgs', 'repos_url': 'https://api.github.com/users/clokep/repos', 'events_url': 'https://api.github.com/users/clokep/events{/privacy}', 'received_events_url': 'https://api.github.com/users/clokep/received_events', 'type': 'User', 'site_admin': False}]",,6,2020-05-04T08:55:49Z,2020-05-05T13:23:04Z,2020-05-05T13:23:04Z,CONTRIBUTOR,,,"We get an exception when trying to handle both thumbnail requests and media downloads for some images. It reliably happens for a given URL, but not all downloads / thumbnails for a remote host fail.
```
2020-05-04 08:50:22,981 - synapse.http.server - 110 - ERROR - GET-5511628 - Failed handle request via 'DownloadResource':
Capture point (most recent call last):
File ""/usr/local/lib/python3.7/runpy.py"", line 193, in _run_module_as_main
""__main__"", mod_spec)
File ""/usr/local/lib/python3.7/runpy.py"", line 85, in _run_code
exec(code, run_globals)
File ""/home/synapse/src/synapse/app/media_repository.py"", line 24, in
start(sys.argv[1:])
File ""/home/synapse/src/synapse/app/generic_worker.py"", line 983, in start
_base.start_worker_reactor(""synapse-generic-worker"", config)
File ""/home/synapse/src/synapse/app/_base.py"", line 77, in start_worker_reactor
run_command=run_command,
File ""/home/synapse/src/synapse/app/_base.py"", line 137, in start_reactor
daemon.start()
File ""/home/synapse/env-py37/lib/python3.7/site-packages/daemonize.py"", line 248, in start
self.action(*privileged_action_result)
File ""/home/synapse/src/synapse/app/_base.py"", line 114, in run
run_command()
File ""/home/synapse/env-py37/lib/python3.7/site-packages/twisted/internet/base.py"", line 1283, in run
self.mainLoop()
File ""/home/synapse/env-py37/lib/python3.7/site-packages/twisted/internet/base.py"", line 1292, in mainLoop
self.runUntilCurrent()
File ""/home/synapse/src/synapse/metrics/__init__.py"", line 436, in f
ret = func(*args, **kwargs)
File ""/home/synapse/env-py37/lib/python3.7/site-packages/twisted/internet/base.py"", line 886, in runUntilCurrent
f(*a, **kw)
File ""/home/synapse/env-py37/lib/python3.7/site-packages/twisted/internet/base.py"", line 886, in runUntilCurrent
f(*a, **kw)
File ""/home/synapse/env-py37/lib/python3.7/site-packages/twisted/internet/defer.py"", line 460, in callback
self._startRunCallbacks(result)
File ""/home/synapse/env-py37/lib/python3.7/site-packages/twisted/internet/defer.py"", line 568, in _startRunCallbacks
self._runCallbacks()
File ""/home/synapse/env-py37/lib/python3.7/site-packages/twisted/internet/defer.py"", line 654, in _runCallbacks
current.result = callback(current.result, *args, **kw)
File ""/home/synapse/env-py37/lib/python3.7/site-packages/twisted/internet/defer.py"", line 1475, in gotResult
_inlineCallbacks(r, g, status)
File ""/home/synapse/env-py37/lib/python3.7/site-packages/twisted/internet/defer.py"", line 1421, in _inlineCallbacks
status.deferred.callback(getattr(e, ""value"", None))
File ""/home/synapse/env-py37/lib/python3.7/site-packages/twisted/internet/defer.py"", line 460, in callback
self._startRunCallbacks(result)
File ""/home/synapse/env-py37/lib/python3.7/site-packages/twisted/internet/defer.py"", line 568, in _startRunCallbacks
self._runCallbacks()
File ""/home/synapse/env-py37/lib/python3.7/site-packages/twisted/internet/defer.py"", line 654, in _runCallbacks
current.result = callback(current.result, *args, **kw)
File ""/home/synapse/env-py37/lib/python3.7/site-packages/twisted/internet/defer.py"", line 1475, in gotResult
_inlineCallbacks(r, g, status)
File ""/home/synapse/env-py37/lib/python3.7/site-packages/twisted/internet/defer.py"", line 1421, in _inlineCallbacks
status.deferred.callback(getattr(e, ""value"", None))
File ""/home/synapse/env-py37/lib/python3.7/site-packages/twisted/internet/defer.py"", line 460, in callback
self._startRunCallbacks(result)
File ""/home/synapse/env-py37/lib/python3.7/site-packages/twisted/internet/defer.py"", line 568, in _startRunCallbacks
self._runCallbacks()
File ""/home/synapse/env-py37/lib/python3.7/site-packages/twisted/internet/defer.py"", line 654, in _runCallbacks
current.result = callback(current.result, *args, **kw)
File ""/home/synapse/env-py37/lib/python3.7/site-packages/twisted/internet/defer.py"", line 1475, in gotResult
_inlineCallbacks(r, g, status)
File ""/home/synapse/env-py37/lib/python3.7/site-packages/twisted/internet/defer.py"", line 1418, in _inlineCallbacks
result = g.send(result)
File ""/home/synapse/src/synapse/http/server.py"", line 209, in wrapped_async_request_handler
await h(self, request)
File ""/home/synapse/src/synapse/http/server.py"", line 78, in wrapped_request_handler
await h(self, request)
File ""/home/synapse/src/synapse/rest/media/v1/download_resource.py"", line 72, in _async_render_GET
await self.media_repo.get_remote_media(request, server_name, media_id, name)
File ""/home/synapse/src/synapse/rest/media/v1/media_repository.py"", line 236, in get_remote_media
server_name, media_id
File ""/home/synapse/src/synapse/rest/media/v1/media_repository.py"", line 313, in _get_remote_media_impl
responder = await self.media_storage.fetch_media(file_info)
File ""/home/synapse/env-py37/lib/python3.7/site-packages/twisted/internet/defer.py"", line 1613, in unwindGenerator
return _cancellableInlineCallbacks(gen)
File ""/home/synapse/env-py37/lib/python3.7/site-packages/twisted/internet/defer.py"", line 1529, in _cancellableInlineCallbacks
_inlineCallbacks(None, g, status)
Traceback (most recent call last):
File ""/home/synapse/env-py37/lib/python3.7/site-packages/twisted/internet/defer.py"", line 1418, in _inlineCallbacks
result = g.send(result)
StopIteration: {'media_type': 'image/png', 'media_length': 500000, 'upload_name': 'name.png', 'created_ts': 1554744000000, 'filesystem_id': 'YYYY', 'quarantined_by': None}
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File ""/home/synapse/env-py37/lib/python3.7/site-packages/twisted/internet/defer.py"", line 1418, in _inlineCallbacks
result = g.send(result)
StopIteration: {'media_type': 'image/png', 'media_length': 50000, 'upload_name': 'name.png', 'created_ts': 1554744000000, 'filesystem_id': 'YYYY', 'quarantined_by': None}
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File ""/home/synapse/src/synapse/http/server.py"", line 78, in wrapped_request_handler
await h(self, request)
File ""/home/synapse/src/synapse/rest/media/v1/download_resource.py"", line 72, in _async_render_GET
await self.media_repo.get_remote_media(request, server_name, media_id, name)
File ""/home/synapse/src/synapse/rest/media/v1/media_repository.py"", line 236, in get_remote_media
server_name, media_id
File ""/home/synapse/src/synapse/rest/media/v1/media_repository.py"", line 313, in _get_remote_media_impl
responder = await self.media_storage.fetch_media(file_info)
File ""/home/synapse/env-py37/lib/python3.7/site-packages/twisted/internet/defer.py"", line 1418, in _inlineCallbacks
result = g.send(result)
File ""/home/synapse/src/synapse/rest/media/v1/media_storage.py"", line 149, in fetch_media
res = yield provider.fetch(path, file_info)
File ""/home/synapse/src/synapse/rest/media/v1/storage_provider.py"", line 104, in fetch
return self.backend.fetch(path, file_info)
File ""/home/synapse/synapse-s3-storage-provider/s3_storage_provider.py"", line 74, in fetch
logcontext = LoggingContext.current_context()
AttributeError: type object 'LoggingContext' has no attribute 'current_context'
```",
889,https://api.github.com/repos/matrix-org/synapse/issues/7399,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7399/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7399/comments,https://api.github.com/repos/matrix-org/synapse/issues/7399/events,https://github.com/matrix-org/synapse/issues/7399,611594983,MDU6SXNzdWU2MTE1OTQ5ODM=,7399,Integrations do not work - Failed handle request via 'AccountDataServlet',"{'login': 'danry25', 'id': 1683673, 'node_id': 'MDQ6VXNlcjE2ODM2NzM=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1683673?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/danry25', 'html_url': 'https://github.com/danry25', 'followers_url': 'https://api.github.com/users/danry25/followers', 'following_url': 'https://api.github.com/users/danry25/following{/other_user}', 'gists_url': 'https://api.github.com/users/danry25/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/danry25/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/danry25/subscriptions', 'organizations_url': 'https://api.github.com/users/danry25/orgs', 'repos_url': 'https://api.github.com/users/danry25/repos', 'events_url': 'https://api.github.com/users/danry25/events{/privacy}', 'received_events_url': 'https://api.github.com/users/danry25/received_events', 'type': 'User', 'site_admin': False}","[{'id': 121086029, 'node_id': 'MDU6TGFiZWwxMjEwODYwMjk=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/bug', 'name': 'bug', 'color': 'fc2929', 'default': True, 'description': None}, {'id': 1311133228, 'node_id': 'MDU6TGFiZWwxMzExMTMzMjI4', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/info-needed', 'name': 'info-needed', 'color': 'a1e8ea', 'default': False, 'description': ''}]",closed,False,,[],,4,2020-05-04T04:25:17Z,2020-05-05T10:02:11Z,2020-05-05T05:33:18Z,NONE,,,"### Description
When trying to use Integrations (whether provided dimension.t2bot.io or scalar.vector.im) ""Cannot connect to integration manager"" is shown to the user. This affects existing users as well as newly registered users on whomst.online.
The [integration troubleshooter](https://github.com/turt2live/matrix-dimension#could-not-contact-integrations-server-error) provided by matrix-dimension passes, as does the [federation tester](https://federationtester.matrix.org/).
### Steps to reproduce
- Open Riot-web
- Press the four squares in the upper right corner
- Check the Accept button for the Terms of Service and click Next
- User is presented with ""Cannot connect to integration manager"" and the error below is generated on the matrix-synapse server.
```
May 03 17:40:50 matrix authbind[24029]: 2020-05-03 17:40:50,204 - synapse.http.server - 110 - ERROR - PUT-2380028 - Failed handle request via 'AccountDataServlet':
May 03 17:40:50 matrix authbind[24029]: Traceback (most recent call last):
May 03 17:40:50 matrix authbind[24029]: File ""/usr/local/lib/python3.7/dist-packages/synapse/http/server.py"", line 78, in wrapped_request_handler
May 03 17:40:50 matrix authbind[24029]: await h(self, request)
May 03 17:40:50 matrix authbind[24029]: File ""/usr/local/lib/python3.7/dist-packages/synapse/http/server.py"", line 331, in _async_render
May 03 17:40:50 matrix authbind[24029]: callback_return = await callback_return
May 03 17:40:50 matrix authbind[24029]: File ""/usr/local/lib/python3.7/dist-packages/synapse/rest/client/v2_alpha/account_data.py"", line 50, in on_PUT
May 03 17:40:50 matrix authbind[24029]: user_id, account_data_type, body
May 03 17:40:50 matrix authbind[24029]: File ""/usr/lib/python3/dist-packages/twisted/internet/defer.py"", line 1416, in _inlineCallbacks
May 03 17:40:50 matrix authbind[24029]: result = result.throwExceptionIntoGenerator(g)
May 03 17:40:50 matrix authbind[24029]: File ""/usr/lib/python3/dist-packages/twisted/python/failure.py"", line 491, in throwExceptionIntoGenerator
May 03 17:40:50 matrix authbind[24029]: return g.throw(self.type, self.value, self.tb)
May 03 17:40:50 matrix authbind[24029]: File ""/usr/local/lib/python3.7/dist-packages/synapse/storage/data_stores/main/account_data.py"", line 357, in add_account_data_for_user
May 03 17:40:50 matrix authbind[24029]: lock=False,
May 03 17:40:50 matrix authbind[24029]: File ""/usr/lib/python3/dist-packages/twisted/internet/defer.py"", line 1416, in _inlineCallbacks
May 03 17:40:50 matrix authbind[24029]: result = result.throwExceptionIntoGenerator(g)
May 03 17:40:50 matrix authbind[24029]: File ""/usr/lib/python3/dist-packages/twisted/python/failure.py"", line 491, in throwExceptionIntoGenerator
May 03 17:40:50 matrix authbind[24029]: return g.throw(self.type, self.value, self.tb)
May 03 17:40:50 matrix authbind[24029]: File ""/usr/local/lib/python3.7/dist-packages/synapse/storage/database.py"", line 730, in simple_upsert
May 03 17:40:50 matrix authbind[24029]: lock=lock,
May 03 17:40:50 matrix authbind[24029]: File ""/usr/lib/python3/dist-packages/twisted/internet/defer.py"", line 1416, in _inlineCallbacks
May 03 17:40:50 matrix authbind[24029]: result = result.throwExceptionIntoGenerator(g)
May 03 17:40:50 matrix authbind[24029]: File ""/usr/lib/python3/dist-packages/twisted/python/failure.py"", line 491, in throwExceptionIntoGenerator
May 03 17:40:50 matrix authbind[24029]: return g.throw(self.type, self.value, self.tb)
May 03 17:40:50 matrix authbind[24029]: File ""/usr/local/lib/python3.7/dist-packages/synapse/storage/database.py"", line 524, in runInteraction
May 03 17:40:50 matrix authbind[24029]: **kwargs
May 03 17:40:50 matrix authbind[24029]: File ""/usr/lib/python3/dist-packages/twisted/internet/defer.py"", line 1416, in _inlineCallbacks
May 03 17:40:50 matrix authbind[24029]: result = result.throwExceptionIntoGenerator(g)
May 03 17:40:50 matrix authbind[24029]: File ""/usr/lib/python3/dist-packages/twisted/python/failure.py"", line 491, in throwExceptionIntoGenerator
May 03 17:40:50 matrix authbind[24029]: return g.throw(self.type, self.value, self.tb)
May 03 17:40:50 matrix authbind[24029]: File ""/usr/local/lib/python3.7/dist-packages/synapse/storage/database.py"", line 574, in runWithConnection
May 03 17:40:50 matrix authbind[24029]: self._db_pool.runWithConnection(inner_func, *args, **kwargs)
May 03 17:40:50 matrix authbind[24029]: File ""/usr/lib/python3/dist-packages/twisted/python/threadpool.py"", line 250, in inContext
May 03 17:40:50 matrix authbind[24029]: result = inContext.theWork()
May 03 17:40:50 matrix authbind[24029]: File ""/usr/lib/python3/dist-packages/twisted/python/threadpool.py"", line 266, in
May 03 17:40:50 matrix authbind[24029]: inContext.theWork = lambda: context.call(ctx, func, *args, **kw)
May 03 17:40:50 matrix authbind[24029]: File ""/usr/lib/python3/dist-packages/twisted/python/context.py"", line 122, in callWithContext
May 03 17:40:50 matrix authbind[24029]: return self.currentContext().callWithContext(ctx, func, *args, **kw)
May 03 17:40:50 matrix authbind[24029]: File ""/usr/lib/python3/dist-packages/twisted/python/context.py"", line 85, in callWithContext
May 03 17:40:50 matrix authbind[24029]: return func(*args,**kw)
May 03 17:40:50 matrix authbind[24029]: File ""/usr/lib/python3/dist-packages/twisted/enterprise/adbapi.py"", line 306, in _runWithConnection
May 03 17:40:50 matrix authbind[24029]: compat.reraise(excValue, excTraceback)
May 03 17:40:50 matrix authbind[24029]: File ""/usr/lib/python3/dist-packages/twisted/python/compat.py"", line 464, in reraise
May 03 17:40:50 matrix authbind[24029]: raise exception.with_traceback(traceback)
May 03 17:40:50 matrix authbind[24029]: File ""/usr/lib/python3/dist-packages/twisted/enterprise/adbapi.py"", line 297, in _runWithConnection
May 03 17:40:50 matrix authbind[24029]: result = func(conn, *args, **kw)
May 03 17:40:50 matrix authbind[24029]: File ""/usr/local/lib/python3.7/dist-packages/synapse/storage/database.py"", line 571, in inner_func
May 03 17:40:50 matrix authbind[24029]: return func(conn, *args, **kwargs)
May 03 17:40:50 matrix authbind[24029]: File ""/usr/local/lib/python3.7/dist-packages/synapse/storage/database.py"", line 407, in new_transaction
May 03 17:40:50 matrix authbind[24029]: r = func(cursor, *args, **kwargs)
May 03 17:40:50 matrix authbind[24029]: File ""/usr/local/lib/python3.7/dist-packages/synapse/storage/database.py"", line 767, in simple_upsert_txn
May 03 17:40:50 matrix authbind[24029]: txn, table, keyvalues, values, insertion_values=insertion_values
May 03 17:40:50 matrix authbind[24029]: File ""/usr/local/lib/python3.7/dist-packages/synapse/storage/database.py"", line 880, in simple_upsert_txn_native_upsert
May 03 17:40:50 matrix authbind[24029]: txn.execute(sql, list(allvalues.values()))
May 03 17:40:50 matrix authbind[24029]: File ""/usr/local/lib/python3.7/dist-packages/synapse/storage/database.py"", line 199, in execute
May 03 17:40:50 matrix authbind[24029]: self._do_execute(self.txn.execute, sql, *args)
May 03 17:40:50 matrix authbind[24029]: File ""/usr/local/lib/python3.7/dist-packages/synapse/storage/database.py"", line 225, in _do_execute
May 03 17:40:50 matrix authbind[24029]: return func(sql, *args)
May 03 17:40:50 matrix authbind[24029]: psycopg2.ProgrammingError: there is no unique or exclusion constraint matching the ON CONFLICT specification
May 03 17:40:50 matrix authbind[24029]: 2020-05-03 17:40:50,206 - synapse.access.https.443 - 302 - INFO - PUT-2380028 - ::ffff:10.100.1.226 - 443 - {@dan:whomst.online} Processed request: 0.003sec/0.000sec (0.001sec, 0.000sec) (0.000sec/0.001sec/1) 67B 500 ""PUT /_matrix/client/r0/user/%40dan%3Awhomst.online/account_data/m.accepted_terms HTTP/1.1"" ""Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Riot/1.5.15 Chrome/78.0.3904.130 Electron/7.1.14 Safari/537.36"" [0 dbevts]
May 03 17:40:50 matrix authbind[24029]: 2020-05-03 17:40:50,221 - twisted - 192 - INFO - - Timing out client: IPv6Address(type='TCP', host='::ffff:10.100.1.226', port=44732, flowInfo=0, scopeID=0)
```
### Version information
- **Homeserver**: whomst.online
- **Version**: 1.12.3
- **Install method**: pip3
- **Platform**: Debian 10 Buster (inside KVM, atop a Ryzen CPU), matrix-synapse is directly exposed to the web using authbind, and Postgres is the backend database.",
890,https://api.github.com/repos/matrix-org/synapse/issues/7398,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7398/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7398/comments,https://api.github.com/repos/matrix-org/synapse/issues/7398/events,https://github.com/matrix-org/synapse/pull/7398,611421811,MDExOlB1bGxSZXF1ZXN0NDEyNjA3ODY0,7398,Update docker runtime image to Alpine v3.11,"{'login': 'Starbix', 'id': 12443257, 'node_id': 'MDQ6VXNlcjEyNDQzMjU3', 'avatar_url': 'https://avatars1.githubusercontent.com/u/12443257?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Starbix', 'html_url': 'https://github.com/Starbix', 'followers_url': 'https://api.github.com/users/Starbix/followers', 'following_url': 'https://api.github.com/users/Starbix/following{/other_user}', 'gists_url': 'https://api.github.com/users/Starbix/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/Starbix/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/Starbix/subscriptions', 'organizations_url': 'https://api.github.com/users/Starbix/orgs', 'repos_url': 'https://api.github.com/users/Starbix/repos', 'events_url': 'https://api.github.com/users/Starbix/events{/privacy}', 'received_events_url': 'https://api.github.com/users/Starbix/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,0,2020-05-03T14:06:35Z,2020-05-07T09:56:58Z,2020-05-07T09:56:57Z,CONTRIBUTOR,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7398', 'html_url': 'https://github.com/matrix-org/synapse/pull/7398', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7398.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7398.patch'}","### Pull Request Checklist
* [x] Pull request is based on the develop branch
* [x] Pull request includes a [changelog file](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#changelog). The entry should:
- Be a short description of your change which makes sense to users. ""Fixed a bug that prevented receiving messages from other servers."" instead of ""Moved X method from `EventStore` to `EventWorkerStore`."".
- Use markdown where necessary, mostly for `code blocks`.
- End with either a period (.) or an exclamation mark (!).
- Start with a capital letter.
* [x] Pull request includes a [sign off](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#sign-off)
* [x] Code style is correct (run the [linters](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#code-style))
Signed-off-by: Cédric Laubacher ",
891,https://api.github.com/repos/matrix-org/synapse/issues/7397,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7397/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7397/comments,https://api.github.com/repos/matrix-org/synapse/issues/7397/events,https://github.com/matrix-org/synapse/pull/7397,611418727,MDExOlB1bGxSZXF1ZXN0NDEyNjA1Njk0,7397,Docker image: Multi arch support,"{'login': 'Starbix', 'id': 12443257, 'node_id': 'MDQ6VXNlcjEyNDQzMjU3', 'avatar_url': 'https://avatars1.githubusercontent.com/u/12443257?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Starbix', 'html_url': 'https://github.com/Starbix', 'followers_url': 'https://api.github.com/users/Starbix/followers', 'following_url': 'https://api.github.com/users/Starbix/following{/other_user}', 'gists_url': 'https://api.github.com/users/Starbix/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/Starbix/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/Starbix/subscriptions', 'organizations_url': 'https://api.github.com/users/Starbix/orgs', 'repos_url': 'https://api.github.com/users/Starbix/repos', 'events_url': 'https://api.github.com/users/Starbix/events{/privacy}', 'received_events_url': 'https://api.github.com/users/Starbix/received_events', 'type': 'User', 'site_admin': False}","[{'id': 955488836, 'node_id': 'MDU6TGFiZWw5NTU0ODg4MzY=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/awaiting%20changes', 'name': 'awaiting changes', 'color': 'cfe886', 'default': False, 'description': ''}]",closed,False,,[],,13,2020-05-03T13:51:00Z,2020-08-06T17:33:19Z,2020-08-06T17:33:19Z,CONTRIBUTOR,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7397', 'html_url': 'https://github.com/matrix-org/synapse/pull/7397', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7397.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7397.patch'}","### Pull Request Checklist
* [x] Pull request is based on the develop branch
* [x] Pull request includes a [changelog file](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#changelog). The entry should:
- Be a short description of your change which makes sense to users. ""Fixed a bug that prevented receiving messages from other servers."" instead of ""Moved X method from `EventStore` to `EventWorkerStore`."".
- Use markdown where necessary, mostly for `code blocks`.
- End with either a period (.) or an exclamation mark (!).
- Start with a capital letter.
* [x] Pull request includes a [sign off](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#sign-off)
* [x] Code style is correct (run the [linters](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#code-style))
This PR updates the CircleCI configuration to use `docker buildx` to build the docker image. This way multi-arch images can be built on amd64. Currently only amd64 and arm64v8 are enabled. But other architectures such as arm/v7 or even s390x can be easily added.
Building for amd64 and arm64v8 took around 1h 30m on a Docker Medium instance on CircleCI.
Closes #4599
In case you want to test it, the multiarch image created by CircleCI is available under `starbix/synapse:latest` (master branch).
Signed-off-by: Cédric Laubacher ",
892,https://api.github.com/repos/matrix-org/synapse/issues/7396,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7396/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7396/comments,https://api.github.com/repos/matrix-org/synapse/issues/7396/events,https://github.com/matrix-org/synapse/pull/7396,610906872,MDExOlB1bGxSZXF1ZXN0NDEyMjUxODgw,7396,Convert the room handler to async/await.,"{'login': 'clokep', 'id': 517124, 'node_id': 'MDQ6VXNlcjUxNzEyNA==', 'avatar_url': 'https://avatars2.githubusercontent.com/u/517124?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/clokep', 'html_url': 'https://github.com/clokep', 'followers_url': 'https://api.github.com/users/clokep/followers', 'following_url': 'https://api.github.com/users/clokep/following{/other_user}', 'gists_url': 'https://api.github.com/users/clokep/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/clokep/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/clokep/subscriptions', 'organizations_url': 'https://api.github.com/users/clokep/orgs', 'repos_url': 'https://api.github.com/users/clokep/repos', 'events_url': 'https://api.github.com/users/clokep/events{/privacy}', 'received_events_url': 'https://api.github.com/users/clokep/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,0,2020-05-01T18:47:48Z,2020-05-04T11:43:54Z,2020-05-04T11:43:53Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7396', 'html_url': 'https://github.com/matrix-org/synapse/pull/7396', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7396.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7396.patch'}",I noticed in #7363 that the room handler was almost fully converted to async/await. Figured we should finish the job.,
893,https://api.github.com/repos/matrix-org/synapse/issues/7395,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7395/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7395/comments,https://api.github.com/repos/matrix-org/synapse/issues/7395/events,https://github.com/matrix-org/synapse/pull/7395,610898077,MDExOlB1bGxSZXF1ZXN0NDEyMjQ0ODU2,7395,Convert the synapse.notifier module to async/await.,"{'login': 'clokep', 'id': 517124, 'node_id': 'MDQ6VXNlcjUxNzEyNA==', 'avatar_url': 'https://avatars2.githubusercontent.com/u/517124?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/clokep', 'html_url': 'https://github.com/clokep', 'followers_url': 'https://api.github.com/users/clokep/followers', 'following_url': 'https://api.github.com/users/clokep/following{/other_user}', 'gists_url': 'https://api.github.com/users/clokep/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/clokep/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/clokep/subscriptions', 'organizations_url': 'https://api.github.com/users/clokep/orgs', 'repos_url': 'https://api.github.com/users/clokep/repos', 'events_url': 'https://api.github.com/users/clokep/events{/privacy}', 'received_events_url': 'https://api.github.com/users/clokep/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,0,2020-05-01T18:29:28Z,2020-05-01T19:14:51Z,2020-05-01T19:14:50Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7395', 'html_url': 'https://github.com/matrix-org/synapse/pull/7395', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7395.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7395.patch'}",This seemed like an easy win to convert.,
894,https://api.github.com/repos/matrix-org/synapse/issues/7394,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7394/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7394/comments,https://api.github.com/repos/matrix-org/synapse/issues/7394/events,https://github.com/matrix-org/synapse/pull/7394,610892635,MDExOlB1bGxSZXF1ZXN0NDEyMjQwNDcy,7394,Convert synapse.server_notices to async/await.,"{'login': 'clokep', 'id': 517124, 'node_id': 'MDQ6VXNlcjUxNzEyNA==', 'avatar_url': 'https://avatars2.githubusercontent.com/u/517124?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/clokep', 'html_url': 'https://github.com/clokep', 'followers_url': 'https://api.github.com/users/clokep/followers', 'following_url': 'https://api.github.com/users/clokep/following{/other_user}', 'gists_url': 'https://api.github.com/users/clokep/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/clokep/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/clokep/subscriptions', 'organizations_url': 'https://api.github.com/users/clokep/orgs', 'repos_url': 'https://api.github.com/users/clokep/repos', 'events_url': 'https://api.github.com/users/clokep/events{/privacy}', 'received_events_url': 'https://api.github.com/users/clokep/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,0,2020-05-01T18:18:11Z,2020-05-01T19:29:01Z,2020-05-01T19:29:00Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7394', 'html_url': 'https://github.com/matrix-org/synapse/pull/7394', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7394.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7394.patch'}",I noticed while reviewing #7363 that there was only a couple more usages of `inlineCallbacks` in `synapse.server_notices`. I figured it made sense to just finish it up while being somewhat familar with the code.,
895,https://api.github.com/repos/matrix-org/synapse/issues/7393,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7393/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7393/comments,https://api.github.com/repos/matrix-org/synapse/issues/7393/events,https://github.com/matrix-org/synapse/pull/7393,610824323,MDExOlB1bGxSZXF1ZXN0NDEyMTg3MDcx,7393,Fix bug in EventContext.deserialize.,"{'login': 'erikjohnston', 'id': 8428120, 'node_id': 'MDQ6VXNlcjg0MjgxMjA=', 'avatar_url': 'https://avatars0.githubusercontent.com/u/8428120?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/erikjohnston', 'html_url': 'https://github.com/erikjohnston', 'followers_url': 'https://api.github.com/users/erikjohnston/followers', 'following_url': 'https://api.github.com/users/erikjohnston/following{/other_user}', 'gists_url': 'https://api.github.com/users/erikjohnston/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/erikjohnston/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/erikjohnston/subscriptions', 'organizations_url': 'https://api.github.com/users/erikjohnston/orgs', 'repos_url': 'https://api.github.com/users/erikjohnston/repos', 'events_url': 'https://api.github.com/users/erikjohnston/events{/privacy}', 'received_events_url': 'https://api.github.com/users/erikjohnston/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,0,2020-05-01T15:56:58Z,2020-05-05T13:17:29Z,2020-05-05T13:17:28Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7393', 'html_url': 'https://github.com/matrix-org/synapse/pull/7393', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7393.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7393.patch'}","This caused `prev_state_ids` to be incorrect if the state event was not
replacing an existing state entry.",
896,https://api.github.com/repos/matrix-org/synapse/issues/7392,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7392/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7392/comments,https://api.github.com/repos/matrix-org/synapse/issues/7392/events,https://github.com/matrix-org/synapse/pull/7392,610770131,MDExOlB1bGxSZXF1ZXN0NDEyMTQ1MzUy,7392,Add a section about support to the top of the README,"{'login': 'babolivier', 'id': 5547783, 'node_id': 'MDQ6VXNlcjU1NDc3ODM=', 'avatar_url': 'https://avatars3.githubusercontent.com/u/5547783?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/babolivier', 'html_url': 'https://github.com/babolivier', 'followers_url': 'https://api.github.com/users/babolivier/followers', 'following_url': 'https://api.github.com/users/babolivier/following{/other_user}', 'gists_url': 'https://api.github.com/users/babolivier/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/babolivier/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/babolivier/subscriptions', 'organizations_url': 'https://api.github.com/users/babolivier/orgs', 'repos_url': 'https://api.github.com/users/babolivier/repos', 'events_url': 'https://api.github.com/users/babolivier/events{/privacy}', 'received_events_url': 'https://api.github.com/users/babolivier/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,0,2020-05-01T14:11:12Z,2020-05-01T15:27:24Z,2020-05-01T15:27:23Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7392', 'html_url': 'https://github.com/matrix-org/synapse/pull/7392', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7392.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7392.patch'}","Continuation of https://github.com/matrix-org/synapse/pull/7379
Adds a section in the README telling people to go to #synapse:matrix.org instead of using github issues. I'm not entirely sure about placing it above the install section but then people are likely to first seek support when installing (if something goes boom), and it's probably better to have it as high as possible anyway so people actually see it.",
897,https://api.github.com/repos/matrix-org/synapse/issues/7391,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7391/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7391/comments,https://api.github.com/repos/matrix-org/synapse/issues/7391/events,https://github.com/matrix-org/synapse/issues/7391,610720827,MDU6SXNzdWU2MTA3MjA4Mjc=,7391,Ability to set default power levels via Config,"{'login': 'cnvandijk', 'id': 10700411, 'node_id': 'MDQ6VXNlcjEwNzAwNDEx', 'avatar_url': 'https://avatars0.githubusercontent.com/u/10700411?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/cnvandijk', 'html_url': 'https://github.com/cnvandijk', 'followers_url': 'https://api.github.com/users/cnvandijk/followers', 'following_url': 'https://api.github.com/users/cnvandijk/following{/other_user}', 'gists_url': 'https://api.github.com/users/cnvandijk/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/cnvandijk/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/cnvandijk/subscriptions', 'organizations_url': 'https://api.github.com/users/cnvandijk/orgs', 'repos_url': 'https://api.github.com/users/cnvandijk/repos', 'events_url': 'https://api.github.com/users/cnvandijk/events{/privacy}', 'received_events_url': 'https://api.github.com/users/cnvandijk/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,1,2020-05-01T12:10:35Z,2020-05-01T16:18:22Z,2020-05-01T16:18:21Z,NONE,,,"**Description:**
This is essentially #4401 with a broader scope.
On an unfederated private homeserver, it can be useful to be able to tweak the permission model to e.g. allow all users to change the room name, add widgets etc. It is also often a requirement to disable e2e encryption. By exposing the default power levels via config, private homeservers would not need to resort to patching, such as in https://github.com/matrix-org/synapse/issues/4367#issuecomment-452772632.",
898,https://api.github.com/repos/matrix-org/synapse/issues/7390,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7390/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7390/comments,https://api.github.com/repos/matrix-org/synapse/issues/7390/events,https://github.com/matrix-org/synapse/issues/7390,610717095,MDU6SXNzdWU2MTA3MTcwOTU=,7390,create_group called on TransportLayerClient,"{'login': 'anoadragon453', 'id': 1342360, 'node_id': 'MDQ6VXNlcjEzNDIzNjA=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1342360?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/anoadragon453', 'html_url': 'https://github.com/anoadragon453', 'followers_url': 'https://api.github.com/users/anoadragon453/followers', 'following_url': 'https://api.github.com/users/anoadragon453/following{/other_user}', 'gists_url': 'https://api.github.com/users/anoadragon453/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/anoadragon453/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/anoadragon453/subscriptions', 'organizations_url': 'https://api.github.com/users/anoadragon453/orgs', 'repos_url': 'https://api.github.com/users/anoadragon453/repos', 'events_url': 'https://api.github.com/users/anoadragon453/events{/privacy}', 'received_events_url': 'https://api.github.com/users/anoadragon453/received_events', 'type': 'User', 'site_admin': False}","[{'id': 121086029, 'node_id': 'MDU6TGFiZWwxMjEwODYwMjk=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/bug', 'name': 'bug', 'color': 'fc2929', 'default': True, 'description': None}, {'id': 477043173, 'node_id': 'MDU6TGFiZWw0NzcwNDMxNzM=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/p2', 'name': 'p2', 'color': 'fbca04', 'default': False, 'description': None}]",open,False,,[],,1,2020-05-01T11:59:41Z,2020-05-01T12:10:26Z,,MEMBER,,,"https://github.com/matrix-org/synapse/blob/de2d267375069c2d22bceb0d6ef9c6f5a77380e3/synapse/handlers/groups_local.py#L307-L309
`TransportLayerClient` nor any parent class has a `create_group` method. It looks like this might be a typo for `self.groups_server_handler.create_group`, however the arguments do not match the function signature.",
899,https://api.github.com/repos/matrix-org/synapse/issues/7389,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7389/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7389/comments,https://api.github.com/repos/matrix-org/synapse/issues/7389/events,https://github.com/matrix-org/synapse/issues/7389,610685010,MDU6SXNzdWU2MTA2ODUwMTA=,7389,A configuration file is required for --help,"{'login': 'babolivier', 'id': 5547783, 'node_id': 'MDQ6VXNlcjU1NDc3ODM=', 'avatar_url': 'https://avatars3.githubusercontent.com/u/5547783?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/babolivier', 'html_url': 'https://github.com/babolivier', 'followers_url': 'https://api.github.com/users/babolivier/followers', 'following_url': 'https://api.github.com/users/babolivier/following{/other_user}', 'gists_url': 'https://api.github.com/users/babolivier/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/babolivier/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/babolivier/subscriptions', 'organizations_url': 'https://api.github.com/users/babolivier/orgs', 'repos_url': 'https://api.github.com/users/babolivier/repos', 'events_url': 'https://api.github.com/users/babolivier/events{/privacy}', 'received_events_url': 'https://api.github.com/users/babolivier/received_events', 'type': 'User', 'site_admin': False}","[{'id': 121086029, 'node_id': 'MDU6TGFiZWwxMjEwODYwMjk=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/bug', 'name': 'bug', 'color': 'fc2929', 'default': True, 'description': None}, {'id': 845245048, 'node_id': 'MDU6TGFiZWw4NDUyNDUwNDg=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/docs', 'name': 'docs', 'color': '0e8a16', 'default': False, 'description': ''}, {'id': 477043173, 'node_id': 'MDU6TGFiZWw0NzcwNDMxNzM=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/p2', 'name': 'p2', 'color': 'fbca04', 'default': False, 'description': None}]",closed,False,,[],,2,2020-05-01T10:32:17Z,2020-05-01T16:20:35Z,2020-05-01T16:06:23Z,MEMBER,,,"Synapse complains about missing a config file if called with `--help`, instead of just printing the help doc:
```
$ python -m synapse.app.homeserver --help
usage: homeserver.py [-c CONFIG_FILE] [--generate-config] [--generate-missing-configs] [-H SERVER_NAME] [--report-stats {yes,no}] [--config-directory DIRECTORY] [--data-directory DIRECTORY] [--open-private-ports]
homeserver.py: error: Must supply a config file.
A config file can be automatically generated using ""--generate-config -H SERVER_NAME -c CONFIG-FILE""
```
If a configuration file is provided, it will print the help doc as expected:
```
$ python -m synapse.app.homeserver -c homeserver.yaml --help
usage: homeserver.py [-h] [-c CONFIG_FILE] [--generate-config] [--generate-missing-configs] [-H SERVER_NAME] [--report-stats {yes,no}] [--config-directory DIRECTORY] [--data-directory DIRECTORY] [--open-private-ports] [-D]
[--print-pidfile] [--manhole PORT] [-d SQLITE_DATABASE_PATH] [-n] [--enable-registration]
Synapse Homeserver
optional arguments:
-h, --help show this help message and exit
-c CONFIG_FILE, --config-path CONFIG_FILE
Specify config file. Can be given multiple times and may specify directories containing *.yaml files.
[...]
```
It seems a bit silly to me that we need a configuration file just to display the help for `synapse.app.homeserver`.",
900,https://api.github.com/repos/matrix-org/synapse/issues/7388,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7388/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7388/comments,https://api.github.com/repos/matrix-org/synapse/issues/7388/events,https://github.com/matrix-org/synapse/issues/7388,610681759,MDU6SXNzdWU2MTA2ODE3NTk=,7388,Can we optimise the 'Update remote profile' task?,"{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}","[{'id': 600557921, 'node_id': 'MDU6TGFiZWw2MDA1NTc5MjE=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/performance', 'name': 'performance', 'color': 'fef2c0', 'default': False, 'description': None}]",open,False,,[],,1,2020-05-01T10:23:15Z,2020-05-11T14:41:16Z,,MEMBER,,,"This runs most of the time on the master, averaging 4% of CPU. It's not obvious it needs to. Optimising it would require understanding what it is meant to be doing and how, though.",
901,https://api.github.com/repos/matrix-org/synapse/issues/7387,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7387/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7387/comments,https://api.github.com/repos/matrix-org/synapse/issues/7387/events,https://github.com/matrix-org/synapse/pull/7387,610665410,MDExOlB1bGxSZXF1ZXN0NDEyMDY0MDMw,7387,Wait for current_state_events_membership before populate_stats_process_rooms,"{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,0,2020-05-01T09:34:53Z,2020-05-01T17:06:00Z,2020-05-01T17:05:59Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7387', 'html_url': 'https://github.com/matrix-org/synapse/pull/7387', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7387.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7387.patch'}","`populate_stats_process_rooms` was added in #5971 / v1.4.0; `current_state_events_membership` was added in #5706 / v1.3.0.
Fixes #7380.",
902,https://api.github.com/repos/matrix-org/synapse/issues/7386,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7386/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7386/comments,https://api.github.com/repos/matrix-org/synapse/issues/7386/events,https://github.com/matrix-org/synapse/issues/7386,610592373,MDU6SXNzdWU2MTA1OTIzNzM=,7386,Deletion of user account not possible.,"{'login': 'derritter88', 'id': 8606313, 'node_id': 'MDQ6VXNlcjg2MDYzMTM=', 'avatar_url': 'https://avatars2.githubusercontent.com/u/8606313?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/derritter88', 'html_url': 'https://github.com/derritter88', 'followers_url': 'https://api.github.com/users/derritter88/followers', 'following_url': 'https://api.github.com/users/derritter88/following{/other_user}', 'gists_url': 'https://api.github.com/users/derritter88/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/derritter88/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/derritter88/subscriptions', 'organizations_url': 'https://api.github.com/users/derritter88/orgs', 'repos_url': 'https://api.github.com/users/derritter88/repos', 'events_url': 'https://api.github.com/users/derritter88/events{/privacy}', 'received_events_url': 'https://api.github.com/users/derritter88/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,3,2020-05-01T06:28:41Z,2020-05-01T09:15:33Z,2020-05-01T08:40:40Z,NONE,,,"Please don't file github issues asking for support.
Instead, please join [`#synapse:matrix.org`](https://matrix.to/#/#synapse:matrix.org)
(from a matrix.org account if necessary), and ask there.
",
903,https://api.github.com/repos/matrix-org/synapse/issues/7385,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7385/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7385/comments,https://api.github.com/repos/matrix-org/synapse/issues/7385/events,https://github.com/matrix-org/synapse/pull/7385,610566569,MDExOlB1bGxSZXF1ZXN0NDExOTgzMDU0,7385,allow emails to be passed through SAML,"{'login': 'cg505', 'id': 1581504, 'node_id': 'MDQ6VXNlcjE1ODE1MDQ=', 'avatar_url': 'https://avatars2.githubusercontent.com/u/1581504?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/cg505', 'html_url': 'https://github.com/cg505', 'followers_url': 'https://api.github.com/users/cg505/followers', 'following_url': 'https://api.github.com/users/cg505/following{/other_user}', 'gists_url': 'https://api.github.com/users/cg505/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/cg505/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/cg505/subscriptions', 'organizations_url': 'https://api.github.com/users/cg505/orgs', 'repos_url': 'https://api.github.com/users/cg505/repos', 'events_url': 'https://api.github.com/users/cg505/events{/privacy}', 'received_events_url': 'https://api.github.com/users/cg505/received_events', 'type': 'User', 'site_admin': False}","[{'id': 955488836, 'node_id': 'MDU6TGFiZWw5NTU0ODg4MzY=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/awaiting%20changes', 'name': 'awaiting changes', 'color': 'cfe886', 'default': False, 'description': ''}]",closed,False,,[],,8,2020-05-01T05:08:25Z,2020-05-28T16:56:06Z,2020-05-27T16:40:08Z,CONTRIBUTOR,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7385', 'html_url': 'https://github.com/matrix-org/synapse/pull/7385', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7385.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7385.patch'}","Signed-off-by: Christopher Cooper
### Pull Request Checklist
* [x] Pull request is based on the develop branch
* [x] Pull request includes a [changelog file](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#changelog). The entry should:
- Be a short description of your change which makes sense to users. ""Fixed a bug that prevented receiving messages from other servers."" instead of ""Moved X method from `EventStore` to `EventWorkerStore`."".
- Use markdown where necessary, mostly for `code blocks`.
- End with either a period (.) or an exclamation mark (!).
- Start with a capital letter.
* [x] Pull request includes a [sign off](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#sign-off)
* [x] Code style is correct (run the [linters](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#code-style))
",
904,https://api.github.com/repos/matrix-org/synapse/issues/7384,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7384/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7384/comments,https://api.github.com/repos/matrix-org/synapse/issues/7384/events,https://github.com/matrix-org/synapse/pull/7384,610409105,MDExOlB1bGxSZXF1ZXN0NDExODU0OTUx,7384,Fix limit logic for AccountDataStream,"{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,0,2020-04-30T21:48:14Z,2020-05-15T18:03:27Z,2020-05-15T18:03:26Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7384', 'html_url': 'https://github.com/matrix-org/synapse/pull/7384', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7384.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7384.patch'}","Make sure that the AccountDataStream presents complete updates, in the right
order.
This is much the same fix as #7337 and #7358, but applied to a different stream.",
905,https://api.github.com/repos/matrix-org/synapse/issues/7383,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7383/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7383/comments,https://api.github.com/repos/matrix-org/synapse/issues/7383/events,https://github.com/matrix-org/synapse/issues/7383,610356889,MDU6SXNzdWU2MTAzNTY4ODk=,7383,User directory doesn't show display names based on the requester's view,"{'login': 'giambr1', 'id': 62073807, 'node_id': 'MDQ6VXNlcjYyMDczODA3', 'avatar_url': 'https://avatars0.githubusercontent.com/u/62073807?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/giambr1', 'html_url': 'https://github.com/giambr1', 'followers_url': 'https://api.github.com/users/giambr1/followers', 'following_url': 'https://api.github.com/users/giambr1/following{/other_user}', 'gists_url': 'https://api.github.com/users/giambr1/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/giambr1/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/giambr1/subscriptions', 'organizations_url': 'https://api.github.com/users/giambr1/orgs', 'repos_url': 'https://api.github.com/users/giambr1/repos', 'events_url': 'https://api.github.com/users/giambr1/events{/privacy}', 'received_events_url': 'https://api.github.com/users/giambr1/received_events', 'type': 'User', 'site_admin': False}","[{'id': 477043173, 'node_id': 'MDU6TGFiZWw0NzcwNDMxNzM=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/p2', 'name': 'p2', 'color': 'fbca04', 'default': False, 'description': None}, {'id': 2028961502, 'node_id': 'MDU6TGFiZWwyMDI4OTYxNTAy', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/user-directory', 'name': 'user-directory', 'color': 'bfdadc', 'default': False, 'description': ''}]",closed,False,,[],,3,2020-04-30T20:14:48Z,2020-05-11T13:22:20Z,2020-05-11T13:22:20Z,NONE,,,"I run a debian server with a friend.
I have installed synapse following https://github.com/spantaleev/matrix-docker-ansible-deploy/ .
I have configured the bridge https://github.com/tulir/mautrix-telegram again through the playbook.
I had some problem related to private telegram contacts sharing between our two accounts on the server.
https://github.com/tulir/mautrix-telegram/issues/459 addresses the details of my problem. It has been suggested the issue is related more to synapse than the bridge itself.
",
906,https://api.github.com/repos/matrix-org/synapse/issues/7382,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7382/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7382/comments,https://api.github.com/repos/matrix-org/synapse/issues/7382/events,https://github.com/matrix-org/synapse/pull/7382,610291573,MDExOlB1bGxSZXF1ZXN0NDExNzYwMDIz,7382,Fix typing annotations in synapse/federation,"{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,0,2020-04-30T18:23:50Z,2020-05-05T13:27:15Z,2020-05-05T13:27:14Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7382', 'html_url': 'https://github.com/matrix-org/synapse/pull/7382', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7382.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7382.patch'}","We're pretty close to having mypy working for `synapse.federation`, so let's finish the job.
~Based on #7374.~",
907,https://api.github.com/repos/matrix-org/synapse/issues/7381,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7381/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7381/comments,https://api.github.com/repos/matrix-org/synapse/issues/7381/events,https://github.com/matrix-org/synapse/pull/7381,610273707,MDExOlB1bGxSZXF1ZXN0NDExNzQ1Mzg2,7381,Strictly enforce canonicaljson requirements in a new room version,"{'login': 'clokep', 'id': 517124, 'node_id': 'MDQ6VXNlcjUxNzEyNA==', 'avatar_url': 'https://avatars2.githubusercontent.com/u/517124?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/clokep', 'html_url': 'https://github.com/clokep', 'followers_url': 'https://api.github.com/users/clokep/followers', 'following_url': 'https://api.github.com/users/clokep/following{/other_user}', 'gists_url': 'https://api.github.com/users/clokep/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/clokep/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/clokep/subscriptions', 'organizations_url': 'https://api.github.com/users/clokep/orgs', 'repos_url': 'https://api.github.com/users/clokep/repos', 'events_url': 'https://api.github.com/users/clokep/events{/privacy}', 'received_events_url': 'https://api.github.com/users/clokep/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,4,2020-04-30T17:54:09Z,2020-05-14T17:24:04Z,2020-05-14T17:24:02Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7381', 'html_url': 'https://github.com/matrix-org/synapse/pull/7381', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7381.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7381.patch'}","This PR does the following:
* Adds an experimental room version which strictly adheres to the [canonical JSON specification](https://matrix.org/docs/spec/appendices#canonical-json):
* Rejects integers outside of the range of [-2 ^ 53 + 1, 2 ^ 53 - 1]
* Rejects floats
* Does not parse Python special values (NaN, Infinity, -Infinity)
* Logic to strictly enforce this is added to the client-server API and the federation API.
Replaces #7356
Implements MSC2540: matrix-org/matrix-doc#2540.
## To Do
* [x] Perform more testing with federation.
* [x] Does this need to be optimized? (Some really rough numbers show that this about doubles the runtime of `event_from_pdu_json`.)
* No!
* [ ] Can we consolidate some of this validation logic further?",
908,https://api.github.com/repos/matrix-org/synapse/issues/7380,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7380/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7380/comments,https://api.github.com/repos/matrix-org/synapse/issues/7380/events,https://github.com/matrix-org/synapse/issues/7380,610270331,MDU6SXNzdWU2MTAyNzAzMzE=,7380,populate_stats_process_rooms runs in the wrong order,"{'login': 'michaelkaye', 'id': 1917473, 'node_id': 'MDQ6VXNlcjE5MTc0NzM=', 'avatar_url': 'https://avatars0.githubusercontent.com/u/1917473?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/michaelkaye', 'html_url': 'https://github.com/michaelkaye', 'followers_url': 'https://api.github.com/users/michaelkaye/followers', 'following_url': 'https://api.github.com/users/michaelkaye/following{/other_user}', 'gists_url': 'https://api.github.com/users/michaelkaye/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/michaelkaye/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/michaelkaye/subscriptions', 'organizations_url': 'https://api.github.com/users/michaelkaye/orgs', 'repos_url': 'https://api.github.com/users/michaelkaye/repos', 'events_url': 'https://api.github.com/users/michaelkaye/events{/privacy}', 'received_events_url': 'https://api.github.com/users/michaelkaye/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,"{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}","[{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}]",,3,2020-04-30T17:48:46Z,2020-05-05T09:11:11Z,2020-05-05T09:11:11Z,CONTRIBUTOR,,,"Upgrading from a 1.0 synapse to the latest causes an issue where the `populate_stats_process_rooms` background task starts running immediately, however I believe it's actually requiring data that is changed as part of `current_state_events_membership` to function correctly.
i think there should be a dependency from `current_state_events_membership` to `populate_stats_process_rooms` to fix this, but there may also be others - is this something that needs to be thought about when choosing background updates' dependencies, i don't think they automatically wait until the ones from previous versions are run.
This isn't a problem when keeping up to date with synapse, but doing larger bulk updates can cause issues.
",
909,https://api.github.com/repos/matrix-org/synapse/issues/7379,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7379/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7379/comments,https://api.github.com/repos/matrix-org/synapse/issues/7379/events,https://github.com/matrix-org/synapse/pull/7379,610238356,MDExOlB1bGxSZXF1ZXN0NDExNzE2NDI1,7379,Make it clearer that #synapse:matrix.org is our support channel,"{'login': 'babolivier', 'id': 5547783, 'node_id': 'MDQ6VXNlcjU1NDc3ODM=', 'avatar_url': 'https://avatars3.githubusercontent.com/u/5547783?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/babolivier', 'html_url': 'https://github.com/babolivier', 'followers_url': 'https://api.github.com/users/babolivier/followers', 'following_url': 'https://api.github.com/users/babolivier/following{/other_user}', 'gists_url': 'https://api.github.com/users/babolivier/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/babolivier/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/babolivier/subscriptions', 'organizations_url': 'https://api.github.com/users/babolivier/orgs', 'repos_url': 'https://api.github.com/users/babolivier/repos', 'events_url': 'https://api.github.com/users/babolivier/events{/privacy}', 'received_events_url': 'https://api.github.com/users/babolivier/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,0,2020-04-30T16:57:56Z,2020-08-04T16:48:10Z,2020-05-01T11:42:36Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7379', 'html_url': 'https://github.com/matrix-org/synapse/pull/7379', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7379.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7379.patch'}","This PR moves the ""support is in #synapse:matrix.org"" in the bug report template outside of the comment as some people seem to ignore what's in the comments, and phrase it a bit more like the support request template. It also adds a default issue template that says the same thing. It's also adding a notice about the security disclosure to both the default template and the bug report one.
It also adds a badge to the top of the README that looks like this:
![Screenshot from 2020-04-30 11-10-12](https://user-images.githubusercontent.com/5547783/80737183-72824180-8b13-11ea-9b59-32ece2131e25.png)
With an alt text saying about the same message if the badge doesn't load (e.g. if matrix.org is slow):
![Screenshot from 2020-04-30 18-51-15](https://user-images.githubusercontent.com/5547783/80737650-2257af00-8b14-11ea-952c-a8f951beea11.png)
I've opened this PR against master on purpose (for once) because I believe it's a good thing to have this out on master soon.
Fixes #6826 ",
910,https://api.github.com/repos/matrix-org/synapse/issues/7378,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7378/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7378/comments,https://api.github.com/repos/matrix-org/synapse/issues/7378/events,https://github.com/matrix-org/synapse/pull/7378,610236128,MDExOlB1bGxSZXF1ZXN0NDExNzE0NTc2,7378,Workaround for assertion errors from db_query_to_update_function,"{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,0,2020-04-30T16:54:23Z,2020-05-01T08:25:18Z,2020-05-01T08:25:17Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7378', 'html_url': 'https://github.com/matrix-org/synapse/pull/7378', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7378.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7378.patch'}","Hopefully this is no worse than what we have on master...
This is a mitigation to the assertionerrors in #7340, but I'm still deeply suspicious that we're not doing the right thing here.",
911,https://api.github.com/repos/matrix-org/synapse/issues/7377,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7377/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7377/comments,https://api.github.com/repos/matrix-org/synapse/issues/7377/events,https://github.com/matrix-org/synapse/pull/7377,610232068,MDExOlB1bGxSZXF1ZXN0NDExNzExMjkw,7377,Search in columns 'name' and 'displayname' in the admin users endpoint,"{'login': 'awesome-manuel', 'id': 37705355, 'node_id': 'MDQ6VXNlcjM3NzA1MzU1', 'avatar_url': 'https://avatars0.githubusercontent.com/u/37705355?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/awesome-manuel', 'html_url': 'https://github.com/awesome-manuel', 'followers_url': 'https://api.github.com/users/awesome-manuel/followers', 'following_url': 'https://api.github.com/users/awesome-manuel/following{/other_user}', 'gists_url': 'https://api.github.com/users/awesome-manuel/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/awesome-manuel/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/awesome-manuel/subscriptions', 'organizations_url': 'https://api.github.com/users/awesome-manuel/orgs', 'repos_url': 'https://api.github.com/users/awesome-manuel/repos', 'events_url': 'https://api.github.com/users/awesome-manuel/events{/privacy}', 'received_events_url': 'https://api.github.com/users/awesome-manuel/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,"{'login': 'anoadragon453', 'id': 1342360, 'node_id': 'MDQ6VXNlcjEzNDIzNjA=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1342360?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/anoadragon453', 'html_url': 'https://github.com/anoadragon453', 'followers_url': 'https://api.github.com/users/anoadragon453/followers', 'following_url': 'https://api.github.com/users/anoadragon453/following{/other_user}', 'gists_url': 'https://api.github.com/users/anoadragon453/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/anoadragon453/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/anoadragon453/subscriptions', 'organizations_url': 'https://api.github.com/users/anoadragon453/orgs', 'repos_url': 'https://api.github.com/users/anoadragon453/repos', 'events_url': 'https://api.github.com/users/anoadragon453/events{/privacy}', 'received_events_url': 'https://api.github.com/users/anoadragon453/received_events', 'type': 'User', 'site_admin': False}","[{'login': 'anoadragon453', 'id': 1342360, 'node_id': 'MDQ6VXNlcjEzNDIzNjA=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1342360?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/anoadragon453', 'html_url': 'https://github.com/anoadragon453', 'followers_url': 'https://api.github.com/users/anoadragon453/followers', 'following_url': 'https://api.github.com/users/anoadragon453/following{/other_user}', 'gists_url': 'https://api.github.com/users/anoadragon453/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/anoadragon453/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/anoadragon453/subscriptions', 'organizations_url': 'https://api.github.com/users/anoadragon453/orgs', 'repos_url': 'https://api.github.com/users/anoadragon453/repos', 'events_url': 'https://api.github.com/users/anoadragon453/events{/privacy}', 'received_events_url': 'https://api.github.com/users/anoadragon453/received_events', 'type': 'User', 'site_admin': False}]",,7,2020-04-30T16:47:51Z,2020-08-25T13:18:15Z,2020-08-25T13:18:15Z,CONTRIBUTOR,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7377', 'html_url': 'https://github.com/matrix-org/synapse/pull/7377', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7377.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7377.patch'}","### Pull Request Checklist
* [x] Pull request is based on the develop branch
* [x] Pull request includes a [changelog file](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#changelog). The entry should:
- Be a short description of your change which makes sense to users. ""Fixed a bug that prevented receiving messages from other servers."" instead of ""Moved X method from `EventStore` to `EventWorkerStore`."".
- Use markdown where necessary, mostly for `code blocks`.
- End with either a period (.) or an exclamation mark (!).
- Start with a capital letter.
* [x] Pull request includes a [sign off](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#sign-off)
* [x] Code style is correct (run the [linters](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#code-style))
",
912,https://api.github.com/repos/matrix-org/synapse/issues/7376,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7376/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7376/comments,https://api.github.com/repos/matrix-org/synapse/issues/7376/events,https://github.com/matrix-org/synapse/pull/7376,610141624,MDExOlB1bGxSZXF1ZXN0NDExNjMxMjkw,7376,Stop `get_joined_users` corruption from custom statuses,"{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,"{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}","[{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}]",,9,2020-04-30T15:25:35Z,2020-05-14T09:07:56Z,2020-05-14T09:07:55Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7376', 'html_url': 'https://github.com/matrix-org/synapse/pull/7376', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7376.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7376.patch'}","Fix a bug where the `get_joined_users` cache could be corrupted by custom
status events (or other state events with a state_key matching the user ID).
The bug was introduced by #2229, but has largely gone unnoticed since then.
Fixes #7099, #7373.",
913,https://api.github.com/repos/matrix-org/synapse/issues/7375,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7375/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7375/comments,https://api.github.com/repos/matrix-org/synapse/issues/7375/events,https://github.com/matrix-org/synapse/issues/7375,609908681,MDU6SXNzdWU2MDk5MDg2ODE=,7375,JSONDecodeError: Expecting value: line 1 column 1 (char 0),"{'login': 'schildbach', 'id': 743306, 'node_id': 'MDQ6VXNlcjc0MzMwNg==', 'avatar_url': 'https://avatars0.githubusercontent.com/u/743306?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/schildbach', 'html_url': 'https://github.com/schildbach', 'followers_url': 'https://api.github.com/users/schildbach/followers', 'following_url': 'https://api.github.com/users/schildbach/following{/other_user}', 'gists_url': 'https://api.github.com/users/schildbach/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/schildbach/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/schildbach/subscriptions', 'organizations_url': 'https://api.github.com/users/schildbach/orgs', 'repos_url': 'https://api.github.com/users/schildbach/repos', 'events_url': 'https://api.github.com/users/schildbach/events{/privacy}', 'received_events_url': 'https://api.github.com/users/schildbach/received_events', 'type': 'User', 'site_admin': False}","[{'id': 121086029, 'node_id': 'MDU6TGFiZWwxMjEwODYwMjk=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/bug', 'name': 'bug', 'color': 'fc2929', 'default': True, 'description': None}, {'id': 1311133228, 'node_id': 'MDU6TGFiZWwxMzExMTMzMjI4', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/info-needed', 'name': 'info-needed', 'color': 'a1e8ea', 'default': False, 'description': ''}]",closed,False,,[],,7,2020-04-30T12:23:58Z,2020-05-04T10:10:34Z,2020-05-04T09:25:00Z,NONE,,,"I keep seeing these errors in the log. I'm using Synapse 1.12.4 and Postgres 10.12, both inside Docker-Compose running Ubuntu 20.04 LTS on the host.
```
Apr 30 12:18:46 ultima docker-compose[22585]: synapse_1 | 2020-04-30 12:18:46,662 - synapse.http.server - 110 - ERROR - GET-15024 - Failed handle request via 'SyncRestServlet':
Apr 30 12:18:46 ultima docker-compose[22585]: synapse_1 | Traceback (most recent call last):
Apr 30 12:18:46 ultima docker-compose[22585]: synapse_1 | File ""/usr/local/lib/python3.7/site-packages/twisted/internet/defer.py"", line 1418, in _inlineCallbacks
Apr 30 12:18:46 ultima docker-compose[22585]: synapse_1 | result = g.send(result)
Apr 30 12:18:46 ultima docker-compose[22585]: synapse_1 | StopIteration: {'$1560540549116pGgvF:fuckeverywhere.space': {'event_id': '$1560540549116pGgvF:fuckeverywhere.space', 'internal_metadata': '{""outlier"": false, ""redacted"": true, ""stream_ordering"": -5104}', 'json': '{""content"": {}, ""event_id"": ""$1560540549116p>
Apr 30 12:18:46 ultima docker-compose[22585]: vh+26NN5fXDHwUZMqSQV9BNy/kHwUQvS4""}]], ""signatures"": {""fuckeverywhere.space"": {""ed25519:a_HvTl"": ""XD6v5fLWbEd5K9Z6cXM8sq+OjItjhXalxZVnDylOOrA/TEF+uVSr0s4+/ztGqiQm1C7wAre5ikMawXqr/2ePBA""}}, ""unsigned"": {}}', 'format_version': 1, 'room_version_id': '1', 'rejected_reason': >
Apr 30 12:18:46 ultima docker-compose[22585]: synapse_1 |
Apr 30 12:18:46 ultima docker-compose[22585]: synapse_1 | During handling of the above exception, another exception occurred:
Apr 30 12:18:46 ultima docker-compose[22585]: synapse_1 |
Apr 30 12:18:46 ultima docker-compose[22585]: synapse_1 | Traceback (most recent call last):
Apr 30 12:18:46 ultima docker-compose[22585]: synapse_1 | File ""/usr/local/lib/python3.7/site-packages/twisted/internet/defer.py"", line 1416, in _inlineCallbacks
Apr 30 12:18:46 ultima docker-compose[22585]: synapse_1 | result = result.throwExceptionIntoGenerator(g)
Apr 30 12:18:46 ultima docker-compose[22585]: synapse_1 | File ""/usr/local/lib/python3.7/site-packages/twisted/python/failure.py"", line 512, in throwExceptionIntoGenerator
Apr 30 12:18:46 ultima docker-compose[22585]: synapse_1 | return g.throw(self.type, self.value, self.tb)
Apr 30 12:18:46 ultima docker-compose[22585]: synapse_1 | File ""/usr/local/lib/python3.7/site-packages/synapse/handlers/sync.py"", line 312, in _wait_for_sync_for_user
Apr 30 12:18:46 ultima docker-compose[22585]: synapse_1 | sync_config, since_token, full_state=full_state
Apr 30 12:18:46 ultima docker-compose[22585]: synapse_1 | File ""/usr/local/lib/python3.7/site-packages/synapse/handlers/sync.py"", line 343, in current_sync_for_user
Apr 30 12:18:46 ultima docker-compose[22585]: synapse_1 | return await self.generate_sync_result(sync_config, since_token, full_state)
Apr 30 12:18:46 ultima docker-compose[22585]: synapse_1 | File ""/usr/local/lib/python3.7/site-packages/synapse/handlers/sync.py"", line 1000, in generate_sync_result
Apr 30 12:18:46 ultima docker-compose[22585]: synapse_1 | sync_result_builder, account_data_by_room
Apr 30 12:18:46 ultima docker-compose[22585]: synapse_1 | File ""/usr/local/lib/python3.7/site-packages/synapse/handlers/sync.py"", line 1419, in _generate_sync_entry_for_rooms
Apr 30 12:18:46 ultima docker-compose[22585]: synapse_1 | await concurrently_execute(handle_room_entries, room_entries, 10)
Apr 30 12:18:46 ultima docker-compose[22585]: synapse_1 | File ""/usr/local/lib/python3.7/site-packages/twisted/internet/defer.py"", line 1416, in _inlineCallbacks
Apr 30 12:18:46 ultima docker-compose[22585]: synapse_1 | result = result.throwExceptionIntoGenerator(g)
Apr 30 12:18:46 ultima docker-compose[22585]: synapse_1 | File ""/usr/local/lib/python3.7/site-packages/twisted/python/failure.py"", line 512, in throwExceptionIntoGenerator
Apr 30 12:18:46 ultima docker-compose[22585]: synapse_1 | return g.throw(self.type, self.value, self.tb)
Apr 30 12:18:46 ultima docker-compose[22585]: synapse_1 | File ""/usr/local/lib/python3.7/site-packages/synapse/util/async_helpers.py"", line 159, in _concurrently_execute_inner
Apr 30 12:18:46 ultima docker-compose[22585]: synapse_1 | await maybe_awaitable(func(next(it)))
Apr 30 12:18:46 ultima docker-compose[22585]: synapse_1 | File ""/usr/local/lib/python3.7/site-packages/synapse/handlers/sync.py"", line 1803, in _generate_room_entry
Apr 30 12:18:46 ultima docker-compose[22585]: synapse_1 | newly_joined_room=newly_joined,
Apr 30 12:18:46 ultima docker-compose[22585]: synapse_1 | File ""/usr/local/lib/python3.7/site-packages/synapse/handlers/sync.py"", line 498, in _load_filtered_recents
Apr 30 12:18:46 ultima docker-compose[22585]: synapse_1 | room_id, limit=load_limit + 1, end_token=end_key
Apr 30 12:18:46 ultima docker-compose[22585]: synapse_1 | File ""/usr/local/lib/python3.7/site-packages/twisted/internet/defer.py"", line 1416, in _inlineCallbacks
Apr 30 12:18:46 ultima docker-compose[22585]: synapse_1 | result = result.throwExceptionIntoGenerator(g)
Apr 30 12:18:46 ultima docker-compose[22585]: synapse_1 | File ""/usr/local/lib/python3.7/site-packages/twisted/python/failure.py"", line 512, in throwExceptionIntoGenerator
Apr 30 12:18:46 ultima docker-compose[22585]: synapse_1 | return g.throw(self.type, self.value, self.tb)
Apr 30 12:18:46 ultima docker-compose[22585]: synapse_1 | File ""/usr/local/lib/python3.7/site-packages/synapse/storage/data_stores/main/stream.py"", line 486, in get_recent_events_for_room
Apr 30 12:18:46 ultima docker-compose[22585]: synapse_1 | [r.event_id for r in rows], get_prev_content=True
Apr 30 12:18:46 ultima docker-compose[22585]: synapse_1 | File ""/usr/local/lib/python3.7/site-packages/twisted/internet/defer.py"", line 1416, in _inlineCallbacks
Apr 30 12:18:46 ultima docker-compose[22585]: synapse_1 | result = result.throwExceptionIntoGenerator(g)
Apr 30 12:18:46 ultima docker-compose[22585]: synapse_1 | File ""/usr/local/lib/python3.7/site-packages/twisted/python/failure.py"", line 512, in throwExceptionIntoGenerator
Apr 30 12:18:46 ultima docker-compose[22585]: synapse_1 | return g.throw(self.type, self.value, self.tb)
Apr 30 12:18:46 ultima docker-compose[22585]: synapse_1 | File ""/usr/local/lib/python3.7/site-packages/synapse/storage/data_stores/main/events_worker.py"", line 274, in get_events_as_list
Apr 30 12:18:46 ultima docker-compose[22585]: synapse_1 | set(event_ids), allow_rejected=allow_rejected
Apr 30 12:18:46 ultima docker-compose[22585]: synapse_1 | File ""/usr/local/lib/python3.7/site-packages/twisted/internet/defer.py"", line 1416, in _inlineCallbacks
Apr 30 12:18:46 ultima docker-compose[22585]: synapse_1 | result = result.throwExceptionIntoGenerator(g)
Apr 30 12:18:46 ultima docker-compose[22585]: synapse_1 | File ""/usr/local/lib/python3.7/site-packages/twisted/python/failure.py"", line 512, in throwExceptionIntoGenerator
Apr 30 12:18:46 ultima docker-compose[22585]: synapse_1 | return g.throw(self.type, self.value, self.tb)
Apr 30 12:18:46 ultima docker-compose[22585]: synapse_1 | File ""/usr/local/lib/python3.7/site-packages/synapse/storage/data_stores/main/events_worker.py"", line 421, in _get_events_from_cache_or_db
Apr 30 12:18:46 ultima docker-compose[22585]: synapse_1 | missing_events_ids, allow_rejected=allow_rejected
Apr 30 12:18:46 ultima docker-compose[22585]: synapse_1 | File ""/usr/local/lib/python3.7/site-packages/twisted/internet/defer.py"", line 1418, in _inlineCallbacks
Apr 30 12:18:46 ultima docker-compose[22585]: synapse_1 | result = g.send(result)
Apr 30 12:18:46 ultima docker-compose[22585]: synapse_1 | File ""/usr/local/lib/python3.7/site-packages/synapse/storage/data_stores/main/events_worker.py"", line 577, in _get_events_from_db
Apr 30 12:18:46 ultima docker-compose[22585]: synapse_1 | d = json.loads(row[""json""])
Apr 30 12:18:46 ultima docker-compose[22585]: synapse_1 | File ""/usr/local/lib/python3.7/site-packages/simplejson/__init__.py"", line 525, in loads
Apr 30 12:18:46 ultima docker-compose[22585]: synapse_1 | return _default_decoder.decode(s)
Apr 30 12:18:46 ultima docker-compose[22585]: synapse_1 | File ""/usr/local/lib/python3.7/site-packages/simplejson/decoder.py"", line 370, in decode
Apr 30 12:18:46 ultima docker-compose[22585]: synapse_1 | obj, end = self.raw_decode(s)
Apr 30 12:18:46 ultima docker-compose[22585]: synapse_1 | File ""/usr/local/lib/python3.7/site-packages/simplejson/decoder.py"", line 400, in raw_decode
Apr 30 12:18:46 ultima docker-compose[22585]: synapse_1 | return self.scan_once(s, idx=_w(s, idx).end())
Apr 30 12:18:46 ultima docker-compose[22585]: synapse_1 | simplejson.errors.JSONDecodeError: Expecting value: line 1 column 1 (char 0)
```
",
914,https://api.github.com/repos/matrix-org/synapse/issues/7374,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7374/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7374/comments,https://api.github.com/repos/matrix-org/synapse/issues/7374/events,https://github.com/matrix-org/synapse/pull/7374,609901792,MDExOlB1bGxSZXF1ZXN0NDExNDE2NDkw,7374,Fix catchup-on-reconnect for the Federation Stream,"{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,0,2020-04-30T12:18:13Z,2020-05-05T13:15:59Z,2020-05-05T13:15:58Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7374', 'html_url': 'https://github.com/matrix-org/synapse/pull/7374', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7374.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7374.patch'}",looks like we managed to break this during the refactorathon.,
915,https://api.github.com/repos/matrix-org/synapse/issues/7373,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7373/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7373/comments,https://api.github.com/repos/matrix-org/synapse/issues/7373/events,https://github.com/matrix-org/synapse/issues/7373,609755043,MDU6SXNzdWU2MDk3NTUwNDM=,7373,/joined_members incorrectly says the appservice wasn't in the room,"{'login': 'Sorunome', 'id': 2433620, 'node_id': 'MDQ6VXNlcjI0MzM2MjA=', 'avatar_url': 'https://avatars3.githubusercontent.com/u/2433620?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Sorunome', 'html_url': 'https://github.com/Sorunome', 'followers_url': 'https://api.github.com/users/Sorunome/followers', 'following_url': 'https://api.github.com/users/Sorunome/following{/other_user}', 'gists_url': 'https://api.github.com/users/Sorunome/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/Sorunome/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/Sorunome/subscriptions', 'organizations_url': 'https://api.github.com/users/Sorunome/orgs', 'repos_url': 'https://api.github.com/users/Sorunome/repos', 'events_url': 'https://api.github.com/users/Sorunome/events{/privacy}', 'received_events_url': 'https://api.github.com/users/Sorunome/received_events', 'type': 'User', 'site_admin': False}","[{'id': 477046103, 'node_id': 'MDU6TGFiZWw0NzcwNDYxMDM=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/application-service', 'name': 'application-service', 'color': 'ededed', 'default': False, 'description': None}, {'id': 121086029, 'node_id': 'MDU6TGFiZWwxMjEwODYwMjk=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/bug', 'name': 'bug', 'color': 'fc2929', 'default': True, 'description': None}, {'id': 477043173, 'node_id': 'MDU6TGFiZWw0NzcwNDMxNzM=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/p2', 'name': 'p2', 'color': 'fbca04', 'default': False, 'description': None}]",closed,False,,[],,2,2020-04-30T09:28:10Z,2020-05-14T11:11:59Z,2020-05-14T11:11:59Z,CONTRIBUTOR,,,"
### Description
When trying to call `/joined_members` synapse incorrectly claims that the appservice wasn't in the room. While the appservice bot itself is indeed not in the room, the ghost set in the `user_id` query parameter is.
```
sorunome@sorunome-desktop ~ $ curl -H ""Authorization: Bearer 0d1dcaae-26db-4810-b284-48df4223328e"" ""http://192.168.1.13:8008/_matrix/client/r0/rooms/%21KiNzXZsRUASeNmbTVD%3A192.168.1.13/joined_members?user_id=%40_botty_n%3D2cj1x3ls3e_42sq9ub%3A192.168.1.13""
{
""joined"": {
""@_botty_n=2cj1x3ls3e_42sq9ub:192.168.1.13"": {
""avatar_url"": ""mxc://192.168.1.13/SFPimpzstdTNxFuIoxwClVRV"",
""display_name"": ""Fuchs Rolle!!!""
},
""@test:192.168.1.13"": {
""avatar_url"": ""mxc://192.168.1.13/YKbcxzDWAYgwrdegzQZmFMYX"",
""display_name"": ""test""
}
}
}
sorunome@sorunome-desktop ~ $ curl -X PUT -H ""Authorization: Bearer 0d1dcaae-26db-4810-b284-48df4223328e"" -H ""Content-Type: application/json"" -d '{""beep"": ""boop""}' ""http://192.168.1.13:8008/_matrix/client/r0/rooms/%21KiNzXZsRUASeNmbTVD%3A192.168.1.13/state/de.sorunome.custom/%40_botty_n%3D2cj1x3ls3e_42sq9ub%3A192.168.1.13?user_id=%40_botty_n%3D2cj1x3ls3e_42sq9ub%3A192.168.1.13""
{
""event_id"": ""$nfrfZ-FtF1LLJZAPjfVYoSHplI0tkNeQ3GSCGi5wjig""
}
sorunome@sorunome-desktop ~ $ curl -H ""Authorization: Bearer 0d1dcaae-26db-4810-b284-48df4223328e"" ""http://192.168.1.13:8008/_matrix/client/r0/rooms/%21KiNzXZsRUASeNmbTVD%3A192.168.1.13/joined_members?user_id=%40_botty_n%3D2cj1x3ls3e_42sq9ub%3A192.168.1.13""
{
""errcode"": ""M_FORBIDDEN"",
""error"": ""Appservice not in room""
}
```
(The appservice token is only for a local install)
### Steps to reproduce
- start synapse
- call `/joined_members` as an appservice ghost that the ghost is in --> it returns the results just fine
- set a state event as said ghost with the `state_key` being its mxid. This needs to actually create a new / modify the existing state, else the bug won't trigger
- call again `/joined_members`, synapse now claims the appservice wasn't in the room until a restart occurs
### Version information
- **Version**:
```
sorunome@sorunome-desktop ~ $ curl http://localhost:8008/_synapse/admin/v1/server_version
{
""python_version"": ""3.8.2"",
""server_version"": ""1.12.4 (b=master,204664d1a)""
}
```
- **Install method**:
`git clone`
- **Platform**:
archlinux
",
916,https://api.github.com/repos/matrix-org/synapse/issues/7372,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7372/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7372/comments,https://api.github.com/repos/matrix-org/synapse/issues/7372/events,https://github.com/matrix-org/synapse/pull/7372,609640188,MDExOlB1bGxSZXF1ZXN0NDExMTkwMDI5,7372,Reduce unnecessary whitespace in JSON,"{'login': 'auscompgeek', 'id': 128854, 'node_id': 'MDQ6VXNlcjEyODg1NA==', 'avatar_url': 'https://avatars2.githubusercontent.com/u/128854?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/auscompgeek', 'html_url': 'https://github.com/auscompgeek', 'followers_url': 'https://api.github.com/users/auscompgeek/followers', 'following_url': 'https://api.github.com/users/auscompgeek/following{/other_user}', 'gists_url': 'https://api.github.com/users/auscompgeek/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/auscompgeek/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/auscompgeek/subscriptions', 'organizations_url': 'https://api.github.com/users/auscompgeek/orgs', 'repos_url': 'https://api.github.com/users/auscompgeek/repos', 'events_url': 'https://api.github.com/users/auscompgeek/events{/privacy}', 'received_events_url': 'https://api.github.com/users/auscompgeek/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,"{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}","[{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}]",,18,2020-04-30T06:48:34Z,2020-08-07T12:04:21Z,2020-08-07T12:02:56Z,CONTRIBUTOR,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7372', 'html_url': 'https://github.com/matrix-org/synapse/pull/7372', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7372.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7372.patch'}","The `json` and `simplejson` modules when serialising default to separators such that the output is compatible with YAML 1.0. As there is no need for JSON responses from Matrix homeservers to be consumed by YAML 1.0/1.1 implementations, the whitespace this generates is redundant.
This PR reduces the amount of redundant whitespace that is stored and sent in responses, hopefully significantly reducing the resources required for Synapse in the long run.
This does not attempt to eliminate the unnecessary whitespace completely, nor does it introduce anything to rewrite data in existing databases to be compact, but rather this tries to find the biggest future wins for the average homeserver.
### Pull Request Checklist
* [x] Pull request is based on the develop branch
* [x] Pull request includes a [changelog file](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#changelog).
* [x] Pull request includes a [sign off](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#sign-off)
* [x] Code style is correct (run the [linters](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#code-style))
`Signed-off-by: David Vo `",
917,https://api.github.com/repos/matrix-org/synapse/issues/7371,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7371/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7371/comments,https://api.github.com/repos/matrix-org/synapse/issues/7371/events,https://github.com/matrix-org/synapse/issues/7371,609533619,MDU6SXNzdWU2MDk1MzM2MTk=,7371,matrix-synapse cannot stop nor restart.,"{'login': 'jumezurike', 'id': 9252094, 'node_id': 'MDQ6VXNlcjkyNTIwOTQ=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/9252094?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/jumezurike', 'html_url': 'https://github.com/jumezurike', 'followers_url': 'https://api.github.com/users/jumezurike/followers', 'following_url': 'https://api.github.com/users/jumezurike/following{/other_user}', 'gists_url': 'https://api.github.com/users/jumezurike/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/jumezurike/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/jumezurike/subscriptions', 'organizations_url': 'https://api.github.com/users/jumezurike/orgs', 'repos_url': 'https://api.github.com/users/jumezurike/repos', 'events_url': 'https://api.github.com/users/jumezurike/events{/privacy}', 'received_events_url': 'https://api.github.com/users/jumezurike/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,5,2020-04-30T03:13:10Z,2020-04-30T15:22:11Z,2020-04-30T08:11:44Z,NONE,,,"
### Description
### Steps to reproduce
- list the steps
- that reproduce the bug
- using hyphens as bullet points
### Version information
- **Homeserver**:
If not matrix.org:
- **Version**:
- **Install method**:
- **Platform**:
",
918,https://api.github.com/repos/matrix-org/synapse/issues/7370,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7370/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7370/comments,https://api.github.com/repos/matrix-org/synapse/issues/7370/events,https://github.com/matrix-org/synapse/issues/7370,609255230,MDU6SXNzdWU2MDkyNTUyMzA=,7370,per-block cpu and db usage metrics are no longer reported accurately,"{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}","[{'id': 121086029, 'node_id': 'MDU6TGFiZWwxMjEwODYwMjk=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/bug', 'name': 'bug', 'color': 'fc2929', 'default': True, 'description': None}, {'id': 828666468, 'node_id': 'MDU6TGFiZWw4Mjg2NjY0Njg=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/release%20blocker', 'name': 'release blocker', 'color': '880000', 'default': False, 'description': None}]",closed,False,"{'login': 'clokep', 'id': 517124, 'node_id': 'MDQ6VXNlcjUxNzEyNA==', 'avatar_url': 'https://avatars2.githubusercontent.com/u/517124?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/clokep', 'html_url': 'https://github.com/clokep', 'followers_url': 'https://api.github.com/users/clokep/followers', 'following_url': 'https://api.github.com/users/clokep/following{/other_user}', 'gists_url': 'https://api.github.com/users/clokep/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/clokep/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/clokep/subscriptions', 'organizations_url': 'https://api.github.com/users/clokep/orgs', 'repos_url': 'https://api.github.com/users/clokep/repos', 'events_url': 'https://api.github.com/users/clokep/events{/privacy}', 'received_events_url': 'https://api.github.com/users/clokep/received_events', 'type': 'User', 'site_admin': False}","[{'login': 'clokep', 'id': 517124, 'node_id': 'MDQ6VXNlcjUxNzEyNA==', 'avatar_url': 'https://avatars2.githubusercontent.com/u/517124?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/clokep', 'html_url': 'https://github.com/clokep', 'followers_url': 'https://api.github.com/users/clokep/followers', 'following_url': 'https://api.github.com/users/clokep/following{/other_user}', 'gists_url': 'https://api.github.com/users/clokep/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/clokep/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/clokep/subscriptions', 'organizations_url': 'https://api.github.com/users/clokep/orgs', 'repos_url': 'https://api.github.com/users/clokep/repos', 'events_url': 'https://api.github.com/users/clokep/events{/privacy}', 'received_events_url': 'https://api.github.com/users/clokep/received_events', 'type': 'User', 'site_admin': False}]",,4,2020-04-29T18:10:42Z,2020-05-06T20:43:53Z,2020-05-06T20:43:52Z,MEMBER,,,this is a regression introduced by #7120.,
919,https://api.github.com/repos/matrix-org/synapse/issues/7369,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7369/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7369/comments,https://api.github.com/repos/matrix-org/synapse/issues/7369/events,https://github.com/matrix-org/synapse/pull/7369,609194038,MDExOlB1bGxSZXF1ZXN0NDEwODIyMTUx,7369,Thread through instance name to replication client.,"{'login': 'erikjohnston', 'id': 8428120, 'node_id': 'MDQ6VXNlcjg0MjgxMjA=', 'avatar_url': 'https://avatars0.githubusercontent.com/u/8428120?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/erikjohnston', 'html_url': 'https://github.com/erikjohnston', 'followers_url': 'https://api.github.com/users/erikjohnston/followers', 'following_url': 'https://api.github.com/users/erikjohnston/following{/other_user}', 'gists_url': 'https://api.github.com/users/erikjohnston/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/erikjohnston/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/erikjohnston/subscriptions', 'organizations_url': 'https://api.github.com/users/erikjohnston/orgs', 'repos_url': 'https://api.github.com/users/erikjohnston/repos', 'events_url': 'https://api.github.com/users/erikjohnston/events{/privacy}', 'received_events_url': 'https://api.github.com/users/erikjohnston/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,0,2020-04-29T16:31:53Z,2020-05-01T16:19:58Z,2020-05-01T16:19:57Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7369', 'html_url': 'https://github.com/matrix-org/synapse/pull/7369', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7369.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7369.patch'}","For in memory streams when fetching updates on workers we need to query the source of the stream, which currently is hard coded to be master. This PR threads through the source instance we received via `POSITION` through to the update function in each stream, which can then be passed to the replication client for in memory streams.",
920,https://api.github.com/repos/matrix-org/synapse/issues/7368,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7368/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7368/comments,https://api.github.com/repos/matrix-org/synapse/issues/7368/events,https://github.com/matrix-org/synapse/pull/7368,609172363,MDExOlB1bGxSZXF1ZXN0NDEwODA0ODUx,7368,Further improvements to requesting the public rooms list on a homeserver which has it set to private,"{'login': 'anoadragon453', 'id': 1342360, 'node_id': 'MDQ6VXNlcjEzNDIzNjA=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1342360?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/anoadragon453', 'html_url': 'https://github.com/anoadragon453', 'followers_url': 'https://api.github.com/users/anoadragon453/followers', 'following_url': 'https://api.github.com/users/anoadragon453/following{/other_user}', 'gists_url': 'https://api.github.com/users/anoadragon453/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/anoadragon453/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/anoadragon453/subscriptions', 'organizations_url': 'https://api.github.com/users/anoadragon453/orgs', 'repos_url': 'https://api.github.com/users/anoadragon453/repos', 'events_url': 'https://api.github.com/users/anoadragon453/events{/privacy}', 'received_events_url': 'https://api.github.com/users/anoadragon453/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,"{'login': 'anoadragon453', 'id': 1342360, 'node_id': 'MDQ6VXNlcjEzNDIzNjA=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1342360?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/anoadragon453', 'html_url': 'https://github.com/anoadragon453', 'followers_url': 'https://api.github.com/users/anoadragon453/followers', 'following_url': 'https://api.github.com/users/anoadragon453/following{/other_user}', 'gists_url': 'https://api.github.com/users/anoadragon453/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/anoadragon453/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/anoadragon453/subscriptions', 'organizations_url': 'https://api.github.com/users/anoadragon453/orgs', 'repos_url': 'https://api.github.com/users/anoadragon453/repos', 'events_url': 'https://api.github.com/users/anoadragon453/events{/privacy}', 'received_events_url': 'https://api.github.com/users/anoadragon453/received_events', 'type': 'User', 'site_admin': False}","[{'login': 'anoadragon453', 'id': 1342360, 'node_id': 'MDQ6VXNlcjEzNDIzNjA=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1342360?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/anoadragon453', 'html_url': 'https://github.com/anoadragon453', 'followers_url': 'https://api.github.com/users/anoadragon453/followers', 'following_url': 'https://api.github.com/users/anoadragon453/following{/other_user}', 'gists_url': 'https://api.github.com/users/anoadragon453/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/anoadragon453/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/anoadragon453/subscriptions', 'organizations_url': 'https://api.github.com/users/anoadragon453/orgs', 'repos_url': 'https://api.github.com/users/anoadragon453/repos', 'events_url': 'https://api.github.com/users/anoadragon453/events{/privacy}', 'received_events_url': 'https://api.github.com/users/anoadragon453/received_events', 'type': 'User', 'site_admin': False}]",,0,2020-04-29T16:00:05Z,2020-05-01T14:15:10Z,2020-05-01T14:15:09Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7368', 'html_url': 'https://github.com/matrix-org/synapse/pull/7368', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7368.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7368.patch'}","Improves upon https://github.com/matrix-org/synapse/pull/6899
This PR:
* Adds nice docstrings
* Removes an unnecessary check
* Returns a more descriptive error when we request a private publicRooms list from a remote homeserver.
Why you ask? Well, I noticed the problem on my homeserver and went to fix it, and once done realized I had already fixed this in that other PR, and it still hasn't hit master. Still, the changes here should be useful.
Using the same changelog as the previous PR.",
921,https://api.github.com/repos/matrix-org/synapse/issues/7367,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7367/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7367/comments,https://api.github.com/repos/matrix-org/synapse/issues/7367/events,https://github.com/matrix-org/synapse/pull/7367,609126202,MDExOlB1bGxSZXF1ZXN0NDEwNzY3Nzc3,7367,Apply federation check for /publicRooms with filter list,"{'login': 'anoadragon453', 'id': 1342360, 'node_id': 'MDQ6VXNlcjEzNDIzNjA=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1342360?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/anoadragon453', 'html_url': 'https://github.com/anoadragon453', 'followers_url': 'https://api.github.com/users/anoadragon453/followers', 'following_url': 'https://api.github.com/users/anoadragon453/following{/other_user}', 'gists_url': 'https://api.github.com/users/anoadragon453/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/anoadragon453/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/anoadragon453/subscriptions', 'organizations_url': 'https://api.github.com/users/anoadragon453/orgs', 'repos_url': 'https://api.github.com/users/anoadragon453/repos', 'events_url': 'https://api.github.com/users/anoadragon453/events{/privacy}', 'received_events_url': 'https://api.github.com/users/anoadragon453/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,0,2020-04-29T14:58:49Z,2020-04-30T10:38:09Z,2020-04-30T10:38:08Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7367', 'html_url': 'https://github.com/matrix-org/synapse/pull/7367', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7367.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7367.patch'}","Fixes: https://github.com/matrix-org/synapse/issues/7366
The `from_federation` parameter determines whether to mutate the `/publicRooms` response based on whether the request is coming from another homeserver or a local client.
Currently this is only used for determining whether to show rooms that are set to not federate. This missing parameter meant that these rooms would be shown to other servers if they providing a filter with their `/publicRooms` query.
Missed in #4736: https://github.com/matrix-org/synapse/pull/4736/files#diff-a78cb67d0a36ffde4ccd3d5c78c25a13R85",
922,https://api.github.com/repos/matrix-org/synapse/issues/7366,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7366/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7366/comments,https://api.github.com/repos/matrix-org/synapse/issues/7366/events,https://github.com/matrix-org/synapse/issues/7366,609034698,MDU6SXNzdWU2MDkwMzQ2OTg=,7366,Searching in the public rooms list shows unfederatable rooms,"{'login': 'anoadragon453', 'id': 1342360, 'node_id': 'MDQ6VXNlcjEzNDIzNjA=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1342360?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/anoadragon453', 'html_url': 'https://github.com/anoadragon453', 'followers_url': 'https://api.github.com/users/anoadragon453/followers', 'following_url': 'https://api.github.com/users/anoadragon453/following{/other_user}', 'gists_url': 'https://api.github.com/users/anoadragon453/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/anoadragon453/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/anoadragon453/subscriptions', 'organizations_url': 'https://api.github.com/users/anoadragon453/orgs', 'repos_url': 'https://api.github.com/users/anoadragon453/repos', 'events_url': 'https://api.github.com/users/anoadragon453/events{/privacy}', 'received_events_url': 'https://api.github.com/users/anoadragon453/received_events', 'type': 'User', 'site_admin': False}","[{'id': 121086029, 'node_id': 'MDU6TGFiZWwxMjEwODYwMjk=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/bug', 'name': 'bug', 'color': 'fc2929', 'default': True, 'description': None}]",closed,False,"{'login': 'anoadragon453', 'id': 1342360, 'node_id': 'MDQ6VXNlcjEzNDIzNjA=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1342360?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/anoadragon453', 'html_url': 'https://github.com/anoadragon453', 'followers_url': 'https://api.github.com/users/anoadragon453/followers', 'following_url': 'https://api.github.com/users/anoadragon453/following{/other_user}', 'gists_url': 'https://api.github.com/users/anoadragon453/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/anoadragon453/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/anoadragon453/subscriptions', 'organizations_url': 'https://api.github.com/users/anoadragon453/orgs', 'repos_url': 'https://api.github.com/users/anoadragon453/repos', 'events_url': 'https://api.github.com/users/anoadragon453/events{/privacy}', 'received_events_url': 'https://api.github.com/users/anoadragon453/received_events', 'type': 'User', 'site_admin': False}","[{'login': 'anoadragon453', 'id': 1342360, 'node_id': 'MDQ6VXNlcjEzNDIzNjA=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1342360?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/anoadragon453', 'html_url': 'https://github.com/anoadragon453', 'followers_url': 'https://api.github.com/users/anoadragon453/followers', 'following_url': 'https://api.github.com/users/anoadragon453/following{/other_user}', 'gists_url': 'https://api.github.com/users/anoadragon453/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/anoadragon453/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/anoadragon453/subscriptions', 'organizations_url': 'https://api.github.com/users/anoadragon453/orgs', 'repos_url': 'https://api.github.com/users/anoadragon453/repos', 'events_url': 'https://api.github.com/users/anoadragon453/events{/privacy}', 'received_events_url': 'https://api.github.com/users/anoadragon453/received_events', 'type': 'User', 'site_admin': False}]",,1,2020-04-29T12:55:25Z,2020-05-01T14:16:25Z,2020-05-01T14:16:25Z,MEMBER,,,"Non-federated rooms are hidden in the public rooms list when other servers query them, as users on other servers won't be able to join them: https://github.com/matrix-org/synapse/pull/6153.
But it turns out that if you make a search it'll show those rooms anyways.",
923,https://api.github.com/repos/matrix-org/synapse/issues/7365,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7365/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7365/comments,https://api.github.com/repos/matrix-org/synapse/issues/7365/events,https://github.com/matrix-org/synapse/issues/7365,609019196,MDU6SXNzdWU2MDkwMTkxOTY=,7365,"psycopg2.errors.UniqueViolation: duplicate key value violates unique constraint ""e2e_one_time_keys_json_uniqueness""","{'login': 'anoadragon453', 'id': 1342360, 'node_id': 'MDQ6VXNlcjEzNDIzNjA=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1342360?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/anoadragon453', 'html_url': 'https://github.com/anoadragon453', 'followers_url': 'https://api.github.com/users/anoadragon453/followers', 'following_url': 'https://api.github.com/users/anoadragon453/following{/other_user}', 'gists_url': 'https://api.github.com/users/anoadragon453/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/anoadragon453/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/anoadragon453/subscriptions', 'organizations_url': 'https://api.github.com/users/anoadragon453/orgs', 'repos_url': 'https://api.github.com/users/anoadragon453/repos', 'events_url': 'https://api.github.com/users/anoadragon453/events{/privacy}', 'received_events_url': 'https://api.github.com/users/anoadragon453/received_events', 'type': 'User', 'site_admin': False}","[{'id': 121086029, 'node_id': 'MDU6TGFiZWwxMjEwODYwMjk=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/bug', 'name': 'bug', 'color': 'fc2929', 'default': True, 'description': None}, {'id': 477043173, 'node_id': 'MDU6TGFiZWw0NzcwNDMxNzM=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/p2', 'name': 'p2', 'color': 'fbca04', 'default': False, 'description': None}, {'id': 1920863622, 'node_id': 'MDU6TGFiZWwxOTIwODYzNjIy', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/validation', 'name': 'validation', 'color': 'f49d6e', 'default': False, 'description': 'lack of parameter validation'}]",open,False,,[],,1,2020-04-29T12:31:01Z,2020-05-11T13:18:28Z,,MEMBER,,,"Storage function `add_e2e_one_time_keys` claims that it raises an error when one tries to insert a key that already exists in the db. This makes a call to `/keys/upload` fail if one of the keys in the set is already known:
```
synapse.http.server - 110 - ERROR - POST-xxx - Failed handle request via 'KeyUploadServlet':
...
File ""/synapse/storage/data_stores/main/end_to_end_keys.py"", line 237, in _add_e2e_one_time_keys
for algorithm, key_id, json_bytes in new_keys
File ""/synapse/storage/database.py"", line 684, in simple_insert_many_txn
txn.executemany(sql, vals)
File ""/synapse/storage/database.py"", line 202, in executemany
self._do_execute(self.txn.executemany, sql, *args)
File ""/synapse/storage/database.py"", line 225, in _do_execute
return func(sql, *args)
psycopg2.errors.UniqueViolation: duplicate key value violates unique constraint ""e2e_one_time_keys_json_uniqueness""
DETAIL: Key (user_id, device_id, algorithm, key_id)=(@blabla:example.com, ATNXJDJWK, signed_curve25519, AAAANR) already exists.
```
Perhaps this in intentional, but presumably we'd want to just skip a key if we already have it and continue inserting the rest rather than 500 (well, ideally we wouldn't do that in any case).",
924,https://api.github.com/repos/matrix-org/synapse/issues/7364,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7364/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7364/comments,https://api.github.com/repos/matrix-org/synapse/issues/7364/events,https://github.com/matrix-org/synapse/pull/7364,608922475,MDExOlB1bGxSZXF1ZXN0NDEwNjA1NjU3,7364,Add instance name to RDATA/POSITION commands,"{'login': 'erikjohnston', 'id': 8428120, 'node_id': 'MDQ6VXNlcjg0MjgxMjA=', 'avatar_url': 'https://avatars0.githubusercontent.com/u/8428120?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/erikjohnston', 'html_url': 'https://github.com/erikjohnston', 'followers_url': 'https://api.github.com/users/erikjohnston/followers', 'following_url': 'https://api.github.com/users/erikjohnston/following{/other_user}', 'gists_url': 'https://api.github.com/users/erikjohnston/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/erikjohnston/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/erikjohnston/subscriptions', 'organizations_url': 'https://api.github.com/users/erikjohnston/orgs', 'repos_url': 'https://api.github.com/users/erikjohnston/repos', 'events_url': 'https://api.github.com/users/erikjohnston/events{/privacy}', 'received_events_url': 'https://api.github.com/users/erikjohnston/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,0,2020-04-29T09:50:50Z,2020-04-29T15:23:10Z,2020-04-29T15:23:09Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7364', 'html_url': 'https://github.com/matrix-org/synapse/pull/7364', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7364.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7364.patch'}","This is primarily for allowing us to send those commands from workers, but for now simply allows us to ignore echoed RDATA/POSITION commands that we sent (we get echoes of sent commands when using redis). Currently we log a WARNING on the master process every time we receive an echoed RDATA.
The fix to the `test.replication.slave` tests are a bit gut wrenching. I need to port the fix from `tests.replication.tcp` to actually create two separate HS instances.",
925,https://api.github.com/repos/matrix-org/synapse/issues/7363,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7363/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7363/comments,https://api.github.com/repos/matrix-org/synapse/issues/7363/events,https://github.com/matrix-org/synapse/pull/7363,608591302,MDExOlB1bGxSZXF1ZXN0NDEwMzQxNDM5,7363,async/await is_server_admin,"{'login': 'anoadragon453', 'id': 1342360, 'node_id': 'MDQ6VXNlcjEzNDIzNjA=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1342360?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/anoadragon453', 'html_url': 'https://github.com/anoadragon453', 'followers_url': 'https://api.github.com/users/anoadragon453/followers', 'following_url': 'https://api.github.com/users/anoadragon453/following{/other_user}', 'gists_url': 'https://api.github.com/users/anoadragon453/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/anoadragon453/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/anoadragon453/subscriptions', 'organizations_url': 'https://api.github.com/users/anoadragon453/orgs', 'repos_url': 'https://api.github.com/users/anoadragon453/repos', 'events_url': 'https://api.github.com/users/anoadragon453/events{/privacy}', 'received_events_url': 'https://api.github.com/users/anoadragon453/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,"{'login': 'clokep', 'id': 517124, 'node_id': 'MDQ6VXNlcjUxNzEyNA==', 'avatar_url': 'https://avatars2.githubusercontent.com/u/517124?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/clokep', 'html_url': 'https://github.com/clokep', 'followers_url': 'https://api.github.com/users/clokep/followers', 'following_url': 'https://api.github.com/users/clokep/following{/other_user}', 'gists_url': 'https://api.github.com/users/clokep/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/clokep/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/clokep/subscriptions', 'organizations_url': 'https://api.github.com/users/clokep/orgs', 'repos_url': 'https://api.github.com/users/clokep/repos', 'events_url': 'https://api.github.com/users/clokep/events{/privacy}', 'received_events_url': 'https://api.github.com/users/clokep/received_events', 'type': 'User', 'site_admin': False}","[{'login': 'clokep', 'id': 517124, 'node_id': 'MDQ6VXNlcjUxNzEyNA==', 'avatar_url': 'https://avatars2.githubusercontent.com/u/517124?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/clokep', 'html_url': 'https://github.com/clokep', 'followers_url': 'https://api.github.com/users/clokep/followers', 'following_url': 'https://api.github.com/users/clokep/following{/other_user}', 'gists_url': 'https://api.github.com/users/clokep/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/clokep/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/clokep/subscriptions', 'organizations_url': 'https://api.github.com/users/clokep/orgs', 'repos_url': 'https://api.github.com/users/clokep/repos', 'events_url': 'https://api.github.com/users/clokep/events{/privacy}', 'received_events_url': 'https://api.github.com/users/clokep/received_events', 'type': 'User', 'site_admin': False}]",,0,2020-04-28T20:23:20Z,2020-05-01T14:15:38Z,2020-05-01T14:15:37Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7363', 'html_url': 'https://github.com/matrix-org/synapse/pull/7363', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7363.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7363.patch'}","Fixes: https://github.com/matrix-org/synapse/issues/6838
Supersedes: https://github.com/matrix-org/synapse/pull/6839
The intention for this PR is to have each commit convert a function that calls `is_server_admin` to async/await, with all or most of the functions that call that converted as well.",
926,https://api.github.com/repos/matrix-org/synapse/issues/7362,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7362/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7362/comments,https://api.github.com/repos/matrix-org/synapse/issues/7362/events,https://github.com/matrix-org/synapse/issues/7362,608574743,MDU6SXNzdWU2MDg1NzQ3NDM=,7362,Expose Power Level Defaults,"{'login': 'TheDiscordian', 'id': 43145244, 'node_id': 'MDQ6VXNlcjQzMTQ1MjQ0', 'avatar_url': 'https://avatars3.githubusercontent.com/u/43145244?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/TheDiscordian', 'html_url': 'https://github.com/TheDiscordian', 'followers_url': 'https://api.github.com/users/TheDiscordian/followers', 'following_url': 'https://api.github.com/users/TheDiscordian/following{/other_user}', 'gists_url': 'https://api.github.com/users/TheDiscordian/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/TheDiscordian/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/TheDiscordian/subscriptions', 'organizations_url': 'https://api.github.com/users/TheDiscordian/orgs', 'repos_url': 'https://api.github.com/users/TheDiscordian/repos', 'events_url': 'https://api.github.com/users/TheDiscordian/events{/privacy}', 'received_events_url': 'https://api.github.com/users/TheDiscordian/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,3,2020-04-28T19:56:23Z,2020-04-30T08:39:23Z,2020-04-29T10:21:46Z,NONE,,,"As described in #5131 (tbh not really sure why that issue can't be used, the history for that issue will be relevant here...) it's very easy for a new user or an experienced user to make a mistake an promote someone else to admin along-side them. If this was done in error, it cannot be corrected without the new admin's cooperation.
There seems to be some debate over the usefulness of having owners default to a higher power level than admins (100 for owners, 90 for admins), which quite frankly I find silly/absurd. Just about every other service offers this distinction, and it's quite jarring and very easy to make a mistake on Matrix with the current defaults, but I digress.
The compromise to solve the problems highlighted above is to expose the default power levels for the roles Moderator, Administrator, and Room Creator inside of `homeserver.yaml`. A server owner could then change the default admin power level to 90. This would allow someone to create a room at power level 100, and reasonably expect to not put themselves in the position highlighted above (can't remove admin) unless they specify ""custom"" and type in 100. This is because when they select the Administrator option while promoting, the user's new power level would be just 90, below the owner's, instead of 100.
I thought this would be mostly a UI thing, and less a Synapse thing, but I clearly don't understand everything that's happening here. I'd be happy to help though.",
927,https://api.github.com/repos/matrix-org/synapse/issues/7361,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7361/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7361/comments,https://api.github.com/repos/matrix-org/synapse/issues/7361/events,https://github.com/matrix-org/synapse/pull/7361,608479540,MDExOlB1bGxSZXF1ZXN0NDEwMjUwNTc5,7361,Clean up admin api docs,"{'login': 'anoadragon453', 'id': 1342360, 'node_id': 'MDQ6VXNlcjEzNDIzNjA=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1342360?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/anoadragon453', 'html_url': 'https://github.com/anoadragon453', 'followers_url': 'https://api.github.com/users/anoadragon453/followers', 'following_url': 'https://api.github.com/users/anoadragon453/following{/other_user}', 'gists_url': 'https://api.github.com/users/anoadragon453/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/anoadragon453/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/anoadragon453/subscriptions', 'organizations_url': 'https://api.github.com/users/anoadragon453/orgs', 'repos_url': 'https://api.github.com/users/anoadragon453/repos', 'events_url': 'https://api.github.com/users/anoadragon453/events{/privacy}', 'received_events_url': 'https://api.github.com/users/anoadragon453/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,0,2020-04-28T17:12:52Z,2020-04-28T19:06:05Z,2020-04-28T19:06:04Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7361', 'html_url': 'https://github.com/matrix-org/synapse/pull/7361', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7361.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7361.patch'}",Hopefully makes the docs a bit easier for sysadmins to understand.,
928,https://api.github.com/repos/matrix-org/synapse/issues/7360,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7360/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7360/comments,https://api.github.com/repos/matrix-org/synapse/issues/7360/events,https://github.com/matrix-org/synapse/issues/7360,608271920,MDU6SXNzdWU2MDgyNzE5MjA=,7360,it's possible for stream_ids to go backwards in a replication stream,"{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}","[{'id': 121086029, 'node_id': 'MDU6TGFiZWwxMjEwODYwMjk=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/bug', 'name': 'bug', 'color': 'fc2929', 'default': True, 'description': None}, {'id': 2011569249, 'node_id': 'MDU6TGFiZWwyMDExNTY5MjQ5', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/operation%20gemini', 'name': 'operation gemini', 'color': '006b75', 'default': False, 'description': 'Part of the project to fix the cpu bottleneck on'}, {'id': 477043173, 'node_id': 'MDU6TGFiZWw0NzcwNDMxNzM=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/p2', 'name': 'p2', 'color': 'fbca04', 'default': False, 'description': None}]",closed,False,"{'login': 'clokep', 'id': 517124, 'node_id': 'MDQ6VXNlcjUxNzEyNA==', 'avatar_url': 'https://avatars2.githubusercontent.com/u/517124?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/clokep', 'html_url': 'https://github.com/clokep', 'followers_url': 'https://api.github.com/users/clokep/followers', 'following_url': 'https://api.github.com/users/clokep/following{/other_user}', 'gists_url': 'https://api.github.com/users/clokep/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/clokep/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/clokep/subscriptions', 'organizations_url': 'https://api.github.com/users/clokep/orgs', 'repos_url': 'https://api.github.com/users/clokep/repos', 'events_url': 'https://api.github.com/users/clokep/events{/privacy}', 'received_events_url': 'https://api.github.com/users/clokep/received_events', 'type': 'User', 'site_admin': False}","[{'login': 'clokep', 'id': 517124, 'node_id': 'MDQ6VXNlcjUxNzEyNA==', 'avatar_url': 'https://avatars2.githubusercontent.com/u/517124?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/clokep', 'html_url': 'https://github.com/clokep', 'followers_url': 'https://api.github.com/users/clokep/followers', 'following_url': 'https://api.github.com/users/clokep/following{/other_user}', 'gists_url': 'https://api.github.com/users/clokep/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/clokep/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/clokep/subscriptions', 'organizations_url': 'https://api.github.com/users/clokep/orgs', 'repos_url': 'https://api.github.com/users/clokep/repos', 'events_url': 'https://api.github.com/users/clokep/events{/privacy}', 'received_events_url': 'https://api.github.com/users/clokep/received_events', 'type': 'User', 'site_admin': False}]",,8,2020-04-28T12:18:43Z,2020-06-15T12:44:55Z,2020-06-15T12:44:55Z,MEMBER,,,"It's possible to receive an `RDATA 1` *after* a `POSITION 2` - which is to say that the stream id goes backwards. It's not obvious that the replication clients always handle this correctly, and is probably a thing we should make sure doesn't happen.",
929,https://api.github.com/repos/matrix-org/synapse/issues/7359,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7359/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7359/comments,https://api.github.com/repos/matrix-org/synapse/issues/7359/events,https://github.com/matrix-org/synapse/pull/7359,607869785,MDExOlB1bGxSZXF1ZXN0NDA5NzYwNzA5,7359,Fix collation for postgres for unit tests,"{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,0,2020-04-27T21:35:42Z,2020-04-28T13:21:50Z,2020-04-28T13:21:49Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7359', 'html_url': 'https://github.com/matrix-org/synapse/pull/7359', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7359.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7359.patch'}","When running the UTs against a postgres database, we need to set the collation
correctly.",
930,https://api.github.com/repos/matrix-org/synapse/issues/7358,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7358/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7358/comments,https://api.github.com/repos/matrix-org/synapse/issues/7358/events,https://github.com/matrix-org/synapse/pull/7358,607857777,MDExOlB1bGxSZXF1ZXN0NDA5NzUwODE0,7358,Fix limit logic for EventsStream,"{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,2,2020-04-27T21:14:18Z,2020-04-29T11:30:38Z,2020-04-29T11:30:37Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7358', 'html_url': 'https://github.com/matrix-org/synapse/pull/7358', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7358.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7358.patch'}","As with #7337, this is partly about fixing an assertion which was added recently, but I'm also fixing a much longer-standing bug in the replication catchup logic.
Also adds some tests. The first couple of commits are just some rejigging of the test framework: it might be helpful to review them separately.",
931,https://api.github.com/repos/matrix-org/synapse/issues/7357,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7357/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7357/comments,https://api.github.com/repos/matrix-org/synapse/issues/7357/events,https://github.com/matrix-org/synapse/pull/7357,607723782,MDExOlB1bGxSZXF1ZXN0NDA5NjQxNjM5,7357,Document monitoring workers,"{'login': 'babolivier', 'id': 5547783, 'node_id': 'MDQ6VXNlcjU1NDc3ODM=', 'avatar_url': 'https://avatars3.githubusercontent.com/u/5547783?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/babolivier', 'html_url': 'https://github.com/babolivier', 'followers_url': 'https://api.github.com/users/babolivier/followers', 'following_url': 'https://api.github.com/users/babolivier/following{/other_user}', 'gists_url': 'https://api.github.com/users/babolivier/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/babolivier/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/babolivier/subscriptions', 'organizations_url': 'https://api.github.com/users/babolivier/orgs', 'repos_url': 'https://api.github.com/users/babolivier/repos', 'events_url': 'https://api.github.com/users/babolivier/events{/privacy}', 'received_events_url': 'https://api.github.com/users/babolivier/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,"{'login': 'babolivier', 'id': 5547783, 'node_id': 'MDQ6VXNlcjU1NDc3ODM=', 'avatar_url': 'https://avatars3.githubusercontent.com/u/5547783?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/babolivier', 'html_url': 'https://github.com/babolivier', 'followers_url': 'https://api.github.com/users/babolivier/followers', 'following_url': 'https://api.github.com/users/babolivier/following{/other_user}', 'gists_url': 'https://api.github.com/users/babolivier/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/babolivier/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/babolivier/subscriptions', 'organizations_url': 'https://api.github.com/users/babolivier/orgs', 'repos_url': 'https://api.github.com/users/babolivier/repos', 'events_url': 'https://api.github.com/users/babolivier/events{/privacy}', 'received_events_url': 'https://api.github.com/users/babolivier/received_events', 'type': 'User', 'site_admin': False}","[{'login': 'babolivier', 'id': 5547783, 'node_id': 'MDQ6VXNlcjU1NDc3ODM=', 'avatar_url': 'https://avatars3.githubusercontent.com/u/5547783?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/babolivier', 'html_url': 'https://github.com/babolivier', 'followers_url': 'https://api.github.com/users/babolivier/followers', 'following_url': 'https://api.github.com/users/babolivier/following{/other_user}', 'gists_url': 'https://api.github.com/users/babolivier/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/babolivier/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/babolivier/subscriptions', 'organizations_url': 'https://api.github.com/users/babolivier/orgs', 'repos_url': 'https://api.github.com/users/babolivier/repos', 'events_url': 'https://api.github.com/users/babolivier/events{/privacy}', 'received_events_url': 'https://api.github.com/users/babolivier/received_events', 'type': 'User', 'site_admin': False}]",,0,2020-04-27T17:31:34Z,2020-04-27T19:36:49Z,2020-04-27T19:36:48Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7357', 'html_url': 'https://github.com/matrix-org/synapse/pull/7357', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7357.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7357.patch'}","It doesn't seem to be documented anywhere and means that you suddenly start losing metrics without any obvious reason when you go from monolith to workers (e.g. #7312).
",
932,https://api.github.com/repos/matrix-org/synapse/issues/7356,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7356/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7356/comments,https://api.github.com/repos/matrix-org/synapse/issues/7356/events,https://github.com/matrix-org/synapse/pull/7356,607710040,MDExOlB1bGxSZXF1ZXN0NDA5NjMwNTA2,7356,Validate that integers are in the proper range while decoding JSON.,"{'login': 'clokep', 'id': 517124, 'node_id': 'MDQ6VXNlcjUxNzEyNA==', 'avatar_url': 'https://avatars2.githubusercontent.com/u/517124?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/clokep', 'html_url': 'https://github.com/clokep', 'followers_url': 'https://api.github.com/users/clokep/followers', 'following_url': 'https://api.github.com/users/clokep/following{/other_user}', 'gists_url': 'https://api.github.com/users/clokep/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/clokep/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/clokep/subscriptions', 'organizations_url': 'https://api.github.com/users/clokep/orgs', 'repos_url': 'https://api.github.com/users/clokep/repos', 'events_url': 'https://api.github.com/users/clokep/events{/privacy}', 'received_events_url': 'https://api.github.com/users/clokep/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,5,2020-04-27T17:09:07Z,2020-05-14T16:42:07Z,2020-04-29T12:32:47Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7356', 'html_url': 'https://github.com/matrix-org/synapse/pull/7356', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7356.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7356.patch'}","Per [the Matrix specification](https://matrix.org/docs/spec/appendices#canonical-json), canonical JSON needs to limit integers in JSON to the range of [-2 ^ 53 + 1, 2 ^ 53 + 1] to match [RFC 7159](https://tools.ietf.org/html/rfc7159).
This PR enforces this restriction in Synapse for all ""incoming"" JSON data that is deserialized by Synapse, including:
* The client-server API.
* The server-server API.
* The identity server API.
* The push gateway API.
This is mostly done via modifying the core areas that parse JSON from HTTP queries and HTTP responses.
This does **NOT** make any changes to:
* The replication API (which uses JSON internally within Synapse workers).
* Data that is sent via Synapse.
* Loading of JSON data from the database.
My hope is that this will mean nothing in Synapse will break if a database already has bad data in it.
Note that I do not believe this is really part of the ""canonicaljson"" package since the APIs should not be using these invalid values anyway. After this change, anytime we generate a canonicaljson value it should be *after* the JSON has been validated, so it should already abide by these rules.",
933,https://api.github.com/repos/matrix-org/synapse/issues/7355,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7355/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7355/comments,https://api.github.com/repos/matrix-org/synapse/issues/7355/events,https://github.com/matrix-org/synapse/issues/7355,607571020,MDU6SXNzdWU2MDc1NzEwMjA=,7355,Stuck invite - Tell Matthew to fix Matrix,"{'login': 'SWW13', 'id': 1280142, 'node_id': 'MDQ6VXNlcjEyODAxNDI=', 'avatar_url': 'https://avatars0.githubusercontent.com/u/1280142?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/SWW13', 'html_url': 'https://github.com/SWW13', 'followers_url': 'https://api.github.com/users/SWW13/followers', 'following_url': 'https://api.github.com/users/SWW13/following{/other_user}', 'gists_url': 'https://api.github.com/users/SWW13/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/SWW13/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/SWW13/subscriptions', 'organizations_url': 'https://api.github.com/users/SWW13/orgs', 'repos_url': 'https://api.github.com/users/SWW13/repos', 'events_url': 'https://api.github.com/users/SWW13/events{/privacy}', 'received_events_url': 'https://api.github.com/users/SWW13/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,2,2020-04-27T13:55:05Z,2020-04-27T14:27:33Z,2020-04-27T14:20:10Z,NONE,,,"### Description
After receiving a broken invite and rejecting it, the invite persists in the riot webclient.
Only whiping the cache solves the issue, which isn't a great workflow for rejecting an invite.
### Steps to reproduce
- Wait for broken invite
- Understand the hate someone else has with matrix after having the same problem
- Open issue here
I'm expecting a chat software that works, or at least have a decent why to fix itself.
Something like ""clear cache"" would be nice if the software itself is broken on a regular basis.
Here is btw the debug console log:
```
Switching to room id !HfiOiEJJbHoCPJEnCP:bau-ha.us at event undefined
RVS update: !HfiOiEJJbHoCPJEnCP:bau-ha.us undefined loading? false joining? false initial? true shouldPeek? true
Returning cached capabilities
Starting watcher for hideReadReceipts@ as ID 1587994746578_20_hideReadReceipts_null
Ending watcher ID 1587994743544_17_hideReadReceipts_null
Ending watcher ID 1587994743605_19_showTypingNotifications_null
Ending watcher ID 1587994743566_18_MessageComposerInput.autoReplaceEmoji_null
newscreen room/!HfiOiEJJbHoCPJEnCP:bau-ha.us
Room undefined does not have an m.room.create event
[!HfiOiEJJbHoCPJEnCP:bau-ha.us] Current version: 1
[!HfiOiEJJbHoCPJEnCP:bau-ha.us] Version capability:
Object { default: ""5"", available: {…} }
!! Room !HfiOiEJJbHoCPJEnCP:bau-ha.us nearly lost: Ran off the end of im.vector.fake.invite
!! Inserting at position 0 with category idle
Switching to room id !OTXoQxlEOLgpfSENoS:bau-ha.us at event undefined
RVS update: !OTXoQxlEOLgpfSENoS:bau-ha.us undefined loading? false joining? false initial? true shouldPeek? true
Returning cached capabilities
Starting watcher for hideReadReceipts@ as ID 1587994749500_21_hideReadReceipts_null
Ending watcher ID 1587994746578_20_hideReadReceipts_null
newscreen room/!OTXoQxlEOLgpfSENoS:bau-ha.us
Room undefined does not have an m.room.create event
[!OTXoQxlEOLgpfSENoS:bau-ha.us] Current version: 1
[!OTXoQxlEOLgpfSENoS:bau-ha.us] Version capability:
Object { default: ""5"", available: {…} }
```
### Version information
- **Homeserver**:
matrix.brn.li
- **Version**:
```
{
""python_version"": ""3.8.2"",
""server_version"": ""1.11.0""
}
```
- **Install method**:
Arch Linux community repo.
- **Platform**:
Arch Linux
",
934,https://api.github.com/repos/matrix-org/synapse/issues/7354,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7354/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7354/comments,https://api.github.com/repos/matrix-org/synapse/issues/7354/events,https://github.com/matrix-org/synapse/issues/7354,607489628,MDU6SXNzdWU2MDc0ODk2Mjg=,7354,Can't configure 3pid requirement for registration.,"{'login': 'ivoryblade', 'id': 15197985, 'node_id': 'MDQ6VXNlcjE1MTk3OTg1', 'avatar_url': 'https://avatars3.githubusercontent.com/u/15197985?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/ivoryblade', 'html_url': 'https://github.com/ivoryblade', 'followers_url': 'https://api.github.com/users/ivoryblade/followers', 'following_url': 'https://api.github.com/users/ivoryblade/following{/other_user}', 'gists_url': 'https://api.github.com/users/ivoryblade/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/ivoryblade/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/ivoryblade/subscriptions', 'organizations_url': 'https://api.github.com/users/ivoryblade/orgs', 'repos_url': 'https://api.github.com/users/ivoryblade/repos', 'events_url': 'https://api.github.com/users/ivoryblade/events{/privacy}', 'received_events_url': 'https://api.github.com/users/ivoryblade/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,2,2020-04-27T12:00:08Z,2020-04-29T08:09:09Z,2020-04-27T15:01:42Z,NONE,,,"Hello! I'm deploying my first synapse homeserver and I'm stuck with email configuration. I've configured smtp settings and template dir (I've downloaded res/templates directory and placed in /var/lib/matrix-synapse). But when I activate
`registrations_require_3pid:
- email`
I got error in logs
`synapse.config._base.ConfigError: Configuration requires email address at registration, but email validation is not configured`
What am I missing in my config? I've tried to enable account validation but got same error....
Synapse version is 1.12.3+bionic1.
My config in attachment.
[homeserver-2.txt](https://github.com/matrix-org/synapse/files/4539423/homeserver-2.txt)
",
935,https://api.github.com/repos/matrix-org/synapse/issues/7353,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7353/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7353/comments,https://api.github.com/repos/matrix-org/synapse/issues/7353/events,https://github.com/matrix-org/synapse/issues/7353,607487641,MDU6SXNzdWU2MDc0ODc2NDE=,7353,synapse doesn't start with openssl-1.1.1,"{'login': 'ctsde-markus', 'id': 3747528, 'node_id': 'MDQ6VXNlcjM3NDc1Mjg=', 'avatar_url': 'https://avatars3.githubusercontent.com/u/3747528?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/ctsde-markus', 'html_url': 'https://github.com/ctsde-markus', 'followers_url': 'https://api.github.com/users/ctsde-markus/followers', 'following_url': 'https://api.github.com/users/ctsde-markus/following{/other_user}', 'gists_url': 'https://api.github.com/users/ctsde-markus/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/ctsde-markus/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/ctsde-markus/subscriptions', 'organizations_url': 'https://api.github.com/users/ctsde-markus/orgs', 'repos_url': 'https://api.github.com/users/ctsde-markus/repos', 'events_url': 'https://api.github.com/users/ctsde-markus/events{/privacy}', 'received_events_url': 'https://api.github.com/users/ctsde-markus/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,5,2020-04-27T11:57:00Z,2020-04-29T16:30:11Z,2020-04-27T15:58:36Z,NONE,,,"### Description
synapse doesn't start with openssl-1.1.1 library (Undefined symbol ""OPENSSL_no_config"")
### Steps to reproduce
- Install FreeBSD 11.3
- set ```DEFAULT_VERSIONS+= ssl=openssl``` in ```/etc/make.conf```
- install packages
- bash
- bash-completion
- vim-console (optional)
- screen (optional)
- openssl
- ca_root_nss
- freetype2
- giflib
- jbigkit
- jpeg-turbo
- libltdl
- libsodium
- nginx
- nspr
- nss
- png
- postgresql96-server
- postgresql96-contrib
- python36
- py36-virtualenv
- py36-psycopg2
- tiff
- turnserver
- webp
- xmlsec1
run the following commands as root to install synapse:
```
pw groupadd synapse
pw useradd synapse -m -g synapse
sh
virtualenv-36 -p python3.6 /home/synapse/env
. /home/synapse/env/bin/activate
# prompt shows (env)
pip install --upgrade pip
pip install --upgrade setuptools
pip install matrix-synapse[all]
exit
```
Setup the installation by creating a reasonable homeserver.yaml and try to start synapse with:
```
/usr/home/synapse/env/bin/python3.6 -m synapse.app.homeserver --daemonize -c /path/to/homeserver.yaml
```
I then get:
```
Starting synapse.
Traceback (most recent call last):
File ""/usr/local/lib/python3.6/runpy.py"", line 193, in _run_module_as_main
""__main__"", mod_spec)
File ""/usr/local/lib/python3.6/runpy.py"", line 85, in _run_code
exec(code, run_globals)
File ""/usr/home/synapse/env/lib/python3.6/site-packages/synapse/app/homeserver.py"", line 39, in
import synapse.config.logger
File ""/usr/home/synapse/env/lib/python3.6/site-packages/synapse/config/logger.py"", line 32, in
from synapse.app import _base as appbase
File ""/usr/home/synapse/env/lib/python3.6/site-packages/synapse/app/_base.py"", line 27, in
from twisted.protocols.tls import TLSMemoryBIOFactory
File ""/usr/home/synapse/env/lib/python3.6/site-packages/twisted/protocols/tls.py"", line 41, in
from OpenSSL.SSL import Error, ZeroReturnError, WantReadError
File ""/usr/home/synapse/env/lib/python3.6/site-packages/OpenSSL/__init__.py"", line 8, in
from OpenSSL import crypto, SSL
File ""/usr/home/synapse/env/lib/python3.6/site-packages/OpenSSL/crypto.py"", line 16, in
from OpenSSL._util import (
File ""/usr/home/synapse/env/lib/python3.6/site-packages/OpenSSL/_util.py"", line 6, in
from cryptography.hazmat.bindings.openssl.binding import Binding
File ""/usr/home/synapse/env/lib/python3.6/site-packages/cryptography/hazmat/bindings/openssl/binding.py"", line 16, in
from cryptography.hazmat.bindings._openssl import ffi, lib
ImportError: /usr/home/synapse/env/lib/python3.6/site-packages/cryptography/hazmat/bindings/_openssl.abi3.so: Undefined symbol ""OPENSSL_no_config""
```
### Version information
- **Homeserver**: my own homeserver
If not matrix.org: 1.12.4 (but also happend in 1.11.x) crucial for my problem was the upgrade of openssl library to 1.1.1 where ""OPENSSL_no_config"" was removed but synapse still tries to use it(?)
- **Version**: 1.12.4 (but also in 1.11.x)
- **Install method**: pip
- **Platform**: FreeBSD 11.3
",
936,https://api.github.com/repos/matrix-org/synapse/issues/7352,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7352/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7352/comments,https://api.github.com/repos/matrix-org/synapse/issues/7352/events,https://github.com/matrix-org/synapse/pull/7352,607460865,MDExOlB1bGxSZXF1ZXN0NDA5NDMxMTEz,7352,Don't relay REMOTE_SERVER_UP cmds to same conn.,"{'login': 'erikjohnston', 'id': 8428120, 'node_id': 'MDQ6VXNlcjg0MjgxMjA=', 'avatar_url': 'https://avatars0.githubusercontent.com/u/8428120?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/erikjohnston', 'html_url': 'https://github.com/erikjohnston', 'followers_url': 'https://api.github.com/users/erikjohnston/followers', 'following_url': 'https://api.github.com/users/erikjohnston/following{/other_user}', 'gists_url': 'https://api.github.com/users/erikjohnston/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/erikjohnston/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/erikjohnston/subscriptions', 'organizations_url': 'https://api.github.com/users/erikjohnston/orgs', 'repos_url': 'https://api.github.com/users/erikjohnston/repos', 'events_url': 'https://api.github.com/users/erikjohnston/events{/privacy}', 'received_events_url': 'https://api.github.com/users/erikjohnston/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,0,2020-04-27T11:15:28Z,2020-04-29T13:11:01Z,2020-04-29T13:11:00Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7352', 'html_url': 'https://github.com/matrix-org/synapse/pull/7352', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7352.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7352.patch'}","For direct TCP connections we need the master to relay REMOTE_SERVER_UP
commands to the other connections so that all instances get notified
about it. The old implementation just relayed to all connections,
assuming that sending back to the original sender of the command was
safe. This is not true for redis, where commands sent get echoed back to
the sender, which was causing master to effectively infinite loop
sending and then re-receiving REMOTE_SERVER_UP commands that it sent.
The fix is to ensure that we only relay to *other* connections and not
to the connection we received the notification from.
Fixes #7334.
(~~This needs tests, which I'll look at after lunch, but wanted to get this out for review since it makes redis unusable on develop~~ Helps if I actually hit the review request button)",
937,https://api.github.com/repos/matrix-org/synapse/issues/7351,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7351/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7351/comments,https://api.github.com/repos/matrix-org/synapse/issues/7351/events,https://github.com/matrix-org/synapse/issues/7351,607377266,MDU6SXNzdWU2MDczNzcyNjY=,7351,Increase in calls to `get_user_by_id` and other strange metrics,"{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}","[{'id': 2011569249, 'node_id': 'MDU6TGFiZWwyMDExNTY5MjQ5', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/operation%20gemini', 'name': 'operation gemini', 'color': '006b75', 'default': False, 'description': 'Part of the project to fix the cpu bottleneck on'}]",closed,False,"{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}","[{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}]",,7,2020-04-27T09:14:22Z,2020-04-29T20:25:22Z,2020-04-29T20:25:22Z,MEMBER,,,"We switched matrix.org to current `develop` for a couple of hours on 2020-04-24, and saw some surprising changes to the metrics, including a large number of calls to the `get_user_by_id` database transaction.
Some of these could be due to more accurate metrics reporting due to #7203, but there were other changes which merit investigation.",
938,https://api.github.com/repos/matrix-org/synapse/issues/7350,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7350/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7350/comments,https://api.github.com/repos/matrix-org/synapse/issues/7350/events,https://github.com/matrix-org/synapse/issues/7350,607345663,MDU6SXNzdWU2MDczNDU2NjM=,7350,self-signing keys are not returned from CS-API for user on different HS,"{'login': 'bwindels', 'id': 274386, 'node_id': 'MDQ6VXNlcjI3NDM4Ng==', 'avatar_url': 'https://avatars1.githubusercontent.com/u/274386?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bwindels', 'html_url': 'https://github.com/bwindels', 'followers_url': 'https://api.github.com/users/bwindels/followers', 'following_url': 'https://api.github.com/users/bwindels/following{/other_user}', 'gists_url': 'https://api.github.com/users/bwindels/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/bwindels/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/bwindels/subscriptions', 'organizations_url': 'https://api.github.com/users/bwindels/orgs', 'repos_url': 'https://api.github.com/users/bwindels/repos', 'events_url': 'https://api.github.com/users/bwindels/events{/privacy}', 'received_events_url': 'https://api.github.com/users/bwindels/received_events', 'type': 'User', 'site_admin': False}","[{'id': 121086029, 'node_id': 'MDU6TGFiZWwxMjEwODYwMjk=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/bug', 'name': 'bug', 'color': 'fc2929', 'default': True, 'description': None}, {'id': 1311133228, 'node_id': 'MDU6TGFiZWwxMzExMTMzMjI4', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/info-needed', 'name': 'info-needed', 'color': 'a1e8ea', 'default': False, 'description': ''}, {'id': 477045093, 'node_id': 'MDU6TGFiZWw0NzcwNDUwOTM=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/p1', 'name': 'p1', 'color': 'd93f0b', 'default': False, 'description': None}]",closed,False,,[],,14,2020-04-27T08:30:25Z,2020-05-13T20:18:10Z,2020-05-06T09:50:48Z,MEMBER,,,"@lampholder is not seeing self-signing keys when calling `/keys/query` on his homeserver for neilj who's on matrix.org. This seems to happen only for this user (neilj), but is 100% reproducable. The master key is the correct one, with `""self_signing_keys"": {}` at the end. Tom says he's running `1.12.3`, I've asked him to repro on `1.12.4`, but already wanted to report here as 1.12.4 apparently only contained fixes for workerized instances, which is not the case for Tom.
Exact output returned from the CS-API can be found at https://github.com/matrix-org/riot-web-rageshakes/issues/2658
This causes breakage in Riot as even after verifying somebody, they still appear with a red shield, as trust chain to their devices is incomplete.",
939,https://api.github.com/repos/matrix-org/synapse/issues/7349,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7349/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7349/comments,https://api.github.com/repos/matrix-org/synapse/issues/7349/events,https://github.com/matrix-org/synapse/issues/7349,607005890,MDU6SXNzdWU2MDcwMDU4OTA=,7349,Can't log in (initial sync fails HTTP 500),"{'login': 'HarHarLinks', 'id': 2803622, 'node_id': 'MDQ6VXNlcjI4MDM2MjI=', 'avatar_url': 'https://avatars0.githubusercontent.com/u/2803622?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/HarHarLinks', 'html_url': 'https://github.com/HarHarLinks', 'followers_url': 'https://api.github.com/users/HarHarLinks/followers', 'following_url': 'https://api.github.com/users/HarHarLinks/following{/other_user}', 'gists_url': 'https://api.github.com/users/HarHarLinks/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/HarHarLinks/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/HarHarLinks/subscriptions', 'organizations_url': 'https://api.github.com/users/HarHarLinks/orgs', 'repos_url': 'https://api.github.com/users/HarHarLinks/repos', 'events_url': 'https://api.github.com/users/HarHarLinks/events{/privacy}', 'received_events_url': 'https://api.github.com/users/HarHarLinks/received_events', 'type': 'User', 'site_admin': False}","[{'id': 121086029, 'node_id': 'MDU6TGFiZWwxMjEwODYwMjk=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/bug', 'name': 'bug', 'color': 'fc2929', 'default': True, 'description': None}]",closed,False,,[],,7,2020-04-26T12:55:03Z,2020-04-28T13:02:36Z,2020-04-28T13:00:08Z,CONTRIBUTOR,,,"### Description
A user of my homeserver has this issue:
after logging in from a new device, riot-desktop and riot-web are ""Unable to connect to Homeserver. Retrying..."" , and if cancelled ""Unexpected error resolving homeserver configuration"".
From my understanding, the initial sync of this user may contain malformed json, which leads to the initial sync failing. The user can still access the account from another device that have been logged in for a long time.
### Steps to reproduce
- have some existing chat history, incl encrypted and redacted
- log in from new device
Specifically, synapse runs behind an nginx reverse proxy.
Error as seen from nginx:
```
""GET /_matrix/client/r0/sync?filter=12&timeout=0&_cacheBuster=1587900538750 HTTP/1.1"" 500 78 ""-"" ""Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/81.0.4044.123 Safari/537.36""
```
And from synapse homesever.log:
```
2020-04-26 11:29:00,034 - synapse.access.http.8008 - 282 - INFO - GET-453461- IP - 8008 - {@user:homeserver.tld} Processed request: 0.809sec/0.247sec (0.420sec, 0.040sec) (0.532sec/1.064sec/60) 67B 500 ""GET /_matrix/client/r0/sync?filter=12&timeout=0&_cacheBuster=1587900538750 HTTP/1.0"" ""Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/81.0.4044.123 Safari/537.36"" [21 dbevts]
```
### Logs
```
2020-04-26 11:28:59,724 - synapse.http.server - 106 - ERROR - GET-453461- Failed handle request via 'SyncRestServlet':
Traceback (most recent call last):
File ""/[...]/python3.8/site-packages/twisted/internet/defer.py"", line 1418, in _inlineCallbacks
result = g.send(result)
StopIteration: [dict dump removed for privacy]
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File ""/[...]/python3.8/site-packages/twisted/internet/defer.py"", line 1416, in _inlineCallbacks
result = result.throwExceptionIntoGenerator(g)
File ""/[...]/python3.8/site-packages/twisted/python/failure.py"", line 512, in throwExceptionIntoGenerator
return g.throw(self.type, self.value, self.tb)
File ""/[...]/python3.8/site-packages/synapse/handlers/sync.py"", line 311, in _wait_for_sync_for_user
result = await self.current_sync_for_user(
File ""/[...]/python3.8/site-packages/synapse/handlers/sync.py"", line 343, in current_sync_for_user
return await self.generate_sync_result(sync_config, since_token, full_state)
File ""/[...]/python3.8/site-packages/synapse/handlers/sync.py"", line 999, in generate_sync_result
res = await self._generate_sync_entry_for_rooms(
File ""/[...]/python3.8/site-packages/synapse/handlers/sync.py"", line 1419, in _generate_sync_entry_for_rooms
await concurrently_execute(handle_room_entries, room_entries, 10)
File ""/[...]/python3.8/site-packages/twisted/internet/defer.py"", line 1416, in _inlineCallbacks
result = result.throwExceptionIntoGenerator(g)
File ""/[...]/python3.8/site-packages/twisted/python/failure.py"", line 512, in throwExceptionIntoGenerator
return g.throw(self.type, self.value, self.tb)
File ""/[...]/python3.8/site-packages/synapse/util/async_helpers.py"", line 159, in _concurrently_execute_inner
await maybe_awaitable(func(next(it)))
File ""/[...]/python3.8/site-packages/synapse/handlers/sync.py"", line 1797, in _generate_room_entry
batch = await self._load_filtered_recents(
File ""/[...]/python3.8/site-packages/synapse/handlers/sync.py"", line 497, in _load_filtered_recents
events, end_key = await self.store.get_recent_events_for_room(
File ""/[...]/python3.8/site-packages/twisted/internet/defer.py"", line 1416, in _inlineCallbacks
result = result.throwExceptionIntoGenerator(g)
File ""/[...]/python3.8/site-packages/twisted/python/failure.py"", line 512, in throwExceptionIntoGenerator
return g.throw(self.type, self.value, self.tb)
File ""/[...]/python3.8/site-packages/synapse/storage/data_stores/main/stream.py"", line 485, in get_recent_events_for_room
events = yield self.get_events_as_list(
File ""/[...]/python3.8/site-packages/twisted/internet/defer.py"", line 1416, in _inlineCallbacks
result = result.throwExceptionIntoGenerator(g)
File ""/[...]/python3.8/site-packages/twisted/python/failure.py"", line 512, in throwExceptionIntoGenerator
return g.throw(self.type, self.value, self.tb)
File ""/[...]/python3.8/site-packages/synapse/storage/data_stores/main/events_worker.py"", line 273, in get_events_as_list
event_entry_map = yield self._get_events_from_cache_or_db(
File ""/[...]/python3.8/site-packages/twisted/internet/defer.py"", line 1416, in _inlineCallbacks
result = result.throwExceptionIntoGenerator(g)
File ""/[...]/python3.8/site-packages/twisted/python/failure.py"", line 512, in throwExceptionIntoGenerator
return g.throw(self.type, self.value, self.tb)
File ""/[...]/python3.8/site-packages/synapse/storage/data_stores/main/events_worker.py"", line 420, in _get_events_from_cache_or_db
missing_events = yield self._get_events_from_db(
File ""/[...]/python3.8/site-packages/twisted/internet/defer.py"", line 1418, in _inlineCallbacks
result = g.send(result)
File ""/[...]/python3.8/site-packages/synapse/storage/data_stores/main/events_worker.py"", line 577, in _get_events_from_db
d = json.loads(row[""json""])
File ""/[...]/python3.8/site-packages/simplejson/__init__.py"", line 525, in loads
return _default_decoder.decode(s)
File ""/[...]/python3.8/site-packages/simplejson/decoder.py"", line 370, in decode
obj, end = self.raw_decode(s)
File ""/[...]/python3.8/site-packages/simplejson/decoder.py"", line 400, in raw_decode
return self.scan_once(s, idx=_w(s, idx).end())
simplejson.errors.JSONDecodeError: Expecting value: line 1 column 1 (char 0)
2020-04-26 11:29:00,034 - synapse.access.http.8008 - 282 - INFO - GET-453461- IP - 8008 - {@user:homeserver.tld} Processed request: 0.809sec/0.247sec (0.420sec, 0.040sec) (0.532sec/1.064sec/60) 67B 500 ""GET /_matrix/client/r0/sync?filter=12&timeout=0&_cacheBuster=1587900538750 HTTP/1.0"" ""Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/81.0.4044.123 Safari/537.36"" [21 dbevts]
```
Specifically, the dict dumped after StopIteration contains several events with a `'json'` field each.
I manually confirmed all these json strings as valid using a validator, except one which is not a ""clear text"" json string, but instead a hex-encoded string in the manner of `'\\xMANYHEXCHARS'`. Trying to load this hex with simplejson crashes it, however decoding it returns what seems to be valid json.
Related line from the source:
https://github.com/matrix-org/synapse/blob/master/synapse/storage/data_stores/main/events_worker.py#L577
### Version information
- **Version**: 1.12.4 (accessed with riot-web/desktop 1.5.15)
- **Install method**: pip in pyenv
- **Platform**: Debian GNU/Linux 9.12 (stretch)
- additional: using synapse-s3-storage provider",
940,https://api.github.com/repos/matrix-org/synapse/issues/7348,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7348/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7348/comments,https://api.github.com/repos/matrix-org/synapse/issues/7348/events,https://github.com/matrix-org/synapse/pull/7348,606992511,MDExOlB1bGxSZXF1ZXN0NDA5MDY5NDAw,7348,Fix INSTALL.md mistake about the FreeBSD pkg,"{'login': 'nguiard', 'id': 8525852, 'node_id': 'MDQ6VXNlcjg1MjU4NTI=', 'avatar_url': 'https://avatars0.githubusercontent.com/u/8525852?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/nguiard', 'html_url': 'https://github.com/nguiard', 'followers_url': 'https://api.github.com/users/nguiard/followers', 'following_url': 'https://api.github.com/users/nguiard/following{/other_user}', 'gists_url': 'https://api.github.com/users/nguiard/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/nguiard/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/nguiard/subscriptions', 'organizations_url': 'https://api.github.com/users/nguiard/orgs', 'repos_url': 'https://api.github.com/users/nguiard/repos', 'events_url': 'https://api.github.com/users/nguiard/events{/privacy}', 'received_events_url': 'https://api.github.com/users/nguiard/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,0,2020-04-26T11:46:16Z,2020-04-26T11:46:44Z,2020-04-26T11:46:44Z,NONE,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7348', 'html_url': 'https://github.com/matrix-org/synapse/pull/7348', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7348.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7348.patch'}","The pkg proposed was py27-matrix-synapse, where it seems it should be instead py37-matrix-synapse. There is no py27-matrix-synapse on http://pkg.freebsd.org/FreeBSD:12:amd64/latest/All/ .
### Pull Request Checklist
* [ ] Pull request is based on the develop branch
* [ ] Pull request includes a [changelog file](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#changelog). The entry should:
- Be a short description of your change which makes sense to users. ""Fixed a bug that prevented receiving messages from other servers."" instead of ""Moved X method from `EventStore` to `EventWorkerStore`."".
- Use markdown where necessary, mostly for `code blocks`.
- End with either a period (.) or an exclamation mark (!).
- Start with a capital letter.
* [ ] Pull request includes a [sign off](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#sign-off)
* [ ] Code style is correct (run the [linters](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#code-style))
",
941,https://api.github.com/repos/matrix-org/synapse/issues/7347,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7347/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7347/comments,https://api.github.com/repos/matrix-org/synapse/issues/7347/events,https://github.com/matrix-org/synapse/issues/7347,606937514,MDU6SXNzdWU2MDY5Mzc1MTQ=,7347,Synapse happily accepts m.push_rules account data,"{'login': 'auscompgeek', 'id': 128854, 'node_id': 'MDQ6VXNlcjEyODg1NA==', 'avatar_url': 'https://avatars2.githubusercontent.com/u/128854?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/auscompgeek', 'html_url': 'https://github.com/auscompgeek', 'followers_url': 'https://api.github.com/users/auscompgeek/followers', 'following_url': 'https://api.github.com/users/auscompgeek/following{/other_user}', 'gists_url': 'https://api.github.com/users/auscompgeek/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/auscompgeek/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/auscompgeek/subscriptions', 'organizations_url': 'https://api.github.com/users/auscompgeek/orgs', 'repos_url': 'https://api.github.com/users/auscompgeek/repos', 'events_url': 'https://api.github.com/users/auscompgeek/events{/privacy}', 'received_events_url': 'https://api.github.com/users/auscompgeek/received_events', 'type': 'User', 'site_admin': False}","[{'id': 121086029, 'node_id': 'MDU6TGFiZWwxMjEwODYwMjk=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/bug', 'name': 'bug', 'color': 'fc2929', 'default': True, 'description': None}, {'id': 477043173, 'node_id': 'MDU6TGFiZWw0NzcwNDMxNzM=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/p2', 'name': 'p2', 'color': 'fbca04', 'default': False, 'description': None}]",open,False,,[],,4,2020-04-26T06:49:27Z,2020-04-28T08:29:08Z,,CONTRIBUTOR,,,"### Description
Synapse will store changes to the `m.push_rules` account data to the `account_data` table. This then becomes out of sync with your real push rules stored in the `push_rules` table.
### Steps to reproduce
**Warning**: Recovering from these steps requires database surgery. Do not attempt on a homeserver for which you do not have admin access to the database.
- Open riot-web devtools
- Explore account data
- Open `m.push_rules`
- Edit and send
Your edited ""push rules"" gets stored in the `account_data` table as `m.push_rules`, which then gets sent out to all of your clients.
### Version information
- **Version**: 1.12.3
- **Install method**: Debian unstable matrix-synapse package
- **Platform**: Debian unstable on OVH",
942,https://api.github.com/repos/matrix-org/synapse/issues/7346,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7346/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7346/comments,https://api.github.com/repos/matrix-org/synapse/issues/7346/events,https://github.com/matrix-org/synapse/issues/7346,606887758,MDU6SXNzdWU2MDY4ODc3NTg=,7346,federation_domain_whitelist wildcard domain support …,"{'login': 'fooness', 'id': 11408027, 'node_id': 'MDQ6VXNlcjExNDA4MDI3', 'avatar_url': 'https://avatars3.githubusercontent.com/u/11408027?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/fooness', 'html_url': 'https://github.com/fooness', 'followers_url': 'https://api.github.com/users/fooness/followers', 'following_url': 'https://api.github.com/users/fooness/following{/other_user}', 'gists_url': 'https://api.github.com/users/fooness/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/fooness/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/fooness/subscriptions', 'organizations_url': 'https://api.github.com/users/fooness/orgs', 'repos_url': 'https://api.github.com/users/fooness/repos', 'events_url': 'https://api.github.com/users/fooness/events{/privacy}', 'received_events_url': 'https://api.github.com/users/fooness/received_events', 'type': 'User', 'site_admin': False}","[{'id': 477043174, 'node_id': 'MDU6TGFiZWw0NzcwNDMxNzQ=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/feature', 'name': 'feature', 'color': 'bfd4f2', 'default': False, 'description': None}, {'id': 477043173, 'node_id': 'MDU6TGFiZWw0NzcwNDMxNzM=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/p2', 'name': 'p2', 'color': 'fbca04', 'default': False, 'description': None}]",open,False,,[],,0,2020-04-26T00:50:04Z,2020-04-27T16:40:50Z,,NONE,,,"It would be good if `federation_domain_whitelist` would support wildcard domains, as for example `federation_certificate_verification_whitelist` does support it.
```
#federation_certificate_verification_whitelist:
# - lon.example.com
# - *.domain.com
# - *.onion
```",
943,https://api.github.com/repos/matrix-org/synapse/issues/7345,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7345/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7345/comments,https://api.github.com/repos/matrix-org/synapse/issues/7345/events,https://github.com/matrix-org/synapse/issues/7345,606793295,MDU6SXNzdWU2MDY3OTMyOTU=,7345,Synchrotron stopped relaying new messages ,"{'login': 'Half-Shot', 'id': 2072976, 'node_id': 'MDQ6VXNlcjIwNzI5NzY=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/2072976?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Half-Shot', 'html_url': 'https://github.com/Half-Shot', 'followers_url': 'https://api.github.com/users/Half-Shot/followers', 'following_url': 'https://api.github.com/users/Half-Shot/following{/other_user}', 'gists_url': 'https://api.github.com/users/Half-Shot/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/Half-Shot/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/Half-Shot/subscriptions', 'organizations_url': 'https://api.github.com/users/Half-Shot/orgs', 'repos_url': 'https://api.github.com/users/Half-Shot/repos', 'events_url': 'https://api.github.com/users/Half-Shot/events{/privacy}', 'received_events_url': 'https://api.github.com/users/Half-Shot/received_events', 'type': 'User', 'site_admin': False}","[{'id': 2011569249, 'node_id': 'MDU6TGFiZWwyMDExNTY5MjQ5', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/operation%20gemini', 'name': 'operation gemini', 'color': '006b75', 'default': False, 'description': 'Part of the project to fix the cpu bottleneck on'}, {'id': 828666468, 'node_id': 'MDU6TGFiZWw4Mjg2NjY0Njg=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/release%20blocker', 'name': 'release blocker', 'color': '880000', 'default': False, 'description': None}]",closed,False,"{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}","[{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}]",,15,2020-04-25T15:28:27Z,2020-04-28T21:11:52Z,2020-04-28T21:11:52Z,CONTRIBUTOR,,,"I noticed today that my messages had stopped arriving after some time, but /sync was happily running as normal (no clientside errors). I checked the synchrotron and noticed that I was hitting the long poll timeout (30s) for my user pretty much reliably, and the sync token wasn't advancing.
And to be sure, I checked that my federation workers were all working, and they seemed to be processing incoming traffic just fine. I've also checked my certificates, and they are okay too.
```
2020-04-24 23:36:10,512 - synapse.state - 497 - INFO - GET-109649- Resolving state for !tdtPuWhSgVBBsTHMhG:matrix.org with 2 groups
2020-04-24 23:36:10,512 - synapse.state - 520 - INFO - GET-109649- Resolving conflicted state for '!tdtPuWhSgVBBsTHMhG:matrix.org'
2020-04-24 23:36:10,513 - synapse.state.v1 - 80 - INFO - GET-109649- Asking for 190/190 conflicted events
2020-04-24 23:36:10,522 - synapse.state - 497 - INFO - GET-109649- Resolving state for !FTFmvhuoHbAAzjYtZe:matrix.org with 8 groups
2020-04-24 23:36:10,522 - synapse.state - 520 - INFO - GET-109649- Resolving conflicted state for '!FTFmvhuoHbAAzjYtZe:matrix.org'
2020-04-24 23:36:10,527 - synapse.state.v1 - 80 - INFO - GET-109649- Asking for 447/447 conflicted events
2020-04-24 23:36:10,542 - synapse.metrics - 464 - INFO - - Collecting gc 1
2020-04-24 23:36:10,586 - synapse.state.v1 - 112 - INFO - GET-109649- Asking for 3/3 auth events
2020-04-24 23:36:10,676 - synapse.state.v1 - 112 - INFO - GET-109649- Asking for 4/4 auth events
2020-04-24 23:36:11,349 - synapse.access.http.8018 - 301 - INFO - GET-109649- - - 8018 - {@Half-Shot:half-shot.uk} Processed request: 1.083sec/0.000sec (0.165sec, 0.008sec) (0.078sec/2.126sec/57) 15178B 200 ""GET /_matrix/client/r0/sync?filter=181&timeout=30000&since=s36879948_272948375_38408_18234089_321641_1391_199653_1182298_48 HTTP/1.0"" ""RiotX/0.19.0-dev (Linux; U; Android 10; Pixel 3a Build/QQ2A.200405.00; Flavour FDr
oid; MatrixAndroidSDK_X 0.0.1)"" [660 dbevts]
2020-04-24 23:36:15,103 - synapse.access.http.8018 - 301 - INFO - GET-109650- - - 8018 - {@Half-Shot:half-shot.uk} Processed request: 0.152sec/0.000sec (0.031sec, 0.001sec) (0.036sec/0.348sec/17) 14608B 200 ""GET /_matrix/client/r0/sync?filter=174&timeout=30000&since=s36879950_272948375_38420_18234097_321641_1391_199653_1182298_48 HTTP/1.0"" ""Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Riot/1.5.15
Chrome/78.0.3904.130 Electron/7.1.14 Safari/537.36"" [0 dbevts]
2020-04-24 23:36:15,374 - synapse.access.http.8018 - 301 - INFO - GET-109651- - - 8018 - {@Half-Shot:half-shot.uk} Processed request: 0.037sec/0.000sec (0.017sec, 0.000sec) (0.001sec/0.018sec/1) 1384B 200 ""GET /_matrix/client/r0/sync?filter=174&timeout=30000&since=s36879970_272948375_38427_18234109_321641_1391_199653_1182299_48 HTTP/1.0"" ""Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Riot/1.5.15 C
hrome/78.0.3904.130 Electron/7.1.14 Safari/537.36"" [0 dbevts]
2020-04-24 23:36:16,972 - synapse.access.http.8018 - 301 - INFO - GET-109653- - - 8018 - {@Half-Shot:half-shot.uk} Processed request: 0.059sec/0.000sec (0.019sec, 0.000sec) (0.001sec/0.036sec/2) 2707B 200 ""GET /_matrix/client/r0/sync?filter=181&timeout=30000&since=s36879969_272948375_38425_18234106_321641_1391_199653_1182299_48 HTTP/1.0"" ""RiotX/0.19.0-dev (Linux; U; Android 10; Pixel 3a Build/QQ2A.200405.00; Flavour FDroi
d; MatrixAndroidSDK_X 0.0.1)"" [0 dbevts]
2020-04-24 23:36:18,871 - synapse.access.http.8018 - 301 - INFO - GET-109652- - - 8018 - {@Half-Shot:half-shot.uk} Processed request: 3.378sec/0.000sec (0.011sec, 0.000sec) (0.001sec/0.038sec/2) 559B 200 ""GET /_matrix/client/r0/sync?filter=174&timeout=30000&since=s36879970_272948375_38428_18234112_321641_1391_199653_1182299_48 HTTP/1.0"" ""Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Riot/1.5.15 Ch
rome/78.0.3904.130 Electron/7.1.14 Safari/537.36"" [0 dbevts]
2020-04-24 23:36:21,919 - synapse.access.http.8018 - 301 - INFO - GET-109654- - - 8018 - {@Half-Shot:half-shot.uk} Processed request: 2.983sec/0.000sec (0.007sec, 0.000sec) (0.000sec/0.000sec/0) 759B 200 ""GET /_matrix/client/r0/sync?filter=174&timeout=30000&since=s36879970_272948375_38428_18234112_321641_1391_199654_1182299_48 HTTP/1.0"" ""Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Riot/1.5.15 Ch
rome/78.0.3904.130 Electron/7.1.14 Safari/537.36"" [0 dbevts]
2020-04-24 23:36:22,853 - synapse.access.http.8018 - 301 - INFO - GET-109655- - - 8018 - {@Half-Shot:half-shot.uk} Processed request: 0.860sec/0.000sec (0.012sec, 0.000sec) (0.001sec/0.018sec/1) 848B 200 ""GET /_matrix/client/r0/sync?filter=174&timeout=30000&since=s36879970_272948375_38429_18234112_321641_1391_199654_1182299_48 HTTP/1.0"" ""Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Riot/1.5.15 Ch
rome/78.0.3904.130 Electron/7.1.14 Safari/537.36"" [0 dbevts]
2020-04-24 23:36:25,040 - synapse.access.http.8018 - 301 - INFO - GET-109656- - - 8018 - {@Half-Shot:half-shot.uk} Processed request: 2.045sec/0.000sec (0.010sec, 0.000sec) (0.000sec/0.000sec/0) 803B 200 ""GET /_matrix/client/r0/sync?filter=174&timeout=30000&since=s36879970_272948375_38429_18234113_321641_1391_199654_1182299_48 HTTP/1.0"" ""Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Riot/1.5.15 Ch
rome/78.0.3904.130 Electron/7.1.14 Safari/537.36"" [0 dbevts]
2020-04-24 23:36:27,238 - synapse.access.http.8018 - 301 - INFO - GET-109657- - - 8018 - {@Half-Shot:half-shot.uk} Processed request: 2.120sec/0.000sec (0.041sec, 0.000sec) (0.001sec/0.045sec/2) 848B 200 ""GET /_matrix/client/r0/sync?filter=174&timeout=30000&since=s36879970_272948375_38430_18234113_321641_1391_199654_1182299_48 HTTP/1.0"" ""Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Riot/1.5.15 Ch
rome/78.0.3904.130 Electron/7.1.14 Safari/537.36"" [0 dbevts]
2020-04-24 23:36:27,795 - synapse.access.http.8018 - 301 - INFO - GET-109658- - - 8018 - {@Half-Shot:half-shot.uk} Processed request: 0.476sec/0.000sec (0.014sec, 0.000sec) (0.000sec/0.018sec/1) 851B 200 ""GET /_matrix/client/r0/sync?filter=174&timeout=30000&since=s36879970_272948375_38430_18234114_321641_1391_199654_1182299_48 HTTP/1.0"" ""Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Riot/1.5.15 Ch
rome/78.0.3904.130 Electron/7.1.14 Safari/537.36"" [0 dbevts]
2020-04-24 23:36:28,130 - synapse.access.http.8018 - 301 - INFO - GET-109659- - - 8018 - {@Half-Shot:half-shot.uk} Processed request: 0.252sec/0.000sec (0.017sec, 0.000sec) (0.007sec/0.018sec/1) 853B 200 ""GET /_matrix/client/r0/sync?filter=174&timeout=30000&since=s36879970_272948375_38430_18234115_321641_1391_199654_1182299_48 HTTP/1.0"" ""Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Riot/1.5.15 Ch
rome/78.0.3904.130 Electron/7.1.14 Safari/537.36"" [0 dbevts]
2020-04-24 23:36:28,130 - synapse.metrics - 464 - INFO - - Collecting gc 1
2020-04-24 23:36:28,139 - synapse.metrics - 464 - INFO - - Collecting gc 2
2020-04-24 23:36:39,442 - synapse.access.http.8018 - 301 - INFO - GET-109661- - - 8018 - {@Half-Shot:half-shot.uk} Processed request: 0.145sec/0.000sec (0.034sec, 0.000sec) (0.001sec/0.105sec/4) 2394B 200 ""GET /_matrix/client/r0/sync?filter=181&timeout=0&since=s36879970_272948375_38428_18234112_321641_1391_199653_1182299_48 HTTP/1.0"" ""RiotX/0.19.0-dev (Linux; U; Android 10; Pixel 3a Build/QQ2A.200405.00; Flavour FDroid; M
atrixAndroidSDK_X 0.0.1)"" [0 dbevts]
2020-04-24 23:36:58,590 - synapse.access.http.8018 - 301 - INFO - GET-109660- - - 8018 - {@Half-Shot:half-shot.uk} Processed request: 30.013sec/0.000sec (0.014sec, 0.000sec) (0.000sec/0.000sec/0) 374B 200 ""GET /_matrix/client/r0/sync?filter=174&timeout=30000&since=s36879970_272948375_38430_18234116_321641_1391_199654_1182299_48 HTTP/1.0"" ""Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Riot/1.5.15 C
hrome/78.0.3904.130 Electron/7.1.14 Safari/537.36"" [0 dbevts]
2020-04-24 23:37:10,582 - synapse.access.http.8018 - 301 - INFO - GET-109662- - - 8018 - {@Half-Shot:half-shot.uk} Processed request: 30.010sec/0.000sec (0.008sec, 0.000sec) (0.000sec/0.000sec/0) 374B 200 ""GET /_matrix/client/r0/sync?filter=181&timeout=30000&since=s36879970_272948375_38430_18234116_321641_1391_199654_1182299_48 HTTP/1.0"" ""RiotX/0.19.0-dev (Linux; U; Android 10; Pixel 3a Build/QQ2A.200405.00; Flavour FDroi
d; MatrixAndroidSDK_X 0.0.1)"" [0 dbevts]
2020-04-24 23:37:10,840 - synapse.access.http.8018 - 301 - INFO - GET-109664- - - 8018 - {@Half-Shot:half-shot.uk} Processed request: 0.012sec/0.000sec (0.009sec, 0.000sec) (0.000sec/0.000sec/0) 374B 200 ""GET /_matrix/client/r0/sync?filter=181&timeout=0&since=s36879970_272948375_38430_18234116_321641_1391_199654_1182299_48 HTTP/1.0"" ""RiotX/0.19.0-dev (Linux; U; Android 10; Pixel 3a Build/QQ2A.200405.00; Flavour FDroid; Ma
trixAndroidSDK_X 0.0.1)"" [0 dbevts]
2020-04-24 23:37:28,678 - synapse.access.http.8018 - 301 - INFO - GET-109663- - - 8018 - {@Half-Shot:half-shot.uk} Processed request: 30.008sec/0.000sec (0.006sec, 0.000sec) (0.000sec/0.000sec/0) 374B 200 ""GET /_matrix/client/r0/sync?filter=174&timeout=30000&since=s36879970_272948375_38430_18234116_321641_1391_199654_1182299_48 HTTP/1.0"" ""Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Riot/1.5.15 C
hrome/78.0.3904.130 Electron/7.1.14 Safari/537.36"" [0 dbevts]
2020-04-24 23:37:41,678 - synapse.access.http.8018 - 301 - INFO - GET-109665- - - 8018 - {@Half-Shot:half-shot.uk} Processed request: 30.008sec/0.000sec (0.005sec, 0.000sec) (0.000sec/0.000sec/0) 374B 200 ""GET /_matrix/client/r0/sync?filter=181&timeout=30000&since=s36879970_272948375_38430_18234116_321641_1391_199654_1182299_48 HTTP/1.0"" ""RiotX/0.19.0-dev (Linux; U; Android 10; Pixel 3a Build/QQ2A.200405.00; Flavour FDroi
d; MatrixAndroidSDK_X 0.0.1)"" [0 dbevts]
2020-04-24 23:37:41,856 - synapse.access.http.8018 - 301 - INFO - GET-109667- - - 8018 - {@Half-Shot:half-shot.uk} Processed request: 0.007sec/0.000sec (0.004sec, 0.000sec) (0.000sec/0.000sec/0) 374B 200 ""GET /_matrix/client/r0/sync?filter=181&timeout=0&since=s36879970_272948375_38430_18234116_321641_1391_199654_1182299_48 HTTP/1.0"" ""RiotX/0.19.0-dev (Linux; U; Android 10; Pixel 3a Build/QQ2A.200405.00; Flavour FDroid; Ma
trixAndroidSDK_X 0.0.1)"" [0 dbevts]
2020-04-24 23:37:58,751 - synapse.access.http.8018 - 301 - INFO - GET-109666- - - 8018 - {@Half-Shot:half-shot.uk} Processed request: 30.009sec/0.000sec (0.004sec, 0.000sec) (0.000sec/0.000sec/0) 374B 200 ""GET /_matrix/client/r0/sync?filter=174&timeout=30000&since=s36879970_272948375_38430_18234116_321641_1391_199654_1182299_48 HTTP/1.0"" ""Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Riot/1.5.15 C
hrome/78.0.3904.130 Electron/7.1.14 Safari/537.36"" [0 dbevts]
2020-04-24 23:38:12,332 - synapse.access.http.8018 - 301 - INFO - GET-109668- - - 8018 - {@Half-Shot:half-shot.uk} Processed request: 30.009sec/0.000sec (0.004sec, 0.000sec) (0.000sec/0.000sec/0) 374B 200 ""GET /_matrix/client/r0/sync?filter=181&timeout=30000&since=s36879970_272948375_38430_18234116_321641_1391_199654_1182299_48 HTTP/1.0"" ""RiotX/0.19.0-dev (Linux; U; Android 10; Pixel 3a Build/QQ2A.200405.00; Flavour FDroi
d; MatrixAndroidSDK_X 0.0.1)"" [0 dbevts]
2020-04-24 23:38:12,458 - synapse.access.http.8018 - 301 - INFO - GET-109670- - - 8018 - {@Half-Shot:half-shot.uk} Processed request: 0.008sec/0.000sec (0.008sec, 0.000sec) (0.000sec/0.000sec/0) 374B 200 ""GET /_matrix/client/r0/sync?filter=181&timeout=0&since=s36879970_272948375_38430_18234116_321641_1391_199654_1182299_48 HTTP/1.0"" ""RiotX/0.19.0-dev (Linux; U; Android 10; Pixel 3a Build/QQ2A.200405.00; Flavour FDroid; Ma
trixAndroidSDK_X 0.0.1)"" [0 dbevts]
2020-04-24 23:38:20,666 - synapse.storage.data_stores.main.event_push_actions - 499 - INFO - event_push_action_stream_orderings-221- Searching for stream ordering 1 month ago
2020-04-24 23:38:20,866 - synapse.storage.data_stores.main.event_push_actions - 504 - INFO - event_push_action_stream_orderings-221- Found stream ordering 1 month ago: it's 36262982
2020-04-24 23:38:20,867 - synapse.storage.data_stores.main.event_push_actions - 506 - INFO - event_push_action_stream_orderings-221- Searching for stream ordering 1 day ago
2020-04-24 23:38:21,025 - synapse.storage.data_stores.main.event_push_actions - 511 - INFO - event_push_action_stream_orderings-221- Found stream ordering 1 day ago: it's 36857827
2020-04-24 23:38:28,839 - synapse.access.http.8018 - 301 - INFO - GET-109669- - - 8018 - {@Half-Shot:half-shot.uk} Processed request: 30.012sec/0.000sec (0.008sec, 0.000sec) (0.000sec/0.000sec/0) 374B 200 ""GET /_matrix/client/r0/sync?filter=174&timeout=30000&since=s36879970_272948375_38430_18234116_321641_1391_199654_1182299_48 HTTP/1.0"" ""Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Riot/1.5.15 C
hrome/78.0.3904.130 Electron/7.1.14 Safari/537.36"" [0 dbevts]
2020-04-24 23:38:42,594 - synapse.access.http.8018 - 301 - INFO - GET-109671- - - 8018 - {@Half-Shot:half-shot.uk} Processed request: 30.008sec/0.000sec (0.005sec, 0.000sec) (0.000sec/0.000sec/0) 374B 200 ""GET /_matrix/client/r0/sync?filter=181&timeout=30000&since=s36879970_272948375_38430_18234116_321641_1391_199654_1182299_48 HTTP/1.0"" ""RiotX/0.19.0-dev (Linux; U; Android 10; Pixel 3a Build/QQ2A.200405.00; Flavour FDroi
d; MatrixAndroidSDK_X 0.0.1)"" [0 dbevts]
2020-04-24 23:38:42,781 - synapse.access.http.8018 - 301 - INFO - GET-109673- - - 8018 - {@Half-Shot:half-shot.uk} Processed request: 0.007sec/0.000sec (0.007sec, 0.000sec) (0.000sec/0.000sec/0) 374B 200 ""GET /_matrix/client/r0/sync?filter=181&timeout=0&since=s36879970_272948375_38430_18234116_321641_1391_199654_1182299_48 HTTP/1.0"" ""RiotX/0.19.0-dev (Linux; U; Android 10; Pixel 3a Build/QQ2A.200405.00; Flavour FDroid; Ma
trixAndroidSDK_X 0.0.1)"" [0 dbevts]
2020-04-24 23:38:58,920 - synapse.access.http.8018 - 301 - INFO - GET-109672- - - 8018 - {@Half-Shot:half-shot.uk} Processed request: 30.013sec/0.000sec (0.008sec, 0.000sec) (0.000sec/0.000sec/0) 374B 200 ""GET /_matrix/client/r0/sync?filter=174&timeout=30000&since=s36879970_272948375_38430_18234116_321641_1391_199654_1182299_48 HTTP/1.0"" ""Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Riot/1.5.15 C
hrome/78.0.3904.130 Electron/7.1.14 Safari/537.36"" [0 dbevts]
2020-04-24 23:39:13,273 - synapse.access.http.8018 - 301 - INFO - GET-109674- - - 8018 - {@Half-Shot:half-shot.uk} Processed request: 30.009sec/0.000sec (0.008sec, 0.000sec) (0.000sec/0.000sec/0) 374B 200 ""GET /_matrix/client/r0/sync?filter=181&timeout=30000&since=s36879970_272948375_38430_18234116_321641_1391_199654_1182299_48 HTTP/1.0"" ""RiotX/0.19.0-dev (Linux; U; Android 10; Pixel 3a Build/QQ2A.200405.00; Flavour FDroi
d; MatrixAndroidSDK_X 0.0.1)"" [0 dbevts]
2020-04-24 23:39:13,487 - synapse.access.http.8018 - 301 - INFO - GET-109676- - - 8018 - {@Half-Shot:half-shot.uk} Processed request: 0.013sec/0.000sec (0.011sec, 0.000sec) (0.000sec/0.000sec/0) 374B 200 ""GET /_matrix/client/r0/sync?filter=181&timeout=0&since=s36879970_272948375_38430_18234116_321641_1391_199654_1182299_48 HTTP/1.0"" ""RiotX/0.19.0-dev (Linux; U; Android 10; Pixel 3a Build/QQ2A.200405.00; Flavour FDroid; Ma
trixAndroidSDK_X 0.0.1)"" [0 dbevts]
2020-04-24 23:39:29,040 - synapse.access.http.8018 - 301 - INFO - GET-109675- - - 8018 - {@Half-Shot:half-shot.uk} Processed request: 30.016sec/0.000sec (0.013sec, 0.000sec) (0.000sec/0.000sec/0) 374B 200 ""GET /_matrix/client/r0/sync?filter=174&timeout=30000&since=s36879970_272948375_38430_18234116_321641_1391_199654_1182299_48 HTTP/1.0"" ""Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Riot/1.5.15 C
hrome/78.0.3904.130 Electron/7.1.14 Safari/537.36"" [0 dbevts]
2020-04-24 23:39:43,976 - synapse.access.http.8018 - 301 - INFO - GET-109677- - - 8018 - {@Half-Shot:half-shot.uk} Processed request: 30.008sec/0.000sec (0.003sec, 0.000sec) (0.000sec/0.000sec/0) 374B 200 ""GET /_matrix/client/r0/sync?filter=181&timeout=30000&since=s36879970_272948375_38430_18234116_321641_1391_199654_1182299_48 HTTP/1.0"" ""RiotX/0.19.0-dev (Linux; U; Android 10; Pixel 3a Build/QQ2A.200405.00; Flavour FDroid; MatrixAndroidSDK_X 0.0.1)"" [0 dbevts]
2020-04-24 23:39:44,237 - synapse.access.http.8018 - 301 - INFO - GET-109679- - - 8018 - {@Half-Shot:half-shot.uk} Processed request: 0.007sec/0.000sec (0.007sec, 0.000sec) (0.000sec/0.000sec/0) 374B 200 ""GET /_matrix/client/r0/sync?filter=181&timeout=0&since=s36879970_272948375_38430_18234116_321641_1391_199654_1182299_48 HTTP/1.0"" ""RiotX/0.19.0-dev (Linux; U; Android 10; Pixel 3a Build/QQ2A.200405.00; Flavour FDroid; MatrixAndroidSDK_X 0.0.1)"" [0 dbevts]
2020-04-24 23:39:59,121 - synapse.access.http.8018 - 301 - INFO - GET-109678- - - 8018 - {@Half-Shot:half-shot.uk} Processed request: 30.013sec/0.000sec (0.013sec, 0.000sec) (0.000sec/0.000sec/0) 374B 200 ""GET /_matrix/client/r0/sync?filter=174&timeout=30000&since=s36879970_272948375_38430_18234116_321641_1391_199654_1182299_48 HTTP/1.0"" ""Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Riot/1.5.15 Chrome/78.0.3904.130 Electron/7.1.14 Safari/537.36"" [0 dbevts]
2020-04-24 23:40:14,737 - synapse.access.http.8018 - 301 - INFO - GET-109680- - - 8018 - {@Half-Shot:half-shot.uk} Processed request: 30.014sec/0.000sec (0.011sec, 0.000sec) (0.000sec/0.000sec/0) 374B 200 ""GET /_matrix/client/r0/sync?filter=181&timeout=30000&since=s36879970_272948375_38430_18234116_321641_1391_199654_1182299_48 HTTP/1.0"" ""RiotX/0.19.0-dev (Linux; U; Android 10; Pixel 3a Build/QQ2A.200405.00; Flavour FDroid; MatrixAndroidSDK_X 0.0.1)"" [0 dbevts]
2020-04-24 23:40:29,227 - synapse.access.http.8018 - 301 - INFO - GET-109681- - - 8018 - {@Half-Shot:half-shot.uk} Processed request: 30.014sec/0.000sec (0.010sec, 0.000sec) (0.000sec/0.000sec/0) 374B 200 ""GET /_matrix/client/r0/sync?filter=174&timeout=30000&since=s36879970_272948375_38430_18234116_321641_1391_199654_1182299_48 HTTP/1.0"" ""Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Riot/1.5.15 Chrome/78.0.3904.130 Electron/7.1.14 Safari/537.36"" [0 dbevts]
2020-04-24 23:40:33,459 - synapse.access.http.8018 - 301 - INFO - GET-109683- - - 8018 - {@Half-Shot:half-shot.uk} Processed request: 0.013sec/0.000sec (0.011sec, 0.000sec) (0.000sec/0.000sec/0) 374B 200 ""GET /_matrix/client/r0/sync?filter=181&timeout=0&since=s36879970_272948375_38430_18234116_321641_1391_199654_1182299_48 HTTP/1.0"" ""RiotX/0.19.0-dev (Linux; U; Android 10; Pixel 3a Build/QQ2A.200405.00; Flavour FDroid; MatrixAndroidSDK_X 0.0.1)"" [0 dbevts]
2020-04-24 23:40:59,315 - synapse.access.http.8018 - 301 - INFO - GET-109682- - - 8018 - {@Half-Shot:half-shot.uk} Processed request: 30.010sec/0.000sec (0.005sec, 0.000sec) (0.000sec/0.000sec/0) 374B 200 ""GET /_matrix/client/r0/sync?filter=174&timeout=30000&since=s36879970_272948375_38430_18234116_321641_1391_199654_1182299_48 HTTP/1.0"" ""Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Riot/1.5.15 Chrome/78.0.3904.130 Electron/7.1.14 Safari/537.36"" [0 dbevts]
2020-04-24 23:41:03,993 - synapse.access.http.8018 - 301 - INFO - GET-109684- - - 8018 - {@Half-Shot:half-shot.uk} Processed request: 30.015sec/0.000sec (0.010sec, 0.000sec) (0.000sec/0.000sec/0) 374B 200 ""GET /_matrix/client/r0/sync?filter=181&timeout=30000&since=s36879970_272948375_38430_18234116_321641_1391_199654_1182299_48 HTTP/1.0"" ""RiotX/0.19.0-dev (Linux; U; Android 10; Pixel 3a Build/QQ2A.200405.00; Flavour FDroid; MatrixAndroidSDK_X 0.0.1)"" [0 dbevts]
2020-04-24 23:41:29,497 - synapse.access.http.8018 - 301 - INFO - GET-109685- - - 8018 - {@Half-Shot:half-shot.uk} Processed request: 30.009sec/0.000sec (0.005sec, 0.000sec) (0.000sec/0.000sec/0) 374B 200 ""GET /_matrix/client/r0/sync?filter=174&timeout=30000&since=s36879970_272948375_38430_18234116_321641_1391_199654_1182299_48 HTTP/1.0"" ""Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Riot/1.5.15 C:
```
It has been going like this from 23:38 last night up until now. ",
944,https://api.github.com/repos/matrix-org/synapse/issues/7344,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7344/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7344/comments,https://api.github.com/repos/matrix-org/synapse/issues/7344/events,https://github.com/matrix-org/synapse/pull/7344,606598607,MDExOlB1bGxSZXF1ZXN0NDA4Nzc2NzUy,7344,Fix incorrect metrics reporting for renew_attestations,"{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,1,2020-04-24T21:39:07Z,2020-04-27T21:21:29Z,2020-04-27T21:20:11Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7344', 'html_url': 'https://github.com/matrix-org/synapse/pull/7344', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7344.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7344.patch'}","We need to wait for the renewals to finish, so that the metrics are correctly
reported.",
945,https://api.github.com/repos/matrix-org/synapse/issues/7343,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7343/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7343/comments,https://api.github.com/repos/matrix-org/synapse/issues/7343/events,https://github.com/matrix-org/synapse/pull/7343,606483627,MDExOlB1bGxSZXF1ZXN0NDA4Njg1NDg4,7343,Add documentation to the sample config about the templates for SSO.,"{'login': 'clokep', 'id': 517124, 'node_id': 'MDQ6VXNlcjUxNzEyNA==', 'avatar_url': 'https://avatars2.githubusercontent.com/u/517124?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/clokep', 'html_url': 'https://github.com/clokep', 'followers_url': 'https://api.github.com/users/clokep/followers', 'following_url': 'https://api.github.com/users/clokep/following{/other_user}', 'gists_url': 'https://api.github.com/users/clokep/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/clokep/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/clokep/subscriptions', 'organizations_url': 'https://api.github.com/users/clokep/orgs', 'repos_url': 'https://api.github.com/users/clokep/repos', 'events_url': 'https://api.github.com/users/clokep/events{/privacy}', 'received_events_url': 'https://api.github.com/users/clokep/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,0,2020-04-24T17:51:33Z,2020-04-24T19:03:51Z,2020-04-24T19:03:50Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7343', 'html_url': 'https://github.com/matrix-org/synapse/pull/7343', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7343.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7343.patch'}","This adds documentation to the sample config for the templates added in the various SSO PRs.
This essentially adds the information from #7279 into a more permanent space for someone setting up a new homeserver. It expands some wonderful docs written by @babolivier.",
946,https://api.github.com/repos/matrix-org/synapse/issues/7342,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7342/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7342/comments,https://api.github.com/repos/matrix-org/synapse/issues/7342/events,https://github.com/matrix-org/synapse/issues/7342,606460239,MDU6SXNzdWU2MDY0NjAyMzk=,7342,SSO CAS login issue,"{'login': 'ravindrsharma99', 'id': 36304122, 'node_id': 'MDQ6VXNlcjM2MzA0MTIy', 'avatar_url': 'https://avatars1.githubusercontent.com/u/36304122?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/ravindrsharma99', 'html_url': 'https://github.com/ravindrsharma99', 'followers_url': 'https://api.github.com/users/ravindrsharma99/followers', 'following_url': 'https://api.github.com/users/ravindrsharma99/following{/other_user}', 'gists_url': 'https://api.github.com/users/ravindrsharma99/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/ravindrsharma99/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/ravindrsharma99/subscriptions', 'organizations_url': 'https://api.github.com/users/ravindrsharma99/orgs', 'repos_url': 'https://api.github.com/users/ravindrsharma99/repos', 'events_url': 'https://api.github.com/users/ravindrsharma99/events{/privacy}', 'received_events_url': 'https://api.github.com/users/ravindrsharma99/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,2,2020-04-24T17:08:51Z,2020-04-24T17:15:24Z,2020-04-24T17:10:30Z,NONE,,,"SSO login: CAS based
http://127.0.0.1:8008/_matrix/client/r0/login/cas/ticket?redirectUrl=http:localhost:8080&ticket=ST-EjKJv6WmUZPVoCoHTG8jFugJ38g0u
Response:
{
""errcode"": ""M_UNAUTHORIZED"",
""error"": ""Invalid CAS response""
}
Please help .
Homeserver.yaml:
cas_config:
enabled: true
server_url: ""http://localhost:8000/cas""
service_url: ""CAS""
displayname_attribute: name
#required_attributes:",
947,https://api.github.com/repos/matrix-org/synapse/issues/7341,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7341/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7341/comments,https://api.github.com/repos/matrix-org/synapse/issues/7341/events,https://github.com/matrix-org/synapse/pull/7341,606362741,MDExOlB1bGxSZXF1ZXN0NDA4NTkwMTYw,7341,Don't crash when one of the configuration files is empty,"{'login': 'babolivier', 'id': 5547783, 'node_id': 'MDQ6VXNlcjU1NDc3ODM=', 'avatar_url': 'https://avatars3.githubusercontent.com/u/5547783?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/babolivier', 'html_url': 'https://github.com/babolivier', 'followers_url': 'https://api.github.com/users/babolivier/followers', 'following_url': 'https://api.github.com/users/babolivier/following{/other_user}', 'gists_url': 'https://api.github.com/users/babolivier/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/babolivier/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/babolivier/subscriptions', 'organizations_url': 'https://api.github.com/users/babolivier/orgs', 'repos_url': 'https://api.github.com/users/babolivier/repos', 'events_url': 'https://api.github.com/users/babolivier/events{/privacy}', 'received_events_url': 'https://api.github.com/users/babolivier/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,3,2020-04-24T14:38:32Z,2020-04-27T13:01:05Z,2020-04-27T13:01:04Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7341', 'html_url': 'https://github.com/matrix-org/synapse/pull/7341', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7341.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7341.patch'}","If the admin adds a `.yaml` file that's either empty or doesn't parse into a dict to a config directory (e.g. `conf.d` for debs installs), stuff like https://github.com/matrix-org/synapse/issues/7322 would happen. This PR checks that the file is correctly parsed into a dict, or ignores it with a warning if it parses into any other type (including `None` for empty files).
Fixes https://github.com/matrix-org/synapse/issues/7322",
948,https://api.github.com/repos/matrix-org/synapse/issues/7340,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7340/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7340/comments,https://api.github.com/repos/matrix-org/synapse/issues/7340/events,https://github.com/matrix-org/synapse/issues/7340,606317300,MDU6SXNzdWU2MDYzMTczMDA=,7340,More AssertionErrors from replication_notifier,"{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}","[{'id': 2011569249, 'node_id': 'MDU6TGFiZWwyMDExNTY5MjQ5', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/operation%20gemini', 'name': 'operation gemini', 'color': '006b75', 'default': False, 'description': 'Part of the project to fix the cpu bottleneck on'}]",closed,False,"{'login': 'erikjohnston', 'id': 8428120, 'node_id': 'MDQ6VXNlcjg0MjgxMjA=', 'avatar_url': 'https://avatars0.githubusercontent.com/u/8428120?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/erikjohnston', 'html_url': 'https://github.com/erikjohnston', 'followers_url': 'https://api.github.com/users/erikjohnston/followers', 'following_url': 'https://api.github.com/users/erikjohnston/following{/other_user}', 'gists_url': 'https://api.github.com/users/erikjohnston/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/erikjohnston/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/erikjohnston/subscriptions', 'organizations_url': 'https://api.github.com/users/erikjohnston/orgs', 'repos_url': 'https://api.github.com/users/erikjohnston/repos', 'events_url': 'https://api.github.com/users/erikjohnston/events{/privacy}', 'received_events_url': 'https://api.github.com/users/erikjohnston/received_events', 'type': 'User', 'site_admin': False}","[{'login': 'erikjohnston', 'id': 8428120, 'node_id': 'MDQ6VXNlcjg0MjgxMjA=', 'avatar_url': 'https://avatars0.githubusercontent.com/u/8428120?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/erikjohnston', 'html_url': 'https://github.com/erikjohnston', 'followers_url': 'https://api.github.com/users/erikjohnston/followers', 'following_url': 'https://api.github.com/users/erikjohnston/following{/other_user}', 'gists_url': 'https://api.github.com/users/erikjohnston/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/erikjohnston/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/erikjohnston/subscriptions', 'organizations_url': 'https://api.github.com/users/erikjohnston/orgs', 'repos_url': 'https://api.github.com/users/erikjohnston/repos', 'events_url': 'https://api.github.com/users/erikjohnston/events{/privacy}', 'received_events_url': 'https://api.github.com/users/erikjohnston/received_events', 'type': 'User', 'site_admin': False}]",,3,2020-04-24T13:33:06Z,2020-07-07T12:03:57Z,2020-07-07T12:03:56Z,MEMBER,,,"we have a function `db_query_to_update_function` which wraps a database query function so that it can be used as an update_function for replication streams. It relies on the wrapped function returning no more than the number of rows asked for. #7337 found and fixed one instance where this was not the case, but we should check if there are any more.",
949,https://api.github.com/repos/matrix-org/synapse/issues/7339,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7339/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7339/comments,https://api.github.com/repos/matrix-org/synapse/issues/7339/events,https://github.com/matrix-org/synapse/issues/7339,605899417,MDU6SXNzdWU2MDU4OTk0MTc=,7339,Unable to join some large rooms due to high RAM consumption,"{'login': 'rihardsk', 'id': 1666746, 'node_id': 'MDQ6VXNlcjE2NjY3NDY=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1666746?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/rihardsk', 'html_url': 'https://github.com/rihardsk', 'followers_url': 'https://api.github.com/users/rihardsk/followers', 'following_url': 'https://api.github.com/users/rihardsk/following{/other_user}', 'gists_url': 'https://api.github.com/users/rihardsk/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/rihardsk/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/rihardsk/subscriptions', 'organizations_url': 'https://api.github.com/users/rihardsk/orgs', 'repos_url': 'https://api.github.com/users/rihardsk/repos', 'events_url': 'https://api.github.com/users/rihardsk/events{/privacy}', 'received_events_url': 'https://api.github.com/users/rihardsk/received_events', 'type': 'User', 'site_admin': False}","[{'id': 477043173, 'node_id': 'MDU6TGFiZWw0NzcwNDMxNzM=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/p2', 'name': 'p2', 'color': 'fbca04', 'default': False, 'description': None}, {'id': 600557921, 'node_id': 'MDU6TGFiZWw2MDA1NTc5MjE=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/performance', 'name': 'performance', 'color': 'fef2c0', 'default': False, 'description': None}]",open,False,,[],,1,2020-04-23T21:54:27Z,2020-04-27T17:13:20Z,,NONE,,,"### Description
Joining some large rooms, such as `#freenode_#haskel:matrix.org` (1.4k members), fails because synapse eats up all the available memory leading to it being forcefully stopped. I've configured my system to limit synapse to 3.5 GB of RAM. Upon joining, synapse first spends some time doing some processing (seeing high CPU usage, RAM usage close to baseline 500 MB) and after a while the RAM consumption starts to steadily climb until it reaches the 3.5 GB mark when it has to be killed.
Here are the logs from the moment of joining the room up until synapse getting killed
[ram-crash.redacted.log](https://github.com/matrix-org/synapse/files/4525391/ram-crash.redacted.log)
The request for joining the room comes in at line 28. On line 564 synapse stopped printing anything to the logs and just maintained high CPU usage while steadily growing RAM consumption for ~1 minute until being killed.
Joining other large rooms, e.g., `#matrix:matrix.org` (3.2k members), `#synapse:matrix.org` (1.2k members), works fine (haven't monitored RAM consumption when joining but i had the same limits set). Some other person on `#synapse:matrix.org` reported joining a room with ~20k people with RAM consumption going up to ~1.1 GB, which leads me to suspect that i might be seeing something abnormal in my case. Am i?
Other than this issue, synapse seems to be working fine. I'm willing to repeat this and do some profiling if necessary.
### Steps to reproduce
- try to join `#freenode_#haskel:matrix.org`
- watch as synapse's RAM consumption grows to > 3.5 GB
### Version information
- **Homeserver**: my private homeserver
- **Version**: 1.12.1
- **Install method**: NixOS
- **Platform**: latest NixOS master branch (commit 01c8795673ecff6272895a085e9fe1ffa3b33620) running on a rockpro64 sbc (with a custom patched kernel).
",
950,https://api.github.com/repos/matrix-org/synapse/issues/7338,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7338/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7338/comments,https://api.github.com/repos/matrix-org/synapse/issues/7338/events,https://github.com/matrix-org/synapse/pull/7338,605815007,MDExOlB1bGxSZXF1ZXN0NDA4MTQ5MDUw,7338,Convert some of the federation handler methods to async/await.,"{'login': 'clokep', 'id': 517124, 'node_id': 'MDQ6VXNlcjUxNzEyNA==', 'avatar_url': 'https://avatars2.githubusercontent.com/u/517124?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/clokep', 'html_url': 'https://github.com/clokep', 'followers_url': 'https://api.github.com/users/clokep/followers', 'following_url': 'https://api.github.com/users/clokep/following{/other_user}', 'gists_url': 'https://api.github.com/users/clokep/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/clokep/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/clokep/subscriptions', 'organizations_url': 'https://api.github.com/users/clokep/orgs', 'repos_url': 'https://api.github.com/users/clokep/repos', 'events_url': 'https://api.github.com/users/clokep/events{/privacy}', 'received_events_url': 'https://api.github.com/users/clokep/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,0,2020-04-23T19:43:34Z,2020-04-24T18:36:40Z,2020-04-24T18:36:39Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7338', 'html_url': 'https://github.com/matrix-org/synapse/pull/7338', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7338.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7338.patch'}",This converts some of the federation handler methods to async/await. Those not converted are called by `inlineCallbacks` code still.,
951,https://api.github.com/repos/matrix-org/synapse/issues/7337,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7337/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7337/comments,https://api.github.com/repos/matrix-org/synapse/issues/7337/events,https://github.com/matrix-org/synapse/pull/7337,605720072,MDExOlB1bGxSZXF1ZXN0NDA4MDcwMTIy,7337,Fix assertions being thrown by the EventsStream update function,"{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,3,2020-04-23T17:34:54Z,2020-04-24T13:00:31Z,2020-04-24T13:00:30Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7337', 'html_url': 'https://github.com/matrix-org/synapse/pull/7337', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7337.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7337.patch'}","The problem here was that the EventsStream update function could return more rows than was requested of it, which was then upsetting the `db_query_to_update_function` wrapper which didn't know how to handle this. The confusion over whether the limit was a limit or a target was introduced in #7024, but I think there are much longer-standing bugs here in the limit logic.
So, part of the fix here is to make it clear that the limit passed into the `update_function` is a target rather than a hard limit, and to avoid using `db_query_to_update_function` which is too simple for this usecase. But to get it right, we need to pull `get_ex_outlier_stream_rows` out to a separate query (to make it easier to see if we have hit the limit), and apply more intelligence about how we truncate the results from the three queries.
Tests and an answer to the FIXME to follow.",
952,https://api.github.com/repos/matrix-org/synapse/issues/7336,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7336/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7336/comments,https://api.github.com/repos/matrix-org/synapse/issues/7336/events,https://github.com/matrix-org/synapse/pull/7336,605636466,MDExOlB1bGxSZXF1ZXN0NDA4MDAxOTYz,7336,Remove bind_email parameter from register_user,"{'login': 'anoadragon453', 'id': 1342360, 'node_id': 'MDQ6VXNlcjEzNDIzNjA=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1342360?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/anoadragon453', 'html_url': 'https://github.com/anoadragon453', 'followers_url': 'https://api.github.com/users/anoadragon453/followers', 'following_url': 'https://api.github.com/users/anoadragon453/following{/other_user}', 'gists_url': 'https://api.github.com/users/anoadragon453/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/anoadragon453/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/anoadragon453/subscriptions', 'organizations_url': 'https://api.github.com/users/anoadragon453/orgs', 'repos_url': 'https://api.github.com/users/anoadragon453/repos', 'events_url': 'https://api.github.com/users/anoadragon453/events{/privacy}', 'received_events_url': 'https://api.github.com/users/anoadragon453/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,"{'login': 'anoadragon453', 'id': 1342360, 'node_id': 'MDQ6VXNlcjEzNDIzNjA=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1342360?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/anoadragon453', 'html_url': 'https://github.com/anoadragon453', 'followers_url': 'https://api.github.com/users/anoadragon453/followers', 'following_url': 'https://api.github.com/users/anoadragon453/following{/other_user}', 'gists_url': 'https://api.github.com/users/anoadragon453/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/anoadragon453/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/anoadragon453/subscriptions', 'organizations_url': 'https://api.github.com/users/anoadragon453/orgs', 'repos_url': 'https://api.github.com/users/anoadragon453/repos', 'events_url': 'https://api.github.com/users/anoadragon453/events{/privacy}', 'received_events_url': 'https://api.github.com/users/anoadragon453/received_events', 'type': 'User', 'site_admin': False}","[{'login': 'anoadragon453', 'id': 1342360, 'node_id': 'MDQ6VXNlcjEzNDIzNjA=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1342360?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/anoadragon453', 'html_url': 'https://github.com/anoadragon453', 'followers_url': 'https://api.github.com/users/anoadragon453/followers', 'following_url': 'https://api.github.com/users/anoadragon453/following{/other_user}', 'gists_url': 'https://api.github.com/users/anoadragon453/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/anoadragon453/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/anoadragon453/subscriptions', 'organizations_url': 'https://api.github.com/users/anoadragon453/orgs', 'repos_url': 'https://api.github.com/users/anoadragon453/repos', 'events_url': 'https://api.github.com/users/anoadragon453/events{/privacy}', 'received_events_url': 'https://api.github.com/users/anoadragon453/received_events', 'type': 'User', 'site_admin': False}]",,1,2020-04-23T15:33:14Z,2020-04-23T18:35:07Z,2020-04-23T18:34:48Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7336', 'html_url': 'https://github.com/matrix-org/synapse/pull/7336', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7336.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7336.patch'}","As far as I can tell, this was only used by the `bind_email` parameter which was removed in https://github.com/matrix-org/synapse/pull/5964.
Emails added during registration still happen in `post_registration_actions`:
https://github.com/matrix-org/synapse/blob/2d6d4fa8aff7187b33fa00147703a802c1c80c95/synapse/handlers/register.py#L556-L565",
953,https://api.github.com/repos/matrix-org/synapse/issues/7335,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7335/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7335/comments,https://api.github.com/repos/matrix-org/synapse/issues/7335/events,https://github.com/matrix-org/synapse/issues/7335,605506880,MDU6SXNzdWU2MDU1MDY4ODA=,7335,Inviting a user to a room via email does not create an invite in Synapse,"{'login': 'anoadragon453', 'id': 1342360, 'node_id': 'MDQ6VXNlcjEzNDIzNjA=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1342360?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/anoadragon453', 'html_url': 'https://github.com/anoadragon453', 'followers_url': 'https://api.github.com/users/anoadragon453/followers', 'following_url': 'https://api.github.com/users/anoadragon453/following{/other_user}', 'gists_url': 'https://api.github.com/users/anoadragon453/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/anoadragon453/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/anoadragon453/subscriptions', 'organizations_url': 'https://api.github.com/users/anoadragon453/orgs', 'repos_url': 'https://api.github.com/users/anoadragon453/repos', 'events_url': 'https://api.github.com/users/anoadragon453/events{/privacy}', 'received_events_url': 'https://api.github.com/users/anoadragon453/received_events', 'type': 'User', 'site_admin': False}","[{'id': 121086029, 'node_id': 'MDU6TGFiZWwxMjEwODYwMjk=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/bug', 'name': 'bug', 'color': 'fc2929', 'default': True, 'description': None}, {'id': 477045093, 'node_id': 'MDU6TGFiZWw0NzcwNDUwOTM=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/p1', 'name': 'p1', 'color': 'd93f0b', 'default': False, 'description': None}]",closed,False,,[],,3,2020-04-23T12:51:31Z,2020-04-23T14:06:07Z,2020-04-23T14:06:07Z,MEMBER,,,"
### Description
Trying to invite a new user to a room via their email address allows them to sign up to the homeserver, but they don't actually get an invite to the room once they're signed in.
### Steps to reproduce
- `@alice:example.com` invites `bob@bobshouse.com` to a direct chat.
- bob registers, setting their email to `bob@bobshouse.com` and username to `bob`
- no room invite occurs inside the server (and this isn't even over federated synapses)
cc @michaelkaye
### Version information
- **Homeserver**: vector.modular.im
- **Version**: v1.12.3",
954,https://api.github.com/repos/matrix-org/synapse/issues/7334,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7334/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7334/comments,https://api.github.com/repos/matrix-org/synapse/issues/7334/events,https://github.com/matrix-org/synapse/issues/7334,605418189,MDU6SXNzdWU2MDU0MTgxODk=,7334,Running redis mode (on develop) causes high CPU usage,"{'login': 'Half-Shot', 'id': 2072976, 'node_id': 'MDQ6VXNlcjIwNzI5NzY=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/2072976?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Half-Shot', 'html_url': 'https://github.com/Half-Shot', 'followers_url': 'https://api.github.com/users/Half-Shot/followers', 'following_url': 'https://api.github.com/users/Half-Shot/following{/other_user}', 'gists_url': 'https://api.github.com/users/Half-Shot/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/Half-Shot/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/Half-Shot/subscriptions', 'organizations_url': 'https://api.github.com/users/Half-Shot/orgs', 'repos_url': 'https://api.github.com/users/Half-Shot/repos', 'events_url': 'https://api.github.com/users/Half-Shot/events{/privacy}', 'received_events_url': 'https://api.github.com/users/Half-Shot/received_events', 'type': 'User', 'site_admin': False}","[{'id': 2011569249, 'node_id': 'MDU6TGFiZWwyMDExNTY5MjQ5', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/operation%20gemini', 'name': 'operation gemini', 'color': '006b75', 'default': False, 'description': 'Part of the project to fix the cpu bottleneck on'}]",closed,False,,[],,5,2020-04-23T10:24:41Z,2020-04-29T13:32:01Z,2020-04-29T13:32:01Z,CONTRIBUTOR,,,"The CPU graph for my set of workers:
![image](https://user-images.githubusercontent.com/2072976/80088648-b5ad4500-8554-11ea-856a-598be8418a02.png)
The GC graph:
![image](https://user-images.githubusercontent.com/2072976/80088694-c493f780-8554-11ea-8941-d0ed26e2afb1.png)
Something has changed between 1.12.3 and 2e3b9a0fcb81b539e155004ded8017ee9923eecc that has caused this to skyrocket.
Otherwise, the homeserver seems to *work* in terms of federating and sending messages. It's just obsessed with GCing right now.
Memory usage has remained a bit low:
![image](https://user-images.githubusercontent.com/2072976/80088879-04f37580-8555-11ea-8e19-ede4f8d4a002.png)
",
955,https://api.github.com/repos/matrix-org/synapse/issues/7333,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7333/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7333/comments,https://api.github.com/repos/matrix-org/synapse/issues/7333/events,https://github.com/matrix-org/synapse/issues/7333,605414210,MDU6SXNzdWU2MDU0MTQyMTA=,7333,"avatar_url is null rather than """" in invite","{'login': 'neilalexander', 'id': 310854, 'node_id': 'MDQ6VXNlcjMxMDg1NA==', 'avatar_url': 'https://avatars3.githubusercontent.com/u/310854?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/neilalexander', 'html_url': 'https://github.com/neilalexander', 'followers_url': 'https://api.github.com/users/neilalexander/followers', 'following_url': 'https://api.github.com/users/neilalexander/following{/other_user}', 'gists_url': 'https://api.github.com/users/neilalexander/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/neilalexander/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/neilalexander/subscriptions', 'organizations_url': 'https://api.github.com/users/neilalexander/orgs', 'repos_url': 'https://api.github.com/users/neilalexander/repos', 'events_url': 'https://api.github.com/users/neilalexander/events{/privacy}', 'received_events_url': 'https://api.github.com/users/neilalexander/received_events', 'type': 'User', 'site_admin': False}","[{'id': 121086029, 'node_id': 'MDU6TGFiZWwxMjEwODYwMjk=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/bug', 'name': 'bug', 'color': 'fc2929', 'default': True, 'description': None}, {'id': 828678284, 'node_id': 'MDU6TGFiZWw4Mjg2NzgyODQ=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/spec%20compliance', 'name': 'spec compliance', 'color': 'cf75ef', 'default': False, 'description': 'places where synapse does not conform to the spec'}]",closed,False,,[],,1,2020-04-23T10:18:49Z,2020-05-19T09:33:00Z,2020-05-19T09:32:59Z,MEMBER,,,"### Description
An incoming v2 invite event from Synapse seems to set `avatar_url` to `nil` rather than `""""`, which doesn't match the spec's expectation of it being a `string`.
### Steps to reproduce
- invite a user to a room
- observe request body, e.g.
```
{
""event"": {
""auth_events"": [
""$uxl1r0IVu5dju5WaLyDWsiGkKu9VMpyLbTsXwVCSjg8"",
""$CDijC-qEh1F9wx2GaEDaVjZeZAotLyb9XECviqXYuQA"",
""$8u2LDvw2PQA1j7huGGlQ11_i1vYC_HLvPjyltQul1l0"",
""$r4MvBNTvC6aahOFhXUP2jHTAzLZDXYURLAipCNUD940"",
""$cmlp6_-XjUKXiKSsbnV0HSH9LXFw00r8Mu6eqG5RuWc""
],
""content"": {
""avatar_url"": """",
""displayname"": ""neilalexander (Dendrite)"",
""membership"": ""invite""
},
""depth"": 10,
""hashes"": {
""sha256"": ""hl9idNvIrjXKVuUZwHdadEIsTk1hiul4Zqb5eJdrapk""
},
""origin"": ""synapse.neilalexander.dev"",
""origin_server_ts"": 1587635800175,
""prev_events"": [
""$8u2LDvw2PQA1j7huGGlQ11_i1vYC_HLvPjyltQul1l0""
],
""prev_state"": [
],
""room_id"": ""!VRajJeEmcnrLJXqSoR:synapse.neilalexander.dev"",
""sender"": ""@neilalexander:synapse.neilalexander.dev"",
""signatures"": {
""synapse.neilalexander.dev"": {
""ed25519:a_MIwE"": ""B6IriXnW1afEYChG5/fSOl+nuUWDYg+IcITfx8vn0ZELyesuxxgDLjX0a5xVV0txd4cz9z829krkU95cSbUuBA""
}
},
""state_key"": ""@neilalexander:dendrite.neilalexander.dev"",
""type"": ""m.room.member"",
""unsigned"": {
""age"": 18,
""invite_room_state"": [
{
""content"": {
""join_rule"": ""invite""
},
""sender"": ""@neilalexander:synapse.neilalexander.dev"",
""state_key"": """",
""type"": ""m.room.join_rules""
},
{
""content"": {
""name"": ""Test""
},
""sender"": ""@neilalexander:synapse.neilalexander.dev"",
""state_key"": """",
""type"": ""m.room.name""
},
{
""content"": {
""avatar_url"": null,
""displayname"": ""neilalexander (Synapse)"",
""membership"": ""join""
},
""sender"": ""@neilalexander:synapse.neilalexander.dev"",
""state_key"": ""@neilalexander:synapse.neilalexander.dev"",
""type"": ""m.room.member""
}
],
""replaces_state"": ""$8u2LDvw2PQA1j7huGGlQ11_i1vYC_HLvPjyltQul1l0""
}
},
""invite_room_state"": [
{
""content"": {
""join_rule"": ""invite""
},
""sender"": ""@neilalexander:synapse.neilalexander.dev"",
""state_key"": """",
""type"": ""m.room.join_rules""
},
{
""content"": {
""name"": ""Test""
},
""sender"": ""@neilalexander:synapse.neilalexander.dev"",
""state_key"": """",
""type"": ""m.room.name""
},
{
""content"": {
""avatar_url"": null,
""displayname"": ""neilalexander (Synapse)"",
""membership"": ""join""
},
""sender"": ""@neilalexander:synapse.neilalexander.dev"",
""state_key"": ""@neilalexander:synapse.neilalexander.dev"",
""type"": ""m.room.member""
}
],
""room_version"": ""4""
}
```
### Version information
- **Homeserver**: `synapse.neilalexander.dev`
If not matrix.org:
- **Version**: `{""server_version"": ""1.11.0"", ""python_version"": ""3.7.6""}`
- **Install method**: Docker `matrixdotorg/synapse` image ID `d64d49dfd131`
- **Platform**: Linux/VMware Photon OS 3.0 running Docker
",
956,https://api.github.com/repos/matrix-org/synapse/issues/7332,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7332/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7332/comments,https://api.github.com/repos/matrix-org/synapse/issues/7332/events,https://github.com/matrix-org/synapse/pull/7332,605393399,MDExOlB1bGxSZXF1ZXN0NDA3ODAyNjA1,7332,Add information about client delegation,"{'login': 'bit', 'id': 102392, 'node_id': 'MDQ6VXNlcjEwMjM5Mg==', 'avatar_url': 'https://avatars1.githubusercontent.com/u/102392?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bit', 'html_url': 'https://github.com/bit', 'followers_url': 'https://api.github.com/users/bit/followers', 'following_url': 'https://api.github.com/users/bit/following{/other_user}', 'gists_url': 'https://api.github.com/users/bit/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/bit/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/bit/subscriptions', 'organizations_url': 'https://api.github.com/users/bit/orgs', 'repos_url': 'https://api.github.com/users/bit/repos', 'events_url': 'https://api.github.com/users/bit/events{/privacy}', 'received_events_url': 'https://api.github.com/users/bit/received_events', 'type': 'User', 'site_admin': False}","[{'id': 955488836, 'node_id': 'MDU6TGFiZWw5NTU0ODg4MzY=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/awaiting%20changes', 'name': 'awaiting changes', 'color': 'cfe886', 'default': False, 'description': ''}]",closed,False,,[],,5,2020-04-23T09:46:55Z,2020-07-02T16:42:55Z,2020-07-02T16:02:30Z,NONE,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7332', 'html_url': 'https://github.com/matrix-org/synapse/pull/7332', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7332.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7332.patch'}","Delegation also requires .well-known/matrix/client for clients to find the homeserver
",
957,https://api.github.com/repos/matrix-org/synapse/issues/7331,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7331/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7331/comments,https://api.github.com/repos/matrix-org/synapse/issues/7331/events,https://github.com/matrix-org/synapse/issues/7331,605283854,MDU6SXNzdWU2MDUyODM4NTQ=,7331,Unable to restrict room creation to admin only,"{'login': 'DarkRider1768', 'id': 7775608, 'node_id': 'MDQ6VXNlcjc3NzU2MDg=', 'avatar_url': 'https://avatars3.githubusercontent.com/u/7775608?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/DarkRider1768', 'html_url': 'https://github.com/DarkRider1768', 'followers_url': 'https://api.github.com/users/DarkRider1768/followers', 'following_url': 'https://api.github.com/users/DarkRider1768/following{/other_user}', 'gists_url': 'https://api.github.com/users/DarkRider1768/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/DarkRider1768/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/DarkRider1768/subscriptions', 'organizations_url': 'https://api.github.com/users/DarkRider1768/orgs', 'repos_url': 'https://api.github.com/users/DarkRider1768/repos', 'events_url': 'https://api.github.com/users/DarkRider1768/events{/privacy}', 'received_events_url': 'https://api.github.com/users/DarkRider1768/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,3,2020-04-23T06:47:01Z,2020-04-27T13:04:24Z,2020-04-27T13:04:24Z,NONE,,,"Hey all!
Went through and configured a homeserver for testing before I roll it out at work. I'm mirroring the work environment for the test as close as possible to make sure I catch as many gotchas as possible. Well, I hit a big one and I'm glad I found it now rather than later.
We are doing auth via LDAP. As we are an enterprise environment, the upper levels of management are going to want room creation limited to just us admins. Unfortunately, I haven't been able to find a combination of settings that prevent nonadmin users from creating rooms. There is an option to restrict Group creation to admin accounts but that does not seem to impact the creation of rooms.
Any advice on how we can lock this down for management?",
958,https://api.github.com/repos/matrix-org/synapse/issues/7330,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7330/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7330/comments,https://api.github.com/repos/matrix-org/synapse/issues/7330/events,https://github.com/matrix-org/synapse/issues/7330,605253692,MDU6SXNzdWU2MDUyNTM2OTI=,7330,logout/delete specific devices/session,"{'login': 'rozahp', 'id': 16958723, 'node_id': 'MDQ6VXNlcjE2OTU4NzIz', 'avatar_url': 'https://avatars1.githubusercontent.com/u/16958723?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/rozahp', 'html_url': 'https://github.com/rozahp', 'followers_url': 'https://api.github.com/users/rozahp/followers', 'following_url': 'https://api.github.com/users/rozahp/following{/other_user}', 'gists_url': 'https://api.github.com/users/rozahp/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/rozahp/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/rozahp/subscriptions', 'organizations_url': 'https://api.github.com/users/rozahp/orgs', 'repos_url': 'https://api.github.com/users/rozahp/repos', 'events_url': 'https://api.github.com/users/rozahp/events{/privacy}', 'received_events_url': 'https://api.github.com/users/rozahp/received_events', 'type': 'User', 'site_admin': False}","[{'id': 1507817868, 'node_id': 'MDU6TGFiZWwxNTA3ODE3ODY4', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/admin-api', 'name': 'admin-api', 'color': 'e9fc71', 'default': False, 'description': ''}, {'id': 477043174, 'node_id': 'MDU6TGFiZWw0NzcwNDMxNzQ=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/feature', 'name': 'feature', 'color': 'bfd4f2', 'default': False, 'description': None}, {'id': 477050471, 'node_id': 'MDU6TGFiZWw0NzcwNTA0NzE=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/p3', 'name': 'p3', 'color': '0e8a16', 'default': False, 'description': None}]",closed,False,,[],,8,2020-04-23T05:38:24Z,2020-06-05T12:07:23Z,2020-06-05T12:07:23Z,NONE,,,"**Description:**
I administer a matrix homeserver and sometimes login myself and others from different clients and types to test users and rooms. As some rooms are encrypted, this tends to be cumbersome when there are alot of devices to verify. How can one delete some of this devices/sessions?
I would like an API that can deactivate/logout/delete certain/specific session/devices per user. That would be very helpfull for a serveradmin.
Regards.",
959,https://api.github.com/repos/matrix-org/synapse/issues/7329,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7329/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7329/comments,https://api.github.com/repos/matrix-org/synapse/issues/7329/events,https://github.com/matrix-org/synapse/issues/7329,605229595,MDU6SXNzdWU2MDUyMjk1OTU=,7329,Make links to external instance versions of images accessible,"{'login': 'Soundtoxin', 'id': 3146494, 'node_id': 'MDQ6VXNlcjMxNDY0OTQ=', 'avatar_url': 'https://avatars0.githubusercontent.com/u/3146494?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Soundtoxin', 'html_url': 'https://github.com/Soundtoxin', 'followers_url': 'https://api.github.com/users/Soundtoxin/followers', 'following_url': 'https://api.github.com/users/Soundtoxin/following{/other_user}', 'gists_url': 'https://api.github.com/users/Soundtoxin/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/Soundtoxin/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/Soundtoxin/subscriptions', 'organizations_url': 'https://api.github.com/users/Soundtoxin/orgs', 'repos_url': 'https://api.github.com/users/Soundtoxin/repos', 'events_url': 'https://api.github.com/users/Soundtoxin/events{/privacy}', 'received_events_url': 'https://api.github.com/users/Soundtoxin/received_events', 'type': 'User', 'site_admin': False}","[{'id': 477045806, 'node_id': 'MDU6TGFiZWw0NzcwNDU4MDY=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/media-repository', 'name': 'media-repository', 'color': 'ededed', 'default': False, 'description': None}]",closed,False,,[],,1,2020-04-23T04:29:25Z,2020-04-27T16:45:22Z,2020-04-27T16:45:22Z,NONE,,,"**Description:**
I am primarily using chat.weho.st is my matrix instance. The file size limit is 10MB. I work with it, I'm used to it. Many of my friends are on matrix.org which has either no limit or just a really big one. Sometimes they post a picture (often from a high quality camera) that is over 10MB. On my end the image never shows up, I can't access it, if I click the download link it shows me a file-size error in another tab. However, the link to the matrix.org version of the image is public. I just can't see it myself. I have another account on matrix.org. If I log in there and see the image, I can copy/paste the link and then open it from the other side. I also confirmed it doesn't just work because I'm signed into matrix.org as well by opening it with mpv+youtube-dl, demonstrating authentication is not needed. Basically, why can't I just access that link from my weho.st account? Why do I get a different link if it's just not going to work anyway?
FYI I am using Riot in a web browser for both instances.
Apologies in advance if this isn't the place / category to file this under. Feel free to move/remake anything.
A good example of this sort of thing being implemented is on the activitypub-based fediverse. I see local versions of posts and images, but I can also hit a button to view the version from the source instance, so there is a precedent for something like this.
https://chat.weho.st/_matrix/media/r0/download/matrix.org/gbVznlYjOOfEupMmKduusCYX
![2020-04-22-232719_grim](https://user-images.githubusercontent.com/3146494/80059192-f1aebe80-84f0-11ea-9084-7c8d203d6746.png)
https://matrix-client.matrix.org/_matrix/media/r0/download/matrix.org/gbVznlYjOOfEupMmKduusCYX
![2020-04-22-232747_grim](https://user-images.githubusercontent.com/3146494/80059195-f5424580-84f0-11ea-918e-9fec1e08ec91.png)
",
960,https://api.github.com/repos/matrix-org/synapse/issues/7328,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7328/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7328/comments,https://api.github.com/repos/matrix-org/synapse/issues/7328/events,https://github.com/matrix-org/synapse/pull/7328,605102814,MDExOlB1bGxSZXF1ZXN0NDA3NTcwNjM4,7328,debugging for flaky guest user test,"{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,1,2020-04-22T22:01:31Z,2020-05-15T17:32:36Z,2020-05-15T17:32:36Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7328', 'html_url': 'https://github.com/matrix-org/synapse/pull/7328', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7328.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7328.patch'}",,
961,https://api.github.com/repos/matrix-org/synapse/issues/7327,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7327/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7327/comments,https://api.github.com/repos/matrix-org/synapse/issues/7327/events,https://github.com/matrix-org/synapse/pull/7327,604967015,MDExOlB1bGxSZXF1ZXN0NDA3NDU5ODY4,7327,"Unflake ""Guest user can set display names""","{'login': 'anoadragon453', 'id': 1342360, 'node_id': 'MDQ6VXNlcjEzNDIzNjA=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1342360?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/anoadragon453', 'html_url': 'https://github.com/anoadragon453', 'followers_url': 'https://api.github.com/users/anoadragon453/followers', 'following_url': 'https://api.github.com/users/anoadragon453/following{/other_user}', 'gists_url': 'https://api.github.com/users/anoadragon453/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/anoadragon453/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/anoadragon453/subscriptions', 'organizations_url': 'https://api.github.com/users/anoadragon453/orgs', 'repos_url': 'https://api.github.com/users/anoadragon453/repos', 'events_url': 'https://api.github.com/users/anoadragon453/events{/privacy}', 'received_events_url': 'https://api.github.com/users/anoadragon453/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,1,2020-04-22T18:23:34Z,2020-05-15T18:12:30Z,2020-05-15T17:29:31Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7327', 'html_url': 'https://github.com/matrix-org/synapse/pull/7327', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7327.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7327.patch'}","After my [investigation](https://github.com/matrix-org/sytest/issues/836#issuecomment-612663357), I found that setting the max cache entries for `get_latest_event_ids_in_room` to 0 unflaked this test, meaning that there was somewhere we weren't invalidating this cache when we should've been.
I couldn't find anywhere where we did so after a membership change, so I've added the appropriate line. I'd appreciate feedback on this as I don't have a complete understanding of the replication code.",
962,https://api.github.com/repos/matrix-org/synapse/issues/7326,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7326/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7326/comments,https://api.github.com/repos/matrix-org/synapse/issues/7326/events,https://github.com/matrix-org/synapse/pull/7326,604741028,MDExOlB1bGxSZXF1ZXN0NDA3Mjc2OTE0,7326,Another go at fixing one-word replication commands,"{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,0,2020-04-22T13:04:23Z,2020-04-22T13:34:33Z,2020-04-22T13:34:32Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7326', 'html_url': 'https://github.com/matrix-org/synapse/pull/7326', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7326.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7326.patch'}",I messed this up last time I tried (#7239 / e13c6c7).,
963,https://api.github.com/repos/matrix-org/synapse/issues/7325,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7325/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7325/comments,https://api.github.com/repos/matrix-org/synapse/issues/7325/events,https://github.com/matrix-org/synapse/pull/7325,604737064,MDExOlB1bGxSZXF1ZXN0NDA3MjczNjYy,7325,Fix replication metrics when using redis,"{'login': 'erikjohnston', 'id': 8428120, 'node_id': 'MDQ6VXNlcjg0MjgxMjA=', 'avatar_url': 'https://avatars0.githubusercontent.com/u/8428120?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/erikjohnston', 'html_url': 'https://github.com/erikjohnston', 'followers_url': 'https://api.github.com/users/erikjohnston/followers', 'following_url': 'https://api.github.com/users/erikjohnston/following{/other_user}', 'gists_url': 'https://api.github.com/users/erikjohnston/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/erikjohnston/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/erikjohnston/subscriptions', 'organizations_url': 'https://api.github.com/users/erikjohnston/orgs', 'repos_url': 'https://api.github.com/users/erikjohnston/repos', 'events_url': 'https://api.github.com/users/erikjohnston/events{/privacy}', 'received_events_url': 'https://api.github.com/users/erikjohnston/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,"{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}","[{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}]",,0,2020-04-22T12:58:23Z,2020-04-22T15:26:21Z,2020-04-22T15:26:20Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7325', 'html_url': 'https://github.com/matrix-org/synapse/pull/7325', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7325.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7325.patch'}",,
964,https://api.github.com/repos/matrix-org/synapse/issues/7324,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7324/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7324/comments,https://api.github.com/repos/matrix-org/synapse/issues/7324/events,https://github.com/matrix-org/synapse/pull/7324,604541541,MDExOlB1bGxSZXF1ZXN0NDA3MTE2MDI5,7324,reCaptcha docs: add note about vector-domain,"{'login': 'andreasnuesslein', 'id': 320080, 'node_id': 'MDQ6VXNlcjMyMDA4MA==', 'avatar_url': 'https://avatars3.githubusercontent.com/u/320080?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/andreasnuesslein', 'html_url': 'https://github.com/andreasnuesslein', 'followers_url': 'https://api.github.com/users/andreasnuesslein/followers', 'following_url': 'https://api.github.com/users/andreasnuesslein/following{/other_user}', 'gists_url': 'https://api.github.com/users/andreasnuesslein/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/andreasnuesslein/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/andreasnuesslein/subscriptions', 'organizations_url': 'https://api.github.com/users/andreasnuesslein/orgs', 'repos_url': 'https://api.github.com/users/andreasnuesslein/repos', 'events_url': 'https://api.github.com/users/andreasnuesslein/events{/privacy}', 'received_events_url': 'https://api.github.com/users/andreasnuesslein/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,3,2020-04-22T07:59:54Z,2020-04-26T12:45:26Z,2020-04-26T09:38:02Z,NONE,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7324', 'html_url': 'https://github.com/matrix-org/synapse/pull/7324', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7324.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7324.patch'}","I'm not sure this place in the docs is correct because I get that there are other matrix clients and this is a very specific clients need.
But a) most people are probably using Riot as of now and b) from Riots perspective there is no documentation on Captcha because it's not really their scope either.
PS: I didnt work through the codying style etc checkboxes because this only concerns docs. Hope that's okay?
PPS: https://github.com/vector-im/riot-web/issues/13307 here's a ticket about this",
965,https://api.github.com/repos/matrix-org/synapse/issues/7323,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7323/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7323/comments,https://api.github.com/repos/matrix-org/synapse/issues/7323/events,https://github.com/matrix-org/synapse/pull/7323,604410620,MDExOlB1bGxSZXF1ZXN0NDA3MDEwNDM5,7323,Add a note about REPLICATE requiring a single space,"{'login': 'turt2live', 'id': 1190097, 'node_id': 'MDQ6VXNlcjExOTAwOTc=', 'avatar_url': 'https://avatars2.githubusercontent.com/u/1190097?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/turt2live', 'html_url': 'https://github.com/turt2live', 'followers_url': 'https://api.github.com/users/turt2live/followers', 'following_url': 'https://api.github.com/users/turt2live/following{/other_user}', 'gists_url': 'https://api.github.com/users/turt2live/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/turt2live/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/turt2live/subscriptions', 'organizations_url': 'https://api.github.com/users/turt2live/orgs', 'repos_url': 'https://api.github.com/users/turt2live/repos', 'events_url': 'https://api.github.com/users/turt2live/events{/privacy}', 'received_events_url': 'https://api.github.com/users/turt2live/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,3,2020-04-22T02:44:17Z,2020-04-22T14:07:01Z,2020-04-22T13:05:04Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7323', 'html_url': 'https://github.com/matrix-org/synapse/pull/7323', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7323.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7323.patch'}","Otherwise errors happen server-side. A more correct fix might be to just remove the requirement, though given this is the only command which shows up bare it's probably fine to just document it instead.
The error, for reference:
```
2020-04-22 02:41:58,808 - twisted - 192 - CRITICAL - - Unhandled Error
Traceback (most recent call last):
File ""/home/matrix/.synapse/local/lib/python3.6/site-packages/twisted/python/log.py"", line 103, in callWithLogger
return callWithContext({""system"": lp}, func, *args, **kw)
File ""/home/matrix/.synapse/local/lib/python3.6/site-packages/twisted/python/log.py"", line 86, in callWithContext
return context.call({ILogContext: newCtx}, func, *args, **kw)
File ""/home/matrix/.synapse/local/lib/python3.6/site-packages/twisted/python/context.py"", line 122, in callWithContext
return self.currentContext().callWithContext(ctx, func, *args, **kw)
File ""/home/matrix/.synapse/local/lib/python3.6/site-packages/twisted/python/context.py"", line 85, in callWithContext
return func(*args,**kw)
--- ---
File ""/home/matrix/.synapse/local/lib/python3.6/site-packages/twisted/internet/posixbase.py"", line 614, in _doReadOrWrite
why = selectable.doRead()
File ""/home/matrix/.synapse/local/lib/python3.6/site-packages/twisted/internet/tcp.py"", line 243, in doRead
return self._dataReceived(data)
File ""/home/matrix/.synapse/local/lib/python3.6/site-packages/twisted/internet/tcp.py"", line 249, in _dataReceived
rval = self.protocol.dataReceived(data)
File ""/home/matrix/.synapse/local/lib/python3.6/site-packages/twisted/protocols/basic.py"", line 454, in dataReceived
self.lineReceived(line)
File ""/home/matrix/.synapse/local/lib/python3.6/site-packages/synapse/replication/tcp/protocol.py"", line 214, in lineReceived
idx = linestr.index("" "")
builtins.ValueError: substring not found
```
This behaviour was added in https://github.com/matrix-org/synapse/pull/7024
### Pull Request Checklist
* [x] Pull request is based on the develop branch
* [x] Pull request includes a [changelog file](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#changelog). The entry should:
- Be a short description of your change which makes sense to users. ""Fixed a bug that prevented receiving messages from other servers."" instead of ""Moved X method from `EventStore` to `EventWorkerStore`."".
- Use markdown where necessary, mostly for `code blocks`.
- End with either a period (.) or an exclamation mark (!).
- Start with a capital letter.
* [x] Pull request includes a [sign off](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#sign-off)
* [x] Code style is correct (run the [linters](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#code-style))
Done with a community hat on:
```
Signed-off-by: Travis Ralston
```",
966,https://api.github.com/repos/matrix-org/synapse/issues/7322,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7322/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7322/comments,https://api.github.com/repos/matrix-org/synapse/issues/7322/events,https://github.com/matrix-org/synapse/issues/7322,604402289,MDU6SXNzdWU2MDQ0MDIyODk=,7322,improve error handling in /etc/matrix-synapse/conf.d,"{'login': 'pedro-nonfree', 'id': 39959198, 'node_id': 'MDQ6VXNlcjM5OTU5MTk4', 'avatar_url': 'https://avatars2.githubusercontent.com/u/39959198?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/pedro-nonfree', 'html_url': 'https://github.com/pedro-nonfree', 'followers_url': 'https://api.github.com/users/pedro-nonfree/followers', 'following_url': 'https://api.github.com/users/pedro-nonfree/following{/other_user}', 'gists_url': 'https://api.github.com/users/pedro-nonfree/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/pedro-nonfree/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/pedro-nonfree/subscriptions', 'organizations_url': 'https://api.github.com/users/pedro-nonfree/orgs', 'repos_url': 'https://api.github.com/users/pedro-nonfree/repos', 'events_url': 'https://api.github.com/users/pedro-nonfree/events{/privacy}', 'received_events_url': 'https://api.github.com/users/pedro-nonfree/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,4,2020-04-22T02:22:41Z,2020-04-27T13:01:58Z,2020-04-27T13:01:58Z,NONE,,,"### Description
`/etc/matrix-synapse/conf.d` is an important section because there you can do whatever you want and upgrade debian-based package for matrix in a good manner
### Steps to reproduce
```
cd /etc/matrix-synapse/conf.d
touch test1
systemctl restart matrix-synapse
```
OK?
```
cd /etc/matrix-synapse/conf.d
touch test2.yaml
systemctl restart matrix-synapse
```
FAILS (it also files if all lines in that file are commented), error says
```
matrix-synapse[23419]: Traceback (most recent call last):
matrix-synapse[23419]: File ""/usr/lib/python3.5/runpy.py"", line 193, in _run_module_as_main
matrix-synapse[23419]: ""__main__"", mod_spec)
matrix-synapse[23419]: File ""/usr/lib/python3.5/runpy.py"", line 85, in _run_code
matrix-synapse[23419]: exec(code, run_globals)
matrix-synapse[23419]: File ""/opt/venvs/matrix-synapse/lib/python3.5/site-packages/synapse/app/homeserver.py"", line 651, in
matrix-synapse[23419]: main()
matrix-synapse[23419]: File ""/opt/venvs/matrix-synapse/lib/python3.5/site-packages/synapse/app/homeserver.py"", line 646, in main
matrix-synapse[23419]: hs = setup(sys.argv[1:])
matrix-synapse[23419]: File ""/opt/venvs/matrix-synapse/lib/python3.5/site-packages/synapse/app/homeserver.py"", line 324, in setup
matrix-synapse[23419]: ""Synapse Homeserver"", config_options
matrix-synapse[23419]: File ""/opt/venvs/matrix-synapse/lib/python3.5/site-packages/synapse/config/_base.py"", line 623, in load_or_generate_config
matrix-synapse[23419]: config_dict = read_config_files(config_files)
matrix-synapse[23419]: File ""/opt/venvs/matrix-synapse/lib/python3.5/site-packages/synapse/config/_base.py"", line 670, in read_config_files
matrix-synapse[23419]: specified_config.update(yaml_config)
matrix-synapse[23419]: TypeError: 'NoneType' object is not iterable
systemd[1]: matrix-synapse.service: Control process exited, code=exited, status=1/FAILURE
systemd[1]: matrix-synapse.service: Failed with result 'exit-code'.
systemd[1]: Failed to start Synapse Matrix homeserver.
```
```
cd /etc/matrix-synapse/conf.d
touch test3.yml
systemctl restart matrix-synapse
```
OK? I have a question, how can I verify that the running synapse has my variable enabled? Maybe this file is not taken in account by synapse
### Version information
- **Homeserver**: matrix.guifi.net
- **Version**:
```
curl http://localhost:8008/_synapse/admin/v1/server_version
{
""python_version"": ""3.5.3"",
""server_version"": ""1.12.3""
}
```
- **Install method**: debian package
- **Platform**: debian stable 10 buster proxmox VM",
967,https://api.github.com/repos/matrix-org/synapse/issues/7321,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7321/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7321/comments,https://api.github.com/repos/matrix-org/synapse/issues/7321/events,https://github.com/matrix-org/synapse/pull/7321,604246844,MDExOlB1bGxSZXF1ZXN0NDA2ODc2NzU0,7321,Reduce federation logging on success,"{'login': 'michaelkaye', 'id': 1917473, 'node_id': 'MDQ6VXNlcjE5MTc0NzM=', 'avatar_url': 'https://avatars0.githubusercontent.com/u/1917473?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/michaelkaye', 'html_url': 'https://github.com/michaelkaye', 'followers_url': 'https://api.github.com/users/michaelkaye/followers', 'following_url': 'https://api.github.com/users/michaelkaye/following{/other_user}', 'gists_url': 'https://api.github.com/users/michaelkaye/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/michaelkaye/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/michaelkaye/subscriptions', 'organizations_url': 'https://api.github.com/users/michaelkaye/orgs', 'repos_url': 'https://api.github.com/users/michaelkaye/repos', 'events_url': 'https://api.github.com/users/michaelkaye/events{/privacy}', 'received_events_url': 'https://api.github.com/users/michaelkaye/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,0,2020-04-21T19:58:02Z,2020-04-22T10:18:20Z,2020-04-22T10:18:19Z,CONTRIBUTOR,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7321', 'html_url': 'https://github.com/matrix-org/synapse/pull/7321', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7321.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7321.patch'}","When we successfully transmit over federation we log the following lines:
```
2020-04-21 00:00:25,111 - synapse.http.matrixfederationclient - 442 - INFO - federation_transaction_transmission_loop-15561448 - {PUT-O-13904925} [matrix.hostname] Got response headers: 200 OK
2020-04-21 00:00:25,111 - synapse.http.matrixfederationclient - 164 - INFO - federation_transaction_transmission_loop-15561448 - {PUT-O-13904925} [matrix.hostname] Completed: 200 OK
2020-04-21 00:00:25,112 - synapse.federation.sender.transaction_manager - 150 - INFO - federation_transaction_transmission_loop-15561448 - TX [matrix.hostname] {1587140000000} got 200 response
```
Looking at this, we are logging the same data three different ways, during the successful flow. Only about 0.5% of these log lines do not contain ""200 OK"". Moving just one of these lines to debug allows them to be filtered out, and with the matrix.org logs, this would save about 15% of the log lines written to this file each day, while still retaining the failures and retries if needed.
",
968,https://api.github.com/repos/matrix-org/synapse/issues/7320,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7320/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7320/comments,https://api.github.com/repos/matrix-org/synapse/issues/7320/events,https://github.com/matrix-org/synapse/issues/7320,604200236,MDU6SXNzdWU2MDQyMDAyMzY=,7320,Creating and deleting aliases could be more consistent,"{'login': 'clokep', 'id': 517124, 'node_id': 'MDQ6VXNlcjUxNzEyNA==', 'avatar_url': 'https://avatars2.githubusercontent.com/u/517124?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/clokep', 'html_url': 'https://github.com/clokep', 'followers_url': 'https://api.github.com/users/clokep/followers', 'following_url': 'https://api.github.com/users/clokep/following{/other_user}', 'gists_url': 'https://api.github.com/users/clokep/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/clokep/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/clokep/subscriptions', 'organizations_url': 'https://api.github.com/users/clokep/orgs', 'repos_url': 'https://api.github.com/users/clokep/repos', 'events_url': 'https://api.github.com/users/clokep/events{/privacy}', 'received_events_url': 'https://api.github.com/users/clokep/received_events', 'type': 'User', 'site_admin': False}","[{'id': 477050471, 'node_id': 'MDU6TGFiZWw0NzcwNTA0NzE=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/p3', 'name': 'p3', 'color': '0e8a16', 'default': False, 'description': None}]",open,False,,[],,0,2020-04-21T18:40:41Z,2020-04-21T18:40:41Z,,MEMBER,,,"This is the promised follow-up to #7052 about how to creating and deleting aliases could be more consistent. In general these are implemented via the `create_association` and `delete_association` methods of `DirectoryHandler`.
The checks done for each of these (copied from #7052 and clarified a bit) below. They're a bit confusing (and maybe make more sense as the flow-charts I wrote out), but the overall checks aren't too complicated.
### Creation
1. Check if the length is valid.
1. If `require_membership_for_aliases` is true in the config, the creator must be in the room or be a server admin.
2. The spam checker's `user_may_create_room_alias` method is queried.
3. The `alias_creation_rules` are checked from the config.
4. Services are checked to see whether they have an ""exclusive lock"" on an alias.
### Deletion
1. Ensure that the user is the room creator, if one exists.
2. Ensure that the alias points to a room ID.
3. The user must be one of the following:
1. A server admin.
2. In the room and have sufficient power level to delete an alias (>= moderator).
5. Services are checked to see whether the have an ""exclusive lock"" on an alias.
## Potential improvements
There aren't too many changes I came up with, but see ideas below:
1. Check `require_room_membership_for_aliases` during alias deletion.
2. Ensure that a user has the proper power level during creation (but that probably only makes sense for the canonical alias, which already happens).
There's a chance that some of the code could be re-used by combining some of the checks, but probably not. Frankly this might just be good enough the way it is.",
969,https://api.github.com/repos/matrix-org/synapse/issues/7319,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7319/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7319/comments,https://api.github.com/repos/matrix-org/synapse/issues/7319/events,https://github.com/matrix-org/synapse/pull/7319,604180330,MDExOlB1bGxSZXF1ZXN0NDA2ODIyMzM3,7319,import urllib.parse when using urllib.parse.quote,"{'login': 'anoadragon453', 'id': 1342360, 'node_id': 'MDQ6VXNlcjEzNDIzNjA=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1342360?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/anoadragon453', 'html_url': 'https://github.com/anoadragon453', 'followers_url': 'https://api.github.com/users/anoadragon453/followers', 'following_url': 'https://api.github.com/users/anoadragon453/following{/other_user}', 'gists_url': 'https://api.github.com/users/anoadragon453/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/anoadragon453/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/anoadragon453/subscriptions', 'organizations_url': 'https://api.github.com/users/anoadragon453/orgs', 'repos_url': 'https://api.github.com/users/anoadragon453/repos', 'events_url': 'https://api.github.com/users/anoadragon453/events{/privacy}', 'received_events_url': 'https://api.github.com/users/anoadragon453/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,0,2020-04-21T18:06:54Z,2020-04-22T11:18:53Z,2020-04-22T11:18:52Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7319', 'html_url': 'https://github.com/matrix-org/synapse/pull/7319', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7319.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7319.patch'}","We were using `urllib.parse.quote` but only importing `urllib`. Afaik that doesn't work:
```
❯ python
Python 3.8.2 (default, Apr 8 2020, 14:31:25)
[GCC 9.3.0] on linux
Type ""help"", ""copyright"", ""credits"" or ""license"" for more information.
>>> import urllib
>>> urllib.parse.quote(""asd"")
Traceback (most recent call last):
File """", line 1, in
AttributeError: module 'urllib' has no attribute 'parse'
>>> import urllib.parse
>>> urllib.parse.quote(""asd"")
'asd'
>>>
```
Broke in https://github.com/matrix-org/synapse/commit/40fb00f5b7a8a9df15169900df218df19423b93e
~~It looks like this would break email registration in Riot, as afaik we use `next_link` there :thinking: However testing, registration on matrix.org via email definitely still works.~~
It's due to the fact that we `import urllib.parse` elsewhere in the codebase. Still, if that ever were to be removed, this would break.",
970,https://api.github.com/repos/matrix-org/synapse/issues/7318,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7318/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7318/comments,https://api.github.com/repos/matrix-org/synapse/issues/7318/events,https://github.com/matrix-org/synapse/pull/7318,604175494,MDExOlB1bGxSZXF1ZXN0NDA2ODE4NTAy,7318,Stop the master relaying USER_SYNC for other workers,"{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,"{'login': 'clokep', 'id': 517124, 'node_id': 'MDQ6VXNlcjUxNzEyNA==', 'avatar_url': 'https://avatars2.githubusercontent.com/u/517124?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/clokep', 'html_url': 'https://github.com/clokep', 'followers_url': 'https://api.github.com/users/clokep/followers', 'following_url': 'https://api.github.com/users/clokep/following{/other_user}', 'gists_url': 'https://api.github.com/users/clokep/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/clokep/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/clokep/subscriptions', 'organizations_url': 'https://api.github.com/users/clokep/orgs', 'repos_url': 'https://api.github.com/users/clokep/repos', 'events_url': 'https://api.github.com/users/clokep/events{/privacy}', 'received_events_url': 'https://api.github.com/users/clokep/received_events', 'type': 'User', 'site_admin': False}","[{'login': 'clokep', 'id': 517124, 'node_id': 'MDQ6VXNlcjUxNzEyNA==', 'avatar_url': 'https://avatars2.githubusercontent.com/u/517124?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/clokep', 'html_url': 'https://github.com/clokep', 'followers_url': 'https://api.github.com/users/clokep/followers', 'following_url': 'https://api.github.com/users/clokep/following{/other_user}', 'gists_url': 'https://api.github.com/users/clokep/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/clokep/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/clokep/subscriptions', 'organizations_url': 'https://api.github.com/users/clokep/orgs', 'repos_url': 'https://api.github.com/users/clokep/repos', 'events_url': 'https://api.github.com/users/clokep/events{/privacy}', 'received_events_url': 'https://api.github.com/users/clokep/received_events', 'type': 'User', 'site_admin': False}]",,2,2020-04-21T17:58:42Z,2020-04-22T21:39:06Z,2020-04-22T21:39:05Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7318', 'html_url': 'https://github.com/matrix-org/synapse/pull/7318', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7318.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7318.patch'}","Long story short: if we're handling presence on the current worker, we shouldn't be sending USER_SYNC commands over replication.
In an attempt to figure out what is going on here, I ended up refactoring some bits of the presencehandler code, so the first 4 commits here are non-functional refactors to move this code slightly closer to sanity. (There's still plenty to do here :/). Suggest reviewing individual commits.
Fixes (I hope) #7257.",
971,https://api.github.com/repos/matrix-org/synapse/issues/7317,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7317/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7317/comments,https://api.github.com/repos/matrix-org/synapse/issues/7317/events,https://github.com/matrix-org/synapse/pull/7317,604160631,MDExOlB1bGxSZXF1ZXN0NDA2ODA2NjA5,7317,Add room details admin endpoint,"{'login': 'awesome-manuel', 'id': 37705355, 'node_id': 'MDQ6VXNlcjM3NzA1MzU1', 'avatar_url': 'https://avatars0.githubusercontent.com/u/37705355?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/awesome-manuel', 'html_url': 'https://github.com/awesome-manuel', 'followers_url': 'https://api.github.com/users/awesome-manuel/followers', 'following_url': 'https://api.github.com/users/awesome-manuel/following{/other_user}', 'gists_url': 'https://api.github.com/users/awesome-manuel/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/awesome-manuel/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/awesome-manuel/subscriptions', 'organizations_url': 'https://api.github.com/users/awesome-manuel/orgs', 'repos_url': 'https://api.github.com/users/awesome-manuel/repos', 'events_url': 'https://api.github.com/users/awesome-manuel/events{/privacy}', 'received_events_url': 'https://api.github.com/users/awesome-manuel/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,10,2020-04-21T17:35:06Z,2020-05-11T19:14:02Z,2020-05-07T19:33:07Z,CONTRIBUTOR,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7317', 'html_url': 'https://github.com/matrix-org/synapse/pull/7317', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7317.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7317.patch'}","### Pull Request Checklist
* [x] Pull request is based on the develop branch
* [x] Pull request includes a [changelog file](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#changelog). The entry should:
- Be a short description of your change which makes sense to users. ""Fixed a bug that prevented receiving messages from other servers."" instead of ""Moved X method from `EventStore` to `EventWorkerStore`."".
- Use markdown where necessary, mostly for `code blocks`.
- End with either a period (.) or an exclamation mark (!).
- Start with a capital letter.
* [x] Pull request includes a [sign off](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#sign-off)
* [x] Code style is correct (run the [linters](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#code-style))
",
972,https://api.github.com/repos/matrix-org/synapse/issues/7316,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7316/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7316/comments,https://api.github.com/repos/matrix-org/synapse/issues/7316/events,https://github.com/matrix-org/synapse/pull/7316,604136195,MDExOlB1bGxSZXF1ZXN0NDA2Nzg2ODA1,7316,Fix fallback value for account_threepid_delegates.email,"{'login': 'anoadragon453', 'id': 1342360, 'node_id': 'MDQ6VXNlcjEzNDIzNjA=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1342360?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/anoadragon453', 'html_url': 'https://github.com/anoadragon453', 'followers_url': 'https://api.github.com/users/anoadragon453/followers', 'following_url': 'https://api.github.com/users/anoadragon453/following{/other_user}', 'gists_url': 'https://api.github.com/users/anoadragon453/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/anoadragon453/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/anoadragon453/subscriptions', 'organizations_url': 'https://api.github.com/users/anoadragon453/orgs', 'repos_url': 'https://api.github.com/users/anoadragon453/repos', 'events_url': 'https://api.github.com/users/anoadragon453/events{/privacy}', 'received_events_url': 'https://api.github.com/users/anoadragon453/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,"{'login': 'anoadragon453', 'id': 1342360, 'node_id': 'MDQ6VXNlcjEzNDIzNjA=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1342360?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/anoadragon453', 'html_url': 'https://github.com/anoadragon453', 'followers_url': 'https://api.github.com/users/anoadragon453/followers', 'following_url': 'https://api.github.com/users/anoadragon453/following{/other_user}', 'gists_url': 'https://api.github.com/users/anoadragon453/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/anoadragon453/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/anoadragon453/subscriptions', 'organizations_url': 'https://api.github.com/users/anoadragon453/orgs', 'repos_url': 'https://api.github.com/users/anoadragon453/repos', 'events_url': 'https://api.github.com/users/anoadragon453/events{/privacy}', 'received_events_url': 'https://api.github.com/users/anoadragon453/received_events', 'type': 'User', 'site_admin': False}","[{'login': 'anoadragon453', 'id': 1342360, 'node_id': 'MDQ6VXNlcjEzNDIzNjA=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1342360?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/anoadragon453', 'html_url': 'https://github.com/anoadragon453', 'followers_url': 'https://api.github.com/users/anoadragon453/followers', 'following_url': 'https://api.github.com/users/anoadragon453/following{/other_user}', 'gists_url': 'https://api.github.com/users/anoadragon453/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/anoadragon453/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/anoadragon453/subscriptions', 'organizations_url': 'https://api.github.com/users/anoadragon453/orgs', 'repos_url': 'https://api.github.com/users/anoadragon453/repos', 'events_url': 'https://api.github.com/users/anoadragon453/events{/privacy}', 'received_events_url': 'https://api.github.com/users/anoadragon453/received_events', 'type': 'User', 'site_admin': False}]",,0,2020-04-21T17:00:13Z,2020-04-29T10:30:08Z,2020-04-29T10:30:07Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7316', 'html_url': 'https://github.com/matrix-org/synapse/pull/7316', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7316.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7316.patch'}","Config option `account_threepid_delegates.email` is expected to be a URL to a identity server, *including* the protocol scheme (https://).
In part of deprecating `trusted_third_party_id_servers`, we state that if `account_threepid_delegates` has not been set, and `trusted_third_party_id_servers` is, then we use the first value from that list as the value for `account_threepid_delegates.email`.
Unfortunately, values from `trusted_third_party_id_servers` do not have a protocol scheme (ex. `example.com`), where `account_threepid_delegates.email` is expected to have a protocol scheme( ex. `https://example.com`).
So this fallback wouldn't have worked. This patch fixes things to presume `https://` for the URL.",
973,https://api.github.com/repos/matrix-org/synapse/issues/7315,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7315/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7315/comments,https://api.github.com/repos/matrix-org/synapse/issues/7315/events,https://github.com/matrix-org/synapse/pull/7315,604130912,MDExOlB1bGxSZXF1ZXN0NDA2NzgyNTE5,7315,Config option to inhibit 3PID errors on /requestToken,"{'login': 'babolivier', 'id': 5547783, 'node_id': 'MDQ6VXNlcjU1NDc3ODM=', 'avatar_url': 'https://avatars3.githubusercontent.com/u/5547783?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/babolivier', 'html_url': 'https://github.com/babolivier', 'followers_url': 'https://api.github.com/users/babolivier/followers', 'following_url': 'https://api.github.com/users/babolivier/following{/other_user}', 'gists_url': 'https://api.github.com/users/babolivier/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/babolivier/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/babolivier/subscriptions', 'organizations_url': 'https://api.github.com/users/babolivier/orgs', 'repos_url': 'https://api.github.com/users/babolivier/repos', 'events_url': 'https://api.github.com/users/babolivier/events{/privacy}', 'received_events_url': 'https://api.github.com/users/babolivier/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,1,2020-04-21T16:52:54Z,2020-04-23T09:32:18Z,2020-04-23T08:38:58Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7315', 'html_url': 'https://github.com/matrix-org/synapse/pull/7315', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7315.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7315.patch'}","Adds a `request_token_inhibit_errors` configuration flag (disabled by default) which, if enabled, change the behaviour of all `/requestToken` endpoints so that they return a 200 and a fake `sid` if the 3PID was/was not found associated with an account (depending on the endpoint), instead of an error.",
974,https://api.github.com/repos/matrix-org/synapse/issues/7314,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7314/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7314/comments,https://api.github.com/repos/matrix-org/synapse/issues/7314/events,https://github.com/matrix-org/synapse/pull/7314,604090081,MDExOlB1bGxSZXF1ZXN0NDA2NzQ5NDg0,7314,Allow guests to operate in encrypted rooms,"{'login': 'awesome-michael', 'id': 37796947, 'node_id': 'MDQ6VXNlcjM3Nzk2OTQ3', 'avatar_url': 'https://avatars3.githubusercontent.com/u/37796947?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/awesome-michael', 'html_url': 'https://github.com/awesome-michael', 'followers_url': 'https://api.github.com/users/awesome-michael/followers', 'following_url': 'https://api.github.com/users/awesome-michael/following{/other_user}', 'gists_url': 'https://api.github.com/users/awesome-michael/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/awesome-michael/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/awesome-michael/subscriptions', 'organizations_url': 'https://api.github.com/users/awesome-michael/orgs', 'repos_url': 'https://api.github.com/users/awesome-michael/repos', 'events_url': 'https://api.github.com/users/awesome-michael/events{/privacy}', 'received_events_url': 'https://api.github.com/users/awesome-michael/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,14,2020-04-21T15:30:07Z,2020-08-03T11:13:50Z,2020-08-03T11:13:50Z,CONTRIBUTOR,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7314', 'html_url': 'https://github.com/matrix-org/synapse/pull/7314', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7314.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7314.patch'}","Guests are not able to operate in encrypted rooms and keep getting lots of errors. These changes enable the guests to write in encrypted rooms. I think one problem is that the guest was not allowed to get the member list of the room and therefore had no list which encryption keys he has to request to encrypt his message properly.
Honestly I'm not sure why I needed the change in the events.py file. I tested this configuration and guests can write and read in encrypted rooms now.
### Pull Request Checklist
* [x] Pull request is based on the develop branch
* [x] Pull request includes a [changelog file](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#changelog). The entry should:
- Be a short description of your change which makes sense to users. ""Fixed a bug that prevented receiving messages from other servers."" instead of ""Moved X method from `EventStore` to `EventWorkerStore`."".
- Use markdown where necessary, mostly for `code blocks`.
- End with either a period (.) or an exclamation mark (!).
- Start with a capital letter.
* [x] Pull request includes a [sign off](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#sign-off)
* [x] Code style is correct (run the [linters](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#code-style))
Signed-off-by: Michael Albert ",
975,https://api.github.com/repos/matrix-org/synapse/issues/7313,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7313/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7313/comments,https://api.github.com/repos/matrix-org/synapse/issues/7313/events,https://github.com/matrix-org/synapse/issues/7313,603998404,MDU6SXNzdWU2MDM5OTg0MDQ=,7313,frontend_proxy worker should be able to handle OPTIONS for /_matrix/media requests,"{'login': 'michaelkaye', 'id': 1917473, 'node_id': 'MDQ6VXNlcjE5MTc0NzM=', 'avatar_url': 'https://avatars0.githubusercontent.com/u/1917473?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/michaelkaye', 'html_url': 'https://github.com/michaelkaye', 'followers_url': 'https://api.github.com/users/michaelkaye/followers', 'following_url': 'https://api.github.com/users/michaelkaye/following{/other_user}', 'gists_url': 'https://api.github.com/users/michaelkaye/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/michaelkaye/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/michaelkaye/subscriptions', 'organizations_url': 'https://api.github.com/users/michaelkaye/orgs', 'repos_url': 'https://api.github.com/users/michaelkaye/repos', 'events_url': 'https://api.github.com/users/michaelkaye/events{/privacy}', 'received_events_url': 'https://api.github.com/users/michaelkaye/received_events', 'type': 'User', 'site_admin': False}","[{'id': 477045806, 'node_id': 'MDU6TGFiZWw0NzcwNDU4MDY=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/media-repository', 'name': 'media-repository', 'color': 'ededed', 'default': False, 'description': None}]",closed,False,"{'login': 'clokep', 'id': 517124, 'node_id': 'MDQ6VXNlcjUxNzEyNA==', 'avatar_url': 'https://avatars2.githubusercontent.com/u/517124?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/clokep', 'html_url': 'https://github.com/clokep', 'followers_url': 'https://api.github.com/users/clokep/followers', 'following_url': 'https://api.github.com/users/clokep/following{/other_user}', 'gists_url': 'https://api.github.com/users/clokep/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/clokep/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/clokep/subscriptions', 'organizations_url': 'https://api.github.com/users/clokep/orgs', 'repos_url': 'https://api.github.com/users/clokep/repos', 'events_url': 'https://api.github.com/users/clokep/events{/privacy}', 'received_events_url': 'https://api.github.com/users/clokep/received_events', 'type': 'User', 'site_admin': False}","[{'login': 'clokep', 'id': 517124, 'node_id': 'MDQ6VXNlcjUxNzEyNA==', 'avatar_url': 'https://avatars2.githubusercontent.com/u/517124?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/clokep', 'html_url': 'https://github.com/clokep', 'followers_url': 'https://api.github.com/users/clokep/followers', 'following_url': 'https://api.github.com/users/clokep/following{/other_user}', 'gists_url': 'https://api.github.com/users/clokep/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/clokep/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/clokep/subscriptions', 'organizations_url': 'https://api.github.com/users/clokep/orgs', 'repos_url': 'https://api.github.com/users/clokep/repos', 'events_url': 'https://api.github.com/users/clokep/events{/privacy}', 'received_events_url': 'https://api.github.com/users/clokep/received_events', 'type': 'User', 'site_admin': False}]",,5,2020-04-21T13:28:17Z,2020-05-22T13:30:08Z,2020-05-22T13:30:08Z,CONTRIBUTOR,,,"**Description:**
The frontend proxy worker is able to handle HTTP OPTIONS requests for everything except the media repo. If it could also handle these requests (and any future api endpoints), we would be able to route all http options requests to the worker in config, without having to keep a seperate map for OPTIONS requests, compared to GET or PUT.
Currently requests return a 404.",
976,https://api.github.com/repos/matrix-org/synapse/issues/7312,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7312/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7312/comments,https://api.github.com/repos/matrix-org/synapse/issues/7312/events,https://github.com/matrix-org/synapse/issues/7312,603587977,MDU6SXNzdWU2MDM1ODc5Nzc=,7312,Metrics (esp. synapse_notifier_users) and workers,"{'login': 'eMPee584', 'id': 1227833, 'node_id': 'MDQ6VXNlcjEyMjc4MzM=', 'avatar_url': 'https://avatars0.githubusercontent.com/u/1227833?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/eMPee584', 'html_url': 'https://github.com/eMPee584', 'followers_url': 'https://api.github.com/users/eMPee584/followers', 'following_url': 'https://api.github.com/users/eMPee584/following{/other_user}', 'gists_url': 'https://api.github.com/users/eMPee584/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/eMPee584/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/eMPee584/subscriptions', 'organizations_url': 'https://api.github.com/users/eMPee584/orgs', 'repos_url': 'https://api.github.com/users/eMPee584/repos', 'events_url': 'https://api.github.com/users/eMPee584/events{/privacy}', 'received_events_url': 'https://api.github.com/users/eMPee584/received_events', 'type': 'User', 'site_admin': False}","[{'id': 1311133228, 'node_id': 'MDU6TGFiZWwxMzExMTMzMjI4', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/info-needed', 'name': 'info-needed', 'color': 'a1e8ea', 'default': False, 'description': ''}]",closed,False,,[],,3,2020-04-20T23:00:34Z,2020-04-27T17:33:02Z,2020-04-27T17:33:01Z,NONE,,,"### Description
Is the assumption correct that `synapse_notifier_users` should reflect the number of active user devices at a given time?
Since activating workers, `synapse_notifier_users` has turned to 0.0, leaving us without this vital measure of server activity.. With 7k+ users atm... :sweat_smile: :sweat_drops:
Here's a dump of our [metrics.gz](https://github.com/matrix-org/synapse/files/4506690/metrics.gz)..
### Steps to reproduce
- enable workers
- check http://localhost:9100/_synapse/metrics
- see `synapse_notifier_users 0.0`
- wonder
### Version information
- **Homeserver**: https://matrix.tu-dresden.de
- **Version**: python_version: 3.7.7, server_version: 1.12.3
- **Install method**: https://github.com/spantaleev/matrix-docker-ansible-deploy
- **Platform**: debian buster VM
",
977,https://api.github.com/repos/matrix-org/synapse/issues/7311,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7311/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7311/comments,https://api.github.com/repos/matrix-org/synapse/issues/7311/events,https://github.com/matrix-org/synapse/pull/7311,603411497,MDExOlB1bGxSZXF1ZXN0NDA2MjAyMDcz,7311,Support GET account_data requests on a worker,"{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,0,2020-04-20T17:34:57Z,2020-04-21T09:46:32Z,2020-04-21T09:46:31Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7311', 'html_url': 'https://github.com/matrix-org/synapse/pull/7311', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7311.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7311.patch'}","fixes #7309
tests at https://github.com/matrix-org/sytest/pull/855",
978,https://api.github.com/repos/matrix-org/synapse/issues/7309,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7309/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7309/comments,https://api.github.com/repos/matrix-org/synapse/issues/7309/events,https://github.com/matrix-org/synapse/issues/7309,603327529,MDU6SXNzdWU2MDMzMjc1Mjk=,7309,Move GET requests to account_data/* onto a worker.,"{'login': 'neilisfragile', 'id': 451032, 'node_id': 'MDQ6VXNlcjQ1MTAzMg==', 'avatar_url': 'https://avatars2.githubusercontent.com/u/451032?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/neilisfragile', 'html_url': 'https://github.com/neilisfragile', 'followers_url': 'https://api.github.com/users/neilisfragile/followers', 'following_url': 'https://api.github.com/users/neilisfragile/following{/other_user}', 'gists_url': 'https://api.github.com/users/neilisfragile/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/neilisfragile/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/neilisfragile/subscriptions', 'organizations_url': 'https://api.github.com/users/neilisfragile/orgs', 'repos_url': 'https://api.github.com/users/neilisfragile/repos', 'events_url': 'https://api.github.com/users/neilisfragile/events{/privacy}', 'received_events_url': 'https://api.github.com/users/neilisfragile/received_events', 'type': 'User', 'site_admin': False}","[{'id': 477045093, 'node_id': 'MDU6TGFiZWw0NzcwNDUwOTM=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/p1', 'name': 'p1', 'color': 'd93f0b', 'default': False, 'description': None}, {'id': 600557921, 'node_id': 'MDU6TGFiZWw2MDA1NTc5MjE=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/performance', 'name': 'performance', 'color': 'fef2c0', 'default': False, 'description': None}]",closed,False,"{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}","[{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}]",,1,2020-04-20T15:29:32Z,2020-04-23T09:26:31Z,2020-04-23T09:26:31Z,CONTRIBUTOR,,,,
979,https://api.github.com/repos/matrix-org/synapse/issues/7308,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7308/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7308/comments,https://api.github.com/repos/matrix-org/synapse/issues/7308/events,https://github.com/matrix-org/synapse/issues/7308,603145719,MDU6SXNzdWU2MDMxNDU3MTk=,7308,Replication fails with AssertionError in replication_notifier,"{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}","[{'id': 2011569249, 'node_id': 'MDU6TGFiZWwyMDExNTY5MjQ5', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/operation%20gemini', 'name': 'operation gemini', 'color': '006b75', 'default': False, 'description': 'Part of the project to fix the cpu bottleneck on'}, {'id': 828666468, 'node_id': 'MDU6TGFiZWw4Mjg2NjY0Njg=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/release%20blocker', 'name': 'release blocker', 'color': '880000', 'default': False, 'description': None}]",closed,False,"{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}","[{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}]",,3,2020-04-20T10:57:54Z,2020-04-29T11:31:04Z,2020-04-29T11:31:04Z,MEMBER,,,"my master stopped sending event notifications over replication. It was logging this sort of thing:
```
2020-04-20 09:36:14,977 - synapse.replication.tcp.resource - 169 - INFO - replication_notifier-231759- Failed to handle stream events
2020-04-20 09:36:14,984 - synapse.metrics.background_process_metrics - 215 - ERROR - replication_notifier-231759- Background process 'replication_notifier' threw an exception
Capture point (most recent call last):
... lots of output...
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File ""/opt/synapse/synapse/synapse/metrics/background_process_metrics.py"", line 213, in run
return (yield result)
File ""/opt/synapse/env3/lib/python3.5/site-packages/twisted/internet/defer.py"", line 1418, in _inlineCallbacks
result = g.send(result)
File ""/opt/synapse/synapse/synapse/replication/tcp/resource.py"", line 166, in _run_notifier_loop
updates, current_token, limited = await stream.get_updates()
File ""/opt/synapse/synapse/synapse/replication/tcp/streams/_base.py"", line 134, in get_updates
self.last_token, current_token
File ""/opt/synapse/synapse/synapse/replication/tcp/streams/_base.py"", line 159, in get_updates_since
from_token, upto_token, limit,
File ""/opt/synapse/synapse/synapse/replication/tcp/streams/_base.py"", line 178, in update_function
assert len(updates) <= limit
AssertionError
```
Likely this only affects `develop` currently.",
980,https://api.github.com/repos/matrix-org/synapse/issues/7307,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7307/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7307/comments,https://api.github.com/repos/matrix-org/synapse/issues/7307/events,https://github.com/matrix-org/synapse/issues/7307,602867800,MDU6SXNzdWU2MDI4Njc4MDA=,7307,Password provider requires more API,"{'login': 'integrics', 'id': 9424569, 'node_id': 'MDQ6VXNlcjk0MjQ1Njk=', 'avatar_url': 'https://avatars3.githubusercontent.com/u/9424569?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/integrics', 'html_url': 'https://github.com/integrics', 'followers_url': 'https://api.github.com/users/integrics/followers', 'following_url': 'https://api.github.com/users/integrics/following{/other_user}', 'gists_url': 'https://api.github.com/users/integrics/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/integrics/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/integrics/subscriptions', 'organizations_url': 'https://api.github.com/users/integrics/orgs', 'repos_url': 'https://api.github.com/users/integrics/repos', 'events_url': 'https://api.github.com/users/integrics/events{/privacy}', 'received_events_url': 'https://api.github.com/users/integrics/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,1,2020-04-20T00:48:40Z,2020-04-20T09:24:43Z,2020-04-20T09:24:43Z,NONE,,,"I'm configuring Synapse to authenticate from an external web service using this guide:
https://github.com/kamax-matrix/matrix-synapse-rest-password-provider
I've set the following in homeserver.yaml:
password_providers:
- module: ""rest_auth_provider.RestAuthProvider""
config:
endpoint: ""http://127.0.0.1""
This is failing because Synapse is making other requests to the web service. From the web server's logs:
GET /_matrix/client/versions HTTP/1.1"" 404
Is it really necessary to implement more of the API? If so, which functions need to be provided, and what are they expected to return?
Synapse is version 1.11.0-1. The client is the riot.im web app. The web server is Apache 2.4.41-4ubuntu3. Everything is running on the same machine, my laptop, running Ubuntu 20.04 beta.",
981,https://api.github.com/repos/matrix-org/synapse/issues/7306,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7306/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7306/comments,https://api.github.com/repos/matrix-org/synapse/issues/7306/events,https://github.com/matrix-org/synapse/issues/7306,602802343,MDU6SXNzdWU2MDI4MDIzNDM=,7306,The `limit` set for a filter in a room's `StateFilter` is ignored,"{'login': 'flaki', 'id': 2089432, 'node_id': 'MDQ6VXNlcjIwODk0MzI=', 'avatar_url': 'https://avatars0.githubusercontent.com/u/2089432?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/flaki', 'html_url': 'https://github.com/flaki', 'followers_url': 'https://api.github.com/users/flaki/followers', 'following_url': 'https://api.github.com/users/flaki/following{/other_user}', 'gists_url': 'https://api.github.com/users/flaki/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/flaki/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/flaki/subscriptions', 'organizations_url': 'https://api.github.com/users/flaki/orgs', 'repos_url': 'https://api.github.com/users/flaki/repos', 'events_url': 'https://api.github.com/users/flaki/events{/privacy}', 'received_events_url': 'https://api.github.com/users/flaki/received_events', 'type': 'User', 'site_admin': False}","[{'id': 121086029, 'node_id': 'MDU6TGFiZWwxMjEwODYwMjk=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/bug', 'name': 'bug', 'color': 'fc2929', 'default': True, 'description': None}, {'id': 477043173, 'node_id': 'MDU6TGFiZWw0NzcwNDMxNzM=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/p2', 'name': 'p2', 'color': 'fbca04', 'default': False, 'description': None}, {'id': 828678284, 'node_id': 'MDU6TGFiZWw4Mjg2NzgyODQ=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/spec%20compliance', 'name': 'spec compliance', 'color': 'cf75ef', 'default': False, 'description': 'places where synapse does not conform to the spec'}]",open,False,,[],,4,2020-04-19T19:38:19Z,2020-04-21T12:49:17Z,,NONE,,,"
### Description
I'm using the below filter in a `sync`:
```json
{
""room"": {
""state"": {
""types"": [
""m.room.member"",
""m.room.name""
],
""limit"": 10
},
""timeline"": {
""limit"": 10
},
""ephemeral"": {
""not_types"": [ ""*"" ]
}
}
}
```
Please note that both room `state` and `timeline` limits are set to 10. In the resulting JSON I see my limit applied in timeline events (also `limited: true`), but not in room state events (one room in `join` has 4000+ events listed). According to the client-server [API docs](https://matrix.org/docs/spec/client_server/r0.6.0#post-matrix-client-r0-user-userid-filter) a `limit` clause should apply to `StateFilter`
### Steps to reproduce
- perform a `sync` without `since`
- include a filter in the query that requests `room.state.limit = 10`
The limit should apply in e.g. `rooms.join..state.events`, but it doesn't seem to do so.
- **Homeserver**: `mozilla.modular.im`
If not matrix.org:
- **Version**: `{""server_version"": ""1.12.3"", ""python_version"": ""3.7.7""}`
- **Install method**:
- **Platform**:
",
982,https://api.github.com/repos/matrix-org/synapse/issues/7305,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7305/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7305/comments,https://api.github.com/repos/matrix-org/synapse/issues/7305/events,https://github.com/matrix-org/synapse/issues/7305,602794352,MDU6SXNzdWU2MDI3OTQzNTI=,7305,"Multiple different ""duplicate key value violates unique constraint"" errors","{'login': 'rihardsk', 'id': 1666746, 'node_id': 'MDQ6VXNlcjE2NjY3NDY=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1666746?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/rihardsk', 'html_url': 'https://github.com/rihardsk', 'followers_url': 'https://api.github.com/users/rihardsk/followers', 'following_url': 'https://api.github.com/users/rihardsk/following{/other_user}', 'gists_url': 'https://api.github.com/users/rihardsk/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/rihardsk/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/rihardsk/subscriptions', 'organizations_url': 'https://api.github.com/users/rihardsk/orgs', 'repos_url': 'https://api.github.com/users/rihardsk/repos', 'events_url': 'https://api.github.com/users/rihardsk/events{/privacy}', 'received_events_url': 'https://api.github.com/users/rihardsk/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,4,2020-04-19T18:59:30Z,2020-04-21T08:28:25Z,2020-04-20T14:49:41Z,NONE,,,"### Description
I've got multiple `psycopg2.errors.UniqueViolation: duplicate key value violates unique constraint` errors of different kinds in my logs.
```
journalctl -u matrix-synapse.service --since=""today"" | grep ""psycopg2.errors.UniqueViolation: duplicate key"" | sort | uniq
psycopg2.errors.UniqueViolation: duplicate key value violates unique constraint ""event_reference_hashes_event_id_algorithm_key""
psycopg2.errors.UniqueViolation: duplicate key value violates unique constraint ""event_search_event_id_idx""
psycopg2.errors.UniqueViolation: duplicate key value violates unique constraint ""event_to_state_groups_event_id_key""
psycopg2.errors.UniqueViolation: duplicate key value violates unique constraint ""redactions_event_id_key""
psycopg2.errors.UniqueViolation: duplicate key value violates unique constraint ""remote_media_cache_media_origin_media_id_key""
```
Here are the full logs [duplicate-key-errors.redacted.log.gz](https://github.com/matrix-org/synapse/files/4499922/duplicate-key-errors.redacted.log.gz).
I think some of the errors might be due to an unresolved corruption in my database due to `LC_COLLATE` being set to `'UTF-8'` previously, which resulted in duplicate entries as described in
https://github.com/matrix-org/synapse/issues/6696#issuecomment-575280941. I attempted to fix the corruption by:
0. leaving all of the rooms that my single user on the homeserver had joined and running the [`synapse_janitor.sql`](https://github.com/xwiki-labs/synapse_scripts/blob/a9188ff175ae581610f92d58ea6eac9a114d854b/synapse_janitor.sql) script,
1. backing up the synapse db,
2. dropping it,
3. recreating it with `LC_CTYPE` and `LC_COLLATE` settings changed from `'UTF-8'` to `'C'`,
4. importing the backup,
5. deleting duplicate rows in tables that were being complained about in the indexing step
6. and then exporting and importing the database again,
7. re-creating the missing indexes (added this step as a resolution to an earlier issue i had - #7282).
I noticed that some of the errors appeared upon joining the Matrix HQ room and trying to load history. The history wouldn't load past some recent point (there's a `Failed to backfill from matrix.org` error which seems to be related). I had joined the room previously and had left it before attempting the database cleanup procedure listed above.
### Version information
- **Homeserver**: my private homeserver
- **Version**: 1.12.1, but the original errors (before running the sql script) were also present on 1.9.1
- **Install method**: NixOS
- **Platform**: latest NixOS master branch (commit 01c8795673ecff6272895a085e9fe1ffa3b33620) running on a rockpro64 sbc (with a custom patched kernel).
",
983,https://api.github.com/repos/matrix-org/synapse/issues/7304,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7304/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7304/comments,https://api.github.com/repos/matrix-org/synapse/issues/7304/events,https://github.com/matrix-org/synapse/issues/7304,602539767,MDU6SXNzdWU2MDI1Mzk3Njc=,7304,Docker image permissions wrong when conf_dir is configured,"{'login': 'awesome-michael', 'id': 37796947, 'node_id': 'MDQ6VXNlcjM3Nzk2OTQ3', 'avatar_url': 'https://avatars3.githubusercontent.com/u/37796947?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/awesome-michael', 'html_url': 'https://github.com/awesome-michael', 'followers_url': 'https://api.github.com/users/awesome-michael/followers', 'following_url': 'https://api.github.com/users/awesome-michael/following{/other_user}', 'gists_url': 'https://api.github.com/users/awesome-michael/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/awesome-michael/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/awesome-michael/subscriptions', 'organizations_url': 'https://api.github.com/users/awesome-michael/orgs', 'repos_url': 'https://api.github.com/users/awesome-michael/repos', 'events_url': 'https://api.github.com/users/awesome-michael/events{/privacy}', 'received_events_url': 'https://api.github.com/users/awesome-michael/received_events', 'type': 'User', 'site_admin': False}","[{'id': 1083085226, 'node_id': 'MDU6TGFiZWwxMDgzMDg1MjI2', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/docker', 'name': 'docker', 'color': 'c2e0c6', 'default': False, 'description': ''}, {'id': 477050471, 'node_id': 'MDU6TGFiZWw0NzcwNTA0NzE=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/p3', 'name': 'p3', 'color': '0e8a16', 'default': False, 'description': None}]",open,False,,[],,1,2020-04-18T20:00:13Z,2020-04-20T11:57:44Z,,CONTRIBUTOR,,,"The docker start script sets the permissions for the data_dir folder (https://github.com/matrix-org/synapse/blob/0d775fcc2d0c7b6a07dad5430256d4d6c75a9f0d/docker/start.py#L173)
but it does not set permissions for the config_dir. Most of the time these two are the same but when config_dir is configured to another directory the permissions are wrong.
Please add another line that sets permissions for the config_dir as well.",
984,https://api.github.com/repos/matrix-org/synapse/issues/7303,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7303/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7303/comments,https://api.github.com/repos/matrix-org/synapse/issues/7303/events,https://github.com/matrix-org/synapse/pull/7303,602207718,MDExOlB1bGxSZXF1ZXN0NDA1MzE5NTI5,7303,Extend StreamChangeCache to support multiple entities per stream ID,"{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,1,2020-04-17T20:11:34Z,2020-04-22T12:45:42Z,2020-04-22T12:45:41Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7303', 'html_url': 'https://github.com/matrix-org/synapse/pull/7303', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7303.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7303.patch'}","First some background for the reviewer: `StreamChangeCache` is used to keep track of what ""entities"" have changed since a given stream ID. So for example, we might use it to [keep track of when the last to-device message for a given user was received](https://github.com/matrix-org/synapse/blob/release-v1.12.3/synapse/storage/data_stores/main/deviceinbox.py#L301), and hence [whether we need to pull any to-device messages from the database on a sync](https://github.com/matrix-org/synapse/blob/release-v1.12.3/synapse/storage/data_stores/main/deviceinbox.py#L47-L51).
Now, it turns out that `StreamChangeCache` didn't support more than one thing being changed at a given stream_id (this was part of the problem with #7206). However, it's entirely valid to send to-device messages to more than one user at a time.
As it turns out, this did in fact work, because *some* methods of `StreamChangeCache` coped ok with having multiple things changing on the same stream ID, and it seems we never actually use the methods which don't work on the stream change caches where we allow multiple changes at the same stream ID. But that feels horribly fragile, hence: let's update `StreamChangeCache` to properly support this, and add some typing and some more tests while we're at it.",
985,https://api.github.com/repos/matrix-org/synapse/issues/7302,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7302/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7302/comments,https://api.github.com/repos/matrix-org/synapse/issues/7302/events,https://github.com/matrix-org/synapse/pull/7302,602140788,MDExOlB1bGxSZXF1ZXN0NDA1MjY1NTcx,7302,Persist user interactive authentication sessions,"{'login': 'clokep', 'id': 517124, 'node_id': 'MDQ6VXNlcjUxNzEyNA==', 'avatar_url': 'https://avatars2.githubusercontent.com/u/517124?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/clokep', 'html_url': 'https://github.com/clokep', 'followers_url': 'https://api.github.com/users/clokep/followers', 'following_url': 'https://api.github.com/users/clokep/following{/other_user}', 'gists_url': 'https://api.github.com/users/clokep/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/clokep/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/clokep/subscriptions', 'organizations_url': 'https://api.github.com/users/clokep/orgs', 'repos_url': 'https://api.github.com/users/clokep/repos', 'events_url': 'https://api.github.com/users/clokep/events{/privacy}', 'received_events_url': 'https://api.github.com/users/clokep/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,8,2020-04-17T17:56:07Z,2020-04-30T17:47:51Z,2020-04-30T17:47:50Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7302', 'html_url': 'https://github.com/matrix-org/synapse/pull/7302', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7302.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7302.patch'}","Fixes #6705 by storing user interactive authentication sessions in the database.
I was able to test this with some of the directions I played with in https://github.com/matrix-org/synapse/pull/7268#issuecomment-615373673:
* Login with an account
* Go to the settings and delete a device
* (You should see a password prompt come up, don't fill it in yet)
* Restart the Synapse server (really what we're trying to do here is flush the cache of activate UI auth sessions)
* Type in the password and continue the UI Auth session
* The authentication completes.
This isn't quite the same as testing in worker mode, but I think it gets to the point
~~This is currently based on the branch from #7268.~~
## Outstanding questions
* [ ] I think this implies we'll be writing to the database from workers. Is this OK?
* [x] How do I handle removing expired entries? (Is there a way to run a task periodically or something else?) (We also need to do some work to update the `last_used` field properly.)
* [x] This has some of the same caveats as #7268 that an ""unknown session"" is outright rejected. See that PR for a conversation about that.
",
986,https://api.github.com/repos/matrix-org/synapse/issues/7301,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7301/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7301/comments,https://api.github.com/repos/matrix-org/synapse/issues/7301/events,https://github.com/matrix-org/synapse/issues/7301,602074810,MDU6SXNzdWU2MDIwNzQ4MTA=,7301,Device updates for own user when not in a room seems to have regressed,"{'login': 'bwindels', 'id': 274386, 'node_id': 'MDQ6VXNlcjI3NDM4Ng==', 'avatar_url': 'https://avatars1.githubusercontent.com/u/274386?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bwindels', 'html_url': 'https://github.com/bwindels', 'followers_url': 'https://api.github.com/users/bwindels/followers', 'following_url': 'https://api.github.com/users/bwindels/following{/other_user}', 'gists_url': 'https://api.github.com/users/bwindels/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/bwindels/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/bwindels/subscriptions', 'organizations_url': 'https://api.github.com/users/bwindels/orgs', 'repos_url': 'https://api.github.com/users/bwindels/repos', 'events_url': 'https://api.github.com/users/bwindels/events{/privacy}', 'received_events_url': 'https://api.github.com/users/bwindels/received_events', 'type': 'User', 'site_admin': False}","[{'id': 1631939447, 'node_id': 'MDU6TGFiZWwxNjMxOTM5NDQ3', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/cross-signing-sprint', 'name': 'cross-signing-sprint', 'color': '730adb', 'default': False, 'description': ''}, {'id': 1581464420, 'node_id': 'MDU6TGFiZWwxNTgxNDY0NDIw', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/phase:3', 'name': 'phase:3', 'color': 'c5e567', 'default': False, 'description': ''}, {'id': 1709952128, 'node_id': 'MDU6TGFiZWwxNzA5OTUyMTI4', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/story:1', 'name': 'story:1', 'color': 'b4f291', 'default': False, 'description': 'As a user I want to cross-sign my own devices'}]",closed,False,,[],,2,2020-04-17T15:55:48Z,2020-04-20T16:47:57Z,2020-04-20T16:47:57Z,MEMBER,,,"Both Nad and Dave were able to repro this case, see https://matrix.to/#/!HhZHxURiCDviGNNPnc:matrix.org/$KbLO8GeJFjO4kT8JEp--nrYF8GWOiEVstYHDRmVE9mQ?via=matrix.org&via=vector.modular.im&via=uhoreg.ca
Regression of https://github.com/matrix-org/synapse/pull/7160",
987,https://api.github.com/repos/matrix-org/synapse/issues/7300,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7300/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7300/comments,https://api.github.com/repos/matrix-org/synapse/issues/7300/events,https://github.com/matrix-org/synapse/pull/7300,602058606,MDExOlB1bGxSZXF1ZXN0NDA1MjAwMTQx,7300,Fix indention in generated config file,"{'login': 'frcl', 'id': 7346166, 'node_id': 'MDQ6VXNlcjczNDYxNjY=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/7346166?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/frcl', 'html_url': 'https://github.com/frcl', 'followers_url': 'https://api.github.com/users/frcl/followers', 'following_url': 'https://api.github.com/users/frcl/following{/other_user}', 'gists_url': 'https://api.github.com/users/frcl/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/frcl/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/frcl/subscriptions', 'organizations_url': 'https://api.github.com/users/frcl/orgs', 'repos_url': 'https://api.github.com/users/frcl/repos', 'events_url': 'https://api.github.com/users/frcl/events{/privacy}', 'received_events_url': 'https://api.github.com/users/frcl/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,1,2020-04-17T15:30:22Z,2020-04-20T15:52:05Z,2020-04-20T15:51:28Z,CONTRIBUTOR,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7300', 'html_url': 'https://github.com/matrix-org/synapse/pull/7300', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7300.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7300.patch'}","Fixes #7285.
Signed-off-by: Lars Franke
### Pull Request Checklist
* [x] Pull request is based on the develop branch
* [x] Pull request includes a [changelog file](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#changelog). The entry should:
- Be a short description of your change which makes sense to users. ""Fixed a bug that prevented receiving messages from other servers."" instead of ""Moved X method from `EventStore` to `EventWorkerStore`."".
- Use markdown where necessary, mostly for `code blocks`.
- End with either a period (.) or an exclamation mark (!).
- Start with a capital letter.
* [x] Pull request includes a [sign off](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#sign-off)
* [x] Code style is correct (run the [linters](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#code-style))
",
988,https://api.github.com/repos/matrix-org/synapse/issues/7299,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7299/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7299/comments,https://api.github.com/repos/matrix-org/synapse/issues/7299/events,https://github.com/matrix-org/synapse/pull/7299,601975289,MDExOlB1bGxSZXF1ZXN0NDA1MTMxNTgy,7299,Add a sanity-check in the StreamChangeCache,"{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,"{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}","[{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}]",,1,2020-04-17T13:26:32Z,2020-04-17T20:12:07Z,2020-04-17T20:12:07Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7299', 'html_url': 'https://github.com/matrix-org/synapse/pull/7299', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7299.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7299.patch'}",... to check that we aren't overwriting important info,
989,https://api.github.com/repos/matrix-org/synapse/issues/7298,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7298/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7298/comments,https://api.github.com/repos/matrix-org/synapse/issues/7298/events,https://github.com/matrix-org/synapse/issues/7298,601964435,MDU6SXNzdWU2MDE5NjQ0MzU=,7298,"If your server is unreachable, attempts to join rooms over federation fail with an obscure error","{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}","[{'id': 1771241792, 'node_id': 'MDU6TGFiZWwxNzcxMjQxNzky', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/join%20fail', 'name': 'join fail', 'color': '6c5ffc', 'default': False, 'description': 'joins over federation generally suck'}]",open,False,,[],,4,2020-04-17T13:10:13Z,2020-07-07T09:34:17Z,,MEMBER,,,"If your server is unreachable (so that the resident server cannot contact yours to retrieve your signing key), then attempts to join rooms over federation fail with
> No key for with ids in []
I mean, wtf does that even mean?
",
990,https://api.github.com/repos/matrix-org/synapse/issues/7297,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7297/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7297/comments,https://api.github.com/repos/matrix-org/synapse/issues/7297/events,https://github.com/matrix-org/synapse/issues/7297,601962160,MDU6SXNzdWU2MDE5NjIxNjA=,7297,Joining a room where all servers are blacklisted fails with obscure error,"{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}","[{'id': 1771241792, 'node_id': 'MDU6TGFiZWwxNzcxMjQxNzky', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/join%20fail', 'name': 'join fail', 'color': '6c5ffc', 'default': False, 'description': 'joins over federation generally suck'}]",open,False,,[],,0,2020-04-17T13:06:14Z,2020-04-17T13:06:21Z,,MEMBER,,,"If you attempt to join a room over federation, and the resident server that you choose to help with the join has been blacklisted, you get this rather obscure error:
> Failed to make_join via any server.
It would be nice if we could record why the server was blacklisted, and return some more information on it (maybe how long until the next attempt?)
",
991,https://api.github.com/repos/matrix-org/synapse/issues/7296,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7296/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7296/comments,https://api.github.com/repos/matrix-org/synapse/issues/7296/events,https://github.com/matrix-org/synapse/issues/7296,601940418,MDU6SXNzdWU2MDE5NDA0MTg=,7296,Resetting cross signing seems really heavy on federation,"{'login': 'MatMaul', 'id': 1643573, 'node_id': 'MDQ6VXNlcjE2NDM1NzM=', 'avatar_url': 'https://avatars0.githubusercontent.com/u/1643573?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/MatMaul', 'html_url': 'https://github.com/MatMaul', 'followers_url': 'https://api.github.com/users/MatMaul/followers', 'following_url': 'https://api.github.com/users/MatMaul/following{/other_user}', 'gists_url': 'https://api.github.com/users/MatMaul/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/MatMaul/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/MatMaul/subscriptions', 'organizations_url': 'https://api.github.com/users/MatMaul/orgs', 'repos_url': 'https://api.github.com/users/MatMaul/repos', 'events_url': 'https://api.github.com/users/MatMaul/events{/privacy}', 'received_events_url': 'https://api.github.com/users/MatMaul/received_events', 'type': 'User', 'site_admin': False}","[{'id': 121086029, 'node_id': 'MDU6TGFiZWwxMjEwODYwMjk=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/bug', 'name': 'bug', 'color': 'fc2929', 'default': True, 'description': None}, {'id': 1631939447, 'node_id': 'MDU6TGFiZWwxNjMxOTM5NDQ3', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/cross-signing-sprint', 'name': 'cross-signing-sprint', 'color': '730adb', 'default': False, 'description': ''}, {'id': 1709952128, 'node_id': 'MDU6TGFiZWwxNzA5OTUyMTI4', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/story:1', 'name': 'story:1', 'color': 'b4f291', 'default': False, 'description': 'As a user I want to cross-sign my own devices'}]",open,False,,[],,1,2020-04-17T12:27:33Z,2020-04-17T13:59:24Z,,NONE,,,"So heavy that it breaks my small slow server for a while (1 shared vcpu and 2GB).
Nginx begins to fail because of too many opened connections/fds (ulimit is 524288).
It recovers after less than a minute once the federation spike is done.
However in the meantime the resetting fails on the client, probably because of a broken HTTP connection on the nginx. Clicking retry goes into the exact same behavior.
Once I also had to revalidate my unique device with the passphrase after doing a reset and it failed. Perhaps I was just too fast and the federation was just not over.",
992,https://api.github.com/repos/matrix-org/synapse/issues/7295,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7295/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7295/comments,https://api.github.com/repos/matrix-org/synapse/issues/7295/events,https://github.com/matrix-org/synapse/pull/7295,601879242,MDExOlB1bGxSZXF1ZXN0NDA1MDU4NjQz,7295,Reduce verbosity of URL cache cleanup.,"{'login': 'michaelkaye', 'id': 1917473, 'node_id': 'MDQ6VXNlcjE5MTc0NzM=', 'avatar_url': 'https://avatars0.githubusercontent.com/u/1917473?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/michaelkaye', 'html_url': 'https://github.com/michaelkaye', 'followers_url': 'https://api.github.com/users/michaelkaye/followers', 'following_url': 'https://api.github.com/users/michaelkaye/following{/other_user}', 'gists_url': 'https://api.github.com/users/michaelkaye/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/michaelkaye/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/michaelkaye/subscriptions', 'organizations_url': 'https://api.github.com/users/michaelkaye/orgs', 'repos_url': 'https://api.github.com/users/michaelkaye/repos', 'events_url': 'https://api.github.com/users/michaelkaye/events{/privacy}', 'received_events_url': 'https://api.github.com/users/michaelkaye/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,0,2020-04-17T10:41:25Z,2020-04-22T11:45:18Z,2020-04-22T11:45:17Z,CONTRIBUTOR,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7295', 'html_url': 'https://github.com/matrix-org/synapse/pull/7295', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7295.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7295.patch'}","This task runs every 10s, so log at info only if media/urls removed, as low-volume homeservers will be very verbose for little benefit otherwise.
We already skip the ""deleted X entries"" line if it's zero length.
While setting log level to 'WARN' for this class could also be done, that simply silences the entire process, providing no mix of visibility between no-op actions and actions that did something.
",
993,https://api.github.com/repos/matrix-org/synapse/issues/7294,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7294/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7294/comments,https://api.github.com/repos/matrix-org/synapse/issues/7294/events,https://github.com/matrix-org/synapse/issues/7294,601875046,MDU6SXNzdWU2MDE4NzUwNDY=,7294,Public room list not updated when disabling stats,"{'login': 'amesser', 'id': 1190145, 'node_id': 'MDQ6VXNlcjExOTAxNDU=', 'avatar_url': 'https://avatars0.githubusercontent.com/u/1190145?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/amesser', 'html_url': 'https://github.com/amesser', 'followers_url': 'https://api.github.com/users/amesser/followers', 'following_url': 'https://api.github.com/users/amesser/following{/other_user}', 'gists_url': 'https://api.github.com/users/amesser/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/amesser/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/amesser/subscriptions', 'organizations_url': 'https://api.github.com/users/amesser/orgs', 'repos_url': 'https://api.github.com/users/amesser/repos', 'events_url': 'https://api.github.com/users/amesser/events{/privacy}', 'received_events_url': 'https://api.github.com/users/amesser/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,6,2020-04-17T10:34:21Z,2020-04-27T16:52:40Z,2020-04-27T16:52:22Z,NONE,,,"### Description
When setting ""report_stats: false"" in homeserver.yaml, newly created rooms which are set to public visible and with local alias do not show up in servers room list. Also existing rooms switched to ""public"" wont show up.
I think the problem is, that the room list depends on sql tables room_stats_*. But these tables are only updated when set ""report_stats: true""
### Version information
- v1.12.3
- running on private homeserver
- installed via package manager (Ubuntu Bionic + Matrix deb repo)",
994,https://api.github.com/repos/matrix-org/synapse/issues/7293,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7293/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7293/comments,https://api.github.com/repos/matrix-org/synapse/issues/7293/events,https://github.com/matrix-org/synapse/issues/7293,601482528,MDU6SXNzdWU2MDE0ODI1Mjg=,7293,build debs for ubuntu 20.04,"{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}","[{'id': 482414360, 'node_id': 'MDU6TGFiZWw0ODI0MTQzNjA=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/packaging', 'name': 'packaging', 'color': '5319e7', 'default': False, 'description': None}]",closed,False,"{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}","[{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}]",,8,2020-04-16T21:14:07Z,2020-05-19T12:58:51Z,2020-05-19T12:58:36Z,MEMBER,,,focal fossa is being released on 2020-04-23 and is in RC currently; we should add it to the list of things we build debs for,
995,https://api.github.com/repos/matrix-org/synapse/issues/7292,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7292/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7292/comments,https://api.github.com/repos/matrix-org/synapse/issues/7292/events,https://github.com/matrix-org/synapse/issues/7292,601331396,MDU6SXNzdWU2MDEzMzEzOTY=,7292,Account validity: admin account has expired,"{'login': 'ukcb', 'id': 22983914, 'node_id': 'MDQ6VXNlcjIyOTgzOTE0', 'avatar_url': 'https://avatars1.githubusercontent.com/u/22983914?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/ukcb', 'html_url': 'https://github.com/ukcb', 'followers_url': 'https://api.github.com/users/ukcb/followers', 'following_url': 'https://api.github.com/users/ukcb/following{/other_user}', 'gists_url': 'https://api.github.com/users/ukcb/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/ukcb/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/ukcb/subscriptions', 'organizations_url': 'https://api.github.com/users/ukcb/orgs', 'repos_url': 'https://api.github.com/users/ukcb/repos', 'events_url': 'https://api.github.com/users/ukcb/events{/privacy}', 'received_events_url': 'https://api.github.com/users/ukcb/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,2,2020-04-16T18:44:20Z,2020-04-20T15:10:13Z,2020-04-20T15:10:13Z,NONE,,,"I start a script at irregular intervals for various tasks that require an admin account. I have activated the option for account validity configuration (synapse v1.12.x).
```
account_validity:
enabled: true
period: 6w
renew_at: 1w
```
At some point my system admin was gone.
```
ROOM_ID: !xxxxxxxxxxxxx
{
""errcode"": ""ORG_MATRIX_EXPIRED_ACCOUNT"",
""error"": ""User account has expired""
}
```
An admin's account shouldn't expire?",
996,https://api.github.com/repos/matrix-org/synapse/issues/7291,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7291/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7291/comments,https://api.github.com/repos/matrix-org/synapse/issues/7291/events,https://github.com/matrix-org/synapse/pull/7291,601282623,MDExOlB1bGxSZXF1ZXN0NDA0NTY0NzE1,7291,Improve type checking in `replication.tcp.Stream`,"{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,0,2020-04-16T17:50:42Z,2020-04-17T13:49:57Z,2020-04-17T13:49:55Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7291', 'html_url': 'https://github.com/matrix-org/synapse/pull/7291', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7291.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7291.patch'}","The general idea here is to get rid of the `type: ignore` annotations on all of the `current_token` and `update_function` assignments, which would have caught #7290.
After a bit of experimentation, it seems like the least-awful way to do this is to pass the offending functions in as parameters to the `Stream` constructor. Unfortunately that means that the concrete implementations no longer have the same constructor signature as `Stream` itself, which means that it gets hard to correctly annotate `STREAMS_MAP`.
I've also introduced a couple of new types, to take out some duplication.",
997,https://api.github.com/repos/matrix-org/synapse/issues/7290,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7290/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7290/comments,https://api.github.com/repos/matrix-org/synapse/issues/7290/events,https://github.com/matrix-org/synapse/pull/7290,601005938,MDExOlB1bGxSZXF1ZXN0NDA0MzMwMTAz,7290,Fix 'generator object is not subscriptable' error,"{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,1,2020-04-16T12:24:36Z,2020-04-16T13:37:08Z,2020-04-16T13:37:07Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7290', 'html_url': 'https://github.com/matrix-org/synapse/pull/7290', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7290.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7290.patch'}","Some of the query functions return generators rather than lists, so we can't
index into the result. Happily we already have a copy of the results.
(think this was introduced in #7024)",
998,https://api.github.com/repos/matrix-org/synapse/issues/7289,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7289/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7289/comments,https://api.github.com/repos/matrix-org/synapse/issues/7289/events,https://github.com/matrix-org/synapse/pull/7289,600981738,MDExOlB1bGxSZXF1ZXN0NDA0MzA5NjEw,7289,Query missing cross-signing keys on local sig upload,"{'login': 'anoadragon453', 'id': 1342360, 'node_id': 'MDQ6VXNlcjEzNDIzNjA=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1342360?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/anoadragon453', 'html_url': 'https://github.com/anoadragon453', 'followers_url': 'https://api.github.com/users/anoadragon453/followers', 'following_url': 'https://api.github.com/users/anoadragon453/following{/other_user}', 'gists_url': 'https://api.github.com/users/anoadragon453/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/anoadragon453/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/anoadragon453/subscriptions', 'organizations_url': 'https://api.github.com/users/anoadragon453/orgs', 'repos_url': 'https://api.github.com/users/anoadragon453/repos', 'events_url': 'https://api.github.com/users/anoadragon453/events{/privacy}', 'received_events_url': 'https://api.github.com/users/anoadragon453/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,"{'login': 'anoadragon453', 'id': 1342360, 'node_id': 'MDQ6VXNlcjEzNDIzNjA=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1342360?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/anoadragon453', 'html_url': 'https://github.com/anoadragon453', 'followers_url': 'https://api.github.com/users/anoadragon453/followers', 'following_url': 'https://api.github.com/users/anoadragon453/following{/other_user}', 'gists_url': 'https://api.github.com/users/anoadragon453/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/anoadragon453/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/anoadragon453/subscriptions', 'organizations_url': 'https://api.github.com/users/anoadragon453/orgs', 'repos_url': 'https://api.github.com/users/anoadragon453/repos', 'events_url': 'https://api.github.com/users/anoadragon453/events{/privacy}', 'received_events_url': 'https://api.github.com/users/anoadragon453/received_events', 'type': 'User', 'site_admin': False}","[{'login': 'anoadragon453', 'id': 1342360, 'node_id': 'MDQ6VXNlcjEzNDIzNjA=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1342360?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/anoadragon453', 'html_url': 'https://github.com/anoadragon453', 'followers_url': 'https://api.github.com/users/anoadragon453/followers', 'following_url': 'https://api.github.com/users/anoadragon453/following{/other_user}', 'gists_url': 'https://api.github.com/users/anoadragon453/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/anoadragon453/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/anoadragon453/subscriptions', 'organizations_url': 'https://api.github.com/users/anoadragon453/orgs', 'repos_url': 'https://api.github.com/users/anoadragon453/repos', 'events_url': 'https://api.github.com/users/anoadragon453/events{/privacy}', 'received_events_url': 'https://api.github.com/users/anoadragon453/received_events', 'type': 'User', 'site_admin': False}]",,5,2020-04-16T11:49:14Z,2020-04-22T11:29:38Z,2020-04-22T11:29:37Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7289', 'html_url': 'https://github.com/matrix-org/synapse/pull/7289', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7289.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7289.patch'}","Mitigates https://github.com/matrix-org/synapse/issues/7276
So we have a race condition that appears in the following scenario: You want to cross-sign with a remote user who doesn't share a room with any users on your homeserver. When you start cross-signing, a DM is created between you and the remote user.
When the remote user sends you their keys, the DM room may not have completed creation yet. In this case, your homeserver ignores the new keys. When you then upload your signatures of the remote user, your homeserver rejects them as it doesn't have the remote user's keys.
This seems to only occur with workerised Synapse setups. A possible solution to this is to fix the race condition, but that still leaves a number of people with broken setups. Another solution, and one we should probably do anyways, is to query the remote user's keys when a local user signs them, if the homeserver doesn't have them already.
So that's what this PR does. At least I *think* it's what it does. This is untested and I used MSC1756 as a reference for all of this so it may or may not be right. Review appreciated!",
999,https://api.github.com/repos/matrix-org/synapse/issues/7288,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7288/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7288/comments,https://api.github.com/repos/matrix-org/synapse/issues/7288/events,https://github.com/matrix-org/synapse/issues/7288,600965378,MDU6SXNzdWU2MDA5NjUzNzg=,7288,matrix-synapse fails to start on ubuntu 20.04,"{'login': 'weebl2000', 'id': 2385844, 'node_id': 'MDQ6VXNlcjIzODU4NDQ=', 'avatar_url': 'https://avatars0.githubusercontent.com/u/2385844?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/weebl2000', 'html_url': 'https://github.com/weebl2000', 'followers_url': 'https://api.github.com/users/weebl2000/followers', 'following_url': 'https://api.github.com/users/weebl2000/following{/other_user}', 'gists_url': 'https://api.github.com/users/weebl2000/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/weebl2000/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/weebl2000/subscriptions', 'organizations_url': 'https://api.github.com/users/weebl2000/orgs', 'repos_url': 'https://api.github.com/users/weebl2000/repos', 'events_url': 'https://api.github.com/users/weebl2000/events{/privacy}', 'received_events_url': 'https://api.github.com/users/weebl2000/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,4,2020-04-16T11:24:57Z,2020-04-16T21:14:17Z,2020-04-16T21:11:54Z,NONE,,,"Upgraded to Ubuntu 20.04 and matrix-synapse-py3 package does not want to start.
matrix-synapse[41198]: ModuleNotFoundError: No module named 'distutils.util'.
Tried installing it in the venv, but same error occurs.",
1000,https://api.github.com/repos/matrix-org/synapse/issues/7287,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7287/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7287/comments,https://api.github.com/repos/matrix-org/synapse/issues/7287/events,https://github.com/matrix-org/synapse/issues/7287,600958893,MDU6SXNzdWU2MDA5NTg4OTM=,7287,Joining replacement room over federation fails with `make_join` error,"{'login': 'dkasak', 'id': 463342, 'node_id': 'MDQ6VXNlcjQ2MzM0Mg==', 'avatar_url': 'https://avatars3.githubusercontent.com/u/463342?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/dkasak', 'html_url': 'https://github.com/dkasak', 'followers_url': 'https://api.github.com/users/dkasak/followers', 'following_url': 'https://api.github.com/users/dkasak/following{/other_user}', 'gists_url': 'https://api.github.com/users/dkasak/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/dkasak/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/dkasak/subscriptions', 'organizations_url': 'https://api.github.com/users/dkasak/orgs', 'repos_url': 'https://api.github.com/users/dkasak/repos', 'events_url': 'https://api.github.com/users/dkasak/events{/privacy}', 'received_events_url': 'https://api.github.com/users/dkasak/received_events', 'type': 'User', 'site_admin': False}","[{'id': 1311133228, 'node_id': 'MDU6TGFiZWwxMzExMTMzMjI4', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/info-needed', 'name': 'info-needed', 'color': 'a1e8ea', 'default': False, 'description': ''}]",closed,False,,[],,3,2020-04-16T11:15:53Z,2020-04-20T14:38:43Z,2020-04-20T14:38:43Z,NONE,,,"### Description
I'm a member of #ruma:matrix.org (with an account on a personal homeserver, info below) which recently got tombstoned. I tried joining the replacement
room using Riot Desktop 1.5.15. This nearly instantaneously failed with `Failed
to make_join via any server`.
The following lines appeared in the synapse log:
```
2020-04-16 12:37:11,275 - synapse.federation.federation_client:929 | ERROR - POST-233666 - Failed to fetch room complexity via matrix.org for !XfqLiaavxVgyMSiRwK:matrix.org
Traceback (most recent call last):
File ""/usr/local/lib/python3.7/site-packages/twisted/internet/defer.py"", line 1418, in _inlineCallbacks
result = g.send(result)
StopIteration: mxc://termina.org.uk/GZLyTGACVOyuzABpftmsbEoA
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File ""/usr/local/lib/python3.7/site-packages/twisted/internet/defer.py"", line 1418, in _inlineCallbacks
result = g.send(result)
StopIteration: mxc://termina.org.uk/GZLyTGACVOyuzABpftmsbEoA
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File ""/usr/local/lib/python3.7/site-packages/twisted/internet/defer.py"", line 1418, in _inlineCallbacks
result = g.send(result)
StopIteration: mxc://termina.org.uk/GZLyTGACVOyuzABpftmsbEoA
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File ""/usr/local/lib/python3.7/site-packages/synapse/federation/federation_client.py"", line 915, in get_room_complexity
destination=destination, room_id=room_id
synapse.util.retryutils.NotRetryingDestination: Not retrying server matrix.org.
2020-04-16 12:37:11,277 - synapse.federation.federation_client:405 | WARNING - POST-233666 - Failed to make_join via matrix.org
Traceback (most recent call last):
File ""/usr/local/lib/python3.7/site-packages/twisted/internet/defer.py"", line 1418, in _inlineCallbacks
result = g.send(result)
StopIteration: mxc://termina.org.uk/GZLyTGACVOyuzABpftmsbEoA
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File ""/usr/local/lib/python3.7/site-packages/twisted/internet/defer.py"", line 1418, in _inlineCallbacks
result = g.send(result)
StopIteration: mxc://termina.org.uk/GZLyTGACVOyuzABpftmsbEoA
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File ""/usr/local/lib/python3.7/site-packages/twisted/internet/defer.py"", line 1418, in _inlineCallbacks
result = g.send(result)
StopIteration: mxc://termina.org.uk/GZLyTGACVOyuzABpftmsbEoA
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File ""/usr/local/lib/python3.7/site-packages/synapse/federation/federation_client.py"", line 386, in _try_destination_list
res = yield callback(destination)
synapse.util.retryutils.NotRetryingDestination: Not retrying server matrix.org.
2020-04-16 12:37:13,557 - synapse.federation.federation_client:929 | ERROR - POST-233671 - Failed to fetch room complexity via matrix.org for !XfqLiaavxVgyMSiRwK:matrix.org
Traceback (most recent call last):
File ""/usr/local/lib/python3.7/site-packages/twisted/internet/defer.py"", line 1418, in _inlineCallbacks
result = g.send(result)
StopIteration: mxc://termina.org.uk/GZLyTGACVOyuzABpftmsbEoA
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File ""/usr/local/lib/python3.7/site-packages/twisted/internet/defer.py"", line 1418, in _inlineCallbacks
result = g.send(result)
StopIteration: mxc://termina.org.uk/GZLyTGACVOyuzABpftmsbEoA
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File ""/usr/local/lib/python3.7/site-packages/twisted/internet/defer.py"", line 1418, in _inlineCallbacks
result = g.send(result)
StopIteration: mxc://termina.org.uk/GZLyTGACVOyuzABpftmsbEoA
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File ""/usr/local/lib/python3.7/site-packages/synapse/federation/federation_client.py"", line 915, in get_room_complexity
destination=destination, room_id=room_id
synapse.util.retryutils.NotRetryingDestination: Not retrying server matrix.org.
2020-04-16 12:37:13,560 - synapse.federation.federation_client:405 | WARNING - POST-233671 - Failed to make_join via matrix.org
Traceback (most recent call last):
File ""/usr/local/lib/python3.7/site-packages/twisted/internet/defer.py"", line 1418, in _inlineCallbacks
result = g.send(result)
StopIteration: mxc://termina.org.uk/GZLyTGACVOyuzABpftmsbEoA
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File ""/usr/local/lib/python3.7/site-packages/twisted/internet/defer.py"", line 1418, in _inlineCallbacks
result = g.send(result)
StopIteration: mxc://termina.org.uk/GZLyTGACVOyuzABpftmsbEoA
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File ""/usr/local/lib/python3.7/site-packages/twisted/internet/defer.py"", line 1418, in _inlineCallbacks
result = g.send(result)
StopIteration: mxc://termina.org.uk/GZLyTGACVOyuzABpftmsbEoA
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File ""/usr/local/lib/python3.7/site-packages/synapse/federation/federation_client.py"", line 386, in _try_destination_list
res = yield callback(destination)
synapse.util.retryutils.NotRetryingDestination: Not retrying server matrix.org.
2020-04-16 12:37:34,140 - synapse.crypto.keyring:587 | WARNING - PUT-233716 - Key lookup failed from 'matrix.org': Not retrying server matrix.org.
```
Apparently mxc://termina.org.uk/GZLyTGACVOyuzABpftmsbEoA is my avatar.
I tried a few more times and while most of the time the error message is the
same, sometimes the failure takes longer (~10 seconds) and then the error
message is `No key for termina.org.uk with ids in ['ed25519:a_RZLi']
(min_validity 1587032954483)`.
The log then contained:
```
2020-04-16 12:53:10,508 - synapse.http.matrixfederationclient:526 | WARNING - POST-236855 - {GET-O-117737} [matrix.org] Request failed: GET matrix://matrix.org/_matrix/federation/v1/make_join/%21XfqLiaavxVgyMSiRwK%3Amatrix.org/%40dkasak%3Atermina.org.uk?ver=1&ver=2&ver=3&ver=4&ver=5&ver=org.matrix.msc2260: HttpResponseException(""401: b'Unauthorized'"")
```
This is the tombstone event:
```
{
""content"": {
""body"": ""This room has been replaced"",
""replacement_room"": ""!XfqLiaavxVgyMSiRwK:matrix.org""
},
""event_id"": ""$1580544874605BBkoe:matrix.org"",
""origin_server_ts"": 1580544874762,
""sender"": ""@jimmycuadra:matrix.org"",
""state_key"": """",
""type"": ""m.room.tombstone"",
""unsigned"": {
""age"": 3009
},
""room_id"": ""!wzHrsErnsyaqbpFiRQ:matrix.org""
}
```
### Steps to reproduce
1. Be a member of the tombstoned #ruma:matrix.org room
(`!wzHrsErnsyaqbpFiRQ:matrix.org`).
2. Click `The conversation continues here` link at the bottom from Riot.
I expect to be joined into the room, but the join fails.
### Version information
- **Homeserver**: termina.org.uk
- **Version**: 1.10.0
- **Install method**: package manager (`pkg` on FreeBSD)
- **Platform**: Freebsd 12.1
",
1001,https://api.github.com/repos/matrix-org/synapse/issues/7286,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7286/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7286/comments,https://api.github.com/repos/matrix-org/synapse/issues/7286/events,https://github.com/matrix-org/synapse/pull/7286,600939860,MDExOlB1bGxSZXF1ZXN0NDA0Mjc0MTQw,7286,"On catchup, process each row with its own stream id","{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,0,2020-04-16T10:45:52Z,2020-04-20T10:43:31Z,2020-04-20T10:43:30Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7286', 'html_url': 'https://github.com/matrix-org/synapse/pull/7286', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7286.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7286.patch'}","Other parts of the code (such as the StreamChangeCache) assume that there will
not be multiple changes with the same stream id.
This code was introduced in #7024, and I hope this fixes #7206.",
1002,https://api.github.com/repos/matrix-org/synapse/issues/7285,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7285/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7285/comments,https://api.github.com/repos/matrix-org/synapse/issues/7285/events,https://github.com/matrix-org/synapse/issues/7285,600920695,MDU6SXNzdWU2MDA5MjA2OTU=,7285,Misindention in saml2_config.sp_config section of generated configuration file,"{'login': 'frcl', 'id': 7346166, 'node_id': 'MDQ6VXNlcjczNDYxNjY=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/7346166?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/frcl', 'html_url': 'https://github.com/frcl', 'followers_url': 'https://api.github.com/users/frcl/followers', 'following_url': 'https://api.github.com/users/frcl/following{/other_user}', 'gists_url': 'https://api.github.com/users/frcl/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/frcl/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/frcl/subscriptions', 'organizations_url': 'https://api.github.com/users/frcl/orgs', 'repos_url': 'https://api.github.com/users/frcl/repos', 'events_url': 'https://api.github.com/users/frcl/events{/privacy}', 'received_events_url': 'https://api.github.com/users/frcl/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,2,2020-04-16T10:16:17Z,2020-04-20T15:51:39Z,2020-04-20T15:51:39Z,CONTRIBUTOR,,,"### Description
When one uses the `organization` and/or `contact_person` options for the SAML service provider, indented as in the generated `homeserver.yml`, synapse fails on startup with the following error.
```
Traceback (most recent call last):
File ""/usr/local/lib/python3.7/runpy.py"", line 193, in _run_module_as_main
""__main__"", mod_spec)
File ""/usr/local/lib/python3.7/runpy.py"", line 85, in _run_code
exec(code, run_globals)
File ""/usr/local/lib/python3.7/site-packages/synapse/app/homeserver.py"", line 651, in
main()
File ""/usr/local/lib/python3.7/site-packages/synapse/app/homeserver.py"", line 646, in main
hs = setup(sys.argv[1:])
File ""/usr/local/lib/python3.7/site-packages/synapse/app/homeserver.py"", line 324, in setup
""Synapse Homeserver"", config_options
File ""/usr/local/lib/python3.7/site-packages/synapse/config/_base.py"", line 629, in load_or_generate_config
config_dict, config_dir_path=config_dir_path, data_dir_path=data_dir_path
File ""/usr/local/lib/python3.7/site-packages/synapse/config/_base.py"", line 651, in parse_config_dict
data_dir_path=data_dir_path,
File ""/usr/local/lib/python3.7/site-packages/synapse/config/_base.py"", line 266, in invoke_all
res[name] = getattr(config, func_name)(*args, **kwargs)
File ""/usr/local/lib/python3.7/site-packages/synapse/config/saml2_config.py"", line 159, in read_config
self.saml2_sp_config.load(saml2_config_dict)
File ""/usr/local/lib/python3.7/site-packages/saml2/config.py"", line 382, in load
self.load_complex(cnf, metadata_construction=metadata_construction)
File ""/usr/local/lib/python3.7/site-packages/saml2/config.py"", line 316, in load_complex
self.load_metadata(cnf[""metadata""]))
File ""/usr/local/lib/python3.7/site-packages/saml2/config.py"", line 425, in load_metadata
mds.imp(metadata_conf)
File ""/usr/local/lib/python3.7/site-packages/saml2/mdstore.py"", line 1023, in imp
self.load(key, val)
File ""/usr/local/lib/python3.7/site-packages/saml2/mdstore.py"", line 1008, in load
raise SAMLError(""Unknown metadata type '%s'"" % typ)
saml2.SAMLError: Unknown metadata type 'organization'
```
The Problem is fixed by moving everything below the `metadata` option down by one indention level.
So this is an issue with the configuration file generating script, not with pysaml2.
### Steps to reproduce
- Generate `homeserver.yml` as described in the installation guide
- Uncomment in the `saml_config` section under `sp_config` the `metadata` option and at least one of `description`, `name`, `organization` and `contact_person`
- Start synapse
### Version information
- **Version**: Synapse v1.12.3
- **Install method**: Docker
",
1003,https://api.github.com/repos/matrix-org/synapse/issues/7284,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7284/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7284/comments,https://api.github.com/repos/matrix-org/synapse/issues/7284/events,https://github.com/matrix-org/synapse/pull/7284,600833347,MDExOlB1bGxSZXF1ZXN0NDA0MTg3MDE4,7284,Improve example TURN configuration,"{'login': 'nataraj-hates-MS-for-stealing-github', 'id': 48326335, 'node_id': 'MDQ6VXNlcjQ4MzI2MzM1', 'avatar_url': 'https://avatars3.githubusercontent.com/u/48326335?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/nataraj-hates-MS-for-stealing-github', 'html_url': 'https://github.com/nataraj-hates-MS-for-stealing-github', 'followers_url': 'https://api.github.com/users/nataraj-hates-MS-for-stealing-github/followers', 'following_url': 'https://api.github.com/users/nataraj-hates-MS-for-stealing-github/following{/other_user}', 'gists_url': 'https://api.github.com/users/nataraj-hates-MS-for-stealing-github/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/nataraj-hates-MS-for-stealing-github/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/nataraj-hates-MS-for-stealing-github/subscriptions', 'organizations_url': 'https://api.github.com/users/nataraj-hates-MS-for-stealing-github/orgs', 'repos_url': 'https://api.github.com/users/nataraj-hates-MS-for-stealing-github/repos', 'events_url': 'https://api.github.com/users/nataraj-hates-MS-for-stealing-github/events{/privacy}', 'received_events_url': 'https://api.github.com/users/nataraj-hates-MS-for-stealing-github/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,4,2020-04-16T08:07:28Z,2020-04-17T12:04:34Z,2020-04-17T12:04:24Z,CONTRIBUTOR,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7284', 'html_url': 'https://github.com/matrix-org/synapse/pull/7284', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7284.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7284.patch'}","Should use quotes for turn_shared_secret value, or it will not work
Me and my firends met same problem on this spot. When you are not familiar with software it is difficult to find why it does not work, when there are no quotes there...",
1004,https://api.github.com/repos/matrix-org/synapse/issues/7283,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7283/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7283/comments,https://api.github.com/repos/matrix-org/synapse/issues/7283/events,https://github.com/matrix-org/synapse/issues/7283,600558828,MDU6SXNzdWU2MDA1NTg4Mjg=,7283,rename username,"{'login': 'helmut72', 'id': 1388751, 'node_id': 'MDQ6VXNlcjEzODg3NTE=', 'avatar_url': 'https://avatars0.githubusercontent.com/u/1388751?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/helmut72', 'html_url': 'https://github.com/helmut72', 'followers_url': 'https://api.github.com/users/helmut72/followers', 'following_url': 'https://api.github.com/users/helmut72/following{/other_user}', 'gists_url': 'https://api.github.com/users/helmut72/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/helmut72/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/helmut72/subscriptions', 'organizations_url': 'https://api.github.com/users/helmut72/orgs', 'repos_url': 'https://api.github.com/users/helmut72/repos', 'events_url': 'https://api.github.com/users/helmut72/events{/privacy}', 'received_events_url': 'https://api.github.com/users/helmut72/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,1,2020-04-15T20:11:10Z,2020-04-16T09:21:22Z,2020-04-16T09:21:22Z,NONE,,,"**Description:**
Please add a feature to rename an username if the new username is free. At least for self hosted servers. If someone marries, she don't want to continue with her old name, but also don't want to lost her old chats.
Thank you",
1005,https://api.github.com/repos/matrix-org/synapse/issues/7282,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7282/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7282/comments,https://api.github.com/repos/matrix-org/synapse/issues/7282/events,https://github.com/matrix-org/synapse/issues/7282,600543893,MDU6SXNzdWU2MDA1NDM4OTM=,7282,Background process 'user_directory.notify_new_event' threw an exception,"{'login': 'rihardsk', 'id': 1666746, 'node_id': 'MDQ6VXNlcjE2NjY3NDY=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1666746?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/rihardsk', 'html_url': 'https://github.com/rihardsk', 'followers_url': 'https://api.github.com/users/rihardsk/followers', 'following_url': 'https://api.github.com/users/rihardsk/following{/other_user}', 'gists_url': 'https://api.github.com/users/rihardsk/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/rihardsk/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/rihardsk/subscriptions', 'organizations_url': 'https://api.github.com/users/rihardsk/orgs', 'repos_url': 'https://api.github.com/users/rihardsk/repos', 'events_url': 'https://api.github.com/users/rihardsk/events{/privacy}', 'received_events_url': 'https://api.github.com/users/rihardsk/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,4,2020-04-15T19:43:34Z,2020-04-17T15:24:59Z,2020-04-17T15:24:59Z,NONE,,,"### Description
My logs are flooded with exceptions `psycopg2.errors.InvalidColumnReference: there is no unique or exclusion constraint matching the ON CONFLICT specification`.
Here are the logs [invalidcolumnreference.error.redacted.log](https://github.com/matrix-org/synapse/files/4483206/invalidcolumnreference.error.redacted.log).
Thinking that this might be the same issue as #4453, i attempted to [trigger the regeneration of the directory info tables](https://github.com/matrix-org/synapse/blob/6fb63d6426b87e989143b6ff2679f5ae4a8fd22b/docs/user_directory.md) as suggested in a comment on that issue. After executing the linked sql script, the original exceptions are replaced with different ones:
```
synapse.storage.background_updates: [background_updates-0] Error doing update
Traceback (most recent call last):
File ""/nix/store/4i8bhyazmbk75frbbpigkhnyqaspw75k-matrix-synapse-1.12.1/lib/python3.7/site-packages/synapse/storage/background_updates.py"", line 109, in run_background_updates
self.BACKGROUND_UPDATE_DURATION_MS
File ""/nix/store/4i8bhyazmbk75frbbpigkhnyqaspw75k-matrix-synapse-1.12.1/lib/python3.7/site-packages/synapse/storage/background_updates.py"", line 205, in do_next_background_update
res = await self._do_background_update(update_name, desired_duration_ms)
File ""/nix/store/4i8bhyazmbk75frbbpigkhnyqaspw75k-matrix-synapse-1.12.1/lib/python3.7/site-packages/synapse/storage/background_updates.py"", line 239, in _do_background_update
items_updated = await update_handler(progress, batch_size)
File ""/nix/store/bmih96pr5vkyc6w67nixdk2y2pn94n7k-python3.7-Twisted-20.3.0/lib/python3.7/site-packages/twisted/internet/defer.py"", line 1416, in _inlineCallbacks
result = result.throwExceptionIntoGenerator(g)
File ""/nix/store/bmih96pr5vkyc6w67nixdk2y2pn94n7k-python3.7-Twisted-20.3.0/lib/python3.7/site-packages/twisted/python/failure.py"", line 512, in throwExceptionIntoGenerator
return g.throw(self.type, self.value, self.tb)
File ""/nix/store/4i8bhyazmbk75frbbpigkhnyqaspw75k-matrix-synapse-1.12.1/lib/python3.7/site-packages/synapse/storage/data_stores/main/user_directory.py"", line 207, in _populate_user_directory_proce>
user_id, profile.display_name, profile.avatar_url
File ""/nix/store/bmih96pr5vkyc6w67nixdk2y2pn94n7k-python3.7-Twisted-20.3.0/lib/python3.7/site-packages/twisted/internet/defer.py"", line 1416, in _inlineCallbacks
result = result.throwExceptionIntoGenerator(g)
File ""/nix/store/bmih96pr5vkyc6w67nixdk2y2pn94n7k-python3.7-Twisted-20.3.0/lib/python3.7/site-packages/twisted/python/failure.py"", line 512, in throwExceptionIntoGenerator
return g.throw(self.type, self.value, self.tb)
File ""/nix/store/4i8bhyazmbk75frbbpigkhnyqaspw75k-matrix-synapse-1.12.1/lib/python3.7/site-packages/synapse/storage/database.py"", line 524, in runInteraction
**kwargs
File ""/nix/store/bmih96pr5vkyc6w67nixdk2y2pn94n7k-python3.7-Twisted-20.3.0/lib/python3.7/site-packages/twisted/internet/defer.py"", line 1416, in _inlineCallbacks
result = result.throwExceptionIntoGenerator(g)
File ""/nix/store/bmih96pr5vkyc6w67nixdk2y2pn94n7k-python3.7-Twisted-20.3.0/lib/python3.7/site-packages/twisted/python/failure.py"", line 512, in throwExceptionIntoGenerator
return g.throw(self.type, self.value, self.tb)
File ""/nix/store/4i8bhyazmbk75frbbpigkhnyqaspw75k-matrix-synapse-1.12.1/lib/python3.7/site-packages/synapse/storage/database.py"", line 574, in runWithConnection
self._db_pool.runWithConnection(inner_func, *args, **kwargs)
File ""/nix/store/bmih96pr5vkyc6w67nixdk2y2pn94n7k-python3.7-Twisted-20.3.0/lib/python3.7/site-packages/twisted/python/threadpool.py"", line 250, in inContext
result = inContext.theWork()
File ""/nix/store/bmih96pr5vkyc6w67nixdk2y2pn94n7k-python3.7-Twisted-20.3.0/lib/python3.7/site-packages/twisted/python/threadpool.py"", line 266, in
inContext.theWork = lambda: context.call(ctx, func, *args, **kw)
File ""/nix/store/bmih96pr5vkyc6w67nixdk2y2pn94n7k-python3.7-Twisted-20.3.0/lib/python3.7/site-packages/twisted/python/context.py"", line 122, in callWithContext
return self.currentContext().callWithContext(ctx, func, *args, **kw)
File ""/nix/store/bmih96pr5vkyc6w67nixdk2y2pn94n7k-python3.7-Twisted-20.3.0/lib/python3.7/site-packages/twisted/python/context.py"", line 85, in callWithContext
return func(*args,**kw)
File ""/nix/store/bmih96pr5vkyc6w67nixdk2y2pn94n7k-python3.7-Twisted-20.3.0/lib/python3.7/site-packages/twisted/enterprise/adbapi.py"", line 306, in _runWithConnection
compat.reraise(excValue, excTraceback)
File ""/nix/store/bmih96pr5vkyc6w67nixdk2y2pn94n7k-python3.7-Twisted-20.3.0/lib/python3.7/site-packages/twisted/python/compat.py"", line 464, in reraise
raise exception.with_traceback(traceback)
File ""/nix/store/bmih96pr5vkyc6w67nixdk2y2pn94n7k-python3.7-Twisted-20.3.0/lib/python3.7/site-packages/twisted/enterprise/adbapi.py"", line 297, in _runWithConnection
result = func(conn, *args, **kw)
File ""/nix/store/4i8bhyazmbk75frbbpigkhnyqaspw75k-matrix-synapse-1.12.1/lib/python3.7/site-packages/synapse/storage/database.py"", line 571, in inner_func
return func(conn, *args, **kwargs)
File ""/nix/store/4i8bhyazmbk75frbbpigkhnyqaspw75k-matrix-synapse-1.12.1/lib/python3.7/site-packages/synapse/storage/database.py"", line 407, in new_transaction
r = func(cursor, *args, **kwargs)
File ""/nix/store/4i8bhyazmbk75frbbpigkhnyqaspw75k-matrix-synapse-1.12.1/lib/python3.7/site-packages/synapse/storage/data_stores/main/user_directory.py"", line 377, in _update_profile_in_user_dir_txn
lock=False, # We're only inserter
File ""/nix/store/4i8bhyazmbk75frbbpigkhnyqaspw75k-matrix-synapse-1.12.1/lib/python3.7/site-packages/synapse/storage/database.py"", line 767, in simple_upsert_txn
txn, table, keyvalues, values, insertion_values=insertion_values
File ""/nix/store/4i8bhyazmbk75frbbpigkhnyqaspw75k-matrix-synapse-1.12.1/lib/python3.7/site-packages/synapse/storage/database.py"", line 880, in simple_upsert_txn_native_upsert
txn.execute(sql, list(allvalues.values()))
File ""/nix/store/4i8bhyazmbk75frbbpigkhnyqaspw75k-matrix-synapse-1.12.1/lib/python3.7/site-packages/synapse/storage/database.py"", line 199, in execute
self._do_execute(self.txn.execute, sql, *args)
File ""/nix/store/4i8bhyazmbk75frbbpigkhnyqaspw75k-matrix-synapse-1.12.1/lib/python3.7/site-packages/synapse/storage/database.py"", line 225, in _do_execute
return func(sql, *args)
psycopg2.errors.InvalidColumnReference: there is no unique or exclusion constraint matching the ON CONFLICT specification
```
For completeness, here are the logs after running the sql script [error-doing-update.redacted.log](https://github.com/matrix-org/synapse/files/4483420/error-doing-update.redacted.log).
### Some background information
I had database corruption issues previously due to `LC_COLLATE` being set to `'UTF-8'` (as described in https://github.com/matrix-org/synapse/issues/6696#issuecomment-575280941). I attempted to fix the corruption by
1. backing up the synapse db,
2. dropping it,
3. recreating it with `LC_CTYPE` and `LC_COLLATE` settings changed from `'UTF-8'` to `'C'`,
4. importing the backup,
5. deleting duplicate rows in tables that were being complained about in the indexing step
6. and then exporting and importing the database again.
The last import was clean - the indexing step didn't complain about anything, but if there were some other duplicate rows that weren't indexed i would have missed them. Or there might have been some other issues.
### Version information
- **Homeserver**: my private homeserver
- **Version**: 1.12.1, but the original errors (before running the sql script) were also present on 1.9.1
- **Install method**: NixOS
- **Platform**: latest NixOS master branch (commit 01c8795673ecff6272895a085e9fe1ffa3b33620) running on a rockpro64 sbc (with a custom patched kernel).
",
1006,https://api.github.com/repos/matrix-org/synapse/issues/7281,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7281/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7281/comments,https://api.github.com/repos/matrix-org/synapse/issues/7281/events,https://github.com/matrix-org/synapse/pull/7281,600470509,MDExOlB1bGxSZXF1ZXN0NDAzODk0ODg5,7281,Add MultiWriterIdGenerator.,"{'login': 'erikjohnston', 'id': 8428120, 'node_id': 'MDQ6VXNlcjg0MjgxMjA=', 'avatar_url': 'https://avatars0.githubusercontent.com/u/8428120?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/erikjohnston', 'html_url': 'https://github.com/erikjohnston', 'followers_url': 'https://api.github.com/users/erikjohnston/followers', 'following_url': 'https://api.github.com/users/erikjohnston/following{/other_user}', 'gists_url': 'https://api.github.com/users/erikjohnston/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/erikjohnston/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/erikjohnston/subscriptions', 'organizations_url': 'https://api.github.com/users/erikjohnston/orgs', 'repos_url': 'https://api.github.com/users/erikjohnston/repos', 'events_url': 'https://api.github.com/users/erikjohnston/events{/privacy}', 'received_events_url': 'https://api.github.com/users/erikjohnston/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,"{'login': 'clokep', 'id': 517124, 'node_id': 'MDQ6VXNlcjUxNzEyNA==', 'avatar_url': 'https://avatars2.githubusercontent.com/u/517124?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/clokep', 'html_url': 'https://github.com/clokep', 'followers_url': 'https://api.github.com/users/clokep/followers', 'following_url': 'https://api.github.com/users/clokep/following{/other_user}', 'gists_url': 'https://api.github.com/users/clokep/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/clokep/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/clokep/subscriptions', 'organizations_url': 'https://api.github.com/users/clokep/orgs', 'repos_url': 'https://api.github.com/users/clokep/repos', 'events_url': 'https://api.github.com/users/clokep/events{/privacy}', 'received_events_url': 'https://api.github.com/users/clokep/received_events', 'type': 'User', 'site_admin': False}","[{'login': 'clokep', 'id': 517124, 'node_id': 'MDQ6VXNlcjUxNzEyNA==', 'avatar_url': 'https://avatars2.githubusercontent.com/u/517124?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/clokep', 'html_url': 'https://github.com/clokep', 'followers_url': 'https://api.github.com/users/clokep/followers', 'following_url': 'https://api.github.com/users/clokep/following{/other_user}', 'gists_url': 'https://api.github.com/users/clokep/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/clokep/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/clokep/subscriptions', 'organizations_url': 'https://api.github.com/users/clokep/orgs', 'repos_url': 'https://api.github.com/users/clokep/repos', 'events_url': 'https://api.github.com/users/clokep/events{/privacy}', 'received_events_url': 'https://api.github.com/users/clokep/received_events', 'type': 'User', 'site_admin': False}]",,2,2020-04-15T17:32:23Z,2020-05-04T16:17:47Z,2020-05-04T16:17:45Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7281', 'html_url': 'https://github.com/matrix-org/synapse/pull/7281', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7281.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7281.patch'}","This will be used to coordinate stream IDs across multiple writers, though is currently unused. Only works with Postgres.
Functions as the equivalent of both `StreamIdGenerator` and `SlavedIdTracker`.
(This is an implementation of what is talked about in the design doc: https://docs.google.com/document/d/1xL1foUsHgcHdVTOAMSJIST04cH0ukHd-oCKFw3m9sxY/edit?usp=sharing )",
1007,https://api.github.com/repos/matrix-org/synapse/issues/7280,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7280/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7280/comments,https://api.github.com/repos/matrix-org/synapse/issues/7280/events,https://github.com/matrix-org/synapse/issues/7280,600406450,MDU6SXNzdWU2MDA0MDY0NTA=,7280,Improve customizability and consistency of templates,"{'login': 'clokep', 'id': 517124, 'node_id': 'MDQ6VXNlcjUxNzEyNA==', 'avatar_url': 'https://avatars2.githubusercontent.com/u/517124?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/clokep', 'html_url': 'https://github.com/clokep', 'followers_url': 'https://api.github.com/users/clokep/followers', 'following_url': 'https://api.github.com/users/clokep/following{/other_user}', 'gists_url': 'https://api.github.com/users/clokep/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/clokep/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/clokep/subscriptions', 'organizations_url': 'https://api.github.com/users/clokep/orgs', 'repos_url': 'https://api.github.com/users/clokep/repos', 'events_url': 'https://api.github.com/users/clokep/events{/privacy}', 'received_events_url': 'https://api.github.com/users/clokep/received_events', 'type': 'User', 'site_admin': False}","[{'id': 477043174, 'node_id': 'MDU6TGFiZWw0NzcwNDMxNzQ=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/feature', 'name': 'feature', 'color': 'bfd4f2', 'default': False, 'description': None}, {'id': 477050471, 'node_id': 'MDU6TGFiZWw0NzcwNTA0NzE=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/p3', 'name': 'p3', 'color': '0e8a16', 'default': False, 'description': None}]",open,False,,[],,3,2020-04-15T15:55:20Z,2020-04-16T11:26:08Z,,MEMBER,,,"Some new templates were added recently that dealt with SSO (#7102, #7240, #7279, #7067), but I think this is a wider issue.
There's a few oddities with the templates used in Synapse:
* [Some are hard-coded HTML embedded in Python](https://github.com/matrix-org/synapse/blob/6fb63d6426b87e989143b6ff2679f5ae4a8fd22b/synapse/rest/client/v2_alpha/auth.py#L28-L114) (this is non-ideal due to no syntax highlighting in editors, etc as well as not being customizable).
* Some ""templates"" are loaded [as raw HTML files](https://github.com/matrix-org/synapse/blob/229eb81498b0fe1da81e9b5b333a0285acde9446/synapse/config/emailconfig.py#L227-L245), but some are [treated as Jinja2](https://github.com/matrix-org/synapse/blob/229eb81498b0fe1da81e9b5b333a0285acde9446/synapse/handlers/auth.py#L116-L119). (Note also that some of those are loaded during the configuration step, while some are loaded while handlers are initialized.)
* There's a variety of template directories that must be configured: `account_validity`, `saml2_config`, `sso`, `email`, `user_consent`.
* Some of those template directories also allow you to customize the names of templates, while others use hard-coded names (e.g. the `account_renewed_html_path` setting vs. SSO uses hard-coded names).
I think there's a few concrete things we could do to improve this situation:
* Use a single template directory and allow the user to configure it in a single place.
* Treat all template files as Jinja (even if they don't have variable expressions there could be other reasons you'd want it to be Jinja).
* Hard-code all template names and document them well.
* (Somewhat unrelated, but...) Fix #6583 so that missing templates don't break Synapse.",
1008,https://api.github.com/repos/matrix-org/synapse/issues/7279,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7279/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7279/comments,https://api.github.com/repos/matrix-org/synapse/issues/7279/events,https://github.com/matrix-org/synapse/pull/7279,600379209,MDExOlB1bGxSZXF1ZXN0NDAzODI1OTY4,7279,Use a template for the SSO success page to allow for customization.,"{'login': 'clokep', 'id': 517124, 'node_id': 'MDQ6VXNlcjUxNzEyNA==', 'avatar_url': 'https://avatars2.githubusercontent.com/u/517124?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/clokep', 'html_url': 'https://github.com/clokep', 'followers_url': 'https://api.github.com/users/clokep/followers', 'following_url': 'https://api.github.com/users/clokep/following{/other_user}', 'gists_url': 'https://api.github.com/users/clokep/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/clokep/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/clokep/subscriptions', 'organizations_url': 'https://api.github.com/users/clokep/orgs', 'repos_url': 'https://api.github.com/users/clokep/repos', 'events_url': 'https://api.github.com/users/clokep/events{/privacy}', 'received_events_url': 'https://api.github.com/users/clokep/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,1,2020-04-15T15:19:07Z,2020-04-17T17:34:57Z,2020-04-17T17:34:56Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7279', 'html_url': 'https://github.com/matrix-org/synapse/pull/7279', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7279.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7279.patch'}","This fixes a bug from #7102 -- the steps in the SSO authentication flow have customizable templates, except the success template, which was re-used from the fallback authentication flow.
This breaks that dependency and adds a new template for a successful SSO authentication. As part of this I moved the `SUCCESS_TEMPLATE` back to where it used to belong.
I filed #7280 about treating templates better.",
1009,https://api.github.com/repos/matrix-org/synapse/issues/7278,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7278/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7278/comments,https://api.github.com/repos/matrix-org/synapse/issues/7278/events,https://github.com/matrix-org/synapse/pull/7278,600284800,MDExOlB1bGxSZXF1ZXN0NDAzNzQ5MjYy,7278,Add some replication tests,"{'login': 'erikjohnston', 'id': 8428120, 'node_id': 'MDQ6VXNlcjg0MjgxMjA=', 'avatar_url': 'https://avatars0.githubusercontent.com/u/8428120?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/erikjohnston', 'html_url': 'https://github.com/erikjohnston', 'followers_url': 'https://api.github.com/users/erikjohnston/followers', 'following_url': 'https://api.github.com/users/erikjohnston/following{/other_user}', 'gists_url': 'https://api.github.com/users/erikjohnston/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/erikjohnston/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/erikjohnston/subscriptions', 'organizations_url': 'https://api.github.com/users/erikjohnston/orgs', 'repos_url': 'https://api.github.com/users/erikjohnston/repos', 'events_url': 'https://api.github.com/users/erikjohnston/events{/privacy}', 'received_events_url': 'https://api.github.com/users/erikjohnston/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,0,2020-04-15T13:08:58Z,2020-04-28T16:42:06Z,2020-04-28T16:42:04Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7278', 'html_url': 'https://github.com/matrix-org/synapse/pull/7278', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7278.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7278.patch'}","Specifically some tests for the typing stream, which means we test streams that fetch missing updates via HTTP (rather than via the DB).
We also shuffle things around a bit so that we create two separate `HomeServer` objects, rather than trying to insert a slaved store into places.
Note: `test_typing.py` is heavily inspired by `test_receipts.py`",
1010,https://api.github.com/repos/matrix-org/synapse/issues/7277,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7277/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7277/comments,https://api.github.com/repos/matrix-org/synapse/issues/7277/events,https://github.com/matrix-org/synapse/issues/7277,600266529,MDU6SXNzdWU2MDAyNjY1Mjk=,7277,"Allow for configuring url preview Accept-Language headers on a per-user, per-room and per-group basis","{'login': 'anoadragon453', 'id': 1342360, 'node_id': 'MDQ6VXNlcjEzNDIzNjA=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1342360?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/anoadragon453', 'html_url': 'https://github.com/anoadragon453', 'followers_url': 'https://api.github.com/users/anoadragon453/followers', 'following_url': 'https://api.github.com/users/anoadragon453/following{/other_user}', 'gists_url': 'https://api.github.com/users/anoadragon453/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/anoadragon453/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/anoadragon453/subscriptions', 'organizations_url': 'https://api.github.com/users/anoadragon453/orgs', 'repos_url': 'https://api.github.com/users/anoadragon453/repos', 'events_url': 'https://api.github.com/users/anoadragon453/events{/privacy}', 'received_events_url': 'https://api.github.com/users/anoadragon453/received_events', 'type': 'User', 'site_admin': False}","[{'id': 477050471, 'node_id': 'MDU6TGFiZWw0NzcwNTA0NzE=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/p3', 'name': 'p3', 'color': '0e8a16', 'default': False, 'description': None}]",open,False,,[],,0,2020-04-15T12:39:26Z,2020-04-15T12:39:36Z,,MEMBER,,,"As of #7265, a server admin can specify the preferred language that URL previews should appear in. However, you may have a homeserver made up of people who speak multiple languages, who would prefer URL previews to appear in their own language.
Ideally you could set a default URL preview language in your client's settings, in room settings, in a group's settings, and the server would figure out which language best to request for you from the remote server.
Will require spec work and making sure this works with other media repository implementations.
Previous discussion: https://github.com/matrix-org/synapse/issues/3037",
1011,https://api.github.com/repos/matrix-org/synapse/issues/7276,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7276/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7276/comments,https://api.github.com/repos/matrix-org/synapse/issues/7276/events,https://github.com/matrix-org/synapse/issues/7276,600199058,MDU6SXNzdWU2MDAxOTkwNTg=,7276,Signature upload fails due to missing keys,"{'login': 'dbkr', 'id': 986903, 'node_id': 'MDQ6VXNlcjk4NjkwMw==', 'avatar_url': 'https://avatars1.githubusercontent.com/u/986903?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/dbkr', 'html_url': 'https://github.com/dbkr', 'followers_url': 'https://api.github.com/users/dbkr/followers', 'following_url': 'https://api.github.com/users/dbkr/following{/other_user}', 'gists_url': 'https://api.github.com/users/dbkr/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/dbkr/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/dbkr/subscriptions', 'organizations_url': 'https://api.github.com/users/dbkr/orgs', 'repos_url': 'https://api.github.com/users/dbkr/repos', 'events_url': 'https://api.github.com/users/dbkr/events{/privacy}', 'received_events_url': 'https://api.github.com/users/dbkr/received_events', 'type': 'User', 'site_admin': False}","[{'id': 121086029, 'node_id': 'MDU6TGFiZWwxMjEwODYwMjk=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/bug', 'name': 'bug', 'color': 'fc2929', 'default': True, 'description': None}, {'id': 1631939447, 'node_id': 'MDU6TGFiZWwxNjMxOTM5NDQ3', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/cross-signing-sprint', 'name': 'cross-signing-sprint', 'color': '730adb', 'default': False, 'description': ''}, {'id': 1581464420, 'node_id': 'MDU6TGFiZWwxNTgxNDY0NDIw', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/phase:3', 'name': 'phase:3', 'color': 'c5e567', 'default': False, 'description': ''}, {'id': 1709952070, 'node_id': 'MDU6TGFiZWwxNzA5OTUyMDcw', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/story:2', 'name': 'story:2', 'color': 'b4f291', 'default': False, 'description': 'As a user I want to verify other users so that I can trust they are who they say they are'}]",open,False,,[],,5,2020-04-15T10:39:19Z,2020-04-22T16:11:41Z,,MEMBER,,,"Upstream bug: https://github.com/vector-im/riot-web/issues/12973
We are seeing signature uploads fail because synapse doesn't have the cross-signing keys for the user in question:
```
{
""@davetestissdjlkfghndklsfjngjlk:dbkr.me"": {
""bO6OqlA3AjbjPOxW7kSfx8N5KHnDU9rjlBWiaCYQOlo"": {
""status"": 404,
""errcode"": ""M_NOT_FOUND"",
""message"": ""404: No master key found for @davetestissdjlkfghndklsfjngjlk:dbkr.me""
}
}
}
```
One cause of this bug was https://github.com/matrix-org/synapse/issues/7252 which is now fixed but the problem still persists.
A reliable way to repro this seems to be to register fresh accounts on matrix.org and a different server, start a chat between them and then verifying the other user. The matrix.org side will fail with the above error.",
1012,https://api.github.com/repos/matrix-org/synapse/issues/7275,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7275/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7275/comments,https://api.github.com/repos/matrix-org/synapse/issues/7275/events,https://github.com/matrix-org/synapse/pull/7275,600196902,MDExOlB1bGxSZXF1ZXN0NDAzNjc4Mzkx,7275,Add some warnings and notes about slow upgrade,"{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,1,2020-04-15T10:35:38Z,2020-04-15T11:40:45Z,2020-04-15T11:40:43Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7275', 'html_url': 'https://github.com/matrix-org/synapse/pull/7275', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7275.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7275.patch'}","Fixes #7144.
Note that this PR is made against master, since it's updating documentation for an earlier release.",
1013,https://api.github.com/repos/matrix-org/synapse/issues/7274,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7274/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7274/comments,https://api.github.com/repos/matrix-org/synapse/issues/7274/events,https://github.com/matrix-org/synapse/pull/7274,599724407,MDExOlB1bGxSZXF1ZXN0NDAzMzA4MTgx,7274,Fix a potentially-huge sql query,"{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,1,2020-04-14T17:07:37Z,2020-04-15T09:16:37Z,2020-04-15T09:16:36Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7274', 'html_url': 'https://github.com/matrix-org/synapse/pull/7274', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7274.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7274.patch'}","We could end up looking up tens of thousands of events, which could cause large
amounts of data to be logged to the postgres log.",
1014,https://api.github.com/repos/matrix-org/synapse/issues/7273,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7273/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7273/comments,https://api.github.com/repos/matrix-org/synapse/issues/7273/events,https://github.com/matrix-org/synapse/issues/7273,599614366,MDU6SXNzdWU1OTk2MTQzNjY=,7273,Calls failing from outside firewall,"{'login': 'mowtheair', 'id': 63654564, 'node_id': 'MDQ6VXNlcjYzNjU0NTY0', 'avatar_url': 'https://avatars1.githubusercontent.com/u/63654564?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/mowtheair', 'html_url': 'https://github.com/mowtheair', 'followers_url': 'https://api.github.com/users/mowtheair/followers', 'following_url': 'https://api.github.com/users/mowtheair/following{/other_user}', 'gists_url': 'https://api.github.com/users/mowtheair/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/mowtheair/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/mowtheair/subscriptions', 'organizations_url': 'https://api.github.com/users/mowtheair/orgs', 'repos_url': 'https://api.github.com/users/mowtheair/repos', 'events_url': 'https://api.github.com/users/mowtheair/events{/privacy}', 'received_events_url': 'https://api.github.com/users/mowtheair/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,2,2020-04-14T14:25:36Z,2020-04-15T18:42:02Z,2020-04-15T11:32:49Z,NONE,,,"I have a matrix/synapse setup running on debian 10 with Riot.im app on iOS. When I try to initiate a phone call from outside of my firewall, it connects with no audio, then fails. App simply says ""error"". Internally on the LAN behind the firewall all is well - voice, video, etc. Chat and general site access are fine from external clients, just the voice and video having an issue. The only thing I see that looks strange to me in the logs is the following:
2020-04-14 10:07:30,213 - synapse.http.site - 203 - WARNING - GET-2344 - Error processing request : Connection was closed cleanly.
I think it might be firewall related, but am not sure. Any help would be greatly appreciated! Thanks in advance.
this is the installation procedure I followed:
https://matrix.org/blog/2020/04/06/running-your-own-secure-communication-service-with-matrix-and-jitsi ",
1015,https://api.github.com/repos/matrix-org/synapse/issues/7272,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7272/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7272/comments,https://api.github.com/repos/matrix-org/synapse/issues/7272/events,https://github.com/matrix-org/synapse/pull/7272,599562509,MDExOlB1bGxSZXF1ZXN0NDAzMTc1NzI4,7272,Fixup media_storage_providers options comments,"{'login': 'tristanlins', 'id': 343404, 'node_id': 'MDQ6VXNlcjM0MzQwNA==', 'avatar_url': 'https://avatars0.githubusercontent.com/u/343404?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/tristanlins', 'html_url': 'https://github.com/tristanlins', 'followers_url': 'https://api.github.com/users/tristanlins/followers', 'following_url': 'https://api.github.com/users/tristanlins/following{/other_user}', 'gists_url': 'https://api.github.com/users/tristanlins/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/tristanlins/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/tristanlins/subscriptions', 'organizations_url': 'https://api.github.com/users/tristanlins/orgs', 'repos_url': 'https://api.github.com/users/tristanlins/repos', 'events_url': 'https://api.github.com/users/tristanlins/events{/privacy}', 'received_events_url': 'https://api.github.com/users/tristanlins/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,11,2020-04-14T13:13:14Z,2020-04-17T11:09:44Z,2020-04-17T11:09:33Z,CONTRIBUTOR,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7272', 'html_url': 'https://github.com/matrix-org/synapse/pull/7272', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7272.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7272.patch'}","Update the comments for the generated configuration.
Taken from line 46-48:
https://github.com/matrix-org/synapse/blob/9dfcf47e9bb323f0597ebf8f34a1bcc9f14a02a1/synapse/config/repository.py#L46-L48",
1016,https://api.github.com/repos/matrix-org/synapse/issues/7271,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7271/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7271/comments,https://api.github.com/repos/matrix-org/synapse/issues/7271/events,https://github.com/matrix-org/synapse/pull/7271,599550254,MDExOlB1bGxSZXF1ZXN0NDAzMTY2MTc5,7271,Do not treat display names as globs for push rules.,"{'login': 'clokep', 'id': 517124, 'node_id': 'MDQ6VXNlcjUxNzEyNA==', 'avatar_url': 'https://avatars2.githubusercontent.com/u/517124?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/clokep', 'html_url': 'https://github.com/clokep', 'followers_url': 'https://api.github.com/users/clokep/followers', 'following_url': 'https://api.github.com/users/clokep/following{/other_user}', 'gists_url': 'https://api.github.com/users/clokep/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/clokep/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/clokep/subscriptions', 'organizations_url': 'https://api.github.com/users/clokep/orgs', 'repos_url': 'https://api.github.com/users/clokep/repos', 'events_url': 'https://api.github.com/users/clokep/events{/privacy}', 'received_events_url': 'https://api.github.com/users/clokep/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,1,2020-04-14T12:53:52Z,2020-04-22T13:32:31Z,2020-04-16T14:52:55Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7271', 'html_url': 'https://github.com/matrix-org/synapse/pull/7271', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7271.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7271.patch'}","This fixes #6641 by treating display names as normal strings, not globs.
## Questions
* [x] Do we want to use the `regex_cache` here?
* I added an additional commit which expands the cache to handle non-globbed content.
* [x] How do we test this?
* I tested this usually notifications in Riot.",
1017,https://api.github.com/repos/matrix-org/synapse/issues/7270,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7270/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7270/comments,https://api.github.com/repos/matrix-org/synapse/issues/7270/events,https://github.com/matrix-org/synapse/issues/7270,599128809,MDU6SXNzdWU1OTkxMjg4MDk=,7270,redactions don't necessarily appear/apply when peeking,"{'login': 'ara4n', 'id': 1294269, 'node_id': 'MDQ6VXNlcjEyOTQyNjk=', 'avatar_url': 'https://avatars2.githubusercontent.com/u/1294269?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/ara4n', 'html_url': 'https://github.com/ara4n', 'followers_url': 'https://api.github.com/users/ara4n/followers', 'following_url': 'https://api.github.com/users/ara4n/following{/other_user}', 'gists_url': 'https://api.github.com/users/ara4n/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/ara4n/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/ara4n/subscriptions', 'organizations_url': 'https://api.github.com/users/ara4n/orgs', 'repos_url': 'https://api.github.com/users/ara4n/repos', 'events_url': 'https://api.github.com/users/ara4n/events{/privacy}', 'received_events_url': 'https://api.github.com/users/ara4n/received_events', 'type': 'User', 'site_admin': False}","[{'id': 121086029, 'node_id': 'MDU6TGFiZWwxMjEwODYwMjk=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/bug', 'name': 'bug', 'color': 'fc2929', 'default': True, 'description': None}, {'id': 477043173, 'node_id': 'MDU6TGFiZWw0NzcwNDMxNzM=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/p2', 'name': 'p2', 'color': 'fbca04', 'default': False, 'description': None}]",open,False,,[],,0,2020-04-13T20:51:26Z,2020-04-29T14:08:08Z,,MEMBER,,,might be peeking getting stuck; might be redactions being mishandled,
1018,https://api.github.com/repos/matrix-org/synapse/issues/7269,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7269/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7269/comments,https://api.github.com/repos/matrix-org/synapse/issues/7269/events,https://github.com/matrix-org/synapse/issues/7269,599116678,MDU6SXNzdWU1OTkxMTY2Nzg=,7269,Authenticate against /etc/passwd,"{'login': 'tgy', 'id': 694873, 'node_id': 'MDQ6VXNlcjY5NDg3Mw==', 'avatar_url': 'https://avatars2.githubusercontent.com/u/694873?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/tgy', 'html_url': 'https://github.com/tgy', 'followers_url': 'https://api.github.com/users/tgy/followers', 'following_url': 'https://api.github.com/users/tgy/following{/other_user}', 'gists_url': 'https://api.github.com/users/tgy/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/tgy/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/tgy/subscriptions', 'organizations_url': 'https://api.github.com/users/tgy/orgs', 'repos_url': 'https://api.github.com/users/tgy/repos', 'events_url': 'https://api.github.com/users/tgy/events{/privacy}', 'received_events_url': 'https://api.github.com/users/tgy/received_events', 'type': 'User', 'site_admin': False}","[{'id': 477046074, 'node_id': 'MDU6TGFiZWw0NzcwNDYwNzQ=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/auth', 'name': 'auth', 'color': 'ededed', 'default': False, 'description': None}, {'id': 477043174, 'node_id': 'MDU6TGFiZWw0NzcwNDMxNzQ=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/feature', 'name': 'feature', 'color': 'bfd4f2', 'default': False, 'description': None}, {'id': 477050471, 'node_id': 'MDU6TGFiZWw0NzcwNTA0NzE=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/p3', 'name': 'p3', 'color': '0e8a16', 'default': False, 'description': None}]",open,False,,[],,0,2020-04-13T20:28:29Z,2020-04-20T15:15:14Z,,NONE,,,"**Description:**
Use `/etc/passwd` and `/etc/shadow` for authenticating users.
This could be useful in a small organisation's setup.",
1019,https://api.github.com/repos/matrix-org/synapse/issues/7268,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7268/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7268/comments,https://api.github.com/repos/matrix-org/synapse/issues/7268/events,https://github.com/matrix-org/synapse/pull/7268,598996441,MDExOlB1bGxSZXF1ZXN0NDAyNzMwMDU3,7268,Explicitly create UI Auth sessions,"{'login': 'clokep', 'id': 517124, 'node_id': 'MDQ6VXNlcjUxNzEyNA==', 'avatar_url': 'https://avatars2.githubusercontent.com/u/517124?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/clokep', 'html_url': 'https://github.com/clokep', 'followers_url': 'https://api.github.com/users/clokep/followers', 'following_url': 'https://api.github.com/users/clokep/following{/other_user}', 'gists_url': 'https://api.github.com/users/clokep/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/clokep/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/clokep/subscriptions', 'organizations_url': 'https://api.github.com/users/clokep/orgs', 'repos_url': 'https://api.github.com/users/clokep/repos', 'events_url': 'https://api.github.com/users/clokep/events{/privacy}', 'received_events_url': 'https://api.github.com/users/clokep/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,6,2020-04-13T16:45:09Z,2020-04-20T12:54:44Z,2020-04-20T12:54:43Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7268', 'html_url': 'https://github.com/matrix-org/synapse/pull/7268', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7268.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7268.patch'}","This makes a tweak to the way that UI Auth sessions get created that I think will be necessary to persist UI Auth sessions (for #6705). UI auth sessions are now created explicitly when no session ID is provided (i.e. at the beginning of a UI auth negotiation).
This does have a change of behavior that clients might notice, but I think being stricter here avoids an abuse channel. Instead of lazily creating sessions if the UI Auth session is unknown (e.g. if the session ID is not found) this will now error with an unknown session.
As far as I can tell the [result is unspecced when an unknown session ID](https://matrix.org/docs/spec/client_server/r0.6.0#user-interactive-authentication-api) is provided, so the previous behavior was being generous, but does not need to be supported.",
1020,https://api.github.com/repos/matrix-org/synapse/issues/7267,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7267/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7267/comments,https://api.github.com/repos/matrix-org/synapse/issues/7267/events,https://github.com/matrix-org/synapse/pull/7267,598860225,MDExOlB1bGxSZXF1ZXN0NDAyNjIxNTkz,7267,Email notifications for new users when creating via the Admin API.,"{'login': 'dklimpel', 'id': 5740567, 'node_id': 'MDQ6VXNlcjU3NDA1Njc=', 'avatar_url': 'https://avatars2.githubusercontent.com/u/5740567?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/dklimpel', 'html_url': 'https://github.com/dklimpel', 'followers_url': 'https://api.github.com/users/dklimpel/followers', 'following_url': 'https://api.github.com/users/dklimpel/following{/other_user}', 'gists_url': 'https://api.github.com/users/dklimpel/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/dklimpel/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/dklimpel/subscriptions', 'organizations_url': 'https://api.github.com/users/dklimpel/orgs', 'repos_url': 'https://api.github.com/users/dklimpel/repos', 'events_url': 'https://api.github.com/users/dklimpel/events{/privacy}', 'received_events_url': 'https://api.github.com/users/dklimpel/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,0,2020-04-13T12:24:37Z,2020-06-01T15:24:31Z,2020-06-01T14:34:34Z,CONTRIBUTOR,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7267', 'html_url': 'https://github.com/matrix-org/synapse/pull/7267', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7267.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7267.patch'}","Fixes #7135
Add `add_pusher` to `PUT ""/_synapse/admin/v2/users/""` when creating a new user
### Pull Request Checklist
* [x] Pull request is based on the develop branch
* [x] Pull request includes a [changelog file](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#changelog). The entry should:
- Be a short description of your change which makes sense to users. ""Fixed a bug that prevented receiving messages from other servers."" instead of ""Moved X method from `EventStore` to `EventWorkerStore`."".
- Use markdown where necessary, mostly for `code blocks`.
- End with either a period (.) or an exclamation mark (!).
- Start with a capital letter.
* [x] Pull request includes a [sign off](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#sign-off)
* [x] Code style is correct (run the [linters](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#code-style))
",
1021,https://api.github.com/repos/matrix-org/synapse/issues/7266,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7266/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7266/comments,https://api.github.com/repos/matrix-org/synapse/issues/7266/events,https://github.com/matrix-org/synapse/pull/7266,598795177,MDExOlB1bGxSZXF1ZXN0NDAyNTcwNTIz,7266,Feature/cas configs,"{'login': 'emmandev', 'id': 20469652, 'node_id': 'MDQ6VXNlcjIwNDY5NjUy', 'avatar_url': 'https://avatars1.githubusercontent.com/u/20469652?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/emmandev', 'html_url': 'https://github.com/emmandev', 'followers_url': 'https://api.github.com/users/emmandev/followers', 'following_url': 'https://api.github.com/users/emmandev/following{/other_user}', 'gists_url': 'https://api.github.com/users/emmandev/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/emmandev/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/emmandev/subscriptions', 'organizations_url': 'https://api.github.com/users/emmandev/orgs', 'repos_url': 'https://api.github.com/users/emmandev/repos', 'events_url': 'https://api.github.com/users/emmandev/events{/privacy}', 'received_events_url': 'https://api.github.com/users/emmandev/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,0,2020-04-13T09:56:08Z,2020-04-13T09:56:51Z,2020-04-13T09:56:35Z,NONE,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7266', 'html_url': 'https://github.com/matrix-org/synapse/pull/7266', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7266.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7266.patch'}","### Pull Request Checklist
* [ ] Pull request is based on the develop branch
* [ ] Pull request includes a [changelog file](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#changelog). The entry should:
- Be a short description of your change which makes sense to users. ""Fixed a bug that prevented receiving messages from other servers."" instead of ""Moved X method from `EventStore` to `EventWorkerStore`."".
- Use markdown where necessary, mostly for `code blocks`.
- End with either a period (.) or an exclamation mark (!).
- Start with a capital letter.
* [ ] Pull request includes a [sign off](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#sign-off)
* [ ] Code style is correct (run the [linters](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#code-style))
",
1022,https://api.github.com/repos/matrix-org/synapse/issues/7265,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7265/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7265/comments,https://api.github.com/repos/matrix-org/synapse/issues/7265/events,https://github.com/matrix-org/synapse/pull/7265,598509270,MDExOlB1bGxSZXF1ZXN0NDAyMzU1MDA2,7265,Allow specifying the value of Accept-Language header for URL previews,"{'login': 'anoadragon453', 'id': 1342360, 'node_id': 'MDQ6VXNlcjEzNDIzNjA=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1342360?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/anoadragon453', 'html_url': 'https://github.com/anoadragon453', 'followers_url': 'https://api.github.com/users/anoadragon453/followers', 'following_url': 'https://api.github.com/users/anoadragon453/following{/other_user}', 'gists_url': 'https://api.github.com/users/anoadragon453/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/anoadragon453/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/anoadragon453/subscriptions', 'organizations_url': 'https://api.github.com/users/anoadragon453/orgs', 'repos_url': 'https://api.github.com/users/anoadragon453/repos', 'events_url': 'https://api.github.com/users/anoadragon453/events{/privacy}', 'received_events_url': 'https://api.github.com/users/anoadragon453/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,2,2020-04-12T15:25:53Z,2020-04-15T12:42:21Z,2020-04-15T12:35:30Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7265', 'html_url': 'https://github.com/matrix-org/synapse/pull/7265', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7265.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7265.patch'}","Addresses: https://github.com/matrix-org/synapse/issues/3037
Adds a config option that allows server operates to specify their preferred language when generating URL previews.
Should hopefully help fix URL previews from YouTube being in a foreign language.
Details on the Accept-Language HTTP header: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Accept-Language",
1023,https://api.github.com/repos/matrix-org/synapse/issues/7264,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7264/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7264/comments,https://api.github.com/repos/matrix-org/synapse/issues/7264/events,https://github.com/matrix-org/synapse/issues/7264,598344619,MDU6SXNzdWU1OTgzNDQ2MTk=,7264,yaml type errors in homeserver.yaml + synctl crashes with a very obscure traceback,"{'login': 'ara4n', 'id': 1294269, 'node_id': 'MDQ6VXNlcjEyOTQyNjk=', 'avatar_url': 'https://avatars2.githubusercontent.com/u/1294269?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/ara4n', 'html_url': 'https://github.com/ara4n', 'followers_url': 'https://api.github.com/users/ara4n/followers', 'following_url': 'https://api.github.com/users/ara4n/following{/other_user}', 'gists_url': 'https://api.github.com/users/ara4n/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/ara4n/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/ara4n/subscriptions', 'organizations_url': 'https://api.github.com/users/ara4n/orgs', 'repos_url': 'https://api.github.com/users/ara4n/repos', 'events_url': 'https://api.github.com/users/ara4n/events{/privacy}', 'received_events_url': 'https://api.github.com/users/ara4n/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,1,2020-04-11T20:26:16Z,2020-04-11T20:53:30Z,2020-04-11T20:53:29Z,MEMBER,,,"When following the instructions from https://www.mytinydc.com/en/blog/matrix-synapse-installationserver-riotclient/ , someone ended up with this stacktrace:
```
Apr 11 16:33:07 matrix-bridges systemd[1]: Starting Matrix Synapse service...
Apr 11 16:33:08 matrix-bridges synapse[6050]: Traceback (most recent call last):
Apr 11 16:33:08 matrix-bridges synapse[6050]: File ""/usr/lib/python3.7/runpy.py"", line 193, in _run_module_as_main
Apr 11 16:33:08 matrix-bridges synapse[6050]: ""__main__"", mod_spec)
Apr 11 16:33:08 matrix-bridges synapse[6050]: File ""/usr/lib/python3.7/runpy.py"", line 85, in _run_code
Apr 11 16:33:08 matrix-bridges synapse[6050]: exec(code, run_globals)
Apr 11 16:33:08 matrix-bridges synapse[6050]: File ""/opt/synapse/env/lib/python3.7/site-packages/synapse/app/homeserver.py"", line 651, in
Apr 11 16:33:08 matrix-bridges synapse[6050]: main()
Apr 11 16:33:08 matrix-bridges synapse[6050]: File ""/opt/synapse/env/lib/python3.7/site-packages/synapse/app/homeserver.py"", line 646, in main
Apr 11 16:33:08 matrix-bridges synapse[6050]: hs = setup(sys.argv[1:])
Apr 11 16:33:08 matrix-bridges synapse[6050]: File ""/opt/synapse/env/lib/python3.7/site-packages/synapse/app/homeserver.py"", line 324, in setup
Apr 11 16:33:08 matrix-bridges synapse[6050]: ""Synapse Homeserver"", config_options
Apr 11 16:33:09 matrix-bridges synapse[6050]: Starting ...
Apr 11 16:33:09 matrix-bridges synapse[6050]: error starting (exit code: 1); see above for logs
Apr 11 16:33:09 matrix-bridges systemd[1]: matrix-synapse.service: Control process exited, code=exited, status=1/FAILURE
Apr 11 16:33:09 matrix-bridges systemd[1]: matrix-synapse.service: Failed with result 'exit-code'.
Apr 11 16:33:09 matrix-bridges systemd[1]: Failed to start Matrix Synapse service.
```
Turned out it was due to there being a string where an int should be in homeserver.yaml. Running synapse manually gave a sensible stacktrace:
```
python -m synapse.app.homeserver -c homeserver.yaml
Traceback (most recent call last):
File ""/usr/lib/python3.7/runpy.py"", line 193, in _run_module_as_main
""__main__"", mod_spec)
File ""/usr/lib/python3.7/runpy.py"", line 85, in _run_code
exec(code, run_globals)
File ""/opt/synapse/env/lib/python3.7/site-packages/synapse/app/homeserver.py"", line 651, in
main()
File ""/opt/synapse/env/lib/python3.7/site-packages/synapse/app/homeserver.py"", line 646, in main
hs = setup(sys.argv[1:])
File ""/opt/synapse/env/lib/python3.7/site-packages/synapse/app/homeserver.py"", line 324, in setup
""Synapse Homeserver"", config_options
File ""/opt/synapse/env/lib/python3.7/site-packages/synapse/config/_base.py"", line 629, in load_or_generate_config
config_dict, config_dir_path=config_dir_path, data_dir_path=data_dir_path
File ""/opt/synapse/env/lib/python3.7/site-packages/synapse/config/_base.py"", line 651, in parse_config_dict
data_dir_path=data_dir_path,
File ""/opt/synapse/env/lib/python3.7/site-packages/synapse/config/_base.py"", line 266, in invoke_all
res[name] = getattr(config, func_name)(*args, **kwargs)
File ""/opt/synapse/env/lib/python3.7/site-packages/synapse/config/server.py"", line 278, in read_config
self.retention_default_max_lifetime
File ""/opt/synapse/env/lib/python3.7/site-packages/synapse/config/_base.py"", line 146, in parse_duration
return int(value) * size
ValueError: invalid literal for int() with base 10: '1M'
```
...so this looks like synctl doing something daft.",
1024,https://api.github.com/repos/matrix-org/synapse/issues/7263,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7263/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7263/comments,https://api.github.com/repos/matrix-org/synapse/issues/7263/events,https://github.com/matrix-org/synapse/pull/7263,598291061,MDExOlB1bGxSZXF1ZXN0NDAyMjA2Nzg1,7263,Allow new users to be registered via the admin API even if the monthly active user limit has been reached,"{'login': 'dklimpel', 'id': 5740567, 'node_id': 'MDQ6VXNlcjU3NDA1Njc=', 'avatar_url': 'https://avatars2.githubusercontent.com/u/5740567?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/dklimpel', 'html_url': 'https://github.com/dklimpel', 'followers_url': 'https://api.github.com/users/dklimpel/followers', 'following_url': 'https://api.github.com/users/dklimpel/following{/other_user}', 'gists_url': 'https://api.github.com/users/dklimpel/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/dklimpel/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/dklimpel/subscriptions', 'organizations_url': 'https://api.github.com/users/dklimpel/orgs', 'repos_url': 'https://api.github.com/users/dklimpel/repos', 'events_url': 'https://api.github.com/users/dklimpel/events{/privacy}', 'received_events_url': 'https://api.github.com/users/dklimpel/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,3,2020-04-11T15:36:27Z,2020-06-05T13:59:45Z,2020-06-05T12:08:50Z,CONTRIBUTOR,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7263', 'html_url': 'https://github.com/matrix-org/synapse/pull/7263', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7263.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7263.patch'}","Fixes: #7175
If MAU limit is reached, you can add user with `GET /_synapse/admin/v1/register`. With `PUT /_synapse/admin/v2/users/` you can only add users if admin user was already active before limit was reached. Admin users seem to be MAU limited.
### Pull Request Checklist
* [x] Pull request is based on the develop branch
* [x] Pull request includes a [changelog file](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#changelog). The entry should:
- Be a short description of your change which makes sense to users. ""Fixed a bug that prevented receiving messages from other servers."" instead of ""Moved X method from `EventStore` to `EventWorkerStore`."".
- Use markdown where necessary, mostly for `code blocks`.
- End with either a period (.) or an exclamation mark (!).
- Start with a capital letter.
* [x] Pull request includes a [sign off](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#sign-off)
* [x] Code style is correct (run the [linters](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#code-style))
",
1025,https://api.github.com/repos/matrix-org/synapse/issues/7262,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7262/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7262/comments,https://api.github.com/repos/matrix-org/synapse/issues/7262/events,https://github.com/matrix-org/synapse/issues/7262,598211735,MDU6SXNzdWU1OTgyMTE3MzU=,7262,Synapse error logged on opening client (room list handler),"{'login': 'V02460', 'id': 1291108, 'node_id': 'MDQ6VXNlcjEyOTExMDg=', 'avatar_url': 'https://avatars2.githubusercontent.com/u/1291108?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/V02460', 'html_url': 'https://github.com/V02460', 'followers_url': 'https://api.github.com/users/V02460/followers', 'following_url': 'https://api.github.com/users/V02460/following{/other_user}', 'gists_url': 'https://api.github.com/users/V02460/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/V02460/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/V02460/subscriptions', 'organizations_url': 'https://api.github.com/users/V02460/orgs', 'repos_url': 'https://api.github.com/users/V02460/repos', 'events_url': 'https://api.github.com/users/V02460/events{/privacy}', 'received_events_url': 'https://api.github.com/users/V02460/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,1,2020-04-11T07:37:44Z,2020-04-13T12:04:47Z,2020-04-13T12:04:47Z,CONTRIBUTOR,,,"Whenever I open up a client, this error is emitted to Synapse’s logs:
`AttributeError: 'NoneType' object has no attribute 'content'`
The code line at fault is in the room list handler. It seems to assume there is always a create event returned from the database, which in my case appears to fail:
https://github.com/matrix-org/synapse/blob/883ac4b1bb7c520e928e8a42d7700de7f0d56055/synapse/handlers/room_list.py#L284-L285
I am running Synapse v1.12.3.",
1026,https://api.github.com/repos/matrix-org/synapse/issues/7261,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7261/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7261/comments,https://api.github.com/repos/matrix-org/synapse/issues/7261/events,https://github.com/matrix-org/synapse/pull/7261,597984255,MDExOlB1bGxSZXF1ZXN0NDAxOTgzMDY0,7261,Convert auth handler to async/await,"{'login': 'clokep', 'id': 517124, 'node_id': 'MDQ6VXNlcjUxNzEyNA==', 'avatar_url': 'https://avatars2.githubusercontent.com/u/517124?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/clokep', 'html_url': 'https://github.com/clokep', 'followers_url': 'https://api.github.com/users/clokep/followers', 'following_url': 'https://api.github.com/users/clokep/following{/other_user}', 'gists_url': 'https://api.github.com/users/clokep/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/clokep/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/clokep/subscriptions', 'organizations_url': 'https://api.github.com/users/clokep/orgs', 'repos_url': 'https://api.github.com/users/clokep/repos', 'events_url': 'https://api.github.com/users/clokep/events{/privacy}', 'received_events_url': 'https://api.github.com/users/clokep/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,1,2020-04-10T16:47:32Z,2020-04-16T09:12:34Z,2020-04-15T16:40:19Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7261', 'html_url': 'https://github.com/matrix-org/synapse/pull/7261', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7261.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7261.patch'}","While working on #6705 I think some methods need to be made async, I figured this was a good opportunity to convert the `AuthHandler` to async/await. It got a little bit bigger than I expected, but is reasonable, I think.
Any uses of the async/await outside of `AuthHandler` I wrapped in `ensureDeferred`.
I'm not fully confident on the changes to the tests (wrapping each call in `ensureDeferred`).",
1027,https://api.github.com/repos/matrix-org/synapse/issues/7260,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7260/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7260/comments,https://api.github.com/repos/matrix-org/synapse/issues/7260/events,https://github.com/matrix-org/synapse/pull/7260,597879134,MDExOlB1bGxSZXF1ZXN0NDAxOTAxOTMx,7260,Check publishing permissions,"{'login': 'PeerD', 'id': 4373944, 'node_id': 'MDQ6VXNlcjQzNzM5NDQ=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/4373944?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/PeerD', 'html_url': 'https://github.com/PeerD', 'followers_url': 'https://api.github.com/users/PeerD/followers', 'following_url': 'https://api.github.com/users/PeerD/following{/other_user}', 'gists_url': 'https://api.github.com/users/PeerD/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/PeerD/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/PeerD/subscriptions', 'organizations_url': 'https://api.github.com/users/PeerD/orgs', 'repos_url': 'https://api.github.com/users/PeerD/repos', 'events_url': 'https://api.github.com/users/PeerD/events{/privacy}', 'received_events_url': 'https://api.github.com/users/PeerD/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,2,2020-04-10T13:07:49Z,2020-04-13T11:42:33Z,2020-04-13T11:42:32Z,CONTRIBUTOR,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7260', 'html_url': 'https://github.com/matrix-org/synapse/pull/7260', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7260.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7260.patch'}","Check on room creation if the user is allowed to publish the room to the room directory. See #7204
`Signed-off-by: Peer Diestelhorst `
### Pull Request Checklist
* [x] Pull request is based on the develop branch
* [x] Pull request includes a [changelog file](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#changelog). The entry should:
- Be a short description of your change which makes sense to users. ""Fixed a bug that prevented receiving messages from other servers."" instead of ""Moved X method from `EventStore` to `EventWorkerStore`."".
- Use markdown where necessary, mostly for `code blocks`.
- End with either a period (.) or an exclamation mark (!).
- Start with a capital letter.
* [x] Pull request includes a [sign off](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#sign-off)
* [x] Code style is correct (run the [linters](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#code-style))
",
1028,https://api.github.com/repos/matrix-org/synapse/issues/7259,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7259/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7259/comments,https://api.github.com/repos/matrix-org/synapse/issues/7259/events,https://github.com/matrix-org/synapse/pull/7259,597834806,MDExOlB1bGxSZXF1ZXN0NDAxODY2NDE4,7259,Add notes to the changelog about new templates and module API changes from #7240.,"{'login': 'clokep', 'id': 517124, 'node_id': 'MDQ6VXNlcjUxNzEyNA==', 'avatar_url': 'https://avatars2.githubusercontent.com/u/517124?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/clokep', 'html_url': 'https://github.com/clokep', 'followers_url': 'https://api.github.com/users/clokep/followers', 'following_url': 'https://api.github.com/users/clokep/following{/other_user}', 'gists_url': 'https://api.github.com/users/clokep/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/clokep/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/clokep/subscriptions', 'organizations_url': 'https://api.github.com/users/clokep/orgs', 'repos_url': 'https://api.github.com/users/clokep/repos', 'events_url': 'https://api.github.com/users/clokep/events{/privacy}', 'received_events_url': 'https://api.github.com/users/clokep/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,0,2020-04-10T11:08:50Z,2020-04-15T14:36:35Z,2020-04-15T14:36:34Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7259', 'html_url': 'https://github.com/matrix-org/synapse/pull/7259', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7259.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7259.patch'}",I should have updated `CHANGES.md` in #7240 to mention the additional new template. We should also mention changes to the `ModuleApi` made in that PR.,
1029,https://api.github.com/repos/matrix-org/synapse/issues/7258,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7258/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7258/comments,https://api.github.com/repos/matrix-org/synapse/issues/7258/events,https://github.com/matrix-org/synapse/issues/7258,597758799,MDU6SXNzdWU1OTc3NTg3OTk=,7258,Add support for hCaptcha,"{'login': 'xmstspider', 'id': 7497125, 'node_id': 'MDQ6VXNlcjc0OTcxMjU=', 'avatar_url': 'https://avatars3.githubusercontent.com/u/7497125?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/xmstspider', 'html_url': 'https://github.com/xmstspider', 'followers_url': 'https://api.github.com/users/xmstspider/followers', 'following_url': 'https://api.github.com/users/xmstspider/following{/other_user}', 'gists_url': 'https://api.github.com/users/xmstspider/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/xmstspider/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/xmstspider/subscriptions', 'organizations_url': 'https://api.github.com/users/xmstspider/orgs', 'repos_url': 'https://api.github.com/users/xmstspider/repos', 'events_url': 'https://api.github.com/users/xmstspider/events{/privacy}', 'received_events_url': 'https://api.github.com/users/xmstspider/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,2,2020-04-10T08:07:56Z,2020-04-10T10:21:16Z,2020-04-10T10:15:43Z,NONE,,,"**Description:**
To remove dependency on one G* company, I would like to use [hCaptcha](https://www.hcaptcha.com/) instead of reCaptcha.
Would it be possible to add support for hCaptcha?
Thanks",
1030,https://api.github.com/repos/matrix-org/synapse/issues/7257,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7257/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7257/comments,https://api.github.com/repos/matrix-org/synapse/issues/7257/events,https://github.com/matrix-org/synapse/issues/7257,597385957,MDU6SXNzdWU1OTczODU5NTc=,7257,Synapse with workers: invalid command USER_SYNC,"{'login': 'hg-runs', 'id': 29901271, 'node_id': 'MDQ6VXNlcjI5OTAxMjcx', 'avatar_url': 'https://avatars3.githubusercontent.com/u/29901271?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/hg-runs', 'html_url': 'https://github.com/hg-runs', 'followers_url': 'https://api.github.com/users/hg-runs/followers', 'following_url': 'https://api.github.com/users/hg-runs/following{/other_user}', 'gists_url': 'https://api.github.com/users/hg-runs/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/hg-runs/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/hg-runs/subscriptions', 'organizations_url': 'https://api.github.com/users/hg-runs/orgs', 'repos_url': 'https://api.github.com/users/hg-runs/repos', 'events_url': 'https://api.github.com/users/hg-runs/events{/privacy}', 'received_events_url': 'https://api.github.com/users/hg-runs/received_events', 'type': 'User', 'site_admin': False}","[{'id': 828666468, 'node_id': 'MDU6TGFiZWw4Mjg2NjY0Njg=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/release%20blocker', 'name': 'release blocker', 'color': '880000', 'default': False, 'description': None}]",closed,False,"{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}","[{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}]",,6,2020-04-09T16:00:34Z,2020-04-23T09:40:53Z,2020-04-23T09:40:53Z,NONE,,,"
### Description
After updating to the latest dev build each and every worker log as well as the homeserver log is filled with that kind of error.
Am I missing something?
```
2020-04-09 17:19:09,348 - synapse.replication.tcp.client - 71 - ERROR - - Lost replication conn:
2020-04-09 17:19:09,658 - synapse.replication.tcp.protocol - 223 - ERROR - - [anon-hWrDh] invalid command USER_SYNC
2020-04-09 17:19:09,659 - synapse.replication.tcp.protocol - 280 - WARNING - - [anon-hWrDh] Closing connection
2020-04-09 17:19:09,662 - synapse.replication.tcp.client - 71 - ERROR - - Lost replication conn:
2020-04-09 17:19:09,952 - synapse.replication.tcp.protocol - 223 - ERROR - - [anon-IAxdO] invalid command USER_SYNC
2020-04-09 17:19:09,953 - synapse.replication.tcp.protocol - 280 - WARNING - - [anon-IAxdO] Closing connection
2020-04-09 17:19:09,956 - synapse.replication.tcp.client - 71 - ERROR - - Lost replication conn:
2020-04-09 17:19:10,338 - synapse.replication.tcp.protocol - 223 - ERROR - - [anon-ArViJ] invalid command USER_SYNC
```
### Steps to reproduce
- getting latest dev branch
- using worker setup
- starting homeserver and workers using synctl command
### Version information
- **Version**: homeserver.py version 1.12.3 (b=develop,967f99b9f)
- **Install method**: git pull
- **Platform**: Debian / Arm64
",
1031,https://api.github.com/repos/matrix-org/synapse/issues/7256,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7256/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7256/comments,https://api.github.com/repos/matrix-org/synapse/issues/7256/events,https://github.com/matrix-org/synapse/pull/7256,597363391,MDExOlB1bGxSZXF1ZXN0NDAxNDkwNjgy,7256,Implement OpenID Connect-based login,"{'login': 'sandhose', 'id': 1549952, 'node_id': 'MDQ6VXNlcjE1NDk5NTI=', 'avatar_url': 'https://avatars0.githubusercontent.com/u/1549952?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sandhose', 'html_url': 'https://github.com/sandhose', 'followers_url': 'https://api.github.com/users/sandhose/followers', 'following_url': 'https://api.github.com/users/sandhose/following{/other_user}', 'gists_url': 'https://api.github.com/users/sandhose/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/sandhose/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/sandhose/subscriptions', 'organizations_url': 'https://api.github.com/users/sandhose/orgs', 'repos_url': 'https://api.github.com/users/sandhose/repos', 'events_url': 'https://api.github.com/users/sandhose/events{/privacy}', 'received_events_url': 'https://api.github.com/users/sandhose/received_events', 'type': 'User', 'site_admin': False}",[],closed,True,"{'login': 'clokep', 'id': 517124, 'node_id': 'MDQ6VXNlcjUxNzEyNA==', 'avatar_url': 'https://avatars2.githubusercontent.com/u/517124?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/clokep', 'html_url': 'https://github.com/clokep', 'followers_url': 'https://api.github.com/users/clokep/followers', 'following_url': 'https://api.github.com/users/clokep/following{/other_user}', 'gists_url': 'https://api.github.com/users/clokep/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/clokep/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/clokep/subscriptions', 'organizations_url': 'https://api.github.com/users/clokep/orgs', 'repos_url': 'https://api.github.com/users/clokep/repos', 'events_url': 'https://api.github.com/users/clokep/events{/privacy}', 'received_events_url': 'https://api.github.com/users/clokep/received_events', 'type': 'User', 'site_admin': False}","[{'login': 'clokep', 'id': 517124, 'node_id': 'MDQ6VXNlcjUxNzEyNA==', 'avatar_url': 'https://avatars2.githubusercontent.com/u/517124?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/clokep', 'html_url': 'https://github.com/clokep', 'followers_url': 'https://api.github.com/users/clokep/followers', 'following_url': 'https://api.github.com/users/clokep/following{/other_user}', 'gists_url': 'https://api.github.com/users/clokep/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/clokep/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/clokep/subscriptions', 'organizations_url': 'https://api.github.com/users/clokep/orgs', 'repos_url': 'https://api.github.com/users/clokep/repos', 'events_url': 'https://api.github.com/users/clokep/events{/privacy}', 'received_events_url': 'https://api.github.com/users/clokep/received_events', 'type': 'User', 'site_admin': False}]",,30,2020-04-09T15:26:11Z,2020-05-29T11:06:47Z,2020-05-08T12:30:40Z,CONTRIBUTOR,resolved,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7256', 'html_url': 'https://github.com/matrix-org/synapse/pull/7256', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7256.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7256.patch'}","This PR implements OIDC based login through the m.login.sso mechanism.
OpenID Connect is based on OAuth2, so this PR is kinda redundant with #7059. For now, it only supports OpenID Connect-compliant providers with the authorization code flow. This could be expanded to support generic OAuth2 provider, as long as they either support the `openid` scope or the userinfo endpoint to fetch user infos.
This is a work in progress, here are a few things that need to be done:
- [x] make the authorization, token and jwks endpoints configurable. Right now they are discovered from the discovery document.
- [x] refresh the jwks periodically. The keys can be rotated by the OIDC Provider
- ~support implicit and hybrid flows~ – edit: implicit and hybrid flows are for single page apps essentially & give the token in the fragment part of the URL, which can't be retrieved server-side
- [x] make the user attributes mapping configurable (maybe the same way the SAML provider does)
- [x] handle errors more nicely
- [x] write some tests
- [x] make mypy happy, add typings where it makes sense
- [ ] maybe handle logouts: the OIDC specs support frontchannel (initiated by the app) and backchannel (initiated by the provider) logouts. For that we would need to save the `id_token` we get from the provider
For the flow to be secure (and prevent CSRF attacks for example), I needed to have a way to carry state through the flow. I chose to use a macaroon token with that state in it.
I needed an URL for the authorization flow callback. As it is not part of the spec, I chose to have that endpoint under `/_synapse/oidc/callback`.
I used `OIDC` as a name pretty much everywhere, but it would make sense to use `oauth2` instead ; haven't really decided.
### Pull Request Checklist
* [x] Pull request is based on the develop branch
* [x] Pull request includes a [changelog file](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#changelog). The entry should:
- Be a short description of your change which makes sense to users. ""Fixed a bug that prevented receiving messages from other servers."" instead of ""Moved X method from `EventStore` to `EventWorkerStore`."".
- Use markdown where necessary, mostly for `code blocks`.
- End with either a period (.) or an exclamation mark (!).
- Start with a capital letter.
* [x] Pull request includes a [sign off](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#sign-off)
* [x] Code style is correct (run the [linters](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#code-style))
",
1032,https://api.github.com/repos/matrix-org/synapse/issues/7255,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7255/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7255/comments,https://api.github.com/repos/matrix-org/synapse/issues/7255/events,https://github.com/matrix-org/synapse/pull/7255,597345941,MDExOlB1bGxSZXF1ZXN0NDAxNDc2MTk3,7255,Only register devices edu handler on the master process,"{'login': 'anoadragon453', 'id': 1342360, 'node_id': 'MDQ6VXNlcjEzNDIzNjA=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1342360?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/anoadragon453', 'html_url': 'https://github.com/anoadragon453', 'followers_url': 'https://api.github.com/users/anoadragon453/followers', 'following_url': 'https://api.github.com/users/anoadragon453/following{/other_user}', 'gists_url': 'https://api.github.com/users/anoadragon453/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/anoadragon453/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/anoadragon453/subscriptions', 'organizations_url': 'https://api.github.com/users/anoadragon453/orgs', 'repos_url': 'https://api.github.com/users/anoadragon453/repos', 'events_url': 'https://api.github.com/users/anoadragon453/events{/privacy}', 'received_events_url': 'https://api.github.com/users/anoadragon453/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,3,2020-04-09T15:01:33Z,2020-04-14T09:10:00Z,2020-04-14T09:09:59Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7255', 'html_url': 'https://github.com/matrix-org/synapse/pull/7255', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7255.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7255.patch'}",Fixes https://github.com/matrix-org/synapse/issues/7252,
1033,https://api.github.com/repos/matrix-org/synapse/issues/7254,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7254/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7254/comments,https://api.github.com/repos/matrix-org/synapse/issues/7254/events,https://github.com/matrix-org/synapse/pull/7254,597225592,MDExOlB1bGxSZXF1ZXN0NDAxMzc3Mjk1,7254,"Revert ""Unblacklist /upgrade creates a new room""","{'login': 'anoadragon453', 'id': 1342360, 'node_id': 'MDQ6VXNlcjEzNDIzNjA=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1342360?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/anoadragon453', 'html_url': 'https://github.com/anoadragon453', 'followers_url': 'https://api.github.com/users/anoadragon453/followers', 'following_url': 'https://api.github.com/users/anoadragon453/following{/other_user}', 'gists_url': 'https://api.github.com/users/anoadragon453/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/anoadragon453/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/anoadragon453/subscriptions', 'organizations_url': 'https://api.github.com/users/anoadragon453/orgs', 'repos_url': 'https://api.github.com/users/anoadragon453/repos', 'events_url': 'https://api.github.com/users/anoadragon453/events{/privacy}', 'received_events_url': 'https://api.github.com/users/anoadragon453/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,0,2020-04-09T11:46:48Z,2020-04-09T11:47:18Z,2020-04-09T11:47:17Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7254', 'html_url': 'https://github.com/matrix-org/synapse/pull/7254', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7254.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7254.patch'}","Reverts matrix-org/synapse#7228
Needed to wait for https://github.com/matrix-org/sytest/pull/848 to be approved first.",
1034,https://api.github.com/repos/matrix-org/synapse/issues/7253,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7253/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7253/comments,https://api.github.com/repos/matrix-org/synapse/issues/7253/events,https://github.com/matrix-org/synapse/issues/7253,597184878,MDU6SXNzdWU1OTcxODQ4Nzg=,7253,"Unable to create a user - ""Connection Refused""?","{'login': 'steveharman', 'id': 12557929, 'node_id': 'MDQ6VXNlcjEyNTU3OTI5', 'avatar_url': 'https://avatars1.githubusercontent.com/u/12557929?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/steveharman', 'html_url': 'https://github.com/steveharman', 'followers_url': 'https://api.github.com/users/steveharman/followers', 'following_url': 'https://api.github.com/users/steveharman/following{/other_user}', 'gists_url': 'https://api.github.com/users/steveharman/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/steveharman/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/steveharman/subscriptions', 'organizations_url': 'https://api.github.com/users/steveharman/orgs', 'repos_url': 'https://api.github.com/users/steveharman/repos', 'events_url': 'https://api.github.com/users/steveharman/events{/privacy}', 'received_events_url': 'https://api.github.com/users/steveharman/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,3,2020-04-09T10:30:11Z,2020-04-09T14:25:12Z,2020-04-09T14:11:35Z,NONE,,,"Apologies for spamming the issues page with this, I searched everywhere for a support forum without success (feel free to point out my obvious omission!)
- I've installed all officially listed dependencies
- I've followed three different installation guides (Digital Ocean, official, random user)
- I've tried two different freshly created Ubuntu installs (18, 16) and one on Debian (current)
- But I always arrive at the same blocker after issuing `register_new_matrix_user -c /etc/matrix-synapse/homeserver.yaml https://localhost:8448` - after three different install guides on ""different"" OSes.
It feels more like a config issue than a code fault but I'm out of ideas and would really appreciate any assistance.
Thanks,
```
% register_new_matrix_user -c /etc/matrix-synapse/homeserver.yaml https://localhost:8448
New user localpart [root]:
Password:
Confirm password:
Make admin [no]: yes
Traceback (most recent call last):
File ""/usr/lib/python3/dist-packages/urllib3/connection.py"", line 159, in _new_conn
(self._dns_host, self.port), self.timeout, **extra_kw)
File ""/usr/lib/python3/dist-packages/urllib3/util/connection.py"", line 80, in create_connection
raise err
File ""/usr/lib/python3/dist-packages/urllib3/util/connection.py"", line 70, in create_connection
sock.connect(sa)
ConnectionRefusedError: [Errno 111] Connection refused
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File ""/usr/lib/python3/dist-packages/urllib3/connectionpool.py"", line 600, in urlopen
chunked=chunked)
File ""/usr/lib/python3/dist-packages/urllib3/connectionpool.py"", line 343, in _make_request
self._validate_conn(conn)
File ""/usr/lib/python3/dist-packages/urllib3/connectionpool.py"", line 841, in _validate_conn
conn.connect()
File ""/usr/lib/python3/dist-packages/urllib3/connection.py"", line 301, in connect
conn = self._new_conn()
File ""/usr/lib/python3/dist-packages/urllib3/connection.py"", line 168, in _new_conn
self, ""Failed to establish a new connection: %s"" % e)
urllib3.exceptions.NewConnectionError: : Failed to establish a new connection: [Errno 111] Connection refused
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File ""/usr/lib/python3/dist-packages/requests/adapters.py"", line 449, in send
timeout=timeout
File ""/usr/lib/python3/dist-packages/urllib3/connectionpool.py"", line 638, in urlopen
_stacktrace=sys.exc_info()[2])
File ""/usr/lib/python3/dist-packages/urllib3/util/retry.py"", line 398, in increment
raise MaxRetryError(_pool, url, error or ResponseError(cause))
urllib3.exceptions.MaxRetryError: HTTPSConnectionPool(host='localhost', port=8448): Max retries exceeded with url: /_matrix/client/r0/admin/register (Caused by NewConnectionError(': Failed to establish a new connection: [Errno 111] Connection refused'))
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File ""/usr/bin/register_new_matrix_user"", line 22, in
main()
File ""/usr/lib/python3/dist-packages/synapse/_scripts/register_new_matrix_user.py"", line 224, in main
admin, args.user_type)
File ""/usr/lib/python3/dist-packages/synapse/_scripts/register_new_matrix_user.py"", line 138, in register_new_user
bool(admin), user_type)
File ""/usr/lib/python3/dist-packages/synapse/_scripts/register_new_matrix_user.py"", line 47, in request_registration
r = requests.get(url, verify=False)
File ""/usr/lib/python3/dist-packages/requests/api.py"", line 75, in get
return request('get', url, params=params, **kwargs)
File ""/usr/lib/python3/dist-packages/requests/api.py"", line 60, in request
return session.request(method=method, url=url, **kwargs)
File ""/usr/lib/python3/dist-packages/requests/sessions.py"", line 533, in request
resp = self.send(prep, **send_kwargs)
File ""/usr/lib/python3/dist-packages/requests/sessions.py"", line 646, in send
r = adapter.send(request, **kwargs)
File ""/usr/lib/python3/dist-packages/requests/adapters.py"", line 516, in send
raise ConnectionError(e, request=request)
requests.exceptions.ConnectionError: HTTPSConnectionPool(host='localhost', port=8448): Max retries exceeded with url: /_matrix/client/r0/admin/register (Caused by NewConnectionError(': Failed to establish a new connection: [Errno 111] Connection refused')
```
",
1035,https://api.github.com/repos/matrix-org/synapse/issues/7252,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7252/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7252/comments,https://api.github.com/repos/matrix-org/synapse/issues/7252/events,https://github.com/matrix-org/synapse/issues/7252,597171598,MDU6SXNzdWU1OTcxNzE1OTg=,7252,Cross signing key updates fail on workerised synapse,"{'login': 'dbkr', 'id': 986903, 'node_id': 'MDQ6VXNlcjk4NjkwMw==', 'avatar_url': 'https://avatars1.githubusercontent.com/u/986903?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/dbkr', 'html_url': 'https://github.com/dbkr', 'followers_url': 'https://api.github.com/users/dbkr/followers', 'following_url': 'https://api.github.com/users/dbkr/following{/other_user}', 'gists_url': 'https://api.github.com/users/dbkr/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/dbkr/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/dbkr/subscriptions', 'organizations_url': 'https://api.github.com/users/dbkr/orgs', 'repos_url': 'https://api.github.com/users/dbkr/repos', 'events_url': 'https://api.github.com/users/dbkr/events{/privacy}', 'received_events_url': 'https://api.github.com/users/dbkr/received_events', 'type': 'User', 'site_admin': False}","[{'id': 121086029, 'node_id': 'MDU6TGFiZWwxMjEwODYwMjk=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/bug', 'name': 'bug', 'color': 'fc2929', 'default': True, 'description': None}, {'id': 1631939447, 'node_id': 'MDU6TGFiZWwxNjMxOTM5NDQ3', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/cross-signing-sprint', 'name': 'cross-signing-sprint', 'color': '730adb', 'default': False, 'description': ''}, {'id': 1581464420, 'node_id': 'MDU6TGFiZWwxNTgxNDY0NDIw', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/phase:3', 'name': 'phase:3', 'color': 'c5e567', 'default': False, 'description': ''}, {'id': 1709952070, 'node_id': 'MDU6TGFiZWwxNzA5OTUyMDcw', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/story:2', 'name': 'story:2', 'color': 'b4f291', 'default': False, 'description': 'As a user I want to verify other users so that I can trust they are who they say they are'}]",closed,False,"{'login': 'anoadragon453', 'id': 1342360, 'node_id': 'MDQ6VXNlcjEzNDIzNjA=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1342360?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/anoadragon453', 'html_url': 'https://github.com/anoadragon453', 'followers_url': 'https://api.github.com/users/anoadragon453/followers', 'following_url': 'https://api.github.com/users/anoadragon453/following{/other_user}', 'gists_url': 'https://api.github.com/users/anoadragon453/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/anoadragon453/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/anoadragon453/subscriptions', 'organizations_url': 'https://api.github.com/users/anoadragon453/orgs', 'repos_url': 'https://api.github.com/users/anoadragon453/repos', 'events_url': 'https://api.github.com/users/anoadragon453/events{/privacy}', 'received_events_url': 'https://api.github.com/users/anoadragon453/received_events', 'type': 'User', 'site_admin': False}","[{'login': 'anoadragon453', 'id': 1342360, 'node_id': 'MDQ6VXNlcjEzNDIzNjA=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1342360?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/anoadragon453', 'html_url': 'https://github.com/anoadragon453', 'followers_url': 'https://api.github.com/users/anoadragon453/followers', 'following_url': 'https://api.github.com/users/anoadragon453/following{/other_user}', 'gists_url': 'https://api.github.com/users/anoadragon453/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/anoadragon453/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/anoadragon453/subscriptions', 'organizations_url': 'https://api.github.com/users/anoadragon453/orgs', 'repos_url': 'https://api.github.com/users/anoadragon453/repos', 'events_url': 'https://api.github.com/users/anoadragon453/events{/privacy}', 'received_events_url': 'https://api.github.com/users/anoadragon453/received_events', 'type': 'User', 'site_admin': False}]",,5,2020-04-09T10:07:19Z,2020-04-15T10:39:41Z,2020-04-15T10:39:41Z,MEMBER,,,"When an EDU comes in with updated cross-signing keys for a user, it's handled by the federation_inbound worker which lacks the ability to write the keys to the db. Stack trace: https://gist.github.com/dbkr/d93c32abab600ff3c7a240c0de0f1d61
@erikjohnston sez:
> ah, looks like we're incorrectly registering an edu handler on workers when it should only happen on master
This affects ability to cross-sign to/from matrix.org so is time-sensitive.
",
1036,https://api.github.com/repos/matrix-org/synapse/issues/7251,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7251/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7251/comments,https://api.github.com/repos/matrix-org/synapse/issues/7251/events,https://github.com/matrix-org/synapse/pull/7251,596858908,MDExOlB1bGxSZXF1ZXN0NDAxMDc3NDkw,7251,Add setting to nginx configuration to allow larger file uploads,"{'login': 'ProCycleDev', 'id': 18075290, 'node_id': 'MDQ6VXNlcjE4MDc1Mjkw', 'avatar_url': 'https://avatars2.githubusercontent.com/u/18075290?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/ProCycleDev', 'html_url': 'https://github.com/ProCycleDev', 'followers_url': 'https://api.github.com/users/ProCycleDev/followers', 'following_url': 'https://api.github.com/users/ProCycleDev/following{/other_user}', 'gists_url': 'https://api.github.com/users/ProCycleDev/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/ProCycleDev/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/ProCycleDev/subscriptions', 'organizations_url': 'https://api.github.com/users/ProCycleDev/orgs', 'repos_url': 'https://api.github.com/users/ProCycleDev/repos', 'events_url': 'https://api.github.com/users/ProCycleDev/events{/privacy}', 'received_events_url': 'https://api.github.com/users/ProCycleDev/received_events', 'type': 'User', 'site_admin': False}","[{'id': 845245048, 'node_id': 'MDU6TGFiZWw4NDUyNDUwNDg=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/docs', 'name': 'docs', 'color': '0e8a16', 'default': False, 'description': ''}]",closed,False,,[],,0,2020-04-08T20:58:53Z,2020-04-13T16:23:37Z,2020-04-13T16:23:37Z,CONTRIBUTOR,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7251', 'html_url': 'https://github.com/matrix-org/synapse/pull/7251', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7251.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7251.patch'}","Nginx defaults to only allow file uploads up to 1MB while synapse allows up to 10MB by default. Added a line to the nginx configuration to increase the limit with a note about how to use the setting and having a default value to match synapse's default.
Signed-off-by: Ryan Hovland ",
1037,https://api.github.com/repos/matrix-org/synapse/issues/7250,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7250/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7250/comments,https://api.github.com/repos/matrix-org/synapse/issues/7250/events,https://github.com/matrix-org/synapse/issues/7250,596729435,MDU6SXNzdWU1OTY3Mjk0MzU=,7250,search users (to chat with) on owned matrix server,"{'login': 'pantafanta', 'id': 29457252, 'node_id': 'MDQ6VXNlcjI5NDU3MjUy', 'avatar_url': 'https://avatars0.githubusercontent.com/u/29457252?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/pantafanta', 'html_url': 'https://github.com/pantafanta', 'followers_url': 'https://api.github.com/users/pantafanta/followers', 'following_url': 'https://api.github.com/users/pantafanta/following{/other_user}', 'gists_url': 'https://api.github.com/users/pantafanta/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/pantafanta/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/pantafanta/subscriptions', 'organizations_url': 'https://api.github.com/users/pantafanta/orgs', 'repos_url': 'https://api.github.com/users/pantafanta/repos', 'events_url': 'https://api.github.com/users/pantafanta/events{/privacy}', 'received_events_url': 'https://api.github.com/users/pantafanta/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,3,2020-04-08T17:08:34Z,2020-04-20T15:14:56Z,2020-04-20T15:14:56Z,NONE,,,"Hi everybody, thanks in advance for the support!
I've up and running synapse matrix server. From Riot site (using recaptcha) my users are able to make a registration. They use Riot on android and IOS.
Everything works properly, but we'rent able to search each other: when I'm looking for other user (in the search area, for example @paperino) I can't see anyone...
On the homeserver.yaml, I've tryed as below
user_directory:
enabled: true
search_all_users: true
My goal is to have the complete list of users on my server...
",
1038,https://api.github.com/repos/matrix-org/synapse/issues/7249,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7249/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7249/comments,https://api.github.com/repos/matrix-org/synapse/issues/7249/events,https://github.com/matrix-org/synapse/pull/7249,596596891,MDExOlB1bGxSZXF1ZXN0NDAwODYzOTI1,7249,Fix --help commandline argument,"{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,"{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}","[{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}]",,0,2020-04-08T13:52:23Z,2020-04-09T11:44:39Z,2020-04-09T11:44:38Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7249', 'html_url': 'https://github.com/matrix-org/synapse/pull/7249', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7249.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7249.patch'}","I don't really remember why this was so complicated; I think it dates
back to the time when we had to instantiate the Config classes before
we could call `add_arguments` - ie before #5597. In any case, I don't
think there's a good reason for it any more, and the impact of it
being complicated is that `--help` doesn't work correctly.",
1039,https://api.github.com/repos/matrix-org/synapse/issues/7248,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7248/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7248/comments,https://api.github.com/repos/matrix-org/synapse/issues/7248/events,https://github.com/matrix-org/synapse/pull/7248,596562521,MDExOlB1bGxSZXF1ZXN0NDAwODM2MDcz,7248,Add matrix-synapse-shared-secret-auth as an example password provider,"{'login': 'anoadragon453', 'id': 1342360, 'node_id': 'MDQ6VXNlcjEzNDIzNjA=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1342360?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/anoadragon453', 'html_url': 'https://github.com/anoadragon453', 'followers_url': 'https://api.github.com/users/anoadragon453/followers', 'following_url': 'https://api.github.com/users/anoadragon453/following{/other_user}', 'gists_url': 'https://api.github.com/users/anoadragon453/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/anoadragon453/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/anoadragon453/subscriptions', 'organizations_url': 'https://api.github.com/users/anoadragon453/orgs', 'repos_url': 'https://api.github.com/users/anoadragon453/repos', 'events_url': 'https://api.github.com/users/anoadragon453/events{/privacy}', 'received_events_url': 'https://api.github.com/users/anoadragon453/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,"{'login': 'anoadragon453', 'id': 1342360, 'node_id': 'MDQ6VXNlcjEzNDIzNjA=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1342360?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/anoadragon453', 'html_url': 'https://github.com/anoadragon453', 'followers_url': 'https://api.github.com/users/anoadragon453/followers', 'following_url': 'https://api.github.com/users/anoadragon453/following{/other_user}', 'gists_url': 'https://api.github.com/users/anoadragon453/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/anoadragon453/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/anoadragon453/subscriptions', 'organizations_url': 'https://api.github.com/users/anoadragon453/orgs', 'repos_url': 'https://api.github.com/users/anoadragon453/repos', 'events_url': 'https://api.github.com/users/anoadragon453/events{/privacy}', 'received_events_url': 'https://api.github.com/users/anoadragon453/received_events', 'type': 'User', 'site_admin': False}","[{'login': 'anoadragon453', 'id': 1342360, 'node_id': 'MDQ6VXNlcjEzNDIzNjA=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1342360?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/anoadragon453', 'html_url': 'https://github.com/anoadragon453', 'followers_url': 'https://api.github.com/users/anoadragon453/followers', 'following_url': 'https://api.github.com/users/anoadragon453/following{/other_user}', 'gists_url': 'https://api.github.com/users/anoadragon453/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/anoadragon453/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/anoadragon453/subscriptions', 'organizations_url': 'https://api.github.com/users/anoadragon453/orgs', 'repos_url': 'https://api.github.com/users/anoadragon453/repos', 'events_url': 'https://api.github.com/users/anoadragon453/events{/privacy}', 'received_events_url': 'https://api.github.com/users/anoadragon453/received_events', 'type': 'User', 'site_admin': False}]",,0,2020-04-08T13:05:13Z,2020-04-09T11:49:07Z,2020-04-09T11:49:06Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7248', 'html_url': 'https://github.com/matrix-org/synapse/pull/7248', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7248.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7248.patch'}","I found another one!
Updates #7238 to add another example of a password provider auth module: https://github.com/devture/matrix-synapse-shared-secret-auth/",
1040,https://api.github.com/repos/matrix-org/synapse/issues/7247,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7247/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7247/comments,https://api.github.com/repos/matrix-org/synapse/issues/7247/events,https://github.com/matrix-org/synapse/issues/7247,596559934,MDU6SXNzdWU1OTY1NTk5MzQ=,7247,Crash in synapse triggered by user request,"{'login': 'foldleft', 'id': 3935731, 'node_id': 'MDQ6VXNlcjM5MzU3MzE=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/3935731?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/foldleft', 'html_url': 'https://github.com/foldleft', 'followers_url': 'https://api.github.com/users/foldleft/followers', 'following_url': 'https://api.github.com/users/foldleft/following{/other_user}', 'gists_url': 'https://api.github.com/users/foldleft/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/foldleft/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/foldleft/subscriptions', 'organizations_url': 'https://api.github.com/users/foldleft/orgs', 'repos_url': 'https://api.github.com/users/foldleft/repos', 'events_url': 'https://api.github.com/users/foldleft/events{/privacy}', 'received_events_url': 'https://api.github.com/users/foldleft/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,2,2020-04-08T13:01:08Z,2020-04-08T17:25:04Z,2020-04-08T17:25:04Z,NONE,,,"### Description
I managed to crash synapse, I think. I didn't note the sequence of events so I'm not sure if I killed the server myself after (it got a SIGINT), but I certainly started getting weird responses from server
### Steps to reproduce
- I logged in with an old-ish test account
- I logged in a second session and tried to verify it. Instead, synapse crashed
```
2020-04-08 12:54:18,459 - synapse.access.http.8008 - 302 - INFO - GET-63733 - - - 8008 - {@test5:localhost} Processed request: 0.006sec/0.000sec (0.001sec, 0.001sec) (0.001sec/0.003sec/2) 465B 200 ""GET /_matrix/client/unstable/room_keys/version HTTP/1.1"" ""Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_3) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/80.0.3987.149 Safari/537.36"" [0 dbevts]
2020-04-08 12:54:27,204 - synapse.metrics.background_process_metrics - 214 - ERROR - presence.notify_new_event-4756 - Background process 'presence.notify_new_event' threw an exception
Traceback (most recent call last):
File ""/usr/local/lib/python3.7/site-packages/twisted/internet/defer.py"", line 1418, in _inlineCallbacks
result = g.send(result)
StopIteration
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File ""/usr/local/lib/python3.7/site-packages/twisted/internet/defer.py"", line 1418, in _inlineCallbacks
result = g.send(result)
StopIteration
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File ""/usr/local/lib/python3.7/site-packages/twisted/internet/defer.py"", line 1418, in _inlineCallbacks
result = g.send(result)
StopIteration: (23728, 23728)
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File ""/usr/local/lib/python3.7/site-packages/synapse/metrics/background_process_metrics.py"", line 212, in run
return (yield result)
TypeError: object tuple can't be used in 'await' expression
```
### Version information
Going by reflog, quite an old one: [12d425900](https://github.com/matrix-org/synapse/commit/12d425900048b29a95b06428f04ed6ecc9e09d15)
- **Version**:
```
matrix-js-sdk develop $ curl http://localhost:8008/_synapse/admin/v1/server_version
{
""python_version"": ""3.7.6"",
""server_version"": ""1.11.0""
}
```
- **Install method**:
Running in docker
- **Platform**:
macos 10.15.3
",
1041,https://api.github.com/repos/matrix-org/synapse/issues/7246,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7246/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7246/comments,https://api.github.com/repos/matrix-org/synapse/issues/7246/events,https://github.com/matrix-org/synapse/issues/7246,596429858,MDU6SXNzdWU1OTY0Mjk4NTg=,7246,Split homeserver.yaml into multiple files,"{'login': 'BoarderEB', 'id': 36758401, 'node_id': 'MDQ6VXNlcjM2NzU4NDAx', 'avatar_url': 'https://avatars3.githubusercontent.com/u/36758401?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/BoarderEB', 'html_url': 'https://github.com/BoarderEB', 'followers_url': 'https://api.github.com/users/BoarderEB/followers', 'following_url': 'https://api.github.com/users/BoarderEB/following{/other_user}', 'gists_url': 'https://api.github.com/users/BoarderEB/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/BoarderEB/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/BoarderEB/subscriptions', 'organizations_url': 'https://api.github.com/users/BoarderEB/orgs', 'repos_url': 'https://api.github.com/users/BoarderEB/repos', 'events_url': 'https://api.github.com/users/BoarderEB/events{/privacy}', 'received_events_url': 'https://api.github.com/users/BoarderEB/received_events', 'type': 'User', 'site_admin': False}","[{'id': 1311133228, 'node_id': 'MDU6TGFiZWwxMzExMTMzMjI4', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/info-needed', 'name': 'info-needed', 'color': 'a1e8ea', 'default': False, 'description': ''}]",closed,False,,[],,12,2020-04-08T09:14:20Z,2020-04-09T15:54:59Z,2020-04-08T13:19:43Z,NONE,,,"The homeserver.yaml is currently 1827 lines long. With this length it is very difficult to get an overview of the config.
Therefore, a division into a conf.d directory for the overview would be very helpful.
",
1042,https://api.github.com/repos/matrix-org/synapse/issues/7245,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7245/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7245/comments,https://api.github.com/repos/matrix-org/synapse/issues/7245/events,https://github.com/matrix-org/synapse/issues/7245,596286836,MDU6SXNzdWU1OTYyODY4MzY=,7245,Is a domain name required?,"{'login': 'snakyjake1', 'id': 8312560, 'node_id': 'MDQ6VXNlcjgzMTI1NjA=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/8312560?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/snakyjake1', 'html_url': 'https://github.com/snakyjake1', 'followers_url': 'https://api.github.com/users/snakyjake1/followers', 'following_url': 'https://api.github.com/users/snakyjake1/following{/other_user}', 'gists_url': 'https://api.github.com/users/snakyjake1/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/snakyjake1/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/snakyjake1/subscriptions', 'organizations_url': 'https://api.github.com/users/snakyjake1/orgs', 'repos_url': 'https://api.github.com/users/snakyjake1/repos', 'events_url': 'https://api.github.com/users/snakyjake1/events{/privacy}', 'received_events_url': 'https://api.github.com/users/snakyjake1/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,1,2020-04-08T03:41:53Z,2020-04-08T09:39:10Z,2020-04-08T09:39:10Z,NONE,,,"Can I setup synapse server without a domain name, and just use IP?
",
1043,https://api.github.com/repos/matrix-org/synapse/issues/7244,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7244/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7244/comments,https://api.github.com/repos/matrix-org/synapse/issues/7244/events,https://github.com/matrix-org/synapse/issues/7244,596239718,MDU6SXNzdWU1OTYyMzk3MTg=,7244,Need Basic Install/Config Instructions,"{'login': 'snakyjake1', 'id': 8312560, 'node_id': 'MDQ6VXNlcjgzMTI1NjA=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/8312560?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/snakyjake1', 'html_url': 'https://github.com/snakyjake1', 'followers_url': 'https://api.github.com/users/snakyjake1/followers', 'following_url': 'https://api.github.com/users/snakyjake1/following{/other_user}', 'gists_url': 'https://api.github.com/users/snakyjake1/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/snakyjake1/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/snakyjake1/subscriptions', 'organizations_url': 'https://api.github.com/users/snakyjake1/orgs', 'repos_url': 'https://api.github.com/users/snakyjake1/repos', 'events_url': 'https://api.github.com/users/snakyjake1/events{/privacy}', 'received_events_url': 'https://api.github.com/users/snakyjake1/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,1,2020-04-08T01:04:35Z,2020-04-08T09:34:59Z,2020-04-08T09:34:59Z,NONE,,,"Might anyone have the **most** simple basic install/config instructions?
I'm setting this up on a private network. No firewall. No domain. I want to get it running on HTTP, and once I get that far, configure for HTTPS.
I tried https://riot.im/app/#/login, and tried using http://192.168.1.176 as the home URL.
Error: Cannot reach homeserver
I figure I'm missing a few steps in the install/config.
Confusing areas:
1) Install was asking for a domain. I don't have one, but gave it something. Now I don't remember what I gave it, or how to change it.
2) homeserver.yaml. The instructions were confusing, because I'm not sure it was relevant to me.
Thanks.
Ubuntu LXD container.
",
1044,https://api.github.com/repos/matrix-org/synapse/issues/7243,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7243/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7243/comments,https://api.github.com/repos/matrix-org/synapse/issues/7243/events,https://github.com/matrix-org/synapse/pull/7243,596112461,MDExOlB1bGxSZXF1ZXN0NDAwNDY5MzAx,7243,Fix the parameters of a test fixture,"{'login': 'Zay11Zay', 'id': 29738176, 'node_id': 'MDQ6VXNlcjI5NzM4MTc2', 'avatar_url': 'https://avatars3.githubusercontent.com/u/29738176?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Zay11Zay', 'html_url': 'https://github.com/Zay11Zay', 'followers_url': 'https://api.github.com/users/Zay11Zay/followers', 'following_url': 'https://api.github.com/users/Zay11Zay/following{/other_user}', 'gists_url': 'https://api.github.com/users/Zay11Zay/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/Zay11Zay/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/Zay11Zay/subscriptions', 'organizations_url': 'https://api.github.com/users/Zay11Zay/orgs', 'repos_url': 'https://api.github.com/users/Zay11Zay/repos', 'events_url': 'https://api.github.com/users/Zay11Zay/events{/privacy}', 'received_events_url': 'https://api.github.com/users/Zay11Zay/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,2,2020-04-07T19:51:49Z,2020-04-14T19:37:29Z,2020-04-14T19:37:29Z,CONTRIBUTOR,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7243', 'html_url': 'https://github.com/matrix-org/synapse/pull/7243', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7243.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7243.patch'}","### Pull Request Checklist
Signed-off-by: Isaiah Singletary ",
1045,https://api.github.com/repos/matrix-org/synapse/issues/7242,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7242/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7242/comments,https://api.github.com/repos/matrix-org/synapse/issues/7242/events,https://github.com/matrix-org/synapse/issues/7242,596083578,MDU6SXNzdWU1OTYwODM1Nzg=,7242,Parameters in in wrong order,"{'login': 'Zay11Zay', 'id': 29738176, 'node_id': 'MDQ6VXNlcjI5NzM4MTc2', 'avatar_url': 'https://avatars3.githubusercontent.com/u/29738176?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Zay11Zay', 'html_url': 'https://github.com/Zay11Zay', 'followers_url': 'https://api.github.com/users/Zay11Zay/followers', 'following_url': 'https://api.github.com/users/Zay11Zay/following{/other_user}', 'gists_url': 'https://api.github.com/users/Zay11Zay/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/Zay11Zay/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/Zay11Zay/subscriptions', 'organizations_url': 'https://api.github.com/users/Zay11Zay/orgs', 'repos_url': 'https://api.github.com/users/Zay11Zay/repos', 'events_url': 'https://api.github.com/users/Zay11Zay/events{/privacy}', 'received_events_url': 'https://api.github.com/users/Zay11Zay/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,3,2020-04-07T18:58:58Z,2020-04-14T19:37:42Z,2020-04-14T19:37:42Z,CONTRIBUTOR,,,"
### Description
In the prepare() method in , the parameters are in the wrong order.
Currently: def prepare(self, hs, reactor, clock):
Should be: def prepare(self, reactor, clock, hs)
### Steps to reproduce
- list the steps
- that reproduce the bug
- using hyphens as bullet points
### Version information
- **Homeserver**:
If not matrix.org:
- **Version**:
- **Install method**:
- **Platform**:
",
1046,https://api.github.com/repos/matrix-org/synapse/issues/7241,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7241/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7241/comments,https://api.github.com/repos/matrix-org/synapse/issues/7241/events,https://github.com/matrix-org/synapse/pull/7241,596050323,MDExOlB1bGxSZXF1ZXN0NDAwNDE3Nzgx,7241,Convert delete_url_cache_media to async/await.,"{'login': 'clokep', 'id': 517124, 'node_id': 'MDQ6VXNlcjUxNzEyNA==', 'avatar_url': 'https://avatars2.githubusercontent.com/u/517124?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/clokep', 'html_url': 'https://github.com/clokep', 'followers_url': 'https://api.github.com/users/clokep/followers', 'following_url': 'https://api.github.com/users/clokep/following{/other_user}', 'gists_url': 'https://api.github.com/users/clokep/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/clokep/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/clokep/subscriptions', 'organizations_url': 'https://api.github.com/users/clokep/orgs', 'repos_url': 'https://api.github.com/users/clokep/repos', 'events_url': 'https://api.github.com/users/clokep/events{/privacy}', 'received_events_url': 'https://api.github.com/users/clokep/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,0,2020-04-07T17:59:33Z,2020-04-07T20:56:37Z,2020-04-07T20:56:35Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7241', 'html_url': 'https://github.com/matrix-org/synapse/pull/7241', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7241.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7241.patch'}",Fixes another instance from #7182. Uses the same fix as #7184.,
1047,https://api.github.com/repos/matrix-org/synapse/issues/7240,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7240/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7240/comments,https://api.github.com/repos/matrix-org/synapse/issues/7240/events,https://github.com/matrix-org/synapse/pull/7240,596033345,MDExOlB1bGxSZXF1ZXN0NDAwNDA0MDMw,7240,Do not allow a deactivated user to login via SSO.,"{'login': 'clokep', 'id': 517124, 'node_id': 'MDQ6VXNlcjUxNzEyNA==', 'avatar_url': 'https://avatars2.githubusercontent.com/u/517124?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/clokep', 'html_url': 'https://github.com/clokep', 'followers_url': 'https://api.github.com/users/clokep/followers', 'following_url': 'https://api.github.com/users/clokep/following{/other_user}', 'gists_url': 'https://api.github.com/users/clokep/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/clokep/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/clokep/subscriptions', 'organizations_url': 'https://api.github.com/users/clokep/orgs', 'repos_url': 'https://api.github.com/users/clokep/repos', 'events_url': 'https://api.github.com/users/clokep/events{/privacy}', 'received_events_url': 'https://api.github.com/users/clokep/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,"{'login': 'clokep', 'id': 517124, 'node_id': 'MDQ6VXNlcjUxNzEyNA==', 'avatar_url': 'https://avatars2.githubusercontent.com/u/517124?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/clokep', 'html_url': 'https://github.com/clokep', 'followers_url': 'https://api.github.com/users/clokep/followers', 'following_url': 'https://api.github.com/users/clokep/following{/other_user}', 'gists_url': 'https://api.github.com/users/clokep/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/clokep/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/clokep/subscriptions', 'organizations_url': 'https://api.github.com/users/clokep/orgs', 'repos_url': 'https://api.github.com/users/clokep/repos', 'events_url': 'https://api.github.com/users/clokep/events{/privacy}', 'received_events_url': 'https://api.github.com/users/clokep/received_events', 'type': 'User', 'site_admin': False}","[{'login': 'clokep', 'id': 517124, 'node_id': 'MDQ6VXNlcjUxNzEyNA==', 'avatar_url': 'https://avatars2.githubusercontent.com/u/517124?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/clokep', 'html_url': 'https://github.com/clokep', 'followers_url': 'https://api.github.com/users/clokep/followers', 'following_url': 'https://api.github.com/users/clokep/following{/other_user}', 'gists_url': 'https://api.github.com/users/clokep/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/clokep/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/clokep/subscriptions', 'organizations_url': 'https://api.github.com/users/clokep/orgs', 'repos_url': 'https://api.github.com/users/clokep/repos', 'events_url': 'https://api.github.com/users/clokep/events{/privacy}', 'received_events_url': 'https://api.github.com/users/clokep/received_events', 'type': 'User', 'site_admin': False}]",,1,2020-04-07T17:28:53Z,2020-04-09T17:28:15Z,2020-04-09T17:28:14Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7240', 'html_url': 'https://github.com/matrix-org/synapse/pull/7240', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7240.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7240.patch'}","This checks the deactivated status of a user during login for SSO.
If a user is deactivated, they are shown an HTML page explaining what happened.
As part of this it makes the `complete_sso_login` on the auth handler async, unfortunately to keep API compatibility in `ModuleApi` this PR adds a separate `complete_sso_login_async` and deprecates `complete_sso_login`. The sync version will not do the deactivation check.",
1048,https://api.github.com/repos/matrix-org/synapse/issues/7239,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7239/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7239/comments,https://api.github.com/repos/matrix-org/synapse/issues/7239/events,https://github.com/matrix-org/synapse/pull/7239,596008973,MDExOlB1bGxSZXF1ZXN0NDAwMzg0MDMx,7239,Miscellaneous cleanups to replication code,"{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,0,2020-04-07T16:46:34Z,2020-04-07T21:00:57Z,2020-04-07T21:00:56Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7239', 'html_url': 'https://github.com/matrix-org/synapse/pull/7239', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7239.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7239.patch'}","One per commit:
* Remove vestigal references to SYNC replication command
We've ripped pretty much all of this out: let's remove the remains.
* Fix warnings about not calling superclass constructor
Separate `SimpleCommand` from `Command`, so that things which don't want to use the `data` property don't have to, and thus fix the warnings PyCharm was giving me about not calling `__init__` in the base class.
* Handle one-word replication commands correctly
`REPLICATE` is now a valid command, and it's nice if you can issue it from the console without remembering to call it `REPLICATE ` with a trailing space.",
1049,https://api.github.com/repos/matrix-org/synapse/issues/7238,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7238/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7238/comments,https://api.github.com/repos/matrix-org/synapse/issues/7238/events,https://github.com/matrix-org/synapse/pull/7238,595982051,MDExOlB1bGxSZXF1ZXN0NDAwMzYxODg4,7238,Add documentation to password_providers config option,"{'login': 'anoadragon453', 'id': 1342360, 'node_id': 'MDQ6VXNlcjEzNDIzNjA=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1342360?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/anoadragon453', 'html_url': 'https://github.com/anoadragon453', 'followers_url': 'https://api.github.com/users/anoadragon453/followers', 'following_url': 'https://api.github.com/users/anoadragon453/following{/other_user}', 'gists_url': 'https://api.github.com/users/anoadragon453/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/anoadragon453/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/anoadragon453/subscriptions', 'organizations_url': 'https://api.github.com/users/anoadragon453/orgs', 'repos_url': 'https://api.github.com/users/anoadragon453/repos', 'events_url': 'https://api.github.com/users/anoadragon453/events{/privacy}', 'received_events_url': 'https://api.github.com/users/anoadragon453/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,"{'login': 'anoadragon453', 'id': 1342360, 'node_id': 'MDQ6VXNlcjEzNDIzNjA=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1342360?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/anoadragon453', 'html_url': 'https://github.com/anoadragon453', 'followers_url': 'https://api.github.com/users/anoadragon453/followers', 'following_url': 'https://api.github.com/users/anoadragon453/following{/other_user}', 'gists_url': 'https://api.github.com/users/anoadragon453/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/anoadragon453/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/anoadragon453/subscriptions', 'organizations_url': 'https://api.github.com/users/anoadragon453/orgs', 'repos_url': 'https://api.github.com/users/anoadragon453/repos', 'events_url': 'https://api.github.com/users/anoadragon453/events{/privacy}', 'received_events_url': 'https://api.github.com/users/anoadragon453/received_events', 'type': 'User', 'site_admin': False}","[{'login': 'anoadragon453', 'id': 1342360, 'node_id': 'MDQ6VXNlcjEzNDIzNjA=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1342360?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/anoadragon453', 'html_url': 'https://github.com/anoadragon453', 'followers_url': 'https://api.github.com/users/anoadragon453/followers', 'following_url': 'https://api.github.com/users/anoadragon453/following{/other_user}', 'gists_url': 'https://api.github.com/users/anoadragon453/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/anoadragon453/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/anoadragon453/subscriptions', 'organizations_url': 'https://api.github.com/users/anoadragon453/orgs', 'repos_url': 'https://api.github.com/users/anoadragon453/repos', 'events_url': 'https://api.github.com/users/anoadragon453/events{/privacy}', 'received_events_url': 'https://api.github.com/users/anoadragon453/received_events', 'type': 'User', 'site_admin': False}]",,0,2020-04-07T16:04:38Z,2020-04-07T23:46:51Z,2020-04-07T23:46:50Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7238', 'html_url': 'https://github.com/matrix-org/synapse/pull/7238', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7238.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7238.patch'}","Sooo... I just watched someone trying to set up Synapse's LDAP support but getting stuck with not knowing that they needed to install [matrix-synapse-ldap3](https://github.com/matrix-org/matrix-synapse-ldap3) to actually get things working.
During so I also realized that the `password_providers` config option has zero documentation in the sample config.
So in an attempt to solve both of these problems I added some docs to the option and pointed people to the password provider auth module docs, which now have to link to known implementations in there, which includes a link to the LDAP3 module.
If there are other known implementations we can add, please suggest them.
This PR also changes `password_providers` such that it's uncommented by default, in accordance with our doc writing... docs: https://github.com/matrix-org/synapse/blob/master/docs/code_style.md#configuration-file-format",
1050,https://api.github.com/repos/matrix-org/synapse/issues/7237,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7237/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7237/comments,https://api.github.com/repos/matrix-org/synapse/issues/7237/events,https://github.com/matrix-org/synapse/pull/7237,595950507,MDExOlB1bGxSZXF1ZXN0NDAwMzM1NjQx,7237,Make it clearer to the user that they haven't overridden onLogin/Register,"{'login': 'anoadragon453', 'id': 1342360, 'node_id': 'MDQ6VXNlcjEzNDIzNjA=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1342360?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/anoadragon453', 'html_url': 'https://github.com/anoadragon453', 'followers_url': 'https://api.github.com/users/anoadragon453/followers', 'following_url': 'https://api.github.com/users/anoadragon453/following{/other_user}', 'gists_url': 'https://api.github.com/users/anoadragon453/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/anoadragon453/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/anoadragon453/subscriptions', 'organizations_url': 'https://api.github.com/users/anoadragon453/orgs', 'repos_url': 'https://api.github.com/users/anoadragon453/repos', 'events_url': 'https://api.github.com/users/anoadragon453/events{/privacy}', 'received_events_url': 'https://api.github.com/users/anoadragon453/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,"{'login': 'anoadragon453', 'id': 1342360, 'node_id': 'MDQ6VXNlcjEzNDIzNjA=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1342360?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/anoadragon453', 'html_url': 'https://github.com/anoadragon453', 'followers_url': 'https://api.github.com/users/anoadragon453/followers', 'following_url': 'https://api.github.com/users/anoadragon453/following{/other_user}', 'gists_url': 'https://api.github.com/users/anoadragon453/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/anoadragon453/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/anoadragon453/subscriptions', 'organizations_url': 'https://api.github.com/users/anoadragon453/orgs', 'repos_url': 'https://api.github.com/users/anoadragon453/repos', 'events_url': 'https://api.github.com/users/anoadragon453/events{/privacy}', 'received_events_url': 'https://api.github.com/users/anoadragon453/received_events', 'type': 'User', 'site_admin': False}","[{'login': 'anoadragon453', 'id': 1342360, 'node_id': 'MDQ6VXNlcjEzNDIzNjA=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1342360?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/anoadragon453', 'html_url': 'https://github.com/anoadragon453', 'followers_url': 'https://api.github.com/users/anoadragon453/followers', 'following_url': 'https://api.github.com/users/anoadragon453/following{/other_user}', 'gists_url': 'https://api.github.com/users/anoadragon453/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/anoadragon453/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/anoadragon453/subscriptions', 'organizations_url': 'https://api.github.com/users/anoadragon453/orgs', 'repos_url': 'https://api.github.com/users/anoadragon453/repos', 'events_url': 'https://api.github.com/users/anoadragon453/events{/privacy}', 'received_events_url': 'https://api.github.com/users/anoadragon453/received_events', 'type': 'User', 'site_admin': False}]",,0,2020-04-07T15:21:18Z,2020-04-09T11:38:40Z,2020-04-09T11:38:38Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7237', 'html_url': 'https://github.com/matrix-org/synapse/pull/7237', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7237.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7237.patch'}","
![image](https://user-images.githubusercontent.com/1342360/78687274-e69e4080-78eb-11ea-822f-899dbecdab27.png)
Perform a `console.warn` instead of `console.log` when informing the user they need to replace the stub.
Just makes things jump out a bit more.",
1051,https://api.github.com/repos/matrix-org/synapse/issues/7236,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7236/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7236/comments,https://api.github.com/repos/matrix-org/synapse/issues/7236/events,https://github.com/matrix-org/synapse/pull/7236,595934523,MDExOlB1bGxSZXF1ZXN0NDAwMzIyNDE5,7236,Upgrade jQuery to 3.x on fallback login/registration screens,"{'login': 'anoadragon453', 'id': 1342360, 'node_id': 'MDQ6VXNlcjEzNDIzNjA=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1342360?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/anoadragon453', 'html_url': 'https://github.com/anoadragon453', 'followers_url': 'https://api.github.com/users/anoadragon453/followers', 'following_url': 'https://api.github.com/users/anoadragon453/following{/other_user}', 'gists_url': 'https://api.github.com/users/anoadragon453/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/anoadragon453/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/anoadragon453/subscriptions', 'organizations_url': 'https://api.github.com/users/anoadragon453/orgs', 'repos_url': 'https://api.github.com/users/anoadragon453/repos', 'events_url': 'https://api.github.com/users/anoadragon453/events{/privacy}', 'received_events_url': 'https://api.github.com/users/anoadragon453/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,"{'login': 'anoadragon453', 'id': 1342360, 'node_id': 'MDQ6VXNlcjEzNDIzNjA=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1342360?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/anoadragon453', 'html_url': 'https://github.com/anoadragon453', 'followers_url': 'https://api.github.com/users/anoadragon453/followers', 'following_url': 'https://api.github.com/users/anoadragon453/following{/other_user}', 'gists_url': 'https://api.github.com/users/anoadragon453/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/anoadragon453/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/anoadragon453/subscriptions', 'organizations_url': 'https://api.github.com/users/anoadragon453/orgs', 'repos_url': 'https://api.github.com/users/anoadragon453/repos', 'events_url': 'https://api.github.com/users/anoadragon453/events{/privacy}', 'received_events_url': 'https://api.github.com/users/anoadragon453/received_events', 'type': 'User', 'site_admin': False}","[{'login': 'anoadragon453', 'id': 1342360, 'node_id': 'MDQ6VXNlcjEzNDIzNjA=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1342360?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/anoadragon453', 'html_url': 'https://github.com/anoadragon453', 'followers_url': 'https://api.github.com/users/anoadragon453/followers', 'following_url': 'https://api.github.com/users/anoadragon453/following{/other_user}', 'gists_url': 'https://api.github.com/users/anoadragon453/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/anoadragon453/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/anoadragon453/subscriptions', 'organizations_url': 'https://api.github.com/users/anoadragon453/orgs', 'repos_url': 'https://api.github.com/users/anoadragon453/repos', 'events_url': 'https://api.github.com/users/anoadragon453/events{/privacy}', 'received_events_url': 'https://api.github.com/users/anoadragon453/received_events', 'type': 'User', 'site_admin': False}]",,0,2020-04-07T14:59:10Z,2020-04-09T11:23:32Z,2020-04-09T11:23:31Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7236', 'html_url': 'https://github.com/matrix-org/synapse/pull/7236', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7236.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7236.patch'}","This PR updates jQuery core to v3.x and fixes the backwards incompatible changes that were made.
The main change is error handling for ajax requests. One simply replaces `.error()` with `.fail()`, which takes a callback function with the same arguments.
I also added a HTML5 definition at the top of the index.html's as jQuery was complaining about it in the JS console.
The login.js stuff has been manually tested with Brendan's test setup. register.js has not but is known broken anyways. I just updated it to make it easier for when we actually fix it.",
1052,https://api.github.com/repos/matrix-org/synapse/issues/7235,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7235/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7235/comments,https://api.github.com/repos/matrix-org/synapse/issues/7235/events,https://github.com/matrix-org/synapse/pull/7235,595928927,MDExOlB1bGxSZXF1ZXN0NDAwMzE3NzY2,7235,Fix typo in the login fallback javascript,"{'login': 'babolivier', 'id': 5547783, 'node_id': 'MDQ6VXNlcjU1NDc3ODM=', 'avatar_url': 'https://avatars3.githubusercontent.com/u/5547783?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/babolivier', 'html_url': 'https://github.com/babolivier', 'followers_url': 'https://api.github.com/users/babolivier/followers', 'following_url': 'https://api.github.com/users/babolivier/following{/other_user}', 'gists_url': 'https://api.github.com/users/babolivier/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/babolivier/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/babolivier/subscriptions', 'organizations_url': 'https://api.github.com/users/babolivier/orgs', 'repos_url': 'https://api.github.com/users/babolivier/repos', 'events_url': 'https://api.github.com/users/babolivier/events{/privacy}', 'received_events_url': 'https://api.github.com/users/babolivier/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,"{'login': 'babolivier', 'id': 5547783, 'node_id': 'MDQ6VXNlcjU1NDc3ODM=', 'avatar_url': 'https://avatars3.githubusercontent.com/u/5547783?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/babolivier', 'html_url': 'https://github.com/babolivier', 'followers_url': 'https://api.github.com/users/babolivier/followers', 'following_url': 'https://api.github.com/users/babolivier/following{/other_user}', 'gists_url': 'https://api.github.com/users/babolivier/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/babolivier/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/babolivier/subscriptions', 'organizations_url': 'https://api.github.com/users/babolivier/orgs', 'repos_url': 'https://api.github.com/users/babolivier/repos', 'events_url': 'https://api.github.com/users/babolivier/events{/privacy}', 'received_events_url': 'https://api.github.com/users/babolivier/received_events', 'type': 'User', 'site_admin': False}","[{'login': 'babolivier', 'id': 5547783, 'node_id': 'MDQ6VXNlcjU1NDc3ODM=', 'avatar_url': 'https://avatars3.githubusercontent.com/u/5547783?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/babolivier', 'html_url': 'https://github.com/babolivier', 'followers_url': 'https://api.github.com/users/babolivier/followers', 'following_url': 'https://api.github.com/users/babolivier/following{/other_user}', 'gists_url': 'https://api.github.com/users/babolivier/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/babolivier/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/babolivier/subscriptions', 'organizations_url': 'https://api.github.com/users/babolivier/orgs', 'repos_url': 'https://api.github.com/users/babolivier/repos', 'events_url': 'https://api.github.com/users/babolivier/events{/privacy}', 'received_events_url': 'https://api.github.com/users/babolivier/received_events', 'type': 'User', 'site_admin': False}]",,4,2020-04-07T14:51:47Z,2020-04-08T10:00:28Z,2020-04-07T16:31:51Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7235', 'html_url': 'https://github.com/matrix-org/synapse/pull/7235', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7235.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7235.patch'}","This would cause the SSO login form to not show up, making it impossible to auth via SSO through the login fallback if SSO isn't the only authentication option the HS offers.",
1053,https://api.github.com/repos/matrix-org/synapse/issues/7234,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7234/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7234/comments,https://api.github.com/repos/matrix-org/synapse/issues/7234/events,https://github.com/matrix-org/synapse/pull/7234,595796804,MDExOlB1bGxSZXF1ZXN0NDAwMjA4MTIw,7234,Make systemd-with-workers doc official,"{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,0,2020-04-07T11:27:25Z,2020-04-14T17:02:28Z,2020-04-08T10:59:27Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7234', 'html_url': 'https://github.com/matrix-org/synapse/pull/7234', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7234.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7234.patch'}","Simplify and update this documentation, and make it part of the core dist.",
1054,https://api.github.com/repos/matrix-org/synapse/issues/7233,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7233/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7233/comments,https://api.github.com/repos/matrix-org/synapse/issues/7233/events,https://github.com/matrix-org/synapse/pull/7233,595788422,MDExOlB1bGxSZXF1ZXN0NDAwMjAxMDU2,7233,Remove redundant checks on `daemonize` from synctl,"{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,1,2020-04-07T11:13:06Z,2020-04-08T10:59:49Z,2020-04-08T10:59:48Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7233', 'html_url': 'https://github.com/matrix-org/synapse/pull/7233', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7233.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7233.patch'}","We pass --daemonize on the commandline, which (since at least #4853) overrides
whatever the config file, so there is no need for it to be set in the config
file.",
1055,https://api.github.com/repos/matrix-org/synapse/issues/7232,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7232/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7232/comments,https://api.github.com/repos/matrix-org/synapse/issues/7232/events,https://github.com/matrix-org/synapse/pull/7232,595615901,MDExOlB1bGxSZXF1ZXN0NDAwMDU4Nzc2,7232,turn-howto.md: enhance and add Let's Encrypt instructions,"{'login': 'rubo77', 'id': 1591563, 'node_id': 'MDQ6VXNlcjE1OTE1NjM=', 'avatar_url': 'https://avatars0.githubusercontent.com/u/1591563?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/rubo77', 'html_url': 'https://github.com/rubo77', 'followers_url': 'https://api.github.com/users/rubo77/followers', 'following_url': 'https://api.github.com/users/rubo77/following{/other_user}', 'gists_url': 'https://api.github.com/users/rubo77/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/rubo77/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/rubo77/subscriptions', 'organizations_url': 'https://api.github.com/users/rubo77/orgs', 'repos_url': 'https://api.github.com/users/rubo77/repos', 'events_url': 'https://api.github.com/users/rubo77/events{/privacy}', 'received_events_url': 'https://api.github.com/users/rubo77/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,3,2020-04-07T06:06:53Z,2020-05-20T10:07:18Z,2020-05-19T16:26:25Z,CONTRIBUTOR,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7232', 'html_url': 'https://github.com/matrix-org/synapse/pull/7232', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7232.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7232.patch'}","This will make it obvious, that you have to use the key defined in your TURN-Server and add a Lets Encrypt example
### Pull Request Checklist
* [x] Pull request is based on the develop branch
* [x] Pull request includes a [changelog file](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#changelog). The entry should:
- Be a short description of your change which makes sense to users. ""Fixed a bug that prevented receiving messages from other servers."" instead of ""Moved X method from `EventStore` to `EventWorkerStore`."".
- Use markdown where necessary, mostly for `code blocks`.
- End with either a period (.) or an exclamation mark (!).
- Start with a capital letter.
* [x] Pull request includes a [sign off](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#sign-off)
* [x] Code style is correct (run the [linters](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#code-style))
",
1056,https://api.github.com/repos/matrix-org/synapse/issues/7231,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7231/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7231/comments,https://api.github.com/repos/matrix-org/synapse/issues/7231/events,https://github.com/matrix-org/synapse/issues/7231,595415581,MDU6SXNzdWU1OTU0MTU1ODE=,7231,dropping requests to .well-known leads to slow media federation,"{'login': 'deepbluev7', 'id': 16312324, 'node_id': 'MDQ6VXNlcjE2MzEyMzI0', 'avatar_url': 'https://avatars3.githubusercontent.com/u/16312324?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/deepbluev7', 'html_url': 'https://github.com/deepbluev7', 'followers_url': 'https://api.github.com/users/deepbluev7/followers', 'following_url': 'https://api.github.com/users/deepbluev7/following{/other_user}', 'gists_url': 'https://api.github.com/users/deepbluev7/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/deepbluev7/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/deepbluev7/subscriptions', 'organizations_url': 'https://api.github.com/users/deepbluev7/orgs', 'repos_url': 'https://api.github.com/users/deepbluev7/repos', 'events_url': 'https://api.github.com/users/deepbluev7/events{/privacy}', 'received_events_url': 'https://api.github.com/users/deepbluev7/received_events', 'type': 'User', 'site_admin': False}","[{'id': 121086029, 'node_id': 'MDU6TGFiZWwxMjEwODYwMjk=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/bug', 'name': 'bug', 'color': 'fc2929', 'default': True, 'description': None}, {'id': 477045806, 'node_id': 'MDU6TGFiZWw0NzcwNDU4MDY=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/media-repository', 'name': 'media-repository', 'color': 'ededed', 'default': False, 'description': None}, {'id': 477043173, 'node_id': 'MDU6TGFiZWw0NzcwNDMxNzM=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/p2', 'name': 'p2', 'color': 'fbca04', 'default': False, 'description': None}]",open,False,,[],,2,2020-04-06T20:44:43Z,2020-04-08T13:51:28Z,,NONE,,,"
### Description
When a server has it's firewall set to drop incoming requests to ports it doesn't use (pf default for the block rule) and doesn't use .well-known (so it drops requests to 443, specifically `https://server:443/.well-known/matrix/server`), every media request needs to wait for the .well-known request to timeout, before it actually starts fetching the media. So every image in a shared room takes around 30 seconds to load over federation.
### Steps to reproduce
- set up a server A, that only runs on port 8448
- set the firewall of server A to drop requests on port 443 (use SRV or default 8448 for federation setup)
- set up server B
- share a room between server A and B
- let server A send an image
Server B will now wait for 30 seconds on the .well-known timeout, before it sends the actual media request. This happens for every media!
### Expected behaviour
Server B caches the .well-known result and only waits for 30 seconds on the first timeout. Maybe it is just the media worker, that doesn't do that.
relevant logs:
```
2020-04-05 21:39:01,516 - synapse.http.matrixfederationclient - 408 - INFO - GET-11022 - {GET-O-345} [pink.packageloss.eu] Sending request: GET matrix://pink.packageloss.eu/_matrix/media/v1/download/pink.packageloss.eu/3d1a80ed7d2b89457d96e5212f2378a958b7560c?allow_remote=false; timeout 60.000000s
2020-04-05 21:39:01,517 - synapse.http.federation.well_known_resolver - 234 - INFO - GET-11022 - Fetching https://pink.packageloss.eu/.well-known/matrix/server
2020-04-05 21:39:03,892 - synapse.access.http.8085 - 302 - INFO - GET-11023 - 127.0.0.1 - 8085 - {None} Processed request: 0.003sec/-0.000sec (0.002sec, 0.000sec) (0.001sec/0.001sec/1) 6756B 200 ""GET /_matrix/media/r0/download/pink.packageloss.eu/b195fb40cab5095adf1551b876d99610bad24f60 HTTP/1.0"" ""mtxclient v0.3.0"" [0 dbevts]
2020-04-05 21:39:31,825 - synapse.http.federation.well_known_resolver - 250 - INFO - GET-11022 - Error fetching https://pink.packageloss.eu/.well-known/matrix/server: User timeout caused connection failure.
2020-04-05 21:39:31,828 - synapse.http.federation.matrix_federation_agent - 242 - INFO - GET-11022 - Connecting to pink.packageloss.eu:8448
2020-04-05 21:39:32,211 - synapse.http.matrixfederationclient - 442 - INFO - GET-11022 - {GET-O-345} [pink.packageloss.eu] Got response headers: 200 OK
2020-04-05 21:39:32,212 - synapse.http.matrixfederationclient - 909 - INFO - GET-11022 - {GET-O-345} [pink.packageloss.eu] Completed: 200 OK [14490 bytes]
2020-04-05 21:39:32,212 - synapse.rest.media.v1.media_repository - 406 - INFO - GET-11022 - Stored remote media in file '/var/lib/synapse/media_store/remote_content/pink.packageloss.eu/td/yY/oLPpEPNArfeZksvNvGWv'
2020-04-05 21:39:32,356 - synapse.access.http.8085 - 302 - INFO - GET-11022 - ::1 - 8085 - {None} Processed request: 30.857sec/-0.000sec (0.047sec, 0.001sec) (0.003sec/0.110sec/7) 14490B 200 ""GET /_matrix/media/r0/download/pink.packageloss.eu/3d1a80ed7d2b89457d96e5212f2378a958b7560c HTTP/1.0"" ""mtxclient v0.3.0"" [0 dbevts]
```
### Version information
- **Homeserver**: pink.packageloss.eu (server A) and neko.dev (server B)
If not matrix.org:
- **Version**: 10.x and 12.3
- **Install method**: ports/ebuild
- **Platform**: FreeBSD/Gentoo
",
1057,https://api.github.com/repos/matrix-org/synapse/issues/7230,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7230/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7230/comments,https://api.github.com/repos/matrix-org/synapse/issues/7230/events,https://github.com/matrix-org/synapse/pull/7230,595256926,MDExOlB1bGxSZXF1ZXN0Mzk5NzYzMzg3,7230,Default PL100 to enable encryption in a room,"{'login': 'anoadragon453', 'id': 1342360, 'node_id': 'MDQ6VXNlcjEzNDIzNjA=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1342360?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/anoadragon453', 'html_url': 'https://github.com/anoadragon453', 'followers_url': 'https://api.github.com/users/anoadragon453/followers', 'following_url': 'https://api.github.com/users/anoadragon453/following{/other_user}', 'gists_url': 'https://api.github.com/users/anoadragon453/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/anoadragon453/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/anoadragon453/subscriptions', 'organizations_url': 'https://api.github.com/users/anoadragon453/orgs', 'repos_url': 'https://api.github.com/users/anoadragon453/repos', 'events_url': 'https://api.github.com/users/anoadragon453/events{/privacy}', 'received_events_url': 'https://api.github.com/users/anoadragon453/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,1,2020-04-06T16:31:29Z,2020-04-09T17:45:40Z,2020-04-09T17:45:39Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7230', 'html_url': 'https://github.com/matrix-org/synapse/pull/7230', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7230.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7230.patch'}","Fixes https://github.com/matrix-org/synapse/issues/7229
TODO:
- ~~Sytests~~ default power levels are not a spec thing
- ~~Unit tests~~ done",
1058,https://api.github.com/repos/matrix-org/synapse/issues/7229,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7229/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7229/comments,https://api.github.com/repos/matrix-org/synapse/issues/7229/events,https://github.com/matrix-org/synapse/issues/7229,595254297,MDU6SXNzdWU1OTUyNTQyOTc=,7229,Raise default power level for enabling e2ee support to 100,"{'login': 'neilisfragile', 'id': 451032, 'node_id': 'MDQ6VXNlcjQ1MTAzMg==', 'avatar_url': 'https://avatars2.githubusercontent.com/u/451032?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/neilisfragile', 'html_url': 'https://github.com/neilisfragile', 'followers_url': 'https://api.github.com/users/neilisfragile/followers', 'following_url': 'https://api.github.com/users/neilisfragile/following{/other_user}', 'gists_url': 'https://api.github.com/users/neilisfragile/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/neilisfragile/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/neilisfragile/subscriptions', 'organizations_url': 'https://api.github.com/users/neilisfragile/orgs', 'repos_url': 'https://api.github.com/users/neilisfragile/repos', 'events_url': 'https://api.github.com/users/neilisfragile/events{/privacy}', 'received_events_url': 'https://api.github.com/users/neilisfragile/received_events', 'type': 'User', 'site_admin': False}","[{'id': 121086031, 'node_id': 'MDU6TGFiZWwxMjEwODYwMzE=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/enhancement', 'name': 'enhancement', 'color': '84b6eb', 'default': True, 'description': None}, {'id': 477043173, 'node_id': 'MDU6TGFiZWw0NzcwNDMxNzM=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/p2', 'name': 'p2', 'color': 'fbca04', 'default': False, 'description': None}]",closed,False,"{'login': 'anoadragon453', 'id': 1342360, 'node_id': 'MDQ6VXNlcjEzNDIzNjA=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1342360?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/anoadragon453', 'html_url': 'https://github.com/anoadragon453', 'followers_url': 'https://api.github.com/users/anoadragon453/followers', 'following_url': 'https://api.github.com/users/anoadragon453/following{/other_user}', 'gists_url': 'https://api.github.com/users/anoadragon453/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/anoadragon453/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/anoadragon453/subscriptions', 'organizations_url': 'https://api.github.com/users/anoadragon453/orgs', 'repos_url': 'https://api.github.com/users/anoadragon453/repos', 'events_url': 'https://api.github.com/users/anoadragon453/events{/privacy}', 'received_events_url': 'https://api.github.com/users/anoadragon453/received_events', 'type': 'User', 'site_admin': False}","[{'login': 'anoadragon453', 'id': 1342360, 'node_id': 'MDQ6VXNlcjEzNDIzNjA=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1342360?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/anoadragon453', 'html_url': 'https://github.com/anoadragon453', 'followers_url': 'https://api.github.com/users/anoadragon453/followers', 'following_url': 'https://api.github.com/users/anoadragon453/following{/other_user}', 'gists_url': 'https://api.github.com/users/anoadragon453/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/anoadragon453/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/anoadragon453/subscriptions', 'organizations_url': 'https://api.github.com/users/anoadragon453/orgs', 'repos_url': 'https://api.github.com/users/anoadragon453/repos', 'events_url': 'https://api.github.com/users/anoadragon453/events{/privacy}', 'received_events_url': 'https://api.github.com/users/anoadragon453/received_events', 'type': 'User', 'site_admin': False}]",,1,2020-04-06T16:27:30Z,2020-04-09T17:45:56Z,2020-04-09T17:45:55Z,CONTRIBUTOR,,,"Currently moderators (PL 50) can enable e2ee which seems like a lot of responsibility given doing so is an irreversible action.
Instead it would be better to limit it to admins with PL 100.
I'm not proposing that existing rooms are changed retrospectively.
",
1059,https://api.github.com/repos/matrix-org/synapse/issues/7228,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7228/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7228/comments,https://api.github.com/repos/matrix-org/synapse/issues/7228/events,https://github.com/matrix-org/synapse/pull/7228,595139843,MDExOlB1bGxSZXF1ZXN0Mzk5NjY2MDY2,7228,Unblacklist /upgrade creates a new room,"{'login': 'anoadragon453', 'id': 1342360, 'node_id': 'MDQ6VXNlcjEzNDIzNjA=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1342360?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/anoadragon453', 'html_url': 'https://github.com/anoadragon453', 'followers_url': 'https://api.github.com/users/anoadragon453/followers', 'following_url': 'https://api.github.com/users/anoadragon453/following{/other_user}', 'gists_url': 'https://api.github.com/users/anoadragon453/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/anoadragon453/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/anoadragon453/subscriptions', 'organizations_url': 'https://api.github.com/users/anoadragon453/orgs', 'repos_url': 'https://api.github.com/users/anoadragon453/repos', 'events_url': 'https://api.github.com/users/anoadragon453/events{/privacy}', 'received_events_url': 'https://api.github.com/users/anoadragon453/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,"{'login': 'anoadragon453', 'id': 1342360, 'node_id': 'MDQ6VXNlcjEzNDIzNjA=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1342360?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/anoadragon453', 'html_url': 'https://github.com/anoadragon453', 'followers_url': 'https://api.github.com/users/anoadragon453/followers', 'following_url': 'https://api.github.com/users/anoadragon453/following{/other_user}', 'gists_url': 'https://api.github.com/users/anoadragon453/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/anoadragon453/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/anoadragon453/subscriptions', 'organizations_url': 'https://api.github.com/users/anoadragon453/orgs', 'repos_url': 'https://api.github.com/users/anoadragon453/repos', 'events_url': 'https://api.github.com/users/anoadragon453/events{/privacy}', 'received_events_url': 'https://api.github.com/users/anoadragon453/received_events', 'type': 'User', 'site_admin': False}","[{'login': 'anoadragon453', 'id': 1342360, 'node_id': 'MDQ6VXNlcjEzNDIzNjA=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1342360?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/anoadragon453', 'html_url': 'https://github.com/anoadragon453', 'followers_url': 'https://api.github.com/users/anoadragon453/followers', 'following_url': 'https://api.github.com/users/anoadragon453/following{/other_user}', 'gists_url': 'https://api.github.com/users/anoadragon453/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/anoadragon453/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/anoadragon453/subscriptions', 'organizations_url': 'https://api.github.com/users/anoadragon453/orgs', 'repos_url': 'https://api.github.com/users/anoadragon453/repos', 'events_url': 'https://api.github.com/users/anoadragon453/events{/privacy}', 'received_events_url': 'https://api.github.com/users/anoadragon453/received_events', 'type': 'User', 'site_admin': False}]",,1,2020-04-06T13:57:19Z,2020-04-09T11:48:11Z,2020-04-09T11:44:49Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7228', 'html_url': 'https://github.com/matrix-org/synapse/pull/7228', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7228.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7228.patch'}","Tests in `tests/30rooms/60version_upgrade.pl` for worker mode doesn't seem to be flaky locally.
Let's try unblacklisting it.",
1060,https://api.github.com/repos/matrix-org/synapse/issues/7227,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7227/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7227/comments,https://api.github.com/repos/matrix-org/synapse/issues/7227/events,https://github.com/matrix-org/synapse/pull/7227,595122759,MDExOlB1bGxSZXF1ZXN0Mzk5NjUxNTk2,7227,Add information about .well-known to Debian installation.,"{'login': 'clokep', 'id': 517124, 'node_id': 'MDQ6VXNlcjUxNzEyNA==', 'avatar_url': 'https://avatars2.githubusercontent.com/u/517124?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/clokep', 'html_url': 'https://github.com/clokep', 'followers_url': 'https://api.github.com/users/clokep/followers', 'following_url': 'https://api.github.com/users/clokep/following{/other_user}', 'gists_url': 'https://api.github.com/users/clokep/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/clokep/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/clokep/subscriptions', 'organizations_url': 'https://api.github.com/users/clokep/orgs', 'repos_url': 'https://api.github.com/users/clokep/repos', 'events_url': 'https://api.github.com/users/clokep/events{/privacy}', 'received_events_url': 'https://api.github.com/users/clokep/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,4,2020-04-06T13:36:25Z,2020-04-06T21:35:04Z,2020-04-06T21:02:45Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7227', 'html_url': 'https://github.com/matrix-org/synapse/pull/7227', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7227.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7227.patch'}","This adds information about using `.well-known/matrix` instead of DNS SRV when configuring a Synapse server.
Fixes #7221",
1061,https://api.github.com/repos/matrix-org/synapse/issues/7226,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7226/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7226/comments,https://api.github.com/repos/matrix-org/synapse/issues/7226/events,https://github.com/matrix-org/synapse/pull/7226,594974170,MDExOlB1bGxSZXF1ZXN0Mzk5NTI1MjQ3,7226,Fix race in replication,"{'login': 'erikjohnston', 'id': 8428120, 'node_id': 'MDQ6VXNlcjg0MjgxMjA=', 'avatar_url': 'https://avatars0.githubusercontent.com/u/8428120?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/erikjohnston', 'html_url': 'https://github.com/erikjohnston', 'followers_url': 'https://api.github.com/users/erikjohnston/followers', 'following_url': 'https://api.github.com/users/erikjohnston/following{/other_user}', 'gists_url': 'https://api.github.com/users/erikjohnston/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/erikjohnston/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/erikjohnston/subscriptions', 'organizations_url': 'https://api.github.com/users/erikjohnston/orgs', 'repos_url': 'https://api.github.com/users/erikjohnston/repos', 'events_url': 'https://api.github.com/users/erikjohnston/events{/privacy}', 'received_events_url': 'https://api.github.com/users/erikjohnston/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,4,2020-04-06T09:58:43Z,2020-04-07T10:01:06Z,2020-04-07T10:01:05Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7226', 'html_url': 'https://github.com/matrix-org/synapse/pull/7226', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7226.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7226.patch'}","Fixes a race between handling `POSITION` and `RDATA` commands. We do this by simply linearizing handling of them.
Also hopefully fixes exceptions described in https://github.com/matrix-org/synapse/issues/7206#issuecomment-608001475.
Broke in #7024.",
1062,https://api.github.com/repos/matrix-org/synapse/issues/7225,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7225/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7225/comments,https://api.github.com/repos/matrix-org/synapse/issues/7225/events,https://github.com/matrix-org/synapse/pull/7225,594619701,MDExOlB1bGxSZXF1ZXN0Mzk5MjIyNjA5,7225,Extend room admin api with additional attributes,"{'login': 'dklimpel', 'id': 5740567, 'node_id': 'MDQ6VXNlcjU3NDA1Njc=', 'avatar_url': 'https://avatars2.githubusercontent.com/u/5740567?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/dklimpel', 'html_url': 'https://github.com/dklimpel', 'followers_url': 'https://api.github.com/users/dklimpel/followers', 'following_url': 'https://api.github.com/users/dklimpel/following{/other_user}', 'gists_url': 'https://api.github.com/users/dklimpel/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/dklimpel/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/dklimpel/subscriptions', 'organizations_url': 'https://api.github.com/users/dklimpel/orgs', 'repos_url': 'https://api.github.com/users/dklimpel/repos', 'events_url': 'https://api.github.com/users/dklimpel/events{/privacy}', 'received_events_url': 'https://api.github.com/users/dklimpel/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,0,2020-04-05T20:04:28Z,2020-04-22T15:32:54Z,2020-04-22T12:38:42Z,CONTRIBUTOR,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7225', 'html_url': 'https://github.com/matrix-org/synapse/pull/7225', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7225.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7225.patch'}","Fixes: #6427
- Add additional attributes to room admin api
`GET /_synapse/admin/v1/rooms`
- Move all room tests to test_room.py
### Pull Request Checklist
* [x] Pull request is based on the develop branch
* [x] Pull request includes a [changelog file](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#changelog). The entry should:
- Be a short description of your change which makes sense to users. ""Fixed a bug that prevented receiving messages from other servers."" instead of ""Moved X method from `EventStore` to `EventWorkerStore`."".
- Use markdown where necessary, mostly for `code blocks`.
- End with either a period (.) or an exclamation mark (!).
- Start with a capital letter.
* [x] Pull request includes a [sign off](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#sign-off)
* [x] Code style is correct (run the [linters](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#code-style))
",
1063,https://api.github.com/repos/matrix-org/synapse/issues/7224,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7224/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7224/comments,https://api.github.com/repos/matrix-org/synapse/issues/7224/events,https://github.com/matrix-org/synapse/pull/7224,594604121,MDExOlB1bGxSZXF1ZXN0Mzk5MjA5MDg3,7224,Extend room admin api with additional attributes.,"{'login': 'dklimpel', 'id': 5740567, 'node_id': 'MDQ6VXNlcjU3NDA1Njc=', 'avatar_url': 'https://avatars2.githubusercontent.com/u/5740567?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/dklimpel', 'html_url': 'https://github.com/dklimpel', 'followers_url': 'https://api.github.com/users/dklimpel/followers', 'following_url': 'https://api.github.com/users/dklimpel/following{/other_user}', 'gists_url': 'https://api.github.com/users/dklimpel/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/dklimpel/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/dklimpel/subscriptions', 'organizations_url': 'https://api.github.com/users/dklimpel/orgs', 'repos_url': 'https://api.github.com/users/dklimpel/repos', 'events_url': 'https://api.github.com/users/dklimpel/events{/privacy}', 'received_events_url': 'https://api.github.com/users/dklimpel/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,1,2020-04-05T19:20:08Z,2020-04-05T19:34:20Z,2020-04-05T19:34:00Z,CONTRIBUTOR,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7224', 'html_url': 'https://github.com/matrix-org/synapse/pull/7224', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7224.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7224.patch'}","### Pull Request Checklist
* [x] Pull request is based on the develop branch
* [ ] Pull request includes a [changelog file](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#changelog). The entry should:
- Be a short description of your change which makes sense to users. ""Fixed a bug that prevented receiving messages from other servers."" instead of ""Moved X method from `EventStore` to `EventWorkerStore`."".
- Use markdown where necessary, mostly for `code blocks`.
- End with either a period (.) or an exclamation mark (!).
- Start with a capital letter.
* [x] Pull request includes a [sign off](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#sign-off)
* [ ] Code style is correct (run the [linters](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#code-style))
",
1064,https://api.github.com/repos/matrix-org/synapse/issues/7223,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7223/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7223/comments,https://api.github.com/repos/matrix-org/synapse/issues/7223/events,https://github.com/matrix-org/synapse/issues/7223,594552565,MDU6SXNzdWU1OTQ1NTI1NjU=,7223,Invite to remote Community cannot be joined with Error 500,"{'login': 'MacLemon', 'id': 90635, 'node_id': 'MDQ6VXNlcjkwNjM1', 'avatar_url': 'https://avatars1.githubusercontent.com/u/90635?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/MacLemon', 'html_url': 'https://github.com/MacLemon', 'followers_url': 'https://api.github.com/users/MacLemon/followers', 'following_url': 'https://api.github.com/users/MacLemon/following{/other_user}', 'gists_url': 'https://api.github.com/users/MacLemon/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/MacLemon/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/MacLemon/subscriptions', 'organizations_url': 'https://api.github.com/users/MacLemon/orgs', 'repos_url': 'https://api.github.com/users/MacLemon/repos', 'events_url': 'https://api.github.com/users/MacLemon/events{/privacy}', 'received_events_url': 'https://api.github.com/users/MacLemon/received_events', 'type': 'User', 'site_admin': False}","[{'id': 121086029, 'node_id': 'MDU6TGFiZWwxMjEwODYwMjk=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/bug', 'name': 'bug', 'color': 'fc2929', 'default': True, 'description': None}, {'id': 1351364998, 'node_id': 'MDU6TGFiZWwxMzUxMzY0OTk4', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/communities', 'name': 'communities', 'color': '0e8a16', 'default': False, 'description': ''}, {'id': 1056680564, 'node_id': 'MDU6TGFiZWwxMDU2NjgwNTY0', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/workers', 'name': 'workers', 'color': 'f9d0c4', 'default': False, 'description': 'Synapse in Worker Mode'}]",open,False,,[],,1,2020-04-05T16:51:48Z,2020-04-06T19:25:09Z,,NONE,,,"### Description
An invitation to a community to a remote Matrix-ID cannot be followed because of an Error 500.
### Steps to reproduce
- User [@fredl:fairydust.space](https://matrix.to/#/@fredl:fairydust.space) creates a Community +cabincrew:fairydust.space
- [@fredl:fairydust.space](https://matrix.to/#/@fredl:fairydust.space) invites user [@MacLemon.maclemon.at](https://matrix.to/#/@MacLemon.maclemon.at) across instances into that new community
- [@MacLemon.maclemon.at](https://matrix.to/#/@MacLemon.maclemon.at) receives an incitation notification
- When [@MacLemon.maclemon.at](https://matrix.to/#/@MacLemon.maclemon.at) clicks the accept button an error dialog is shown.
![Error-Unable to accept invite](https://user-images.githubusercontent.com/90635/78504349-e0358a80-776c-11ea-8e84-d793242a09f2.png)
As a result the invitation can neither be accepted nor refused as the same error is shown to the receiving user who now has a stuck Schroedinger's invitation in their client
`federation_reader.log` on the inviting instance fairydust.space
```
2020-04-05 15:51:01,642 - synapse.http.server - 110 - ERROR - POST-19383- Failed handle request via 'FederationGroupsAcceptInviteServlet':
Traceback (most recent call last):
File ""/usr/local/lib/python3.7/site-packages/synapse/http/server.py"", line 78, in wrapped_request_handler
await h(self, request)
File ""/usr/local/lib/python3.7/site-packages/synapse/http/server.py"", line 331, in _async_render
callback_return = await callback_return
File ""/usr/local/lib/python3.7/site-packages/synapse/federation/transport/server.py"", line 344, in new_func
origin, content, request.args, *args, **kwargs
File ""/usr/local/lib/python3.7/site-packages/synapse/federation/transport/server.py"", line 1032, in on_POST
new_content = await self.handler.accept_invite(group_id, user_id, content)
AttributeError: 'GroupsServerWorkerHandler' object has no attribute 'accept_invite'
```
`homeserver.log` on the receiving instance maclemon.at:
```
2020-04-05 16:14:23,600 - synapse.http.matrixfederationclient - 408 - INFO - PUT-436168- {POST-O-383549} [fairydust.space] Sending request: POST matrix://fairydust.space/_matrix/federa
tion/v1/groups/%2Bcabincrew%3Afairydust.space/users/%40MacLemon%3Amaclemon.at/accept_invite; timeout 60.000000s
2020-04-05 16:14:23,601 - synapse.http.federation.matrix_federation_agent - 242 - INFO - PUT-436168- Connecting to matrix.fairydust.space:443
2020-04-05 16:14:23,659 - synapse.access.http.8008 - 302 - INFO - GET-436169- 195.176.3.20 - 8008 - {@MacLemon:maclemon.at} Processed request: 0.009sec/0.000sec (0.008sec, 0.000sec) (0
.000sec/0.001sec/1) 958B 200 ""GET /_matrix/client/r0/sync?filter=4&timeout=30000&since=s1308738_56890458_10285_1747664_91935_209_116287_261794_10 HTTP/1.1"" ""Mozilla/5.0 (Macintosh; Int
el Mac OS X 10_13_6) AppleWebKit/537.36 (KHTML, like Gecko) Riot/1.5.15 Chrome/78.0.3904.130 Electron/7.1.14 Safari/537.36"" [0 dbevts]
2020-04-05 16:14:23,660 - synapse.http.matrixfederationclient - 442 - INFO - PUT-436168- {POST-O-383549} [fairydust.space] Got response headers: 500 Internal Server Error
2020-04-05 16:14:23,660 - synapse.http.matrixfederationclient - 526 - WARNING - PUT-436168- {POST-O-383549} [fairydust.space] Request failed: POST matrix://fairydust.space/_matrix/federation/v1/groups/%2Bcabincrew%3Afairydust.space/users/%40MacLemon%3Amaclemon.at/accept_invite: HttpResponseException(""500: b'Internal Server Error'"")
2020-04-05 16:14:23,661 - synapse.http.server - 81 - INFO - PUT-436168- SynapseError: 500 - Internal server error
2020-04-05 16:14:23,662 - synapse.access.http.8008 - 302 - INFO - PUT-436168- 195.176.3.20 - 8008 - {@MacLemon:maclemon.at} Processed request: 0.062sec/0.000sec (0.005sec, 0.000sec) (0
.000sec/0.000sec/0) 55B 500 ""PUT /_matrix/client/r0/groups/%2Bcabincrew%3Afairydust.space/self/accept_invite HTTP/1.1"" ""Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_6) AppleWebKit/537.
36 (KHTML, like Gecko) Riot/1.5.15 Chrome/78.0.3904.130 Electron/7.1.14 Safari/537.36"" [0 dbevts]
```
#### Expectations not met
Clicking accept on a community invitation should accept that invitation even when across federation.
### Version information
- **Homeserver**: Inviting: (matrix).fairydust.space
- **Homeserver**: Receiving: (matrix).maclemon.at
What version of Synapse is running?
Version information applies to *both* instances likewise.
- **Version**: 1.12.3
- **Install method**: `pip` with `python 3.7.7`
- **Setup Details**:
- fairydust.space is using synchrotron and federation_reader workers
- maclemon.at is not running worker.
- **Platform**:
- fairydust.space: Hetzner VM running FreeBSD 12.1-p3-RELEASE
- Metal, running FreeBSD 12.1-p3-RELEASE
- **Clients**:
- Selfhosted Riot/Web: riot-web version: 1.5.15, olm version: 3.1.3 at [chat.fairydust.space](https://chat.fairydust.space)
- Riot/Electron Version 1.5.15 (1.5.15) running on macOS 10.13.6 High Sierra.
---
Edit: Correct log file and added Setup details for instances.",
1065,https://api.github.com/repos/matrix-org/synapse/issues/7222,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7222/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7222/comments,https://api.github.com/repos/matrix-org/synapse/issues/7222/events,https://github.com/matrix-org/synapse/issues/7222,594323559,MDU6SXNzdWU1OTQzMjM1NTk=,7222,APT package matrix-synapse-py3 clobbers config in homeserver.yaml,"{'login': 'the-moog', 'id': 3725802, 'node_id': 'MDQ6VXNlcjM3MjU4MDI=', 'avatar_url': 'https://avatars2.githubusercontent.com/u/3725802?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/the-moog', 'html_url': 'https://github.com/the-moog', 'followers_url': 'https://api.github.com/users/the-moog/followers', 'following_url': 'https://api.github.com/users/the-moog/following{/other_user}', 'gists_url': 'https://api.github.com/users/the-moog/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/the-moog/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/the-moog/subscriptions', 'organizations_url': 'https://api.github.com/users/the-moog/orgs', 'repos_url': 'https://api.github.com/users/the-moog/repos', 'events_url': 'https://api.github.com/users/the-moog/events{/privacy}', 'received_events_url': 'https://api.github.com/users/the-moog/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,5,2020-04-05T08:15:28Z,2020-04-06T15:08:21Z,2020-04-06T14:06:16Z,NONE,,,"### Description
apt-get upgrade on the package matrix-synapse-py3 clobbers the homeserver.yaml
You can choose not to do this (unless you have done a quiet upgrade, but as the contents of the example configuration file changes you need to preserve the supplied file to merge it into your own.
The issue is that either you lose the new *example* config or you overwrite your own, I preserve my own before the upgrade but this itself causes issues.
Apparently if you restart the homeserver as a new version it should NOT kick all the users, but this is what happens if the config file changes significantly.
Instead, the package installer should supply an example contemporary homeserver.yaml.exaple if the file homeserver.yaml exists so that the existing homeserver.yaml is not clobbered.
### Steps to reproduce
apt-get upgrade
### Version information
Problem exists in all versions to date (for me 1.12.0-xenial)
- **Platform**:
Ubuntu Xenial
",
1066,https://api.github.com/repos/matrix-org/synapse/issues/7221,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7221/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7221/comments,https://api.github.com/repos/matrix-org/synapse/issues/7221/events,https://github.com/matrix-org/synapse/issues/7221,594115392,MDU6SXNzdWU1OTQxMTUzOTI=,7221,Debian packages ignore .well-known,"{'login': 'ara4n', 'id': 1294269, 'node_id': 'MDQ6VXNlcjEyOTQyNjk=', 'avatar_url': 'https://avatars2.githubusercontent.com/u/1294269?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/ara4n', 'html_url': 'https://github.com/ara4n', 'followers_url': 'https://api.github.com/users/ara4n/followers', 'following_url': 'https://api.github.com/users/ara4n/following{/other_user}', 'gists_url': 'https://api.github.com/users/ara4n/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/ara4n/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/ara4n/subscriptions', 'organizations_url': 'https://api.github.com/users/ara4n/orgs', 'repos_url': 'https://api.github.com/users/ara4n/repos', 'events_url': 'https://api.github.com/users/ara4n/events{/privacy}', 'received_events_url': 'https://api.github.com/users/ara4n/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,"{'login': 'clokep', 'id': 517124, 'node_id': 'MDQ6VXNlcjUxNzEyNA==', 'avatar_url': 'https://avatars2.githubusercontent.com/u/517124?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/clokep', 'html_url': 'https://github.com/clokep', 'followers_url': 'https://api.github.com/users/clokep/followers', 'following_url': 'https://api.github.com/users/clokep/following{/other_user}', 'gists_url': 'https://api.github.com/users/clokep/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/clokep/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/clokep/subscriptions', 'organizations_url': 'https://api.github.com/users/clokep/orgs', 'repos_url': 'https://api.github.com/users/clokep/repos', 'events_url': 'https://api.github.com/users/clokep/events{/privacy}', 'received_events_url': 'https://api.github.com/users/clokep/received_events', 'type': 'User', 'site_admin': False}","[{'login': 'clokep', 'id': 517124, 'node_id': 'MDQ6VXNlcjUxNzEyNA==', 'avatar_url': 'https://avatars2.githubusercontent.com/u/517124?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/clokep', 'html_url': 'https://github.com/clokep', 'followers_url': 'https://api.github.com/users/clokep/followers', 'following_url': 'https://api.github.com/users/clokep/following{/other_user}', 'gists_url': 'https://api.github.com/users/clokep/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/clokep/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/clokep/subscriptions', 'organizations_url': 'https://api.github.com/users/clokep/orgs', 'repos_url': 'https://api.github.com/users/clokep/repos', 'events_url': 'https://api.github.com/users/clokep/events{/privacy}', 'received_events_url': 'https://api.github.com/users/clokep/received_events', 'type': 'User', 'site_admin': False}]",,1,2020-04-04T21:43:10Z,2020-04-06T21:03:01Z,2020-04-06T21:03:01Z,MEMBER,,,"
^ this is confusing if you were planning on doing .well-known",
1067,https://api.github.com/repos/matrix-org/synapse/issues/7220,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7220/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7220/comments,https://api.github.com/repos/matrix-org/synapse/issues/7220/events,https://github.com/matrix-org/synapse/issues/7220,593786572,MDU6SXNzdWU1OTM3ODY1NzI=,7220,Reactivate an account,"{'login': 'ClaudiuLSH', 'id': 6681374, 'node_id': 'MDQ6VXNlcjY2ODEzNzQ=', 'avatar_url': 'https://avatars0.githubusercontent.com/u/6681374?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/ClaudiuLSH', 'html_url': 'https://github.com/ClaudiuLSH', 'followers_url': 'https://api.github.com/users/ClaudiuLSH/followers', 'following_url': 'https://api.github.com/users/ClaudiuLSH/following{/other_user}', 'gists_url': 'https://api.github.com/users/ClaudiuLSH/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/ClaudiuLSH/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/ClaudiuLSH/subscriptions', 'organizations_url': 'https://api.github.com/users/ClaudiuLSH/orgs', 'repos_url': 'https://api.github.com/users/ClaudiuLSH/repos', 'events_url': 'https://api.github.com/users/ClaudiuLSH/events{/privacy}', 'received_events_url': 'https://api.github.com/users/ClaudiuLSH/received_events', 'type': 'User', 'site_admin': False}","[{'id': 1507817868, 'node_id': 'MDU6TGFiZWwxNTA3ODE3ODY4', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/admin-api', 'name': 'admin-api', 'color': 'e9fc71', 'default': False, 'description': ''}]",closed,False,"{'login': 'clokep', 'id': 517124, 'node_id': 'MDQ6VXNlcjUxNzEyNA==', 'avatar_url': 'https://avatars2.githubusercontent.com/u/517124?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/clokep', 'html_url': 'https://github.com/clokep', 'followers_url': 'https://api.github.com/users/clokep/followers', 'following_url': 'https://api.github.com/users/clokep/following{/other_user}', 'gists_url': 'https://api.github.com/users/clokep/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/clokep/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/clokep/subscriptions', 'organizations_url': 'https://api.github.com/users/clokep/orgs', 'repos_url': 'https://api.github.com/users/clokep/repos', 'events_url': 'https://api.github.com/users/clokep/events{/privacy}', 'received_events_url': 'https://api.github.com/users/clokep/received_events', 'type': 'User', 'site_admin': False}","[{'login': 'clokep', 'id': 517124, 'node_id': 'MDQ6VXNlcjUxNzEyNA==', 'avatar_url': 'https://avatars2.githubusercontent.com/u/517124?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/clokep', 'html_url': 'https://github.com/clokep', 'followers_url': 'https://api.github.com/users/clokep/followers', 'following_url': 'https://api.github.com/users/clokep/following{/other_user}', 'gists_url': 'https://api.github.com/users/clokep/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/clokep/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/clokep/subscriptions', 'organizations_url': 'https://api.github.com/users/clokep/orgs', 'repos_url': 'https://api.github.com/users/clokep/repos', 'events_url': 'https://api.github.com/users/clokep/events{/privacy}', 'received_events_url': 'https://api.github.com/users/clokep/received_events', 'type': 'User', 'site_admin': False}]",,11,2020-04-04T09:48:28Z,2020-07-20T12:32:57Z,2020-07-15T15:00:22Z,NONE,,,"### Description
Deactivating an account works but trying to reactivate an account does not.
As far as I can tell from synapse code there is no handler for account reactivation.
https://github.com/matrix-org/synapse/blob/master/synapse/rest/admin/users.py#L229
If this is not implemented, wouldn't it be good to point it out in docs? https://github.com/matrix-org/synapse/blob/master/docs/admin_api/user_admin_api.rst
### Steps to reproduce
- deactivate an account using rest api
- account is properly deactivated
- try and reactivate the account
### Version information
- **Homeserver**: 1.12.3+bionic1
- **Install method**: apt
- **Platform**: ubuntu 18.04
",
1068,https://api.github.com/repos/matrix-org/synapse/issues/7219,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7219/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7219/comments,https://api.github.com/repos/matrix-org/synapse/issues/7219/events,https://github.com/matrix-org/synapse/pull/7219,593575521,MDExOlB1bGxSZXF1ZXN0Mzk4MzMyNTcy,7219,Add typing information to federation_server.,"{'login': 'clokep', 'id': 517124, 'node_id': 'MDQ6VXNlcjUxNzEyNA==', 'avatar_url': 'https://avatars2.githubusercontent.com/u/517124?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/clokep', 'html_url': 'https://github.com/clokep', 'followers_url': 'https://api.github.com/users/clokep/followers', 'following_url': 'https://api.github.com/users/clokep/following{/other_user}', 'gists_url': 'https://api.github.com/users/clokep/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/clokep/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/clokep/subscriptions', 'organizations_url': 'https://api.github.com/users/clokep/orgs', 'repos_url': 'https://api.github.com/users/clokep/repos', 'events_url': 'https://api.github.com/users/clokep/events{/privacy}', 'received_events_url': 'https://api.github.com/users/clokep/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,0,2020-04-03T18:52:36Z,2020-04-07T19:03:25Z,2020-04-07T19:03:24Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7219', 'html_url': 'https://github.com/matrix-org/synapse/pull/7219', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7219.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7219.patch'}","This was another branch I had laying around. I finished it up to finish adding the typing information.
Anyway, it adds typing information, that's pretty much it.",
1069,https://api.github.com/repos/matrix-org/synapse/issues/7218,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7218/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7218/comments,https://api.github.com/repos/matrix-org/synapse/issues/7218/events,https://github.com/matrix-org/synapse/issues/7218,593523393,MDU6SXNzdWU1OTM1MjMzOTM=,7218,synapse refuses to start against sqlite unless sqlite supports json extension,"{'login': 'Zay11Zay', 'id': 29738176, 'node_id': 'MDQ6VXNlcjI5NzM4MTc2', 'avatar_url': 'https://avatars3.githubusercontent.com/u/29738176?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Zay11Zay', 'html_url': 'https://github.com/Zay11Zay', 'followers_url': 'https://api.github.com/users/Zay11Zay/followers', 'following_url': 'https://api.github.com/users/Zay11Zay/following{/other_user}', 'gists_url': 'https://api.github.com/users/Zay11Zay/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/Zay11Zay/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/Zay11Zay/subscriptions', 'organizations_url': 'https://api.github.com/users/Zay11Zay/orgs', 'repos_url': 'https://api.github.com/users/Zay11Zay/repos', 'events_url': 'https://api.github.com/users/Zay11Zay/events{/privacy}', 'received_events_url': 'https://api.github.com/users/Zay11Zay/received_events', 'type': 'User', 'site_admin': False}","[{'id': 477050471, 'node_id': 'MDU6TGFiZWw0NzcwNTA0NzE=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/p3', 'name': 'p3', 'color': '0e8a16', 'default': False, 'description': None}]",open,False,,[],,5,2020-04-03T17:10:52Z,2020-04-20T14:27:37Z,,CONTRIBUTOR,,,"
### Description
Twisted test suite doesn't pass after fresh clone and install
### Steps to reproduce
Steps from the Synapse Development portion of the README
- git clone https://github.com/matrix-org/synapse.git
- cd synapse
- virtualenv -p python3 env
- source env/bin/activate
python -m pip install --no-use-pep517 -e "".[all]""
python -m twisted.trial tests
Ran 907 tests in 41.853s
FAILED (skips=1, errors=610, successes=296)
I guess I was expecting them to pass off a fresh clone, is there something I'm doing wrong? Thanks!
### Version information
- **Homeserver**:
If not matrix.org:
- **Version**:
- **Install method**:
- **Platform**:
",
1070,https://api.github.com/repos/matrix-org/synapse/issues/7217,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7217/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7217/comments,https://api.github.com/repos/matrix-org/synapse/issues/7217/events,https://github.com/matrix-org/synapse/issues/7217,593387080,MDU6SXNzdWU1OTMzODcwODA=,7217,Synapse Homeserver deleted local messages when using purge API,"{'login': 'jakem72360', 'id': 7912205, 'node_id': 'MDQ6VXNlcjc5MTIyMDU=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/7912205?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/jakem72360', 'html_url': 'https://github.com/jakem72360', 'followers_url': 'https://api.github.com/users/jakem72360/followers', 'following_url': 'https://api.github.com/users/jakem72360/following{/other_user}', 'gists_url': 'https://api.github.com/users/jakem72360/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/jakem72360/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/jakem72360/subscriptions', 'organizations_url': 'https://api.github.com/users/jakem72360/orgs', 'repos_url': 'https://api.github.com/users/jakem72360/repos', 'events_url': 'https://api.github.com/users/jakem72360/events{/privacy}', 'received_events_url': 'https://api.github.com/users/jakem72360/received_events', 'type': 'User', 'site_admin': False}","[{'id': 1507817868, 'node_id': 'MDU6TGFiZWwxNTA3ODE3ODY4', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/admin-api', 'name': 'admin-api', 'color': 'e9fc71', 'default': False, 'description': ''}, {'id': 1311133228, 'node_id': 'MDU6TGFiZWwxMzExMTMzMjI4', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/info-needed', 'name': 'info-needed', 'color': 'a1e8ea', 'default': False, 'description': ''}]",closed,False,,[],,4,2020-04-03T13:34:44Z,2020-04-20T15:09:09Z,2020-04-20T15:09:08Z,NONE,,,"### Description
I recently tried to reduce the size of my `homeserver.db` file by issuing
requests to Synapse's Purge History API. After restarting Synapse, all of the
messages in the purged rooms (including my locally sent messages), have been
deleted. This was confirmed by manually inspecting the SQLite database.
Scrolling up to the point of deletion in Riot, yields no results. A loading
spinner shows momentarily, then stops.
### Steps to reproduce
- Retrieve a list of the room IDs to which your user is a member using the client-server API.
- Iterate the list and issue requests using the following shell snippet
`cat | while read i; do curl -X POST ""https:///_synapse/admin/v1/purge_history/$i?access_token="" -d ""{\""purge_up_to_ts\"":$(date -d '-2 days' +%s)000}""; done`
- Stop Synapse using `systemctl stop synapse`, or a relevant init command
- Run `sqlite3 /var/lib/synapse/homeserver.db 'VACUUM;'`
- Restart Synapse
According to the API docs, the above actions should only remove locally cached
messages, however, **ALL** messages have up to two days have been removed from
the homeserver including locally sent messages between users on the affected
server.
Majority of messages (including my own), still exist in the database of a
sister-server, that is a participant in the majority of rooms on the affected
server. Is there any way to transfer them to the database of the affected
server?
### Version information
- **Homeserver**: personal homeserver
- **Version**:
```
{
""python_version"": ""3.8.2"",
""server_version"": ""1.11.1""
}
```
- **Install method**: Arch Linux Repos
- **Platform**:
Arch Linux running inside a VMWare VM.",
1071,https://api.github.com/repos/matrix-org/synapse/issues/7216,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7216/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7216/comments,https://api.github.com/repos/matrix-org/synapse/issues/7216/events,https://github.com/matrix-org/synapse/issues/7216,593371425,MDU6SXNzdWU1OTMzNzE0MjU=,7216,Error in synchrotron worker doc,"{'login': 'dklimpel', 'id': 5740567, 'node_id': 'MDQ6VXNlcjU3NDA1Njc=', 'avatar_url': 'https://avatars2.githubusercontent.com/u/5740567?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/dklimpel', 'html_url': 'https://github.com/dklimpel', 'followers_url': 'https://api.github.com/users/dklimpel/followers', 'following_url': 'https://api.github.com/users/dklimpel/following{/other_user}', 'gists_url': 'https://api.github.com/users/dklimpel/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/dklimpel/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/dklimpel/subscriptions', 'organizations_url': 'https://api.github.com/users/dklimpel/orgs', 'repos_url': 'https://api.github.com/users/dklimpel/repos', 'events_url': 'https://api.github.com/users/dklimpel/events{/privacy}', 'received_events_url': 'https://api.github.com/users/dklimpel/received_events', 'type': 'User', 'site_admin': False}","[{'id': 845245048, 'node_id': 'MDU6TGFiZWw4NDUyNDUwNDg=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/docs', 'name': 'docs', 'color': '0e8a16', 'default': False, 'description': ''}, {'id': 1056680564, 'node_id': 'MDU6TGFiZWwxMDU2NjgwNTY0', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/workers', 'name': 'workers', 'color': 'f9d0c4', 'default': False, 'description': 'Synapse in Worker Mode'}]",closed,False,,[],,5,2020-04-03T13:10:40Z,2020-04-03T15:54:18Z,2020-04-03T15:31:41Z,CONTRIBUTOR,,,"Error in URLs of synapse.app.synchrotron in documentation:
https://github.com/matrix-org/synapse/blob/master/docs/workers.md
```
^/_matrix/client/(v2_alpha|r0)/sync$
^/_matrix/client/(api/v1|v2_alpha|r0)/events$
^/_matrix/client/(api/v1|r0)/initialSync$
^/_matrix/client/(api/v1|r0)/rooms/[^/]+/initialSync$
```
Should be:
```
^/_matrix/client/(v2_alpha|r0)/sync
^/_matrix/client/(api/v1|v2_alpha|r0)/events
^/_matrix/client/(api/v1|r0)/initialSync
^/_matrix/client/(api/v1|r0)/rooms/[^/]+/initialSync
```
See: https://matrix.org/docs/spec/client_server/latest#get-matrix-client-r0-sync",
1072,https://api.github.com/repos/matrix-org/synapse/issues/7215,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7215/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7215/comments,https://api.github.com/repos/matrix-org/synapse/issues/7215/events,https://github.com/matrix-org/synapse/issues/7215,593363381,MDU6SXNzdWU1OTMzNjMzODE=,7215,Bridge for BigBlueButton?,"{'login': 'fooness', 'id': 11408027, 'node_id': 'MDQ6VXNlcjExNDA4MDI3', 'avatar_url': 'https://avatars3.githubusercontent.com/u/11408027?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/fooness', 'html_url': 'https://github.com/fooness', 'followers_url': 'https://api.github.com/users/fooness/followers', 'following_url': 'https://api.github.com/users/fooness/following{/other_user}', 'gists_url': 'https://api.github.com/users/fooness/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/fooness/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/fooness/subscriptions', 'organizations_url': 'https://api.github.com/users/fooness/orgs', 'repos_url': 'https://api.github.com/users/fooness/repos', 'events_url': 'https://api.github.com/users/fooness/events{/privacy}', 'received_events_url': 'https://api.github.com/users/fooness/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,1,2020-04-03T12:57:05Z,2020-04-03T13:23:34Z,2020-04-03T13:23:34Z,NONE,,,Would it be possible to integrate [BigBlueButton](https://docs.bigbluebutton.org/dev/api.html) as was also done with [Jitsi](https://matrix.org/blog/2017/08/23/introducing-matrix-widgets)?,
1073,https://api.github.com/repos/matrix-org/synapse/issues/7214,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7214/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7214/comments,https://api.github.com/repos/matrix-org/synapse/issues/7214/events,https://github.com/matrix-org/synapse/issues/7214,593203154,MDU6SXNzdWU1OTMyMDMxNTQ=,7214,Cannot see messages from one specific user. SynapseError: 403 - You don't have permission to access that event.,"{'login': 'jyte', 'id': 7738906, 'node_id': 'MDQ6VXNlcjc3Mzg5MDY=', 'avatar_url': 'https://avatars2.githubusercontent.com/u/7738906?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/jyte', 'html_url': 'https://github.com/jyte', 'followers_url': 'https://api.github.com/users/jyte/followers', 'following_url': 'https://api.github.com/users/jyte/following{/other_user}', 'gists_url': 'https://api.github.com/users/jyte/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/jyte/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/jyte/subscriptions', 'organizations_url': 'https://api.github.com/users/jyte/orgs', 'repos_url': 'https://api.github.com/users/jyte/repos', 'events_url': 'https://api.github.com/users/jyte/events{/privacy}', 'received_events_url': 'https://api.github.com/users/jyte/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,1,2020-04-03T08:14:51Z,2020-04-03T12:49:56Z,2020-04-03T12:49:56Z,NONE,,,"
### Description
I have a home synapse server setup. With a room that hold ""many"" (arround 30) people in it. And there is one person I cannot see any message from. I only noticed because I saw other people replying to him.
Log state:
```
Apr 3 07:14:34 matrix-ppa matrix-synapse[19361]: 2020-04-03 07:14:34,703 - synapse.http.server - 81 - INFO - GET-77213 - SynapseError: 403 - You don't have permission to access that event.
```
### Steps to reproduce
I don't really know.
### Version information
- **Homeserver**: homeserver, federation disabled & firewalled.
If not matrix.org:
- **Version**: 1.12.3
- **Install method**:
debian package from repository
- **Platform**:
Ubuntu 18.04 on VMWare server, in which I have LXD container based of ubuntu 18.04 image. The host system uses nginx as reverse proxy to the container, and also handle the SSL part.",
1074,https://api.github.com/repos/matrix-org/synapse/issues/7213,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7213/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7213/comments,https://api.github.com/repos/matrix-org/synapse/issues/7213/events,https://github.com/matrix-org/synapse/pull/7213,593058545,MDExOlB1bGxSZXF1ZXN0Mzk3OTIxNDY3,7213,Add explicit python build tools to snapcraft,"{'login': 'devec0', 'id': 1829286, 'node_id': 'MDQ6VXNlcjE4MjkyODY=', 'avatar_url': 'https://avatars2.githubusercontent.com/u/1829286?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/devec0', 'html_url': 'https://github.com/devec0', 'followers_url': 'https://api.github.com/users/devec0/followers', 'following_url': 'https://api.github.com/users/devec0/following{/other_user}', 'gists_url': 'https://api.github.com/users/devec0/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/devec0/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/devec0/subscriptions', 'organizations_url': 'https://api.github.com/users/devec0/orgs', 'repos_url': 'https://api.github.com/users/devec0/repos', 'events_url': 'https://api.github.com/users/devec0/events{/privacy}', 'received_events_url': 'https://api.github.com/users/devec0/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,"{'login': 'anoadragon453', 'id': 1342360, 'node_id': 'MDQ6VXNlcjEzNDIzNjA=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1342360?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/anoadragon453', 'html_url': 'https://github.com/anoadragon453', 'followers_url': 'https://api.github.com/users/anoadragon453/followers', 'following_url': 'https://api.github.com/users/anoadragon453/following{/other_user}', 'gists_url': 'https://api.github.com/users/anoadragon453/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/anoadragon453/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/anoadragon453/subscriptions', 'organizations_url': 'https://api.github.com/users/anoadragon453/orgs', 'repos_url': 'https://api.github.com/users/anoadragon453/repos', 'events_url': 'https://api.github.com/users/anoadragon453/events{/privacy}', 'received_events_url': 'https://api.github.com/users/anoadragon453/received_events', 'type': 'User', 'site_admin': False}","[{'login': 'anoadragon453', 'id': 1342360, 'node_id': 'MDQ6VXNlcjEzNDIzNjA=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1342360?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/anoadragon453', 'html_url': 'https://github.com/anoadragon453', 'followers_url': 'https://api.github.com/users/anoadragon453/followers', 'following_url': 'https://api.github.com/users/anoadragon453/following{/other_user}', 'gists_url': 'https://api.github.com/users/anoadragon453/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/anoadragon453/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/anoadragon453/subscriptions', 'organizations_url': 'https://api.github.com/users/anoadragon453/orgs', 'repos_url': 'https://api.github.com/users/anoadragon453/repos', 'events_url': 'https://api.github.com/users/anoadragon453/events{/privacy}', 'received_events_url': 'https://api.github.com/users/anoadragon453/received_events', 'type': 'User', 'site_admin': False}]",,0,2020-04-03T03:55:22Z,2020-04-17T16:28:01Z,2020-04-17T16:28:01Z,CONTRIBUTOR,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7213', 'html_url': 'https://github.com/matrix-org/synapse/pull/7213', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7213.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7213.patch'}","A small change to explicitly add required Python build tools to the snapcraft metadata.
This resolves an issue where setuptools-scm and wheel were not being installed during building of the Snap due to recent changes.
Adding pip, setuptools, setuptools-scm and wheel ensures these required tools are available now and in the future regardless of changes to Python requirements or the snapcraft tooling.
",
1075,https://api.github.com/repos/matrix-org/synapse/issues/7212,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7212/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7212/comments,https://api.github.com/repos/matrix-org/synapse/issues/7212/events,https://github.com/matrix-org/synapse/pull/7212,592953538,MDExOlB1bGxSZXF1ZXN0Mzk3ODM3ODE5,7212,Update debian build scripts for Pillow 7.1.1.,"{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,0,2020-04-02T22:22:20Z,2020-04-03T09:23:38Z,2020-04-03T09:23:37Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7212', 'html_url': 'https://github.com/matrix-org/synapse/pull/7212', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7212.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7212.patch'}",I believe this will fix #7208.,
1076,https://api.github.com/repos/matrix-org/synapse/issues/7211,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7211/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7211/comments,https://api.github.com/repos/matrix-org/synapse/issues/7211/events,https://github.com/matrix-org/synapse/issues/7211,592847254,MDU6SXNzdWU1OTI4NDcyNTQ=,7211,Synapse 1.12.2 Docker image is broken,"{'login': 'alexrashed', 'id': 2796604, 'node_id': 'MDQ6VXNlcjI3OTY2MDQ=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/2796604?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/alexrashed', 'html_url': 'https://github.com/alexrashed', 'followers_url': 'https://api.github.com/users/alexrashed/followers', 'following_url': 'https://api.github.com/users/alexrashed/following{/other_user}', 'gists_url': 'https://api.github.com/users/alexrashed/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/alexrashed/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/alexrashed/subscriptions', 'organizations_url': 'https://api.github.com/users/alexrashed/orgs', 'repos_url': 'https://api.github.com/users/alexrashed/repos', 'events_url': 'https://api.github.com/users/alexrashed/events{/privacy}', 'received_events_url': 'https://api.github.com/users/alexrashed/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,4,2020-04-02T18:41:14Z,2020-04-03T10:42:43Z,2020-04-03T10:42:43Z,NONE,,,"### Description
The docker images of v1.12.2 (matrixdotorg/synapse:v1.12.2[-py3]) are broken.
They fail due to missing python requirements:
```
ERROR:root:Needed pillow>=4.3.0,<7.1.0, got Pillow==7.1.0
Missing Requirements: 'pillow>=4.3.0,<7.1.0'
To install run:
pip install --upgrade --force 'pillow>=4.3.0,<7.1.0'
```
Since docker tags can be overwritten, here's the digest for the failing images:
sha256:d37b7f73e2fe915fdefda8f1dd46f288fcf7452553945ca3de3d5051c8dc57c5
(matrixdotorg/synapse:v1.12.2 is the same as matrixdotorg/synapse:v1.12.2-py3)
### Steps to reproduce
- Start Synapse using the following docker image: matrixdotorg/synapse:v1.12.2
- You
### Version information
- **Version**: 1.12.2
- **Install method**: Docker
- **Platform**: Docker amd64
",
1077,https://api.github.com/repos/matrix-org/synapse/issues/7210,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7210/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7210/comments,https://api.github.com/repos/matrix-org/synapse/issues/7210/events,https://github.com/matrix-org/synapse/pull/7210,592845568,MDExOlB1bGxSZXF1ZXN0Mzk3NzUwNjQ1,7210,Optional dependencies specifically for building the debs,"{'login': 'anoadragon453', 'id': 1342360, 'node_id': 'MDQ6VXNlcjEzNDIzNjA=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1342360?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/anoadragon453', 'html_url': 'https://github.com/anoadragon453', 'followers_url': 'https://api.github.com/users/anoadragon453/followers', 'following_url': 'https://api.github.com/users/anoadragon453/following{/other_user}', 'gists_url': 'https://api.github.com/users/anoadragon453/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/anoadragon453/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/anoadragon453/subscriptions', 'organizations_url': 'https://api.github.com/users/anoadragon453/orgs', 'repos_url': 'https://api.github.com/users/anoadragon453/repos', 'events_url': 'https://api.github.com/users/anoadragon453/events{/privacy}', 'received_events_url': 'https://api.github.com/users/anoadragon453/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,2,2020-04-02T18:38:14Z,2020-04-03T15:47:22Z,2020-04-03T09:37:14Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7210', 'html_url': 'https://github.com/matrix-org/synapse/pull/7210', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7210.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7210.patch'}","Only applies the workaround for #7208 to building debian packages, not regular Synapse users.
Prevents people with Pillow v7.1.0 from receiving an error trying to start Synapse. They could downgrade, but it'd be a massive faff.",
1078,https://api.github.com/repos/matrix-org/synapse/issues/7209,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7209/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7209/comments,https://api.github.com/repos/matrix-org/synapse/issues/7209/events,https://github.com/matrix-org/synapse/issues/7209,592837773,MDU6SXNzdWU1OTI4Mzc3NzM=,7209,Initial sync included rooms with no information that I'm apparently not in (legacy/unsupported room versions),"{'login': 'turt2live', 'id': 1190097, 'node_id': 'MDQ6VXNlcjExOTAwOTc=', 'avatar_url': 'https://avatars2.githubusercontent.com/u/1190097?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/turt2live', 'html_url': 'https://github.com/turt2live', 'followers_url': 'https://api.github.com/users/turt2live/followers', 'following_url': 'https://api.github.com/users/turt2live/following{/other_user}', 'gists_url': 'https://api.github.com/users/turt2live/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/turt2live/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/turt2live/subscriptions', 'organizations_url': 'https://api.github.com/users/turt2live/orgs', 'repos_url': 'https://api.github.com/users/turt2live/repos', 'events_url': 'https://api.github.com/users/turt2live/events{/privacy}', 'received_events_url': 'https://api.github.com/users/turt2live/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,1,2020-04-02T18:24:35Z,2020-04-02T18:42:17Z,2020-04-02T18:42:17Z,MEMBER,,,"Trying to get members of the room results in `name: ""M_FORBIDDEN"", message: ""User @travis:t2l.io not in room !oeCrnyfPhvZiruUJLn:sw1v.org, and room previews are disabled""`. This is a test room which I should be in.
The room has no name, and I cannot backfill it. 3 of my rooms appear to be impacted by this.
`!oeCrnyfPhvZiruUJLn:sw1v.org` has the version `eventid-noslash-test`.
`!VXChyxVNCBsWeSGcaN:sw1v.org` is `state-v2-test` (old internal room).
`!bNAPsppHlSHCDvMRhh:abolivier.bzh` is another test room with a version of `org.matrix.msc2260`
The theme appears to be that Synapse doesn't recognize the room versions anymore, not that the rooms have reset or been left. Synapse should probably exclude these rooms, or somehow support them enough to refuse new messages?
",
1079,https://api.github.com/repos/matrix-org/synapse/issues/7208,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7208/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7208/comments,https://api.github.com/repos/matrix-org/synapse/issues/7208/events,https://github.com/matrix-org/synapse/issues/7208,592824166,MDU6SXNzdWU1OTI4MjQxNjY=,7208,Unable to build debian packages for debian buster with Pillow 7.1.0,"{'login': 'anoadragon453', 'id': 1342360, 'node_id': 'MDQ6VXNlcjEzNDIzNjA=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1342360?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/anoadragon453', 'html_url': 'https://github.com/anoadragon453', 'followers_url': 'https://api.github.com/users/anoadragon453/followers', 'following_url': 'https://api.github.com/users/anoadragon453/following{/other_user}', 'gists_url': 'https://api.github.com/users/anoadragon453/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/anoadragon453/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/anoadragon453/subscriptions', 'organizations_url': 'https://api.github.com/users/anoadragon453/orgs', 'repos_url': 'https://api.github.com/users/anoadragon453/repos', 'events_url': 'https://api.github.com/users/anoadragon453/events{/privacy}', 'received_events_url': 'https://api.github.com/users/anoadragon453/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,3,2020-04-02T18:01:19Z,2020-04-03T11:07:13Z,2020-04-03T11:07:13Z,MEMBER,,,"
### Description
When trying to build debian packages for Synapse v1.12.1, we ran into a snag with the following error on `debian:buster`:
```
find debian/`dh_listpackages`/ -path '*/site-packages/psycopg2/*.so' | \
xargs dpkg-shlibdeps -Tdebian/`dh_listpackages`.substvars \
-pshlibs1 -dRecommends
dh_shlibdeps -X site-packages/PIL/.libs -X site-packages/psycopg2
dpkg-shlibdeps: error: cannot find library libz-a147dcb0.so.1.2.3 needed by debian/matrix-synapse-py3/opt/venvs/matrix-synapse/lib/python3.7/site-packages/Pillow.libs/libpng16-bedcb7ea.so.16.37.0 (ELF format: 'elf64-x86-64' abi: '0201003e00000000'; RPATH: '')
dpkg-shlibdeps: error: cannot continue due to the error above
```
This appears to be the same error as https://github.com/python-pillow/Pillow/issues/2377, though it's unclear why this issue is only cropping up now.
Pillow did some PNG-related work in release 7.1.0, so that may be the cause. Pinning pillow to
It's not just me seeing this:
",
1083,https://api.github.com/repos/matrix-org/synapse/issues/7204,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7204/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7204/comments,https://api.github.com/repos/matrix-org/synapse/issues/7204/events,https://github.com/matrix-org/synapse/issues/7204,592154981,MDU6SXNzdWU1OTIxNTQ5ODE=,7204,"Can create public room while ""room_list_publication_rules: deny"" when ""alias_creation_rules: allow""","{'login': 'Lighti123', 'id': 34860658, 'node_id': 'MDQ6VXNlcjM0ODYwNjU4', 'avatar_url': 'https://avatars0.githubusercontent.com/u/34860658?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Lighti123', 'html_url': 'https://github.com/Lighti123', 'followers_url': 'https://api.github.com/users/Lighti123/followers', 'following_url': 'https://api.github.com/users/Lighti123/following{/other_user}', 'gists_url': 'https://api.github.com/users/Lighti123/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/Lighti123/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/Lighti123/subscriptions', 'organizations_url': 'https://api.github.com/users/Lighti123/orgs', 'repos_url': 'https://api.github.com/users/Lighti123/repos', 'events_url': 'https://api.github.com/users/Lighti123/events{/privacy}', 'received_events_url': 'https://api.github.com/users/Lighti123/received_events', 'type': 'User', 'site_admin': False}","[{'id': 121086029, 'node_id': 'MDU6TGFiZWwxMjEwODYwMjk=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/bug', 'name': 'bug', 'color': 'fc2929', 'default': True, 'description': None}, {'id': 477043173, 'node_id': 'MDU6TGFiZWw0NzcwNDMxNzM=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/p2', 'name': 'p2', 'color': 'fbca04', 'default': False, 'description': None}]",closed,False,,[],,7,2020-04-01T19:35:30Z,2020-04-13T11:42:48Z,2020-04-13T11:42:47Z,NONE,,,"Hello!
i have the following problem and think it is a bug:
I want my users to be able to create a room and set an alias for it, but prohibit them to set the room public in the public server room list.
For this i set the following options in my own Matrix-Synapse 1.12.0 installation in the homeserver.yaml:
```
alias_creation_rules:
- user_id: ""*""
alias: ""*""
room_id: ""*""
action: allow
```
```
room_list_publication_rules:
- user_id: ""*""
alias: ""*""
room_id: ""*""
action: deny
```
With this setting, my users:
Can create an alias for an existing room, but can not make it public
But:
They can create a NEW room and set the option ""public"" and give it an alias.
The room then is created and appears in the server public room list.
After creation, you can set the option ""public"" for the room setting off again, but not on again like it should be.
Tested with Riot.IM Web 15.12 and Riot.App 15.14.
With the Riot.IM for iOS it works as it should.
With ""alias_creation_rules: action: deny"" it works as it should:
Users can not create public rooms nor set them public after creation (and no aliases, of course)
Thanks!",
1084,https://api.github.com/repos/matrix-org/synapse/issues/7203,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7203/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7203/comments,https://api.github.com/repos/matrix-org/synapse/issues/7203/events,https://github.com/matrix-org/synapse/pull/7203,592100003,MDExOlB1bGxSZXF1ZXN0Mzk3MTQ2Mzg3,7203,Remove some `run_in_background` calls in replication code,"{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,0,2020-04-01T17:58:34Z,2020-04-03T11:29:32Z,2020-04-03T11:29:31Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7203', 'html_url': 'https://github.com/matrix-org/synapse/pull/7203', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7203.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7203.patch'}","By running this stuff with `run_in_background`, it won't be correctly reported
against the relevant CPU usage stats.
Fixes #7202",
1085,https://api.github.com/repos/matrix-org/synapse/issues/7202,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7202/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7202/comments,https://api.github.com/repos/matrix-org/synapse/issues/7202/events,https://github.com/matrix-org/synapse/issues/7202,592087562,MDU6SXNzdWU1OTIwODc1NjI=,7202,workers are spamming 'restarting logcontext' warnings,"{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,"{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}","[{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}]",,2,2020-04-01T17:38:11Z,2020-04-03T11:29:47Z,2020-04-03T11:29:47Z,MEMBER,,,"```
2020-04-01 00:09:04,234 - synapse.logging.context - 345 - WARNING - replication-RDATA-events-751607 - Re-starting finished log context replication-RDATA-events-751607
```
etc.
",
1086,https://api.github.com/repos/matrix-org/synapse/issues/7201,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7201/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7201/comments,https://api.github.com/repos/matrix-org/synapse/issues/7201/events,https://github.com/matrix-org/synapse/issues/7201,592073450,MDU6SXNzdWU1OTIwNzM0NTA=,7201,Server notice rooms cache is never invalidated,"{'login': 'babolivier', 'id': 5547783, 'node_id': 'MDQ6VXNlcjU1NDc3ODM=', 'avatar_url': 'https://avatars3.githubusercontent.com/u/5547783?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/babolivier', 'html_url': 'https://github.com/babolivier', 'followers_url': 'https://api.github.com/users/babolivier/followers', 'following_url': 'https://api.github.com/users/babolivier/following{/other_user}', 'gists_url': 'https://api.github.com/users/babolivier/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/babolivier/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/babolivier/subscriptions', 'organizations_url': 'https://api.github.com/users/babolivier/orgs', 'repos_url': 'https://api.github.com/users/babolivier/repos', 'events_url': 'https://api.github.com/users/babolivier/events{/privacy}', 'received_events_url': 'https://api.github.com/users/babolivier/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,"{'login': 'babolivier', 'id': 5547783, 'node_id': 'MDQ6VXNlcjU1NDc3ODM=', 'avatar_url': 'https://avatars3.githubusercontent.com/u/5547783?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/babolivier', 'html_url': 'https://github.com/babolivier', 'followers_url': 'https://api.github.com/users/babolivier/followers', 'following_url': 'https://api.github.com/users/babolivier/following{/other_user}', 'gists_url': 'https://api.github.com/users/babolivier/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/babolivier/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/babolivier/subscriptions', 'organizations_url': 'https://api.github.com/users/babolivier/orgs', 'repos_url': 'https://api.github.com/users/babolivier/repos', 'events_url': 'https://api.github.com/users/babolivier/events{/privacy}', 'received_events_url': 'https://api.github.com/users/babolivier/received_events', 'type': 'User', 'site_admin': False}","[{'login': 'babolivier', 'id': 5547783, 'node_id': 'MDQ6VXNlcjU1NDc3ODM=', 'avatar_url': 'https://avatars3.githubusercontent.com/u/5547783?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/babolivier', 'html_url': 'https://github.com/babolivier', 'followers_url': 'https://api.github.com/users/babolivier/followers', 'following_url': 'https://api.github.com/users/babolivier/following{/other_user}', 'gists_url': 'https://api.github.com/users/babolivier/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/babolivier/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/babolivier/subscriptions', 'organizations_url': 'https://api.github.com/users/babolivier/orgs', 'repos_url': 'https://api.github.com/users/babolivier/repos', 'events_url': 'https://api.github.com/users/babolivier/events{/privacy}', 'received_events_url': 'https://api.github.com/users/babolivier/received_events', 'type': 'User', 'site_admin': False}]",,1,2020-04-01T17:14:10Z,2020-04-01T17:17:34Z,2020-04-01T17:17:34Z,MEMBER,,,"There's a cache in the function that retrieves or create a server notice room for a user, but this cache is never invalidated.
This means that if the user has left the room and the server wants to notify them again, the server is going to send the notice to the old room instead of creating a new one.",
1087,https://api.github.com/repos/matrix-org/synapse/issues/7200,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7200/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7200/comments,https://api.github.com/repos/matrix-org/synapse/issues/7200/events,https://github.com/matrix-org/synapse/pull/7200,592072193,MDExOlB1bGxSZXF1ZXN0Mzk3MTIzNzA4,7200,Invalidate cache for server notice room ID when the user leaves,"{'login': 'babolivier', 'id': 5547783, 'node_id': 'MDQ6VXNlcjU1NDc3ODM=', 'avatar_url': 'https://avatars3.githubusercontent.com/u/5547783?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/babolivier', 'html_url': 'https://github.com/babolivier', 'followers_url': 'https://api.github.com/users/babolivier/followers', 'following_url': 'https://api.github.com/users/babolivier/following{/other_user}', 'gists_url': 'https://api.github.com/users/babolivier/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/babolivier/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/babolivier/subscriptions', 'organizations_url': 'https://api.github.com/users/babolivier/orgs', 'repos_url': 'https://api.github.com/users/babolivier/repos', 'events_url': 'https://api.github.com/users/babolivier/events{/privacy}', 'received_events_url': 'https://api.github.com/users/babolivier/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,1,2020-04-01T17:12:03Z,2020-06-16T11:19:37Z,2020-04-01T17:18:00Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7200', 'html_url': 'https://github.com/matrix-org/synapse/pull/7200', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7200.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7200.patch'}",,
1088,https://api.github.com/repos/matrix-org/synapse/issues/7199,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7199/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7199/comments,https://api.github.com/repos/matrix-org/synapse/issues/7199/events,https://github.com/matrix-org/synapse/pull/7199,592060805,MDExOlB1bGxSZXF1ZXN0Mzk3MTE0Mjc3,7199,Server notices: Dissociate room creation/lookup from invite,"{'login': 'babolivier', 'id': 5547783, 'node_id': 'MDQ6VXNlcjU1NDc3ODM=', 'avatar_url': 'https://avatars3.githubusercontent.com/u/5547783?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/babolivier', 'html_url': 'https://github.com/babolivier', 'followers_url': 'https://api.github.com/users/babolivier/followers', 'following_url': 'https://api.github.com/users/babolivier/following{/other_user}', 'gists_url': 'https://api.github.com/users/babolivier/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/babolivier/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/babolivier/subscriptions', 'organizations_url': 'https://api.github.com/users/babolivier/orgs', 'repos_url': 'https://api.github.com/users/babolivier/repos', 'events_url': 'https://api.github.com/users/babolivier/events{/privacy}', 'received_events_url': 'https://api.github.com/users/babolivier/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,0,2020-04-01T16:52:36Z,2020-04-04T15:27:47Z,2020-04-04T15:27:46Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7199', 'html_url': 'https://github.com/matrix-org/synapse/pull/7199', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7199.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7199.patch'}","Fixes #6815
Before figuring out whether we should alert a user on MAU, we call `get_notice_room_for_user` to get some info on the existing server notices room for this user. This function, if the room doesn't exist, creates it and invites the user in it. This means that, if we decide later that no server notice is needed, the user gets invited in a room with no message in it. This happens at every restart of the server, since the room ID returned by `get_notice_room_for_user` is cached.
This PR fixes that by moving the inviting bit to a dedicated function, that's only called when the server actually needs to send a notice to the user. A potential issue with this approach is that the room that's created by `get_notice_room_for_user` doesn't match how that same function looks for an existing room (i.e. it creates a room that doesn't have an invite or a join for the current user in it, so it could lead to a new room being created each time a user syncs), but I'm not sure this is a problem given it's cached until the server restarts ~or (as of an upcoming PR) the user leaves the room~, so that function won't run very often.
It also renames `get_notice_room_for_user` into `get_or_create_notice_room_for_user` to make what it does clearer.",
1089,https://api.github.com/repos/matrix-org/synapse/issues/7198,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7198/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7198/comments,https://api.github.com/repos/matrix-org/synapse/issues/7198/events,https://github.com/matrix-org/synapse/issues/7198,591983669,MDU6SXNzdWU1OTE5ODM2Njk=,7198,CAS should use the public_baseurl instead of a separate cas_service_url,"{'login': 'clokep', 'id': 517124, 'node_id': 'MDQ6VXNlcjUxNzEyNA==', 'avatar_url': 'https://avatars2.githubusercontent.com/u/517124?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/clokep', 'html_url': 'https://github.com/clokep', 'followers_url': 'https://api.github.com/users/clokep/followers', 'following_url': 'https://api.github.com/users/clokep/following{/other_user}', 'gists_url': 'https://api.github.com/users/clokep/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/clokep/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/clokep/subscriptions', 'organizations_url': 'https://api.github.com/users/clokep/orgs', 'repos_url': 'https://api.github.com/users/clokep/repos', 'events_url': 'https://api.github.com/users/clokep/events{/privacy}', 'received_events_url': 'https://api.github.com/users/clokep/received_events', 'type': 'User', 'site_admin': False}","[{'id': 481619573, 'node_id': 'MDU6TGFiZWw0ODE2MTk1NzM=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/maintenance', 'name': 'maintenance', 'color': 'fbca04', 'default': False, 'description': None}]",open,False,,[],,0,2020-04-01T14:59:46Z,2020-04-01T14:59:46Z,,MEMBER,,,"When using CAS you currently need to define a `cas_service_url` in the homeserver configuration. This ends up being a duplicate of the `public_baseurl` configuration and should be fairly easy to get rid of.
Reasons for doing this:
* Not having duplicated config is good. 👍
* This will match what SAML requires.
We'll need to deprecate the old option before just outright removing it.",
1090,https://api.github.com/repos/matrix-org/synapse/issues/7197,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7197/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7197/comments,https://api.github.com/repos/matrix-org/synapse/issues/7197/events,https://github.com/matrix-org/synapse/pull/7197,591886400,MDExOlB1bGxSZXF1ZXN0Mzk2OTcwNjI2,7197,Babolivier/server notice invite,"{'login': 'babolivier', 'id': 5547783, 'node_id': 'MDQ6VXNlcjU1NDc3ODM=', 'avatar_url': 'https://avatars3.githubusercontent.com/u/5547783?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/babolivier', 'html_url': 'https://github.com/babolivier', 'followers_url': 'https://api.github.com/users/babolivier/followers', 'following_url': 'https://api.github.com/users/babolivier/following{/other_user}', 'gists_url': 'https://api.github.com/users/babolivier/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/babolivier/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/babolivier/subscriptions', 'organizations_url': 'https://api.github.com/users/babolivier/orgs', 'repos_url': 'https://api.github.com/users/babolivier/repos', 'events_url': 'https://api.github.com/users/babolivier/events{/privacy}', 'received_events_url': 'https://api.github.com/users/babolivier/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,1,2020-04-01T12:42:45Z,2020-04-01T15:31:41Z,2020-04-01T15:31:41Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7197', 'html_url': 'https://github.com/matrix-org/synapse/pull/7197', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7197.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7197.patch'}","Fixes #6815
Before figuring out whether we should alert a user on MAU, we call `get_notice_room_for_user` to get some info on the existing server notices room for this user. This function, if the room doesn't exist, creates it and invites the user in it. This means that, if we decide later that no server notice is needed, the user gets invited in a room with no message in it. This happens at every restart of the server, since the room ID returned by `get_notice_room_for_user` is cached.
This PR fixes that by moving the inviting bit to a dedicated function, that's only called when the server actually needs to send a notice to the user. A potential issue with this approach is that the room that's created by `get_notice_room_for_user` doesn't match how that same function looks for an existing room (i.e. it creates a room that doesn't have an invite or a join for the current user in it, so it could lead to a new room being created each time a user syncs), but I'm not sure this is a problem given it's cached until the server restarts or (as of an upcoming PR) the user leaves the room, so that function won't run very often.
It also renames `get_notice_room_for_user` into `get_or_create_notice_room_for_user` to make what it does clearer.",
1091,https://api.github.com/repos/matrix-org/synapse/issues/7196,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7196/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7196/comments,https://api.github.com/repos/matrix-org/synapse/issues/7196/events,https://github.com/matrix-org/synapse/issues/7196,591831454,MDU6SXNzdWU1OTE4MzE0NTQ=,7196,Error sending email [SMTP],"{'login': 'mario26', 'id': 1866325, 'node_id': 'MDQ6VXNlcjE4NjYzMjU=', 'avatar_url': 'https://avatars0.githubusercontent.com/u/1866325?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/mario26', 'html_url': 'https://github.com/mario26', 'followers_url': 'https://api.github.com/users/mario26/followers', 'following_url': 'https://api.github.com/users/mario26/following{/other_user}', 'gists_url': 'https://api.github.com/users/mario26/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/mario26/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/mario26/subscriptions', 'organizations_url': 'https://api.github.com/users/mario26/orgs', 'repos_url': 'https://api.github.com/users/mario26/repos', 'events_url': 'https://api.github.com/users/mario26/events{/privacy}', 'received_events_url': 'https://api.github.com/users/mario26/received_events', 'type': 'User', 'site_admin': False}","[{'id': 1311133228, 'node_id': 'MDU6TGFiZWwxMzExMTMzMjI4', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/info-needed', 'name': 'info-needed', 'color': 'a1e8ea', 'default': False, 'description': ''}]",closed,False,,[],,2,2020-04-01T11:09:35Z,2020-04-08T09:18:48Z,2020-04-08T09:18:48Z,NONE,,,"Hello,
I configured the email service in Synapse but the emails are not sent, here is the return:
```
synapse | 2020-04-01 10:55:53,106 - synapse.access.http.8008 - 302 - INFO - OPTIONS-9 - 37.173.176.107 - 8008 - {None} Processed request: 0.000sec/0.000sec (0.000sec, 0.000sec) (0.000sec/0.000sec/0) 2B 200 ""OPTIONS /_matrix/client/r0/register/email/requestToken HTTP/1.0"" ""Mozilla/5.0 (X11; Linux x86_64; rv:74.0) Gecko/20100101 Firefox/74.0"" [0 dbevts]
synapse | 2020-04-01 10:55:53,182 - synapse.push.mailer - 315 - INFO - POST-10 - Sending email to xxxxxxx@xxxxxxxx.com
synapse | 2020-04-01 10:55:53,474 - twisted - 192 - INFO - - SMTP Client retrying server. Retry: 5
synapse | 2020-04-01 10:55:53,722 - twisted - 192 - INFO - - SMTP Client retrying server. Retry: 4
synapse | 2020-04-01 10:55:53,966 - twisted - 192 - INFO - - SMTP Client retrying server. Retry: 3
synapse | 2020-04-01 10:55:54,190 - twisted - 192 - INFO - - SMTP Client retrying server. Retry: 2
synapse | 2020-04-01 10:55:54,433 - twisted - 192 - INFO - - SMTP Client retrying server. Retry: 1
synapse | 2020-04-01 10:55:54,673 - synapse.handlers.identity - 359 - ERROR - POST-10 - Error sending threepid validation email to xxxxxxx@xxxxxxxx.com
synapse | Traceback (most recent call last):
synapse | File ""/usr/local/lib/python3.7/site-packages/synapse/handlers/identity.py"", line 356, in send_threepid_validation
synapse | yield send_email_func(email_address, token, client_secret, session_id)
synapse | twisted.mail._except.SMTPConnectError: Unable to connect to server.
synapse | 2020-04-01 10:55:54,674 - synapse.http.server - 81 - INFO - POST-10 - SynapseError: 500 - An error was encountered when sending the email
synapse | 2020-04-01 10:55:54,675 - synapse.access.http.8008 - 302 - INFO - POST-10 - 37.173.176.107 - 8008 - {None} Processed request: 1.501sec/0.001sec (0.016sec, 0.000sec) (0.002sec/0.001sec/2) 81B 500 ""POST /_matrix/client/r0/register/email/requestToken HTTP/1.0"" ""Mozilla/5.0 (X11; Linux x86_64; rv:74.0) Gecko/20100101 Firefox/74.0"" [0 dbevts]
```
I think the server SMTP does not accept the Synapse connection for sending emails, i think of a TLS error...
Here's what my conf looks like:
```
email:
# The hostname of the outgoing SMTP server to use. Defaults to 'localhost'.
#
smtp_host: mail.xxxxxxxx.com
# The port on the mail server for outgoing SMTP. Defaults to 25.
#
#smtp_port: 587
# Username/password for authentication to the SMTP server. By default, no
# authentication is attempted.
#
smtp_user: ""myuser@xxxxxxxx.com""
smtp_pass: ""xxxxxxxxxxxxxxxxxxxxxxxxxxxxx""
require_transport_security: true
```
I have already tried different ways of configuration, nothing works.
Can you help me ?",
1092,https://api.github.com/repos/matrix-org/synapse/issues/7195,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7195/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7195/comments,https://api.github.com/repos/matrix-org/synapse/issues/7195/events,https://github.com/matrix-org/synapse/pull/7195,591759331,MDExOlB1bGxSZXF1ZXN0Mzk2ODY1Nzcz,7195,Remove connections per replication stream metric.,"{'login': 'erikjohnston', 'id': 8428120, 'node_id': 'MDQ6VXNlcjg0MjgxMjA=', 'avatar_url': 'https://avatars0.githubusercontent.com/u/8428120?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/erikjohnston', 'html_url': 'https://github.com/erikjohnston', 'followers_url': 'https://api.github.com/users/erikjohnston/followers', 'following_url': 'https://api.github.com/users/erikjohnston/following{/other_user}', 'gists_url': 'https://api.github.com/users/erikjohnston/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/erikjohnston/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/erikjohnston/subscriptions', 'organizations_url': 'https://api.github.com/users/erikjohnston/orgs', 'repos_url': 'https://api.github.com/users/erikjohnston/repos', 'events_url': 'https://api.github.com/users/erikjohnston/events{/privacy}', 'received_events_url': 'https://api.github.com/users/erikjohnston/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,0,2020-04-01T09:14:22Z,2020-04-01T09:40:48Z,2020-04-01T09:40:47Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7195', 'html_url': 'https://github.com/matrix-org/synapse/pull/7195', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7195.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7195.patch'}","This broke in a recent PR (#7024) and is no longer useful due to all
replication clients implicitly subscribing to all streams, so let's
just remove it.
Fixes #7189",
1093,https://api.github.com/repos/matrix-org/synapse/issues/7194,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7194/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7194/comments,https://api.github.com/repos/matrix-org/synapse/issues/7194/events,https://github.com/matrix-org/synapse/issues/7194,591521631,MDU6SXNzdWU1OTE1MjE2MzE=,7194,Dockerfile problem,"{'login': 'mario26', 'id': 1866325, 'node_id': 'MDQ6VXNlcjE4NjYzMjU=', 'avatar_url': 'https://avatars0.githubusercontent.com/u/1866325?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/mario26', 'html_url': 'https://github.com/mario26', 'followers_url': 'https://api.github.com/users/mario26/followers', 'following_url': 'https://api.github.com/users/mario26/following{/other_user}', 'gists_url': 'https://api.github.com/users/mario26/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/mario26/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/mario26/subscriptions', 'organizations_url': 'https://api.github.com/users/mario26/orgs', 'repos_url': 'https://api.github.com/users/mario26/repos', 'events_url': 'https://api.github.com/users/mario26/events{/privacy}', 'received_events_url': 'https://api.github.com/users/mario26/received_events', 'type': 'User', 'site_admin': False}","[{'id': 1311133228, 'node_id': 'MDU6TGFiZWwxMzExMTMzMjI4', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/info-needed', 'name': 'info-needed', 'color': 'a1e8ea', 'default': False, 'description': ''}]",closed,False,,[],,2,2020-04-01T00:00:09Z,2020-05-06T12:36:52Z,2020-05-06T12:36:52Z,NONE,,,"Hello,
I am trying to run your Dockerfile, but i get this problem:
```
Step 5/17 : COPY synapse /synapse/synapse/
ERROR: Service 'synapse' failed to build: COPY failed: stat /var/lib/docker/tmp/docker-builder170131157/synapse: no such file or directory
```
Dockerfile that i use :
```
# Dockerfile to build the matrixdotorg/synapse docker images.
#
# To build the image, run `docker build` command from the root of the
# synapse repository:
#
# docker build -f docker/Dockerfile .
#
# There is an optional PYTHON_VERSION build argument which sets the
# version of python to build against: for example:
#
# docker build -f docker/Dockerfile --build-arg PYTHON_VERSION=3.6 .
#
# https://forge.tedomum.net/tedomum/synapse/-/tree/aac748e3720e001a2fc9e42ef2add49ce815443e/docker
ARG PYTHON_VERSION=3.7
###
### Stage 0: builder
###
FROM docker.io/python:${PYTHON_VERSION}-alpine3.10 as builder
# install the OS build deps
RUN apk add \
build-base \
libffi-dev \
libjpeg-turbo-dev \
libressl-dev \
libxslt-dev \
linux-headers \
postgresql-dev \
zlib-dev
# build things which have slow build steps, before we copy synapse, so that
# the layer can be cached.
#
# (we really just care about caching a wheel here, as the ""pip install"" below
# will install them again.)
RUN pip install --prefix=""/install"" --no-warn-script-location \
cryptography \
msgpack-python \
pillow \
pynacl
# now install synapse and all of the python deps to /install.
COPY synapse /synapse/synapse/
COPY scripts /synapse/scripts/
COPY MANIFEST.in README.rst setup.py synctl /synapse/
RUN pip install --prefix=""/install"" --no-warn-script-location \
/synapse[all]
# This ugly patch is meant to fix an issue with Twisted forcing a
# downgrade to TLSv1 when opening an SMTP TLS socket.
# See: https://github.com/matrix-org/synapse/issues/6211
RUN sed -i '/ssl.SSL.TLSv1_METHOD/d' /install/lib/python*/site-packages/twisted/mail/smtp.py
###
### Stage 1: runtime
###
FROM docker.io/python:${PYTHON_VERSION}-alpine3.10
# xmlsec is required for saml support
RUN apk add --no-cache --virtual .runtime_deps \
libffi \
libjpeg-turbo \
libressl \
libxslt \
libpq \
zlib \
su-exec \
tzdata \
xmlsec
COPY --from=builder /install /usr/local
COPY ./docker/start.py /start.py
COPY ./docker/conf /conf
VOLUME [""/data""]
EXPOSE 8008/tcp 8009/tcp 8448/tcp
ENTRYPOINT [""/start.py""]
```
I don't understand the problem...
Can you help me ?
",
1094,https://api.github.com/repos/matrix-org/synapse/issues/7193,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7193/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7193/comments,https://api.github.com/repos/matrix-org/synapse/issues/7193/events,https://github.com/matrix-org/synapse/pull/7193,591475185,MDExOlB1bGxSZXF1ZXN0Mzk2NjQzMDU0,7193,bg update to clear out duplicate outbound_device_list_pokes,"{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,"{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}","[{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}]",,3,2020-03-31T22:27:56Z,2020-04-07T22:06:41Z,2020-04-07T22:06:40Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7193', 'html_url': 'https://github.com/matrix-org/synapse/pull/7193', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7193.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7193.patch'}","We seem to have some duplicates, which could do with being cleared out.
~~Based on #7190.~~",
1095,https://api.github.com/repos/matrix-org/synapse/issues/7192,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7192/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7192/comments,https://api.github.com/repos/matrix-org/synapse/issues/7192/events,https://github.com/matrix-org/synapse/pull/7192,591466937,MDExOlB1bGxSZXF1ZXN0Mzk2NjM2MDgy,7192,Remove sent outbound device list pokes from the database,"{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,"{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}","[{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}]",,1,2020-03-31T22:11:44Z,2020-04-07T14:19:21Z,2020-04-07T14:19:20Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7192', 'html_url': 'https://github.com/matrix-org/synapse/pull/7192', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7192.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7192.patch'}",They just get in the way.,
1096,https://api.github.com/repos/matrix-org/synapse/issues/7191,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7191/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7191/comments,https://api.github.com/repos/matrix-org/synapse/issues/7191/events,https://github.com/matrix-org/synapse/pull/7191,591363575,MDExOlB1bGxSZXF1ZXN0Mzk2NTQ4MDEy,7191,Allow admins to create aliases when they are not in the room,"{'login': 'clokep', 'id': 517124, 'node_id': 'MDQ6VXNlcjUxNzEyNA==', 'avatar_url': 'https://avatars2.githubusercontent.com/u/517124?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/clokep', 'html_url': 'https://github.com/clokep', 'followers_url': 'https://api.github.com/users/clokep/followers', 'following_url': 'https://api.github.com/users/clokep/following{/other_user}', 'gists_url': 'https://api.github.com/users/clokep/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/clokep/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/clokep/subscriptions', 'organizations_url': 'https://api.github.com/users/clokep/orgs', 'repos_url': 'https://api.github.com/users/clokep/repos', 'events_url': 'https://api.github.com/users/clokep/events{/privacy}', 'received_events_url': 'https://api.github.com/users/clokep/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,1,2020-03-31T19:26:45Z,2020-04-01T12:27:07Z,2020-04-01T12:27:06Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7191', 'html_url': 'https://github.com/matrix-org/synapse/pull/7191', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7191.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7191.patch'}",This fixes #7052 by allowing server admins to create aliases even when not in the room.,
1097,https://api.github.com/repos/matrix-org/synapse/issues/7190,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7190/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7190/comments,https://api.github.com/repos/matrix-org/synapse/issues/7190/events,https://github.com/matrix-org/synapse/pull/7190,591262186,MDExOlB1bGxSZXF1ZXN0Mzk2NDYyMTYz,7190,Only run one background update at a time,"{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,"{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}","[{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}]",,0,2020-03-31T16:51:15Z,2020-04-03T12:17:33Z,2020-04-03T12:17:31Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7190', 'html_url': 'https://github.com/matrix-org/synapse/pull/7190', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7190.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7190.patch'}","The intention here is to avoid SNAFUs like https://github.com/matrix-org/synapse/issues/6923 and https://github.com/matrix-org/synapse/issues/7065 which are basically caused by us not thinking hard enough about whether it is safe to run particular background updates in a particular order.
I'm adding an `ordering` column to the `background_updates` table, which we should try to populate for future updates, and which will define the order that background updates are performed.
There are a few preparatory changes here; see the individual commits.",
1098,https://api.github.com/repos/matrix-org/synapse/issues/7189,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7189/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7189/comments,https://api.github.com/repos/matrix-org/synapse/issues/7189/events,https://github.com/matrix-org/synapse/issues/7189,591255485,MDU6SXNzdWU1OTEyNTU0ODU=,7189,AttributeError: 'ServerReplicationStreamProtocol' object has no attribute 'replication_streams',"{'login': 'hg-runs', 'id': 29901271, 'node_id': 'MDQ6VXNlcjI5OTAxMjcx', 'avatar_url': 'https://avatars3.githubusercontent.com/u/29901271?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/hg-runs', 'html_url': 'https://github.com/hg-runs', 'followers_url': 'https://api.github.com/users/hg-runs/followers', 'following_url': 'https://api.github.com/users/hg-runs/following{/other_user}', 'gists_url': 'https://api.github.com/users/hg-runs/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/hg-runs/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/hg-runs/subscriptions', 'organizations_url': 'https://api.github.com/users/hg-runs/orgs', 'repos_url': 'https://api.github.com/users/hg-runs/repos', 'events_url': 'https://api.github.com/users/hg-runs/events{/privacy}', 'received_events_url': 'https://api.github.com/users/hg-runs/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,3,2020-03-31T16:41:04Z,2020-04-01T11:06:50Z,2020-04-01T11:06:40Z,NONE,,,"### Description
Using the latest dev build I am getting several of these errors in the homeserver.log
```
2020-03-31 18:02:31,862 - synapse.replication.tcp.protocol - 163 - INFO - - [anon-dQsVA] Connection established
2020-03-31 18:02:31,880 - synapse.replication.tcp.protocol - 421 - INFO - replication-NAME-10 - [anon-dQsVA] Renamed to 'synapse.app.appservice'
2020-03-31 18:02:32,915 - synapse.metrics - 76 - ERROR - - Exception running callback for LaterGauge(synapse_replication_tcp_resource_connections_per_stream)
Traceback (most recent call last):
File ""/opt/synapse/synapse/synapse/metrics/__init__.py"", line 74, in collect
calls = self.caller()
File ""/opt/synapse/synapse/synapse/replication/tcp/resource.py"", line 114, in
for stream_name in self.streams_by_name
File ""/opt/synapse/synapse/synapse/replication/tcp/resource.py"", line 114, in
for stream_name in self.streams_by_name
File ""/opt/synapse/synapse/synapse/replication/tcp/resource.py"", line 111, in
if stream_name in conn.replication_streams
AttributeError: 'ServerReplicationStreamProtocol' object has no attribute 'replication_streams'
2020-03-31 18:02:37,707 - synapse.replication.tcp.protocol - 163 - INFO - - [anon-zCRCR] Connection established
2020-03-31 18:02:37,723 - synapse.replication.tcp.protocol - 421 - INFO - replication-NAME-11 - [anon-zCRCR] Renamed to 'synapse.app.client_reader'
2020-03-31 18:02:43,427 - synapse.replication.tcp.protocol - 163 - INFO - - [anon-NHvgG] Connection established
2020-03-31 18:02:43,464 - synapse.replication.tcp.protocol - 421 - INFO - replication-NAME-12 - [anon-NHvgG] Renamed to 'synapse.app.synchrotron'
2020-03-31 18:02:47,925 - synapse.metrics - 76 - ERROR - - Exception running callback for LaterGauge(synapse_replication_tcp_resource_connections_per_stream)
Traceback (most recent call last):
File ""/opt/synapse/synapse/synapse/metrics/__init__.py"", line 74, in collect
calls = self.caller()
File ""/opt/synapse/synapse/synapse/replication/tcp/resource.py"", line 114, in
for stream_name in self.streams_by_name
File ""/opt/synapse/synapse/synapse/replication/tcp/resource.py"", line 114, in
for stream_name in self.streams_by_name
File ""/opt/synapse/synapse/synapse/replication/tcp/resource.py"", line 111, in
if stream_name in conn.replication_streams
AttributeError: 'ServerReplicationStreamProtocol' object has no attribute 'replication_streams'
2020-03-31 18:02:49,166 - synapse.replication.tcp.protocol - 163 - INFO - - [anon-ZGMih] Connection established
```
### Steps to reproduce
- download latest dev build
- using a worker environment
- start homeserver and check log
### Version information
- **Version**:
homeserver.py version 1.12.0 (b=develop,2e826cd80)
Twisted is 20.3.0 (in case that matters)
- **Install method**:
git pull
- **Platform**:
Debian 9, ARM64
",
1099,https://api.github.com/repos/matrix-org/synapse/issues/7188,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7188/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7188/comments,https://api.github.com/repos/matrix-org/synapse/issues/7188/events,https://github.com/matrix-org/synapse/pull/7188,591250712,MDExOlB1bGxSZXF1ZXN0Mzk2NDUyNDgy,7188,Convert http.HTTPStatus objects to their int equivalent,"{'login': 'anoadragon453', 'id': 1342360, 'node_id': 'MDQ6VXNlcjEzNDIzNjA=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1342360?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/anoadragon453', 'html_url': 'https://github.com/anoadragon453', 'followers_url': 'https://api.github.com/users/anoadragon453/followers', 'following_url': 'https://api.github.com/users/anoadragon453/following{/other_user}', 'gists_url': 'https://api.github.com/users/anoadragon453/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/anoadragon453/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/anoadragon453/subscriptions', 'organizations_url': 'https://api.github.com/users/anoadragon453/orgs', 'repos_url': 'https://api.github.com/users/anoadragon453/repos', 'events_url': 'https://api.github.com/users/anoadragon453/events{/privacy}', 'received_events_url': 'https://api.github.com/users/anoadragon453/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,2,2020-03-31T16:34:18Z,2020-04-03T13:26:09Z,2020-04-03T13:26:08Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7188', 'html_url': 'https://github.com/matrix-org/synapse/pull/7188', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7188.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7188.patch'}","Fixes https://github.com/matrix-org/synapse/issues/7017
This PR fixes a bug where `http.HTTPStatus` objects were printed (whose representation is a str) into logs, showing something like `HTTPStatus.FORBIDDEN` instead of `403`.
This was inconsistent with other log lines and thus made writing log parsers a bit more painful than necessary.
This PR changes any `CodeMessageException` given an `http.HTTPStatus` object will convert it to its integer equivalent when it's instantiated.",
1100,https://api.github.com/repos/matrix-org/synapse/issues/7187,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7187/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7187/comments,https://api.github.com/repos/matrix-org/synapse/issues/7187/events,https://github.com/matrix-org/synapse/pull/7187,591110051,MDExOlB1bGxSZXF1ZXN0Mzk2MzM2MTY4,7187,Move server command handling out of TCP protocol,"{'login': 'erikjohnston', 'id': 8428120, 'node_id': 'MDQ6VXNlcjg0MjgxMjA=', 'avatar_url': 'https://avatars0.githubusercontent.com/u/8428120?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/erikjohnston', 'html_url': 'https://github.com/erikjohnston', 'followers_url': 'https://api.github.com/users/erikjohnston/followers', 'following_url': 'https://api.github.com/users/erikjohnston/following{/other_user}', 'gists_url': 'https://api.github.com/users/erikjohnston/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/erikjohnston/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/erikjohnston/subscriptions', 'organizations_url': 'https://api.github.com/users/erikjohnston/orgs', 'repos_url': 'https://api.github.com/users/erikjohnston/repos', 'events_url': 'https://api.github.com/users/erikjohnston/events{/privacy}', 'received_events_url': 'https://api.github.com/users/erikjohnston/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,1,2020-03-31T13:28:48Z,2020-04-07T09:51:09Z,2020-04-07T09:51:08Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7187', 'html_url': 'https://github.com/matrix-org/synapse/pull/7187', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7187.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7187.patch'}","This completes the merging of server and client command processing.
Based on #7185.",
1101,https://api.github.com/repos/matrix-org/synapse/issues/7186,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7186/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7186/comments,https://api.github.com/repos/matrix-org/synapse/issues/7186/events,https://github.com/matrix-org/synapse/pull/7186,591091987,MDExOlB1bGxSZXF1ZXN0Mzk2MzIxMDc5,7186,Support CAS in UI Auth flows.,"{'login': 'clokep', 'id': 517124, 'node_id': 'MDQ6VXNlcjUxNzEyNA==', 'avatar_url': 'https://avatars2.githubusercontent.com/u/517124?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/clokep', 'html_url': 'https://github.com/clokep', 'followers_url': 'https://api.github.com/users/clokep/followers', 'following_url': 'https://api.github.com/users/clokep/following{/other_user}', 'gists_url': 'https://api.github.com/users/clokep/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/clokep/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/clokep/subscriptions', 'organizations_url': 'https://api.github.com/users/clokep/orgs', 'repos_url': 'https://api.github.com/users/clokep/repos', 'events_url': 'https://api.github.com/users/clokep/events{/privacy}', 'received_events_url': 'https://api.github.com/users/clokep/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,4,2020-03-31T13:04:21Z,2020-04-03T19:35:07Z,2020-04-03T19:35:06Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7186', 'html_url': 'https://github.com/matrix-org/synapse/pull/7186', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7186.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7186.patch'}","This is part of #5667, it adds support for CAS into the user-interactive authentication by building on the work done in #7102. The general flow is the same as #7102, but using the CAS code instead of SAML. One difference is that a new endpoint is used for CAS (where SAML has to re-use the same endpoint), this simplifies code slightly.
See sytests at matrix-org/sytest#845
## TODO
* [x] Change the base branch once #7102 is merged.
* [x] Remove debugging code.
* [x] Test end-to-end.
",
1102,https://api.github.com/repos/matrix-org/synapse/issues/7185,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7185/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7185/comments,https://api.github.com/repos/matrix-org/synapse/issues/7185/events,https://github.com/matrix-org/synapse/pull/7185,591071812,MDExOlB1bGxSZXF1ZXN0Mzk2MzA0MTI4,7185,Move client command handling out of TCP protocol,"{'login': 'erikjohnston', 'id': 8428120, 'node_id': 'MDQ6VXNlcjg0MjgxMjA=', 'avatar_url': 'https://avatars0.githubusercontent.com/u/8428120?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/erikjohnston', 'html_url': 'https://github.com/erikjohnston', 'followers_url': 'https://api.github.com/users/erikjohnston/followers', 'following_url': 'https://api.github.com/users/erikjohnston/following{/other_user}', 'gists_url': 'https://api.github.com/users/erikjohnston/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/erikjohnston/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/erikjohnston/subscriptions', 'organizations_url': 'https://api.github.com/users/erikjohnston/orgs', 'repos_url': 'https://api.github.com/users/erikjohnston/repos', 'events_url': 'https://api.github.com/users/erikjohnston/events{/privacy}', 'received_events_url': 'https://api.github.com/users/erikjohnston/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,1,2020-03-31T12:35:15Z,2020-04-06T08:58:44Z,2020-04-06T08:58:43Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7185', 'html_url': 'https://github.com/matrix-org/synapse/pull/7185', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7185.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7185.patch'}","The aim here is to move the command handling out of the TCP protocol classes and to also merge the client and server command handling (so that we can reuse them for redis protocol). This PR simply moves the client paths to the new `ReplicationCommandHandler`, a future PR will move the server paths too.
The commits should explain what's going on at each step. ""Add ReplicationCommandHandler"" and ""Merge replication command and client handlers"" should mostly just be c+p.
Replaces #7134.",
1103,https://api.github.com/repos/matrix-org/synapse/issues/7184,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7184/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7184/comments,https://api.github.com/repos/matrix-org/synapse/issues/7184/events,https://github.com/matrix-org/synapse/pull/7184,591064472,MDExOlB1bGxSZXF1ZXN0Mzk2Mjk3OTc4,7184,"Do not try to await None, which can be returned by delete_url_cache.","{'login': 'clokep', 'id': 517124, 'node_id': 'MDQ6VXNlcjUxNzEyNA==', 'avatar_url': 'https://avatars2.githubusercontent.com/u/517124?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/clokep', 'html_url': 'https://github.com/clokep', 'followers_url': 'https://api.github.com/users/clokep/followers', 'following_url': 'https://api.github.com/users/clokep/following{/other_user}', 'gists_url': 'https://api.github.com/users/clokep/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/clokep/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/clokep/subscriptions', 'organizations_url': 'https://api.github.com/users/clokep/orgs', 'repos_url': 'https://api.github.com/users/clokep/repos', 'events_url': 'https://api.github.com/users/clokep/events{/privacy}', 'received_events_url': 'https://api.github.com/users/clokep/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,0,2020-03-31T12:24:06Z,2020-03-31T13:33:03Z,2020-03-31T13:33:02Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7184', 'html_url': 'https://github.com/matrix-org/synapse/pull/7184', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7184.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7184.patch'}","Fixes #7182
In the case were `removed_media` is an empty list then `delete_url_cache` returns `None`.
Wrapping this in `defer.ensureDeferred` should fix the error, but it does seem silly to call into a method which we know will just return `None` and then wrap that in a `Deferred`, etc. I did consider just moving the modified line down into the `if removed_media` block.",
1104,https://api.github.com/repos/matrix-org/synapse/issues/7183,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7183/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7183/comments,https://api.github.com/repos/matrix-org/synapse/issues/7183/events,https://github.com/matrix-org/synapse/pull/7183,591038216,MDExOlB1bGxSZXF1ZXN0Mzk2Mjc2MzA3,7183,Reduce the number of calls to `resource.getrusage`,"{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,"{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}","[{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}]",,1,2020-03-31T11:45:16Z,2020-04-03T12:21:32Z,2020-04-03T12:21:31Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7183', 'html_url': 'https://github.com/matrix-org/synapse/pull/7183', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7183.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7183.patch'}","Let's just call `getrusage` once on each logcontext change, rather than twice.
There's two benefits to this:
* optimisation: fewer syscalls
* less cpu time lost down the cracks between logcontexts.",
1105,https://api.github.com/repos/matrix-org/synapse/issues/7182,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7182/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7182/comments,https://api.github.com/repos/matrix-org/synapse/issues/7182/events,https://github.com/matrix-org/synapse/issues/7182,591033874,MDU6SXNzdWU1OTEwMzM4NzQ=,7182,Background process 'expire_url_cache_data' threw an exception,"{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,"{'login': 'clokep', 'id': 517124, 'node_id': 'MDQ6VXNlcjUxNzEyNA==', 'avatar_url': 'https://avatars2.githubusercontent.com/u/517124?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/clokep', 'html_url': 'https://github.com/clokep', 'followers_url': 'https://api.github.com/users/clokep/followers', 'following_url': 'https://api.github.com/users/clokep/following{/other_user}', 'gists_url': 'https://api.github.com/users/clokep/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/clokep/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/clokep/subscriptions', 'organizations_url': 'https://api.github.com/users/clokep/orgs', 'repos_url': 'https://api.github.com/users/clokep/repos', 'events_url': 'https://api.github.com/users/clokep/events{/privacy}', 'received_events_url': 'https://api.github.com/users/clokep/received_events', 'type': 'User', 'site_admin': False}","[{'login': 'clokep', 'id': 517124, 'node_id': 'MDQ6VXNlcjUxNzEyNA==', 'avatar_url': 'https://avatars2.githubusercontent.com/u/517124?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/clokep', 'html_url': 'https://github.com/clokep', 'followers_url': 'https://api.github.com/users/clokep/followers', 'following_url': 'https://api.github.com/users/clokep/following{/other_user}', 'gists_url': 'https://api.github.com/users/clokep/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/clokep/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/clokep/subscriptions', 'organizations_url': 'https://api.github.com/users/clokep/orgs', 'repos_url': 'https://api.github.com/users/clokep/repos', 'events_url': 'https://api.github.com/users/clokep/events{/privacy}', 'received_events_url': 'https://api.github.com/users/clokep/received_events', 'type': 'User', 'site_admin': False}]",,5,2020-03-31T11:37:31Z,2020-04-07T20:56:53Z,2020-04-07T20:56:53Z,MEMBER,,,"I'm seeing this every few seconds:
```
2020-03-31 12:30:15,350 - synapse.rest.media.v1.preview_url_resource - 401 - INFO - expire_url_cache_data-1 - Running url preview cache expiry
2020-03-31 12:30:15,351 - synapse.metrics.background_process_metrics - 215 - ERROR - expire_url_cache_data-1 - Background process 'expire_url_cache_data' threw an exception
Traceback (most recent call last):
File ""/home/rav/work/synapse/env3/lib/python3.6/site-packages/twisted/internet/defer.py"", line 1418, in _inlineCallbacks
result = g.send(result)
StopIteration: []
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File ""/home/rav/work/synapse/env3/lib/python3.6/site-packages/twisted/internet/defer.py"", line 1418, in _inlineCallbacks
result = g.send(result)
StopIteration: []
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File ""/home/rav/work/synapse/synapse/metrics/background_process_metrics.py"", line 213, in run
return (yield result)
File ""/home/rav/work/synapse/env3/lib/python3.6/site-packages/twisted/internet/defer.py"", line 1418, in _inlineCallbacks
result = g.send(result)
File ""/home/rav/work/synapse/synapse/rest/media/v1/preview_url_resource.py"", line 430, in _expire_url_cache_data
await self.store.delete_url_cache(removed_media)
TypeError: object NoneType can't be used in 'await' expression
```
",
1106,https://api.github.com/repos/matrix-org/synapse/issues/7181,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7181/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7181/comments,https://api.github.com/repos/matrix-org/synapse/issues/7181/events,https://github.com/matrix-org/synapse/pull/7181,591009223,MDExOlB1bGxSZXF1ZXN0Mzk2MjUxNjk3,7181,"Fix ""'NoneType' has no attribute start|stop"" logcontext errors","{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,0,2020-03-31T11:01:49Z,2020-03-31T14:18:43Z,2020-03-31T14:18:42Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7181', 'html_url': 'https://github.com/matrix-org/synapse/pull/7181', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7181.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7181.patch'}",Fixes #7179.,
1107,https://api.github.com/repos/matrix-org/synapse/issues/7180,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7180/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7180/comments,https://api.github.com/repos/matrix-org/synapse/issues/7180/events,https://github.com/matrix-org/synapse/issues/7180,591002379,MDU6SXNzdWU1OTEwMDIzNzk=,7180,Security breach: an unencrypted messages is sent to encrypted room,"{'login': '532910', 'id': 14617699, 'node_id': 'MDQ6VXNlcjE0NjE3Njk5', 'avatar_url': 'https://avatars3.githubusercontent.com/u/14617699?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/532910', 'html_url': 'https://github.com/532910', 'followers_url': 'https://api.github.com/users/532910/followers', 'following_url': 'https://api.github.com/users/532910/following{/other_user}', 'gists_url': 'https://api.github.com/users/532910/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/532910/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/532910/subscriptions', 'organizations_url': 'https://api.github.com/users/532910/orgs', 'repos_url': 'https://api.github.com/users/532910/repos', 'events_url': 'https://api.github.com/users/532910/events{/privacy}', 'received_events_url': 'https://api.github.com/users/532910/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,1,2020-03-31T10:52:27Z,2020-03-31T11:32:42Z,2020-03-31T11:32:42Z,NONE,,,"Just updated synapse to 1.12.0-1~bpo10+1, debian buster-backports.
And just received an unencrypted message from another user on my homeserver (the message send from riot for android), on my side it looks so:
desktop version:
![image](https://user-images.githubusercontent.com/14617699/78017807-83ddff80-7355-11ea-813f-9e548404ac53.png)
android:
![image](https://user-images.githubusercontent.com/14617699/78018044-de775b80-7355-11ea-981d-6e14ee57a565.png)
The room is encrypted:
![image](https://user-images.githubusercontent.com/14617699/78018158-0ff02700-7356-11ea-9793-d54293ea37cc.png)
![image](https://user-images.githubusercontent.com/14617699/78018514-b2100f00-7356-11ea-95bc-c8012afa1831.png)",
1108,https://api.github.com/repos/matrix-org/synapse/issues/7179,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7179/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7179/comments,https://api.github.com/repos/matrix-org/synapse/issues/7179/events,https://github.com/matrix-org/synapse/issues/7179,590635017,MDU6SXNzdWU1OTA2MzUwMTc=,7179,`'NoneType' object has no attribute start|stop` exceptions from logging context code,"{'login': 'turt2live', 'id': 1190097, 'node_id': 'MDQ6VXNlcjExOTAwOTc=', 'avatar_url': 'https://avatars2.githubusercontent.com/u/1190097?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/turt2live', 'html_url': 'https://github.com/turt2live', 'followers_url': 'https://api.github.com/users/turt2live/followers', 'following_url': 'https://api.github.com/users/turt2live/following{/other_user}', 'gists_url': 'https://api.github.com/users/turt2live/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/turt2live/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/turt2live/subscriptions', 'organizations_url': 'https://api.github.com/users/turt2live/orgs', 'repos_url': 'https://api.github.com/users/turt2live/repos', 'events_url': 'https://api.github.com/users/turt2live/events{/privacy}', 'received_events_url': 'https://api.github.com/users/turt2live/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,2,2020-03-30T22:17:59Z,2020-03-31T14:25:45Z,2020-03-31T14:25:45Z,MEMBER,,,"```
2020-03-30 22:03:18,603 - twisted - 192 - CRITICAL - - Unhandled Error
Traceback (most recent call last):
File ""/home/matrix/.synapse/local/lib/python3.6/site-packages/synapse/app/_base.py"", line 114, in run
run_command()
File ""/home/matrix/.synapse/local/lib/python3.6/site-packages/twisted/internet/base.py"", line 1283, in run
self.mainLoop()
File ""/home/matrix/.synapse/local/lib/python3.6/site-packages/twisted/internet/base.py"", line 1295, in mainLoop
self.doIteration(t)
File ""/home/matrix/.synapse/local/lib/python3.6/site-packages/twisted/internet/epollreactor.py"", line 235, in doPoll
log.callWithLogger(selectable, _drdw, selectable, fd, event)
--- ---
File ""/home/matrix/.synapse/local/lib/python3.6/site-packages/twisted/python/log.py"", line 103, in callWithLogger
return callWithContext({""system"": lp}, func, *args, **kw)
File ""/home/matrix/.synapse/local/lib/python3.6/site-packages/twisted/python/log.py"", line 86, in callWithContext
return context.call({ILogContext: newCtx}, func, *args, **kw)
File ""/home/matrix/.synapse/local/lib/python3.6/site-packages/twisted/python/context.py"", line 122, in callWithContext
return self.currentContext().callWithContext(ctx, func, *args, **kw)
File ""/home/matrix/.synapse/local/lib/python3.6/site-packages/twisted/python/context.py"", line 85, in callWithContext
return func(*args,**kw)
File ""/home/matrix/.synapse/local/lib/python3.6/site-packages/twisted/internet/posixbase.py"", line 627, in _doReadOrWrite
self._disconnectSelectable(selectable, why, inRead)
File ""/home/matrix/.synapse/local/lib/python3.6/site-packages/twisted/internet/posixbase.py"", line 255, in _disconnectSelectable
selectable.connectionLost(f)
File ""/home/matrix/.synapse/local/lib/python3.6/site-packages/twisted/internet/tcp.py"", line 327, in connectionLost
protocol.connectionLost(reason)
File ""/home/matrix/.synapse/local/lib/python3.6/site-packages/twisted/web/http.py"", line 2433, in connectionLost
request.connectionLost(reason)
File ""/home/matrix/.synapse/local/lib/python3.6/site-packages/synapse/http/site.py"", line 201, in connectionLost
with PreserveLoggingContext(self.logcontext):
File ""/home/matrix/.synapse/local/lib/python3.6/site-packages/synapse/logging/context.py"", line 506, in __enter__
self.current_context = set_current_context(self.new_context)
File ""/home/matrix/.synapse/local/lib/python3.6/site-packages/synapse/logging/context.py"", line 547, in set_current_context
context.start()
builtins.AttributeError: 'NoneType' object has no attribute 'start'
2020-03-30 22:03:19,662 - synapse.util - 123 - ERROR - - Looping call died
Traceback (most recent call last):
File ""/home/matrix/.synapse/local/lib/python3.6/site-packages/twisted/internet/defer.py"", line 151, in maybeDeferred
result = f(*args, **kw)
File ""/home/matrix/.synapse/local/lib/python3.6/site-packages/synapse/metrics/background_process_metrics.py"", line 236, in wrap_as_background_process_inner_2
return run_as_background_process(desc, func, *args, **kwargs)
File ""/home/matrix/.synapse/local/lib/python3.6/site-packages/synapse/metrics/background_process_metrics.py"", line 222, in run_as_background_process
with PreserveLoggingContext():
File ""/home/matrix/.synapse/local/lib/python3.6/site-packages/synapse/logging/context.py"", line 506, in __enter__
self.current_context = set_current_context(self.new_context)
File ""/home/matrix/.synapse/local/lib/python3.6/site-packages/synapse/logging/context.py"", line 545, in set_current_context
current.stop()
AttributeError: 'NoneType' object has no attribute 'stop'
```
The setup here is a Synapse with a single worker (federation sender). The federation sender appears to be fine, though I can't confirm because the master keeps throwing back 500 errors. The stacktrace above is all that was found after seemingly normal traffic (a single client syncing, doing nothing else).
Prior to upgrading, the following was run (with results which get the following output):
```
(.synapse) matrix@matrix:~/.synapse$ pip install 'Twisted>=20.3.0'
Requirement already satisfied: Twisted>=20.3.0 in ./lib/python3.6/site-packages (20.3.0)
Requirement already satisfied: hyperlink>=17.1.1 in ./lib/python3.6/site-packages (from Twisted>=20.3.0) (18.0.0)
Requirement already satisfied: constantly>=15.1 in ./lib/python3.6/site-packages (from Twisted>=20.3.0) (15.1.0)
Requirement already satisfied: Automat>=0.3.0 in ./lib/python3.6/site-packages (from Twisted>=20.3.0) (0.7.0)
Requirement already satisfied: incremental>=16.10.1 in ./lib/python3.6/site-packages (from Twisted>=20.3.0) (17.5.0)
Requirement already satisfied: PyHamcrest!=1.10.0,>=1.9.0 in ./lib/python3.6/site-packages (from Twisted>=20.3.0) (1.9.0)
Requirement already satisfied: zope.interface>=4.4.2 in ./lib/python3.6/site-packages (from Twisted>=20.3.0) (4.6.0)
Requirement already satisfied: attrs>=19.2.0 in ./lib/python3.6/site-packages (from Twisted>=20.3.0) (19.3.0)
Requirement already satisfied: idna>=2.5 in ./lib/python3.6/site-packages (from hyperlink>=17.1.1->Twisted>=20.3.0) (2.9)
Requirement already satisfied: six in ./lib/python3.6/site-packages (from Automat>=0.3.0->Twisted>=20.3.0) (1.14.0)
Requirement already satisfied: setuptools in ./lib/python3.6/site-packages (from PyHamcrest!=1.10.0,>=1.9.0->Twisted>=20.3.0) (40.8.0)
```
Unsure if this happens on master/release.",
1109,https://api.github.com/repos/matrix-org/synapse/issues/7178,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7178/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7178/comments,https://api.github.com/repos/matrix-org/synapse/issues/7178/events,https://github.com/matrix-org/synapse/pull/7178,590467145,MDExOlB1bGxSZXF1ZXN0Mzk1Nzk1ODQ2,7178,Fix a bug which could cause incorrect 'cyclic dependency' error.,"{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,0,2020-03-30T17:34:52Z,2020-03-31T12:09:19Z,2020-03-31T12:09:18Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7178', 'html_url': 'https://github.com/matrix-org/synapse/pull/7178', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7178.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7178.patch'}","If there was an exception setting up one of the attributes of the Homeserver
god object, then future attempts to fetch that attribute would raise a
confusing ""Cyclic dependency"" error. Let's make sure that we clear the
`building` flag so that we just get the original exception.
Ref: #7169",
1110,https://api.github.com/repos/matrix-org/synapse/issues/7177,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7177/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7177/comments,https://api.github.com/repos/matrix-org/synapse/issues/7177/events,https://github.com/matrix-org/synapse/pull/7177,590457010,MDExOlB1bGxSZXF1ZXN0Mzk1Nzg3NTYw,7177,Only setdefault for signatures if device has key_json,"{'login': 'anoadragon453', 'id': 1342360, 'node_id': 'MDQ6VXNlcjEzNDIzNjA=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1342360?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/anoadragon453', 'html_url': 'https://github.com/anoadragon453', 'followers_url': 'https://api.github.com/users/anoadragon453/followers', 'following_url': 'https://api.github.com/users/anoadragon453/following{/other_user}', 'gists_url': 'https://api.github.com/users/anoadragon453/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/anoadragon453/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/anoadragon453/subscriptions', 'organizations_url': 'https://api.github.com/users/anoadragon453/orgs', 'repos_url': 'https://api.github.com/users/anoadragon453/repos', 'events_url': 'https://api.github.com/users/anoadragon453/events{/privacy}', 'received_events_url': 'https://api.github.com/users/anoadragon453/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,3,2020-03-30T17:18:11Z,2020-03-31T13:51:24Z,2020-03-31T13:51:22Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7177', 'html_url': 'https://github.com/matrix-org/synapse/pull/7177', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7177.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7177.patch'}","A possible fix for https://github.com/matrix-org/synapse/issues/7163
I'm not entirely sure what this code is doing, but I know it's incorrect that we're trying to pull a key out of a dictionary all the time, when we're only setting that key sometimes (when `key_json` is truthy).
~~Stopped the exception on Cadair's server (which is expected), however I'm not convinced that this isn't just fixing a symptom of another issue.~~ (@uhoreg seems to think this does the right thing). Considering this code was introduced in 1.11.0 with https://github.com/matrix-org/synapse/pull/6844, but has only been reported with 1.12.0.",
1111,https://api.github.com/repos/matrix-org/synapse/issues/7176,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7176/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7176/comments,https://api.github.com/repos/matrix-org/synapse/issues/7176/events,https://github.com/matrix-org/synapse/issues/7176,590411086,MDU6SXNzdWU1OTA0MTEwODY=,7176,Memory/GC time regression,"{'login': 'tulir', 'id': 4224639, 'node_id': 'MDQ6VXNlcjQyMjQ2Mzk=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/4224639?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/tulir', 'html_url': 'https://github.com/tulir', 'followers_url': 'https://api.github.com/users/tulir/followers', 'following_url': 'https://api.github.com/users/tulir/following{/other_user}', 'gists_url': 'https://api.github.com/users/tulir/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/tulir/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/tulir/subscriptions', 'organizations_url': 'https://api.github.com/users/tulir/orgs', 'repos_url': 'https://api.github.com/users/tulir/repos', 'events_url': 'https://api.github.com/users/tulir/events{/privacy}', 'received_events_url': 'https://api.github.com/users/tulir/received_events', 'type': 'User', 'site_admin': False}","[{'id': 600557921, 'node_id': 'MDU6TGFiZWw2MDA1NTc5MjE=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/performance', 'name': 'performance', 'color': 'fef2c0', 'default': False, 'description': None}]",open,False,,[],,8,2020-03-30T16:07:38Z,2020-06-04T11:29:45Z,,CONTRIBUTOR,,,"# Description
After updating to 1.12.0, average event send times have gone up. Metrics are showing GC time going up a lot more than before, around 1 second per day. Memory usage hasn't changed significantly though. @lub:imninja.net's metrics showed the same problem when I asked in [#synapse:matrix.org](https://matrix.to/#/#synapse:matrix.org).
The problem did not happen with the 1.12 release candidate, which leads me to believe it could have something to do with the Twisted update.
![image](https://user-images.githubusercontent.com/4224639/77932725-9bb27680-72b6-11ea-920e-a9b685ff9fbe.png)
![image](https://user-images.githubusercontent.com/4224639/77932770-aa009280-72b6-11ea-89ae-4c8a3bfb22c5.png)
![image](https://user-images.githubusercontent.com/4224639/77932749-a40ab180-72b6-11ea-8fad-3c5e78e09e99.png)
### Version information
- **Version**: 1.12.0 (https://mau.dev/maunium/synapse)
- **Install method**: Docker
- **Platform**: buster-slim, tested both with and without jemalloc",
1112,https://api.github.com/repos/matrix-org/synapse/issues/7175,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7175/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7175/comments,https://api.github.com/repos/matrix-org/synapse/issues/7175/events,https://github.com/matrix-org/synapse/issues/7175,590350734,MDU6SXNzdWU1OTAzNTA3MzQ=,7175,"""register user"" admin api is incorrectly blocked if the MAU limit has been reached","{'login': 'Twi1ightSparkle', 'id': 19155609, 'node_id': 'MDQ6VXNlcjE5MTU1NjA5', 'avatar_url': 'https://avatars0.githubusercontent.com/u/19155609?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Twi1ightSparkle', 'html_url': 'https://github.com/Twi1ightSparkle', 'followers_url': 'https://api.github.com/users/Twi1ightSparkle/followers', 'following_url': 'https://api.github.com/users/Twi1ightSparkle/following{/other_user}', 'gists_url': 'https://api.github.com/users/Twi1ightSparkle/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/Twi1ightSparkle/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/Twi1ightSparkle/subscriptions', 'organizations_url': 'https://api.github.com/users/Twi1ightSparkle/orgs', 'repos_url': 'https://api.github.com/users/Twi1ightSparkle/repos', 'events_url': 'https://api.github.com/users/Twi1ightSparkle/events{/privacy}', 'received_events_url': 'https://api.github.com/users/Twi1ightSparkle/received_events', 'type': 'User', 'site_admin': False}","[{'id': 1507817868, 'node_id': 'MDU6TGFiZWwxNTA3ODE3ODY4', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/admin-api', 'name': 'admin-api', 'color': 'e9fc71', 'default': False, 'description': ''}, {'id': 121086029, 'node_id': 'MDU6TGFiZWwxMjEwODYwMjk=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/bug', 'name': 'bug', 'color': 'fc2929', 'default': True, 'description': None}, {'id': 477043173, 'node_id': 'MDU6TGFiZWw0NzcwNDMxNzM=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/p2', 'name': 'p2', 'color': 'fbca04', 'default': False, 'description': None}]",closed,False,,[],,4,2020-03-30T14:46:16Z,2020-06-05T12:08:50Z,2020-06-05T12:08:50Z,MEMBER,,,"
### Description
If the server has a MAU user limit, you can add unlimited users accounts. But you cannot add accounts if MAU is rached
### Steps to reproduce
- reach mau limit
- add new user account
### Version information
v1.12.0
- **Homeserver**:
If not matrix.org: At least all Modular servers
Container",
1113,https://api.github.com/repos/matrix-org/synapse/issues/7174,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7174/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7174/comments,https://api.github.com/repos/matrix-org/synapse/issues/7174/events,https://github.com/matrix-org/synapse/issues/7174,590334123,MDU6SXNzdWU1OTAzMzQxMjM=,7174,SQLite: too many SQL variables (federation),"{'login': 'zougloub', 'id': 998040, 'node_id': 'MDQ6VXNlcjk5ODA0MA==', 'avatar_url': 'https://avatars1.githubusercontent.com/u/998040?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/zougloub', 'html_url': 'https://github.com/zougloub', 'followers_url': 'https://api.github.com/users/zougloub/followers', 'following_url': 'https://api.github.com/users/zougloub/following{/other_user}', 'gists_url': 'https://api.github.com/users/zougloub/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/zougloub/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/zougloub/subscriptions', 'organizations_url': 'https://api.github.com/users/zougloub/orgs', 'repos_url': 'https://api.github.com/users/zougloub/repos', 'events_url': 'https://api.github.com/users/zougloub/events{/privacy}', 'received_events_url': 'https://api.github.com/users/zougloub/received_events', 'type': 'User', 'site_admin': False}","[{'id': 121086029, 'node_id': 'MDU6TGFiZWwxMjEwODYwMjk=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/bug', 'name': 'bug', 'color': 'fc2929', 'default': True, 'description': None}, {'id': 477050471, 'node_id': 'MDU6TGFiZWw0NzcwNTA0NzE=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/p3', 'name': 'p3', 'color': '0e8a16', 'default': False, 'description': None}]",closed,False,,[],,12,2020-03-30T14:24:50Z,2020-04-20T14:31:14Z,2020-04-20T14:31:14Z,NONE,,,"### Description
Can't log in after upgrade to v1.12.0
During login, server logs say:
```
2020-03-30 10:23:48,083 - synapse.http.server - 110 - ERROR - GET-1160- Failed handle request via 'SyncRestServlet':
...
File ""/home/matrix/.synapse/lib/python3.6/site-packages/synapse/storage/data_stores/main/event_federation.py"", line 185, in _get_auth_chain_difference_txn
txn.execute(sql % (clause,), args)
File ""/home/matrix/.synapse/lib/python3.6/site-packages/synapse/storage/database.py"", line 199, in execute
self._do_execute(self.txn.execute, sql, *args)
File ""/home/matrix/.synapse/lib/python3.6/site-packages/synapse/storage/database.py"", line 225, in _do_execute
return func(sql, *args)
sqlite3.OperationalError: too many SQL variables
```
(may be another problem)
### Version information
- **Version**: 1.12.0
- **Install method**: pip
- **Platform**: python 3.6.9 / linux / SQLite3 DB
",
1114,https://api.github.com/repos/matrix-org/synapse/issues/7173,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7173/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7173/comments,https://api.github.com/repos/matrix-org/synapse/issues/7173/events,https://github.com/matrix-org/synapse/issues/7173,590309145,MDU6SXNzdWU1OTAzMDkxNDU=,7173,Synapse relies on unspecced behaviour for the remote server to resync device lists after `prune_outbound_device_list_pokes`,"{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}","[{'id': 477045123, 'node_id': 'MDU6TGFiZWw0NzcwNDUxMjM=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/federation', 'name': 'federation', 'color': 'ededed', 'default': False, 'description': None}, {'id': 477043173, 'node_id': 'MDU6TGFiZWw0NzcwNDMxNzM=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/p2', 'name': 'p2', 'color': 'fbca04', 'default': False, 'description': None}, {'id': 828678284, 'node_id': 'MDU6TGFiZWw4Mjg2NzgyODQ=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/spec%20compliance', 'name': 'spec compliance', 'color': 'cf75ef', 'default': False, 'description': 'places where synapse does not conform to the spec'}]",open,False,,[],,0,2020-03-30T13:51:55Z,2020-04-02T17:55:33Z,,MEMBER,,,"Background: each `m.device_list_update` EDU has a `stream_id`; receiving servers can check that they haven't missed any in the sequence. If a receiving server receives an update with a `prev_id` it doesn't recognise, it should do a full resync for that user.
We use this behaviour to prune device list updates for offline server.
However, synapse currently relies on the unspecced behaviour that the remote server will do a full resync if the `prev_id` is empty. This is wrong - an empty `prev_id` means 'this is the first ever update', so there should be no need for the remote server to resync.",
1115,https://api.github.com/repos/matrix-org/synapse/issues/7172,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7172/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7172/comments,https://api.github.com/repos/matrix-org/synapse/issues/7172/events,https://github.com/matrix-org/synapse/pull/7172,590297919,MDExOlB1bGxSZXF1ZXN0Mzk1NjU2NzAx,7172,Use `stream.current_token()` and remove `stream_positions()`,"{'login': 'erikjohnston', 'id': 8428120, 'node_id': 'MDQ6VXNlcjg0MjgxMjA=', 'avatar_url': 'https://avatars0.githubusercontent.com/u/8428120?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/erikjohnston', 'html_url': 'https://github.com/erikjohnston', 'followers_url': 'https://api.github.com/users/erikjohnston/followers', 'following_url': 'https://api.github.com/users/erikjohnston/following{/other_user}', 'gists_url': 'https://api.github.com/users/erikjohnston/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/erikjohnston/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/erikjohnston/subscriptions', 'organizations_url': 'https://api.github.com/users/erikjohnston/orgs', 'repos_url': 'https://api.github.com/users/erikjohnston/repos', 'events_url': 'https://api.github.com/users/erikjohnston/events{/privacy}', 'received_events_url': 'https://api.github.com/users/erikjohnston/received_events', 'type': 'User', 'site_admin': False}","[{'id': 2011569249, 'node_id': 'MDU6TGFiZWwyMDExNTY5MjQ5', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/operation%20gemini', 'name': 'operation gemini', 'color': '006b75', 'default': False, 'description': 'Part of the project to fix the cpu bottleneck on'}]",closed,False,,[],,1,2020-03-30T13:37:52Z,2020-05-07T10:18:51Z,2020-05-01T14:21:36Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7172', 'html_url': 'https://github.com/matrix-org/synapse/pull/7172', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7172.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7172.patch'}","We move the processing of typing and federation replication traffic into their handlers so that `Stream.current_token()` points to a valid token. This allows us to remove `get_streams_to_replicate()` and `stream_positions()`.
~~Based on #7146~~",
1116,https://api.github.com/repos/matrix-org/synapse/issues/7171,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7171/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7171/comments,https://api.github.com/repos/matrix-org/synapse/issues/7171/events,https://github.com/matrix-org/synapse/pull/7171,590267796,MDExOlB1bGxSZXF1ZXN0Mzk1NjMxNjg4,7171,Fix a small typo in the `metrics_flags` config option.,"{'login': 'anoadragon453', 'id': 1342360, 'node_id': 'MDQ6VXNlcjEzNDIzNjA=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1342360?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/anoadragon453', 'html_url': 'https://github.com/anoadragon453', 'followers_url': 'https://api.github.com/users/anoadragon453/followers', 'following_url': 'https://api.github.com/users/anoadragon453/following{/other_user}', 'gists_url': 'https://api.github.com/users/anoadragon453/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/anoadragon453/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/anoadragon453/subscriptions', 'organizations_url': 'https://api.github.com/users/anoadragon453/orgs', 'repos_url': 'https://api.github.com/users/anoadragon453/repos', 'events_url': 'https://api.github.com/users/anoadragon453/events{/privacy}', 'received_events_url': 'https://api.github.com/users/anoadragon453/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,0,2020-03-30T12:55:22Z,2020-03-30T16:38:23Z,2020-03-30T16:38:22Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7171', 'html_url': 'https://github.com/matrix-org/synapse/pull/7171', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7171.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7171.patch'}",`g auge` -> `gauge`,
1117,https://api.github.com/repos/matrix-org/synapse/issues/7170,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7170/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7170/comments,https://api.github.com/repos/matrix-org/synapse/issues/7170/events,https://github.com/matrix-org/synapse/issues/7170,590203347,MDU6SXNzdWU1OTAyMDMzNDc=,7170,"Inbound federation worker crashed with ""Workers cannot send federation traffic"" on 1.12.0","{'login': 'Half-Shot', 'id': 2072976, 'node_id': 'MDQ6VXNlcjIwNzI5NzY=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/2072976?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Half-Shot', 'html_url': 'https://github.com/Half-Shot', 'followers_url': 'https://api.github.com/users/Half-Shot/followers', 'following_url': 'https://api.github.com/users/Half-Shot/following{/other_user}', 'gists_url': 'https://api.github.com/users/Half-Shot/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/Half-Shot/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/Half-Shot/subscriptions', 'organizations_url': 'https://api.github.com/users/Half-Shot/orgs', 'repos_url': 'https://api.github.com/users/Half-Shot/repos', 'events_url': 'https://api.github.com/users/Half-Shot/events{/privacy}', 'received_events_url': 'https://api.github.com/users/Half-Shot/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,2,2020-03-30T11:10:42Z,2020-03-30T11:47:36Z,2020-03-30T11:47:36Z,CONTRIBUTOR,,,"Not sure why it's trying to do this, or if it's a misconfigration. This was working on 1.11.0 and seems to have stopped when I upgraded to 1.12.0.
```
2020-03-30 11:07:26,668 - synapse.storage.data_stores.main.event_push_actions - 511 - INFO - None- Found stream ordering 1 day ago: it's 36326079
2020-03-30 11:07:26,739 - synapse.storage.data_stores - 68 - INFO - None- Starting 'state' data store
2020-03-30 11:07:26,746 - synapse.storage.data_stores - 81 - INFO - None- Database 'master' prepared
2020-03-30 11:07:26,747 - synapse.server - 243 - INFO - None- Finished setting up.
2020-03-30 11:07:26,750 - synapse.app.federation_reader - 110 - INFO - - Running
2020-03-30 11:07:26,751 - synapse.app.homeserver - 30 - INFO - - Set file limit to: 524288
2020-03-30 11:07:26,751 - synapse.config.tls - 494 - INFO - - Loading TLS certificate from /etc/letsencrypt/live/reckless.half-shot.uk/fullchain.pem
2020-03-30 11:07:26,770 - synapse.app.generic_worker - 238 - INFO - - Presence process_id is 'kDnIJBEVcbbjIeAD'
2020-03-30 11:07:26,770 - synapse.push.pusher - 42 - INFO - - email enable notifs: False
2020-03-30 11:07:26,771 - twisted - 192 - ERROR - - Traceback (most recent call last):
2020-03-30 11:07:26,772 - twisted - 192 - ERROR - - File ""/opt/synapse/lib/python3.7/site-packages/synapse/app/_base.py"", line 277, in start
2020-03-30 11:07:26,772 - twisted - 192 - ERROR - - hs.start_listening(listeners)
2020-03-30 11:07:26,772 - twisted - 192 - ERROR - - File ""/opt/synapse/lib/python3.7/site-packages/synapse/app/generic_worker.py"", line 553, in start_listening
2020-03-30 11:07:26,772 - twisted - 192 - ERROR - - self._listen_http(listener)
2020-03-30 11:07:26,772 - twisted - 192 - ERROR - - File ""/opt/synapse/lib/python3.7/site-packages/synapse/app/generic_worker.py"", line 495, in _listen_http
2020-03-30 11:07:26,772 - twisted - 192 - ERROR - - resources.update({FEDERATION_PREFIX: TransportLayerServer(self)})
2020-03-30 11:07:26,772 - twisted - 192 - ERROR - - File ""/opt/synapse/lib/python3.7/site-packages/synapse/federation/transport/server.py"", line 76, in __init__
2020-03-30 11:07:26,772 - twisted - 192 - ERROR - - self.authenticator = Authenticator(hs)
2020-03-30 11:07:26,772 - twisted - 192 - ERROR - - File ""/opt/synapse/lib/python3.7/site-packages/synapse/federation/transport/server.py"", line 116, in __init__
2020-03-30 11:07:26,772 - twisted - 192 - ERROR - - self.replication_client = hs.get_tcp_replication()
2020-03-30 11:07:26,773 - twisted - 192 - ERROR - - File ""/opt/synapse/lib/python3.7/site-packages/synapse/server.py"", line 568, in _get
2020-03-30 11:07:26,773 - twisted - 192 - ERROR - - dep = builder()
2020-03-30 11:07:26,773 - twisted - 192 - ERROR - - File ""/opt/synapse/lib/python3.7/site-packages/synapse/app/generic_worker.py"", line 581, in build_tcp_replication
2020-03-30 11:07:26,773 - twisted - 192 - ERROR - - return GenericWorkerReplicationHandler(self)
2020-03-30 11:07:26,773 - twisted - 192 - ERROR - - File ""/opt/synapse/lib/python3.7/site-packages/synapse/app/generic_worker.py"", line 604, in __init__
2020-03-30 11:07:26,773 - twisted - 192 - ERROR - - self.send_handler = FederationSenderHandler(hs, self)
2020-03-30 11:07:26,773 - twisted - 192 - ERROR - - File ""/opt/synapse/lib/python3.7/site-packages/synapse/app/generic_worker.py"", line 734, in __init__
2020-03-30 11:07:26,773 - twisted - 192 - ERROR - - self.federation_sender = hs.get_federation_sender()
2020-03-30 11:07:26,773 - twisted - 192 - ERROR - - File ""/opt/synapse/lib/python3.7/site-packages/synapse/server.py"", line 568, in _get
2020-03-30 11:07:26,773 - twisted - 192 - ERROR - - dep = builder()
2020-03-30 11:07:26,773 - twisted - 192 - ERROR - - File ""/opt/synapse/lib/python3.7/site-packages/synapse/server.py"", line 445, in build_federation_sender
2020-03-30 11:07:26,773 - twisted - 192 - ERROR - - raise Exception(""Workers cannot send federation traffic"")
2020-03-30 11:07:26,773 - twisted - 192 - ERROR - - Exception: Workers cannot send federation traffic
2020-03-30 11:07:26,774 - twisted - 192 - CRITICAL - - Unhandled Error
Traceback (most recent call last):
File ""/opt/synapse/lib/python3.7/site-packages/twisted/internet/base.py"", line 1282, in run
self.startRunning(installSignalHandlers=installSignalHandlers)
File ""/opt/synapse/lib/python3.7/site-packages/twisted/internet/base.py"", line 1262, in startRunning
ReactorBase.startRunning(self)
File ""/opt/synapse/lib/python3.7/site-packages/twisted/internet/base.py"", line 770, in startRunning
self.fireSystemEvent('startup')
File ""/opt/synapse/lib/python3.7/site-packages/twisted/internet/base.py"", line 721, in fireSystemEvent
event.fireEvent()
--- ---
File ""/opt/synapse/lib/python3.7/site-packages/twisted/internet/base.py"", line 428, in fireEvent
result = callable(*args, **kwargs)
File ""/opt/synapse/lib/python3.7/site-packages/synapse/app/_base.py"", line 297, in start
sys.exit(1)
builtins.SystemExit: 1
```",
1118,https://api.github.com/repos/matrix-org/synapse/issues/7169,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7169/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7169/comments,https://api.github.com/repos/matrix-org/synapse/issues/7169/events,https://github.com/matrix-org/synapse/issues/7169,590200411,MDU6SXNzdWU1OTAyMDA0MTE=,7169,Cyclic dependency while building tcp_replication error in 1.12.0,"{'login': 'Half-Shot', 'id': 2072976, 'node_id': 'MDQ6VXNlcjIwNzI5NzY=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/2072976?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Half-Shot', 'html_url': 'https://github.com/Half-Shot', 'followers_url': 'https://api.github.com/users/Half-Shot/followers', 'following_url': 'https://api.github.com/users/Half-Shot/following{/other_user}', 'gists_url': 'https://api.github.com/users/Half-Shot/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/Half-Shot/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/Half-Shot/subscriptions', 'organizations_url': 'https://api.github.com/users/Half-Shot/orgs', 'repos_url': 'https://api.github.com/users/Half-Shot/repos', 'events_url': 'https://api.github.com/users/Half-Shot/events{/privacy}', 'received_events_url': 'https://api.github.com/users/Half-Shot/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,2,2020-03-30T11:05:42Z,2020-04-01T13:42:32Z,2020-04-01T13:42:32Z,CONTRIBUTOR,,,"Updating to 1.12.0 from 1.11.0 today, and found that my synchronous have stopped working and are displaying this error when handling requests. I can't see any warnings in CHANGES.md of package breakages so I'm not sure what's going on here.
```
2020-03-30 11:03:19,111 - synapse.http.server - 110 - ERROR - GET-292- Failed handle request via 'SyncRestServlet':
Traceback (most recent call last):
File ""/opt/synapse/lib/python3.7/site-packages/synapse/http/server.py"", line 78, in wrapped_request_handler
await h(self, request)
File ""/opt/synapse/lib/python3.7/site-packages/synapse/http/server.py"", line 331, in _async_render
callback_return = await callback_return
File ""/opt/synapse/lib/python3.7/site-packages/synapse/rest/client/v2_alpha/sync.py"", line 96, in on_GET
requester = await self.auth.get_user_by_req(request, allow_guest=True)
File ""/opt/synapse/lib/python3.7/site-packages/twisted/internet/defer.py"", line 1418, in _inlineCallbacks
result = g.send(result)
File ""/opt/synapse/lib/python3.7/site-packages/synapse/api/auth.py"", line 232, in get_user_by_req
device_id=device_id,
File ""/opt/synapse/lib/python3.7/site-packages/synapse/replication/slave/storage/client_ips.py"", line 47, in insert_client_ip
self.hs.get_tcp_replication().send_user_ip(
File ""/opt/synapse/lib/python3.7/site-packages/synapse/server.py"", line 565, in _get
raise ValueError(""Cyclic dependency while building %s"" % (depname,))
ValueError: Cyclic dependency while building tcp_replication
```",
1119,https://api.github.com/repos/matrix-org/synapse/issues/7168,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7168/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7168/comments,https://api.github.com/repos/matrix-org/synapse/issues/7168/events,https://github.com/matrix-org/synapse/issues/7168,589666504,MDU6SXNzdWU1ODk2NjY1MDQ=,7168,IOS calls not working,"{'login': 'myoussef89', 'id': 26151993, 'node_id': 'MDQ6VXNlcjI2MTUxOTkz', 'avatar_url': 'https://avatars0.githubusercontent.com/u/26151993?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/myoussef89', 'html_url': 'https://github.com/myoussef89', 'followers_url': 'https://api.github.com/users/myoussef89/followers', 'following_url': 'https://api.github.com/users/myoussef89/following{/other_user}', 'gists_url': 'https://api.github.com/users/myoussef89/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/myoussef89/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/myoussef89/subscriptions', 'organizations_url': 'https://api.github.com/users/myoussef89/orgs', 'repos_url': 'https://api.github.com/users/myoussef89/repos', 'events_url': 'https://api.github.com/users/myoussef89/events{/privacy}', 'received_events_url': 'https://api.github.com/users/myoussef89/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,2,2020-03-28T21:50:11Z,2020-03-30T14:39:41Z,2020-03-30T14:39:41Z,NONE,,,"I tried to test from android > android on different networks and its working with the turn server,
when I try from android > IOS or from IOS > IOS on the same network it's working.
when I try from android > IOS or from IOS > IOS on different networks it's not working.
did anyone faced like an issue before, or any clue for that?
Android 9
IOS13.4
synapse:v0.31.1",
1120,https://api.github.com/repos/matrix-org/synapse/issues/7167,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7167/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7167/comments,https://api.github.com/repos/matrix-org/synapse/issues/7167/events,https://github.com/matrix-org/synapse/pull/7167,589625958,MDExOlB1bGxSZXF1ZXN0Mzk1MTMwMzg5,7167,Improve TURN documentation.,"{'login': 'josteink', 'id': 411338, 'node_id': 'MDQ6VXNlcjQxMTMzOA==', 'avatar_url': 'https://avatars2.githubusercontent.com/u/411338?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/josteink', 'html_url': 'https://github.com/josteink', 'followers_url': 'https://api.github.com/users/josteink/followers', 'following_url': 'https://api.github.com/users/josteink/following{/other_user}', 'gists_url': 'https://api.github.com/users/josteink/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/josteink/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/josteink/subscriptions', 'organizations_url': 'https://api.github.com/users/josteink/orgs', 'repos_url': 'https://api.github.com/users/josteink/repos', 'events_url': 'https://api.github.com/users/josteink/events{/privacy}', 'received_events_url': 'https://api.github.com/users/josteink/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,5,2020-03-28T17:53:35Z,2020-03-31T14:50:49Z,2020-03-31T14:50:49Z,CONTRIBUTOR,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7167', 'html_url': 'https://github.com/matrix-org/synapse/pull/7167', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7167.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7167.patch'}","Public IP seems to be a fixed requirement, and not mentioning it in the docs is guaranteed to have people waste their time on setups which will never work.
Signed-off-by: Jostein Kjønigsen
### Pull Request Checklist
* [x] Pull request is based on the develop branch
* [x] Pull request includes a [changelog file](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#changelog). The entry should:
- Be a short description of your change which makes sense to users. ""Fixed a bug that prevented receiving messages from other servers."" instead of ""Moved X method from `EventStore` to `EventWorkerStore`."".
- Use markdown where necessary, mostly for `code blocks`.
- End with either a period (.) or an exclamation mark (!).
- Start with a capital letter.
* [x] Pull request includes a [sign off](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#sign-off)
* [x] Code style is correct (run the [linters](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#code-style))
",
1121,https://api.github.com/repos/matrix-org/synapse/issues/7166,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7166/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7166/comments,https://api.github.com/repos/matrix-org/synapse/issues/7166/events,https://github.com/matrix-org/synapse/issues/7166,589578474,MDU6SXNzdWU1ODk1Nzg0NzQ=,7166,homeserver.yaml variable to specify self hosted jitsi-server,"{'login': 'zaggynl', 'id': 5062119, 'node_id': 'MDQ6VXNlcjUwNjIxMTk=', 'avatar_url': 'https://avatars2.githubusercontent.com/u/5062119?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/zaggynl', 'html_url': 'https://github.com/zaggynl', 'followers_url': 'https://api.github.com/users/zaggynl/followers', 'following_url': 'https://api.github.com/users/zaggynl/following{/other_user}', 'gists_url': 'https://api.github.com/users/zaggynl/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/zaggynl/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/zaggynl/subscriptions', 'organizations_url': 'https://api.github.com/users/zaggynl/orgs', 'repos_url': 'https://api.github.com/users/zaggynl/repos', 'events_url': 'https://api.github.com/users/zaggynl/events{/privacy}', 'received_events_url': 'https://api.github.com/users/zaggynl/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,2,2020-03-28T13:33:56Z,2020-04-06T14:40:16Z,2020-04-06T14:40:15Z,NONE,,,"As per subject.
For privacy and to take load off public jitsi-meet servers.
",
1122,https://api.github.com/repos/matrix-org/synapse/issues/7165,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7165/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7165/comments,https://api.github.com/repos/matrix-org/synapse/issues/7165/events,https://github.com/matrix-org/synapse/issues/7165,589571279,MDU6SXNzdWU1ODk1NzEyNzk=,7165,KeyError for is_verified in e2e_room_keys.py,"{'login': 'darix', 'id': 230233, 'node_id': 'MDQ6VXNlcjIzMDIzMw==', 'avatar_url': 'https://avatars0.githubusercontent.com/u/230233?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/darix', 'html_url': 'https://github.com/darix', 'followers_url': 'https://api.github.com/users/darix/followers', 'following_url': 'https://api.github.com/users/darix/following{/other_user}', 'gists_url': 'https://api.github.com/users/darix/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/darix/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/darix/subscriptions', 'organizations_url': 'https://api.github.com/users/darix/orgs', 'repos_url': 'https://api.github.com/users/darix/repos', 'events_url': 'https://api.github.com/users/darix/events{/privacy}', 'received_events_url': 'https://api.github.com/users/darix/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,1,2020-03-28T12:49:29Z,2020-03-29T14:19:37Z,2020-03-29T14:19:37Z,NONE,,,"### Description
https://github.com/matrix-org/synapse/commit/80e580ae92d1170a4ac2f6afb2fa70f5f8e7b4ac
The code doesnt check if is_verified is set at all which leads to:
```
File ""/usr/lib/python3.6/site-packages/synapse/handlers/e2e_room_keys.py"", line 210, in upload_room_keys
if not isinstance(room_key[""is_verified""], bool):
KeyError: 'is_verified'
```
### Steps to reproduce
- seems to happen when I reload my riot-web tab
### Version information
* openSUSE:Leap 15.1
* matrix-synapse-1.12.0-lp151.151.2.noarch
* riot-web-1.5.14~rc1-0.noarch
",
1123,https://api.github.com/repos/matrix-org/synapse/issues/7164,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7164/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7164/comments,https://api.github.com/repos/matrix-org/synapse/issues/7164/events,https://github.com/matrix-org/synapse/issues/7164,589554861,MDU6SXNzdWU1ODk1NTQ4NjE=,7164,Synapse returned event in backfill that was already returned during sync,"{'login': 'bwindels', 'id': 274386, 'node_id': 'MDQ6VXNlcjI3NDM4Ng==', 'avatar_url': 'https://avatars1.githubusercontent.com/u/274386?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bwindels', 'html_url': 'https://github.com/bwindels', 'followers_url': 'https://api.github.com/users/bwindels/followers', 'following_url': 'https://api.github.com/users/bwindels/following{/other_user}', 'gists_url': 'https://api.github.com/users/bwindels/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/bwindels/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/bwindels/subscriptions', 'organizations_url': 'https://api.github.com/users/bwindels/orgs', 'repos_url': 'https://api.github.com/users/bwindels/repos', 'events_url': 'https://api.github.com/users/bwindels/events{/privacy}', 'received_events_url': 'https://api.github.com/users/bwindels/received_events', 'type': 'User', 'site_admin': False}","[{'id': 121086029, 'node_id': 'MDU6TGFiZWwxMjEwODYwMjk=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/bug', 'name': 'bug', 'color': 'fc2929', 'default': True, 'description': None}]",closed,False,,[],,9,2020-03-28T11:02:11Z,2020-03-31T12:07:04Z,2020-03-30T16:00:14Z,MEMBER,,,"### Steps to reproduce
- request https://matrix.org/_matrix/client/r0/rooms/!WCHwNGGsrVwPeRtAnq%3Amatrix.org/messages?from=t116230-1314852630_757269739_1037333_466964661_301544009_1144442_46059099_22957226_86880&dir=b&limit=10&filter=%7B%22lazy_load_members%22%3Atrue%7D with an access token that has access to the room ""Matrix & ex-Matrix"" (!WCHwNGGsrVwPeRtAnq:matrix.org)
- The second event is `$1585350022333PFkGE:lant.uk`, before `$158535013295770ZmONI:matrix.org` (the 1st event in the backfill)
- This event was also returned during a sync to be between events `$1585352285101062xfUvo:matrix.org` and `$1585352478298tKJwR:lant.uk`
The same event is thus returned to be at 2 locations in the timeline.
The event came from another server, at a time that the federation was lagging considerably.",
1124,https://api.github.com/repos/matrix-org/synapse/issues/7163,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7163/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7163/comments,https://api.github.com/repos/matrix-org/synapse/issues/7163/events,https://github.com/matrix-org/synapse/issues/7163,589465612,MDU6SXNzdWU1ODk0NjU2MTI=,7163,"Something odd happened to my device list/keys, and then my messages wouldn't federate anymore.","{'login': 'lampholder', 'id': 1922197, 'node_id': 'MDQ6VXNlcjE5MjIxOTc=', 'avatar_url': 'https://avatars2.githubusercontent.com/u/1922197?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/lampholder', 'html_url': 'https://github.com/lampholder', 'followers_url': 'https://api.github.com/users/lampholder/followers', 'following_url': 'https://api.github.com/users/lampholder/following{/other_user}', 'gists_url': 'https://api.github.com/users/lampholder/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/lampholder/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/lampholder/subscriptions', 'organizations_url': 'https://api.github.com/users/lampholder/orgs', 'repos_url': 'https://api.github.com/users/lampholder/repos', 'events_url': 'https://api.github.com/users/lampholder/events{/privacy}', 'received_events_url': 'https://api.github.com/users/lampholder/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,4,2020-03-27T23:50:18Z,2020-04-02T13:21:04Z,2020-04-02T13:21:03Z,MEMBER,,,"lant.uk synapse was accepting messages, but they weren't making it to matrix.org.
Anecdotally this seemed to start at the same time I logged out of Riot Android to test another account (not on lant.uk), then tried to log in to my main account again. This login attempt never succeeded.
Synapse was logging the following:
```
Mar 28 00:11:11 thor matrix-synapse[31968]: 2020-03-27 23:11:11,815 - synapse.federation.sender.per_destination_queue - 332 - ERROR - federation_transaction_transmission_loop-0 - TX [matrix.org] Failed to send transaction
Mar 28 00:11:11 thor matrix-synapse[31968]: Traceback (most recent call last):
Mar 28 00:11:11 thor matrix-synapse[31968]: File ""/usr/local/lib/python3.7/site-packages/twisted/internet/defer.py"", line 1418, in _inlineCallbacks
Mar 28 00:11:11 thor matrix-synapse[31968]: result = g.send(result)
Mar 28 00:11:11 thor matrix-synapse[31968]: StopIteration: 0
Mar 28 00:11:11 thor matrix-synapse[31968]: During handling of the above exception, another exception occurred:
Mar 28 00:11:11 thor matrix-synapse[31968]: Traceback (most recent call last):
Mar 28 00:11:11 thor matrix-synapse[31968]: File ""/usr/local/lib/python3.7/site-packages/twisted/internet/defer.py"", line 1418, in _inlineCallbacks
Mar 28 00:11:11 thor matrix-synapse[31968]: result = g.send(result)
Mar 28 00:11:11 thor matrix-synapse[31968]: StopIteration: 0
Mar 28 00:11:11 thor matrix-synapse[31968]: During handling of the above exception, another exception occurred:
Mar 28 00:11:11 thor matrix-synapse[31968]: Traceback (most recent call last):
Mar 28 00:11:11 thor matrix-synapse[31968]: File ""/usr/local/lib/python3.7/site-packages/synapse/federation/sender/per_destination_queue.py"", line 201, in _transaction_transmission_loop
Mar 28 00:11:11 thor matrix-synapse[31968]: limit
Mar 28 00:11:11 thor matrix-synapse[31968]: File ""/usr/local/lib/python3.7/site-packages/synapse/federation/sender/per_destination_queue.py"", line 368, in _get_device_update_edus
Mar 28 00:11:11 thor matrix-synapse[31968]: self._destination, last_device_list, limit=limit
Mar 28 00:11:11 thor matrix-synapse[31968]: File ""/usr/local/lib/python3.7/site-packages/twisted/internet/defer.py"", line 1416, in _inlineCallbacks
Mar 28 00:11:11 thor matrix-synapse[31968]: result = result.throwExceptionIntoGenerator(g)
Mar 28 00:11:11 thor matrix-synapse[31968]: File ""/usr/local/lib/python3.7/site-packages/twisted/python/failure.py"", line 512, in throwExceptionIntoGenerator
Mar 28 00:11:11 thor matrix-synapse[31968]: return g.throw(self.type, self.value, self.tb)
Mar 28 00:11:11 thor matrix-synapse[31968]: File ""/usr/local/lib/python3.7/site-packages/synapse/storage/data_stores/main/devices.py"", line 233, in get_device_updates_by_remote
Mar 28 00:11:11 thor matrix-synapse[31968]: destination, from_stream_id, query_map
Mar 28 00:11:11 thor matrix-synapse[31968]: File ""/usr/local/lib/python3.7/site-packages/twisted/internet/defer.py"", line 1418, in _inlineCallbacks
Mar 28 00:11:11 thor matrix-synapse[31968]: result = g.send(result)
Mar 28 00:11:11 thor matrix-synapse[31968]: File ""/usr/local/lib/python3.7/site-packages/synapse/storage/data_stores/main/devices.py"", line 325, in _get_device_update_edus_by_remote
Mar 28 00:11:11 thor matrix-synapse[31968]: result[""keys""].setdefault(""signatures"", {}).setdefault(
Mar 28 00:11:11 thor matrix-synapse[31968]: KeyError: 'keys'
```
My db state was this:
```
synapse=# select * from devices where user_id ='@tom:lant.uk' and hidden = False;
user_id | device_id | display_name | last_seen | ip | user_agent | hidden
--------------+------------------+-------------------------------+---------------+----------------+-----------------------------------------------------------------------------------------------------------------------------------------------------------------+--------
@tom:lant.uk | Mautrix-Facebook | Generic Matrix Client · Linux | 1585351781327 | - | Python/3.8 aiohttp/3.6.2 | f
@tom:lant.uk | ABICGMVRNF | Riot · Desktop · macOS | 1584985239789 | XXXXXXXX | Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_6) AppleWebKit/537.36 (KHTML, like Gecko) RiotNightly/2020032301 Chrome/80.0.3987.134 Electron/8.0.3 Safari/537.36 | f
@tom:lant.uk | HWVQMHGYDM | Riot · Firefox · macOS | 1585351825192 | XXXXXXXXX | Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:76.0) Gecko/20100101 Firefox/76.0 | f
@tom:lant.uk | EYDLDOKXIK | | | | | f
@tom:lant.uk | BKOEIBIDJW | Mobile | 1585349903283 | XXXXXXXX | Riot.im/0.9.9-dev (Linux; U; Android 9; CLT-L09 Build/HUAWEICLT-L0; Flavour GooglePlay; MatrixAndroidSDK 0.9.31-dev) | f
(5 rows)
synapse=# select * from e2e_device_keys_json where user_id = '@tom:lant.uk';;
user_id | device_id | ts_added_ms | key_json
--------------+------------+---------------+--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
@tom:lant.uk | ABICGMVRNF | 1584632687735 | {""algorithms"":[""m.olm.v1.curve25519-aes-sha2"",""m.megolm.v1.aes-sha2""],""device_id"":""ABICGMVRNF"",""keys"":{LIST_OF_KEYS},""signatures"":{""@tom:lant.uk"":{SIGNATURE_STUFF}},""user_id"":""@tom:lant.uk""}
@tom:lant.uk | HWVQMHGYDM | 1584973633940 | {""algorithms"":[""m.olm.v1.curve25519-aes-sha2"",""m.megolm.v1.aes-sha2""],""device_id"":""HWVQMHGYDM"",""keys"":{LIST_OF_KEYS},""signatures"":{""@tom:lant.uk"":{SIGNATURE_STUFF}},""user_id"":""@tom:lant.uk""}
(2 rows)
```
I guess the stuff in e2e_device_keys_json _isn't_ sensitive but have redacted anyway. I have a copy if it's useful.",
1125,https://api.github.com/repos/matrix-org/synapse/issues/7162,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7162/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7162/comments,https://api.github.com/repos/matrix-org/synapse/issues/7162/events,https://github.com/matrix-org/synapse/issues/7162,589304661,MDU6SXNzdWU1ODkzMDQ2NjE=,7162,"Make interactions with external users (Invite, Rooms) more recognizable","{'login': 'lxp', 'id': 484626, 'node_id': 'MDQ6VXNlcjQ4NDYyNg==', 'avatar_url': 'https://avatars2.githubusercontent.com/u/484626?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/lxp', 'html_url': 'https://github.com/lxp', 'followers_url': 'https://api.github.com/users/lxp/followers', 'following_url': 'https://api.github.com/users/lxp/following{/other_user}', 'gists_url': 'https://api.github.com/users/lxp/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/lxp/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/lxp/subscriptions', 'organizations_url': 'https://api.github.com/users/lxp/orgs', 'repos_url': 'https://api.github.com/users/lxp/repos', 'events_url': 'https://api.github.com/users/lxp/events{/privacy}', 'received_events_url': 'https://api.github.com/users/lxp/received_events', 'type': 'User', 'site_admin': False}","[{'id': 477045123, 'node_id': 'MDU6TGFiZWw0NzcwNDUxMjM=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/federation', 'name': 'federation', 'color': 'ededed', 'default': False, 'description': None}]",closed,False,,[],,1,2020-03-27T17:54:22Z,2020-04-06T20:22:53Z,2020-04-06T20:22:52Z,NONE,,,"### Problem
We currently have a closed community homeserver with federation disabled and we want to switch to an open federation policy. However, we are concerned that our users might fall for spear phishing attacks. For example, an attacker might start a direct chat to one of our users, using the same username, display name and profile picture as one of our users. Of course, the user would see an invite dialog, but if the attacker's domain is closely related to our domain a user could easily mistake it for an legitimate request. Once the direct chat is started, it is very hard to even notice the difference from a legitimate user.
### Goal
Our goal would be to make it as prominent as possible, that an invite is from an external user or you are talking in a room with external users. We thought that a good option would be to prefix all external display names and rooms with external users with `[EXT]`. We could also possibly modify the profile picture.
### Implementation Idea 1
We consider using Synapse's third party rules to modify incoming room events like `m.room.name` and `m.room.member`. Our homeserver would then store and deliver those modified events to the clients.
**Questions**
I know that the approach is not the cleanest, but are you seeing any serious problems that this might cause or might cause in the future?
Do you have any other implementation ideas to achieve the goal?
After a discussion [1] on #synapse:matrix.org, the following alternative implementation ideas came up:
### Implementation Idea 2
As modifying incoming federation events seems not to be possible, another solution would be to modify the events only in the client API.
**Questions**
If a pull request would exist for this, is it an acceptable solution that would be merged into Synapse?
If not, do you see any other solution for this, other than maintaining our own Synapse fork?
### Implementation Idea 3
Only handle everything on the clients. However, every client would have to support this feature.
**Questions**
If an administrator would want to manage this feature centrally. Does it require Matrix specification changes?
### Implementation Idea 4
Implement a bot that warns the user on external invites. However, this warning would not be permanently visible.
### [1] Discussion on #synapse:matrix.org
> tulir: it would be extremely hacky, since you obviously can't modify the actual events, you'd have to patch only the part where the events are returned on the client api
mikr: Coming from an enterprise-environment that think this is paramount to email - something like that would probably be very usefull
cos: That should probably be a client feature. I agree it would be useful.
s7evink: That's what i wanted to say. Probably more of a client feature
mikr: I can't really disagree with you, but it would mean adding support for it to all clients - I'm not sure how that would work with matrix, does all clients have to adhere to a spesific display-spec?
mikr: it's easy to think this should be handled on a server-level, as most email-solutions I have seen simply rewrite the subject-field in an email - that's universal to clients
lxp: I agree with mikr . It would be hard to have support in all clients for it. That is also why I was looking for a server-side solution.
cos: On server side it could be a bot that would join the chat and warn ""User foo:bar is an external"" or something.. I think that would be possible to do without major changes.
tulir: that would be visible for the other user though
cos: ..or perhaps the bot just open a new private chat to the user
lxp: that's a good idea. it might be easier to implement. however, i am somehow looking for a more permanent warning.
lxp: and i think it would be a lot better, if we could warn the user before he accepts the invitation.
cos: some kind of pre-invite hook for synapse would be useful.. it could also be used to auto-accept messages from friends & auto-reject spammers. ther has been some discussion about it alrady.
cos: in this situation it could just add some kind of warning text to the invite
tulir: preventing invites is already possible, adding a warning text wouldn't be possible with any kind of pre-invite hook
tulir: modifying the client api responses might be the best way (other than modifying clients) even though it's really hacky",
1126,https://api.github.com/repos/matrix-org/synapse/issues/7161,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7161/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7161/comments,https://api.github.com/repos/matrix-org/synapse/issues/7161/events,https://github.com/matrix-org/synapse/pull/7161,589135232,MDExOlB1bGxSZXF1ZXN0Mzk0NzU1MTM1,7161,Attempt to clarify Python version requirements,"{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,1,2020-03-27T13:30:41Z,2020-03-30T12:55:03Z,2020-03-30T12:55:02Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7161', 'html_url': 'https://github.com/matrix-org/synapse/pull/7161', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7161.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7161.patch'}","In particular, we depend on `typing.TYPE_CHECKING`, which is only present in
3.5.2.
It turns out that Ubuntu Xenial, despite having a package called `python 3
(3.5.1-3)`, actually has python 3.5.2, so I think this is fine.",
1127,https://api.github.com/repos/matrix-org/synapse/issues/7160,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7160/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7160/comments,https://api.github.com/repos/matrix-org/synapse/issues/7160/events,https://github.com/matrix-org/synapse/pull/7160,589101010,MDExOlB1bGxSZXF1ZXN0Mzk0NzI2NzY2,7160,Always send the user updates to their own device list,"{'login': 'dbkr', 'id': 986903, 'node_id': 'MDQ6VXNlcjk4NjkwMw==', 'avatar_url': 'https://avatars1.githubusercontent.com/u/986903?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/dbkr', 'html_url': 'https://github.com/dbkr', 'followers_url': 'https://api.github.com/users/dbkr/followers', 'following_url': 'https://api.github.com/users/dbkr/following{/other_user}', 'gists_url': 'https://api.github.com/users/dbkr/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/dbkr/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/dbkr/subscriptions', 'organizations_url': 'https://api.github.com/users/dbkr/orgs', 'repos_url': 'https://api.github.com/users/dbkr/repos', 'events_url': 'https://api.github.com/users/dbkr/events{/privacy}', 'received_events_url': 'https://api.github.com/users/dbkr/received_events', 'type': 'User', 'site_admin': False}","[{'id': 1631939447, 'node_id': 'MDU6TGFiZWwxNjMxOTM5NDQ3', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/cross-signing-sprint', 'name': 'cross-signing-sprint', 'color': '730adb', 'default': False, 'description': ''}, {'id': 1581464420, 'node_id': 'MDU6TGFiZWwxNTgxNDY0NDIw', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/phase:3', 'name': 'phase:3', 'color': 'c5e567', 'default': False, 'description': ''}, {'id': 1709952128, 'node_id': 'MDU6TGFiZWwxNzA5OTUyMTI4', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/story:1', 'name': 'story:1', 'color': 'b4f291', 'default': False, 'description': 'As a user I want to cross-sign my own devices'}]",closed,False,,[],,2,2020-03-27T12:30:22Z,2020-04-22T13:31:06Z,2020-03-30T13:34:28Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7160', 'html_url': 'https://github.com/matrix-org/synapse/pull/7160', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7160.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7160.patch'}","This will allow clients to notify users about new devices even if
the user isn't in any rooms (yet).",
1128,https://api.github.com/repos/matrix-org/synapse/issues/7159,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7159/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7159/comments,https://api.github.com/repos/matrix-org/synapse/issues/7159/events,https://github.com/matrix-org/synapse/pull/7159,589084534,MDExOlB1bGxSZXF1ZXN0Mzk0NzEzNDE3,7159,Rewrite prune_old_outbound_device_pokes for efficiency,"{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,0,2020-03-27T11:59:49Z,2020-03-30T18:06:54Z,2020-03-30T18:06:53Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7159', 'html_url': 'https://github.com/matrix-org/synapse/pull/7159', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7159.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7159.patch'}","* make sure we clear out all but one update for the user
* ~~there is no need to delete from `device_lists_outbound_last_success`: sticking with the last successful stream id is fine.~~
Based on #7157.",
1129,https://api.github.com/repos/matrix-org/synapse/issues/7158,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7158/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7158/comments,https://api.github.com/repos/matrix-org/synapse/issues/7158/events,https://github.com/matrix-org/synapse/pull/7158,589082905,MDExOlB1bGxSZXF1ZXN0Mzk0NzEyMDU3,7158,Fix device list update stream ids going backward,"{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,"{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}","[{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}]",,0,2020-03-27T11:57:01Z,2020-04-03T09:40:24Z,2020-04-03T09:40:22Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7158', 'html_url': 'https://github.com/matrix-org/synapse/pull/7158', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7158.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7158.patch'}","Occasionally we could get a federation device list update transaction which looked like:
```
[
{'edu_type': 'm.device_list_update', 'content': {'user_id': '@user:test', 'device_id': 'D2', 'prev_id': [], 'stream_id': 12, 'deleted': True}},
{'edu_type': 'm.device_list_update', 'content': {'user_id': '@user:test', 'device_id': 'D1', 'prev_id': [12], 'stream_id': 11, 'deleted': True}},
{'edu_type': 'm.device_list_update', 'content': {'user_id': '@user:test', 'device_id': 'D3', 'prev_id': [11], 'stream_id': 13, 'deleted': True}}
]
```
Having `stream_ids` which are lower than `prev_ids` looks odd. It might work (I'm not actually sure), but in any case it doesn't seem like a reasonable thing to expect other implementations to support.
~~Based on #7157.~~",
1130,https://api.github.com/repos/matrix-org/synapse/issues/7157,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7157/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7157/comments,https://api.github.com/repos/matrix-org/synapse/issues/7157/events,https://github.com/matrix-org/synapse/pull/7157,589081020,MDExOlB1bGxSZXF1ZXN0Mzk0NzEwNDk5,7157,Add tests for outbound device pokes,"{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,0,2020-03-27T11:53:20Z,2020-03-30T12:59:09Z,2020-03-30T12:59:08Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7157', 'html_url': 'https://github.com/matrix-org/synapse/pull/7157', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7157.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7157.patch'}","This starts with a change to remove the somewhat spurious ""name"" parameter to `default_config`. It's a separate commit to help with review.",
1131,https://api.github.com/repos/matrix-org/synapse/issues/7156,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7156/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7156/comments,https://api.github.com/repos/matrix-org/synapse/issues/7156/events,https://github.com/matrix-org/synapse/issues/7156,588951761,MDU6SXNzdWU1ODg5NTE3NjE=,7156,State groups relation schema,"{'login': 'sargon', 'id': 178904, 'node_id': 'MDQ6VXNlcjE3ODkwNA==', 'avatar_url': 'https://avatars2.githubusercontent.com/u/178904?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sargon', 'html_url': 'https://github.com/sargon', 'followers_url': 'https://api.github.com/users/sargon/followers', 'following_url': 'https://api.github.com/users/sargon/following{/other_user}', 'gists_url': 'https://api.github.com/users/sargon/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/sargon/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/sargon/subscriptions', 'organizations_url': 'https://api.github.com/users/sargon/orgs', 'repos_url': 'https://api.github.com/users/sargon/repos', 'events_url': 'https://api.github.com/users/sargon/events{/privacy}', 'received_events_url': 'https://api.github.com/users/sargon/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,8,2020-03-27T07:52:13Z,2020-05-12T14:30:43Z,2020-04-07T21:55:34Z,CONTRIBUTOR,,,"We have several Homeservers whose state_groups_state table is filling up the database server. One of the servers I take care of has reached ~180GB in table size, see below
```
public | state_events | table | ttt_matrix | 165 MB |
public | state_group_edges | table | ttt_matrix | 77 MB |
public | state_groups | table | ttt_matrix | 80 MB |
public | state_groups_state | table | ttt_matrix | 182 GB |
```
That size has nearly doubled since I last reported the size in #3364. To my knowledge there have been bugs contributing to this growth, e.g. #6566.
So to the question in need: Can someone of the core devteam please provide a relational schema or point me to the correct documentation, if I am blind, of the state tables. So I can forge/propose a query to cleanup the mess - even if we have to turn off the homeserver during that operation, but we have to get rid of this garbage data - sooner or later.",
1132,https://api.github.com/repos/matrix-org/synapse/issues/7155,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7155/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7155/comments,https://api.github.com/repos/matrix-org/synapse/issues/7155/events,https://github.com/matrix-org/synapse/pull/7155,588824915,MDExOlB1bGxSZXF1ZXN0Mzk0NTAyNjY0,7155,Only import sqlite3 when type checking,"{'login': 'auscompgeek', 'id': 128854, 'node_id': 'MDQ6VXNlcjEyODg1NA==', 'avatar_url': 'https://avatars2.githubusercontent.com/u/128854?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/auscompgeek', 'html_url': 'https://github.com/auscompgeek', 'followers_url': 'https://api.github.com/users/auscompgeek/followers', 'following_url': 'https://api.github.com/users/auscompgeek/following{/other_user}', 'gists_url': 'https://api.github.com/users/auscompgeek/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/auscompgeek/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/auscompgeek/subscriptions', 'organizations_url': 'https://api.github.com/users/auscompgeek/orgs', 'repos_url': 'https://api.github.com/users/auscompgeek/repos', 'events_url': 'https://api.github.com/users/auscompgeek/events{/privacy}', 'received_events_url': 'https://api.github.com/users/auscompgeek/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,0,2020-03-27T01:29:52Z,2020-03-30T09:03:52Z,2020-03-27T13:20:01Z,CONTRIBUTOR,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7155', 'html_url': 'https://github.com/matrix-org/synapse/pull/7155', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7155.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7155.patch'}","Fixes: #7127
Signed-off-by: David Vo ",
1133,https://api.github.com/repos/matrix-org/synapse/issues/7154,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7154/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7154/comments,https://api.github.com/repos/matrix-org/synapse/issues/7154/events,https://github.com/matrix-org/synapse/issues/7154,588680404,MDU6SXNzdWU1ODg2ODA0MDQ=,7154,Synapse is hammering the database with user directory updates,"{'login': 'turt2live', 'id': 1190097, 'node_id': 'MDQ6VXNlcjExOTAwOTc=', 'avatar_url': 'https://avatars2.githubusercontent.com/u/1190097?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/turt2live', 'html_url': 'https://github.com/turt2live', 'followers_url': 'https://api.github.com/users/turt2live/followers', 'following_url': 'https://api.github.com/users/turt2live/following{/other_user}', 'gists_url': 'https://api.github.com/users/turt2live/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/turt2live/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/turt2live/subscriptions', 'organizations_url': 'https://api.github.com/users/turt2live/orgs', 'repos_url': 'https://api.github.com/users/turt2live/repos', 'events_url': 'https://api.github.com/users/turt2live/events{/privacy}', 'received_events_url': 'https://api.github.com/users/turt2live/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,8,2020-03-26T19:43:25Z,2020-03-31T15:14:45Z,2020-03-31T15:14:45Z,MEMBER,,,"After upgrading from 1.11.0 to 1.12.0 the following is appearing quite a lot in the logs:
```
homeserver_1 - 2020-03-26 20:41:32,656 - synapse.storage.database - 418 - WARNING - user_directory.notify_new_event-1077 - [TXN OPERROR] {update_user_directory_stream_pos-27fe} could not serialize access due to concurrent update
homeserver_1 - 2020-03-26 20:41:32,659 - synapse.storage.database - 418 - WARNING - user_directory.notify_new_event-1077 - [TXN OPERROR] {update_user_directory_stream_pos-27fe} could not serialize access due to concurrent update
homeserver_1 - 2020-03-26 20:41:32,664 - synapse.storage.database - 418 - WARNING - user_directory.notify_new_event-1077 - [TXN OPERROR] {update_user_directory_stream_pos-27fe} could not serialize access due to concurrent update
homeserver_1 - 2020-03-26 20:41:47,025 - synapse.storage.database - 418 - WARNING - user_directory.notify_new_event-1149 - [TXN OPERROR] {update_user_directory_stream_pos-29ed} could not serialize access due to concurrent update
homeserver_1 - 2020-03-26 20:41:47,576 - synapse.storage.database - 418 - WARNING - user_directory.notify_new_event-1154 - [TXN OPERROR] {update_user_directory_stream_pos-2a33} could not serialize access due to concurrent update
homeserver_1 - 2020-03-26 20:41:47,579 - synapse.storage.database - 418 - WARNING - user_directory.notify_new_event-1154 - [TXN OPERROR] {update_user_directory_stream_pos-2a33} could not serialize access due to concurrent update
homeserver_1 - 2020-03-26 20:41:52,060 - synapse.storage.database - 418 - WARNING - user_directory.notify_new_event-1163 - [TXN OPERROR] {update_user_directory_stream_pos-2a81} could not serialize access due to concurrent update
homeserver_1 - 2020-03-26 20:41:52,078 - synapse.storage.database - 418 - WARNING - user_directory.notify_new_event-1163 - [TXN OPERROR] {update_user_directory_stream_pos-2a81} could not serialize access due to concurrent update
homeserver_1 - 2020-03-26 20:41:52,093 - synapse.storage.database - 418 - WARNING - user_directory.notify_new_event-1163 - [TXN OPERROR] {update_user_directory_stream_pos-2a81} could not serialize access due to concurrent update
homeserver_1 - 2020-03-26 20:41:52,122 - synapse.storage.database - 418 - WARNING - user_directory.notify_new_event-1163 - [TXN OPERROR] {update_user_directory_stream_pos-2a81} could not serialize access due to concurrent update
homeserver_1 - 2020-03-26 20:41:52,166 - synapse.storage.database - 418 - WARNING - user_directory.notify_new_event-1163 - [TXN OPERROR] {update_user_directory_stream_pos-2a81} could not serialize access due to concurrent update
homeserver_1 - 2020-03-26 20:41:52,187 - synapse.storage.database - 418 - WARNING - user_directory.notify_new_event-1163 - [TXN OPERROR] {update_user_directory_stream_pos-2a81} could not serialize access due to concurrent update
homeserver_1 - 2020-03-26 20:41:52,190 - synapse.metrics.background_process_metrics - 215 - ERROR - user_directory.notify_new_event-1163 - Background process 'user_directory.notify_new_event' threw an exception
File ""/home/synapse/.synapse-py3/lib/python3.6/site-packages/synapse/handlers/user_directory.py"", line 109, in process
File ""/home/synapse/.synapse-py3/lib/python3.6/site-packages/synapse/handlers/user_directory.py"", line 172, in _unsafe_process
yield self.store.update_user_directory_stream_pos(max_pos)
```
The database is showing at least 5x the amount of rejected updates, which appear to be coming from all the workers. ~~The user directory is disabled on this server.~~ It was supposed to be disabled, but the wrong option was set. See comments.",
1134,https://api.github.com/repos/matrix-org/synapse/issues/7153,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7153/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7153/comments,https://api.github.com/repos/matrix-org/synapse/issues/7153/events,https://github.com/matrix-org/synapse/pull/7153,588618815,MDExOlB1bGxSZXF1ZXN0Mzk0MzMxOTYw,7153,Always whitelist the login fallback for SSO,"{'login': 'babolivier', 'id': 5547783, 'node_id': 'MDQ6VXNlcjU1NDc3ODM=', 'avatar_url': 'https://avatars3.githubusercontent.com/u/5547783?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/babolivier', 'html_url': 'https://github.com/babolivier', 'followers_url': 'https://api.github.com/users/babolivier/followers', 'following_url': 'https://api.github.com/users/babolivier/following{/other_user}', 'gists_url': 'https://api.github.com/users/babolivier/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/babolivier/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/babolivier/subscriptions', 'organizations_url': 'https://api.github.com/users/babolivier/orgs', 'repos_url': 'https://api.github.com/users/babolivier/repos', 'events_url': 'https://api.github.com/users/babolivier/events{/privacy}', 'received_events_url': 'https://api.github.com/users/babolivier/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,2,2020-03-26T18:03:48Z,2020-03-27T21:52:06Z,2020-03-27T14:34:42Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7153', 'html_url': 'https://github.com/matrix-org/synapse/pull/7153', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7153.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7153.patch'}","That fallback sets the redirect URL to itself (so it can process the login token then return gracefully to the client). This would make it pointless to ask the user for confirmation, since the URL the confirmation page would be showing wouldn't be the client's.",
1135,https://api.github.com/repos/matrix-org/synapse/issues/7152,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7152/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7152/comments,https://api.github.com/repos/matrix-org/synapse/issues/7152/events,https://github.com/matrix-org/synapse/pull/7152,588600330,MDExOlB1bGxSZXF1ZXN0Mzk0MzE2NjQz,7152,Improve the UX of the login fallback when using SSO,"{'login': 'babolivier', 'id': 5547783, 'node_id': 'MDQ6VXNlcjU1NDc3ODM=', 'avatar_url': 'https://avatars3.githubusercontent.com/u/5547783?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/babolivier', 'html_url': 'https://github.com/babolivier', 'followers_url': 'https://api.github.com/users/babolivier/followers', 'following_url': 'https://api.github.com/users/babolivier/following{/other_user}', 'gists_url': 'https://api.github.com/users/babolivier/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/babolivier/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/babolivier/subscriptions', 'organizations_url': 'https://api.github.com/users/babolivier/orgs', 'repos_url': 'https://api.github.com/users/babolivier/repos', 'events_url': 'https://api.github.com/users/babolivier/events{/privacy}', 'received_events_url': 'https://api.github.com/users/babolivier/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,2,2020-03-26T17:35:20Z,2020-03-27T21:52:42Z,2020-03-27T14:44:14Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7152', 'html_url': 'https://github.com/matrix-org/synapse/pull/7152', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7152.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7152.patch'}","* Don't show the login forms if we're currently logging in with a
password or a token.
* Submit directly the SSO login form, showing only a spinner to the
user, in order to eliminate from the clunkiness of SSO through this
fallback.",
1136,https://api.github.com/repos/matrix-org/synapse/issues/7151,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7151/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7151/comments,https://api.github.com/repos/matrix-org/synapse/issues/7151/events,https://github.com/matrix-org/synapse/pull/7151,588580211,MDExOlB1bGxSZXF1ZXN0Mzk0MzAwNTUw,7151,Allow RedirectResponse in SAML response handler,"{'login': 'jaywink', 'id': 1174866, 'node_id': 'MDQ6VXNlcjExNzQ4NjY=', 'avatar_url': 'https://avatars0.githubusercontent.com/u/1174866?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/jaywink', 'html_url': 'https://github.com/jaywink', 'followers_url': 'https://api.github.com/users/jaywink/followers', 'following_url': 'https://api.github.com/users/jaywink/following{/other_user}', 'gists_url': 'https://api.github.com/users/jaywink/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/jaywink/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/jaywink/subscriptions', 'organizations_url': 'https://api.github.com/users/jaywink/orgs', 'repos_url': 'https://api.github.com/users/jaywink/repos', 'events_url': 'https://api.github.com/users/jaywink/events{/privacy}', 'received_events_url': 'https://api.github.com/users/jaywink/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,2,2020-03-26T17:06:26Z,2020-03-26T20:10:33Z,2020-03-26T20:10:32Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7151', 'html_url': 'https://github.com/matrix-org/synapse/pull/7151', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7151.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7151.patch'}","Allow custom SAML handlers to redirect after processing an auth response.
Fixes #7149
Signed-off-by: Jason Robinson
",
1137,https://api.github.com/repos/matrix-org/synapse/issues/7150,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7150/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7150/comments,https://api.github.com/repos/matrix-org/synapse/issues/7150/events,https://github.com/matrix-org/synapse/pull/7150,588512596,MDExOlB1bGxSZXF1ZXN0Mzk0MjQ1MDY1,7150,Ensure is_verified on /_matrix/client/r0/room_keys/keys is a boolean,"{'login': 'anoadragon453', 'id': 1342360, 'node_id': 'MDQ6VXNlcjEzNDIzNjA=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1342360?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/anoadragon453', 'html_url': 'https://github.com/anoadragon453', 'followers_url': 'https://api.github.com/users/anoadragon453/followers', 'following_url': 'https://api.github.com/users/anoadragon453/following{/other_user}', 'gists_url': 'https://api.github.com/users/anoadragon453/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/anoadragon453/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/anoadragon453/subscriptions', 'organizations_url': 'https://api.github.com/users/anoadragon453/orgs', 'repos_url': 'https://api.github.com/users/anoadragon453/repos', 'events_url': 'https://api.github.com/users/anoadragon453/events{/privacy}', 'received_events_url': 'https://api.github.com/users/anoadragon453/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,2,2020-03-26T15:33:32Z,2020-03-27T13:30:24Z,2020-03-27T13:30:23Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7150', 'html_url': 'https://github.com/matrix-org/synapse/pull/7150', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7150.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7150.patch'}","Fixes: https://github.com/matrix-org/synapse/issues/6977
Also tells the user whether they're missing the `version` query parameter instead of 500'ing (this confused me for a bit while testing).
I'm not sure how [this sytest](https://github.com/matrix-org/sytest/blob/aee12f9414e5b36cba569e3ca0220e8e2f995329/tests/41end-to-end-keys/07-backup.pl#L225) didn't catch this initially though.",
1138,https://api.github.com/repos/matrix-org/synapse/issues/7149,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7149/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7149/comments,https://api.github.com/repos/matrix-org/synapse/issues/7149/events,https://github.com/matrix-org/synapse/issues/7149,588419030,MDU6SXNzdWU1ODg0MTkwMzA=,7149,SAML login fails since v1.12.0 if custom SAML module raises a RedirectException,"{'login': 'jaywink', 'id': 1174866, 'node_id': 'MDQ6VXNlcjExNzQ4NjY=', 'avatar_url': 'https://avatars0.githubusercontent.com/u/1174866?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/jaywink', 'html_url': 'https://github.com/jaywink', 'followers_url': 'https://api.github.com/users/jaywink/followers', 'following_url': 'https://api.github.com/users/jaywink/following{/other_user}', 'gists_url': 'https://api.github.com/users/jaywink/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/jaywink/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/jaywink/subscriptions', 'organizations_url': 'https://api.github.com/users/jaywink/orgs', 'repos_url': 'https://api.github.com/users/jaywink/repos', 'events_url': 'https://api.github.com/users/jaywink/events{/privacy}', 'received_events_url': 'https://api.github.com/users/jaywink/received_events', 'type': 'User', 'site_admin': False}","[{'id': 121086029, 'node_id': 'MDU6TGFiZWwxMjEwODYwMjk=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/bug', 'name': 'bug', 'color': 'fc2929', 'default': True, 'description': None}, {'id': 1793931943, 'node_id': 'MDU6TGFiZWwxNzkzOTMxOTQz', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/mozilla', 'name': 'mozilla', 'color': 'db1c1f', 'default': False, 'description': 'Mozilla feedback'}]",closed,False,"{'login': 'jaywink', 'id': 1174866, 'node_id': 'MDQ6VXNlcjExNzQ4NjY=', 'avatar_url': 'https://avatars0.githubusercontent.com/u/1174866?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/jaywink', 'html_url': 'https://github.com/jaywink', 'followers_url': 'https://api.github.com/users/jaywink/followers', 'following_url': 'https://api.github.com/users/jaywink/following{/other_user}', 'gists_url': 'https://api.github.com/users/jaywink/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/jaywink/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/jaywink/subscriptions', 'organizations_url': 'https://api.github.com/users/jaywink/orgs', 'repos_url': 'https://api.github.com/users/jaywink/repos', 'events_url': 'https://api.github.com/users/jaywink/events{/privacy}', 'received_events_url': 'https://api.github.com/users/jaywink/received_events', 'type': 'User', 'site_admin': False}","[{'login': 'jaywink', 'id': 1174866, 'node_id': 'MDQ6VXNlcjExNzQ4NjY=', 'avatar_url': 'https://avatars0.githubusercontent.com/u/1174866?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/jaywink', 'html_url': 'https://github.com/jaywink', 'followers_url': 'https://api.github.com/users/jaywink/followers', 'following_url': 'https://api.github.com/users/jaywink/following{/other_user}', 'gists_url': 'https://api.github.com/users/jaywink/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/jaywink/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/jaywink/subscriptions', 'organizations_url': 'https://api.github.com/users/jaywink/orgs', 'repos_url': 'https://api.github.com/users/jaywink/repos', 'events_url': 'https://api.github.com/users/jaywink/events{/privacy}', 'received_events_url': 'https://api.github.com/users/jaywink/received_events', 'type': 'User', 'site_admin': False}]",,2,2020-03-26T13:25:17Z,2020-03-26T20:13:18Z,2020-03-26T20:13:18Z,MEMBER,,,"### Description
Mozilla SAML module raises a RedirectException to redirect a new user to a username picker: https://github.com/matrix-org/matrix-synapse-saml-mozilla/blob/master/matrix_synapse_saml_mozilla/mapping_provider.py#L162
Since v1.12.0 Synapse is catching this and rendering an error page instead: https://github.com/matrix-org/synapse/pull/7058/files#diff-4a1427aad5021dc55886911e28d9c941R120
### Version information
Synapse v1.12.0
Matrix SYnapse SAML Mozilla v0.2.5",
1139,https://api.github.com/repos/matrix-org/synapse/issues/7148,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7148/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7148/comments,https://api.github.com/repos/matrix-org/synapse/issues/7148/events,https://github.com/matrix-org/synapse/issues/7148,588407321,MDU6SXNzdWU1ODg0MDczMjE=,7148,test failures with openssl 1.1.1e,"{'login': 'Bubu', 'id': 105185, 'node_id': 'MDQ6VXNlcjEwNTE4NQ==', 'avatar_url': 'https://avatars0.githubusercontent.com/u/105185?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Bubu', 'html_url': 'https://github.com/Bubu', 'followers_url': 'https://api.github.com/users/Bubu/followers', 'following_url': 'https://api.github.com/users/Bubu/following{/other_user}', 'gists_url': 'https://api.github.com/users/Bubu/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/Bubu/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/Bubu/subscriptions', 'organizations_url': 'https://api.github.com/users/Bubu/orgs', 'repos_url': 'https://api.github.com/users/Bubu/repos', 'events_url': 'https://api.github.com/users/Bubu/events{/privacy}', 'received_events_url': 'https://api.github.com/users/Bubu/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,14,2020-03-26T13:07:11Z,2020-04-01T18:21:07Z,2020-04-01T18:21:06Z,CONTRIBUTOR,,,"### Description
### Steps to reproduce
- run synapse 1.12.0 tests during archlinux packaging
- this runs `PYTHONPATH=. trial3 tests` after `python setup.py build`
- then I get the following 2 test failures
```
tests.test_visibility.FilterEventsForServerTestCase.test_large_room
===============================================================================
[FAIL]
Traceback (most recent call last):
File ""/home/bubu/build/community/matrix-synapse/repos/community-any/src/synapse-1.12.0/tests/http/federation/test_matrix_federation_agent.py"", line 411, in test_get_hostname_bad_cert
e = self.failureResultOf(test_d, ResponseNeverReceived)
File ""/usr/lib/python3.8/site-packages/twisted/trial/_synctest.py"", line 743, in failureResultOf
self.fail(
twisted.trial.unittest.FailTest: Failure result expected on , found no result instead
tests.http.federation.test_matrix_federation_agent.MatrixFederationAgentTests.test_get_hostname_bad_cert
===============================================================================
[FAIL]
Traceback (most recent call last):
File ""/home/bubu/build/community/matrix-synapse/repos/community-any/src/synapse-1.12.0/tests/http/federation/test_matrix_federation_agent.py"", line 442, in test_get_ip_address_bad_cert
e = self.failureResultOf(test_d, ResponseNeverReceived)
File ""/usr/lib/python3.8/site-packages/twisted/trial/_synctest.py"", line 743, in failureResultOf
self.fail(
twisted.trial.unittest.FailTest: Failure result expected on , found no result instead
tests.http.federation.test_matrix_federation_agent.MatrixFederationAgentTests.test_get_ip_address_bad_cert
-------------------------------------------------------------------------------
Ran 907 tests in 328.985s
```
Here's the PKGBUILD file, but this really isn't doing anything crazy.
https://git.archlinux.org/svntogit/community.git/tree/trunk/PKGBUILD?h=packages/matrix-synapse",
1140,https://api.github.com/repos/matrix-org/synapse/issues/7147,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7147/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7147/comments,https://api.github.com/repos/matrix-org/synapse/issues/7147/events,https://github.com/matrix-org/synapse/pull/7147,588393958,MDExOlB1bGxSZXF1ZXN0Mzk0MTQ3OTY2,7147,Add developer documentation for running a local CAS server,"{'login': 'clokep', 'id': 517124, 'node_id': 'MDQ6VXNlcjUxNzEyNA==', 'avatar_url': 'https://avatars2.githubusercontent.com/u/517124?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/clokep', 'html_url': 'https://github.com/clokep', 'followers_url': 'https://api.github.com/users/clokep/followers', 'following_url': 'https://api.github.com/users/clokep/following{/other_user}', 'gists_url': 'https://api.github.com/users/clokep/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/clokep/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/clokep/subscriptions', 'organizations_url': 'https://api.github.com/users/clokep/orgs', 'repos_url': 'https://api.github.com/users/clokep/repos', 'events_url': 'https://api.github.com/users/clokep/events{/privacy}', 'received_events_url': 'https://api.github.com/users/clokep/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,0,2020-03-26T12:45:03Z,2020-03-30T11:28:44Z,2020-03-30T11:28:42Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7147', 'html_url': 'https://github.com/matrix-org/synapse/pull/7147', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7147.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7147.patch'}","This adds some documentation about running a local CAS server and hooking Synapse up to it. The docs are based on [our SAML docs](https://github.com/matrix-org/synapse/blob/229eb81498b0fe1da81e9b5b333a0285acde9446/docs/dev/saml.md). CAS is more annoying than SAML since Synapse needs to directly talk to the CAS server, so you can't do a lot of the stuff that samling does.
This uses a pretty simple package I found. I also pushed a git repo that has everything configured (which simplifies the configuration a bit): https://github.com/clokep/cas-test -- not sure if it is worth pointing to that or not though.
Here's the [rendered version](https://github.com/matrix-org/synapse/blob/clokep/cas-docs/docs/dev/cas.md).
This also makes a tweak to our SAML docs to note another parameter that must be set.",
1141,https://api.github.com/repos/matrix-org/synapse/issues/7146,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7146/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7146/comments,https://api.github.com/repos/matrix-org/synapse/issues/7146/events,https://github.com/matrix-org/synapse/pull/7146,588355051,MDExOlB1bGxSZXF1ZXN0Mzk0MTE2NDIz,7146,Run replication streamers on workers,"{'login': 'erikjohnston', 'id': 8428120, 'node_id': 'MDQ6VXNlcjg0MjgxMjA=', 'avatar_url': 'https://avatars0.githubusercontent.com/u/8428120?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/erikjohnston', 'html_url': 'https://github.com/erikjohnston', 'followers_url': 'https://api.github.com/users/erikjohnston/followers', 'following_url': 'https://api.github.com/users/erikjohnston/following{/other_user}', 'gists_url': 'https://api.github.com/users/erikjohnston/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/erikjohnston/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/erikjohnston/subscriptions', 'organizations_url': 'https://api.github.com/users/erikjohnston/orgs', 'repos_url': 'https://api.github.com/users/erikjohnston/repos', 'events_url': 'https://api.github.com/users/erikjohnston/events{/privacy}', 'received_events_url': 'https://api.github.com/users/erikjohnston/received_events', 'type': 'User', 'site_admin': False}","[{'id': 2011569249, 'node_id': 'MDU6TGFiZWwyMDExNTY5MjQ5', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/operation%20gemini', 'name': 'operation gemini', 'color': '006b75', 'default': False, 'description': 'Part of the project to fix the cpu bottleneck on'}]",closed,False,,[],,1,2020-03-26T11:37:56Z,2020-05-07T10:18:46Z,2020-04-28T12:34:13Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7146', 'html_url': 'https://github.com/matrix-org/synapse/pull/7146', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7146.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7146.patch'}","Currently we never write to streams from workers, but that will change soon",
1142,https://api.github.com/repos/matrix-org/synapse/issues/7145,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7145/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7145/comments,https://api.github.com/repos/matrix-org/synapse/issues/7145/events,https://github.com/matrix-org/synapse/pull/7145,588296325,MDExOlB1bGxSZXF1ZXN0Mzk0MDY4OTY5,7145,Add an optional config flag to skip the SSO confirmation step,"{'login': 'babolivier', 'id': 5547783, 'node_id': 'MDQ6VXNlcjU1NDc3ODM=', 'avatar_url': 'https://avatars3.githubusercontent.com/u/5547783?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/babolivier', 'html_url': 'https://github.com/babolivier', 'followers_url': 'https://api.github.com/users/babolivier/followers', 'following_url': 'https://api.github.com/users/babolivier/following{/other_user}', 'gists_url': 'https://api.github.com/users/babolivier/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/babolivier/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/babolivier/subscriptions', 'organizations_url': 'https://api.github.com/users/babolivier/orgs', 'repos_url': 'https://api.github.com/users/babolivier/repos', 'events_url': 'https://api.github.com/users/babolivier/events{/privacy}', 'received_events_url': 'https://api.github.com/users/babolivier/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,1,2020-03-26T10:02:12Z,2020-03-26T14:03:09Z,2020-03-26T14:03:09Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7145', 'html_url': 'https://github.com/matrix-org/synapse/pull/7145', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7145.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7145.patch'}","In the case of an instance which SSO backend is quite restrictive, or doesn't allow e.g. ""passwordless"" email login, it makes the SSO login flow feel a bit clunky to have a confirmation step after a successful authentication.",
1143,https://api.github.com/repos/matrix-org/synapse/issues/7144,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7144/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7144/comments,https://api.github.com/repos/matrix-org/synapse/issues/7144/events,https://github.com/matrix-org/synapse/issues/7144,588103337,MDU6SXNzdWU1ODgxMDMzMzc=,7144,57/rooms_version_column_3.sql taking ages on upgrade,"{'login': 'turt2live', 'id': 1190097, 'node_id': 'MDQ6VXNlcjExOTAwOTc=', 'avatar_url': 'https://avatars2.githubusercontent.com/u/1190097?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/turt2live', 'html_url': 'https://github.com/turt2live', 'followers_url': 'https://api.github.com/users/turt2live/followers', 'following_url': 'https://api.github.com/users/turt2live/following{/other_user}', 'gists_url': 'https://api.github.com/users/turt2live/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/turt2live/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/turt2live/subscriptions', 'organizations_url': 'https://api.github.com/users/turt2live/orgs', 'repos_url': 'https://api.github.com/users/turt2live/repos', 'events_url': 'https://api.github.com/users/turt2live/events{/privacy}', 'received_events_url': 'https://api.github.com/users/turt2live/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,"{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}","[{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}]",,12,2020-03-26T02:11:27Z,2020-04-15T11:40:43Z,2020-04-15T11:40:43Z,MEMBER,,,"Currently my server is stuck on `Applying engine-specific schema 57/rooms_version_column_3.sql.postgres` and has been for about 30 minutes now. It's an unavoidable update, but would have been nice to know that there's a significant update to the database so I can expect that it'll be a while before the server starts up on its own.
It looks like this particular update is just a really expensive nested loop:
```
synapse=# select count(*) from rooms;
count
--------
528770
(1 row)
synapse=# select count(*) from rooms where room_version is null;
count
-------
4071
(1 row)
synapse=# explain UPDATE rooms SET room_version=(
SELECT COALESCE(json::json->'content'->>'room_version','1')
FROM state_events se INNER JOIN event_json ej USING (event_id)
WHERE se.room_id=rooms.room_id AND se.type='m.room.create' AND se.state_key=''
LIMIT 1
) WHERE rooms.room_version IS NULL;
QUERY PLAN
-------------------------------------------------------------------------------------------------------------------------------
Update on rooms (cost=0.00..7581986912.20 rows=4248 width=55)
-> Seq Scan on rooms (cost=0.00..7581986912.20 rows=4248 width=55)
Filter: (room_version IS NULL)
SubPlan 1
-> Limit (cost=0.70..1784833.81 rows=1 width=1107)
-> Nested Loop (cost=0.70..1784833.81 rows=1 width=1107)
-> Seq Scan on state_events se (cost=0.00..1784825.08 rows=1 width=35)
Filter: ((room_id = rooms.room_id) AND (type = 'm.room.create'::text) AND (state_key = ''::text))
-> Index Scan using event_json_event_id_key on event_json ej (cost=0.70..8.71 rows=1 width=1140)
Index Cond: (event_id = se.event_id)
(10 rows)
```
The other reason for mentioning large database updates would be to let admins run them ahead of time where possible, knowing that they're completely on their own and could ruin everything. This shouldn't be an advertised feature of bolding some text in the changelog though.",
1144,https://api.github.com/repos/matrix-org/synapse/issues/7143,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7143/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7143/comments,https://api.github.com/repos/matrix-org/synapse/issues/7143/events,https://github.com/matrix-org/synapse/pull/7143,587778204,MDExOlB1bGxSZXF1ZXN0MzkzNjUzOTEz,7143,Only import sqlite3 by default if running mypy checks,"{'login': 'anoadragon453', 'id': 1342360, 'node_id': 'MDQ6VXNlcjEzNDIzNjA=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1342360?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/anoadragon453', 'html_url': 'https://github.com/anoadragon453', 'followers_url': 'https://api.github.com/users/anoadragon453/followers', 'following_url': 'https://api.github.com/users/anoadragon453/following{/other_user}', 'gists_url': 'https://api.github.com/users/anoadragon453/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/anoadragon453/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/anoadragon453/subscriptions', 'organizations_url': 'https://api.github.com/users/anoadragon453/orgs', 'repos_url': 'https://api.github.com/users/anoadragon453/repos', 'events_url': 'https://api.github.com/users/anoadragon453/events{/privacy}', 'received_events_url': 'https://api.github.com/users/anoadragon453/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,1,2020-03-25T15:24:00Z,2020-03-25T15:59:50Z,2020-03-25T15:59:50Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7143', 'html_url': 'https://github.com/matrix-org/synapse/pull/7143', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7143.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7143.patch'}","Fixes https://github.com/matrix-org/synapse/issues/7127
Only import `sqlite3` for mypy checks, not by default, else python binaries built without sqlite3 will fail to start Synapse, even if they're using postgres.",
1145,https://api.github.com/repos/matrix-org/synapse/issues/7142,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7142/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7142/comments,https://api.github.com/repos/matrix-org/synapse/issues/7142/events,https://github.com/matrix-org/synapse/issues/7142,587772386,MDU6SXNzdWU1ODc3NzIzODY=,7142,uploading cross-signing keys causes remote homeservers to re-sync your device list,"{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}","[{'id': 477043173, 'node_id': 'MDU6TGFiZWw0NzcwNDMxNzM=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/p2', 'name': 'p2', 'color': 'fbca04', 'default': False, 'description': None}, {'id': 600557921, 'node_id': 'MDU6TGFiZWw2MDA1NTc5MjE=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/performance', 'name': 'performance', 'color': 'fef2c0', 'default': False, 'description': None}]",open,False,,[],,1,2020-03-25T15:16:03Z,2020-03-26T14:50:26Z,,MEMBER,,,"Uploading the cross-signing keys causes a discontinuity in the stream_id sequence, so next time there is a device update, all the servers that you share a room with will need to do a complete resync of your device list.
I think the issue is that the x-signing-key upload bumps the stream id, but doesn't cause a device update edu.",
1146,https://api.github.com/repos/matrix-org/synapse/issues/7141,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7141/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7141/comments,https://api.github.com/repos/matrix-org/synapse/issues/7141/events,https://github.com/matrix-org/synapse/pull/7141,587633314,MDExOlB1bGxSZXF1ZXN0MzkzNTM2OTU2,7141,Various cleanups to INSTALL.md,"{'login': 'anoadragon453', 'id': 1342360, 'node_id': 'MDQ6VXNlcjEzNDIzNjA=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1342360?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/anoadragon453', 'html_url': 'https://github.com/anoadragon453', 'followers_url': 'https://api.github.com/users/anoadragon453/followers', 'following_url': 'https://api.github.com/users/anoadragon453/following{/other_user}', 'gists_url': 'https://api.github.com/users/anoadragon453/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/anoadragon453/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/anoadragon453/subscriptions', 'organizations_url': 'https://api.github.com/users/anoadragon453/orgs', 'repos_url': 'https://api.github.com/users/anoadragon453/repos', 'events_url': 'https://api.github.com/users/anoadragon453/events{/privacy}', 'received_events_url': 'https://api.github.com/users/anoadragon453/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,0,2020-03-25T11:36:17Z,2020-03-25T13:56:42Z,2020-03-25T13:56:41Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7141', 'html_url': 'https://github.com/matrix-org/synapse/pull/7141', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7141.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7141.patch'}","* complete markdownifying
* Home Server -> homeserver
* python2 -> python3
* Remove old/unnecessary troubleshooting guidelines",
1147,https://api.github.com/repos/matrix-org/synapse/issues/7140,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7140/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7140/comments,https://api.github.com/repos/matrix-org/synapse/issues/7140/events,https://github.com/matrix-org/synapse/issues/7140,587577842,MDU6SXNzdWU1ODc1Nzc4NDI=,7140,Documentation for media_storage_providers,"{'login': 'djschilling', 'id': 3503166, 'node_id': 'MDQ6VXNlcjM1MDMxNjY=', 'avatar_url': 'https://avatars0.githubusercontent.com/u/3503166?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/djschilling', 'html_url': 'https://github.com/djschilling', 'followers_url': 'https://api.github.com/users/djschilling/followers', 'following_url': 'https://api.github.com/users/djschilling/following{/other_user}', 'gists_url': 'https://api.github.com/users/djschilling/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/djschilling/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/djschilling/subscriptions', 'organizations_url': 'https://api.github.com/users/djschilling/orgs', 'repos_url': 'https://api.github.com/users/djschilling/repos', 'events_url': 'https://api.github.com/users/djschilling/events{/privacy}', 'received_events_url': 'https://api.github.com/users/djschilling/received_events', 'type': 'User', 'site_admin': False}","[{'id': 845245048, 'node_id': 'MDU6TGFiZWw4NDUyNDUwNDg=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/docs', 'name': 'docs', 'color': '0e8a16', 'default': False, 'description': ''}, {'id': 121086032, 'node_id': 'MDU6TGFiZWwxMjEwODYwMzI=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/help%20wanted', 'name': 'help wanted', 'color': '159818', 'default': True, 'description': None}, {'id': 477045806, 'node_id': 'MDU6TGFiZWw0NzcwNDU4MDY=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/media-repository', 'name': 'media-repository', 'color': 'ededed', 'default': False, 'description': None}]",open,False,,[],,8,2020-03-25T10:01:14Z,2020-08-04T14:36:24Z,,NONE,,,"I want to use the `s3_storage_provider.S3StorageProviderBackend`.
I configured it and when images are send over my synapse server they are also stored in the s3 bucket.
Here is how i configured it:
```
media_storage_providers:
- module: s3_storage_provider.S3StorageProviderBackend
store_local: False
store_remote: True
store_synchronous: True
config:
bucket: synapse1
endpoint_url: $HIDDEN_ENDPOINT
access_key_id: $HIDDEN_KEY
secret_access_key: $HIDDEN_KEY
```
But the images are still also stored locally on disk at `/var/lib/matrix-synapse/media` and if i remove the folder `/var/lib/matrix-synapse/media` the images are not shown anymore although they are still in the s3 bucket. So it seems to me that the `s3_storage_provider.S3StorageProviderBackend` does nothing but also store the data as a backup option?
I also could not find any documentation about `media_storage_providers` in this repo.
Can someone explain what they are and how they are supposed to work please.
My use case is that i want only to use the S3 Bucket and no local storage. Is this possible with `media_storage_providers`?",
1148,https://api.github.com/repos/matrix-org/synapse/issues/7139,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7139/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7139/comments,https://api.github.com/repos/matrix-org/synapse/issues/7139/events,https://github.com/matrix-org/synapse/issues/7139,587561891,MDU6SXNzdWU1ODc1NjE4OTE=,7139,"Error 403 ""no create event in auth events"" when trying to reject invitation after inviter leaves","{'login': 'WebFreak001', 'id': 2035977, 'node_id': 'MDQ6VXNlcjIwMzU5Nzc=', 'avatar_url': 'https://avatars0.githubusercontent.com/u/2035977?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/WebFreak001', 'html_url': 'https://github.com/WebFreak001', 'followers_url': 'https://api.github.com/users/WebFreak001/followers', 'following_url': 'https://api.github.com/users/WebFreak001/following{/other_user}', 'gists_url': 'https://api.github.com/users/WebFreak001/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/WebFreak001/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/WebFreak001/subscriptions', 'organizations_url': 'https://api.github.com/users/WebFreak001/orgs', 'repos_url': 'https://api.github.com/users/WebFreak001/repos', 'events_url': 'https://api.github.com/users/WebFreak001/events{/privacy}', 'received_events_url': 'https://api.github.com/users/WebFreak001/received_events', 'type': 'User', 'site_admin': False}","[{'id': 121086029, 'node_id': 'MDU6TGFiZWwxMjEwODYwMjk=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/bug', 'name': 'bug', 'color': 'fc2929', 'default': True, 'description': None}, {'id': 477043173, 'node_id': 'MDU6TGFiZWw0NzcwNDMxNzM=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/p2', 'name': 'p2', 'color': 'fbca04', 'default': False, 'description': None}, {'id': 597215764, 'node_id': 'MDU6TGFiZWw1OTcyMTU3NjQ=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/stuck-invite', 'name': 'stuck-invite', 'color': 'c5def5', 'default': False, 'description': None}]",closed,False,,[],,5,2020-03-25T09:33:20Z,2020-07-30T15:58:57Z,2020-07-30T15:58:57Z,NONE,,,"
### Description
A user was invited to a DM by another user, who has promptly left the room without the invitee accepting the request. Now the invitee can't reject the room invite and has a stuck invite.
### Steps to reproduce
(doesn't work reliably, but this is what reportedly was being done)
- invite a user to DM
- leave DM before user joined DM
- (wait a little bit)
- user can't accept nor reject DM
log when room was created:
```
2020-03-24 07:13:41,242 - synapse.access.http.8008 - 233 - INFO - OPTIONS-5783871 - 10.56.3.4 - 8008 - Received request: OPTIONS /_matrix/client/r0/createRoom
2020-03-24 07:13:41,243 - synapse.access.http.8008 - 302 - INFO - OPTIONS-5783871 - 10.56.3.4 - 8008 - {None} Processed request: 0.000sec/0.000sec (0.000sec, 0.000sec) (0.000sec/0.000sec/0) 22B 200 ""OPTIONS /_matrix/client/r0/createRoom HTTP/1.0"" ""Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Riot/1.3.2 Chrome/73.0.3683.121 Electron/5.0.7 Safari/537.36"" [0 dbevts]
2020-03-24 07:13:41,250 - synapse.access.http.8008 - 233 - INFO - POST-5783872 - 10.56.3.4 - 8008 - Received request: POST /_matrix/client/r0/createRoom
2020-03-24 07:13:41,263 - synapse.handlers.room - 768 - INFO - POST-5783872 - Sending m.room.create in new room
2020-03-24 07:13:41,291 - synapse.storage.persist_events - 384 - INFO - persist_events-3984 - Calculating state delta for room !RoOmIdHeRe:home.server
2020-03-24 07:13:41,309 - synapse.handlers.room - 782 - INFO - POST-5783872 - Sending m.room.member in new room
2020-03-24 07:13:41,311 - synapse.handlers.user_directory - 152 - INFO - user_directory.notify_new_event-50069 - Handling 1 state deltas
2020-03-24 07:13:41,323 - synapse.handlers.stats - 303 - INFO - stats.notify_new_event-50036 - Updating room_stats_state for !RoOmIdHeRe:home.server: {'is_federatable': True}
2020-03-24 07:13:41,377 - synapse.storage.persist_events - 384 - INFO - persist_events-3985 - Calculating state delta for room !RoOmIdHeRe:home.server
2020-03-24 07:13:41,394 - synapse.handlers.sync - 930 - INFO - GET-5783812 - Calculating sync response for @inviter:home.server between StreamToken(room_key='s17923', presence_key='4092238', typing_key='14338', receipt_key='15653', account_data_key='40312', push_rules_key='126', to_device_key='1384', device_list_key='1061', groups_key='20') and StreamToken(room_key='s17925', presence_key=4092238, typing_key=14338, receipt_key=15653, account_data_key=40312, push_rules_key=126, to_device_key=1384, device_list_key=1061, groups_key=20)
2020-03-24 07:13:41,395 - synapse.handlers.sync - 930 - INFO - GET-5783815 - Calculating sync response for @inviter:home.server between StreamToken(room_key='s17923', presence_key='4092238', typing_key='14338', receipt_key='15653', account_data_key='40312', push_rules_key='126', to_device_key='1384', device_list_key='1061', groups_key='20') and StreamToken(room_key='s17925', presence_key=4092238, typing_key=14338, receipt_key=15653, account_data_key=40312, push_rules_key=126, to_device_key=1384, device_list_key=1061, groups_key=20)
2020-03-24 07:13:41,396 - synapse.handlers.room - 768 - INFO - POST-5783872 - Sending m.room.power_levels in new room
2020-03-24 07:13:41,401 - synapse.handlers.user_directory - 152 - INFO - user_directory.notify_new_event-50070 - Handling 1 state deltas
2020-03-24 07:13:41,403 - synapse.handlers.stats - 303 - INFO - stats.notify_new_event-50037 - Updating room_stats_state for !RoOmIdHeRe:home.server: {}
2020-03-24 07:13:41,425 - synapse.handlers.sync - 1466 - INFO - GET-5783815 - Membership changes in !RoOmIdHeRe:home.server: [$some-internal-id (join)]
2020-03-24 07:13:41,426 - synapse.handlers.sync - 1466 - INFO - GET-5783812 - Membership changes in !RoOmIdHeRe:home.server: [$some-internal-id (join)]
2020-03-24 07:13:41,469 - synapse.storage.persist_events - 384 - INFO - persist_events-3986 - Calculating state delta for room !RoOmIdHeRe:home.server
2020-03-24 07:13:41,489 - synapse.handlers.room - 768 - INFO - POST-5783872 - Sending m.room.join_rules in new room
2020-03-24 07:13:41,494 - synapse.handlers.user_directory - 152 - INFO - user_directory.notify_new_event-50071 - Handling 1 state deltas
2020-03-24 07:13:41,495 - synapse.handlers.stats - 303 - INFO - stats.notify_new_event-50038 - Updating room_stats_state for !RoOmIdHeRe:home.server: {}
2020-03-24 07:13:41,497 - synapse.metrics - 462 - INFO - - Collecting gc 1
2020-03-24 07:13:41,522 - synapse.access.http.8008 - 302 - INFO - GET-5783812 - 10.56.3.4 - 8008 - {@inviter:home.server} Processed request: 9.649sec/0.002sec (0.006sec, 0.000sec) (0.073sec/0.001sec/9) 647B 200 ""GET /_matrix/client/r0/sync?filter=4&timeout=30000&since=s17923_4092238_14338_15653_40312_126_1384_1061_20 HTTP/1.0"" ""Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Riot/1.3.2 Chrome/73.0.3683.121 Electron/5.0.7 Safari/537.36"" [0 dbevts]
2020-03-24 07:13:41,523 - synapse.access.http.8008 - 302 - INFO - GET-5783815 - 80.151.78.15 - 8008 - {@inviter:home.server} Processed request: 9.644sec/0.001sec (0.002sec, 0.000sec) (0.073sec/0.002sec/10) 648B 200 ""GET /_matrix/client/r0/sync?filter=4&timeout=30000&since=s17923_4092238_14338_15653_40312_126_1384_1061_20 HTTP/1.1"" ""Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Riot/1.5.13 Chrome/78.0.3904.130 Electron/7.1.12 Safari/537.36"" [0 dbevts]
2020-03-24 07:13:41,545 - synapse.access.http.8008 - 233 - INFO - POST-5783873 - 10.56.3.4 - 8008 - Received request: POST /_matrix/client/r0/keys/query
2020-03-24 07:13:41,601 - synapse.access.http.8008 - 233 - INFO - OPTIONS-5783874 - 10.56.3.4 - 8008 - Received request: OPTIONS /_matrix/client/r0/sync?filter=4&timeout=30000&since=s17925_4092238_14338_15653_40312_126_1384_1061_20
2020-03-24 07:13:41,601 - synapse.access.http.8008 - 302 - INFO - OPTIONS-5783874 - 10.56.3.4 - 8008 - {None} Processed request: 0.000sec/0.000sec (0.000sec, 0.000sec) (0.000sec/0.000sec/0) 22B 200 ""OPTIONS /_matrix/client/r0/sync?filter=4&timeout=30000&since=s17925_4092238_14338_15653_40312_126_1384_1061_20 HTTP/1.0"" ""Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Riot/1.3.2 Chrome/73.0.3683.121 Electron/5.0.7 Safari/537.36"" [0 dbevts]
2020-03-24 07:13:41,605 - synapse.access.http.8008 - 233 - INFO - GET-5783875 - 10.56.3.4 - 8008 - Received request: GET /_matrix/client/r0/sync?filter=4&timeout=30000&since=s17925_4092238_14338_15653_40312_126_1384_1061_20
2020-03-24 07:13:41,607 - synapse.handlers.sync - 930 - INFO - GET-5783875 - Calculating sync response for @inviter:home.server between StreamToken(room_key='s17925', presence_key='4092238', typing_key='14338', receipt_key='15653', account_data_key='40312', push_rules_key='126', to_device_key='1384', device_list_key='1061', groups_key='20') and StreamToken(room_key='s17926', presence_key=4092238, typing_key=14338, receipt_key=15653, account_data_key=40312, push_rules_key=126, to_device_key=1384, device_list_key=1061, groups_key=20)
2020-03-24 07:13:41,618 - synapse.access.http.8008 - 302 - INFO - GET-5783875 - 10.56.3.4 - 8008 - {@inviter:home.server} Processed request: 0.012sec/0.001sec (0.006sec, 0.000sec) (0.002sec/0.000sec/1) 563B 200 ""GET /_matrix/client/r0/sync?filter=4&timeout=30000&since=s17925_4092238_14338_15653_40312_126_1384_1061_20 HTTP/1.0"" ""Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Riot/1.3.2 Chrome/73.0.3683.121 Electron/5.0.7 Safari/537.36"" [0 dbevts]
2020-03-24 07:13:41,621 - synapse.access.http.8008 - 302 - INFO - POST-5783873 - 10.56.3.4 - 8008 - {@inviter:home.server} Processed request: 0.075sec/0.001sec (0.003sec, 0.000sec) (0.014sec/0.000sec/2) 1617B 200 ""POST /_matrix/client/r0/keys/query HTTP/1.0"" ""Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Riot/1.3.2 Chrome/73.0.3683.121 Electron/5.0.7 Safari/537.36"" [0 dbevts]
2020-03-24 07:13:41,622 - synapse.storage.persist_events - 384 - INFO - persist_events-3987 - Calculating state delta for room !RoOmIdHeRe:home.server
2020-03-24 07:13:41,629 - synapse.access.http.8008 - 233 - INFO - OPTIONS-5783876 - 10.56.3.4 - 8008 - Received request: OPTIONS /_matrix/client/r0/sync?filter=4&timeout=30000&since=s17926_4092238_14338_15653_40312_126_1384_1061_20
2020-03-24 07:13:41,629 - synapse.access.http.8008 - 302 - INFO - OPTIONS-5783876 - 10.56.3.4 - 8008 - {None} Processed request: 0.000sec/0.000sec (0.000sec, 0.000sec) (0.000sec/0.000sec/0) 22B 200 ""OPTIONS /_matrix/client/r0/sync?filter=4&timeout=30000&since=s17926_4092238_14338_15653_40312_126_1384_1061_20 HTTP/1.0"" ""Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Riot/1.3.2 Chrome/73.0.3683.121 Electron/5.0.7 Safari/537.36"" [0 dbevts]
2020-03-24 07:13:41,632 - synapse.access.http.8008 - 233 - INFO - GET-5783877 - 10.56.3.4 - 8008 - Received request: GET /_matrix/client/r0/sync?filter=4&timeout=30000&since=s17926_4092238_14338_15653_40312_126_1384_1061_20
2020-03-24 07:13:41,637 - synapse.handlers.sync - 930 - INFO - GET-5783877 - Calculating sync response for @inviter:home.server between StreamToken(room_key='s17926', presence_key='4092238', typing_key='14338', receipt_key='15653', account_data_key='40312', push_rules_key='126', to_device_key='1384', device_list_key='1061', groups_key='20') and StreamToken(room_key='s17927', presence_key=4092238, typing_key=14338, receipt_key=15653, account_data_key=40312, push_rules_key=126, to_device_key=1384, device_list_key=1061, groups_key=20)
2020-03-24 07:13:41,639 - synapse.handlers.room - 768 - INFO - POST-5783872 - Sending m.room.history_visibility in new room
2020-03-24 07:13:41,643 - synapse.handlers.user_directory - 152 - INFO - user_directory.notify_new_event-50072 - Handling 1 state deltas
2020-03-24 07:13:41,644 - synapse.handlers.stats - 303 - INFO - stats.notify_new_event-50039 - Updating room_stats_state for !RoOmIdHeRe:home.server: {'join_rules': 'invite'}
2020-03-24 07:13:41,661 - synapse.access.http.8008 - 233 - INFO - OPTIONS-5783878 - 80.151.78.15 - 8008 - Received request: OPTIONS /_matrix/client/r0/keys/query
2020-03-24 07:13:41,662 - synapse.access.http.8008 - 302 - INFO - OPTIONS-5783878 - 80.151.78.15 - 8008 - {None} Processed request: 0.000sec/0.000sec (0.000sec, 0.000sec) (0.000sec/0.000sec/0) 22B 200 ""OPTIONS /_matrix/client/r0/keys/query HTTP/1.1"" ""Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Riot/1.5.13 Chrome/78.0.3904.130 Electron/7.1.12 Safari/537.36"" [0 dbevts]
2020-03-24 07:13:41,679 - synapse.access.http.8008 - 302 - INFO - GET-5783877 - 10.56.3.4 - 8008 - {@inviter:home.server} Processed request: 0.043sec/0.003sec (0.006sec, 0.000sec) (0.026sec/0.000sec/3) 462B 200 ""GET /_matrix/client/r0/sync?filter=4&timeout=30000&since=s17926_4092238_14338_15653_40312_126_1384_1061_20 HTTP/1.0"" ""Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Riot/1.3.2 Chrome/73.0.3683.121 Electron/5.0.7 Safari/537.36"" [0 dbevts]
2020-03-24 07:13:41,693 - synapse.access.http.8008 - 233 - INFO - OPTIONS-5783879 - 80.151.78.15 - 8008 - Received request: OPTIONS /_matrix/client/r0/sync?filter=4&timeout=30000&since=s17925_4092238_14338_15653_40312_126_1384_1061_20
2020-03-24 07:13:41,694 - synapse.access.http.8008 - 302 - INFO - OPTIONS-5783879 - 80.151.78.15 - 8008 - {None} Processed request: 0.000sec/0.000sec (0.000sec, 0.000sec) (0.000sec/0.000sec/0) 22B 200 ""OPTIONS /_matrix/client/r0/sync?filter=4&timeout=30000&since=s17925_4092238_14338_15653_40312_126_1384_1061_20 HTTP/1.1"" ""Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Riot/1.5.13 Chrome/78.0.3904.130 Electron/7.1.12 Safari/537.36"" [0 dbevts]
2020-03-24 07:13:41,694 - synapse.access.http.8008 - 233 - INFO - OPTIONS-5783880 - 10.56.3.4 - 8008 - Received request: OPTIONS /_matrix/client/r0/sync?filter=4&timeout=30000&since=s17927_4092238_14338_15653_40312_126_1384_1061_20
2020-03-24 07:13:41,695 - synapse.access.http.8008 - 302 - INFO - OPTIONS-5783880 - 10.56.3.4 - 8008 - {None} Processed request: 0.000sec/0.000sec (0.000sec, 0.000sec) (0.000sec/0.000sec/0) 22B 200 ""OPTIONS /_matrix/client/r0/sync?filter=4&timeout=30000&since=s17927_4092238_14338_15653_40312_126_1384_1061_20 HTTP/1.0"" ""Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Riot/1.3.2 Chrome/73.0.3683.121 Electron/5.0.7 Safari/537.36"" [0 dbevts]
2020-03-24 07:13:41,700 - synapse.access.http.8008 - 233 - INFO - GET-5783881 - 10.56.3.4 - 8008 - Received request: GET /_matrix/client/r0/sync?filter=4&timeout=30000&since=s17927_4092238_14338_15653_40312_126_1384_1061_20
2020-03-24 07:13:41,702 - synapse.storage.persist_events - 384 - INFO - persist_events-3988 - Calculating state delta for room !RoOmIdHeRe:home.server
2020-03-24 07:13:41,719 - synapse.handlers.sync - 930 - INFO - GET-5783881 - Calculating sync response for @inviter:home.server between StreamToken(room_key='s17927', presence_key='4092238', typing_key='14338', receipt_key='15653', account_data_key='40312', push_rules_key='126', to_device_key='1384', device_list_key='1061', groups_key='20') and StreamToken(room_key='s17928', presence_key=4092238, typing_key=14338, receipt_key=15653, account_data_key=40312, push_rules_key=126, to_device_key=1384, device_list_key=1061, groups_key=20)
2020-03-24 07:13:41,720 - synapse.handlers.room - 768 - INFO - POST-5783872 - Sending m.room.guest_access in new room
2020-03-24 07:13:41,724 - synapse.handlers.user_directory - 152 - INFO - user_directory.notify_new_event-50073 - Handling 1 state deltas
2020-03-24 07:13:41,726 - synapse.handlers.stats - 303 - INFO - stats.notify_new_event-50040 - Updating room_stats_state for !RoOmIdHeRe:home.server: {'history_visibility': 'shared'}
2020-03-24 07:13:41,727 - synapse.access.http.8008 - 233 - INFO - POST-5783882 - 80.151.78.15 - 8008 - Received request: POST /_matrix/client/r0/keys/query
2020-03-24 07:13:41,737 - synapse.access.http.8008 - 233 - INFO - GET-5783883 - 80.151.78.15 - 8008 - Received request: GET /_matrix/client/r0/sync?filter=4&timeout=30000&since=s17925_4092238_14338_15653_40312_126_1384_1061_20
2020-03-24 07:13:41,739 - synapse.handlers.sync - 930 - INFO - GET-5783883 - Calculating sync response for @inviter:home.server between StreamToken(room_key='s17925', presence_key='4092238', typing_key='14338', receipt_key='15653', account_data_key='40312', push_rules_key='126', to_device_key='1384', device_list_key='1061', groups_key='20') and StreamToken(room_key='s17928', presence_key=4092238, typing_key=14338, receipt_key=15653, account_data_key=40312, push_rules_key=126, to_device_key=1384, device_list_key=1061, groups_key=20)
2020-03-24 07:13:41,765 - synapse.access.http.8008 - 302 - INFO - GET-5783881 - 10.56.3.4 - 8008 - {@inviter:home.server} Processed request: 0.059sec/0.006sec (0.001sec, 0.000sec) (0.026sec/0.000sec/3) 472B 200 ""GET /_matrix/client/r0/sync?filter=4&timeout=30000&since=s17927_4092238_14338_15653_40312_126_1384_1061_20 HTTP/1.0"" ""Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Riot/1.3.2 Chrome/73.0.3683.121 Electron/5.0.7 Safari/537.36"" [0 dbevts]
2020-03-24 07:13:41,766 - synapse.access.http.8008 - 302 - INFO - POST-5783882 - 80.151.78.15 - 8008 - {@inviter:home.server} Processed request: 0.037sec/0.001sec (0.005sec, 0.000sec) (0.026sec/0.000sec/2) 1617B 200 ""POST /_matrix/client/r0/keys/query HTTP/1.1"" ""Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Riot/1.5.13 Chrome/78.0.3904.130 Electron/7.1.12 Safari/537.36"" [0 dbevts]
2020-03-24 07:13:41,766 - synapse.access.http.8008 - 302 - INFO - GET-5783883 - 80.151.78.15 - 8008 - {@inviter:home.server} Processed request: 0.026sec/0.004sec (0.002sec, 0.000sec) (0.016sec/0.000sec/1) 700B 200 ""GET /_matrix/client/r0/sync?filter=4&timeout=30000&since=s17925_4092238_14338_15653_40312_126_1384_1061_20 HTTP/1.1"" ""Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Riot/1.5.13 Chrome/78.0.3904.130 Electron/7.1.12 Safari/537.36"" [0 dbevts]
2020-03-24 07:13:41,777 - synapse.handlers.presence - 255 - INFO - persist_presence_changes-76136 - Persisting 46 unpersisted presence updates
2020-03-24 07:13:41,778 - synapse.access.http.8008 - 233 - INFO - OPTIONS-5783884 - 10.56.3.4 - 8008 - Received request: OPTIONS /_matrix/client/r0/sync?filter=4&timeout=30000&since=s17928_4092238_14338_15653_40312_126_1384_1061_20
2020-03-24 07:13:41,779 - synapse.access.http.8008 - 302 - INFO - OPTIONS-5783884 - 10.56.3.4 - 8008 - {None} Processed request: 0.000sec/0.000sec (0.000sec, 0.000sec) (0.000sec/0.000sec/0) 22B 200 ""OPTIONS /_matrix/client/r0/sync?filter=4&timeout=30000&since=s17928_4092238_14338_15653_40312_126_1384_1061_20 HTTP/1.0"" ""Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Riot/1.3.2 Chrome/73.0.3683.121 Electron/5.0.7 Safari/537.36"" [0 dbevts]
2020-03-24 07:13:41,783 - synapse.access.http.8008 - 233 - INFO - GET-5783885 - 10.56.3.4 - 8008 - Received request: GET /_matrix/client/r0/sync?filter=4&timeout=30000&since=s17928_4092238_14338_15653_40312_126_1384_1061_20
2020-03-24 07:13:41,798 - synapse.storage.persist_events - 384 - INFO - persist_events-3989 - Calculating state delta for room !RoOmIdHeRe:home.server
2020-03-24 07:13:41,810 - synapse.rest.media.v1.preview_url_resource - 404 - INFO - expire_url_cache_data-456827 - Running url preview cache expiry
2020-03-24 07:13:41,817 - synapse.metrics - 462 - INFO - - Collecting gc 1
2020-03-24 07:13:41,827 - synapse.handlers.sync - 930 - INFO - GET-5783885 - Calculating sync response for @inviter:home.server between StreamToken(room_key='s17928', presence_key='4092238', typing_key='14338', receipt_key='15653', account_data_key='40312', push_rules_key='126', to_device_key='1384', device_list_key='1061', groups_key='20') and StreamToken(room_key='s17929', presence_key=4092284, typing_key=14338, receipt_key=15653, account_data_key=40312, push_rules_key=126, to_device_key=1384, device_list_key=1061, groups_key=20)
2020-03-24 07:13:41,831 - synapse.rest.media.v1.preview_url_resource - 483 - INFO - expire_url_cache_data-456827 - Deleted 0 media from url cache
2020-03-24 07:13:41,833 - synapse.handlers.user_directory - 152 - INFO - user_directory.notify_new_event-50074 - Handling 1 state deltas
2020-03-24 07:13:41,834 - synapse.handlers.stats - 303 - INFO - stats.notify_new_event-50041 - Updating room_stats_state for !RoOmIdHeRe:home.server: {'guest_access': 'can_join'}
2020-03-24 07:13:41,836 - synapse.access.http.8008 - 233 - INFO - OPTIONS-5783886 - 80.151.78.15 - 8008 - Received request: OPTIONS /_matrix/client/r0/sync?filter=4&timeout=30000&since=s17928_4092238_14338_15653_40312_126_1384_1061_20
2020-03-24 07:13:41,840 - synapse.access.http.8008 - 302 - INFO - OPTIONS-5783886 - 80.151.78.15 - 8008 - {None} Processed request: 0.000sec/0.003sec (0.001sec, 0.000sec) (0.000sec/0.000sec/0) 22B 200 ""OPTIONS /_matrix/client/r0/sync?filter=4&timeout=30000&since=s17928_4092238_14338_15653_40312_126_1384_1061_20 HTTP/1.1"" ""Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Riot/1.5.13 Chrome/78.0.3904.130 Electron/7.1.12 Safari/537.36"" [0 dbevts]
2020-03-24 07:13:41,867 - synapse.storage.TIME - 347 - INFO - - Total database time: 5.091% {store_state_group(7): 1.434%, persist_events(6): 0.848%, update_user_directory_stream_pos(6): 0.568%}
2020-03-24 07:13:41,869 - synapse.access.http.8008 - 302 - INFO - GET-5783885 - 10.56.3.4 - 8008 - {@inviter:home.server} Processed request: 0.084sec/0.003sec (0.005sec, 0.000sec) (0.025sec/0.000sec/3) 953B 200 ""GET /_matrix/client/r0/sync?filter=4&timeout=30000&since=s17928_4092238_14338_15653_40312_126_1384_1061_20 HTTP/1.0"" ""Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Riot/1.3.2 Chrome/73.0.3683.121 Electron/5.0.7 Safari/537.36"" [0 dbevts]
2020-03-24 07:13:41,874 - synapse.access.http.8008 - 233 - INFO - GET-5783887 - 80.151.78.15 - 8008 - Received request: GET /_matrix/client/r0/sync?filter=4&timeout=30000&since=s17928_4092238_14338_15653_40312_126_1384_1061_20
2020-03-24 07:13:41,876 - synapse.handlers.sync - 930 - INFO - GET-5783887 - Calculating sync response for @inviter:home.server between StreamToken(room_key='s17928', presence_key='4092238', typing_key='14338', receipt_key='15653', account_data_key='40312', push_rules_key='126', to_device_key='1384', device_list_key='1061', groups_key='20') and StreamToken(room_key='s17929', presence_key=4092284, typing_key=14338, receipt_key=15653, account_data_key=40312, push_rules_key=126, to_device_key=1384, device_list_key=1061, groups_key=20)
2020-03-24 07:13:41,885 - synapse.access.http.8008 - 302 - INFO - GET-5783887 - 80.151.78.15 - 8008 - {@inviter:home.server} Processed request: 0.010sec/0.001sec (0.004sec, 0.000sec) (0.002sec/0.000sec/1) 953B 200 ""GET /_matrix/client/r0/sync?filter=4&timeout=30000&since=s17928_4092238_14338_15653_40312_126_1384_1061_20 HTTP/1.1"" ""Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Riot/1.5.13 Chrome/78.0.3904.130 Electron/7.1.12 Safari/537.36"" [0 dbevts]
2020-03-24 07:13:41,888 - synapse.access.http.8008 - 233 - INFO - OPTIONS-5783888 - 10.56.3.4 - 8008 - Received request: OPTIONS /_matrix/client/r0/sync?filter=4&timeout=30000&since=s17929_4092284_14338_15653_40312_126_1384_1061_20
2020-03-24 07:13:41,889 - synapse.access.http.8008 - 302 - INFO - OPTIONS-5783888 - 10.56.3.4 - 8008 - {None} Processed request: 0.000sec/0.000sec (0.000sec, 0.000sec) (0.000sec/0.000sec/0) 22B 200 ""OPTIONS /_matrix/client/r0/sync?filter=4&timeout=30000&since=s17929_4092284_14338_15653_40312_126_1384_1061_20 HTTP/1.0"" ""Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Riot/1.3.2 Chrome/73.0.3683.121 Electron/5.0.7 Safari/537.36"" [0 dbevts]
2020-03-24 07:13:41,893 - synapse.access.http.8008 - 233 - INFO - GET-5783889 - 10.56.3.4 - 8008 - Received request: GET /_matrix/client/r0/sync?filter=4&timeout=30000&since=s17929_4092284_14338_15653_40312_126_1384_1061_20
2020-03-24 07:13:41,903 - synapse.storage.persist_events - 384 - INFO - persist_events-3990 - Calculating state delta for room !RoOmIdHeRe:home.server
2020-03-24 07:13:41,919 - synapse.handlers.sync - 930 - INFO - GET-5783889 - Calculating sync response for @inviter:home.server between StreamToken(room_key='s17929', presence_key='4092284', typing_key='14338', receipt_key='15653', account_data_key='40312', push_rules_key='126', to_device_key='1384', device_list_key='1061', groups_key='20') and StreamToken(room_key='s17930', presence_key=4092284, typing_key=14338, receipt_key=15653, account_data_key=40312, push_rules_key=126, to_device_key=1384, device_list_key=1061, groups_key=20)
2020-03-24 07:13:41,920 - synapse.handlers.sync - 930 - INFO - GET-5783850 - Calculating sync response for @user:home.server between StreamToken(room_key='s17923', presence_key='4092238', typing_key='14338', receipt_key='15653', account_data_key='40312', push_rules_key='126', to_device_key='1384', device_list_key='1061', groups_key='20') and StreamToken(room_key='s17930', presence_key=4092284, typing_key=14338, receipt_key=15653, account_data_key=40312, push_rules_key=126, to_device_key=1384, device_list_key=1061, groups_key=20)
2020-03-24 07:13:41,924 - synapse.access.http.8008 - 302 - INFO - POST-5783872 - 10.56.3.4 - 8008 - {@inviter:home.server} Processed request: 0.673sec/0.002sec (0.045sec, 0.004sec) (0.214sec/0.167sec/46) 79B 200 ""POST /_matrix/client/r0/createRoom HTTP/1.0"" ""Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Riot/1.3.2 Chrome/73.0.3683.121 Electron/5.0.7 Safari/537.36"" [0 dbevts]
2020-03-24 07:13:41,927 - synapse.handlers.user_directory - 152 - INFO - user_directory.notify_new_event-50075 - Handling 1 state deltas
2020-03-24 07:13:41,928 - synapse.handlers.stats - 303 - INFO - stats.notify_new_event-50042 - Updating room_stats_state for !RoOmIdHeRe:home.server: {}
2020-03-24 07:13:41,933 - synapse.access.http.8008 - 233 - INFO - OPTIONS-5783890 - 10.56.3.4 - 8008 - Received request: OPTIONS /_matrix/client/r0/user/%40inviter%3Ahome.server/account_data/m.direct
2020-03-24 07:13:41,934 - synapse.access.http.8008 - 302 - INFO - OPTIONS-5783890 - 10.56.3.4 - 8008 - {None} Processed request: 0.000sec/0.000sec (0.000sec, 0.000sec) (0.000sec/0.000sec/0) 22B 200 ""OPTIONS /_matrix/client/r0/user/%40inviter%3Ahome.server/account_data/m.direct HTTP/1.0"" ""Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Riot/1.3.2 Chrome/73.0.3683.121 Electron/5.0.7 Safari/537.36"" [0 dbevts]
2020-03-24 07:13:41,937 - synapse.access.http.8008 - 233 - INFO - PUT-5783891 - 10.56.3.4 - 8008 - Received request: PUT /_matrix/client/r0/user/%40inviter%3Ahome.server/account_data/m.direct
2020-03-24 07:13:41,950 - synapse.handlers.sync - 1466 - INFO - GET-5783850 - Membership changes in !RoOmIdHeRe:home.server: [$some-other-internal-id (invite)]
2020-03-24 07:13:41,953 - synapse.access.http.8008 - 233 - INFO - OPTIONS-5783892 - 80.151.78.15 - 8008 - Received request: OPTIONS /_matrix/client/r0/sync?filter=4&timeout=30000&since=s17929_4092284_14338_15653_40312_126_1384_1061_20
2020-03-24 07:13:41,954 - synapse.access.http.8008 - 302 - INFO - OPTIONS-5783892 - 80.151.78.15 - 8008 - {None} Processed request: 0.000sec/0.000sec (0.000sec, 0.000sec) (0.000sec/0.000sec/0) 22B 200 ""OPTIONS /_matrix/client/r0/sync?filter=4&timeout=30000&since=s17929_4092284_14338_15653_40312_126_1384_1061_20 HTTP/1.1"" ""Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Riot/1.5.13 Chrome/78.0.3904.130 Electron/7.1.12 Safari/537.36"" [0 dbevts]
2020-03-24 07:13:41,977 - synapse.access.http.8008 - 302 - INFO - PUT-5783891 - 10.56.3.4 - 8008 - {@inviter:home.server} Processed request: 0.039sec/0.000sec (0.003sec, 0.000sec) (0.016sec/0.019sec/2) 22B 200 ""PUT /_matrix/client/r0/user/%40inviter%3Ahome.server/account_data/m.direct HTTP/1.0"" ""Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Riot/1.3.2 Chrome/73.0.3683.121 Electron/5.0.7 Safari/537.36"" [0 dbevts]
2020-03-24 07:13:41,988 - synapse.access.http.8008 - 302 - INFO - GET-5783889 - 10.56.3.4 - 8008 - {@inviter:home.server} Processed request: 0.094sec/0.001sec (0.001sec, 0.000sec) (0.051sec/0.001sec/5) 584B 200 ""GET /_matrix/client/r0/sync?filter=4&timeout=30000&since=s17929_4092284_14338_15653_40312_126_1384_1061_20 HTTP/1.0"" ""Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Riot/1.3.2 Chrome/73.0.3683.121 Electron/5.0.7 Safari/537.36"" [0 dbevts]
2020-03-24 07:13:41,992 - synapse.access.http.8008 - 302 - INFO - GET-5783850 - 10.56.3.27 - 8008 - {@user:home.server} Processed request: 10.032sec/0.000sec (0.009sec, 0.000sec) (0.049sec/0.001sec/6) 1030B 200 ""GET /_matrix/client/r0/sync?filter=0&timeout=30000&since=s17923_4092238_14338_15653_40312_126_1384_1061_20 HTTP/1.0"" ""Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Riot/1.3.2 Chrome/73.0.3683.121 Electron/5.0.7 Safari/537.36"" [0 dbevts]
2020-03-24 07:13:41,992 - synapse.access.http.8008 - 233 - INFO - GET-5783893 - 80.151.78.15 - 8008 - Received request: GET /_matrix/client/r0/sync?filter=4&timeout=30000&since=s17929_4092284_14338_15653_40312_126_1384_1061_20
2020-03-24 07:13:41,995 - synapse.handlers.sync - 930 - INFO - GET-5783893 - Calculating sync response for @inviter:home.server between StreamToken(room_key='s17929', presence_key='4092284', typing_key='14338', receipt_key='15653', account_data_key='40312', push_rules_key='126', to_device_key='1384', device_list_key='1061', groups_key='20') and StreamToken(room_key='s17930', presence_key=4092284, typing_key=14338, receipt_key=15653, account_data_key=40313, push_rules_key=126, to_device_key=1384, device_list_key=1061, groups_key=20)
2020-03-24 07:13:42,003 - synapse.access.http.8008 - 302 - INFO - GET-5783893 - 80.151.78.15 - 8008 - {@inviter:home.server} Processed request: 0.010sec/0.000sec (0.007sec, 0.000sec) (0.001sec/0.001sec/4) 1204B 200 ""GET /_matrix/client/r0/sync?filter=4&timeout=30000&since=s17929_4092284_14338_15653_40312_126_1384_1061_20 HTTP/1.1"" ""Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Riot/1.5.13 Chrome/78.0.3904.130 Electron/7.1.12 Safari/537.36"" [0 dbevts]
2020-03-24 07:13:42,004 - synapse.access.http.8008 - 233 - INFO - OPTIONS-5783894 - 10.56.3.4 - 8008 - Received request: OPTIONS /_matrix/client/r0/user/%40inviter%3Ahome.server/account_data/im.vector.riot.breadcrumb_rooms
2020-03-24 07:13:42,004 - synapse.access.http.8008 - 302 - INFO - OPTIONS-5783894 - 10.56.3.4 - 8008 - {None} Processed request: 0.000sec/0.000sec (0.000sec, 0.003sec) (0.000sec/0.000sec/0) 22B 200 ""OPTIONS /_matrix/client/r0/user/%40inviter%3Ahome.server/account_data/im.vector.riot.breadcrumb_rooms HTTP/1.0"" ""Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Riot/1.3.2 Chrome/73.0.3683.121 Electron/5.0.7 Safari/537.36"" [0 dbevts]
2020-03-24 07:13:42,048 - synapse.access.http.8008 - 233 - INFO - OPTIONS-5783895 - 10.56.3.27 - 8008 - Received request: OPTIONS /_matrix/client/r0/sync?filter=0&timeout=30000&since=s17930_4092284_14338_15653_40312_126_1384_1061_20
2020-03-24 07:13:42,049 - synapse.access.http.8008 - 302 - INFO - OPTIONS-5783895 - 10.56.3.27 - 8008 - {None} Processed request: 0.000sec/0.000sec (0.000sec, 0.000sec) (0.000sec/0.000sec/0) 22B 200 ""OPTIONS /_matrix/client/r0/sync?filter=0&timeout=30000&since=s17930_4092284_14338_15653_40312_126_1384_1061_20 HTTP/1.0"" ""Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Riot/1.3.2 Chrome/73.0.3683.121 Electron/5.0.7 Safari/537.36"" [0 dbevts]
2020-03-24 07:13:42,053 - synapse.access.http.8008 - 233 - INFO - GET-5783896 - 10.56.3.27 - 8008 - Received request: GET /_matrix/client/r0/sync?filter=0&timeout=30000&since=s17930_4092284_14338_15653_40312_126_1384_1061_20
2020-03-24 07:13:42,067 - synapse.access.http.8008 - 233 - INFO - OPTIONS-5783897 - 80.151.78.15 - 8008 - Received request: OPTIONS /_matrix/client/r0/sync?filter=4&timeout=30000&since=s17930_4092284_14338_15653_40313_126_1384_1061_20
2020-03-24 07:13:42,067 - synapse.access.http.8008 - 302 - INFO - OPTIONS-5783897 - 80.151.78.15 - 8008 - {None} Processed request: 0.000sec/0.000sec (0.000sec, 0.000sec) (0.000sec/0.000sec/0) 22B 200 ""OPTIONS /_matrix/client/r0/sync?filter=4&timeout=30000&since=s17930_4092284_14338_15653_40313_126_1384_1061_20 HTTP/1.1"" ""Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Riot/1.5.13 Chrome/78.0.3904.130 Electron/7.1.12 Safari/537.36"" [0 dbevts]
```
log when inviter left: (after some typing and a message)
```
2020-03-24 07:14:09,310 - synapse.access.http.8008 - 233 - INFO - OPTIONS-5784116 - 10.56.3.4 - 8008 - Received request: OPTIONS /_matrix/client/r0/rooms/!RoOmIdHeRe%3Ahome.server/leave
2020-03-24 07:14:09,310 - synapse.access.http.8008 - 302 - INFO - OPTIONS-5784116 - 10.56.3.4 - 8008 - {None} Processed request: 0.000sec/0.000sec (0.000sec, 0.000sec) (0.000sec/0.000sec/0) 22B 200 ""OPTIONS /_matrix/client/r0/rooms/!RoOmIdHeRe%3Ahome.server/leave HTTP/1.0"" ""Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Riot/1.3.2 Chrome/73.0.3683.121 Electron/5.0.7 Safari/537.36"" [0 dbevts]
2020-03-24 07:14:09,314 - synapse.access.http.8008 - 233 - INFO - POST-5784117 - 10.56.3.4 - 8008 - Received request: POST /_matrix/client/r0/rooms/!RoOmIdHeRe%3Ahome.server/leave
2020-03-24 07:14:09,335 - synapse.storage.persist_events - 384 - INFO - persist_events-3998 - Calculating state delta for room !RoOmIdHeRe:home.server
2020-03-24 07:14:09,354 - synapse.handlers.sync - 930 - INFO - GET-5784102 - Calculating sync response for @inviter:home.server between StreamToken(room_key='s17937', presence_key='4092284', typing_key='14342', receipt_key='15654', account_data_key='40318', push_rules_key='126', to_device_key='1384', device_list_key='1061', groups_key='20') and StreamToken(room_key='s17938', presence_key=4092284, typing_key=14343, receipt_key=15655, account_data_key=40318, push_rules_key=126, to_device_key=1384, device_list_key=1061, groups_key=20)
2020-03-24 07:14:09,355 - synapse.handlers.sync - 930 - INFO - GET-5784105 - Calculating sync response for @inviter:home.server between StreamToken(room_key='s17937', presence_key='4092284', typing_key='14342', receipt_key='15654', account_data_key='40318', push_rules_key='126', to_device_key='1384', device_list_key='1061', groups_key='20') and StreamToken(room_key='s17938', presence_key=4092284, typing_key=14343, receipt_key=15655, account_data_key=40318, push_rules_key=126, to_device_key=1384, device_list_key=1061, groups_key=20)
2020-03-24 07:14:09,359 - synapse.access.http.8008 - 302 - INFO - POST-5784117 - 10.56.3.4 - 8008 - {@inviter:home.server} Processed request: 0.043sec/0.002sec (0.007sec, 0.000sec) (0.002sec/0.011sec/6) 22B 200 ""POST /_matrix/client/r0/rooms/!RoOmIdHeRe%3Ahome.server/leave HTTP/1.0"" ""Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Riot/1.3.2 Chrome/73.0.3683.121 Electron/5.0.7 Safari/537.36"" [0 dbevts]
2020-03-24 07:14:09,361 - synapse.handlers.user_directory - 152 - INFO - user_directory.notify_new_event-50096 - Handling 1 state deltas
2020-03-24 07:14:09,363 - synapse.handlers.stats - 303 - INFO - stats.notify_new_event-50062 - Updating room_stats_state for !RoOmIdHeRe:home.server: {}
2020-03-24 07:14:09,366 - synapse.handlers.user_directory - 198 - INFO - user_directory.notify_new_event-50096 - Server left room: '!RoOmIdHeRe:home.server'
2020-03-24 07:14:09,374 - synapse.access.http.8008 - 233 - INFO - OPTIONS-5784118 - 10.56.3.4 - 8008 - Received request: OPTIONS /_matrix/client/r0/user/%40inviter%3Ahome.server/account_data/im.vector.riot.breadcrumb_rooms
2020-03-24 07:14:09,374 - synapse.access.http.8008 - 302 - INFO - OPTIONS-5784118 - 10.56.3.4 - 8008 - {None} Processed request: 0.000sec/0.000sec (0.000sec, 0.000sec) (0.000sec/0.000sec/0) 22B 200 ""OPTIONS /_matrix/client/r0/user/%40inviter%3Ahome.server/account_data/im.vector.riot.breadcrumb_rooms HTTP/1.0"" ""Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Riot/1.3.2 Chrome/73.0.3683.121 Electron/5.0.7 Safari/537.36"" [0 dbevts]
2020-03-24 07:14:09,377 - synapse.handlers.sync - 1466 - INFO - GET-5784102 - Membership changes in !RoOmIdHeRe:home.server: [$another-internal-id (leave)]
2020-03-24 07:14:09,378 - synapse.handlers.sync - 1466 - INFO - GET-5784105 - Membership changes in !RoOmIdHeRe:home.server: [$another-internal-id (leave)]
2020-03-24 07:14:09,394 - synapse.metrics - 462 - INFO - - Collecting gc 1
```
log when trying to join room then:
```
2020-03-24 07:27:06,483 - synapse.access.http.8008 - 233 - INFO - OPTIONS-5789040 - 10.56.3.27 - 8008 - Received request: OPTIONS /_matrix/client/r0/join/!RoOmIdHeRe%3Ahome.server
2020-03-24 07:27:06,484 - synapse.access.http.8008 - 302 - INFO - OPTIONS-5789040 - 10.56.3.27 - 8008 - {None} Processed request: 0.000sec/0.000sec (0.000sec, 0.000sec) (0.000sec/0.000sec/0) 22B 200 ""OPTIONS /_matrix/client/r0/join/!RoOmIdHeRe%3Ahome.server HTTP/1.0"" ""Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Riot/1.3.2 Chrome/73.0.3683.121 Electron/5.0.7 Safari/537.36"" [0 dbevts]
2020-03-24 07:27:06,487 - synapse.access.http.8008 - 233 - INFO - POST-5789041 - 10.56.3.27 - 8008 - Received request: POST /_matrix/client/r0/join/!RoOmIdHeRe%3Ahome.server
2020-03-24 07:27:06,492 - synapse.http.server - 81 - INFO - POST-5789041 - SynapseError: 404 - No known servers
2020-03-24 07:27:06,493 - synapse.access.http.8008 - 302 - INFO - POST-5789041 - 10.56.3.27 - 8008 - {@user:home.server} Processed request: 0.006sec/0.000sec (0.004sec, 0.000sec) (0.001sec/0.001sec/5) 66B 404 ""POST /_matrix/client/r0/join/!RoOmIdHeRe%3Ahome.server HTTP/1.0"" ""Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Riot/1.3.2 Chrome/73.0.3683.121 Electron/5.0.7 Safari/537.36"" [0 dbevts]
```
(and another more recent try):
```
2020-03-25 07:43:28,066 - synapse.access.http.8008 - 302 - INFO - OPTIONS-86448 - 10.56.3.27 - 8008 - {None} Processed request: 0.001sec/0.001sec (0.002sec, 0.000sec) (0.000sec/0.000sec/0) 22B 200 ""OPTIONS /_matrix/client/r0/join/!RoOmId%3Ahome.server HTTP/1.0"" ""Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Riot/1.3.2 Chrome/73.0.3683.121 Electron/5.0.7 Safari/537.36"" [0 dbevts]
2020-03-25 07:43:28,084 - synapse.http.server - 81 - INFO - POST-86449 - SynapseError: 404 - No known servers
2020-03-25 07:43:28,085 - synapse.access.http.8008 - 302 - INFO - POST-86449 - 10.56.3.27 - 8008 - {@user:home.server} Processed request: 0.013sec/0.000sec (0.003sec, 0.000sec) (0.001sec/0.008sec/7) 66B 404 ""POST /_matrix/client/r0/join/!RoOmId%3Ahome.server HTTP/1.0"" ""Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Riot/1.3.2 Chrome/73.0.3683.121 Electron/5.0.7 Safari/537.36"" [0 dbevts]
```
additionally rooms were cleared but this already happened after a failed join:
```
2020-03-24 12:27:45,178 - synapse.storage.background_updates - 211 - INFO - background_updates-0 - Starting update batch on background update 'delete_old_current_state_events'
2020-03-24 12:27:45,184 - synapse.storage.data_stores.main.state - 391 - INFO - background_updates-0 - Deleting current state left rooms: {..., '!RoOmId:home.server', ...}
2020-03-24 12:27:45,216 - synapse.storage.background_updates - 253 - INFO - background_updates-0 - Running background update 'delete_old_current_state_events'. Processed 270 items in 37ms. (total_rate=2.7027027027027026/ms, current_rate=2.7027027027027026/ms, total_updated=100, batch_size=270)
```
log trying to reject room:
```
2020-03-25 09:22:54,232 - synapse.access.http.8008 - 302 - INFO - OPTIONS-133052 - 10.56.3.27 - 8008 - {None} Processed request: 0.000sec/0.000sec (0.000sec, 0.000sec) (0.000sec/0.000sec/0) 22B 200 ""OPTIONS /_matrix/client/r0/rooms/!RoOmId%3Ahome.server/leave HTTP/1.0"" ""Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:74.0) Gecko/20100101 Firefox/74.0"" [0 dbevts]
2020-03-25 09:22:54,259 - synapse.handlers.message - 810 - WARNING - POST-133053 - Denying new event because 403: No create event in auth events
2020-03-25 09:22:54,260 - synapse.http.server - 81 - INFO - POST-133053 - SynapseError: 403 - No create event in auth events
2020-03-25 09:22:54,261 - synapse.access.http.8008 - 302 - INFO - POST-133053 - 10.56.3.27 - 8008 - {@user:home.server} Processed request: 0.026sec/0.000sec (0.007sec, 0.000sec) (0.001sec/0.020sec/3) 78B 403 ""POST /_matrix/client/r0/rooms/!RoOmId%3Ahome.server/leave HTTP/1.0"" ""Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:74.0) Gecko/20100101 Firefox/74.0"" [0 dbevts]
```
Doesn't seem to be a cache problem because it happens on new logins on entirely new devices and also stays when clearing cache in riot.
### Version information
- **Homeserver**: (disabled federation, all local LDAP accounts only)
- **Version**: {""server_version"": ""1.12.0"", ""python_version"": ""3.6.7""}
- **Install method**: pip (Python 3.6.7)
- **Platform**:
OS: Ubuntu 18.04.4 LTS x86_64
Host: VMware Virtual Platform
Kernel: 4.15.0-91-generic
",
1149,https://api.github.com/repos/matrix-org/synapse/issues/7138,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7138/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7138/comments,https://api.github.com/repos/matrix-org/synapse/issues/7138/events,https://github.com/matrix-org/synapse/issues/7138,587402297,MDU6SXNzdWU1ODc0MDIyOTc=,7138,Use Retry-After header in addition to retry_after_ms,"{'login': 'sents', 'id': 26575793, 'node_id': 'MDQ6VXNlcjI2NTc1Nzkz', 'avatar_url': 'https://avatars3.githubusercontent.com/u/26575793?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sents', 'html_url': 'https://github.com/sents', 'followers_url': 'https://api.github.com/users/sents/followers', 'following_url': 'https://api.github.com/users/sents/following{/other_user}', 'gists_url': 'https://api.github.com/users/sents/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/sents/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/sents/subscriptions', 'organizations_url': 'https://api.github.com/users/sents/orgs', 'repos_url': 'https://api.github.com/users/sents/repos', 'events_url': 'https://api.github.com/users/sents/events{/privacy}', 'received_events_url': 'https://api.github.com/users/sents/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,2,2020-03-25T02:43:40Z,2020-03-27T20:13:57Z,2020-03-27T20:13:57Z,NONE,,,"**Description:**
When exceeding the rate limit synapse sends a `429, M_LIMIT_EXCEEDED` response with the json-attribute `retry_after_ms`. There seems to be a standard response header for this: [Retry-After](https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Retry-After)
Using this header in addition to the retry_after_ms attribute would make it easier to handle the retries in common http libraries.
",
1150,https://api.github.com/repos/matrix-org/synapse/issues/7137,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7137/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7137/comments,https://api.github.com/repos/matrix-org/synapse/issues/7137/events,https://github.com/matrix-org/synapse/pull/7137,587335794,MDExOlB1bGxSZXF1ZXN0MzkzMzAxNjUz,7137,Remove unused captcha_bypass_secret option,"{'login': 'aaronraimist', 'id': 5855073, 'node_id': 'MDQ6VXNlcjU4NTUwNzM=', 'avatar_url': 'https://avatars2.githubusercontent.com/u/5855073?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/aaronraimist', 'html_url': 'https://github.com/aaronraimist', 'followers_url': 'https://api.github.com/users/aaronraimist/followers', 'following_url': 'https://api.github.com/users/aaronraimist/following{/other_user}', 'gists_url': 'https://api.github.com/users/aaronraimist/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/aaronraimist/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/aaronraimist/subscriptions', 'organizations_url': 'https://api.github.com/users/aaronraimist/orgs', 'repos_url': 'https://api.github.com/users/aaronraimist/repos', 'events_url': 'https://api.github.com/users/aaronraimist/events{/privacy}', 'received_events_url': 'https://api.github.com/users/aaronraimist/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,0,2020-03-24T23:15:22Z,2020-03-25T17:55:46Z,2020-03-25T17:49:35Z,CONTRIBUTOR,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7137', 'html_url': 'https://github.com/matrix-org/synapse/pull/7137', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7137.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7137.patch'}","### Pull Request Checklist
* [x] Pull request is based on the develop branch
* [x] Pull request includes a [changelog file](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#changelog). The entry should:
- Be a short description of your change which makes sense to users. ""Fixed a bug that prevented receiving messages from other servers."" instead of ""Moved X method from `EventStore` to `EventWorkerStore`."".
- Use markdown where necessary, mostly for `code blocks`.
- End with either a period (.) or an exclamation mark (!).
- Start with a capital letter.
* [x] Pull request includes a [sign off](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#sign-off)
* [x] Code style is correct (run the [linters](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#code-style))
",
1151,https://api.github.com/repos/matrix-org/synapse/issues/7136,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7136/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7136/comments,https://api.github.com/repos/matrix-org/synapse/issues/7136/events,https://github.com/matrix-org/synapse/pull/7136,587264337,MDExOlB1bGxSZXF1ZXN0MzkzMjQzNjU4,7136,Refactor the CAS code to move the logic to a handler,"{'login': 'clokep', 'id': 517124, 'node_id': 'MDQ6VXNlcjUxNzEyNA==', 'avatar_url': 'https://avatars2.githubusercontent.com/u/517124?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/clokep', 'html_url': 'https://github.com/clokep', 'followers_url': 'https://api.github.com/users/clokep/followers', 'following_url': 'https://api.github.com/users/clokep/following{/other_user}', 'gists_url': 'https://api.github.com/users/clokep/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/clokep/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/clokep/subscriptions', 'organizations_url': 'https://api.github.com/users/clokep/orgs', 'repos_url': 'https://api.github.com/users/clokep/repos', 'events_url': 'https://api.github.com/users/clokep/events{/privacy}', 'received_events_url': 'https://api.github.com/users/clokep/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,1,2020-03-24T20:38:34Z,2020-03-26T19:05:28Z,2020-03-26T19:05:27Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7136', 'html_url': 'https://github.com/matrix-org/synapse/pull/7136', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7136.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7136.patch'}","This refactors the CAS code to move the logic to a separate handler class. It somewhat takes the `SSOAuthHandler` and the logic of each of the servlets and combines them into a `CasHandler` class that is analogous to `SamlHandler`.
It also adds typing information to the various CAS methods.
Based on feedback in https://github.com/matrix-org/synapse/pull/7102#discussion_r397086662",
1152,https://api.github.com/repos/matrix-org/synapse/issues/7135,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7135/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7135/comments,https://api.github.com/repos/matrix-org/synapse/issues/7135/events,https://github.com/matrix-org/synapse/issues/7135,587195294,MDU6SXNzdWU1ODcxOTUyOTQ=,7135,email_notif_for_new_users is ignored when creating new users via the Admin API,"{'login': 'florianjacob', 'id': 1109959, 'node_id': 'MDQ6VXNlcjExMDk5NTk=', 'avatar_url': 'https://avatars3.githubusercontent.com/u/1109959?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/florianjacob', 'html_url': 'https://github.com/florianjacob', 'followers_url': 'https://api.github.com/users/florianjacob/followers', 'following_url': 'https://api.github.com/users/florianjacob/following{/other_user}', 'gists_url': 'https://api.github.com/users/florianjacob/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/florianjacob/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/florianjacob/subscriptions', 'organizations_url': 'https://api.github.com/users/florianjacob/orgs', 'repos_url': 'https://api.github.com/users/florianjacob/repos', 'events_url': 'https://api.github.com/users/florianjacob/events{/privacy}', 'received_events_url': 'https://api.github.com/users/florianjacob/received_events', 'type': 'User', 'site_admin': False}","[{'id': 121086029, 'node_id': 'MDU6TGFiZWwxMjEwODYwMjk=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/bug', 'name': 'bug', 'color': 'fc2929', 'default': True, 'description': None}, {'id': 477043173, 'node_id': 'MDU6TGFiZWw0NzcwNDMxNzM=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/p2', 'name': 'p2', 'color': 'fbca04', 'default': False, 'description': None}]",closed,False,,[],,1,2020-03-24T18:33:06Z,2020-06-01T14:34:34Z,2020-06-01T14:34:34Z,NONE,,,"### Description
I created a few uses via the [Synapse Admin API](https://github.com/matrix-org/synapse/blob/master/docs/admin_api/README.rst) using the new `threepids` option to assign email addresses. I noticed though that the new users don't receive push notifications via the configured email address, despite having the `notif_for_new_users` configuration option set.
### Steps to reproduce
- run a synapse server with setting `notif_for_new_users: true` (the default) and a working email configuration
- Create a new user via the [“Create or modify Account”](https://github.com/matrix-org/synapse/blob/master/docs/admin_api/user_admin_api.rst#create-or-modify-account) Admin API
```
PUT /_synapse/admin/v2/users/testuser
{
""password"": ""testuser_password"",
""threepids"": [
{
""medium"": ""email"",
""address"": ""testuser@example.org""
}
]
}
```
- login as testuser
- see that the email address is present in the user settings
- see that email notifications for the address however are disabled in the user notification settings
### Relevant Code Sections in v1.12.0
- [notif_for_new_users setting](https://github.com/matrix-org/synapse/blob/v1.12.0/docs/sample_config.yaml#L1506)
- [email_notif_for_new_users check on interactive registration](https://github.com/matrix-org/synapse/blob/v1.12.0/synapse/handlers/register.py#L630)
- [missing check in user admin API somewhere around here](https://github.com/matrix-org/synapse/blob/v1.12.0/synapse/rest/admin/users.py#L275)
### Version information
- **Homeserver**: self-hosted
- **Version**: 1.12.0
- **Install method**: package manager
- **Platform**: NixOS 19.03",
1153,https://api.github.com/repos/matrix-org/synapse/issues/7134,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7134/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7134/comments,https://api.github.com/repos/matrix-org/synapse/issues/7134/events,https://github.com/matrix-org/synapse/pull/7134,587019963,MDExOlB1bGxSZXF1ZXN0MzkzMDM5OTIy,7134,Move command processing out of transport,"{'login': 'erikjohnston', 'id': 8428120, 'node_id': 'MDQ6VXNlcjg0MjgxMjA=', 'avatar_url': 'https://avatars0.githubusercontent.com/u/8428120?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/erikjohnston', 'html_url': 'https://github.com/erikjohnston', 'followers_url': 'https://api.github.com/users/erikjohnston/followers', 'following_url': 'https://api.github.com/users/erikjohnston/following{/other_user}', 'gists_url': 'https://api.github.com/users/erikjohnston/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/erikjohnston/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/erikjohnston/subscriptions', 'organizations_url': 'https://api.github.com/users/erikjohnston/orgs', 'repos_url': 'https://api.github.com/users/erikjohnston/repos', 'events_url': 'https://api.github.com/users/erikjohnston/events{/privacy}', 'received_events_url': 'https://api.github.com/users/erikjohnston/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,1,2020-03-24T14:53:57Z,2020-03-31T13:26:11Z,2020-03-31T13:26:11Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7134', 'html_url': 'https://github.com/matrix-org/synapse/pull/7134', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7134.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7134.patch'}","This moves out the command processing from `protocol` and merges it with the logic in `client` and `resource`. This simplifies things quite a bit and merges the server and client handling into one, rather than duplicating a bunch of code.
I'd suggest ignoring much of the changes in `protocol.py`, `client.py` and `resource.py`, most of it is just moving the code into `handler.py`.
This PR does a few things on top of the move:
1. Removes a bunch of unused functions around handling `SYNC` command (we probably just want to remove the command at this point).
2. Removes the checks for whether a command is a valid client or server command. These checks become a bit pointless in a redis world.
3. Changes how worker gets told about replication data. Instead of it sub classing the replication handler and overriding methods, we add a new ""replication data handler"" object to the `HomeServer` which worker apps can replace instead.
Based on ~~#7024~~ and #7128 ",
1154,https://api.github.com/repos/matrix-org/synapse/issues/7133,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7133/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7133/comments,https://api.github.com/repos/matrix-org/synapse/issues/7133/events,https://github.com/matrix-org/synapse/pull/7133,586858611,MDExOlB1bGxSZXF1ZXN0MzkyOTA4MzIx,7133,Fix starting workers when federation sending not split out.,"{'login': 'erikjohnston', 'id': 8428120, 'node_id': 'MDQ6VXNlcjg0MjgxMjA=', 'avatar_url': 'https://avatars0.githubusercontent.com/u/8428120?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/erikjohnston', 'html_url': 'https://github.com/erikjohnston', 'followers_url': 'https://api.github.com/users/erikjohnston/followers', 'following_url': 'https://api.github.com/users/erikjohnston/following{/other_user}', 'gists_url': 'https://api.github.com/users/erikjohnston/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/erikjohnston/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/erikjohnston/subscriptions', 'organizations_url': 'https://api.github.com/users/erikjohnston/orgs', 'repos_url': 'https://api.github.com/users/erikjohnston/repos', 'events_url': 'https://api.github.com/users/erikjohnston/events{/privacy}', 'received_events_url': 'https://api.github.com/users/erikjohnston/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,1,2020-03-24T10:36:10Z,2020-03-26T11:32:19Z,2020-03-25T09:42:40Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7133', 'html_url': 'https://github.com/matrix-org/synapse/pull/7133', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7133.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7133.patch'}","This is a bit of a hacky fix, but will do for now. Branch is based off of master, so we can do a hotfix if we want to.
Fixes #7130.",
1155,https://api.github.com/repos/matrix-org/synapse/issues/7132,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7132/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7132/comments,https://api.github.com/repos/matrix-org/synapse/issues/7132/events,https://github.com/matrix-org/synapse/issues/7132,586789306,MDU6SXNzdWU1ODY3ODkzMDY=,7132,video user timeout,"{'login': 'xsq0718', 'id': 26321450, 'node_id': 'MDQ6VXNlcjI2MzIxNDUw', 'avatar_url': 'https://avatars3.githubusercontent.com/u/26321450?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/xsq0718', 'html_url': 'https://github.com/xsq0718', 'followers_url': 'https://api.github.com/users/xsq0718/followers', 'following_url': 'https://api.github.com/users/xsq0718/following{/other_user}', 'gists_url': 'https://api.github.com/users/xsq0718/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/xsq0718/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/xsq0718/subscriptions', 'organizations_url': 'https://api.github.com/users/xsq0718/orgs', 'repos_url': 'https://api.github.com/users/xsq0718/repos', 'events_url': 'https://api.github.com/users/xsq0718/events{/privacy}', 'received_events_url': 'https://api.github.com/users/xsq0718/received_events', 'type': 'User', 'site_admin': False}","[{'id': 1311133228, 'node_id': 'MDU6TGFiZWwxMzExMTMzMjI4', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/info-needed', 'name': 'info-needed', 'color': 'a1e8ea', 'default': False, 'description': ''}]",closed,False,,[],,3,2020-03-24T08:40:28Z,2020-03-24T12:17:26Z,2020-03-24T12:17:25Z,NONE,,,"
### Description
[root@izbp1czplot2hq98jaybtdz matrix]# journalctl -fu matrix-synapse
-- Logs begin at Wed 2020-03-11 23:37:00 CST. --
Mar 19 14:37:25 izbp1czplot2hq98jaybtdz matrix-synapse[21747]: 2020-03-19 06:37:25,106 - synapse.http.site - 203 - WARNING - GET-2613 - Error processing request : Connection was closed cleanly.
Mar 19 14:37:25 izbp1czplot2hq98jaybtdz matrix-synapse[21747]: 2020-03-19 06:37:25,115 - synapse.http.server - 465 - WARNING - GET-2613 - Not sending response to request , already disconnected.
Mar 19 14:39:58 izbp1czplot2hq98jaybtdz matrix-synapse[21747]: 2020-03-19 06:39:58,940 - synapse.http.site - 203 - WARNING - GET-2642 - Error processing request : Connection was closed cleanly.
Mar 19 14:39:58 izbp1czplot2hq98jaybtdz matrix-synapse[21747]: 2020-03-19 06:39:58,949 - synapse.http.server - 465 - WARNING - GET-2642 - Not sending response to request , already disconnected.
Mar 19 14:44:49 izbp1czplot2hq98jaybtdz matrix-synapse[21747]: 2020-03-19 06:44:49,911 - synapse.http.site - 203 - WARNING - GET-2669 - Error processing request : Connection was closed cleanly.
Mar 19 14:44:49 izbp1czplot2hq98jaybtdz matrix-synapse[21747]: 2020-03-19 06:44:49,919 - synapse.http.server - 465 - WARNING - GET-2669 - Not sending response to request , already disconnected.
Mar 19 14:45:42 izbp1czplot2hq98jaybtdz matrix-synapse[21747]: 2020-03-19 06:45:42,545 - synapse.push.httppusher - 387 - WARNING - httppush.process-91 - Failed to push event $fl4-y-uY3dNQZg9_PZ8cD5pOs_dGtlKs2gFPwBPGnak to @test4:mydomain/im.vector.app.ios.voip.prod/kEias6zIYvjR4fr0YZG2GXiqLnwuRhKGQKxD87PEGV4=: User timeout caused connection failure.
### Version information
- **Homeserver**:
If not matrix.org:
- **Version**:
matrixdotorg/synapse v1.11.1
- **Install method**:
docker pull matrixdotorg/synapse:1.11.1
- **Platform**:
CentOS Linux release 7.4.1708 (Core)
",
1156,https://api.github.com/repos/matrix-org/synapse/issues/7131,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7131/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7131/comments,https://api.github.com/repos/matrix-org/synapse/issues/7131/events,https://github.com/matrix-org/synapse/pull/7131,586736740,MDExOlB1bGxSZXF1ZXN0MzkyODExMTA2,7131,Bump Twisted version to 20.3.0,"{'login': 'DylanVanAssche', 'id': 4999159, 'node_id': 'MDQ6VXNlcjQ5OTkxNTk=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/4999159?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/DylanVanAssche', 'html_url': 'https://github.com/DylanVanAssche', 'followers_url': 'https://api.github.com/users/DylanVanAssche/followers', 'following_url': 'https://api.github.com/users/DylanVanAssche/following{/other_user}', 'gists_url': 'https://api.github.com/users/DylanVanAssche/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/DylanVanAssche/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/DylanVanAssche/subscriptions', 'organizations_url': 'https://api.github.com/users/DylanVanAssche/orgs', 'repos_url': 'https://api.github.com/users/DylanVanAssche/repos', 'events_url': 'https://api.github.com/users/DylanVanAssche/events{/privacy}', 'received_events_url': 'https://api.github.com/users/DylanVanAssche/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,2,2020-03-24T06:54:16Z,2020-03-24T19:51:24Z,2020-03-24T10:26:23Z,NONE,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7131', 'html_url': 'https://github.com/matrix-org/synapse/pull/7131', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7131.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7131.patch'}","With the release of Synapse V1.0.12 it is advised to upgrade Twisted to 20.3.0 to avoid vulnerabilities when using Synapse behind a reverse-proxy. This PR upgrades the minimum dependency version of Synapse which install the right Twisted version automatically when running `pip install --upgrade .` when upgrading.
Signed-off-by: Dylan Van Assche
### Pull Request Checklist
* [x] Pull request is based on the develop branch
* [x] Pull request includes a [changelog file](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#changelog). The entry should:
- Be a short description of your change which makes sense to users. ""Fixed a bug that prevented receiving messages from other servers."" instead of ""Moved X method from `EventStore` to `EventWorkerStore`."".
- Use markdown where necessary, mostly for `code blocks`.
- End with either a period (.) or an exclamation mark (!).
- Start with a capital letter.
* [x] Pull request includes a [sign off](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#sign-off)
* [ ] Code style is correct (run the [linters](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#code-style))
",
1157,https://api.github.com/repos/matrix-org/synapse/issues/7130,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7130/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7130/comments,https://api.github.com/repos/matrix-org/synapse/issues/7130/events,https://github.com/matrix-org/synapse/issues/7130,586598314,MDU6SXNzdWU1ODY1OTgzMTQ=,7130,update to 1.12 broke workers setup,"{'login': 'airblag', 'id': 24829620, 'node_id': 'MDQ6VXNlcjI0ODI5NjIw', 'avatar_url': 'https://avatars1.githubusercontent.com/u/24829620?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/airblag', 'html_url': 'https://github.com/airblag', 'followers_url': 'https://api.github.com/users/airblag/followers', 'following_url': 'https://api.github.com/users/airblag/following{/other_user}', 'gists_url': 'https://api.github.com/users/airblag/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/airblag/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/airblag/subscriptions', 'organizations_url': 'https://api.github.com/users/airblag/orgs', 'repos_url': 'https://api.github.com/users/airblag/repos', 'events_url': 'https://api.github.com/users/airblag/events{/privacy}', 'received_events_url': 'https://api.github.com/users/airblag/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,3,2020-03-24T00:11:25Z,2020-03-26T13:24:29Z,2020-03-26T13:24:29Z,NONE,,,"### Description
I changed my setup for using workers a few days ago. Today, after updating to 1.12 (debian repository from matrix.org), my workers are not starting anymore.
Example of the log for a synchrotron worker :
```
2020-03-24 00:51:40,018 - root - 257 - WARNING - None- ***** STARTING SERVER *****
2020-03-24 00:51:40,018 - root - 258 - WARNING - None- Server /opt/venvs/matrix-synapse/lib/python3.7/site-packages/synapse/app/synchrotron.py version 1.12.0
2020-03-24 00:51:40,230 - synapse.app.synchrotron - 245 - WARNING - - Starting daemon.
2020-03-24 00:51:40,332 - twisted - 192 - ERROR - - Traceback (most recent call last):
2020-03-24 00:51:40,332 - twisted - 192 - ERROR - - File ""/opt/venvs/matrix-synapse/lib/python3.7/site-packages/synapse/app/_base.py"", line 277, in start
2020-03-24 00:51:40,332 - twisted - 192 - ERROR - - hs.start_listening(listeners)
2020-03-24 00:51:40,333 - twisted - 192 - ERROR - - File ""/opt/venvs/matrix-synapse/lib/python3.7/site-packages/synapse/app/generic_worker.py"", line 575, in start_listening
2020-03-24 00:51:40,333 - twisted - 192 - ERROR - - self.get_tcp_replication().start_replication(self)
2020-03-24 00:51:40,333 - twisted - 192 - ERROR - - File ""/opt/venvs/matrix-synapse/lib/python3.7/site-packages/synapse/server.py"", line 568, in _get
2020-03-24 00:51:40,333 - twisted - 192 - ERROR - - dep = builder()
2020-03-24 00:51:40,334 - twisted - 192 - ERROR - - File ""/opt/venvs/matrix-synapse/lib/python3.7/site-packages/synapse/app/generic_worker.py"", line 581, in build_tcp_replication
2020-03-24 00:51:40,334 - twisted - 192 - ERROR - - return GenericWorkerReplicationHandler(self)
2020-03-24 00:51:40,334 - twisted - 192 - ERROR - - File ""/opt/venvs/matrix-synapse/lib/python3.7/site-packages/synapse/app/generic_worker.py"", line 604, in __init__
2020-03-24 00:51:40,334 - twisted - 192 - ERROR - - self.send_handler = FederationSenderHandler(hs, self)
2020-03-24 00:51:40,335 - twisted - 192 - ERROR - - File ""/opt/venvs/matrix-synapse/lib/python3.7/site-packages/synapse/app/generic_worker.py"", line 734, in __init__
2020-03-24 00:51:40,335 - twisted - 192 - ERROR - - self.federation_sender = hs.get_federation_sender()
2020-03-24 00:51:40,335 - twisted - 192 - ERROR - - File ""/opt/venvs/matrix-synapse/lib/python3.7/site-packages/synapse/server.py"", line 568, in _get
2020-03-24 00:51:40,335 - twisted - 192 - ERROR - - dep = builder()
2020-03-24 00:51:40,335 - twisted - 192 - ERROR - - File ""/opt/venvs/matrix-synapse/lib/python3.7/site-packages/synapse/server.py"", line 445, in build_federation_sender
2020-03-24 00:51:40,336 - twisted - 192 - ERROR - - raise Exception(""Workers cannot send federation traffic"")
2020-03-24 00:51:40,336 - twisted - 192 - ERROR - - Exception: Workers cannot send federation traffic
2020-03-24 00:51:40,337 - twisted - 192 - CRITICAL - - Unhandled Error
Traceback (most recent call last):
File ""/opt/venvs/matrix-synapse/lib/python3.7/site-packages/twisted/internet/base.py"", line 1282, in run
self.startRunning(installSignalHandlers=installSignalHandlers)
File ""/opt/venvs/matrix-synapse/lib/python3.7/site-packages/twisted/internet/base.py"", line 1262, in startRunning
ReactorBase.startRunning(self)
File ""/opt/venvs/matrix-synapse/lib/python3.7/site-packages/twisted/internet/base.py"", line 770, in startRunning
self.fireSystemEvent('startup')
File ""/opt/venvs/matrix-synapse/lib/python3.7/site-packages/twisted/internet/base.py"", line 721, in fireSystemEvent
event.fireEvent()
--- ---
File ""/opt/venvs/matrix-synapse/lib/python3.7/site-packages/twisted/internet/base.py"", line 428, in fireEvent
result = callable(*args, **kwargs)
File ""/opt/venvs/matrix-synapse/lib/python3.7/site-packages/synapse/app/_base.py"", line 297, in start
sys.exit(1)
builtins.SystemExit: 1
```
/etc/matrix-synapse/worker/synchrotron-1.yaml:
```
worker_app: synapse.app.synchrotron
# The replication listener on the synapse to talk to.
worker_replication_host: 127.0.0.1
worker_replication_port: 9092
worker_replication_http_port: 9093
worker_listeners:
- type: http
port: 8083
resources:
- names:
- client
worker_daemonize: True
worker_pid_file: /var/run/synapse/synchrotron1.pid
worker_log_config: /etc/matrix-synapse/synchrotron1-log.yaml
```
### Steps to reproduce
worked with 1.11 and stopped with the update
### Version information
- **Homeserver**:
selfhosted
- **Version**:
{
""python_version"": ""3.7.3"",
""server_version"": ""1.12.0""
}
- **Install method**:
apt, matrix.org repository
### Description
If the client tries to upload an **encrypted** image with the Content-Type for example ""image/jpeg"", the server response with ""Internal server error"". For encrypted images I need to change the Content-Type to ""application/octet-stream"".
### Steps to reproduce
- Build a fancy Matrix client with file encryption
- Encrypt an image file
- Upload the image with the Content-Type of the unencrypted image mimetype
Expected:
The server recognized that the file is encrypted and handles it like a blob and does not respond with an internal server error.
Actual:
Can't upload the image without an internal server error.
### Version information
- **Homeserver**: https://famedly.de
If not matrix.org:
- **Version**: Can tell you this later today
- **Install method**: Docker, more information will come later today
- **Platform**: Debian, more information will come later today
",
1162,https://api.github.com/repos/matrix-org/synapse/issues/7125,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7125/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7125/comments,https://api.github.com/repos/matrix-org/synapse/issues/7125/events,https://github.com/matrix-org/synapse/issues/7125,585873959,MDU6SXNzdWU1ODU4NzM5NTk=,7125,Document logging options,"{'login': 'IngwiePhoenix', 'id': 2893716, 'node_id': 'MDQ6VXNlcjI4OTM3MTY=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/2893716?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/IngwiePhoenix', 'html_url': 'https://github.com/IngwiePhoenix', 'followers_url': 'https://api.github.com/users/IngwiePhoenix/followers', 'following_url': 'https://api.github.com/users/IngwiePhoenix/following{/other_user}', 'gists_url': 'https://api.github.com/users/IngwiePhoenix/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/IngwiePhoenix/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/IngwiePhoenix/subscriptions', 'organizations_url': 'https://api.github.com/users/IngwiePhoenix/orgs', 'repos_url': 'https://api.github.com/users/IngwiePhoenix/repos', 'events_url': 'https://api.github.com/users/IngwiePhoenix/events{/privacy}', 'received_events_url': 'https://api.github.com/users/IngwiePhoenix/received_events', 'type': 'User', 'site_admin': False}","[{'id': 845245048, 'node_id': 'MDU6TGFiZWw4NDUyNDUwNDg=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/docs', 'name': 'docs', 'color': '0e8a16', 'default': False, 'description': ''}, {'id': 950651954, 'node_id': 'MDU6TGFiZWw5NTA2NTE5NTQ=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/good%20first%20issue', 'name': 'good first issue', 'color': '0bba0e', 'default': True, 'description': ''}]",open,False,,[],,0,2020-03-23T01:55:45Z,2020-05-19T19:08:29Z,,NONE,,,"**Description:**
While porting my sqlite based DB to Postgres, I realized just how much log messages Synapse produces and puts down on my disk - so many, that I would not be able to tell if there ever was an error, let alone be able to actually find something like app service communication. It would simply get lost - fast.
The link provided in the `log.yaml` file that came with the Debian package led to an extensive documentation - unfortunately, it is aimed at developers rather than users who want to set up logging for an application taking advantage of a software using this logging library. Thus, it is very, very confusing. I don't code in python a lot - merely enough that I can write utterly basic programs with it. But above that, I have no clue about Python at all - and I think that learning Python should not be required just to configure logging :)
I would basically like to split my config into:
- Client-Server API calls (`access.log`)
- Federation calls (`federation.log`)
- Appservices (`appservices.log`)
- Errors (`error.log`)
However, i have no idea, even after reading the linked document, how to set this scheme up properly...
Since I don't think I will be the only one, I thought I might as well ask for it as a ""feature request"", although it's more of a ""documentation request"".
Kind regards,
Ingwie",
1163,https://api.github.com/repos/matrix-org/synapse/issues/7124,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7124/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7124/comments,https://api.github.com/repos/matrix-org/synapse/issues/7124/events,https://github.com/matrix-org/synapse/pull/7124,585744726,MDExOlB1bGxSZXF1ZXN0MzkyMDI0MjQw,7124,Include method in thumbnail media name,"{'login': 'deepbluev7', 'id': 16312324, 'node_id': 'MDQ6VXNlcjE2MzEyMzI0', 'avatar_url': 'https://avatars3.githubusercontent.com/u/16312324?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/deepbluev7', 'html_url': 'https://github.com/deepbluev7', 'followers_url': 'https://api.github.com/users/deepbluev7/followers', 'following_url': 'https://api.github.com/users/deepbluev7/following{/other_user}', 'gists_url': 'https://api.github.com/users/deepbluev7/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/deepbluev7/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/deepbluev7/subscriptions', 'organizations_url': 'https://api.github.com/users/deepbluev7/orgs', 'repos_url': 'https://api.github.com/users/deepbluev7/repos', 'events_url': 'https://api.github.com/users/deepbluev7/events{/privacy}', 'received_events_url': 'https://api.github.com/users/deepbluev7/received_events', 'type': 'User', 'site_admin': False}",[],open,False,"{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}","[{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}]",,26,2020-03-22T15:32:46Z,2020-09-01T11:17:36Z,,NONE,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7124', 'html_url': 'https://github.com/matrix-org/synapse/pull/7124', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7124.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7124.patch'}","This fixes an issue, where different crop methods overwrite one another.
Signed-off-by: Nicolas Werner
### Pull Request Checklist
* [x] Pull request is based on the develop branch
* [x] Pull request includes a [changelog file](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#changelog). The entry should:
- Be a short description of your change which makes sense to users. ""Fixed a bug that prevented receiving messages from other servers."" instead of ""Moved X method from `EventStore` to `EventWorkerStore`."".
- Use markdown where necessary, mostly for `code blocks`.
- End with either a period (.) or an exclamation mark (!).
- Start with a capital letter.
* [x] Pull request includes a [sign off](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#sign-off)
* [x] Code style is correct (run the [linters](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#code-style))
",
1164,https://api.github.com/repos/matrix-org/synapse/issues/7123,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7123/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7123/comments,https://api.github.com/repos/matrix-org/synapse/issues/7123/events,https://github.com/matrix-org/synapse/pull/7123,585492665,MDExOlB1bGxSZXF1ZXN0MzkxODU0NjIw,7123,Add default values for notif_template_html and notif_template_text,"{'login': 'kuba-orlik', 'id': 2697916, 'node_id': 'MDQ6VXNlcjI2OTc5MTY=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/2697916?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/kuba-orlik', 'html_url': 'https://github.com/kuba-orlik', 'followers_url': 'https://api.github.com/users/kuba-orlik/followers', 'following_url': 'https://api.github.com/users/kuba-orlik/following{/other_user}', 'gists_url': 'https://api.github.com/users/kuba-orlik/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/kuba-orlik/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/kuba-orlik/subscriptions', 'organizations_url': 'https://api.github.com/users/kuba-orlik/orgs', 'repos_url': 'https://api.github.com/users/kuba-orlik/repos', 'events_url': 'https://api.github.com/users/kuba-orlik/events{/privacy}', 'received_events_url': 'https://api.github.com/users/kuba-orlik/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,3,2020-03-21T12:45:45Z,2020-03-26T15:07:16Z,2020-03-26T15:07:15Z,NONE,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7123', 'html_url': 'https://github.com/matrix-org/synapse/pull/7123', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7123.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7123.patch'}","Ref #6551
When setting up synapse I found the lack of default values for these fields confusing. I encountered #6551 and decided to add the fields to sample config. Is it where defaults are taken from? If not, please correct me
### Pull Request Checklist
* [ ] Pull request is based on the develop branch
* [ ] Pull request includes a [changelog file](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#changelog). The entry should:
- Be a short description of your change which makes sense to users. ""Fixed a bug that prevented receiving messages from other servers."" instead of ""Moved X method from `EventStore` to `EventWorkerStore`."".
- Use markdown where necessary, mostly for `code blocks`.
- End with either a period (.) or an exclamation mark (!).
- Start with a capital letter.
* [ ] Pull request includes a [sign off](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#sign-off)
* [ ] Code style is correct (run the [linters](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#code-style))
",
1165,https://api.github.com/repos/matrix-org/synapse/issues/7122,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7122/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7122/comments,https://api.github.com/repos/matrix-org/synapse/issues/7122/events,https://github.com/matrix-org/synapse/issues/7122,585453194,MDU6SXNzdWU1ODU0NTMxOTQ=,7122,Failed to send_join via matrix.org (or any server) when joining #freenode_#trains:matrix.org,"{'login': 'GuillaumeDIDIER', 'id': 3857552, 'node_id': 'MDQ6VXNlcjM4NTc1NTI=', 'avatar_url': 'https://avatars0.githubusercontent.com/u/3857552?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/GuillaumeDIDIER', 'html_url': 'https://github.com/GuillaumeDIDIER', 'followers_url': 'https://api.github.com/users/GuillaumeDIDIER/followers', 'following_url': 'https://api.github.com/users/GuillaumeDIDIER/following{/other_user}', 'gists_url': 'https://api.github.com/users/GuillaumeDIDIER/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/GuillaumeDIDIER/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/GuillaumeDIDIER/subscriptions', 'organizations_url': 'https://api.github.com/users/GuillaumeDIDIER/orgs', 'repos_url': 'https://api.github.com/users/GuillaumeDIDIER/repos', 'events_url': 'https://api.github.com/users/GuillaumeDIDIER/events{/privacy}', 'received_events_url': 'https://api.github.com/users/GuillaumeDIDIER/received_events', 'type': 'User', 'site_admin': False}",[],open,False,,[],,2,2020-03-21T08:11:00Z,2020-05-02T00:34:50Z,,NONE,,,"
### Description
When I attempt to join #freenode_#trains:matrix.org (aka #trains on FreeNode), the IRC a--service successfully joins my puppet (people on IRC believe I'm there), but I get an error message on my matrix client, and errors in the home server log.
My Homeserver is up to date using pip.
### Steps to reproduce
- `/join #freenode_#trains:matrix.org`
- wait a short while
- get error message `Failed to send_join via any server` on riot, no room joined.
Expected behaviour : no error message, join a room.
Logs : Too big to be inlined, attached. (Has some very long lines)
[homeserver.bug.log](https://github.com/matrix-org/synapse/files/4362577/homeserver.bug.log)
### Version information
- **Homeserver**: matrix.sobex.net (plus joining a channel on matrix.org)
- **Version**: {""server_version"": ""1.11.1"", ""python_version"": ""3.6.9""}
- **Install method**: pip / virtualenv
- **Platform**: gentoo / linux on a dedicated server.
",
1166,https://api.github.com/repos/matrix-org/synapse/issues/7121,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7121/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7121/comments,https://api.github.com/repos/matrix-org/synapse/issues/7121/events,https://github.com/matrix-org/synapse/issues/7121,585408012,MDU6SXNzdWU1ODU0MDgwMTI=,7121,prune_old_outbound_device_pokes is burning CPU on the master,"{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,"{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}","[{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}]",,1,2020-03-21T01:56:08Z,2020-03-30T15:05:48Z,2020-03-30T15:05:48Z,MEMBER,,,"Every hour, it runs for 20 minutes. It's running in a database thread but I suspect it's holding the GIL for a lot of that time,
It's table-scanning the whole table, and then doing a query on every single (user_id,destination) in the table (over a million of them). The code doesn't seem to realise that users might have more than one device. We either need to optimise the query, or move the pruned remnants out to a separate table so that we aren't redoing the same work the whole time.
Related: #4115",
1167,https://api.github.com/repos/matrix-org/synapse/issues/7120,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7120/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7120/comments,https://api.github.com/repos/matrix-org/synapse/issues/7120/events,https://github.com/matrix-org/synapse/pull/7120,585386748,MDExOlB1bGxSZXF1ZXN0MzkxNzg1ODgw,7120,Clean up some LoggingContext stuff,"{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,5,2020-03-21T00:05:41Z,2020-03-24T14:45:35Z,2020-03-24T14:45:34Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7120', 'html_url': 'https://github.com/matrix-org/synapse/pull/7120', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7120.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7120.patch'}","This is a series of commits aimed at cleaning up a bit of stuff around `LoggingContext`.
The first couple are the big ones; they move `Sentinel`, `current_context` and `set_context` out to the top level. Mostly this means that I can more easily trace what's actually referring to `LoggingContext` itself, but I think it's generally neater.
The other two are simple enough and hopefully speak for themselves.",
1168,https://api.github.com/repos/matrix-org/synapse/issues/7119,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7119/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7119/comments,https://api.github.com/repos/matrix-org/synapse/issues/7119/events,https://github.com/matrix-org/synapse/pull/7119,585349102,MDExOlB1bGxSZXF1ZXN0MzkxNzU4MzI3,7119,Update postgres.md,"{'login': 'siroccal', 'id': 41478263, 'node_id': 'MDQ6VXNlcjQxNDc4MjYz', 'avatar_url': 'https://avatars1.githubusercontent.com/u/41478263?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/siroccal', 'html_url': 'https://github.com/siroccal', 'followers_url': 'https://api.github.com/users/siroccal/followers', 'following_url': 'https://api.github.com/users/siroccal/following{/other_user}', 'gists_url': 'https://api.github.com/users/siroccal/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/siroccal/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/siroccal/subscriptions', 'organizations_url': 'https://api.github.com/users/siroccal/orgs', 'repos_url': 'https://api.github.com/users/siroccal/repos', 'events_url': 'https://api.github.com/users/siroccal/events{/privacy}', 'received_events_url': 'https://api.github.com/users/siroccal/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,2,2020-03-20T22:01:33Z,2020-04-02T01:48:34Z,2020-04-01T11:44:51Z,CONTRIBUTOR,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7119', 'html_url': 'https://github.com/matrix-org/synapse/pull/7119', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7119.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7119.patch'}","Add workaround in postgres docs for potential ident authentication failure.
### Pull Request Checklist
* [ ] Pull request is based on the develop branch
* [ ] Pull request includes a [changelog file](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#changelog). The entry should:
- Be a short description of your change which makes sense to users. ""Fixed a bug that prevented receiving messages from other servers."" instead of ""Moved X method from `EventStore` to `EventWorkerStore`."".
- Use markdown where necessary, mostly for `code blocks`.
- End with either a period (.) or an exclamation mark (!).
- Start with a capital letter.
* [ ] Pull request includes a [sign off](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#sign-off)
* [ ] Code style is correct (run the [linters](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#code-style))
",
1169,https://api.github.com/repos/matrix-org/synapse/issues/7118,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7118/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7118/comments,https://api.github.com/repos/matrix-org/synapse/issues/7118/events,https://github.com/matrix-org/synapse/pull/7118,585327313,MDExOlB1bGxSZXF1ZXN0MzkxNzQwODI2,7118,Allow server admins to define and enforce a password policy (MSC2000).,"{'login': 'dklimpel', 'id': 5740567, 'node_id': 'MDQ6VXNlcjU3NDA1Njc=', 'avatar_url': 'https://avatars2.githubusercontent.com/u/5740567?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/dklimpel', 'html_url': 'https://github.com/dklimpel', 'followers_url': 'https://api.github.com/users/dklimpel/followers', 'following_url': 'https://api.github.com/users/dklimpel/following{/other_user}', 'gists_url': 'https://api.github.com/users/dklimpel/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/dklimpel/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/dklimpel/subscriptions', 'organizations_url': 'https://api.github.com/users/dklimpel/orgs', 'repos_url': 'https://api.github.com/users/dklimpel/repos', 'events_url': 'https://api.github.com/users/dklimpel/events{/privacy}', 'received_events_url': 'https://api.github.com/users/dklimpel/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,0,2020-03-20T21:06:17Z,2020-03-26T21:09:07Z,2020-03-26T16:51:14Z,CONTRIBUTOR,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7118', 'html_url': 'https://github.com/matrix-org/synapse/pull/7118', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7118.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7118.patch'}","PR for: #5112
Code from #5214
* [x] Pull request is based on the develop branch
* [x] Pull request includes a [changelog file](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#changelog). The entry should:
- Be a short description of your change which makes sense to users. ""Fixed a bug that prevented receiving messages from other servers."" instead of ""Moved X method from `EventStore` to `EventWorkerStore`."".
- Use markdown where necessary, mostly for `code blocks`.
- End with either a period (.) or an exclamation mark (!).
- Start with a capital letter.
* [x] Pull request includes a [sign off](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#sign-off)
* [x] Code style is correct (run the [linters](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#code-style))
",
1170,https://api.github.com/repos/matrix-org/synapse/issues/7117,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7117/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7117/comments,https://api.github.com/repos/matrix-org/synapse/issues/7117/events,https://github.com/matrix-org/synapse/pull/7117,585136444,MDExOlB1bGxSZXF1ZXN0MzkxNTg2MTg2,7117,"Fix processing of `groups` stream, and use symbolic names for streams","{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,0,2020-03-20T15:13:54Z,2020-03-23T11:39:38Z,2020-03-23T11:39:37Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7117', 'html_url': 'https://github.com/matrix-org/synapse/pull/7117', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7117.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7117.patch'}","`groups` != `receipts`
Introduced in #2378",
1171,https://api.github.com/repos/matrix-org/synapse/issues/7116,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7116/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7116/comments,https://api.github.com/repos/matrix-org/synapse/issues/7116/events,https://github.com/matrix-org/synapse/pull/7116,585132404,MDExOlB1bGxSZXF1ZXN0MzkxNTgyOTcz,7116,Convert `*StreamRow` classes to inner classes,"{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,0,2020-03-20T15:07:47Z,2020-03-23T13:59:13Z,2020-03-23T13:59:11Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7116', 'html_url': 'https://github.com/matrix-org/synapse/pull/7116', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7116.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7116.patch'}","This just helps keep the rows closer to their streams, so that it's easier to
see what the format of each stream is.
",
1172,https://api.github.com/repos/matrix-org/synapse/issues/7115,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7115/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7115/comments,https://api.github.com/repos/matrix-org/synapse/issues/7115/events,https://github.com/matrix-org/synapse/pull/7115,585017579,MDExOlB1bGxSZXF1ZXN0MzkxNDkwMzUw,7115,Clean-up some auth/login REST code,"{'login': 'clokep', 'id': 517124, 'node_id': 'MDQ6VXNlcjUxNzEyNA==', 'avatar_url': 'https://avatars2.githubusercontent.com/u/517124?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/clokep', 'html_url': 'https://github.com/clokep', 'followers_url': 'https://api.github.com/users/clokep/followers', 'following_url': 'https://api.github.com/users/clokep/following{/other_user}', 'gists_url': 'https://api.github.com/users/clokep/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/clokep/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/clokep/subscriptions', 'organizations_url': 'https://api.github.com/users/clokep/orgs', 'repos_url': 'https://api.github.com/users/clokep/repos', 'events_url': 'https://api.github.com/users/clokep/events{/privacy}', 'received_events_url': 'https://api.github.com/users/clokep/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,2,2020-03-20T11:49:55Z,2020-03-20T20:22:49Z,2020-03-20T20:22:48Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7115', 'html_url': 'https://github.com/matrix-org/synapse/pull/7115', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7115.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7115.patch'}","I spun these changes out of #7102 since they're not really related to that and that diff is larger than I'd like (and it isn't done yet).
Two changes:
* De-duplicates some code in the auth REST code.
* Removes a couple of unused properties from the login REST code (these were added in b2bd54a2e31d9a248f73fadb184ae9b4cbdb49f9, but then the uses were factored out in 65c73cdfec1876a9fec2fd2c3a74923cd146fe0b).",
1173,https://api.github.com/repos/matrix-org/synapse/issues/7114,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7114/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7114/comments,https://api.github.com/repos/matrix-org/synapse/issues/7114/events,https://github.com/matrix-org/synapse/issues/7114,585010249,MDU6SXNzdWU1ODUwMTAyNDk=,7114,Internal Server Error on /groups//rooms endpoint,"{'login': 'bwindels', 'id': 274386, 'node_id': 'MDQ6VXNlcjI3NDM4Ng==', 'avatar_url': 'https://avatars1.githubusercontent.com/u/274386?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bwindels', 'html_url': 'https://github.com/bwindels', 'followers_url': 'https://api.github.com/users/bwindels/followers', 'following_url': 'https://api.github.com/users/bwindels/following{/other_user}', 'gists_url': 'https://api.github.com/users/bwindels/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/bwindels/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/bwindels/subscriptions', 'organizations_url': 'https://api.github.com/users/bwindels/orgs', 'repos_url': 'https://api.github.com/users/bwindels/repos', 'events_url': 'https://api.github.com/users/bwindels/events{/privacy}', 'received_events_url': 'https://api.github.com/users/bwindels/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,1,2020-03-20T11:35:56Z,2020-03-20T12:42:34Z,2020-03-20T12:42:33Z,MEMBER,,,"Reported at https://github.com/vector-im/riot-web/issues/12714#issuecomment-601633142
Synapse logs:
```
Mar 19 22:57:57 matrix matrix-synapse[6661]: 2020-03-19 22:57:57,852 - synapse.http.server - 110 - ERROR - GET-19535 - Failed handle request via 'GroupRoomServlet':
Mar 19 22:57:57 matrix matrix-synapse[6661]: Traceback (most recent call last):
Mar 19 22:57:57 matrix matrix-synapse[6661]: File ""/opt/venvs/matrix-synapse/lib/python3.6/site-packages/twisted/internet/defer.py"", line 1418, in _inlineCallbacks
Mar 19 22:57:57 matrix matrix-synapse[6661]: result = g.send(result)
Mar 19 22:57:57 matrix matrix-synapse[6661]: StopIteration: [{'room_id': '!KZwlWkhTSkUNDrquFg:chat.berline.rs', 'is_public': False}, {'room_id': '!LSJjLKsbWZqdvBuXJa:chat.berline.rs', 'is_public': False}, {'room_id': '!UJDBxLRJoRCeIlROCH:chat.berline.rs', 'is_public': False}, {'room_id': '!wJFqQvoWQaskEAMzoB:chat.berline.rs', 'is_public': False}, {'room_id': '!G
Mar 19 22:57:57 matrix matrix-synapse[6661]: During handling of the above exception, another exception occurred:
Mar 19 22:57:57 matrix matrix-synapse[6661]: Traceback (most recent call last):
Mar 19 22:57:57 matrix matrix-synapse[6661]: File ""/opt/venvs/matrix-synapse/lib/python3.6/site-packages/twisted/internet/defer.py"", line 1418, in _inlineCallbacks
Mar 19 22:57:57 matrix matrix-synapse[6661]: result = g.send(result)
Mar 19 22:57:57 matrix matrix-synapse[6661]: StopIteration: [{'room_id': '!KZwlWkhTSkUNDrquFg:chat.berline.rs', 'is_public': False}, {'room_id': '!LSJjLKsbWZqdvBuXJa:chat.berline.rs', 'is_public': False}, {'room_id': '!UJDBxLRJoRCeIlROCH:chat.berline.rs', 'is_public': False}, {'room_id': '!wJFqQvoWQaskEAMzoB:chat.berline.rs', 'is_public': False}, {'room_id': '!G
Mar 19 22:57:57 matrix matrix-synapse[6661]: During handling of the above exception, another exception occurred:
Mar 19 22:57:57 matrix matrix-synapse[6661]: Traceback (most recent call last):
Mar 19 22:57:57 matrix matrix-synapse[6661]: File ""/opt/venvs/matrix-synapse/lib/python3.6/site-packages/synapse/util/caches/descriptors.py"", line 438, in _wrapped
Mar 19 22:57:57 matrix matrix-synapse[6661]: cached_result_d = cache.get(cache_key, callback=invalidate_callback)
Mar 19 22:57:57 matrix matrix-synapse[6661]: File ""/opt/venvs/matrix-synapse/lib/python3.6/site-packages/synapse/util/caches/descriptors.py"", line 160, in get
Mar 19 22:57:57 matrix matrix-synapse[6661]: raise KeyError()
Mar 19 22:57:57 matrix matrix-synapse[6661]: KeyError
Mar 19 22:57:57 matrix matrix-synapse[6661]: During handling of the above exception, another exception occurred:
Mar 19 22:57:57 matrix matrix-synapse[6661]: Traceback (most recent call last):
Mar 19 22:57:57 matrix matrix-synapse[6661]: File ""/opt/venvs/matrix-synapse/lib/python3.6/site-packages/synapse/http/server.py"", line 78, in wrapped_request_handler
Mar 19 22:57:57 matrix matrix-synapse[6661]: await h(self, request)
Mar 19 22:57:57 matrix matrix-synapse[6661]: File ""/opt/venvs/matrix-synapse/lib/python3.6/site-packages/synapse/http/server.py"", line 331, in _async_render
Mar 19 22:57:57 matrix matrix-synapse[6661]: callback_return = await callback_return
Mar 19 22:57:57 matrix matrix-synapse[6661]: File ""/opt/venvs/matrix-synapse/lib/python3.6/site-packages/synapse/rest/client/v2_alpha/groups.py"", line 329, in on_GET
Mar 19 22:57:57 matrix matrix-synapse[6661]: group_id, requester_user_id
Mar 19 22:57:57 matrix matrix-synapse[6661]: AttributeError: 'NoneType' object has no attribute 'content'
```",
1174,https://api.github.com/repos/matrix-org/synapse/issues/7113,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7113/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7113/comments,https://api.github.com/repos/matrix-org/synapse/issues/7113/events,https://github.com/matrix-org/synapse/issues/7113,584987801,MDU6SXNzdWU1ODQ5ODc4MDE=,7113,"Pusher stops pushing, with lots of DNSLookupFailed errors","{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}","[{'id': 600557921, 'node_id': 'MDU6TGFiZWw2MDA1NTc5MjE=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/performance', 'name': 'performance', 'color': 'fef2c0', 'default': False, 'description': None}, {'id': 477045805, 'node_id': 'MDU6TGFiZWw0NzcwNDU4MDU=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/push', 'name': 'push', 'color': 'ededed', 'default': False, 'description': None}]",open,False,,[],,9,2020-03-20T10:52:59Z,2020-08-28T23:07:40Z,,MEMBER,,,"Our pusher process got behind. A couple of hours after it started to catch up, almost all pushes started failing:
![image](https://user-images.githubusercontent.com/1389908/77156873-31206000-6a98-11ea-8855-6102545355fa.png)
Inspection of logs showed that they were failing with DNSLookupFailed errors:
```
2020-03-19 11:11:27,083 - synapse.http.client - 281 - INFO - httppush.process-57923 - Sending request POST http://10.103.0.7/_matrix/push/v1/notify
2020-03-19 11:12:28,647 - synapse.http.client - 328 - INFO - httppush.process-57923 - Error sending request to POST http://10.103.0.7/_matrix/push/v1/notify: DNSLookupError Couldn't find the hostname '10.103.0.7'
2020-03-19 11:12:28,647 - synapse.push.httppusher - 391 - WARNING - httppush.process-57923 - Failed to push event to : DNS lookup failed: Couldn't find the hostname '10.103.0.7'.
2020-03-19 11:12:32,225 - synapse.push.httppusher - 276 - INFO - httppush.process-57923 - Push failed: delaying for 1s
```
",
1175,https://api.github.com/repos/matrix-org/synapse/issues/7112,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7112/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7112/comments,https://api.github.com/repos/matrix-org/synapse/issues/7112/events,https://github.com/matrix-org/synapse/issues/7112,584853692,MDU6SXNzdWU1ODQ4NTM2OTI=,7112,Can the synapse run on Raspberry Pi?,"{'login': 'wjhtinger', 'id': 1773284, 'node_id': 'MDQ6VXNlcjE3NzMyODQ=', 'avatar_url': 'https://avatars0.githubusercontent.com/u/1773284?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/wjhtinger', 'html_url': 'https://github.com/wjhtinger', 'followers_url': 'https://api.github.com/users/wjhtinger/followers', 'following_url': 'https://api.github.com/users/wjhtinger/following{/other_user}', 'gists_url': 'https://api.github.com/users/wjhtinger/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/wjhtinger/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/wjhtinger/subscriptions', 'organizations_url': 'https://api.github.com/users/wjhtinger/orgs', 'repos_url': 'https://api.github.com/users/wjhtinger/repos', 'events_url': 'https://api.github.com/users/wjhtinger/events{/privacy}', 'received_events_url': 'https://api.github.com/users/wjhtinger/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,1,2020-03-20T05:32:20Z,2020-03-20T09:11:21Z,2020-03-20T09:11:21Z,NONE,,,"I want to run synapse on Raspberry Pi, is there any guide?",
1176,https://api.github.com/repos/matrix-org/synapse/issues/7111,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7111/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7111/comments,https://api.github.com/repos/matrix-org/synapse/issues/7111/events,https://github.com/matrix-org/synapse/issues/7111,584807250,MDU6SXNzdWU1ODQ4MDcyNTA=,7111,Failed to handle edu 'm.receipt',"{'login': 'dajohi', 'id': 3308193, 'node_id': 'MDQ6VXNlcjMzMDgxOTM=', 'avatar_url': 'https://avatars0.githubusercontent.com/u/3308193?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/dajohi', 'html_url': 'https://github.com/dajohi', 'followers_url': 'https://api.github.com/users/dajohi/followers', 'following_url': 'https://api.github.com/users/dajohi/following{/other_user}', 'gists_url': 'https://api.github.com/users/dajohi/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/dajohi/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/dajohi/subscriptions', 'organizations_url': 'https://api.github.com/users/dajohi/orgs', 'repos_url': 'https://api.github.com/users/dajohi/repos', 'events_url': 'https://api.github.com/users/dajohi/events{/privacy}', 'received_events_url': 'https://api.github.com/users/dajohi/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,1,2020-03-20T02:36:59Z,2020-03-20T12:36:07Z,2020-03-20T12:36:07Z,NONE,,,"
### Description
```
2020-03-20 02:32:34,548 - synapse.federation.federation_server - 832 - ERROR - PUT-75910- Failed to handle edu 'm.receipt'
Traceback (most recent call last):
File ""/usr/local/lib/python3.7/site-packages/twisted/internet/defer.py"", line 1418, in _inlineCallbacks
result = g.send(result)
StopIteration: 1584650095267
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File ""/usr/local/lib/python3.7/site-packages/synapse/federation/federation_server.py"", line 828, in on_edu
await handler(origin, content)
File ""/usr/local/lib/python3.7/site-packages/synapse/handlers/receipts.py"", line 65, in _received_remote_receipt
await self._handle_new_receipts(receipts)
File ""/usr/local/lib/python3.7/site-packages/synapse/handlers/receipts.py"", line 79, in _handle_new_receipts
receipt.data,
File ""/usr/local/lib/python3.7/site-packages/twisted/internet/defer.py"", line 1416, in _inlineCallbacks
result = result.throwExceptionIntoGenerator(g)
File ""/usr/local/lib/python3.7/site-packages/twisted/python/failure.py"", line 512, in throwExceptionIntoGenerator
return g.throw(self.type, self.value, self.tb)
File ""/usr/local/lib/python3.7/site-packages/synapse/storage/data_stores/main/receipts.py"", line 473, in insert_receipt
stream_id=stream_id,
File ""/usr/local/lib/python3.7/site-packages/twisted/internet/defer.py"", line 1418, in _inlineCallbacks
result = g.send(result)
File ""/usr/local/lib/python3.7/site-packages/synapse/storage/database.py"", line 499, in runInteraction
after_callback(*after_args, **after_kwargs)
File ""/usr/local/lib/python3.7/site-packages/synapse/storage/data_stores/main/receipts.py"", line 310, in _invalidate_get_users_with_receipts_in_room
if res and user_id in res:
TypeError: argument of type 'ObservableDeferred' is not iterable
2020-03-20 02:32:34,841 - synapse.metrics - 462 - INFO - - Collecting gc 1
```
### Steps to reproduce
upgraded from 1.3.1 to 1.11.1
### Version information
- **Homeserver**:
matrix.decred.org
1.11.1
docker
linux
",
1177,https://api.github.com/repos/matrix-org/synapse/issues/7110,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7110/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7110/comments,https://api.github.com/repos/matrix-org/synapse/issues/7110/events,https://github.com/matrix-org/synapse/pull/7110,584679747,MDExOlB1bGxSZXF1ZXN0MzkxMjIxMTM4,7110,Convert some of the media REST code to async/await,"{'login': 'clokep', 'id': 517124, 'node_id': 'MDQ6VXNlcjUxNzEyNA==', 'avatar_url': 'https://avatars2.githubusercontent.com/u/517124?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/clokep', 'html_url': 'https://github.com/clokep', 'followers_url': 'https://api.github.com/users/clokep/followers', 'following_url': 'https://api.github.com/users/clokep/following{/other_user}', 'gists_url': 'https://api.github.com/users/clokep/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/clokep/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/clokep/subscriptions', 'organizations_url': 'https://api.github.com/users/clokep/orgs', 'repos_url': 'https://api.github.com/users/clokep/repos', 'events_url': 'https://api.github.com/users/clokep/events{/privacy}', 'received_events_url': 'https://api.github.com/users/clokep/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,0,2020-03-19T20:26:52Z,2020-03-20T11:20:04Z,2020-03-20T11:20:03Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7110', 'html_url': 'https://github.com/matrix-org/synapse/pull/7110', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7110.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7110.patch'}","Partially converts the `synapse.rest.media` to async/await. (It doesn't do `synapse.rest.media.v1.media_storage` or `_base` -- those are a bit more complicated as far as I can tell.)
",
1178,https://api.github.com/repos/matrix-org/synapse/issues/7109,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7109/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7109/comments,https://api.github.com/repos/matrix-org/synapse/issues/7109/events,https://github.com/matrix-org/synapse/pull/7109,584547302,MDExOlB1bGxSZXF1ZXN0MzkxMTEzNTUw,7109,Update the error code when a canonical alias that does not exist is used,"{'login': 'clokep', 'id': 517124, 'node_id': 'MDQ6VXNlcjUxNzEyNA==', 'avatar_url': 'https://avatars2.githubusercontent.com/u/517124?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/clokep', 'html_url': 'https://github.com/clokep', 'followers_url': 'https://api.github.com/users/clokep/followers', 'following_url': 'https://api.github.com/users/clokep/following{/other_user}', 'gists_url': 'https://api.github.com/users/clokep/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/clokep/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/clokep/subscriptions', 'organizations_url': 'https://api.github.com/users/clokep/orgs', 'repos_url': 'https://api.github.com/users/clokep/repos', 'events_url': 'https://api.github.com/users/clokep/events{/privacy}', 'received_events_url': 'https://api.github.com/users/clokep/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,0,2020-03-19T16:40:50Z,2020-03-23T19:21:56Z,2020-03-23T19:21:55Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7109', 'html_url': 'https://github.com/matrix-org/synapse/pull/7109', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7109.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7109.patch'}","Per the clarification in the spec (see https://github.com/matrix-org/matrix-doc/pull/2432#issuecomment-601242488) the situation of an alias not existing should be treated the same as an alias that points to the wrong room.
Fixes #7105
See updated SyTests: matrix-org/sytest#837",
1179,https://api.github.com/repos/matrix-org/synapse/issues/7108,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7108/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7108/comments,https://api.github.com/repos/matrix-org/synapse/issues/7108/events,https://github.com/matrix-org/synapse/issues/7108,584512673,MDU6SXNzdWU1ODQ1MTI2NzM=,7108,server_name is not correctly validated for join requests,"{'login': 'grinapo', 'id': 1056054, 'node_id': 'MDQ6VXNlcjEwNTYwNTQ=', 'avatar_url': 'https://avatars0.githubusercontent.com/u/1056054?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/grinapo', 'html_url': 'https://github.com/grinapo', 'followers_url': 'https://api.github.com/users/grinapo/followers', 'following_url': 'https://api.github.com/users/grinapo/following{/other_user}', 'gists_url': 'https://api.github.com/users/grinapo/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/grinapo/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/grinapo/subscriptions', 'organizations_url': 'https://api.github.com/users/grinapo/orgs', 'repos_url': 'https://api.github.com/users/grinapo/repos', 'events_url': 'https://api.github.com/users/grinapo/events{/privacy}', 'received_events_url': 'https://api.github.com/users/grinapo/received_events', 'type': 'User', 'site_admin': False}","[{'id': 121086029, 'node_id': 'MDU6TGFiZWwxMjEwODYwMjk=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/bug', 'name': 'bug', 'color': 'fc2929', 'default': True, 'description': None}, {'id': 477043173, 'node_id': 'MDU6TGFiZWw0NzcwNDMxNzM=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/p2', 'name': 'p2', 'color': 'fbca04', 'default': False, 'description': None}, {'id': 1920863622, 'node_id': 'MDU6TGFiZWwxOTIwODYzNjIy', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/validation', 'name': 'validation', 'color': 'f49d6e', 'default': False, 'description': 'lack of parameter validation'}]",open,False,,[],,5,2020-03-19T15:52:30Z,2020-04-28T12:12:43Z,,NONE,,,"### Description
Caused #4891 but is a problem by itself, too.
```
2020-03-19 16:02:39,463 - synapse.http.matrixfederationclient - 491 - WARNING - POST-591111- {GET-O-12659} [!NEdKsYgzazXzpqqeBT:grin.hu] Request failed: GET matrix://!NEdKsYgzazXzpqqeBT:grin.hu/_matrix/federation/v1/make_join/%21NEdKsYgzazXzpqqeBT%3Agrin.hu/%40grin%3Agrin.hu?ver=1&ver=2&ver=3&ver=4&ver=5&ver=org.matrix.msc2260: ValueError(""invalid literal for int() with base 10: b'grin.hu'"")
2020-03-19 16:02:39,463 - synapse.util.retryutils - 218 - INFO - POST-591111- Connection to !NEdKsYgzazXzpqqeBT:grin.hu was unsuccessful ((Failed to send request: ValueError: invalid literal for int() with base 10: b'grin.hu')); backoff now 600000
2020-03-19 16:02:39,464 - synapse.federation.federation_client - 421 - WARNING - POST-591111- Failed to make_join via !NEdKsYgzazXzpqqeBT:grin.hu
2020-03-19 16:02:39,465 - synapse.http.server - 81 - INFO - POST-591111- SynapseError: 502 - Failed to make_join via any server
```
### Steps to reproduce
I don't know, I only became aware of this when it completely broke communities.
### Version information
- **Homeserver**:
matrix.grin.hu
- **Version**:
v1.11.1-1 (debian)
- **Install method**:
debian experimental repo.
- **Platform**:
Debian/Sid/x64
",
1180,https://api.github.com/repos/matrix-org/synapse/issues/7107,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7107/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7107/comments,https://api.github.com/repos/matrix-org/synapse/issues/7107/events,https://github.com/matrix-org/synapse/pull/7107,584405622,MDExOlB1bGxSZXF1ZXN0MzkwOTk4MTM2,7107,Update pre-built package name for FreeBSD,"{'login': 'staktrace', 'id': 485789, 'node_id': 'MDQ6VXNlcjQ4NTc4OQ==', 'avatar_url': 'https://avatars3.githubusercontent.com/u/485789?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/staktrace', 'html_url': 'https://github.com/staktrace', 'followers_url': 'https://api.github.com/users/staktrace/followers', 'following_url': 'https://api.github.com/users/staktrace/following{/other_user}', 'gists_url': 'https://api.github.com/users/staktrace/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/staktrace/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/staktrace/subscriptions', 'organizations_url': 'https://api.github.com/users/staktrace/orgs', 'repos_url': 'https://api.github.com/users/staktrace/repos', 'events_url': 'https://api.github.com/users/staktrace/events{/privacy}', 'received_events_url': 'https://api.github.com/users/staktrace/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,0,2020-03-19T13:18:12Z,2020-03-23T15:31:03Z,2020-03-23T15:31:03Z,CONTRIBUTOR,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7107', 'html_url': 'https://github.com/matrix-org/synapse/pull/7107', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7107.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7107.patch'}","Signed-off-by: Kartikaya Gupta
### Pull Request Checklist
* [X] Pull request is based on the develop branch
* [x] Pull request includes a [changelog file](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#changelog). The entry should:
- Be a short description of your change which makes sense to users. ""Fixed a bug that prevented receiving messages from other servers."" instead of ""Moved X method from `EventStore` to `EventWorkerStore`."".
- Use markdown where necessary, mostly for `code blocks`.
- End with either a period (.) or an exclamation mark (!).
- Start with a capital letter.
* [X] Pull request includes a [sign off](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#sign-off)
* [X] Code style is correct (run the [linters](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#code-style))
",
1181,https://api.github.com/repos/matrix-org/synapse/issues/7106,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7106/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7106/comments,https://api.github.com/repos/matrix-org/synapse/issues/7106/events,https://github.com/matrix-org/synapse/pull/7106,584307235,MDExOlB1bGxSZXF1ZXN0MzkwOTE3MDU4,7106,Fix concurrent modification errors in pusher metrics,"{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,0,2020-03-19T10:23:30Z,2020-03-19T10:28:51Z,2020-03-19T10:28:50Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7106', 'html_url': 'https://github.com/matrix-org/synapse/pull/7106', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7106.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7106.patch'}",add a lock to try to make this metric actually work,
1182,https://api.github.com/repos/matrix-org/synapse/issues/7105,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7105/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7105/comments,https://api.github.com/repos/matrix-org/synapse/issues/7105/events,https://github.com/matrix-org/synapse/issues/7105,584287084,MDU6SXNzdWU1ODQyODcwODQ=,7105,we seem to be returning the wrong error code when adding an undefined alias to canonical_alias,"{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,"{'login': 'clokep', 'id': 517124, 'node_id': 'MDQ6VXNlcjUxNzEyNA==', 'avatar_url': 'https://avatars2.githubusercontent.com/u/517124?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/clokep', 'html_url': 'https://github.com/clokep', 'followers_url': 'https://api.github.com/users/clokep/followers', 'following_url': 'https://api.github.com/users/clokep/following{/other_user}', 'gists_url': 'https://api.github.com/users/clokep/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/clokep/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/clokep/subscriptions', 'organizations_url': 'https://api.github.com/users/clokep/orgs', 'repos_url': 'https://api.github.com/users/clokep/repos', 'events_url': 'https://api.github.com/users/clokep/events{/privacy}', 'received_events_url': 'https://api.github.com/users/clokep/received_events', 'type': 'User', 'site_admin': False}","[{'login': 'clokep', 'id': 517124, 'node_id': 'MDQ6VXNlcjUxNzEyNA==', 'avatar_url': 'https://avatars2.githubusercontent.com/u/517124?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/clokep', 'html_url': 'https://github.com/clokep', 'followers_url': 'https://api.github.com/users/clokep/followers', 'following_url': 'https://api.github.com/users/clokep/following{/other_user}', 'gists_url': 'https://api.github.com/users/clokep/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/clokep/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/clokep/subscriptions', 'organizations_url': 'https://api.github.com/users/clokep/orgs', 'repos_url': 'https://api.github.com/users/clokep/repos', 'events_url': 'https://api.github.com/users/clokep/events{/privacy}', 'received_events_url': 'https://api.github.com/users/clokep/received_events', 'type': 'User', 'site_admin': False}]",,3,2020-03-19T09:48:30Z,2020-03-26T14:14:26Z,2020-03-26T14:14:26Z,MEMBER,,,"we're returning a 404 with `{errcode: ""M_NOT_FOUND"", error: ""Room alias #megolm:sw1v.org not found""}`; https://github.com/matrix-org/matrix-doc/pull/2432#discussion_r388457807 suggests a different conclusion.
The upshot is that the error message in riot is unhelpful:
![Peek 2020-03-19 09-38](https://user-images.githubusercontent.com/1389908/77053780-c18e7000-69c6-11ea-8b5b-ee6ba3bfc63e.gif)
",
1183,https://api.github.com/repos/matrix-org/synapse/issues/7104,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7104/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7104/comments,https://api.github.com/repos/matrix-org/synapse/issues/7104/events,https://github.com/matrix-org/synapse/pull/7104,583921781,MDExOlB1bGxSZXF1ZXN0MzkwNTk2Njc1,7104,Move pusherpool startup into _base.setup,"{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,0,2020-03-18T18:25:05Z,2020-03-19T09:48:47Z,2020-03-19T09:48:46Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7104', 'html_url': 'https://github.com/matrix-org/synapse/pull/7104', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7104.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7104.patch'}","This should be safe to do on all workers/masters because it is guarded by
a config option which will ensure it is only actually done on the worker
assigned as a pusher.
Hopefully fixes #7075.",
1184,https://api.github.com/repos/matrix-org/synapse/issues/7103,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7103/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7103/comments,https://api.github.com/repos/matrix-org/synapse/issues/7103/events,https://github.com/matrix-org/synapse/pull/7103,583918654,MDExOlB1bGxSZXF1ZXN0MzkwNTk0MTM2,7103,Add prometheus metrics for the number of active pushers,"{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,2,2020-03-18T18:19:32Z,2020-03-19T10:00:26Z,2020-03-19T10:00:25Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7103', 'html_url': 'https://github.com/matrix-org/synapse/pull/7103', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7103.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7103.patch'}",,
1185,https://api.github.com/repos/matrix-org/synapse/issues/7102,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7102/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7102/comments,https://api.github.com/repos/matrix-org/synapse/issues/7102/events,https://github.com/matrix-org/synapse/pull/7102,583893515,MDExOlB1bGxSZXF1ZXN0MzkwNTczMTEx,7102,Support SAML in the user interactive authentication workflow.,"{'login': 'clokep', 'id': 517124, 'node_id': 'MDQ6VXNlcjUxNzEyNA==', 'avatar_url': 'https://avatars2.githubusercontent.com/u/517124?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/clokep', 'html_url': 'https://github.com/clokep', 'followers_url': 'https://api.github.com/users/clokep/followers', 'following_url': 'https://api.github.com/users/clokep/following{/other_user}', 'gists_url': 'https://api.github.com/users/clokep/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/clokep/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/clokep/subscriptions', 'organizations_url': 'https://api.github.com/users/clokep/orgs', 'repos_url': 'https://api.github.com/users/clokep/repos', 'events_url': 'https://api.github.com/users/clokep/events{/privacy}', 'received_events_url': 'https://api.github.com/users/clokep/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,8,2020-03-18T17:35:47Z,2020-04-01T12:48:02Z,2020-04-01T12:48:00Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7102', 'html_url': 'https://github.com/matrix-org/synapse/pull/7102', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7102.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7102.patch'}","This aims to accomplish a portion of #5667:
* Update `validate_user_via_ui_auth` to return `m.login.sso` for homeservers which use sso login
* Implement a handler for `/_matrix/client/r0/auth/m.login.sso/fallback/web` which shows a confirmation page, and redirects to the SAML server.
* Update the SAML return page handlers to behave differently for a UI auth flow, and:
* Update the UI Auth session
* Return the fallback completion page
## TODO
* [x] Remove any debug statements.
* [x] Handle any other TODO comments.
* [x] Add validation of session + user information.
* [x] Think about redirect URLs.
* [x] Use a Jinja template for the confirmation page.
* [x] Fix unit tests.
* [x] SyTests? See matrix-org/sytest#845
~~This is currently based on #7115.~~
## Testing
### SAML
I was testing SAML by first generally following the directions at [docs/dev/saml.md](https://github.com/matrix-org/synapse/blob/master/docs/dev/saml.md) to create a user. Note that I also had to set the following in the config:
```yaml
public_baseurl: http://localhost:8080/
```
Then to test the UI Auth workflow:
1. Add a debug line so you can see what UI-Auth sessions are getting created in Synapse:
```diff
diff --git a/synapse/handlers/auth.py b/synapse/handlers/auth.py
--- a/synapse/handlers/auth.py
+++ b/synapse/handlers/auth.py
@@ -494,6 +494,7 @@ class AuthHandler(BaseHandler):
while session_id is None or session_id in self.sessions:
session_id = stringutils.random_string(24)
self.sessions[session_id] = {""id"": session_id}
+ print(""Created new session: %s"" % session_id)
return self.sessions[session_id]
```
2. Restart Synapse to pick up the change.
3. Go to the ""User Details"" page on https://capriza.github.io/samling/samling.html and click ""Logout"" (weirdly this doesn't show anything, refresh the page to ensure you're logged out).
4. Perform an operation that dumps you into the UI Auth workflow (e.g. deleting a device).
5. Check out the logs to get the session ID.
6. Browse to http://localhost:8080/_matrix/client/r0/auth/org.matrix.login.sso/fallback/web?session=
7. Read this, go through the SSO workflow.
8. You should end up at a success page telling you to close the window.
Unfortunately at this point you're stuck since the client doesn't know the auth has completed.",
1186,https://api.github.com/repos/matrix-org/synapse/issues/7101,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7101/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7101/comments,https://api.github.com/repos/matrix-org/synapse/issues/7101/events,https://github.com/matrix-org/synapse/issues/7101,583681233,MDU6SXNzdWU1ODM2ODEyMzM=,7101,Follow-up work to new alias semantics (MSC2432),"{'login': 'clokep', 'id': 517124, 'node_id': 'MDQ6VXNlcjUxNzEyNA==', 'avatar_url': 'https://avatars2.githubusercontent.com/u/517124?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/clokep', 'html_url': 'https://github.com/clokep', 'followers_url': 'https://api.github.com/users/clokep/followers', 'following_url': 'https://api.github.com/users/clokep/following{/other_user}', 'gists_url': 'https://api.github.com/users/clokep/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/clokep/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/clokep/subscriptions', 'organizations_url': 'https://api.github.com/users/clokep/orgs', 'repos_url': 'https://api.github.com/users/clokep/repos', 'events_url': 'https://api.github.com/users/clokep/events{/privacy}', 'received_events_url': 'https://api.github.com/users/clokep/received_events', 'type': 'User', 'site_admin': False}","[{'id': 477043174, 'node_id': 'MDU6TGFiZWw0NzcwNDMxNzQ=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/feature', 'name': 'feature', 'color': 'bfd4f2', 'default': False, 'description': None}]",open,False,,[],,0,2020-03-18T12:07:15Z,2020-03-18T12:07:15Z,,MEMBER,,,"While working on #6898 the following work was punted until the need for them is demonstrated:
* Extend GET /_matrix/client/r0/rooms/{roomId}/aliases to allow passing in the name of a remote server to query over federation.
* Add a federation API which can be called by servers with mods in the room, to request that an alias be removed
",
1187,https://api.github.com/repos/matrix-org/synapse/issues/7100,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7100/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7100/comments,https://api.github.com/repos/matrix-org/synapse/issues/7100/events,https://github.com/matrix-org/synapse/issues/7100,583639771,MDU6SXNzdWU1ODM2Mzk3NzE=,7100,Push notifications `unread count` is always set to 1.,"{'login': 'lampholder', 'id': 1922197, 'node_id': 'MDQ6VXNlcjE5MjIxOTc=', 'avatar_url': 'https://avatars2.githubusercontent.com/u/1922197?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/lampholder', 'html_url': 'https://github.com/lampholder', 'followers_url': 'https://api.github.com/users/lampholder/followers', 'following_url': 'https://api.github.com/users/lampholder/following{/other_user}', 'gists_url': 'https://api.github.com/users/lampholder/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/lampholder/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/lampholder/subscriptions', 'organizations_url': 'https://api.github.com/users/lampholder/orgs', 'repos_url': 'https://api.github.com/users/lampholder/repos', 'events_url': 'https://api.github.com/users/lampholder/events{/privacy}', 'received_events_url': 'https://api.github.com/users/lampholder/received_events', 'type': 'User', 'site_admin': False}","[{'id': 121086029, 'node_id': 'MDU6TGFiZWwxMjEwODYwMjk=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/bug', 'name': 'bug', 'color': 'fc2929', 'default': True, 'description': None}, {'id': 1311133228, 'node_id': 'MDU6TGFiZWwxMzExMTMzMjI4', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/info-needed', 'name': 'info-needed', 'color': 'a1e8ea', 'default': False, 'description': ''}, {'id': 477045805, 'node_id': 'MDU6TGFiZWw0NzcwNDU4MDU=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/push', 'name': 'push', 'color': 'ededed', 'default': False, 'description': None}]",closed,False,"{'login': 'anoadragon453', 'id': 1342360, 'node_id': 'MDQ6VXNlcjEzNDIzNjA=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1342360?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/anoadragon453', 'html_url': 'https://github.com/anoadragon453', 'followers_url': 'https://api.github.com/users/anoadragon453/followers', 'following_url': 'https://api.github.com/users/anoadragon453/following{/other_user}', 'gists_url': 'https://api.github.com/users/anoadragon453/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/anoadragon453/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/anoadragon453/subscriptions', 'organizations_url': 'https://api.github.com/users/anoadragon453/orgs', 'repos_url': 'https://api.github.com/users/anoadragon453/repos', 'events_url': 'https://api.github.com/users/anoadragon453/events{/privacy}', 'received_events_url': 'https://api.github.com/users/anoadragon453/received_events', 'type': 'User', 'site_admin': False}","[{'login': 'anoadragon453', 'id': 1342360, 'node_id': 'MDQ6VXNlcjEzNDIzNjA=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1342360?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/anoadragon453', 'html_url': 'https://github.com/anoadragon453', 'followers_url': 'https://api.github.com/users/anoadragon453/followers', 'following_url': 'https://api.github.com/users/anoadragon453/following{/other_user}', 'gists_url': 'https://api.github.com/users/anoadragon453/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/anoadragon453/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/anoadragon453/subscriptions', 'organizations_url': 'https://api.github.com/users/anoadragon453/orgs', 'repos_url': 'https://api.github.com/users/anoadragon453/repos', 'events_url': 'https://api.github.com/users/anoadragon453/events{/privacy}', 'received_events_url': 'https://api.github.com/users/anoadragon453/received_events', 'type': 'User', 'site_admin': False}]",,13,2020-03-18T10:51:24Z,2020-04-20T15:18:59Z,2020-04-20T15:18:59Z,MEMBER,,,"This was reported by a third party and I _believe_ verified in a discussion I had with somebody from the mobile team (I didn't get around to filing an issue before and I'm afraid I forgot who I discussed this with).
It seems that this doesn't cause any problem for the Riot mobile apps because they don't rely on this value.
I didn't know whether this was a Sygnal or Synapse issue, so I've filed it here :)",
1188,https://api.github.com/repos/matrix-org/synapse/issues/7099,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7099/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7099/comments,https://api.github.com/repos/matrix-org/synapse/issues/7099/events,https://github.com/matrix-org/synapse/issues/7099,583588540,MDU6SXNzdWU1ODM1ODg1NDA=,7099,Messages not being sent over federation,"{'login': 'ErrorProne', 'id': 541410, 'node_id': 'MDQ6VXNlcjU0MTQxMA==', 'avatar_url': 'https://avatars3.githubusercontent.com/u/541410?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/ErrorProne', 'html_url': 'https://github.com/ErrorProne', 'followers_url': 'https://api.github.com/users/ErrorProne/followers', 'following_url': 'https://api.github.com/users/ErrorProne/following{/other_user}', 'gists_url': 'https://api.github.com/users/ErrorProne/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/ErrorProne/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/ErrorProne/subscriptions', 'organizations_url': 'https://api.github.com/users/ErrorProne/orgs', 'repos_url': 'https://api.github.com/users/ErrorProne/repos', 'events_url': 'https://api.github.com/users/ErrorProne/events{/privacy}', 'received_events_url': 'https://api.github.com/users/ErrorProne/received_events', 'type': 'User', 'site_admin': False}","[{'id': 121086029, 'node_id': 'MDU6TGFiZWwxMjEwODYwMjk=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/bug', 'name': 'bug', 'color': 'fc2929', 'default': True, 'description': None}, {'id': 828666468, 'node_id': 'MDU6TGFiZWw4Mjg2NjY0Njg=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/release%20blocker', 'name': 'release blocker', 'color': '880000', 'default': False, 'description': None}]",closed,False,"{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}","[{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}]",,20,2020-03-18T09:26:46Z,2020-05-14T11:11:48Z,2020-05-14T11:11:48Z,NONE,,,"### Description
I'll try to do this as exact as I'm able to in reverse.
After upgrading our matrix server running on ubuntu 18.04 to 1.11.1+bionic1 we did not receive any messages from servers running on older instances (only in 1:1 chats, groups have been working fine).
We are explicitly talking with a another company running a matrix instance and a freelancer and his own setup.
Both problems were solved after upgrading their versions to the matrix synapse 1.11.1 version. But since at least one party was running 1.11.0+bionic1 before, it looks like the bug has been introduced in the patch release.
All messages and presence updates going from 1.11.1+bionic1 to the other sides went through without problems. But nothing the other way around.
One major pain point was that we discovered this by getting suspicious that some people did not respond in time and thus tried other communication channels. So the users where totally unaware of this.
A last note: As mentioned bringing all instances to 1.11.1 (or the latest docker image) solved it, no message went missing! As soon as the other parties wrote a new message all the missing ones got redelivered.
**Edit**: As far as I can tell it did not matter on which side the 1:1 chatroom has been initially created.
### Steps to reproduce
(I did not re-test this, but this should result in the problematic setup)
- Connect two matrix servers running 1.11.0+bionic1
- Create two 1:1 chats, one initialized by each side
- Upgrade on instance to 1.11.1+bionic1
You should now only be able to send 1:1 messages from 1.11.1+bionic1 to 1.11.0+bionic1 but not the other way around (At least using any riot the user won't get any feedback about this. I'll write an issue for that project later).
I could not find any suspicious log entries on our 1.11.1 server. But I've requested logs from the other side, maybe we can find something there.
### Version information
- apt package installed: matrix-synapse-py3 1.11.1+bionic1 amd64
- Not exactly sure about the other sides. One had matrix-synapse-py3 1.11.0+bionic1 apt
- The other party had the docker container setup using matrixdotorg/synapse (version before upgrade not known)
",
1189,https://api.github.com/repos/matrix-org/synapse/issues/7098,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7098/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7098/comments,https://api.github.com/repos/matrix-org/synapse/issues/7098/events,https://github.com/matrix-org/synapse/issues/7098,583469647,MDU6SXNzdWU1ODM0Njk2NDc=,7098,OpenSSL Error about Certificated Authenticity Breaking Federation,"{'login': 'JonQuan1', 'id': 32870251, 'node_id': 'MDQ6VXNlcjMyODcwMjUx', 'avatar_url': 'https://avatars2.githubusercontent.com/u/32870251?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/JonQuan1', 'html_url': 'https://github.com/JonQuan1', 'followers_url': 'https://api.github.com/users/JonQuan1/followers', 'following_url': 'https://api.github.com/users/JonQuan1/following{/other_user}', 'gists_url': 'https://api.github.com/users/JonQuan1/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/JonQuan1/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/JonQuan1/subscriptions', 'organizations_url': 'https://api.github.com/users/JonQuan1/orgs', 'repos_url': 'https://api.github.com/users/JonQuan1/repos', 'events_url': 'https://api.github.com/users/JonQuan1/events{/privacy}', 'received_events_url': 'https://api.github.com/users/JonQuan1/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,2,2020-03-18T05:07:52Z,2020-03-18T11:36:09Z,2020-03-18T11:36:08Z,NONE,,,"
### Description
I am unable to federate with any instance on the Matrix network. My system is fully up to date, and all my SSL certificates are still valid
When looking at the logs I notice this error repeated over and over:
```
Mar 17 23:36:46 archserver synapse[1269341]: 2020-03-17 23:36:46,242 - synapse.http.matrixfederationclient - 485 - WARNING - renew_attestations-15 - {POST-O-137} [[cencored]] Request failed: POST matrix://[cencored]: RequestTransmissionFailed:[Error([('SSL routines', 'tls_process_server_certificate', 'certificate verify failed')])]
Mar 17 23:36:46 archserver synapse[1269341]: 2020-03-17 23:36:46,242 - synapse.groups.attestations - 202 - WARNING - renew_attestations-15 - Failed to renew attestation of '@[cencored]' in '+[cencored]': Failed to send request: RequestTransmissionFailed: []
```
### Steps to reproduce
I don't know exactly what caused this bug, it just spontaneously occurred
### Version information
- ** Only My Homeserver**:
- **Version**:
1.11.0-1
- **Install method**:
Followed the Arch Wiki
- **Platform**:
Arch Linux on a Dell OptiPlex 7010
",
1190,https://api.github.com/repos/matrix-org/synapse/issues/7097,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7097/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7097/comments,https://api.github.com/repos/matrix-org/synapse/issues/7097/events,https://github.com/matrix-org/synapse/issues/7097,583328676,MDU6SXNzdWU1ODMzMjg2NzY=,7097,blocked room in group_rooms blocks listing of the community room list,"{'login': 'airblag', 'id': 24829620, 'node_id': 'MDQ6VXNlcjI0ODI5NjIw', 'avatar_url': 'https://avatars1.githubusercontent.com/u/24829620?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/airblag', 'html_url': 'https://github.com/airblag', 'followers_url': 'https://api.github.com/users/airblag/followers', 'following_url': 'https://api.github.com/users/airblag/following{/other_user}', 'gists_url': 'https://api.github.com/users/airblag/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/airblag/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/airblag/subscriptions', 'organizations_url': 'https://api.github.com/users/airblag/orgs', 'repos_url': 'https://api.github.com/users/airblag/repos', 'events_url': 'https://api.github.com/users/airblag/events{/privacy}', 'received_events_url': 'https://api.github.com/users/airblag/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,1,2020-03-17T22:09:28Z,2020-03-19T12:24:50Z,2020-03-19T12:24:50Z,NONE,,,"### Description
Two communities on my homeserver where not able to display the room list in riot (rolling circle animation never stops).
It shows in the logs of synapse this :
```
2020-03-16 12:30:36,168 - synapse.http.server - 110 - ERROR - GET-8088028- Failed handle request via 'GroupRoomServlet':
Traceback (most recent call last):
File ""/opt/venvs/matrix-synapse/lib/python3.7/site-packages/twisted/internet/defer.py"", line 1418, in _inlineCallbacks
result = g.send(result)
StopIteration: [{'room_id': '!XxXxXxXxXxXxXxZrdt:matrix.example.org', 'is_public': False}, {'room_id': '!XxXxXxXxXxXxXxCDNg:matrix.example.org', 'is_public': False}, {'room_id': '!XxXxXxXxXxXxXxsbEE:matrix.example.org', 'is_public': False}, {'room_id': '!XxXxXxXxXxXxXxBEhg:matrix.example.org
', 'is_public': False}, {'room_id': '!XxXxXxXxXxXxXxgppS:matrix.example.org', 'is_public': False}, {'room_id': '!XxXxXxXxXxXxXxmFNE:matrix.example.org', 'is_public': False}, {'room_id': '!XxXxXxXxXxXxXxFpTn:matrix.example.org', 'is_public': False}, {'room_id': '!XxXxXxXxXxXxXxIFYD:matrix.example.org', 'is_public': False}, {'room_id': '!XxXxXxXxXxXxXxmxCs:matrix.example.org', 'is_public': False}, {'room_id': '!XxXxXxXxXxXxXxkHBS:matrix.example.org', 'is_public': False}, {'room_id': '!XxXxXxXxXxXxXxLBUJ:matrix.example.org', 'is_public': False}, {'room_id': '!XxXxXxXxXxXxXxDEWL:matrix.example.org', 'is_public': False}, {'room_id': '!XxXxXxXxXxXxXxXXKK:matrix.example.org', 'is_public': False}]
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File ""/opt/venvs/matrix-synapse/lib/python3.7/site-packages/twisted/internet/defer.py"", line 1418, in _inlineCallbacks
result = g.send(result)
StopIteration: [{'room_id': '!XxXxXxXxXxXxXxZrdt:matrix.example.org', 'is_public': False}, {'room_id': '!XxXxXxXxXxXxXxCDNg:matrix.example.org', 'is_public': False}, {'room_id': '!XxXxXxXxXxXxXxsbEE:matrix.example.org', 'is_public': False}, {'room_id': '!XxXxXxXxXxXxXxBEhg:matrix.example.org', 'is_public': False}, {'room_id': '!XxXxXxXxXxXxXxgppS:matrix.example.org', 'is_public': False}, {'room_id': '!XxXxXxXxXxXxXxmFNE:matrix.example.org', 'is_public': False}, {'room_id': '!XxXxXxXxXxXxXxFpTn:matrix.example.org', 'is_public': False}, {'room_id': '!XxXxXxXxXxXxXxIFYD:matrix.example.org', 'is_public': False}, {'room_id': '!XxXxXxXxXxXxXxmxCs:matrix.example.org', 'is_public': False}, {'room_id': '!XxXxXxXxXxXxXxkHBS:matrix.example.org', 'is_public': False}, {'room_id': '!XxXxXxXxXxXxXxLBUJ:matrix.example.org', 'is_public': False}, {'room_id': '!XxXxXxXxXxXxXxDEWL:matrix.example.org', 'is_public': False}, {'room_id': '!XxXxXxXxXxXxXxXXKK:matrix.example.org', 'is_public': False}]
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File ""/opt/venvs/matrix-synapse/lib/python3.7/site-packages/synapse/util/caches/descriptors.py"", line 438, in _wrapped
cached_result_d = cache.get(cache_key, callback=invalidate_callback)
File ""/opt/venvs/matrix-synapse/lib/python3.7/site-packages/synapse/util/caches/descriptors.py"", line 160, in get
raise KeyError()
KeyError
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File ""/opt/venvs/matrix-synapse/lib/python3.7/site-packages/synapse/http/server.py"", line 78, in wrapped_request_handler
await h(self, request)
File ""/opt/venvs/matrix-synapse/lib/python3.7/site-packages/synapse/http/server.py"", line 331, in _async_render
callback_return = await callback_return
File ""/opt/venvs/matrix-synapse/lib/python3.7/site-packages/synapse/rest/client/v2_alpha/groups.py"", line 329, in on_GET
group_id, requester_user_id
AttributeError: 'NoneType' object has no attribute 'content'
```
Looking at the DB :
```
SELECT * from group_rooms, rooms where group_rooms.group_id='+desk:matrix.example.org' and rooms.room_id=group_rooms.room_id;
group_id | room_id | is_public | room_id | is_public | creator | room_version
---------------------+-----------------------------------+-----------+-----------------------------------+-----------+---------------------------+--------------
+desk:matrix.example.org | !XxXxXxXxXxXxXxZrdt:matrix.example.org | f | !XxXxXxXxXxXxXxZrdt:matrix.example.org | f | @user:matrix.example.org | 1
+desk:matrix.example.org | !XxXxXxXxXxXxXxCDNg:matrix.example.org | f | !XxXxXxXxXxXxXxCDNg:matrix.example.org | f | @user:matrix.example.org | 1
+desk:matrix.example.org | !XxXxXxXxXxXxXxsbEE:matrix.example.org | f | !XxXxXxXxXxXxXxsbEE:matrix.example.org | f | @user:matrix.example.org | 1
+desk:matrix.example.org | !XxXxXxXxXxXxXxBEhg:matrix.example.org | f | !XxXxXxXxXxXxXxBEhg:matrix.example.org | f | @user:matrix.example.org | 1
+desk:matrix.example.org | !XxXxXxXxXxXxXxgppS:matrix.example.org | f | !XxXxXxXxXxXxXxgppS:matrix.example.org | f | @user:matrix.example.org | 1
+desk:matrix.example.org | !XxXxXxXxXxXxXxmFNE:matrix.example.org | f | !XxXxXxXxXxXxXxmFNE:matrix.example.org | t | @user:matrix.example.org | 1
+desk:matrix.example.org | !XxXxXxXxXxXxXxFpTn:matrix.example.org | f | !XxXxXxXxXxXxXxFpTn:matrix.example.org | f | @user:matrix.example.org | 1
+desk:matrix.example.org | !XxXxXxXxXxXxXxIFYD:matrix.example.org | f | !XxXxXxXxXxXxXxIFYD:matrix.example.org | f | @user:matrix.example.org |
+desk:matrix.example.org | !XxXxXxXxXxXxXxmxCs:matrix.example.org | f | !XxXxXxXxXxXxXxmxCs:matrix.example.org | t | @user:matrix.example.org | 1
+desk:matrix.example.org | !XxXxXxXxXxXxXxkHBS:matrix.example.org | f | !XxXxXxXxXxXxXxkHBS:matrix.example.org | f | @user:matrix.example.org | 1
+desk:matrix.example.org | !XxXxXxXxXxXxXxLBUJ:matrix.example.org | f | !XxXxXxXxXxXxXxLBUJ:matrix.example.org | f | @user:matrix.example.org | 1
+desk:matrix.example.org | !XxXxXxXxXxXxXxDEWL:matrix.example.org | f | !XxXxXxXxXxXxXxDEWL:matrix.example.org | f | @user:matrix.example.org | 1
+desk:matrix.example.org | !XxXxXxXxXxXxXxXXKK:matrix.example.org | f | !XxXxXxXxXxXxXxXXKK:matrix.example.org | t | @user:matrix.example.org | 5
```
The room : !XxXxXxXxXxXxXxIFYD:matrix.example.org is not having a field ""room_version""
After trying to join it, riot informs me that the room has been blocked on this server.
I removed references to this room from group_rooms to solve it
`delete from group_rooms where room_id='!XxXxXxXxXxXxXxIFYD:matrix.example.org';`
### Steps to reproduce
- Add a room to a comunity
- Block this room on the server with /_matrix/client/unstable/admin/shutdown_room/$roomid
- room list of the community should not show up anymore
### Version information
- **Homeserver**:
self hosted
- **Version**:
matrix-synapse-py3 1.11.1+buster1 amd64
```
{
""python_version"": ""3.7.3"",
""server_version"": ""1.11.1""
}
```
- **Install method**:
apt, packages.matrix.org
",
1191,https://api.github.com/repos/matrix-org/synapse/issues/7096,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7096/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7096/comments,https://api.github.com/repos/matrix-org/synapse/issues/7096/events,https://github.com/matrix-org/synapse/pull/7096,583301253,MDExOlB1bGxSZXF1ZXN0MzkwMDc5NTI0,7096,Add options to prevent users from changing their profile.,"{'login': 'dklimpel', 'id': 5740567, 'node_id': 'MDQ6VXNlcjU3NDA1Njc=', 'avatar_url': 'https://avatars2.githubusercontent.com/u/5740567?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/dklimpel', 'html_url': 'https://github.com/dklimpel', 'followers_url': 'https://api.github.com/users/dklimpel/followers', 'following_url': 'https://api.github.com/users/dklimpel/following{/other_user}', 'gists_url': 'https://api.github.com/users/dklimpel/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/dklimpel/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/dklimpel/subscriptions', 'organizations_url': 'https://api.github.com/users/dklimpel/orgs', 'repos_url': 'https://api.github.com/users/dklimpel/repos', 'events_url': 'https://api.github.com/users/dklimpel/events{/privacy}', 'received_events_url': 'https://api.github.com/users/dklimpel/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,0,2020-03-17T21:10:58Z,2020-03-27T19:45:54Z,2020-03-27T19:15:24Z,CONTRIBUTOR,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7096', 'html_url': 'https://github.com/matrix-org/synapse/pull/7096', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7096.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7096.patch'}","PR for: #5267
Code from #3179 and #3180 with additional tests
Second try for #7053 to update configuration file
* [x] Pull request is based on the develop branch
* [x] Pull request includes a [changelog file](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#changelog). The entry should:
- Be a short description of your change which makes sense to users. ""Fixed a bug that prevented receiving messages from other servers."" instead of ""Moved X method from `EventStore` to `EventWorkerStore`."".
- Use markdown where necessary, mostly for `code blocks`.
- End with either a period (.) or an exclamation mark (!).
- Start with a capital letter.
* [x] Pull request includes a [sign off](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#sign-off)
* [x] Code style is correct (run the [linters](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#code-style))
Signed-off-by: Dirk Klimpel dirk@klimpel.org",
1192,https://api.github.com/repos/matrix-org/synapse/issues/7095,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7095/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7095/comments,https://api.github.com/repos/matrix-org/synapse/issues/7095/events,https://github.com/matrix-org/synapse/pull/7095,583133957,MDExOlB1bGxSZXF1ZXN0Mzg5OTM3ODgw,7095,Improve get auth chain difference algorithm.,"{'login': 'erikjohnston', 'id': 8428120, 'node_id': 'MDQ6VXNlcjg0MjgxMjA=', 'avatar_url': 'https://avatars0.githubusercontent.com/u/8428120?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/erikjohnston', 'html_url': 'https://github.com/erikjohnston', 'followers_url': 'https://api.github.com/users/erikjohnston/followers', 'following_url': 'https://api.github.com/users/erikjohnston/following{/other_user}', 'gists_url': 'https://api.github.com/users/erikjohnston/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/erikjohnston/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/erikjohnston/subscriptions', 'organizations_url': 'https://api.github.com/users/erikjohnston/orgs', 'repos_url': 'https://api.github.com/users/erikjohnston/repos', 'events_url': 'https://api.github.com/users/erikjohnston/events{/privacy}', 'received_events_url': 'https://api.github.com/users/erikjohnston/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,0,2020-03-17T16:20:18Z,2020-03-18T16:46:43Z,2020-03-18T16:46:42Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7095', 'html_url': 'https://github.com/matrix-org/synapse/pull/7095', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7095.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7095.patch'}","It was originally implemented by pulling the full auth chain of all
state sets out of the database and doing set comparison. However, that
can take a lot work if the state and auth chains are large.
Instead, lets try and fetch the auth chains at the same time and
calcualte the difference on the fly, allowing us to bail early if all
the auth chains converge. Assuming that the auth chains do converge more
often than not, this should improve performance. Hopefully.
Relates to: #6943",
1193,https://api.github.com/repos/matrix-org/synapse/issues/7094,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7094/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7094/comments,https://api.github.com/repos/matrix-org/synapse/issues/7094/events,https://github.com/matrix-org/synapse/pull/7094,583133660,MDExOlB1bGxSZXF1ZXN0Mzg5OTM3NjMw,7094,Share SSL contexts for non-federation requests,"{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,0,2020-03-17T16:19:52Z,2020-03-17T21:32:27Z,2020-03-17T21:32:26Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7094', 'html_url': 'https://github.com/matrix-org/synapse/pull/7094', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7094.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7094.patch'}","Extends #5794 etc to the SimpleHttpClient so that it also applies to non-federation requests.
Fixes #7092.",
1194,https://api.github.com/repos/matrix-org/synapse/issues/7093,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7093/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7093/comments,https://api.github.com/repos/matrix-org/synapse/issues/7093/events,https://github.com/matrix-org/synapse/issues/7093,583099661,MDU6SXNzdWU1ODMwOTk2NjE=,7093,"federation seems to work, server available but clients unable to connect.","{'login': 'poetaster', 'id': 1065933, 'node_id': 'MDQ6VXNlcjEwNjU5MzM=', 'avatar_url': 'https://avatars0.githubusercontent.com/u/1065933?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/poetaster', 'html_url': 'https://github.com/poetaster', 'followers_url': 'https://api.github.com/users/poetaster/followers', 'following_url': 'https://api.github.com/users/poetaster/following{/other_user}', 'gists_url': 'https://api.github.com/users/poetaster/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/poetaster/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/poetaster/subscriptions', 'organizations_url': 'https://api.github.com/users/poetaster/orgs', 'repos_url': 'https://api.github.com/users/poetaster/repos', 'events_url': 'https://api.github.com/users/poetaster/events{/privacy}', 'received_events_url': 'https://api.github.com/users/poetaster/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,4,2020-03-17T15:31:21Z,2020-03-18T08:34:14Z,2020-03-18T08:34:14Z,NONE,,,"### Description
Clients cannot connect although the server is available via proxy and dns srv records are in place.
https://federationtester.matrix.org/ also shows all green???
### Steps to reproduce
try to connect with riot.im to https://matrix.netzpolitik.org (https proxy)
The old (sqlite, direct port 8448) method worked. After moving to postgres (all fine) and putting a proxy in front, no go.
The proxy is running on one private jail (443 traffic forwarded to it) and the synapse server is running on it's own jail with 8008 and 8448 forwarded to it. Both proxy and synapse share the same certs.
### Version information
matrix.netzpolitik.org
{
""python_version"": ""3.7.6"",
""server_version"": ""1.7.2""
}
- **Version**:
""server_version"": ""1.7.2""
apache 2.4
- **Install method**:
freebsd pkg
- **Platform**:
free bsd
-**debug**
``{
""WellKnownResult"": {
""m.server"": """",
""result"": ""No .well-known found""
},
""DNSResult"": {
""SRVCName"": ""_matrix._tcp.matrix.netzpolitik.org."",
""SRVRecords"": [
{
""Target"": ""matrix.netzpolitik.org."",
""Port"": 443,
""Priority"": 10,
""Weight"": 5
}
],
""SRVError"": null,
""Hosts"": {
""matrix.netzpolitik.org."": {
""CName"": ""matrix.netzpolitik.org."",
""Addrs"": [
""91.102.13.7""
],
""Error"": null
}
},
""Addrs"": [
""91.102.13.7:443""
]
},
""ConnectionReports"": {
""91.102.13.7:443"": {
""Certificates"": [
{
""SubjectCommonName"": ""matrix.netzpolitik.org"",
""IssuerCommonName"": ""Let's Encrypt Authority X3"",
""SHA256Fingerprint"": ""n4LGqQYS42eD2KZgaCNrYJSdKWoRDeapH3QttSX5Noo"",
""DNSNames"": [
""matrix.netzpolitik.org""
]
},
{
""SubjectCommonName"": ""Let's Encrypt Authority X3"",
""IssuerCommonName"": ""DST Root CA X3"",
""SHA256Fingerprint"": ""JYR9Zo608E/dQLErawdAxWfafQJDCOtsLJb+QdneIY0"",
""DNSNames"": null
}
],
""Cipher"": {
""Version"": ""TLS 1.2"",
""CipherSuite"": ""TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384""
},
""Checks"": {
""AllChecksOK"": true,
""MatchingServerName"": true,
""FutureValidUntilTS"": true,
""HasEd25519Key"": true,
""AllEd25519ChecksOK"": true,
""Ed25519Checks"": {
""ed25519:a_sANA"": {
""ValidEd25519"": true,
""MatchingSignature"": true
}
},
""ValidCertificates"": true
},
""Errors"": [ ],
""Ed25519VerifyKeys"": {
""ed25519:a_sANA"": ""js9k95dU/5VAELzJkjH0Lgqu14F5NOzy0yFmTG4lDTc""
},
""Info"": { },
""Keys"": {
""old_verify_keys"": { },
""server_name"": ""matrix.netzpolitik.org"",
""signatures"": {
""matrix.netzpolitik.org"": {
""ed25519:a_sANA"": ""ZSYUmSeqyptfbdlURDFyrSks5F4nswCzqlcBMn5tUQktyYj/kObn+LK8hR7rTswppiXWS0u5inUHggJ3QxuqAQ""
}
},
""tls_fingerprints"": [
{
""sha256"": ""n4LGqQYS42eD2KZgaCNrYJSdKWoRDeapH3QttSX5Noo""
}
],
""valid_until_ts"": 1584543210770,
""verify_keys"": {
""ed25519:a_sANA"": {
""key"": ""js9k95dU/5VAELzJkjH0Lgqu14F5NOzy0yFmTG4lDTc""
}
}
}
}
},
""ConnectionErrors"": { },
""Version"": {
""name"": ""Synapse"",
""version"": ""1.7.2""
},
""FederationOK"": true
}
",
1195,https://api.github.com/repos/matrix-org/synapse/issues/7092,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7092/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7092/comments,https://api.github.com/repos/matrix-org/synapse/issues/7092/events,https://github.com/matrix-org/synapse/issues/7092,583048376,MDU6SXNzdWU1ODMwNDgzNzY=,7092,OpenSSL contexts are not shared between non-federation connections,"{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,1,2020-03-17T14:20:30Z,2020-03-17T21:32:35Z,2020-03-17T21:32:35Z,MEMBER,,,"... ie, each connection to a sydent/sygnal/etc gets its own OpenSSL context",
1196,https://api.github.com/repos/matrix-org/synapse/issues/7091,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7091/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7091/comments,https://api.github.com/repos/matrix-org/synapse/issues/7091/events,https://github.com/matrix-org/synapse/pull/7091,583036601,MDExOlB1bGxSZXF1ZXN0Mzg5ODU2MzM1,7091,Add some explanation to application_services.md,"{'login': 'lub', 'id': 1029578, 'node_id': 'MDQ6VXNlcjEwMjk1Nzg=', 'avatar_url': 'https://avatars0.githubusercontent.com/u/1029578?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/lub', 'html_url': 'https://github.com/lub', 'followers_url': 'https://api.github.com/users/lub/followers', 'following_url': 'https://api.github.com/users/lub/following{/other_user}', 'gists_url': 'https://api.github.com/users/lub/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/lub/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/lub/subscriptions', 'organizations_url': 'https://api.github.com/users/lub/orgs', 'repos_url': 'https://api.github.com/users/lub/repos', 'events_url': 'https://api.github.com/users/lub/events{/privacy}', 'received_events_url': 'https://api.github.com/users/lub/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,1,2020-03-17T14:03:38Z,2020-04-27T14:03:10Z,2020-04-27T14:03:10Z,CONTRIBUTOR,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7091', 'html_url': 'https://github.com/matrix-org/synapse/pull/7091', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7091.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7091.patch'}","Signed-off-by: Simon Körner
### Pull Request Checklist
* [x] Pull request is based on the develop branch
* [x] Pull request includes a [changelog file](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#changelog). The entry should:
- Be a short description of your change which makes sense to users. ""Fixed a bug that prevented receiving messages from other servers."" instead of ""Moved X method from `EventStore` to `EventWorkerStore`."".
- Use markdown where necessary, mostly for `code blocks`.
- End with either a period (.) or an exclamation mark (!).
- Start with a capital letter.
* [x] Pull request includes a [sign off](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#sign-off)
* [ ] Code style is correct (run the [linters](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#code-style))
This PR does not touch code, are linters and changelog still neccessary?",
1197,https://api.github.com/repos/matrix-org/synapse/issues/7090,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7090/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7090/comments,https://api.github.com/repos/matrix-org/synapse/issues/7090/events,https://github.com/matrix-org/synapse/issues/7090,582992015,MDU6SXNzdWU1ODI5OTIwMTU=,7090,Invite rejection fails due to ACL ban,"{'login': 'grinapo', 'id': 1056054, 'node_id': 'MDQ6VXNlcjEwNTYwNTQ=', 'avatar_url': 'https://avatars0.githubusercontent.com/u/1056054?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/grinapo', 'html_url': 'https://github.com/grinapo', 'followers_url': 'https://api.github.com/users/grinapo/followers', 'following_url': 'https://api.github.com/users/grinapo/following{/other_user}', 'gists_url': 'https://api.github.com/users/grinapo/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/grinapo/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/grinapo/subscriptions', 'organizations_url': 'https://api.github.com/users/grinapo/orgs', 'repos_url': 'https://api.github.com/users/grinapo/repos', 'events_url': 'https://api.github.com/users/grinapo/events{/privacy}', 'received_events_url': 'https://api.github.com/users/grinapo/received_events', 'type': 'User', 'site_admin': False}","[{'id': 1311133228, 'node_id': 'MDU6TGFiZWwxMzExMTMzMjI4', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/info-needed', 'name': 'info-needed', 'color': 'a1e8ea', 'default': False, 'description': ''}]",closed,False,,[],,2,2020-03-17T12:54:36Z,2020-03-17T20:28:08Z,2020-03-17T20:28:08Z,NONE,,,"### Steps to reproduce
- register spammer account on spammer server, create spam room
- invite Victim into SpamRoom
- ACL BAN Victim, VictimServer in room
- Victim invite_reject (room leave) gets 403 forbidden from spammer_server
- invite stays on forever (locally rejected in local db)
",
1198,https://api.github.com/repos/matrix-org/synapse/issues/7089,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7089/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7089/comments,https://api.github.com/repos/matrix-org/synapse/issues/7089/events,https://github.com/matrix-org/synapse/pull/7089,582970636,MDExOlB1bGxSZXF1ZXN0Mzg5ODAwOTc1,7089,Fix a typing issue in the federation client code found with mypy,"{'login': 'clokep', 'id': 517124, 'node_id': 'MDQ6VXNlcjUxNzEyNA==', 'avatar_url': 'https://avatars2.githubusercontent.com/u/517124?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/clokep', 'html_url': 'https://github.com/clokep', 'followers_url': 'https://api.github.com/users/clokep/followers', 'following_url': 'https://api.github.com/users/clokep/following{/other_user}', 'gists_url': 'https://api.github.com/users/clokep/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/clokep/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/clokep/subscriptions', 'organizations_url': 'https://api.github.com/users/clokep/orgs', 'repos_url': 'https://api.github.com/users/clokep/repos', 'events_url': 'https://api.github.com/users/clokep/events{/privacy}', 'received_events_url': 'https://api.github.com/users/clokep/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,0,2020-03-17T12:16:15Z,2020-03-19T12:22:58Z,2020-03-19T12:22:57Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7089', 'html_url': 'https://github.com/matrix-org/synapse/pull/7089', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7089.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7089.patch'}","Per the conversation at https://github.com/matrix-org/synapse/pull/7026#discussion_r388975243, this fixes the typing issue found with mypy that was introduced in f84700fba8cd9345d7a1a025462c7f8650f27386.
The `room_version` variable is now consistently a `RoomVersion` instead of sometimes a `RoomVersion` and sometimes a `str`.",
1199,https://api.github.com/repos/matrix-org/synapse/issues/7088,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7088/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7088/comments,https://api.github.com/repos/matrix-org/synapse/issues/7088/events,https://github.com/matrix-org/synapse/issues/7088,582569996,MDU6SXNzdWU1ODI1Njk5OTY=,7088,Anonymous Homeservers (Tor/I2P),"{'login': 'jakehemmerle', 'id': 8061957, 'node_id': 'MDQ6VXNlcjgwNjE5NTc=', 'avatar_url': 'https://avatars2.githubusercontent.com/u/8061957?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/jakehemmerle', 'html_url': 'https://github.com/jakehemmerle', 'followers_url': 'https://api.github.com/users/jakehemmerle/followers', 'following_url': 'https://api.github.com/users/jakehemmerle/following{/other_user}', 'gists_url': 'https://api.github.com/users/jakehemmerle/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/jakehemmerle/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/jakehemmerle/subscriptions', 'organizations_url': 'https://api.github.com/users/jakehemmerle/orgs', 'repos_url': 'https://api.github.com/users/jakehemmerle/repos', 'events_url': 'https://api.github.com/users/jakehemmerle/events{/privacy}', 'received_events_url': 'https://api.github.com/users/jakehemmerle/received_events', 'type': 'User', 'site_admin': False}","[{'id': 477043174, 'node_id': 'MDU6TGFiZWw0NzcwNDMxNzQ=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/feature', 'name': 'feature', 'color': 'bfd4f2', 'default': False, 'description': None}, {'id': 477050471, 'node_id': 'MDU6TGFiZWw0NzcwNTA0NzE=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/p3', 'name': 'p3', 'color': '0e8a16', 'default': False, 'description': None}]",open,False,,[],,13,2020-03-16T20:08:41Z,2020-09-03T16:49:04Z,,NONE,,,"## Intro
Several people in the Matrix community, including myself, would love to see anonymous homeservers. It didn't seem appropriate to use either of the other I2P or Tor threads, since both had some awesome points by awesome people (looking at you @richvdh @cyphar @vsatmydynipnet @ekleog @ara4n). Big thanks to @ara4n for giving this a proofread before I posted!
## Why this Tor/I2P thread
It seemed appropriate to start a new thread (and lock) for the following reasons and with the following hopes:
1. Create a central thread for the discussion of **Tor/I2P homeservers** and **DNS-addressed homeservers that federate to Tor/I2P homeservers**, merging the I2P homeserver thread #5455 with the two Tor homeserver threads #5152 and #2111 (as each thread contained at least some useful and non-duplicate information that I have tried to consolidate in this post). Both protocols could theoretically be implemented, but for the sake of anonymous homeservers, we should just pick one.
2. Come to a community decision about which anonymity network to use for homeservers and for what reasons
3. Create a roadmap and/or tickets that I and other community members can start working on
Since this is a large post on a new thread that discusses several steps that are dependent on the previous, for the sake of organization it will probably make sense to break this into smaller threads over time, rename threads, and/or move stuff to a wiki or something.
## Tor or I2P?
Here is an excellent and pretty unbiased post comparing Tor and I2P from I2P’s website: https://geti2p.net/en/comparison/tor
(Summarized from above link):
### Benefits of Tor over I2P
- Bigger user base, significant funding
- Has already addressed some scaling issues I2P has yet to address
- More resistant to state-level blocking due to Pluggable Transports
- More efficient memory usage
- Tor client nodes have very low bandwidth overhead
- SOCKS is (probably) easier to build with than I2P's API
- Written in C, while I2P is Java
- Designed and optimized for exit traffic, with a large number of exit nodes (possibly faster to federate to DNS-addressed HSs)
### Benefits of I2P over Tor
- Designed and optimized for hidden services, which are much faster than Tor (how much faster?)
- UDP support instead of just TCP
- Although I don't expect there to be many audio/video transmissions from anonymous Matrix users, receiving them could be nice).
- Could we see coap-proxy get some love here? How much slower would it be with TCP as transport?
- I2P's APIs are designed specifically for anonymity and security, while SOCKS is designed for functionality.
- Fully distributed and self organizing nodes
- P2P friendly
- Packet switched instead of circuit switched
I am no expert in network protocols and I don't want to provide an ill-equip opinion, but it seems that Tor HSs would be easier to implement, while I2P HSs appear more 'proper'.
## UX and Federation Behavior
I thought it would be useful to include expected behavior in this discussion. This and everything below this will be split into a separate thread with more details after decision on Tor or I2P.
### UX (Client)
In a perfect world, I would think we would want the following behavior to apply (I will use terms 'Tor/I2P HSs' and 'DNS-addressed HSs' to describe homeservers that end in .onion/.i2p and in .com/etc for lack of better terminology):
1. Tor/I2P HSs and DNS-addressed HSs should be able to participate in the same rooms and federate to each other (I can ping @matthew:matrix.org and @somefella:sdfasdfdfd.i2p/.onion in the same message without having to do anything special).
### Behind the scenes (Server)
1. Having a HS that does not support federating to Tor/I2P HSs should not break anything.
- How would we handle legacy HSs that don't support specifying a Tor/I2P client? Would adding a bridge to the room solve catching Tor/I2P servers up or would it be cleaner to do a breaking server update during a big release? interesting comment related to this by @OlegGirko on #2528 )
2. In a perfect world, we would have every HS running a Tor/I2P client, providing native federation to all HS types. I don't think this should be a requirement as this will probably induce non-insignificant overhead, but we should include a server config entry to just specify an external relay (ie IP/port of a Tor SOCKS5 proxy). Maybe include native Tor/I2P client in the stable Dendrite release? Food for thought, I'm just dreaming here.
3. Tor/I2P HSs would have to route all their requests through Tor/I2P while DNS-addressed HSs would split where they route outgoing packets.
@richvdh in #2111 recognized that for both types of HSs to federate to each other, it may be easiest to propose a change to the Matrix specification (specifically 'raising an MSC in the matrix-doc'). See post for context.
Depending on the expected future support of Synapse and with the building of Dendrite, would it make sense to skip building this for Synapse and just implement this for Dendrite?
## Next steps
I hope this post finds the community well and brings some organization to the awesome discussions started around Tor/I2P homeservers. What should we start with? Tor or I2P?",
1200,https://api.github.com/repos/matrix-org/synapse/issues/7087,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7087/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7087/comments,https://api.github.com/repos/matrix-org/synapse/issues/7087/events,https://github.com/matrix-org/synapse/issues/7087,582413539,MDU6SXNzdWU1ODI0MTM1Mzk=,7087,ObservableDeferred is not iterable,"{'login': 'IngwiePhoenix', 'id': 2893716, 'node_id': 'MDQ6VXNlcjI4OTM3MTY=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/2893716?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/IngwiePhoenix', 'html_url': 'https://github.com/IngwiePhoenix', 'followers_url': 'https://api.github.com/users/IngwiePhoenix/followers', 'following_url': 'https://api.github.com/users/IngwiePhoenix/following{/other_user}', 'gists_url': 'https://api.github.com/users/IngwiePhoenix/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/IngwiePhoenix/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/IngwiePhoenix/subscriptions', 'organizations_url': 'https://api.github.com/users/IngwiePhoenix/orgs', 'repos_url': 'https://api.github.com/users/IngwiePhoenix/repos', 'events_url': 'https://api.github.com/users/IngwiePhoenix/events{/privacy}', 'received_events_url': 'https://api.github.com/users/IngwiePhoenix/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,1,2020-03-16T16:01:26Z,2020-03-17T17:42:09Z,2020-03-17T17:42:09Z,NONE,,,"### Description
I have been running Synapse for about a month now and just traveled up and down a few server's room lists via Riot and wanted to join a couple. Well, either I am literally over-tasking my server, or I found an actual bug. I don't exactly know which of the two it is, but since this is unexpected behaviour, I thought I'd let you guys know.
### Steps to reproduce
From what I know, this is about when I try to `/join` a room through Riot. The room shouldn't matter, but it is `#gamingonlinux:matrix.org`.
Log:
```
2020-03-16 15:51:21,944 - synapse.access.http.8008 - 302 - INFO - PUT-1738425 - 198.245.63.94 - 8008 - {@_discord_324631108731928587:ingwie.io} Processed request: 0.002sec/0.001sec (0.004sec, 0.000sec) (0.000sec/0.000sec/0) 2B 200 ""PUT /_matrix/client/r0/presence/%40_discord_324631108731928587%3Aingwie.io/status?access_token=&user_id=%40_discord_324631108731928587%3Aingwie.io HTTP/1.0"" ""-"" [0 dbevts] 2020-03-16 15:51:22,275 - synapse.access.http.8008 - 302 - INFO - GET-1738418 - 2a02:908:c37:9a20:65f3:c170:5a83:a4c5 - 8008 - {@ingwiephoenix:ingwie.io} Processed request: 2.558sec/0.003sec (0.008sec, 0.000sec) (0.000sec/0.000sec/0) 491B 200 ""GET /_matrix/client/r0/sync?filter=0&timeout=30000&since=s126525_4944167_17371_26878_2214_3_2_4306_2 HTTP/1.0"" ""Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/78.0.3904.130 Safari/537.36"" [0 dbevts]
2020-03-16 15:51:22,335 - synapse.access.http.8008 - 302 - INFO - PUT-1738368 - 149.248.189.70 - 8008 - {tylerfreedman.com} Processed request: 11.334sec/0.000sec (0.012sec, 0.000sec) (10.758sec/0.556sec/3) 12B 200 ""PUT /_matrix/federation/v1/send/1583436493074 HTTP/1.0"" ""Synapse/1.0.0"" [0 dbevts]
2020-03-16 15:51:22,432 - synapse.access.http.8008 - 302 - INFO - GET-1738428 - 2a02:908:c37:9a20:65f3:c170:5a83:a4c5 - 8008 - {@ingwiephoenix:ingwie.io} Processed request: 0.022sec/0.003sec (0.004sec, 0.000sec) (0.000sec/0.000sec/0) 490B 200 ""GET /_matrix/client/r0/sync?filter=0&timeout=30000&since=s126625_4944168_17371_26878_2214_3_2_4306_2 HTTP/1.0"" ""Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/78.0.3904.130 Safari/537.36"" [0 dbevts]
2020-03-16 15:51:22,542 - synapse.federation.federation_server - 832 - ERROR - PUT-1738389 - Failed to handle edu 'm.receipt'
Traceback (most recent call last):
File ""/opt/venvs/matrix-synapse/lib/python3.5/site-packages/twisted/internet/defer.py"", line 1418, in _inlineCallbacks
result = g.send(result)
StopIteration: 0
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File ""/opt/venvs/matrix-synapse/lib/python3.5/site-packages/synapse/federation/federation_server.py"", line 828, in on_edu
await handler(origin, content)
File ""/opt/venvs/matrix-synapse/lib/python3.5/site-packages/synapse/handlers/receipts.py"", line 65, in _received_remote_receipt
await self._handle_new_receipts(receipts)
File ""/opt/venvs/matrix-synapse/lib/python3.5/site-packages/synapse/handlers/receipts.py"", line 79, in _handle_new_receipts
receipt.data,
File ""/opt/venvs/matrix-synapse/lib/python3.5/site-packages/twisted/internet/defer.py"", line 1416, in _inlineCallbacks
result = result.throwExceptionIntoGenerator(g)
File ""/opt/venvs/matrix-synapse/lib/python3.5/site-packages/twisted/python/failure.py"", line 512, in throwExceptionIntoGenerator
return g.throw(self.type, self.value, self.tb)
File ""/opt/venvs/matrix-synapse/lib/python3.5/site-packages/synapse/storage/data_stores/main/receipts.py"", line 473, in insert_receipt
stream_id=stream_id,
File ""/opt/venvs/matrix-synapse/lib/python3.5/site-packages/twisted/internet/defer.py"", line 1418, in _inlineCallbacks
result = g.send(result)
File ""/opt/venvs/matrix-synapse/lib/python3.5/site-packages/synapse/storage/database.py"", line 499, in runInteraction
after_callback(*after_args, **after_kwargs)
File ""/opt/venvs/matrix-synapse/lib/python3.5/site-packages/synapse/storage/data_stores/main/receipts.py"", line 310, in _invalidate_get_users_with_receipts_in_room
if res and user_id in res:
TypeError: argument of type 'ObservableDeferred' is not iterable
```
### Version information
- **Homeserver**: My own homeserver (ingwie.io / https://matrix.ingwie.io )
- **Version**:
```
ingwiephoenix@ingwie-io /v/l/matrix-synapse $ curl -v localhost:8008/_synapse/admin/v1/server_version
* Trying ::1...
* TCP_NODELAY set
* Connected to localhost (::1) port 8008 (#0)
> GET /_synapse/admin/v1/server_version HTTP/1.1
> Host: localhost:8008
> User-Agent: curl/7.52.1
> Accept: */*
>
< HTTP/1.1 200 OK
< Server: Synapse/1.11.1
< Cache-Control: no-cache, no-store, must-revalidate
< Date: Mon, 16 Mar 2020 15:58:06 GMT
< Access-Control-Allow-Origin: *
< Content-Type: application/json
< Access-Control-Allow-Methods: GET, POST, PUT, DELETE, OPTIONS
< Content-Length: 66
< Access-Control-Allow-Headers: Origin, X-Requested-With, Content-Type, Accept, Authorization
<
{
""python_version"": ""3.5.3"",
""server_version"": ""1.11.1""
}
* Curl_http_done: called premature == 0
* Connection #0 to host localhost left intact
```
- **Install method**: APT
```
$ dpkg -l | grep synapse
ii matrix-synapse-py3 1.11.1+stretch1 amd64 Open federated Instant Messaging and VoIP server
```
- **Platform**: GNU/Linux Debian
```
$ cat /etc/debian_version
9.12
```",
1201,https://api.github.com/repos/matrix-org/synapse/issues/7086,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7086/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7086/comments,https://api.github.com/repos/matrix-org/synapse/issues/7086/events,https://github.com/matrix-org/synapse/issues/7086,582326161,MDU6SXNzdWU1ODIzMjYxNjE=,7086,Limit concurrent creation of events in a room,"{'login': 'erikjohnston', 'id': 8428120, 'node_id': 'MDQ6VXNlcjg0MjgxMjA=', 'avatar_url': 'https://avatars0.githubusercontent.com/u/8428120?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/erikjohnston', 'html_url': 'https://github.com/erikjohnston', 'followers_url': 'https://api.github.com/users/erikjohnston/followers', 'following_url': 'https://api.github.com/users/erikjohnston/following{/other_user}', 'gists_url': 'https://api.github.com/users/erikjohnston/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/erikjohnston/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/erikjohnston/subscriptions', 'organizations_url': 'https://api.github.com/users/erikjohnston/orgs', 'repos_url': 'https://api.github.com/users/erikjohnston/repos', 'events_url': 'https://api.github.com/users/erikjohnston/events{/privacy}', 'received_events_url': 'https://api.github.com/users/erikjohnston/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,2,2020-03-16T14:06:38Z,2020-07-09T13:47:24Z,2020-07-09T13:47:24Z,MEMBER,,,"When Synapse generates new events it ensures that they have a max of ten `prev_events`. This has the effect that if more than ten events get generated for a room concurrently (i.e. they get generated before the other events are persisted) then we'll end up with more than ten events as forward extremities. A single subsequent event will therefore not clear out all the forward extremities, and so if synapse tries to generate more than ten events concurrently for a long period of time the number of forward extremities will grow.
This has happened on matrix.org where a bridged freenode room ended up having ~1.6k extremities. (This then had performance implications as all events had ten extremities, and so state res happened a lot).",
1202,https://api.github.com/repos/matrix-org/synapse/issues/7085,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7085/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7085/comments,https://api.github.com/repos/matrix-org/synapse/issues/7085/events,https://github.com/matrix-org/synapse/pull/7085,582311105,MDExOlB1bGxSZXF1ZXN0Mzg5MjQ4NzU4,7085,Update the set password API to optionally logout other devices.,"{'login': 'clokep', 'id': 517124, 'node_id': 'MDQ6VXNlcjUxNzEyNA==', 'avatar_url': 'https://avatars2.githubusercontent.com/u/517124?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/clokep', 'html_url': 'https://github.com/clokep', 'followers_url': 'https://api.github.com/users/clokep/followers', 'following_url': 'https://api.github.com/users/clokep/following{/other_user}', 'gists_url': 'https://api.github.com/users/clokep/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/clokep/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/clokep/subscriptions', 'organizations_url': 'https://api.github.com/users/clokep/orgs', 'repos_url': 'https://api.github.com/users/clokep/repos', 'events_url': 'https://api.github.com/users/clokep/events{/privacy}', 'received_events_url': 'https://api.github.com/users/clokep/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,5,2020-03-16T13:50:20Z,2020-03-18T11:50:02Z,2020-03-18T11:50:01Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7085', 'html_url': 'https://github.com/matrix-org/synapse/pull/7085', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7085.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7085.patch'}","This updates the set password API (and the admin API to modify passwords) to take an optional flag: `logout_devices`. If set to `true` (the default) then other sessions are deleted. If set to `false` the password is updated, but any active sessions are left alone.
See matrix-org/matrix-doc#2457 for spec changes.
Fixes #6963, Fixes #6976",
1203,https://api.github.com/repos/matrix-org/synapse/issues/7084,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7084/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7084/comments,https://api.github.com/repos/matrix-org/synapse/issues/7084/events,https://github.com/matrix-org/synapse/issues/7084,582235761,MDU6SXNzdWU1ODIyMzU3NjE=,7084,Events going missing from incremental /syncs,"{'login': 'ara4n', 'id': 1294269, 'node_id': 'MDQ6VXNlcjEyOTQyNjk=', 'avatar_url': 'https://avatars2.githubusercontent.com/u/1294269?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/ara4n', 'html_url': 'https://github.com/ara4n', 'followers_url': 'https://api.github.com/users/ara4n/followers', 'following_url': 'https://api.github.com/users/ara4n/following{/other_user}', 'gists_url': 'https://api.github.com/users/ara4n/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/ara4n/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/ara4n/subscriptions', 'organizations_url': 'https://api.github.com/users/ara4n/orgs', 'repos_url': 'https://api.github.com/users/ara4n/repos', 'events_url': 'https://api.github.com/users/ara4n/events{/privacy}', 'received_events_url': 'https://api.github.com/users/ara4n/received_events', 'type': 'User', 'site_admin': False}","[{'id': 1311133228, 'node_id': 'MDU6TGFiZWwxMzExMTMzMjI4', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/info-needed', 'name': 'info-needed', 'color': 'a1e8ea', 'default': False, 'description': ''}]",closed,False,"{'login': 'ara4n', 'id': 1294269, 'node_id': 'MDQ6VXNlcjEyOTQyNjk=', 'avatar_url': 'https://avatars2.githubusercontent.com/u/1294269?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/ara4n', 'html_url': 'https://github.com/ara4n', 'followers_url': 'https://api.github.com/users/ara4n/followers', 'following_url': 'https://api.github.com/users/ara4n/following{/other_user}', 'gists_url': 'https://api.github.com/users/ara4n/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/ara4n/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/ara4n/subscriptions', 'organizations_url': 'https://api.github.com/users/ara4n/orgs', 'repos_url': 'https://api.github.com/users/ara4n/repos', 'events_url': 'https://api.github.com/users/ara4n/events{/privacy}', 'received_events_url': 'https://api.github.com/users/ara4n/received_events', 'type': 'User', 'site_admin': False}","[{'login': 'ara4n', 'id': 1294269, 'node_id': 'MDQ6VXNlcjEyOTQyNjk=', 'avatar_url': 'https://avatars2.githubusercontent.com/u/1294269?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/ara4n', 'html_url': 'https://github.com/ara4n', 'followers_url': 'https://api.github.com/users/ara4n/followers', 'following_url': 'https://api.github.com/users/ara4n/following{/other_user}', 'gists_url': 'https://api.github.com/users/ara4n/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/ara4n/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/ara4n/subscriptions', 'organizations_url': 'https://api.github.com/users/ara4n/orgs', 'repos_url': 'https://api.github.com/users/ara4n/repos', 'events_url': 'https://api.github.com/users/ara4n/events{/privacy}', 'received_events_url': 'https://api.github.com/users/ara4n/received_events', 'type': 'User', 'site_admin': False}]",,2,2020-03-16T12:00:47Z,2020-04-02T14:18:40Z,2020-04-02T14:18:40Z,MEMBER,,,"I've had several instances in the last 4-5 days where messages and/or state have gone missing from my clients. It's unclear whether these are clientside or serverside bugs, but in combination with https://github.com/matrix-org/synapse/issues/7083 and https://github.com/matrix-org/synapse/issues/7065 i'm wondering there are synapse-side regressions going on.
These have all happened in v5 rooms, as far as I know.
Concretely:
* https://github.com/matrix-org/riot-ios-rageshakes/issues/3976
* https://github.com/matrix-org/riot-web-rageshakes/issues/2375
Also, https://github.com/vector-im/riot-web/issues/7843 seems to be a grabbag of ""my client got out of sync with the server somehow"". However, some of these seem to be ""a chunk of my history went missing"" and i don't know why - which could point at synapse providing unreliable sync responses.",
1204,https://api.github.com/repos/matrix-org/synapse/issues/7083,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7083/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7083/comments,https://api.github.com/repos/matrix-org/synapse/issues/7083/events,https://github.com/matrix-org/synapse/issues/7083,582231166,MDU6SXNzdWU1ODIyMzExNjY=,7083,Rooms with unsupported versions are shown as blank rooms,"{'login': 'ara4n', 'id': 1294269, 'node_id': 'MDQ6VXNlcjEyOTQyNjk=', 'avatar_url': 'https://avatars2.githubusercontent.com/u/1294269?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/ara4n', 'html_url': 'https://github.com/ara4n', 'followers_url': 'https://api.github.com/users/ara4n/followers', 'following_url': 'https://api.github.com/users/ara4n/following{/other_user}', 'gists_url': 'https://api.github.com/users/ara4n/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/ara4n/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/ara4n/subscriptions', 'organizations_url': 'https://api.github.com/users/ara4n/orgs', 'repos_url': 'https://api.github.com/users/ara4n/repos', 'events_url': 'https://api.github.com/users/ara4n/events{/privacy}', 'received_events_url': 'https://api.github.com/users/ara4n/received_events', 'type': 'User', 'site_admin': False}",[],open,False,,[],,9,2020-03-16T11:53:05Z,2020-08-14T16:14:26Z,,MEMBER,,,"In the last ~4-5 days
`!VXChyxVNCBsWeSGcaN:sw1v.org`
`!eKTrlepAvBEhUIyoQV:jki.re`
`!bNAPsppHlSHCDvMRhh:abolivier.bzh`",
1205,https://api.github.com/repos/matrix-org/synapse/issues/7082,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7082/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7082/comments,https://api.github.com/repos/matrix-org/synapse/issues/7082/events,https://github.com/matrix-org/synapse/issues/7082,581804348,MDU6SXNzdWU1ODE4MDQzNDg=,7082,Setting account_validity to diabled crashes synapse,"{'login': 'deepbluev7', 'id': 16312324, 'node_id': 'MDQ6VXNlcjE2MzEyMzI0', 'avatar_url': 'https://avatars3.githubusercontent.com/u/16312324?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/deepbluev7', 'html_url': 'https://github.com/deepbluev7', 'followers_url': 'https://api.github.com/users/deepbluev7/followers', 'following_url': 'https://api.github.com/users/deepbluev7/following{/other_user}', 'gists_url': 'https://api.github.com/users/deepbluev7/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/deepbluev7/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/deepbluev7/subscriptions', 'organizations_url': 'https://api.github.com/users/deepbluev7/orgs', 'repos_url': 'https://api.github.com/users/deepbluev7/repos', 'events_url': 'https://api.github.com/users/deepbluev7/events{/privacy}', 'received_events_url': 'https://api.github.com/users/deepbluev7/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,3,2020-03-15T20:00:08Z,2020-03-16T13:56:20Z,2020-03-16T12:16:52Z,NONE,,,"
### Description
When disabling account_validity checking by setting enabled to false, synapse barfs while parsing the config file with the following error: `AttributeError: 'AccountValidityConfig' object has no attribute 'renew_email_subject'`.
See also #6199 for an example with a full backtrace.
### Steps to reproduce
- configure account_validity
- instead of setting `enabled: true`, use `enabled: false`
- try to start synapse
### Version information
- **Homeserver**: neko.dev
If not matrix.org:
- **Version**: 1.11
- **Install method**: custom ebuild
- **Platform**: Gentoo
",
1206,https://api.github.com/repos/matrix-org/synapse/issues/7081,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7081/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7081/comments,https://api.github.com/repos/matrix-org/synapse/issues/7081/events,https://github.com/matrix-org/synapse/issues/7081,581771824,MDU6SXNzdWU1ODE3NzE4MjQ=,7081,youtube.com/embed URL doesn't give a useful preview,"{'login': 'aaronraimist', 'id': 5855073, 'node_id': 'MDQ6VXNlcjU4NTUwNzM=', 'avatar_url': 'https://avatars2.githubusercontent.com/u/5855073?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/aaronraimist', 'html_url': 'https://github.com/aaronraimist', 'followers_url': 'https://api.github.com/users/aaronraimist/followers', 'following_url': 'https://api.github.com/users/aaronraimist/following{/other_user}', 'gists_url': 'https://api.github.com/users/aaronraimist/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/aaronraimist/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/aaronraimist/subscriptions', 'organizations_url': 'https://api.github.com/users/aaronraimist/orgs', 'repos_url': 'https://api.github.com/users/aaronraimist/repos', 'events_url': 'https://api.github.com/users/aaronraimist/events{/privacy}', 'received_events_url': 'https://api.github.com/users/aaronraimist/received_events', 'type': 'User', 'site_admin': False}","[{'id': 477043174, 'node_id': 'MDU6TGFiZWw0NzcwNDMxNzQ=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/feature', 'name': 'feature', 'color': 'bfd4f2', 'default': False, 'description': None}, {'id': 477050471, 'node_id': 'MDU6TGFiZWw0NzcwNTA0NzE=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/p3', 'name': 'p3', 'color': '0e8a16', 'default': False, 'description': None}]",closed,False,,[],,2,2020-03-15T18:19:36Z,2020-03-29T23:32:09Z,2020-03-29T23:32:09Z,CONTRIBUTOR,,,"**Description:**
It would be nice to get an image for youtube.com/embed/... URLs",
1207,https://api.github.com/repos/matrix-org/synapse/issues/7080,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7080/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7080/comments,https://api.github.com/repos/matrix-org/synapse/issues/7080/events,https://github.com/matrix-org/synapse/issues/7080,581693172,MDU6SXNzdWU1ODE2OTMxNzI=,7080,failed :attempt to write readonly database,"{'login': 'learnwithsobhit', 'id': 56473067, 'node_id': 'MDQ6VXNlcjU2NDczMDY3', 'avatar_url': 'https://avatars2.githubusercontent.com/u/56473067?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/learnwithsobhit', 'html_url': 'https://github.com/learnwithsobhit', 'followers_url': 'https://api.github.com/users/learnwithsobhit/followers', 'following_url': 'https://api.github.com/users/learnwithsobhit/following{/other_user}', 'gists_url': 'https://api.github.com/users/learnwithsobhit/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/learnwithsobhit/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/learnwithsobhit/subscriptions', 'organizations_url': 'https://api.github.com/users/learnwithsobhit/orgs', 'repos_url': 'https://api.github.com/users/learnwithsobhit/repos', 'events_url': 'https://api.github.com/users/learnwithsobhit/events{/privacy}', 'received_events_url': 'https://api.github.com/users/learnwithsobhit/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,1,2020-03-15T14:20:32Z,2020-03-17T16:53:36Z,2020-03-17T16:53:36Z,NONE,,,"i have configured docker build for synapse then establishing user login using keycloak server ,but while registering client inside docker image i am getting following error (if i run synapse without docker it works fine)
**sqlite3.OperationalError: attempt to write a readonly database**
**i am mounting the /data of container with my updated data folder in the host with required files and configuration of keycloak and homeserver.yaml**
more error info as below -->
2020-03-15 14:12:56,732 - synapse.handlers.saml_handler - 142 - INFO - POST-7 - SAML2 assertion: (1)...ment>
2020-03-15 14:12:56,732 - synapse.handlers.saml_handler - 146 - INFO - POST-7 - SAML2 mapped attributes: {'uid': ['admin123']}
2020-03-15 14:12:56,733 - synapse.handlers.saml_handler - 162 - INFO - POST-7 - Looking for existing mapping for user saml:admin123
2020-03-15 14:12:56,736 - synapse.handlers.saml_handler - 184 - INFO - POST-7 - Looking for existing account based on mapped uid @admin123:my.domain.name
2020-03-15 14:12:56,738 - synapse.handlers.saml_handler - 232 - INFO - POST-7 - Mapped SAML user to local part admin123
2020-03-15 14:12:56,742 - synapse.storage.database - 389 - WARNING - POST-7 - [TXN OPERROR] {register_user-31} attempt to write a readonly database 0/5
2020-03-15 14:12:56,744 - synapse.storage.database - 389 - WARNING - POST-7 - [TXN OPERROR] {register_user-31} attempt to write a readonly database 1/5
2020-03-15 14:12:56,746 - synapse.storage.database - 389 - WARNING - POST-7 - [TXN OPERROR] {register_user-31} attempt to write a readonly database 2/5
2020-03-15 14:12:56,747 - synapse.storage.database - 389 - WARNING - POST-7 - [TXN OPERROR] {register_user-31} attempt to write a readonly database 3/5
2020-03-15 14:12:56,749 - synapse.storage.database - 389 - WARNING - POST-7 - [TXN OPERROR] {register_user-31} attempt to write a readonly database 4/5
2020-03-15 14:12:56,750 - synapse.storage.database - 389 - WARNING - POST-7 - [TXN OPERROR] {register_user-31} attempt to write a readonly database 5/5
2020-03-15 14:12:56,751 - synapse.http.server - 183 - ERROR - POST-7 - Failed handle request
Traceback (most recent call last):
File ""/usr/local/lib/python3.7/site-packages/synapse/http/server.py"", line 144, in wrapped_request_handler
return await h(self, request)
File ""/usr/local/lib/python3.7/site-packages/synapse/rest/saml2/response_resource.py"", line 31, in _async_render_POST
return await self._saml_handler.handle_saml_response(request)
File ""/usr/local/lib/python3.7/site-packages/synapse/handlers/saml_handler.py"", line 117, in handle_saml_response
user_id = await self._map_saml_response_to_user(resp_bytes, relay_state)
File ""/usr/local/lib/python3.7/site-packages/synapse/handlers/saml_handler.py"", line 235, in _map_saml_response_to_user
localpart=localpart, default_display_name=displayname
File ""/usr/local/lib/python3.7/site-packages/twisted/internet/defer.py"", line 1416, in _inlineCallbacks
result = result.throwExceptionIntoGenerator(g)
File ""/usr/local/lib/python3.7/site-packages/twisted/python/failure.py"", line 512, in throwExceptionIntoGenerator
return g.throw(self.type, self.value, self.tb)
File ""/usr/local/lib/python3.7/site-packages/synapse/handlers/register.py"", line 203, in register_user
address=address,
File ""/usr/local/lib/python3.7/site-packages/twisted/internet/defer.py"", line 1416, in _inlineCallbacks
result = result.throwExceptionIntoGenerator(g)
File ""/usr/local/lib/python3.7/site-packages/twisted/python/failure.py"", line 512, in throwExceptionIntoGenerator
return g.throw(self.type, self.value, self.tb)
File ""/usr/local/lib/python3.7/site-packages/synapse/storage/database.py"", line 495, in runInteraction
**kwargs
File ""/usr/local/lib/python3.7/site-packages/twisted/internet/defer.py"", line 1416, in _inlineCallbacks
result = result.throwExceptionIntoGenerator(g)
File ""/usr/local/lib/python3.7/site-packages/twisted/python/failure.py"", line 512, in throwExceptionIntoGenerator
return g.throw(self.type, self.value, self.tb)
File ""/usr/local/lib/python3.7/site-packages/synapse/storage/database.py"", line 543, in runWithConnection
self._db_pool.runWithConnection(inner_func, *args, **kwargs)
File ""/usr/local/lib/python3.7/site-packages/twisted/python/threadpool.py"", line 250, in inContext
result = inContext.theWork()
File ""/usr/local/lib/python3.7/site-packages/twisted/python/threadpool.py"", line 266, in
inContext.theWork = lambda: context.call(ctx, func, *args, **kw)
File ""/usr/local/lib/python3.7/site-packages/twisted/python/context.py"", line 122, in callWithContext
return self.currentContext().callWithContext(ctx, func, *args, **kw)
File ""/usr/local/lib/python3.7/site-packages/twisted/python/context.py"", line 85, in callWithContext
return func(*args,**kw)
File ""/usr/local/lib/python3.7/site-packages/twisted/enterprise/adbapi.py"", line 306, in _runWithConnection
compat.reraise(excValue, excTraceback)
File ""/usr/local/lib/python3.7/site-packages/twisted/python/compat.py"", line 464, in reraise
raise exception.with_traceback(traceback)
File ""/usr/local/lib/python3.7/site-packages/twisted/enterprise/adbapi.py"", line 297, in _runWithConnection
result = func(conn, *args, **kw)
File ""/usr/local/lib/python3.7/site-packages/synapse/storage/database.py"", line 540, in inner_func
return func(conn, *args, **kwargs)
File ""/usr/local/lib/python3.7/site-packages/synapse/storage/database.py"", line 378, in new_transaction
r = func(cursor, *args, **kwargs)
File ""/usr/local/lib/python3.7/site-packages/synapse/storage/data_stores/main/registration.py"", line 1078, in _register_user
""user_type"": user_type,
File ""/usr/local/lib/python3.7/site-packages/synapse/storage/database.py"", line 621, in simple_insert_txn
txn.execute(sql, vals)
File ""/usr/local/lib/python3.7/site-packages/synapse/storage/database.py"", line 175, in execute
self._do_execute(self.txn.execute, sql, *args)
File ""/usr/local/lib/python3.7/site-packages/synapse/storage/database.py"", line 201, in _do_execute
return func(sql, *args)
sqlite3.OperationalError: attempt to write a readonly database
",
1208,https://api.github.com/repos/matrix-org/synapse/issues/7079,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7079/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7079/comments,https://api.github.com/repos/matrix-org/synapse/issues/7079/events,https://github.com/matrix-org/synapse/issues/7079,581659643,MDU6SXNzdWU1ODE2NTk2NDM=,7079,synapse docker image throw internal server error after getting validation from keycloak ,"{'login': 'learnwithsobhit', 'id': 56473067, 'node_id': 'MDQ6VXNlcjU2NDczMDY3', 'avatar_url': 'https://avatars2.githubusercontent.com/u/56473067?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/learnwithsobhit', 'html_url': 'https://github.com/learnwithsobhit', 'followers_url': 'https://api.github.com/users/learnwithsobhit/followers', 'following_url': 'https://api.github.com/users/learnwithsobhit/following{/other_user}', 'gists_url': 'https://api.github.com/users/learnwithsobhit/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/learnwithsobhit/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/learnwithsobhit/subscriptions', 'organizations_url': 'https://api.github.com/users/learnwithsobhit/orgs', 'repos_url': 'https://api.github.com/users/learnwithsobhit/repos', 'events_url': 'https://api.github.com/users/learnwithsobhit/events{/privacy}', 'received_events_url': 'https://api.github.com/users/learnwithsobhit/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,1,2020-03-15T12:45:42Z,2020-03-17T16:50:29Z,2020-03-17T16:50:29Z,NONE,,,"
### Description
### Steps to reproduce
- list the steps
- that reproduce the bug
- using hyphens as bullet points
### Version information
- **Homeserver**:
If not matrix.org:
- **Version**:
- **Install method**:
- **Platform**:
",
1209,https://api.github.com/repos/matrix-org/synapse/issues/7078,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7078/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7078/comments,https://api.github.com/repos/matrix-org/synapse/issues/7078/events,https://github.com/matrix-org/synapse/issues/7078,581604415,MDU6SXNzdWU1ODE2MDQ0MTU=,7078,Server error on viewing sick community (cannot get room list),"{'login': 'grinapo', 'id': 1056054, 'node_id': 'MDQ6VXNlcjEwNTYwNTQ=', 'avatar_url': 'https://avatars0.githubusercontent.com/u/1056054?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/grinapo', 'html_url': 'https://github.com/grinapo', 'followers_url': 'https://api.github.com/users/grinapo/followers', 'following_url': 'https://api.github.com/users/grinapo/following{/other_user}', 'gists_url': 'https://api.github.com/users/grinapo/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/grinapo/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/grinapo/subscriptions', 'organizations_url': 'https://api.github.com/users/grinapo/orgs', 'repos_url': 'https://api.github.com/users/grinapo/repos', 'events_url': 'https://api.github.com/users/grinapo/events{/privacy}', 'received_events_url': 'https://api.github.com/users/grinapo/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,2,2020-03-15T09:55:33Z,2020-03-17T17:12:05Z,2020-03-17T17:12:05Z,NONE,,,"### Description
Tried to add a room ( #ubuntu-hour:grin.hu ) to the community, and the server responded that it cannot be added. It wasnt't saved in riot.
Next time I try to come to the community page synapse 500'd it.
```
2020-03-15 10:44:12,652 - synapse.http.server - 110 - ERROR - GET-1036905- Failed handle request via 'GroupRoomServlet':
Traceback (most recent call last):
File ""/usr/lib/python3/dist-packages/twisted/internet/defer.py"", line 1418, in _inlineCallbacks
result = g.send(result)
StopIteration: {}
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File ""/usr/lib/python3/dist-packages/twisted/internet/defer.py"", line 1418, in _inlineCallbacks
result = g.send(result)
StopIteration: {}
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File ""/usr/lib/python3/dist-packages/synapse/http/server.py"", line 78, in wrapped_request_handler
await h(self, request)
File ""/usr/lib/python3/dist-packages/synapse/http/server.py"", line 331, in _async_render
callback_return = await callback_return
File ""/usr/lib/python3/dist-packages/synapse/rest/client/v2_alpha/groups.py"", line 329, in on_GET
group_id, requester_user_id
File ""/usr/lib/python3/dist-packages/twisted/internet/defer.py"", line 1418, in _inlineCallbacks
result = g.send(result)
File ""/usr/lib/python3/dist-packages/synapse/handlers/room_list.py"", line 294, in generate_room_entry
result[""m.federate""] = create_event.content.get(""m.federate"", True)
AttributeError: 'NoneType' object has no attribute 'content'
```
And later even better
```
2020-03-15 10:48:43,815 - synapse.http.server - 110 - ERROR - GET-1037840- Failed handle request via 'GroupRoomServlet':
Traceback (most recent call last):
File ""/usr/lib/python3/dist-packages/twisted/internet/defer.py"", line 1418, in _inlineCallbacks
result = g.send(result)
StopIteration: {'$0xIQjO88lKN0G3ISYi6DZGQZBAcKI0lf2bIP0F5ANdM': {'event_id': '$0xIQjO88lKN0G3ISYi6DZGQZBAcKI0lf2bIP0F5ANdM', 'internal_metadata': '{""token_id"": 76, ""stream_ordering"": 1260084}', 'json': '{""auth_events"": [""$V9-0PyAxNxHT7BWlILkb7
NZM2HihatEuBD4Oavggfd8"", ""$yaWi93ApF2JzGFv1s9PNXPIbXq7WO-xKk276_snRWDs"", ""$kVa9uhXUlOH5f23uJIxciUnU_8ZqrhwhRElDt9W1HjA""], ""prev_events"": [""$dBZOGgyow89xtRsfgg_0-gpKOc-knWTTqHNGcj7jFjg""], ""type"": ""m.room.history_visibility"", ""room_id"": ""!gAwUAK
JoCAuYnIoNeV:grin.hu"", ""sender"": ""@grin:grin.hu"", ""content"": {""history_visibility"": ""world_readable""}, ""depth"": 12, ""prev_state"": [], ""state_key"": """", ""origin"": ""grin.hu"", ""origin_server_ts"": 1572699110969, ""hashes"": {""sha256"": ""4UYq8CM6f6Lbmf
FPMDTMkTvSwYcqGgEsxAbc7ua0K70""}, ""signatures"": {""grin.hu"": {""ed25519:a_PkUB"": ""XLnEPfStDbH6uxaSX+Wb2WMjSOrOWEdip5YIOK/9gBDpuMVQqWt6tLsmbovEt7o74J1YV91wBU8/M+B+minfCw""}}, ""unsigned"": {""age_ts"": 1572699110969, ""replaces_state"": ""$sxCukWrxfmfKOXH
Sszo8LvXWPDxRb_VER1YseqtCV8U""}}', 'format_version': 3, 'rejected_reason': None, 'redactions': []}, '$2AilMN5BPoHA674Z0NfiUDJT2KKfcgL1aBKfZ8xUgUI': {'event_id': '$2AilMN5BPoHA674Z0NfiUDJT2KKfcgL1aBKfZ8xUgUI', 'internal_metadata': '{""token_id"":
76, ""stream_ordering"": 1260077}', 'json': '{""auth_events"": [""$V9-0PyAxNxHT7BWlILkb7NZM2HihatEuBD4Oavggfd8"", ""$yaWi93ApF2JzGFv1s9PNXPIbXq7WO-xKk276_snRWDs"", ""$kVa9uhXUlOH5f23uJIxciUnU_8ZqrhwhRElDt9W1HjA""], ""prev_events"": [""$9kovxH0Ti3NTfX9eJ-6I
80Je1EvVRjJv1D6WUVm-Ssc""], ""type"": ""m.room.join_rules"", ""room_id"": ""!gAwUAKJoCAuYnIoNeV:grin.hu"", ""sender"": ""@grin:grin.hu"", ""content"": {""join_rule"": ""public""}, ""depth"": 5, ""prev_state"": [], ""state_key"": """", ""origin"": ""grin.hu"", ""origin_server
_ts"": 1572699069227, ""hashes"": {""sha256"": ""v7Sf2Mi6i48nhIrhazL7J84o3y4SfcZTlPaj0jJUF34""}, ""signatures"": {""grin.hu"": {""ed25519:a_PkUB"": ""IWmTDnK4/xCjiegX/OMnY+svueztxgGII4TH+Lxluh3Y/11FKk7KX5sTLjGYtOks2hooegyagmpHeBxxuKi+DA""}}, ""unsigned"": {""ag
e_ts"": 1572699069227}}', 'format_version': 3, 'rejected_reason': None, 'redactions': []}, '$9kovxH0Ti3NTfX9eJ-6I80Je1EvVRjJv1D6WUVm-Ssc': {'event_id': '$9kovxH0Ti3NTfX9eJ-6I80Je1EvVRjJv1D6WUVm-Ssc', 'internal_metadata': '{""token_id"": 76, ""stre
am_ordering"": 1260076}', 'json': '{""auth_events"": [""$V9-0PyAxNxHT7BWlILkb7NZM2HihatEuBD4Oavggfd8"", ""$yaWi93ApF2JzGFv1s9PNXPIbXq7WO-xKk276_snRWDs"", ""$kVa9uhXUlOH5f23uJIxciUnU_8ZqrhwhRElDt9W1HjA""], ""prev_events"": [""$V9-0PyAxNxHT7BWlILkb7NZM2Hiha
tEuBD4Oavggfd8""], ""type"": ""m.room.canonical_alias"", ""room_id"": ""!gAwUAKJoCAuYnIoNeV:grin.hu"", ""sender"": ""@grin:grin.hu"", ""content"": {""alias"": ""#osm:grin.hu""}, ""depth"": 4, ""prev_state"": [], ""state_key"": """", ""origin"": ""grin.hu"", ""origin_server_t
s"": 1572699069078, ""hashes"": {""sha256"": ""lxhZkAHii2gRqO8Ajw3mWzOdFFkr+m1kBOqgX2NkSxc""}, ""signatures"": {""grin.hu"": {""ed25519:a_PkUB"": ""LC0t2bNo250w5UQ9tSdlfk1kzTkih6a8kjelWldvbYN8UWW8Tz9th20sFyInFK9TizPgNtj4hzFF4nB3VbkpBQ""}}, ""unsigned"": {""age_
ts"": 1572699069078}}', 'format_version': 3, 'rejected_reason': None, 'redactions': []}, '$GvoF44EmloKhUIL2gqO8-bDTisFDn2kHx0YVCbdDThc': {'event_id': '$GvoF44EmloKhUIL2gqO8-bDTisFDn2kHx0YVCbdDThc', 'internal_metadata': '{""token_id"": 76, ""stream
_ordering"": 1268907}', 'json': '{""auth_events"": [""$24-plRKTekEWsMc9mXVdx6zCtG8i4vVGoRKsRcCxYxA"", ""$yaWi93ApF2JzGFv1s9PNXPIbXq7WO-xKk276_snRWDs"", ""$kVa9uhXUlOH5f23uJIxciUnU_8ZqrhwhRElDt9W1HjA""], ""prev_events"": [""$DeW9rlBZpTEsx5FhnSjNrrY9lsTLqtd
Ckpq44kAOX2c""], ""type"": ""m.room.topic"", ""room_id"": ""!gAwUAKJoCAuYnIoNeV:grin.hu"", ""sender"": ""@grin:grin.hu"", ""content"": {""topic"": ""Az OSM magyarorsz\\u00e1gi k\\u00f6z\\u00f6ss\\u00e9ge.\\nhttps://openstreetmap.hu/\\nMarkdown help: https://com
monmark.org/help/\\n""}, ""depth"": 31, ""prev_state"": [], ""state_key"": """", ""origin"": ""grin.hu"", ""origin_server_ts"": 1572865114935, ""hashes"": {""sha256"": ""AOAqZAeTvTvFENPFByTdtoPTwoTW6N9Ve4veijcLYLE""}, ""signatures"": {""grin.hu"": {""ed25519:a_PkUB"": ""
8E01XMLIu7BGwdnGSmefBbSZkFGqgzXoOoDBm32xElxSb3OyKRh5OCUflpGWoKQiqYfzxx0CxVpVMgNM4Z4ZAQ""}}, ""unsigned"": {""age_ts"": 1572865114935, ""replaces_state"": ""$j1Mx52VrcarbzExzZPvJUSGdYa8qqEmA-V3eDYmil2g""}}', 'format_version': 3, 'rejected_reason': None,
'redactions': []}, '$dBZOGgyow89xtRsfgg_0-gpKOc-knWTTqHNGcj7jFjg': {'event_id': '$dBZOGgyow89xtRsfgg_0-gpKOc-knWTTqHNGcj7jFjg', 'internal_metadata': '{""token_id"": 76, ""stream_ordering"": 1260083}', 'json': '{""auth_events"": [""$V9-0PyAxNxHT7BWlI
Lkb7NZM2HihatEuBD4Oavggfd8"", ""$yaWi93ApF2JzGFv1s9PNXPIbXq7WO-xKk276_snRWDs"", ""$kVa9uhXUlOH5f23uJIxciUnU_8ZqrhwhRElDt9W1HjA""], ""prev_events"": [""$zRMX8vfzbKQIQkxsBdPOx0llnopyAxMLkw_G-xkvlr0""], ""type"": ""m.room.guest_access"", ""room_id"": ""!gAwUAKJo
CAuYnIoNeV:grin.hu"", ""sender"": ""@grin:grin.hu"", ""content"": {""guest_access"": ""can_join""}, ""depth"": 11, ""prev_state"": [], ""state_key"": """", ""origin"": ""grin.hu"", ""origin_server_ts"": 1572699108433, ""hashes"": {""sha256"": ""ixr9fT81xXcrqLI3qZAvqoyLyYRM
qf50pngjx5unyHY""}, ""signatures"": {""grin.hu"": {""ed25519:a_PkUB"": ""Td/K9cLai2NZk6Ob8EZQ04uWFnZxlajKcqDfpGcaFlD6XNx1LSFzvvvqaVBdIzdpM1X5uTb2fB2Gj+6CDzZEBg""}}, ""unsigned"": {""age_ts"": 1572699108433}}', 'format_version': 3, 'rejected_reason': None,
'redactions': []}, '$f3nF3vgpFW5zezEbwUg-_eYNJeC3sSh3ljauGYT0HP4': {'event_id': '$f3nF3vgpFW5zezEbwUg-_eYNJeC3sSh3ljauGYT0HP4', 'internal_metadata': '{""token_id"": 76, ""stream_ordering"": 1260079}', 'json': '{""auth_events"": [""$V9-0PyAxNxHT7BWlIL
kb7NZM2HihatEuBD4Oavggfd8"", ""$yaWi93ApF2JzGFv1s9PNXPIbXq7WO-xKk276_snRWDs"", ""$kVa9uhXUlOH5f23uJIxciUnU_8ZqrhwhRElDt9W1HjA""], ""prev_events"": [""$sxCukWrxfmfKOXHSszo8LvXWPDxRb_VER1YseqtCV8U""], ""type"": ""m.room.name"", ""room_id"": ""!gAwUAKJoCAuYnIoNe
V:grin.hu"", ""sender"": ""@grin:grin.hu"", ""content"": {""name"": ""OpenStreetMap Hungary""}, ""depth"": 7, ""prev_state"": [], ""state_key"": """", ""origin"": ""grin.hu"", ""origin_server_ts"": 1572699069486, ""hashes"": {""sha256"": ""1Mewd3Rk6CHlN4+/CqOT1uNnh71Eq6nTH
zfBUe6aUFg""}, ""signatures"": {""grin.hu"": {""ed25519:a_PkUB"": ""4bNoAePrbRst7ZbyZPbaGl0906q+pw690JvaXfJH4/WhGO6w7ssNDivL4uC/oqVoZderZIXQHr8zaHdVdFnGDw""}}, ""unsigned"": {""age_ts"": 1572699069486}}', 'format_version': 3, 'rejected_reason': None, 'reda
ctions': []}, '$k8NsgWNkqATFjHTv5wHMUZ8AxkjmjbYjiTTVtmwnrtc': {'event_id': '$k8NsgWNkqATFjHTv5wHMUZ8AxkjmjbYjiTTVtmwnrtc', 'internal_metadata': '{""token_id"": 76, ""stream_ordering"": 1260087}', 'json': '{""auth_events"": [""$vTkp1Bpq52xKbafLApUOXzL
IaDs6JqOcwvGLknzTQ8I"", ""$yaWi93ApF2JzGFv1s9PNXPIbXq7WO-xKk276_snRWDs"", ""$kVa9uhXUlOH5f23uJIxciUnU_8ZqrhwhRElDt9W1HjA""], ""prev_events"": [""$vTkp1Bpq52xKbafLApUOXzLIaDs6JqOcwvGLknzTQ8I""], ""type"": ""m.room.avatar"", ""room_id"": ""!gAwUAKJoCAuYnIoNeV:g
rin.hu"", ""sender"": ""@grin:grin.hu"", ""content"": {""url"": ""mxc://grin.hu/rQnVLEOuEVKlJktCwosaxAlO""}, ""depth"": 15, ""prev_state"": [], ""state_key"": """", ""origin"": ""grin.hu"", ""origin_server_ts"": 1572699276452, ""hashes"": {""sha256"": ""dzhG6cM80DlN07A9cbC
U/M1RFUOpTzyPBRpCXD6nu4o""}, ""signatures"": {""grin.hu"": {""ed25519:a_PkUB"": ""3HciawgLNV9XwKUAMk5W3s824IMBaE5Zq9COzO/bKTCzbJP8/ag0CgTAPYB6WGPIHndRcbc4trwFb0ibOvkjAA""}}, ""unsigned"": {""age_ts"": 1572699276452}}', 'format_version': 3, 'rejected_reason
': None, 'redactions': []}, '$yaWi93ApF2JzGFv1s9PNXPIbXq7WO-xKk276_snRWDs': {'event_id': '$yaWi93ApF2JzGFv1s9PNXPIbXq7WO-xKk276_snRWDs', 'internal_metadata': '{""token_id"": 76, ""stream_ordering"": 1260073}', 'json': '{""auth_events"": [], ""prev_ev
ents"": [], ""type"": ""m.room.create"", ""room_id"": ""!gAwUAKJoCAuYnIoNeV:grin.hu"", ""sender"": ""@grin:grin.hu"", ""content"": {""room_version"": ""4"", ""creator"": ""@grin:grin.hu""}, ""depth"": 1, ""prev_state"": [], ""state_key"": """", ""origin"": ""grin.hu"", ""origin_
server_ts"": 1572699068282, ""hashes"": {""sha256"": ""R5NXXJdBFiv5x9BorOsBPQCCNmN++N7N26TjcULqCiQ""}, ""signatures"": {""grin.hu"": {""ed25519:a_PkUB"": ""JYJKoJqkY9tGH1zvxmW+ahGzY9aqkf/G3jldWndNl4UFOGynZQ2n4Yggi9ZGBIkauscRuAkA4K5eh6e8HLixBQ""}}, ""unsigned""
: {""age_ts"": 1572699068282}}', 'format_version': 3, 'rejected_reason': None, 'redactions': []}}
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File ""/usr/lib/python3/dist-packages/twisted/internet/defer.py"", line 1418, in _inlineCallbacks
result = g.send(result)
StopIteration: {'$k8NsgWNkqATFjHTv5wHMUZ8AxkjmjbYjiTTVtmwnrtc': _EventCacheEntry(event=, redacted_event=None), '$GvoF44EmloKhUIL2gqO8-bD
TisFDn2kHx0YVCbdDThc': _EventCacheEntry(event=, redacted_event=None), '$0xIQjO88lKN0G3ISYi6DZGQZBAcKI0lf2bIP0F5ANdM': _EventCacheEntry(ev
ent=, redacted_event=None), '$yaWi93ApF2JzGFv1s9PNXPIbXq7WO-xKk276_snRWDs': _EventCacheEntry(event=, redacted_event=None), '$9kovxH0Ti3NTfX9eJ-6I80Je1EvVRjJv1D6WUVm-Ssc': _EventCacheEntry(event=, redacted_event=None), '$f3nF3vgpFW5zezEbwUg-_eYNJeC3sSh3ljauGYT0HP4': _EventCacheEntry(event=, redacted_event=None), '$2AilMN5BPoHA674Z0NfiUDJT2KKfcgL1aBKfZ8xUgUI': _EventCacheEntry(event=, redacted_event=None), '$dBZO
Ggyow89xtRsfgg_0-gpKOc-knWTTqHNGcj7jFjg': _EventCacheEntry(event=, redacted_event=None)}
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File ""/usr/lib/python3/dist-packages/twisted/internet/defer.py"", line 1418, in _inlineCallbacks
result = g.send(result)
StopIteration: {'$k8NsgWNkqATFjHTv5wHMUZ8AxkjmjbYjiTTVtmwnrtc': _EventCacheEntry(event=, redacted_event=None), '$GvoF44EmloKhUIL2gqO8-bD
TisFDn2kHx0YVCbdDThc': _EventCacheEntry(event=, redacted_event=None), '$0xIQjO88lKN0G3ISYi6DZGQZBAcKI0lf2bIP0F5ANdM': _EventCacheEntry(ev
ent=, redacted_event=None), '$yaWi93ApF2JzGFv1s9PNXPIbXq7WO-xKk276_snRWDs': _EventCacheEntry(event=, redacted_event=None), '$9kovxH0Ti3NTfX9eJ-6I80Je1EvVRjJv1D6WUVm-Ssc': _EventCacheEntry(event=, redacted_event=None), '$f3nF3vgpFW5zezEbwUg-_eYNJeC3sSh3ljauGYT0HP4': _EventCacheEntry(event=, redacted_event=None), '$2AilMN5BPoHA674Z0NfiUDJT2KKfcgL1aBKfZ8xUgUI': _EventCacheEntry(event=, redacted_event=None), '$dBZO
Ggyow89xtRsfgg_0-gpKOc-knWTTqHNGcj7jFjg': _EventCacheEntry(event=, redacted_event=None)}
```
...and so on...
### Steps to reproduce
- try to add room to +magyarok:grin.hu, get error, do not save
- try to view community rooms again
### Version information
- **Homeserver**:
If not matrix.org: grin.hu
- **Version**:
1.11.1-1 (Debian)
- **Install method**:
Debian (not NV)
",
1210,https://api.github.com/repos/matrix-org/synapse/issues/7077,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7077/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7077/comments,https://api.github.com/repos/matrix-org/synapse/issues/7077/events,https://github.com/matrix-org/synapse/pull/7077,581435604,MDExOlB1bGxSZXF1ZXN0Mzg4NDk3NDg5,7077,Update the nginx section for `reverse_proxy.md`,"{'login': 'thepra', 'id': 7032509, 'node_id': 'MDQ6VXNlcjcwMzI1MDk=', 'avatar_url': 'https://avatars2.githubusercontent.com/u/7032509?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/thepra', 'html_url': 'https://github.com/thepra', 'followers_url': 'https://api.github.com/users/thepra/followers', 'following_url': 'https://api.github.com/users/thepra/following{/other_user}', 'gists_url': 'https://api.github.com/users/thepra/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/thepra/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/thepra/subscriptions', 'organizations_url': 'https://api.github.com/users/thepra/orgs', 'repos_url': 'https://api.github.com/users/thepra/repos', 'events_url': 'https://api.github.com/users/thepra/events{/privacy}', 'received_events_url': 'https://api.github.com/users/thepra/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,"{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}","[{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}]",,1,2020-03-15T00:28:35Z,2020-04-01T17:25:09Z,2020-04-01T17:25:08Z,NONE,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7077', 'html_url': 'https://github.com/matrix-org/synapse/pull/7077', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7077.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7077.patch'}","Added further `.well-known` proxy forwarding and other paths.
Plus an extra note about opening the firewall port 8448 and the same for the eventual router.
",
1211,https://api.github.com/repos/matrix-org/synapse/issues/7076,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7076/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7076/comments,https://api.github.com/repos/matrix-org/synapse/issues/7076/events,https://github.com/matrix-org/synapse/issues/7076,581393678,MDU6SXNzdWU1ODEzOTM2Nzg=,7076,"README claims you can run a ""hot spare"" synapse, which is incorrect","{'login': 'djschilling', 'id': 3503166, 'node_id': 'MDQ6VXNlcjM1MDMxNjY=', 'avatar_url': 'https://avatars0.githubusercontent.com/u/3503166?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/djschilling', 'html_url': 'https://github.com/djschilling', 'followers_url': 'https://api.github.com/users/djschilling/followers', 'following_url': 'https://api.github.com/users/djschilling/following{/other_user}', 'gists_url': 'https://api.github.com/users/djschilling/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/djschilling/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/djschilling/subscriptions', 'organizations_url': 'https://api.github.com/users/djschilling/orgs', 'repos_url': 'https://api.github.com/users/djschilling/repos', 'events_url': 'https://api.github.com/users/djschilling/events{/privacy}', 'received_events_url': 'https://api.github.com/users/djschilling/received_events', 'type': 'User', 'site_admin': False}","[{'id': 845245048, 'node_id': 'MDU6TGFiZWw4NDUyNDUwNDg=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/docs', 'name': 'docs', 'color': '0e8a16', 'default': False, 'description': ''}]",closed,False,,[],,6,2020-03-14T22:11:51Z,2020-07-29T14:35:45Z,2020-07-29T14:35:45Z,NONE,,,"In the Readme i read the following sentence:
`allowing basic active/backup high-availability with a ""hot spare"" synapse pointing at the same DB master, as well as enabling DB replication in synapse itself.`
But i cannot find any documentation how this ha setup should work.
I also asked in the Matrix Channel Synapse Admins but no one could give me help there.
The only issue i found related is this one: https://github.com/matrix-org/synapse/issues/2123
So the questions that i would like to see answered in the docs are:
* What type of postres replication should i use?
* I like the setup described here, but i have no experience with synapse und some guidance of typical setups would be nice: https://medium.com/searce/design-a-highly-available-postgresql-cluster-with-patroni-in-gcp-part-1-dfb6ed277806
* How can i achieve a `hot spare` setup as described in the documentation?
* When possible how could i achieve a ""real"" ha setup, using two or more matrix servers behind a loadbalancer?",
1212,https://api.github.com/repos/matrix-org/synapse/issues/7075,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7075/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7075/comments,https://api.github.com/repos/matrix-org/synapse/issues/7075/events,https://github.com/matrix-org/synapse/issues/7075,580795139,MDU6SXNzdWU1ODA3OTUxMzk=,7075,2/3 of non-email push notifications seem to not go through,"{'login': 'babolivier', 'id': 5547783, 'node_id': 'MDQ6VXNlcjU1NDc3ODM=', 'avatar_url': 'https://avatars3.githubusercontent.com/u/5547783?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/babolivier', 'html_url': 'https://github.com/babolivier', 'followers_url': 'https://api.github.com/users/babolivier/followers', 'following_url': 'https://api.github.com/users/babolivier/following{/other_user}', 'gists_url': 'https://api.github.com/users/babolivier/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/babolivier/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/babolivier/subscriptions', 'organizations_url': 'https://api.github.com/users/babolivier/orgs', 'repos_url': 'https://api.github.com/users/babolivier/repos', 'events_url': 'https://api.github.com/users/babolivier/events{/privacy}', 'received_events_url': 'https://api.github.com/users/babolivier/received_events', 'type': 'User', 'site_admin': False}","[{'id': 121086029, 'node_id': 'MDU6TGFiZWwxMjEwODYwMjk=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/bug', 'name': 'bug', 'color': 'fc2929', 'default': True, 'description': None}, {'id': 477045093, 'node_id': 'MDU6TGFiZWw0NzcwNDUwOTM=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/p1', 'name': 'p1', 'color': 'd93f0b', 'default': False, 'description': None}]",closed,False,"{'login': 'clokep', 'id': 517124, 'node_id': 'MDQ6VXNlcjUxNzEyNA==', 'avatar_url': 'https://avatars2.githubusercontent.com/u/517124?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/clokep', 'html_url': 'https://github.com/clokep', 'followers_url': 'https://api.github.com/users/clokep/followers', 'following_url': 'https://api.github.com/users/clokep/following{/other_user}', 'gists_url': 'https://api.github.com/users/clokep/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/clokep/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/clokep/subscriptions', 'organizations_url': 'https://api.github.com/users/clokep/orgs', 'repos_url': 'https://api.github.com/users/clokep/repos', 'events_url': 'https://api.github.com/users/clokep/events{/privacy}', 'received_events_url': 'https://api.github.com/users/clokep/received_events', 'type': 'User', 'site_admin': False}","[{'login': 'clokep', 'id': 517124, 'node_id': 'MDQ6VXNlcjUxNzEyNA==', 'avatar_url': 'https://avatars2.githubusercontent.com/u/517124?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/clokep', 'html_url': 'https://github.com/clokep', 'followers_url': 'https://api.github.com/users/clokep/followers', 'following_url': 'https://api.github.com/users/clokep/following{/other_user}', 'gists_url': 'https://api.github.com/users/clokep/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/clokep/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/clokep/subscriptions', 'organizations_url': 'https://api.github.com/users/clokep/orgs', 'repos_url': 'https://api.github.com/users/clokep/repos', 'events_url': 'https://api.github.com/users/clokep/events{/privacy}', 'received_events_url': 'https://api.github.com/users/clokep/received_events', 'type': 'User', 'site_admin': False}]",,3,2020-03-13T19:22:08Z,2020-03-19T10:49:55Z,2020-03-19T10:49:55Z,MEMBER,,,"(it might be email as well but we don't have enough stats for them)
We've received report that some users weren't receiving push notifications either via email or on their devices (i.e. via APNS or FCM). The graph for HTTP push (the latter category) on matrix.org seems to show a 2/3 drop on February 27th:
![image](https://user-images.githubusercontent.com/5547783/76650384-6e499700-655a-11ea-8047-751a99209b38.png)
The pusher worker's logs seem to indicate the same trend:
```
$ zgrep ""Received response to POST http://[SYGNAL'S IP]/_matrix/push/v1/notify"" pusher1.log-20200218.gz | wc -l
3153656
```
(on Feb 18th)
```
$ zgrep ""Received response to POST http://[SYGNAL'S IP]/_matrix/push/v1/notify"" pusher1.log-20200310.gz | wc -l
931077
```
(on Mar 10th)
Feb 27th seems to match with a deployment of Synapse matrix.org, so it seems fair to say this is probably a Synapse issue and the cause should be a changed that happened between then and Feb 19th (the previous deployment, which didn't seem to have that bug). https://github.com/matrix-org/synapse/pull/6964 seems like a likely suspect, though I didn't get far enough in my investigation to confirm this theory.
According to what @manuroe told me, it seems like a user can temporarily fix this issue by restarting their client, which causes it to re-register the pusher. But it turns out it's only a temporary fix because a device fixed like this can stop receiving notifications again after a short while (I think @dbkr experienced that).
Another point of interest is that, while investigating @jryans's missing email notifs (which I thought might be coming from the same issue, but I have no evidence to confirm nor deny this theory right now), I could see that Synapse's database (in the `pushers` table) claimed to have that the last successful email notification was sent to his address two days ago while he hasn't received any since Feb 27th. It might be unrelated, but the fact that the date coincides with this bug and that email pushes don't seem to be entirely broken (I managed to get an email notif sent to an address associated with my matrix.org account earlier today), I thought it worth it to mention it here.
My first hunch was that the pusher wasn't replicated correctly from the master to the pusher worker, and that hunch was coming from the fact that for Ryan's account, the replication notifier would log ""Streaming: pushers -> [PUSHER ID]"" for the HTTP pusher(s) but not the email one (which was the problematic one), but it looks like it only logs that for HTTP pushers so it's might not be coming from there.",
1213,https://api.github.com/repos/matrix-org/synapse/issues/7074,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7074/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7074/comments,https://api.github.com/repos/matrix-org/synapse/issues/7074/events,https://github.com/matrix-org/synapse/pull/7074,580499044,MDExOlB1bGxSZXF1ZXN0Mzg3Njk0ODI1,7074,Fix buggy condition in account validity handler,"{'login': 'babolivier', 'id': 5547783, 'node_id': 'MDQ6VXNlcjU1NDc3ODM=', 'avatar_url': 'https://avatars3.githubusercontent.com/u/5547783?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/babolivier', 'html_url': 'https://github.com/babolivier', 'followers_url': 'https://api.github.com/users/babolivier/followers', 'following_url': 'https://api.github.com/users/babolivier/following{/other_user}', 'gists_url': 'https://api.github.com/users/babolivier/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/babolivier/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/babolivier/subscriptions', 'organizations_url': 'https://api.github.com/users/babolivier/orgs', 'repos_url': 'https://api.github.com/users/babolivier/repos', 'events_url': 'https://api.github.com/users/babolivier/events{/privacy}', 'received_events_url': 'https://api.github.com/users/babolivier/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,0,2020-03-13T10:11:54Z,2020-03-16T12:16:32Z,2020-03-16T12:16:31Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7074', 'html_url': 'https://github.com/matrix-org/synapse/pull/7074', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7074.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7074.patch'}",Otherwise renewal emails would be sent even if enabled is set to false in the account validity config.,
1214,https://api.github.com/repos/matrix-org/synapse/issues/7073,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7073/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7073/comments,https://api.github.com/repos/matrix-org/synapse/issues/7073/events,https://github.com/matrix-org/synapse/issues/7073,580417449,MDU6SXNzdWU1ODA0MTc0NDk=,7073,Disable / turn off direct messages,"{'login': 'george-angel', 'id': 1801067, 'node_id': 'MDQ6VXNlcjE4MDEwNjc=', 'avatar_url': 'https://avatars0.githubusercontent.com/u/1801067?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/george-angel', 'html_url': 'https://github.com/george-angel', 'followers_url': 'https://api.github.com/users/george-angel/followers', 'following_url': 'https://api.github.com/users/george-angel/following{/other_user}', 'gists_url': 'https://api.github.com/users/george-angel/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/george-angel/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/george-angel/subscriptions', 'organizations_url': 'https://api.github.com/users/george-angel/orgs', 'repos_url': 'https://api.github.com/users/george-angel/repos', 'events_url': 'https://api.github.com/users/george-angel/events{/privacy}', 'received_events_url': 'https://api.github.com/users/george-angel/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,2,2020-03-13T07:20:34Z,2020-03-13T08:56:21Z,2020-03-13T08:56:21Z,NONE,,,"**Description:**
Hello, we have a rather specific use-case where we would like to use matrix internally for teams in the company, but we would like to only allow room conversations, no direct messages (apart from few select members may be).
Is this at all possible? Happy to hear any hacky solution you might have.
Currently we are looking to use Slack and to drop packages on the firewall where URI matches structures of a DM.
So yes, you could say we are flexible.",
1215,https://api.github.com/repos/matrix-org/synapse/issues/7072,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7072/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7072/comments,https://api.github.com/repos/matrix-org/synapse/issues/7072/events,https://github.com/matrix-org/synapse/issues/7072,580217709,MDU6SXNzdWU1ODAyMTc3MDk=,7072,What means realm=turn.myserver.org? I am trying to figure this out to work with matrix-synapse,"{'login': 'jcabrerazuniga', 'id': 27739794, 'node_id': 'MDQ6VXNlcjI3NzM5Nzk0', 'avatar_url': 'https://avatars1.githubusercontent.com/u/27739794?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/jcabrerazuniga', 'html_url': 'https://github.com/jcabrerazuniga', 'followers_url': 'https://api.github.com/users/jcabrerazuniga/followers', 'following_url': 'https://api.github.com/users/jcabrerazuniga/following{/other_user}', 'gists_url': 'https://api.github.com/users/jcabrerazuniga/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/jcabrerazuniga/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/jcabrerazuniga/subscriptions', 'organizations_url': 'https://api.github.com/users/jcabrerazuniga/orgs', 'repos_url': 'https://api.github.com/users/jcabrerazuniga/repos', 'events_url': 'https://api.github.com/users/jcabrerazuniga/events{/privacy}', 'received_events_url': 'https://api.github.com/users/jcabrerazuniga/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,9,2020-03-12T21:04:20Z,2020-03-17T19:15:29Z,2020-03-17T12:22:50Z,NONE,,,"I am a bit confused here. Do we need to replace:
turn.myserver.org
with some string related to our homeserver?
Since there is a web site using myserver.org I believe I shouldn’t touch this line.
Am I missing something?
",
1216,https://api.github.com/repos/matrix-org/synapse/issues/7071,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7071/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7071/comments,https://api.github.com/repos/matrix-org/synapse/issues/7071/events,https://github.com/matrix-org/synapse/issues/7071,580199032,MDU6SXNzdWU1ODAxOTkwMzI=,7071,Constant high load on IO writes for postgres setup,"{'login': 'RuralYak', 'id': 25221496, 'node_id': 'MDQ6VXNlcjI1MjIxNDk2', 'avatar_url': 'https://avatars3.githubusercontent.com/u/25221496?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/RuralYak', 'html_url': 'https://github.com/RuralYak', 'followers_url': 'https://api.github.com/users/RuralYak/followers', 'following_url': 'https://api.github.com/users/RuralYak/following{/other_user}', 'gists_url': 'https://api.github.com/users/RuralYak/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/RuralYak/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/RuralYak/subscriptions', 'organizations_url': 'https://api.github.com/users/RuralYak/orgs', 'repos_url': 'https://api.github.com/users/RuralYak/repos', 'events_url': 'https://api.github.com/users/RuralYak/events{/privacy}', 'received_events_url': 'https://api.github.com/users/RuralYak/received_events', 'type': 'User', 'site_admin': False}","[{'id': 121086029, 'node_id': 'MDU6TGFiZWwxMjEwODYwMjk=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/bug', 'name': 'bug', 'color': 'fc2929', 'default': True, 'description': None}, {'id': 477050471, 'node_id': 'MDU6TGFiZWw0NzcwNTA0NzE=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/p3', 'name': 'p3', 'color': '0e8a16', 'default': False, 'description': None}, {'id': 600557921, 'node_id': 'MDU6TGFiZWw2MDA1NTc5MjE=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/performance', 'name': 'performance', 'color': 'fef2c0', 'default': False, 'description': None}]",open,False,,[],,3,2020-03-12T20:24:28Z,2020-04-20T15:11:54Z,,NONE,,,"# Description
Postgress 12 db constantly produce high rate of IO writes to state_groups_state adding ~ 10000 new records per second. So the number of records for some rooms could reach 100M
### Steps to reproduce
- join active room (Synapse Admin for example)
- observe number of records for it
```
select count(1) from state_groups_state where room_id='!mjbDjyNsRXndKLkHIe:matrix.org';
count
```
ER: Growth of the table state_groups_state should be reasonable: 1K/ day for a single room
AR: Abnormal number of new rows resulting in constant disk writes could reach 10K/sec
![image](https://user-images.githubusercontent.com/25221496/76563693-24cb5000-6465-11ea-865d-33102f8fe685.png)
### Version information
synapse version:
curl http://localhost:8008/_synapse/admin/v1/server_version
{
""python_version"": ""3.7.6"",
""server_version"": ""1.11.1""
}
postgress: 12.2 (Debian 12.2-2.pgdg100+1))
- **Install method**:
docker image matrixdotorg/synapse:latest
sha256:0ca8c818316529cca0dd12fc26157e31f593763a4e13eaf55ebe3e71b906583b
- **Platform**:
Kernel Version: 4.15.0-88-generic
Operating System: Ubuntu 18.04.4 LTS
OSType: linux
Architecture: x86_64
CPUs: 4
Total Memory: 7.488GiB
Docker Server Version: 19.03.7
# Logs
[server_logs.zip](https://github.com/matrix-org/synapse/files/4326416/server_logs.zip)
",
1217,https://api.github.com/repos/matrix-org/synapse/issues/7070,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7070/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7070/comments,https://api.github.com/repos/matrix-org/synapse/issues/7070/events,https://github.com/matrix-org/synapse/pull/7070,580106147,MDExOlB1bGxSZXF1ZXN0Mzg3Mzc4NzEz,7070,Populate the room version from state events,"{'login': 'babolivier', 'id': 5547783, 'node_id': 'MDQ6VXNlcjU1NDc3ODM=', 'avatar_url': 'https://avatars3.githubusercontent.com/u/5547783?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/babolivier', 'html_url': 'https://github.com/babolivier', 'followers_url': 'https://api.github.com/users/babolivier/followers', 'following_url': 'https://api.github.com/users/babolivier/following{/other_user}', 'gists_url': 'https://api.github.com/users/babolivier/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/babolivier/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/babolivier/subscriptions', 'organizations_url': 'https://api.github.com/users/babolivier/orgs', 'repos_url': 'https://api.github.com/users/babolivier/repos', 'events_url': 'https://api.github.com/users/babolivier/events{/privacy}', 'received_events_url': 'https://api.github.com/users/babolivier/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,0,2020-03-12T17:39:04Z,2020-03-16T22:31:50Z,2020-03-16T22:31:48Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7070', 'html_url': 'https://github.com/matrix-org/synapse/pull/7070', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7070.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7070.patch'}","Fixes #7065
This is basically the same as https://github.com/matrix-org/synapse/pull/6847 except it tries to populate events from `state_events` rather than `current_state_events`, since this table might have been cleared from the state of some rooms too early, leaving them with a `NULL` room version.",
1218,https://api.github.com/repos/matrix-org/synapse/issues/7069,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7069/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7069/comments,https://api.github.com/repos/matrix-org/synapse/issues/7069/events,https://github.com/matrix-org/synapse/issues/7069,579928122,MDU6SXNzdWU1Nzk5MjgxMjI=,7069,/publicRooms should consider alt_aliases for returned aliases,"{'login': 'bwindels', 'id': 274386, 'node_id': 'MDQ6VXNlcjI3NDM4Ng==', 'avatar_url': 'https://avatars1.githubusercontent.com/u/274386?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bwindels', 'html_url': 'https://github.com/bwindels', 'followers_url': 'https://api.github.com/users/bwindels/followers', 'following_url': 'https://api.github.com/users/bwindels/following{/other_user}', 'gists_url': 'https://api.github.com/users/bwindels/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/bwindels/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/bwindels/subscriptions', 'organizations_url': 'https://api.github.com/users/bwindels/orgs', 'repos_url': 'https://api.github.com/users/bwindels/repos', 'events_url': 'https://api.github.com/users/bwindels/events{/privacy}', 'received_events_url': 'https://api.github.com/users/bwindels/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,7,2020-03-12T13:10:51Z,2020-03-18T15:17:54Z,2020-03-18T14:05:13Z,MEMBER,,,"Currently, Synapse only returns the canonical alias for returned rooms from the `/publicRooms` endpoint. `alt_aliases` in the canonical alias event should also be considered to return in the `aliases` field.
Before the changes for MSC2432, Synapse would also return local aliases in the `aliases` field in the `/publicRooms` response. This had the nice property of making rooms joinable over federation through the room directory without moderator intervention. Should we consider to return a (subset) of the local aliases if no canonical alias or alt_aliases have been set for a public room? Spam should be easily avoidable that way by just setting a canonical alias.",
1219,https://api.github.com/repos/matrix-org/synapse/issues/7068,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7068/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7068/comments,https://api.github.com/repos/matrix-org/synapse/issues/7068/events,https://github.com/matrix-org/synapse/pull/7068,579524459,MDExOlB1bGxSZXF1ZXN0Mzg2OTAzMDQ4,7068,Validate that a UI-Auth session is not being reused,"{'login': 'clokep', 'id': 517124, 'node_id': 'MDQ6VXNlcjUxNzEyNA==', 'avatar_url': 'https://avatars2.githubusercontent.com/u/517124?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/clokep', 'html_url': 'https://github.com/clokep', 'followers_url': 'https://api.github.com/users/clokep/followers', 'following_url': 'https://api.github.com/users/clokep/following{/other_user}', 'gists_url': 'https://api.github.com/users/clokep/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/clokep/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/clokep/subscriptions', 'organizations_url': 'https://api.github.com/users/clokep/orgs', 'repos_url': 'https://api.github.com/users/clokep/repos', 'events_url': 'https://api.github.com/users/clokep/events{/privacy}', 'received_events_url': 'https://api.github.com/users/clokep/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,5,2020-03-11T20:23:34Z,2020-03-26T11:39:37Z,2020-03-26T11:39:35Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7068', 'html_url': 'https://github.com/matrix-org/synapse/pull/7068', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7068.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7068.patch'}","This is my attempt to fix:
> make sure that UI-Auth sessions are tied to a single request (ie, the client can't change its mind about what it's asking for in the middle of a session)
The general idea is to store some additional information in the session about what is being authenticated (namely the URI, the method, and the data associated with whatever operation is being performed). So at each stage in when we check the status of the user interactive authentication session we ensure that the event being authenticated for has not been modified.
~~This isn't fully finished, but I wanted to put this up and get some feedback.~~
Part of #5667
## TODO
* [x] Finalize design.
* [x] Fix unit tests.
~~Currently based on #7063.~~",
1220,https://api.github.com/repos/matrix-org/synapse/issues/7067,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7067/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7067/comments,https://api.github.com/repos/matrix-org/synapse/issues/7067/events,https://github.com/matrix-org/synapse/pull/7067,579498897,MDExOlB1bGxSZXF1ZXN0Mzg2ODgyMjQz,7067,Move the default SAML2 error HTML to a dedicated file,"{'login': 'babolivier', 'id': 5547783, 'node_id': 'MDQ6VXNlcjU1NDc3ODM=', 'avatar_url': 'https://avatars3.githubusercontent.com/u/5547783?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/babolivier', 'html_url': 'https://github.com/babolivier', 'followers_url': 'https://api.github.com/users/babolivier/followers', 'following_url': 'https://api.github.com/users/babolivier/following{/other_user}', 'gists_url': 'https://api.github.com/users/babolivier/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/babolivier/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/babolivier/subscriptions', 'organizations_url': 'https://api.github.com/users/babolivier/orgs', 'repos_url': 'https://api.github.com/users/babolivier/repos', 'events_url': 'https://api.github.com/users/babolivier/events{/privacy}', 'received_events_url': 'https://api.github.com/users/babolivier/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,0,2020-03-11T19:37:23Z,2020-03-13T19:53:21Z,2020-03-13T19:53:20Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7067', 'html_url': 'https://github.com/matrix-org/synapse/pull/7067', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7067.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7067.patch'}","Also add some JS to it to process any error we might have in the URI
(see #6893).",
1221,https://api.github.com/repos/matrix-org/synapse/issues/7066,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7066/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7066/comments,https://api.github.com/repos/matrix-org/synapse/issues/7066/events,https://github.com/matrix-org/synapse/pull/7066,579449454,MDExOlB1bGxSZXF1ZXN0Mzg2ODQxMjQz,7066,Skip the correct visibility checks when checking the visibility of the state at a given event,"{'login': 'babolivier', 'id': 5547783, 'node_id': 'MDQ6VXNlcjU1NDc3ODM=', 'avatar_url': 'https://avatars3.githubusercontent.com/u/5547783?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/babolivier', 'html_url': 'https://github.com/babolivier', 'followers_url': 'https://api.github.com/users/babolivier/followers', 'following_url': 'https://api.github.com/users/babolivier/following{/other_user}', 'gists_url': 'https://api.github.com/users/babolivier/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/babolivier/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/babolivier/subscriptions', 'organizations_url': 'https://api.github.com/users/babolivier/orgs', 'repos_url': 'https://api.github.com/users/babolivier/repos', 'events_url': 'https://api.github.com/users/babolivier/events{/privacy}', 'received_events_url': 'https://api.github.com/users/babolivier/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,0,2020-03-11T18:04:10Z,2020-03-11T20:08:00Z,2020-03-11T20:07:59Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7066', 'html_url': 'https://github.com/matrix-org/synapse/pull/7066', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7066.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7066.patch'}","Otherwise the requesting user will get told `User @alice:example.com not allowed to view events in room !someroom:example.com at token StreamToken(...)`.
Technical explanation on why this causes Riot to show that error every time we render a room (as copy-pasted from internal room):
> Basically Riot will ask the server for the list of members in a room each time you render that room in Riot, using the latest sync token it knows about or something like that. Synapse then proceeds to check if the user is allowed to see the latest event before this token based on the state at that event, which happens to be the same function call as when wondering if Synapse should send an event to the client, which is a similar question but not exactly the same. For example, we don't want to send dummy events to clients, but we also don't want that to mean ""users don't have the perms to see any event in the room with the state at that point in the dag"". So we've introduced a flag that allows this function to make the difference between these two use cases, and that flag causes a few tests to be skipped when we're in the ""checking visibility"" one. Except that we weren't applying it on messages sent by a user that had been ignored.
>
> So if that semi-random event happened to be from a user I'm ignoring, Synapse is going to tell me that I can't see the state of the room at that event with this ""not allowed to view events in room"" error.",
1222,https://api.github.com/repos/matrix-org/synapse/issues/7065,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7065/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7065/comments,https://api.github.com/repos/matrix-org/synapse/issues/7065/events,https://github.com/matrix-org/synapse/issues/7065,579241459,MDU6SXNzdWU1NzkyNDE0NTk=,7065,"Initial /sync is returning 404 due to ""unknown room"" when processing an event.","{'login': 'ara4n', 'id': 1294269, 'node_id': 'MDQ6VXNlcjEyOTQyNjk=', 'avatar_url': 'https://avatars2.githubusercontent.com/u/1294269?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/ara4n', 'html_url': 'https://github.com/ara4n', 'followers_url': 'https://api.github.com/users/ara4n/followers', 'following_url': 'https://api.github.com/users/ara4n/following{/other_user}', 'gists_url': 'https://api.github.com/users/ara4n/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/ara4n/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/ara4n/subscriptions', 'organizations_url': 'https://api.github.com/users/ara4n/orgs', 'repos_url': 'https://api.github.com/users/ara4n/repos', 'events_url': 'https://api.github.com/users/ara4n/events{/privacy}', 'received_events_url': 'https://api.github.com/users/ara4n/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,6,2020-03-11T12:51:31Z,2020-03-16T22:32:08Z,2020-03-16T22:32:07Z,MEMBER,,,"My account is currently unable to initial /sync and is broken with:
```
$ grep GET-17237 initial_synchrotron4.log
2020-03-11 00:13:02,176 - synapse.storage.data_stores.main.events_worker - 592 - WARNING - GET-17237 - Room !YkSMpYmmunCikXWFkB:matrix.org for event $3AJgBnxl5BLJs3Sp0L3GWojCeItDi98uVpmuqWH-vJc is unknown
2020-03-11 00:13:02,177 - synapse.http.server - 81 - INFO - GET-17237 - SynapseError: 404 - Could not find event $3AJgBnxl5BLJs3Sp0L3GWojCeItDi98uVpmuqWH-vJc
2020-03-11 00:13:02,178 - synapse.access.http.8108 - 302 - INFO - GET-17237 - 92.234.32.44 - 8108 - {@matthew:matrix.org} Processed request: 3.956sec/0.000sec (2.098sec, 0.621sec) (0.203sec/1.574sec/2) 101B 404 ""GET /_matrix/client/r0/sync?filter=139&timeout=0 HTTP/1.1"" ""Riot/0.11.0 (iPhone; iOS 13.3.1; Scale/3.00)"" [1 dbevts]
```
The `$...-vJc` event is an invite event for my user to a room I hadn't yet accepted.
This circumstantially looks related to the new redaction stuff in #6875 - perhaps in conjunction with stuck invite bugs, or failing to set room_version on unaccepted invites, or something else...",
1223,https://api.github.com/repos/matrix-org/synapse/issues/7064,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7064/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7064/comments,https://api.github.com/repos/matrix-org/synapse/issues/7064/events,https://github.com/matrix-org/synapse/issues/7064,579233106,MDU6SXNzdWU1NzkyMzMxMDY=,7064,We should surely be logging requests when they come in.,"{'login': 'ara4n', 'id': 1294269, 'node_id': 'MDQ6VXNlcjEyOTQyNjk=', 'avatar_url': 'https://avatars2.githubusercontent.com/u/1294269?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/ara4n', 'html_url': 'https://github.com/ara4n', 'followers_url': 'https://api.github.com/users/ara4n/followers', 'following_url': 'https://api.github.com/users/ara4n/following{/other_user}', 'gists_url': 'https://api.github.com/users/ara4n/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/ara4n/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/ara4n/subscriptions', 'organizations_url': 'https://api.github.com/users/ara4n/orgs', 'repos_url': 'https://api.github.com/users/ara4n/repos', 'events_url': 'https://api.github.com/users/ara4n/events{/privacy}', 'received_events_url': 'https://api.github.com/users/ara4n/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,4,2020-03-11T12:36:38Z,2020-04-02T13:42:40Z,2020-04-02T13:42:39Z,MEMBER,,,"http://github.com/matrix-org/synapse/pull/6862 moves the 'received request' logline to debug log level. As a result, you can no longer see when requests are coming in and stacking up without being processed (which historically has been a very common failure mode in Synapse, as things get stuck behind a lock or lineariser or whatever), given it could be tens of minutes before the processed logline appears, and you no longer have any way to see the request come in. You also can no longer read the log lines chronologically - you get random information about a request which is in progress without actually knowing what the request was... until it completes (assuming it gets stuck). I am very surprised at https://github.com/matrix-org/synapse/pull/6862/files#r375819342, and would love to know why this is considered the 'right choice'.",
1224,https://api.github.com/repos/matrix-org/synapse/issues/7063,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7063/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7063/comments,https://api.github.com/repos/matrix-org/synapse/issues/7063/events,https://github.com/matrix-org/synapse/pull/7063,579227364,MDExOlB1bGxSZXF1ZXN0Mzg2NjU5Mzk5,7063,Add type annotations and comments to auth handler,"{'login': 'clokep', 'id': 517124, 'node_id': 'MDQ6VXNlcjUxNzEyNA==', 'avatar_url': 'https://avatars2.githubusercontent.com/u/517124?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/clokep', 'html_url': 'https://github.com/clokep', 'followers_url': 'https://api.github.com/users/clokep/followers', 'following_url': 'https://api.github.com/users/clokep/following{/other_user}', 'gists_url': 'https://api.github.com/users/clokep/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/clokep/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/clokep/subscriptions', 'organizations_url': 'https://api.github.com/users/clokep/orgs', 'repos_url': 'https://api.github.com/users/clokep/repos', 'events_url': 'https://api.github.com/users/clokep/events{/privacy}', 'received_events_url': 'https://api.github.com/users/clokep/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,0,2020-03-11T12:26:05Z,2020-03-12T15:36:29Z,2020-03-12T15:36:28Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7063', 'html_url': 'https://github.com/matrix-org/synapse/pull/7063', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7063.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7063.patch'}",While working on #5667 I started adding some docstrings / type information for myself. Figured it was worth cleaning up and merging.,
1225,https://api.github.com/repos/matrix-org/synapse/issues/7062,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7062/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7062/comments,https://api.github.com/repos/matrix-org/synapse/issues/7062/events,https://github.com/matrix-org/synapse/issues/7062,579106956,MDU6SXNzdWU1NzkxMDY5NTY=,7062,coturn server Relay not work,"{'login': 'wjhtinger', 'id': 1773284, 'node_id': 'MDQ6VXNlcjE3NzMyODQ=', 'avatar_url': 'https://avatars0.githubusercontent.com/u/1773284?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/wjhtinger', 'html_url': 'https://github.com/wjhtinger', 'followers_url': 'https://api.github.com/users/wjhtinger/followers', 'following_url': 'https://api.github.com/users/wjhtinger/following{/other_user}', 'gists_url': 'https://api.github.com/users/wjhtinger/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/wjhtinger/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/wjhtinger/subscriptions', 'organizations_url': 'https://api.github.com/users/wjhtinger/orgs', 'repos_url': 'https://api.github.com/users/wjhtinger/repos', 'events_url': 'https://api.github.com/users/wjhtinger/events{/privacy}', 'received_events_url': 'https://api.github.com/users/wjhtinger/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,6,2020-03-11T09:02:52Z,2020-03-17T12:08:09Z,2020-03-17T12:08:09Z,NONE,,,"I set a coturn server according to the turn-howto.md. I use riot-android do the test and the STUN work well. But in some networks, STUN not success, but the Relay not work too. That means TURN not work, right?
So, what wrong with my server? How can I debug the problem?",
1226,https://api.github.com/repos/matrix-org/synapse/issues/7061,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7061/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7061/comments,https://api.github.com/repos/matrix-org/synapse/issues/7061/events,https://github.com/matrix-org/synapse/issues/7061,578758103,MDU6SXNzdWU1Nzg3NTgxMDM=,7061,Clients doesn't receive notifications until the app is open,"{'login': 'amarquez80', 'id': 12921874, 'node_id': 'MDQ6VXNlcjEyOTIxODc0', 'avatar_url': 'https://avatars3.githubusercontent.com/u/12921874?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/amarquez80', 'html_url': 'https://github.com/amarquez80', 'followers_url': 'https://api.github.com/users/amarquez80/followers', 'following_url': 'https://api.github.com/users/amarquez80/following{/other_user}', 'gists_url': 'https://api.github.com/users/amarquez80/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/amarquez80/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/amarquez80/subscriptions', 'organizations_url': 'https://api.github.com/users/amarquez80/orgs', 'repos_url': 'https://api.github.com/users/amarquez80/repos', 'events_url': 'https://api.github.com/users/amarquez80/events{/privacy}', 'received_events_url': 'https://api.github.com/users/amarquez80/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,1,2020-03-10T17:51:30Z,2020-03-16T16:02:55Z,2020-03-16T16:02:54Z,NONE,,,"Hi everyone I'm having problems with notifications
they arrive only if the app is open
this behavior is the same on iPhone and Android clients.
Someone has been through a similar situation?
Thanks",
1227,https://api.github.com/repos/matrix-org/synapse/issues/7060,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7060/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7060/comments,https://api.github.com/repos/matrix-org/synapse/issues/7060/events,https://github.com/matrix-org/synapse/issues/7060,578751396,MDU6SXNzdWU1Nzg3NTEzOTY=,7060,Support for more architectures,"{'login': 'schnaitterm', 'id': 9668910, 'node_id': 'MDQ6VXNlcjk2Njg5MTA=', 'avatar_url': 'https://avatars0.githubusercontent.com/u/9668910?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/schnaitterm', 'html_url': 'https://github.com/schnaitterm', 'followers_url': 'https://api.github.com/users/schnaitterm/followers', 'following_url': 'https://api.github.com/users/schnaitterm/following{/other_user}', 'gists_url': 'https://api.github.com/users/schnaitterm/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/schnaitterm/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/schnaitterm/subscriptions', 'organizations_url': 'https://api.github.com/users/schnaitterm/orgs', 'repos_url': 'https://api.github.com/users/schnaitterm/repos', 'events_url': 'https://api.github.com/users/schnaitterm/events{/privacy}', 'received_events_url': 'https://api.github.com/users/schnaitterm/received_events', 'type': 'User', 'site_admin': False}","[{'id': 1311133228, 'node_id': 'MDU6TGFiZWwxMzExMTMzMjI4', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/info-needed', 'name': 'info-needed', 'color': 'a1e8ea', 'default': False, 'description': ''}]",closed,False,,[],,3,2020-03-10T17:39:25Z,2020-04-02T14:19:07Z,2020-04-02T14:19:07Z,NONE,,,"This package, being python, should be pretty easy to package as an all/noarch package, at least for Debian and the like. Is there as specific reason for the following case statement in `debian/build_virtualenv`?
```
case `dpkg-architecture -q DEB_HOST_ARCH` in
amd64)
export CFLAGS=-march=x86-64
;;
esac
```
As in, would something break if this were to be removed? The gcc defaults when `-march` isn't specified should be generic enough. If we take this out, we can then change the `Architecture: amd64` line in `debian/control` to `Architecture: all`. I hacked this when building it myself on system Z (S390x) and it seems to be working fine.",
1228,https://api.github.com/repos/matrix-org/synapse/issues/7059,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7059/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7059/comments,https://api.github.com/repos/matrix-org/synapse/issues/7059/events,https://github.com/matrix-org/synapse/pull/7059,578745119,MDExOlB1bGxSZXF1ZXN0Mzg2MjY4MzAx,7059,Add OAuth2 support,"{'login': 'maxklenk', 'id': 3898310, 'node_id': 'MDQ6VXNlcjM4OTgzMTA=', 'avatar_url': 'https://avatars0.githubusercontent.com/u/3898310?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/maxklenk', 'html_url': 'https://github.com/maxklenk', 'followers_url': 'https://api.github.com/users/maxklenk/followers', 'following_url': 'https://api.github.com/users/maxklenk/following{/other_user}', 'gists_url': 'https://api.github.com/users/maxklenk/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/maxklenk/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/maxklenk/subscriptions', 'organizations_url': 'https://api.github.com/users/maxklenk/orgs', 'repos_url': 'https://api.github.com/users/maxklenk/repos', 'events_url': 'https://api.github.com/users/maxklenk/events{/privacy}', 'received_events_url': 'https://api.github.com/users/maxklenk/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,8,2020-03-10T17:28:42Z,2020-05-05T11:14:13Z,2020-05-04T21:54:55Z,NONE,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7059', 'html_url': 'https://github.com/matrix-org/synapse/pull/7059', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7059.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7059.patch'}","It is now possible to register and login in using the OAuth2 Authorization Code Flow.
Things to discuss:
- [ ] add support for custom mapping providers similar to the ones used in the SAML integration
- [ ] use of an oAuth library
### Pull Request Checklist
* [x] Pull request is based on the develop branch
* [x] Pull request includes a [changelog file](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#changelog). The entry should:
- Be a short description of your change which makes sense to users. ""Fixed a bug that prevented receiving messages from other servers."" instead of ""Moved X method from `EventStore` to `EventWorkerStore`."".
- Use markdown where necessary, mostly for `code blocks`.
- End with either a period (.) or an exclamation mark (!).
- Start with a capital letter.
* [x] Pull request includes a [sign off](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#sign-off)
* [x] Code style is correct (run the [linters](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#code-style))
Signed-off-by: Max Klenk
",
1229,https://api.github.com/repos/matrix-org/synapse/issues/7058,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7058/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7058/comments,https://api.github.com/repos/matrix-org/synapse/issues/7058/events,https://github.com/matrix-org/synapse/pull/7058,578601515,MDExOlB1bGxSZXF1ZXN0Mzg2MTUxMjgw,7058,SAML2: render a comprehensible error page if something goes wrong,"{'login': 'babolivier', 'id': 5547783, 'node_id': 'MDQ6VXNlcjU1NDc3ODM=', 'avatar_url': 'https://avatars3.githubusercontent.com/u/5547783?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/babolivier', 'html_url': 'https://github.com/babolivier', 'followers_url': 'https://api.github.com/users/babolivier/followers', 'following_url': 'https://api.github.com/users/babolivier/following{/other_user}', 'gists_url': 'https://api.github.com/users/babolivier/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/babolivier/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/babolivier/subscriptions', 'organizations_url': 'https://api.github.com/users/babolivier/orgs', 'repos_url': 'https://api.github.com/users/babolivier/repos', 'events_url': 'https://api.github.com/users/babolivier/events{/privacy}', 'received_events_url': 'https://api.github.com/users/babolivier/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,1,2020-03-10T14:01:35Z,2020-03-10T18:42:17Z,2020-03-10T18:42:16Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7058', 'html_url': 'https://github.com/matrix-org/synapse/pull/7058', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7058.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7058.patch'}","If an error happened while processing a SAML AuthN response, or a client
ends up doing a `GET` request to `/authn_response`, then render a
customisable error page rather than a confusing error.",
1230,https://api.github.com/repos/matrix-org/synapse/issues/7057,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7057/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7057/comments,https://api.github.com/repos/matrix-org/synapse/issues/7057/events,https://github.com/matrix-org/synapse/issues/7057,578448395,MDU6SXNzdWU1Nzg0NDgzOTU=,7057,Auth0 passwordless auth fails if the linked clicked isn't from the first email sent,"{'login': 'babolivier', 'id': 5547783, 'node_id': 'MDQ6VXNlcjU1NDc3ODM=', 'avatar_url': 'https://avatars3.githubusercontent.com/u/5547783?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/babolivier', 'html_url': 'https://github.com/babolivier', 'followers_url': 'https://api.github.com/users/babolivier/followers', 'following_url': 'https://api.github.com/users/babolivier/following{/other_user}', 'gists_url': 'https://api.github.com/users/babolivier/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/babolivier/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/babolivier/subscriptions', 'organizations_url': 'https://api.github.com/users/babolivier/orgs', 'repos_url': 'https://api.github.com/users/babolivier/repos', 'events_url': 'https://api.github.com/users/babolivier/events{/privacy}', 'received_events_url': 'https://api.github.com/users/babolivier/received_events', 'type': 'User', 'site_admin': False}","[{'id': 121086029, 'node_id': 'MDU6TGFiZWwxMjEwODYwMjk=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/bug', 'name': 'bug', 'color': 'fc2929', 'default': True, 'description': None}, {'id': 1793931943, 'node_id': 'MDU6TGFiZWwxNzkzOTMxOTQz', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/mozilla', 'name': 'mozilla', 'color': 'db1c1f', 'default': False, 'description': 'Mozilla feedback'}]",closed,False,,[],,2,2020-03-10T09:36:11Z,2020-03-26T14:32:35Z,2020-03-26T14:32:35Z,MEMBER,,,"Mozilla's Auth0 has email passwordless auth enabled, with a feature that allows one to ask Auth0 to actually email the authentication magic link to another email address than the one initially set. This works in the following way:
* Click the ""Sign in with SSO"" button on https://chat.mozilla.org
* Choose to login with an email, enter an email address (let's say `alice@example.com`) and click ""Enter""
* Confirm (""Send me an email to continue"")
* On the success screen, click the ""Need to send that to a different email?"" link:
![image](https://user-images.githubusercontent.com/5547783/76298214-058bc180-62b1-11ea-89d8-446ca5e0637b.png)
* Get the authentication portal to send a magic link to another email address (let's say `bob@example.com`)
Now, if you click on the link sent to `alice@example.com`, Auth0 gets the user's browser to send a `POST` request to `/authn_response` with a SAML AuthN response, as expected (though I did get bitten by https://github.com/matrix-org/synapse/issues/7056 a few times when trying it out).
However, if you click on the link sent to `bob@example.com`, then your browser ends up doing a `GET` request to `https://mozilla.modular.im/_matrix/saml2/authn_response#access_token=[...]&scope=openid&expires_in=7200&token_type=Bearer&state=[...]`, which has an access token in the URI fragment.
Currently I'm not sure how to use that access token, nor whether I can use it to get an AuthN response to give to Synapse.
I'm also not sure whose fault this is, since this ""Need to send that to a different email?"" link isn't an Auth0 thing but rather a Mozilla one afaict (which lives here: https://github.com/mozilla-iam/auth0-custom-lock).",
1231,https://api.github.com/repos/matrix-org/synapse/issues/7056,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7056/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7056/comments,https://api.github.com/repos/matrix-org/synapse/issues/7056/events,https://github.com/matrix-org/synapse/issues/7056,578446457,MDU6SXNzdWU1Nzg0NDY0NTc=,7056,Unable to parse SAML2 response: Unsolicited response,"{'login': 'babolivier', 'id': 5547783, 'node_id': 'MDQ6VXNlcjU1NDc3ODM=', 'avatar_url': 'https://avatars3.githubusercontent.com/u/5547783?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/babolivier', 'html_url': 'https://github.com/babolivier', 'followers_url': 'https://api.github.com/users/babolivier/followers', 'following_url': 'https://api.github.com/users/babolivier/following{/other_user}', 'gists_url': 'https://api.github.com/users/babolivier/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/babolivier/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/babolivier/subscriptions', 'organizations_url': 'https://api.github.com/users/babolivier/orgs', 'repos_url': 'https://api.github.com/users/babolivier/repos', 'events_url': 'https://api.github.com/users/babolivier/events{/privacy}', 'received_events_url': 'https://api.github.com/users/babolivier/received_events', 'type': 'User', 'site_admin': False}","[{'id': 121086029, 'node_id': 'MDU6TGFiZWwxMjEwODYwMjk=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/bug', 'name': 'bug', 'color': 'fc2929', 'default': True, 'description': None}, {'id': 1793931943, 'node_id': 'MDU6TGFiZWwxNzkzOTMxOTQz', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/mozilla', 'name': 'mozilla', 'color': 'db1c1f', 'default': False, 'description': 'Mozilla feedback'}]",open,False,"{'login': 'clokep', 'id': 517124, 'node_id': 'MDQ6VXNlcjUxNzEyNA==', 'avatar_url': 'https://avatars2.githubusercontent.com/u/517124?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/clokep', 'html_url': 'https://github.com/clokep', 'followers_url': 'https://api.github.com/users/clokep/followers', 'following_url': 'https://api.github.com/users/clokep/following{/other_user}', 'gists_url': 'https://api.github.com/users/clokep/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/clokep/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/clokep/subscriptions', 'organizations_url': 'https://api.github.com/users/clokep/orgs', 'repos_url': 'https://api.github.com/users/clokep/repos', 'events_url': 'https://api.github.com/users/clokep/events{/privacy}', 'received_events_url': 'https://api.github.com/users/clokep/received_events', 'type': 'User', 'site_admin': False}","[{'login': 'clokep', 'id': 517124, 'node_id': 'MDQ6VXNlcjUxNzEyNA==', 'avatar_url': 'https://avatars2.githubusercontent.com/u/517124?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/clokep', 'html_url': 'https://github.com/clokep', 'followers_url': 'https://api.github.com/users/clokep/followers', 'following_url': 'https://api.github.com/users/clokep/following{/other_user}', 'gists_url': 'https://api.github.com/users/clokep/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/clokep/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/clokep/subscriptions', 'organizations_url': 'https://api.github.com/users/clokep/orgs', 'repos_url': 'https://api.github.com/users/clokep/repos', 'events_url': 'https://api.github.com/users/clokep/events{/privacy}', 'received_events_url': 'https://api.github.com/users/clokep/received_events', 'type': 'User', 'site_admin': False}]",,25,2020-03-10T09:32:41Z,2020-09-03T19:09:15Z,,MEMBER,,,"Sometimes, when authenticating with passwordless login on Mozilla's SSO, the user's browser gets told to `POST` to `/authn_response` with a SAML AuthN response (as expected), but that call seems to fail with the error ""Unable to parse SAML2 response: Unsolicited response: id-XXXXXXXXXXXXX"".
I'm currently not sure why this happens.",
1232,https://api.github.com/repos/matrix-org/synapse/issues/7055,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7055/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7055/comments,https://api.github.com/repos/matrix-org/synapse/issues/7055/events,https://github.com/matrix-org/synapse/pull/7055,577945086,MDExOlB1bGxSZXF1ZXN0Mzg1NjE3NjU1,7055,Move get_time_of_last_push_action_before to the EventPushActionsWorkerStore,"{'login': 'babolivier', 'id': 5547783, 'node_id': 'MDQ6VXNlcjU1NDc3ODM=', 'avatar_url': 'https://avatars3.githubusercontent.com/u/5547783?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/babolivier', 'html_url': 'https://github.com/babolivier', 'followers_url': 'https://api.github.com/users/babolivier/followers', 'following_url': 'https://api.github.com/users/babolivier/following{/other_user}', 'gists_url': 'https://api.github.com/users/babolivier/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/babolivier/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/babolivier/subscriptions', 'organizations_url': 'https://api.github.com/users/babolivier/orgs', 'repos_url': 'https://api.github.com/users/babolivier/repos', 'events_url': 'https://api.github.com/users/babolivier/events{/privacy}', 'received_events_url': 'https://api.github.com/users/babolivier/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,1,2020-03-09T14:22:04Z,2020-03-09T14:53:53Z,2020-03-09T14:53:52Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7055', 'html_url': 'https://github.com/matrix-org/synapse/pull/7055', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7055.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7055.patch'}","Fixes #7054
I also had a look at the rest of the functions in
`EventPushActionsStore` and in the push notifications send code and it
looks to me like there shouldn't be any other method with this issue in
this part of the codebase.",
1233,https://api.github.com/repos/matrix-org/synapse/issues/7054,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7054/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7054/comments,https://api.github.com/repos/matrix-org/synapse/issues/7054/events,https://github.com/matrix-org/synapse/issues/7054,577859819,MDU6SXNzdWU1Nzc4NTk4MTk=,7054,AttributeError: 'GenericWorkerSlavedStore' object has no attribute 'get_time_of_last_push_action_before',"{'login': 'babolivier', 'id': 5547783, 'node_id': 'MDQ6VXNlcjU1NDc3ODM=', 'avatar_url': 'https://avatars3.githubusercontent.com/u/5547783?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/babolivier', 'html_url': 'https://github.com/babolivier', 'followers_url': 'https://api.github.com/users/babolivier/followers', 'following_url': 'https://api.github.com/users/babolivier/following{/other_user}', 'gists_url': 'https://api.github.com/users/babolivier/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/babolivier/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/babolivier/subscriptions', 'organizations_url': 'https://api.github.com/users/babolivier/orgs', 'repos_url': 'https://api.github.com/users/babolivier/repos', 'events_url': 'https://api.github.com/users/babolivier/events{/privacy}', 'received_events_url': 'https://api.github.com/users/babolivier/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,1,2020-03-09T12:10:59Z,2020-03-09T17:10:33Z,2020-03-09T17:10:33Z,MEMBER,,,"Happens when sending out new email notifications. Given it happened on `matrix-org-hotfixes` between Feb 19th and Feb 27th, I assume this was caused by https://github.com/matrix-org/synapse/pull/6964.",
1234,https://api.github.com/repos/matrix-org/synapse/issues/7053,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7053/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7053/comments,https://api.github.com/repos/matrix-org/synapse/issues/7053/events,https://github.com/matrix-org/synapse/pull/7053,577504700,MDExOlB1bGxSZXF1ZXN0Mzg1MjY5NjQw,7053,Add options to disable setting profile info for prevent changes.,"{'login': 'dklimpel', 'id': 5740567, 'node_id': 'MDQ6VXNlcjU3NDA1Njc=', 'avatar_url': 'https://avatars2.githubusercontent.com/u/5740567?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/dklimpel', 'html_url': 'https://github.com/dklimpel', 'followers_url': 'https://api.github.com/users/dklimpel/followers', 'following_url': 'https://api.github.com/users/dklimpel/following{/other_user}', 'gists_url': 'https://api.github.com/users/dklimpel/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/dklimpel/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/dklimpel/subscriptions', 'organizations_url': 'https://api.github.com/users/dklimpel/orgs', 'repos_url': 'https://api.github.com/users/dklimpel/repos', 'events_url': 'https://api.github.com/users/dklimpel/events{/privacy}', 'received_events_url': 'https://api.github.com/users/dklimpel/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,3,2020-03-08T13:57:30Z,2020-03-30T19:46:10Z,2020-03-10T22:23:02Z,CONTRIBUTOR,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7053', 'html_url': 'https://github.com/matrix-org/synapse/pull/7053', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7053.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7053.patch'}","PR for: #5267
Code from #3179 and #3180 with additional tests
* [x] Pull request is based on the develop branch
* [x] Pull request includes a [changelog file](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#changelog). The entry should:
- Be a short description of your change which makes sense to users. ""Fixed a bug that prevented receiving messages from other servers."" instead of ""Moved X method from `EventStore` to `EventWorkerStore`."".
- Use markdown where necessary, mostly for `code blocks`.
- End with either a period (.) or an exclamation mark (!).
- Start with a capital letter.
* [x] Pull request includes a [sign off](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#sign-off)
* [x] Code style is correct (run the [linters](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#code-style))
Signed-off-by: Dirk Klimpel dirk@klimpel.org",
1235,https://api.github.com/repos/matrix-org/synapse/issues/7052,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7052/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7052/comments,https://api.github.com/repos/matrix-org/synapse/issues/7052/events,https://github.com/matrix-org/synapse/issues/7052,577410255,MDU6SXNzdWU1Nzc0MTAyNTU=,7052,Server admins should be able to bypass restrictions on creating aliases,"{'login': 'turt2live', 'id': 1190097, 'node_id': 'MDQ6VXNlcjExOTAwOTc=', 'avatar_url': 'https://avatars2.githubusercontent.com/u/1190097?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/turt2live', 'html_url': 'https://github.com/turt2live', 'followers_url': 'https://api.github.com/users/turt2live/followers', 'following_url': 'https://api.github.com/users/turt2live/following{/other_user}', 'gists_url': 'https://api.github.com/users/turt2live/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/turt2live/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/turt2live/subscriptions', 'organizations_url': 'https://api.github.com/users/turt2live/orgs', 'repos_url': 'https://api.github.com/users/turt2live/repos', 'events_url': 'https://api.github.com/users/turt2live/events{/privacy}', 'received_events_url': 'https://api.github.com/users/turt2live/received_events', 'type': 'User', 'site_admin': False}","[{'id': 121086031, 'node_id': 'MDU6TGFiZWwxMjEwODYwMzE=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/enhancement', 'name': 'enhancement', 'color': '84b6eb', 'default': True, 'description': None}]",closed,False,"{'login': 'clokep', 'id': 517124, 'node_id': 'MDQ6VXNlcjUxNzEyNA==', 'avatar_url': 'https://avatars2.githubusercontent.com/u/517124?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/clokep', 'html_url': 'https://github.com/clokep', 'followers_url': 'https://api.github.com/users/clokep/followers', 'following_url': 'https://api.github.com/users/clokep/following{/other_user}', 'gists_url': 'https://api.github.com/users/clokep/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/clokep/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/clokep/subscriptions', 'organizations_url': 'https://api.github.com/users/clokep/orgs', 'repos_url': 'https://api.github.com/users/clokep/repos', 'events_url': 'https://api.github.com/users/clokep/events{/privacy}', 'received_events_url': 'https://api.github.com/users/clokep/received_events', 'type': 'User', 'site_admin': False}","[{'login': 'clokep', 'id': 517124, 'node_id': 'MDQ6VXNlcjUxNzEyNA==', 'avatar_url': 'https://avatars2.githubusercontent.com/u/517124?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/clokep', 'html_url': 'https://github.com/clokep', 'followers_url': 'https://api.github.com/users/clokep/followers', 'following_url': 'https://api.github.com/users/clokep/following{/other_user}', 'gists_url': 'https://api.github.com/users/clokep/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/clokep/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/clokep/subscriptions', 'organizations_url': 'https://api.github.com/users/clokep/orgs', 'repos_url': 'https://api.github.com/users/clokep/repos', 'events_url': 'https://api.github.com/users/clokep/events{/privacy}', 'received_events_url': 'https://api.github.com/users/clokep/received_events', 'type': 'User', 'site_admin': False}]",,6,2020-03-07T22:28:12Z,2020-04-01T12:27:47Z,2020-04-01T12:27:47Z,MEMBER,,,otherwise administration tools can't do their job,
1236,https://api.github.com/repos/matrix-org/synapse/issues/7051,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7051/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7051/comments,https://api.github.com/repos/matrix-org/synapse/issues/7051/events,https://github.com/matrix-org/synapse/pull/7051,577351933,MDExOlB1bGxSZXF1ZXN0Mzg1MTU2NTA5,7051,Admin API to join users to a room.,"{'login': 'dklimpel', 'id': 5740567, 'node_id': 'MDQ6VXNlcjU3NDA1Njc=', 'avatar_url': 'https://avatars2.githubusercontent.com/u/5740567?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/dklimpel', 'html_url': 'https://github.com/dklimpel', 'followers_url': 'https://api.github.com/users/dklimpel/followers', 'following_url': 'https://api.github.com/users/dklimpel/following{/other_user}', 'gists_url': 'https://api.github.com/users/dklimpel/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/dklimpel/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/dklimpel/subscriptions', 'organizations_url': 'https://api.github.com/users/dklimpel/orgs', 'repos_url': 'https://api.github.com/users/dklimpel/repos', 'events_url': 'https://api.github.com/users/dklimpel/events{/privacy}', 'received_events_url': 'https://api.github.com/users/dklimpel/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,6,2020-03-07T15:41:37Z,2020-03-27T19:45:12Z,2020-03-27T19:16:44Z,CONTRIBUTOR,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7051', 'html_url': 'https://github.com/matrix-org/synapse/pull/7051', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7051.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7051.patch'}","Feature for #7049
Admin API `POST /_synapse/admin/v1/join/` to join users to a room like `auto_join_rooms` for creation of users.
### Pull Request Checklist
* [x] Pull request is based on the develop branch
* [x] Pull request includes a [changelog file](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#changelog). The entry should:
- Be a short description of your change which makes sense to users. ""Fixed a bug that prevented receiving messages from other servers."" instead of ""Moved X method from `EventStore` to `EventWorkerStore`."".
- Use markdown where necessary, mostly for `code blocks`.
- End with either a period (.) or an exclamation mark (!).
- Start with a capital letter.
* [x] Pull request includes a [sign off](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#sign-off)
* [x] Code style is correct (run the [linters](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#code-style))
Signed-off-by: Dirk Klimpel dirk@klimpel.org",
1237,https://api.github.com/repos/matrix-org/synapse/issues/7050,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7050/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7050/comments,https://api.github.com/repos/matrix-org/synapse/issues/7050/events,https://github.com/matrix-org/synapse/issues/7050,577347719,MDU6SXNzdWU1NzczNDc3MTk=,7050,can't reject invite to chat from a nonexisting matrix server,"{'login': 'blw42', 'id': 61110554, 'node_id': 'MDQ6VXNlcjYxMTEwNTU0', 'avatar_url': 'https://avatars1.githubusercontent.com/u/61110554?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/blw42', 'html_url': 'https://github.com/blw42', 'followers_url': 'https://api.github.com/users/blw42/followers', 'following_url': 'https://api.github.com/users/blw42/following{/other_user}', 'gists_url': 'https://api.github.com/users/blw42/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/blw42/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/blw42/subscriptions', 'organizations_url': 'https://api.github.com/users/blw42/orgs', 'repos_url': 'https://api.github.com/users/blw42/repos', 'events_url': 'https://api.github.com/users/blw42/events{/privacy}', 'received_events_url': 'https://api.github.com/users/blw42/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,1,2020-03-07T15:09:36Z,2020-03-07T15:30:42Z,2020-03-07T15:29:53Z,NONE,,,"### Description
A guy sent me an invite for an chat. I tried to join, doesn't worked, i tried to reject or reject & ignore, doesn't work. I thought i will check his matrix version so i visited ```matrix.HISHOMESERVER.com/_synapse/admin/v1/server_version```, but there was no matrix server. I think he deleted it after sending me the invite.
### Steps to reproduce
I'm using riot-web through ferdi (a franz fork), but i'm not in controll of the riot-web therefore i can't show you riotweb-logs
- if i try to join:
```
2020-03-07 15:53:47,034 - synapse.http.server - 81 - INFO - POST-15789 - SynapseError: 404 - No known servers
2020-03-07 15:53:47,035 - synapse.access.http.8009 - 302 - INFO - POST-15789 - 42.42.42.42(myip) - 8009 - {@MYUSERNAME:matrix.MYHOMESERVER.com} Processed request: 0.006sec/0.000sec (0.004sec, 0.000sec) (0.002sec/0.001sec/3) 50B 404 ""POST /_matrix/client/r0/join/!oertzevxdaMsdalsj%3Amatrix.HISHOMESERVER.com HTTP/1.0"" ""Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/78.0.3904.130 Safari/537.36"" [0 dbevts]
```
- if i try to reject & ignore:
```
2020-03-07 15:54:08,727 - synapse.access.http.8009 - 302 - INFO - PUT-15775 - 42.42.42.42(myip) - 8009 - {@MYUSERNAME:matrix.MYHOMESERVER.com} Processed request: 0.007sec/0.000sec (0.000sec, 0.000sec) (0.001sec/0.003sec/2) 2B 200 ""PUT /_matrix/client/r0/user/%40MYUSERNAME%3Amatrix.MYHOMESERVER.com/account_data/m.ignored_user_list HTTP/1.0"" ""Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/78.0.3904.130 Safari/537.36"" [0 dbevts]
2020-03-07 15:54:08,780 - synapse.access.http.8009 - 302 - INFO - GET-15774 - 42.42.42.42(myip) - 8009 - {@MYUSERNAME:matrix.MYHOMESERVER.com} Processed request: 2.546sec/0.001sec (0.048sec, 0.000sec) (0.003sec/0.002sec/3) 36844B 200 ""GET /_matrix/client/r0/sync?filter=0&timeout=30000&since=s67039_686064_508_54237_123_28_178_22759_14 HTTP/1.0"" ""Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/78.0.3904.130 Safari/537.36"" [0 dbevts]
2020-03-07 15:54:08,787 - synapse.http.server - 81 - INFO - POST-15776 - SynapseError: 404 - Not a known room
2020-03-07 15:54:08,788 - synapse.access.http.8009 - 302 - INFO - POST-15776 - 42.42.42.42(myip) - 8009 - {@MYUSERNAME:matrix.MYHOMESERVER.com} Processed request: 0.004sec/0.000sec (0.004sec, 0.000sec) (0.001sec/0.000sec/1) 50B 404 ""POST /_matrix/client/r0/rooms/!oertzevxdaMsdalsj%3Amatrix.HISHOMESERVER.com/leave HTTP/1.0"" ""Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/78.0.3904.130 Safari/537.36"" [0 dbevts]
```
- if i try to reeject:
```
2020-03-07 15:55:22,015 - synapse.http.server - 81 - INFO - POST-15798 - SynapseError: 404 - Not a known room
2020-03-07 15:55:22,016 - synapse.access.http.8009 - 302 - INFO - POST-15798 - 42.42.42.42(myip) - 8009 - {@MYUSERNAME:matrix.MYHOMESERVER.com} Processed request: 0.005sec/0.001sec (0.000sec, 0.000sec) (0.000sec/0.000sec/1) 50B 404 ""POST /_matrix/client/r0/rooms/!oertzevxdaMsdalsj%3Amatrix.HISHOMESERVER.com/leave HTTP/1.0"" ""Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/78.0.3904.130 Safari/537.36"" [0 dbevts]
```
### Version information
- **Homeserver**: my own interacting with another inofficial one
- **Version**: 1.11.1
- **Install method**:pip
- **Platform**: Linux 4.9.0-11-amd64 #1 SMP Debian 4.9.189-3+deb9u1 (2019-09-20) x86_64 GNU/Linux on a VPS",
1238,https://api.github.com/repos/matrix-org/synapse/issues/7049,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7049/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7049/comments,https://api.github.com/repos/matrix-org/synapse/issues/7049/events,https://github.com/matrix-org/synapse/issues/7049,577160174,MDU6SXNzdWU1NzcxNjAxNzQ=,7049,force join for admin api,"{'login': 'Tjeri', 'id': 13244009, 'node_id': 'MDQ6VXNlcjEzMjQ0MDA5', 'avatar_url': 'https://avatars0.githubusercontent.com/u/13244009?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Tjeri', 'html_url': 'https://github.com/Tjeri', 'followers_url': 'https://api.github.com/users/Tjeri/followers', 'following_url': 'https://api.github.com/users/Tjeri/following{/other_user}', 'gists_url': 'https://api.github.com/users/Tjeri/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/Tjeri/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/Tjeri/subscriptions', 'organizations_url': 'https://api.github.com/users/Tjeri/orgs', 'repos_url': 'https://api.github.com/users/Tjeri/repos', 'events_url': 'https://api.github.com/users/Tjeri/events{/privacy}', 'received_events_url': 'https://api.github.com/users/Tjeri/received_events', 'type': 'User', 'site_admin': False}","[{'id': 1507817868, 'node_id': 'MDU6TGFiZWwxNTA3ODE3ODY4', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/admin-api', 'name': 'admin-api', 'color': 'e9fc71', 'default': False, 'description': ''}, {'id': 477043174, 'node_id': 'MDU6TGFiZWw0NzcwNDMxNzQ=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/feature', 'name': 'feature', 'color': 'bfd4f2', 'default': False, 'description': None}, {'id': 477043173, 'node_id': 'MDU6TGFiZWw0NzcwNDMxNzM=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/p2', 'name': 'p2', 'color': 'fbca04', 'default': False, 'description': None}]",closed,False,,[],,2,2020-03-06T20:30:50Z,2020-04-02T11:42:14Z,2020-04-02T11:42:14Z,NONE,,,"You can force users to auto join on registration, but currently there is no option to make users auto join any other rooms.
It would be nice to be able to have the users auto accept invites or just directly put users in rooms without needing the step over invite.
This should probably go over the admin api.",
1239,https://api.github.com/repos/matrix-org/synapse/issues/7048,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7048/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7048/comments,https://api.github.com/repos/matrix-org/synapse/issues/7048/events,https://github.com/matrix-org/synapse/pull/7048,577111358,MDExOlB1bGxSZXF1ZXN0Mzg0OTY4Nzg5,7048,Document that fallback auth must be routed to the same worker node as register,"{'login': 'clokep', 'id': 517124, 'node_id': 'MDQ6VXNlcjUxNzEyNA==', 'avatar_url': 'https://avatars2.githubusercontent.com/u/517124?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/clokep', 'html_url': 'https://github.com/clokep', 'followers_url': 'https://api.github.com/users/clokep/followers', 'following_url': 'https://api.github.com/users/clokep/following{/other_user}', 'gists_url': 'https://api.github.com/users/clokep/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/clokep/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/clokep/subscriptions', 'organizations_url': 'https://api.github.com/users/clokep/orgs', 'repos_url': 'https://api.github.com/users/clokep/repos', 'events_url': 'https://api.github.com/users/clokep/events{/privacy}', 'received_events_url': 'https://api.github.com/users/clokep/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,1,2020-03-06T18:50:09Z,2020-03-09T11:19:26Z,2020-03-09T11:19:25Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7048', 'html_url': 'https://github.com/matrix-org/synapse/pull/7048', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7048.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7048.patch'}","Per the description in #6705, this updates the documentation to state that fallback auth and register must be routed to the same worker node, this is because there is memory state shared between these endpoints (in the `session` `dict`).
Fixes #6705.",
1240,https://api.github.com/repos/matrix-org/synapse/issues/7047,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7047/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7047/comments,https://api.github.com/repos/matrix-org/synapse/issues/7047/events,https://github.com/matrix-org/synapse/issues/7047,577033501,MDU6SXNzdWU1NzcwMzM1MDE=,7047,That you can have an empty trusted_key_servers config option is non-obvious,"{'login': 'anoadragon453', 'id': 1342360, 'node_id': 'MDQ6VXNlcjEzNDIzNjA=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1342360?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/anoadragon453', 'html_url': 'https://github.com/anoadragon453', 'followers_url': 'https://api.github.com/users/anoadragon453/followers', 'following_url': 'https://api.github.com/users/anoadragon453/following{/other_user}', 'gists_url': 'https://api.github.com/users/anoadragon453/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/anoadragon453/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/anoadragon453/subscriptions', 'organizations_url': 'https://api.github.com/users/anoadragon453/orgs', 'repos_url': 'https://api.github.com/users/anoadragon453/repos', 'events_url': 'https://api.github.com/users/anoadragon453/events{/privacy}', 'received_events_url': 'https://api.github.com/users/anoadragon453/received_events', 'type': 'User', 'site_admin': False}","[{'id': 845245048, 'node_id': 'MDU6TGFiZWw4NDUyNDUwNDg=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/docs', 'name': 'docs', 'color': '0e8a16', 'default': False, 'description': ''}, {'id': 477043173, 'node_id': 'MDU6TGFiZWw0NzcwNDMxNzM=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/p2', 'name': 'p2', 'color': 'fbca04', 'default': False, 'description': None}]",open,False,,[],,1,2020-03-06T16:16:49Z,2020-05-21T22:10:23Z,,MEMBER,,,"
Sometimes you're running Synapse and not wanting to trust any other Synapse server as a keyserver (either for privacy reasons or you're running in a private federation).
In this case, it's not obvious that the way that you specify ""No external key server please"" is to set `trusted_key_servers` to an empty array `[]`. Commenting out the block will just default to `matrix.org`.
We should add a line in the config help for this option to state that contacting 3rd party trusted key servers can be disabled by setting `trusted_key_servers` to `[]`.
Synapse v1.11.1
",
1241,https://api.github.com/repos/matrix-org/synapse/issues/7046,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7046/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7046/comments,https://api.github.com/repos/matrix-org/synapse/issues/7046/events,https://github.com/matrix-org/synapse/pull/7046,576979843,MDExOlB1bGxSZXF1ZXN0Mzg0ODYwNTc2,7046,Increase replication timeout,"{'login': 'michaelkaye', 'id': 1917473, 'node_id': 'MDQ6VXNlcjE5MTc0NzM=', 'avatar_url': 'https://avatars0.githubusercontent.com/u/1917473?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/michaelkaye', 'html_url': 'https://github.com/michaelkaye', 'followers_url': 'https://api.github.com/users/michaelkaye/followers', 'following_url': 'https://api.github.com/users/michaelkaye/following{/other_user}', 'gists_url': 'https://api.github.com/users/michaelkaye/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/michaelkaye/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/michaelkaye/subscriptions', 'organizations_url': 'https://api.github.com/users/michaelkaye/orgs', 'repos_url': 'https://api.github.com/users/michaelkaye/repos', 'events_url': 'https://api.github.com/users/michaelkaye/events{/privacy}', 'received_events_url': 'https://api.github.com/users/michaelkaye/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,1,2020-03-06T14:49:48Z,2020-04-21T09:50:51Z,2020-04-21T09:50:51Z,CONTRIBUTOR,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7046', 'html_url': 'https://github.com/matrix-org/synapse/pull/7046', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7046.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7046.patch'}",,
1242,https://api.github.com/repos/matrix-org/synapse/issues/7045,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7045/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7045/comments,https://api.github.com/repos/matrix-org/synapse/issues/7045/events,https://github.com/matrix-org/synapse/pull/7045,576860290,MDExOlB1bGxSZXF1ZXN0Mzg0NzYzMTE3,7045,Make sure that is_verified is a boolean when processing room keys,"{'login': 'babolivier', 'id': 5547783, 'node_id': 'MDQ6VXNlcjU1NDc3ODM=', 'avatar_url': 'https://avatars3.githubusercontent.com/u/5547783?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/babolivier', 'html_url': 'https://github.com/babolivier', 'followers_url': 'https://api.github.com/users/babolivier/followers', 'following_url': 'https://api.github.com/users/babolivier/following{/other_user}', 'gists_url': 'https://api.github.com/users/babolivier/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/babolivier/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/babolivier/subscriptions', 'organizations_url': 'https://api.github.com/users/babolivier/orgs', 'repos_url': 'https://api.github.com/users/babolivier/repos', 'events_url': 'https://api.github.com/users/babolivier/events{/privacy}', 'received_events_url': 'https://api.github.com/users/babolivier/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,0,2020-03-06T11:06:53Z,2020-03-09T09:54:50Z,2020-03-09T09:54:48Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7045', 'html_url': 'https://github.com/matrix-org/synapse/pull/7045', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7045.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7045.patch'}","Fixes #7036, or at least the confusion around it, by adding a check on the type to return a more understandable error message.",
1243,https://api.github.com/repos/matrix-org/synapse/issues/7044,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7044/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7044/comments,https://api.github.com/repos/matrix-org/synapse/issues/7044/events,https://github.com/matrix-org/synapse/pull/7044,576760277,MDExOlB1bGxSZXF1ZXN0Mzg0NjgzMzgw,7044,Set charset to utf-8 when adding headers for certain text content types,"{'login': 'TheStranjer', 'id': 791672, 'node_id': 'MDQ6VXNlcjc5MTY3Mg==', 'avatar_url': 'https://avatars1.githubusercontent.com/u/791672?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/TheStranjer', 'html_url': 'https://github.com/TheStranjer', 'followers_url': 'https://api.github.com/users/TheStranjer/followers', 'following_url': 'https://api.github.com/users/TheStranjer/following{/other_user}', 'gists_url': 'https://api.github.com/users/TheStranjer/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/TheStranjer/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/TheStranjer/subscriptions', 'organizations_url': 'https://api.github.com/users/TheStranjer/orgs', 'repos_url': 'https://api.github.com/users/TheStranjer/repos', 'events_url': 'https://api.github.com/users/TheStranjer/events{/privacy}', 'received_events_url': 'https://api.github.com/users/TheStranjer/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,5,2020-03-06T07:55:08Z,2020-04-13T20:06:07Z,2020-03-17T13:29:10Z,CONTRIBUTOR,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7044', 'html_url': 'https://github.com/matrix-org/synapse/pull/7044', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7044.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7044.patch'}","Fix #7043
### Pull Request Checklist
* [x] Pull request is based on the develop branch
* [x] Pull request includes a [changelog file](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#changelog). The entry should:
- Be a short description of your change which makes sense to users. ""Fixed a bug that prevented receiving messages from other servers."" instead of ""Moved X method from `EventStore` to `EventWorkerStore`."".
- Use markdown where necessary, mostly for `code blocks`.
- End with either a period (.) or an exclamation mark (!).
- Start with a capital letter.
* [x] Pull request includes a [sign off](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#sign-off)
* [x] Code style is correct (run the [linters](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#code-style))
### Demonstration Of Fix
I have this code running on my own homeserver. Here is the file being rendered there:
https://iddqd.social/_matrix/media/r0/download/iddqd.social/bkwUKJYKmwhMvddiGpErdAmG
I uploaded the same file to matrix.org here:
https://matrix-client.matrix.org/_matrix/media/r0/download/matrix.org/pAMkdBaolnxNCwQTuBaDJYrF
### Sign-Off
Signed-off-by: Bob Arctor
",
1244,https://api.github.com/repos/matrix-org/synapse/issues/7043,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7043/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7043/comments,https://api.github.com/repos/matrix-org/synapse/issues/7043/events,https://github.com/matrix-org/synapse/issues/7043,576746774,MDU6SXNzdWU1NzY3NDY3NzQ=,7043,"media repo serves utf-8 files with no charset info, leading to incorrect in-browser rendering","{'login': 'TheStranjer', 'id': 791672, 'node_id': 'MDQ6VXNlcjc5MTY3Mg==', 'avatar_url': 'https://avatars1.githubusercontent.com/u/791672?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/TheStranjer', 'html_url': 'https://github.com/TheStranjer', 'followers_url': 'https://api.github.com/users/TheStranjer/followers', 'following_url': 'https://api.github.com/users/TheStranjer/following{/other_user}', 'gists_url': 'https://api.github.com/users/TheStranjer/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/TheStranjer/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/TheStranjer/subscriptions', 'organizations_url': 'https://api.github.com/users/TheStranjer/orgs', 'repos_url': 'https://api.github.com/users/TheStranjer/repos', 'events_url': 'https://api.github.com/users/TheStranjer/events{/privacy}', 'received_events_url': 'https://api.github.com/users/TheStranjer/received_events', 'type': 'User', 'site_admin': False}","[{'id': 121086031, 'node_id': 'MDU6TGFiZWwxMjEwODYwMzE=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/enhancement', 'name': 'enhancement', 'color': '84b6eb', 'default': True, 'description': None}, {'id': 477043173, 'node_id': 'MDU6TGFiZWw0NzcwNDMxNzM=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/p2', 'name': 'p2', 'color': 'fbca04', 'default': False, 'description': None}]",closed,False,,[],,4,2020-03-06T07:24:26Z,2020-03-17T13:30:17Z,2020-03-17T13:30:17Z,CONTRIBUTOR,,,"### Description
Certain text files do not render correctly in-browser.
Example being a character sheet I made:
[How It Should Render](https://0x0.st/iTqU.txt) vs [How It Actually Renders](https://matrix-client.matrix.org/_matrix/media/r0/download/matrix.org/pAMkdBaolnxNCwQTuBaDJYrF)
This is not a browser error; it happens in both Chrome and in Firefox.
### Steps to reproduce
- Upload a text file with certain UTF8 characters
- Click on that file
- Watch it render incorrectly
### Version information
This issue has been identified on matrix.org; the above link on how it actually renders is a link to the matrix.org homeserver.",
1245,https://api.github.com/repos/matrix-org/synapse/issues/7042,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7042/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7042/comments,https://api.github.com/repos/matrix-org/synapse/issues/7042/events,https://github.com/matrix-org/synapse/issues/7042,576576819,MDU6SXNzdWU1NzY1NzY4MTk=,7042,Stickers keep getting quarantined by antiabuse,"{'login': 'ara4n', 'id': 1294269, 'node_id': 'MDQ6VXNlcjEyOTQyNjk=', 'avatar_url': 'https://avatars2.githubusercontent.com/u/1294269?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/ara4n', 'html_url': 'https://github.com/ara4n', 'followers_url': 'https://api.github.com/users/ara4n/followers', 'following_url': 'https://api.github.com/users/ara4n/following{/other_user}', 'gists_url': 'https://api.github.com/users/ara4n/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/ara4n/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/ara4n/subscriptions', 'organizations_url': 'https://api.github.com/users/ara4n/orgs', 'repos_url': 'https://api.github.com/users/ara4n/repos', 'events_url': 'https://api.github.com/users/ara4n/events{/privacy}', 'received_events_url': 'https://api.github.com/users/ara4n/received_events', 'type': 'User', 'site_admin': False}","[{'id': 477043174, 'node_id': 'MDU6TGFiZWw0NzcwNDMxNzQ=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/feature', 'name': 'feature', 'color': 'bfd4f2', 'default': False, 'description': None}, {'id': 477043173, 'node_id': 'MDU6TGFiZWw0NzcwNDMxNzM=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/p2', 'name': 'p2', 'color': 'fbca04', 'default': False, 'description': None}]",closed,False,,[],,1,2020-03-05T22:44:48Z,2020-05-19T19:44:57Z,2020-05-19T19:44:57Z,MEMBER,,,We need a way for admins to mark some content as unquarantinable,
1246,https://api.github.com/repos/matrix-org/synapse/issues/7041,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7041/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7041/comments,https://api.github.com/repos/matrix-org/synapse/issues/7041/events,https://github.com/matrix-org/synapse/issues/7041,576430101,MDU6SXNzdWU1NzY0MzAxMDE=,7041,There's some regression with the room directory member count,"{'login': 'turt2live', 'id': 1190097, 'node_id': 'MDQ6VXNlcjExOTAwOTc=', 'avatar_url': 'https://avatars2.githubusercontent.com/u/1190097?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/turt2live', 'html_url': 'https://github.com/turt2live', 'followers_url': 'https://api.github.com/users/turt2live/followers', 'following_url': 'https://api.github.com/users/turt2live/following{/other_user}', 'gists_url': 'https://api.github.com/users/turt2live/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/turt2live/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/turt2live/subscriptions', 'organizations_url': 'https://api.github.com/users/turt2live/orgs', 'repos_url': 'https://api.github.com/users/turt2live/repos', 'events_url': 'https://api.github.com/users/turt2live/events{/privacy}', 'received_events_url': 'https://api.github.com/users/turt2live/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,1,2020-03-05T17:53:06Z,2020-03-06T10:31:22Z,2020-03-06T10:31:22Z,MEMBER,,,"Riot keeps getting reports of the room directory being wrong for the member count. Theory is that it's not counting left members, or double counting joins (possibly profile changes?). Most extreme example is a room that has ~2k joined members and the room directory says it is 20k on matrix.org",
1247,https://api.github.com/repos/matrix-org/synapse/issues/7040,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7040/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7040/comments,https://api.github.com/repos/matrix-org/synapse/issues/7040/events,https://github.com/matrix-org/synapse/pull/7040,576409339,MDExOlB1bGxSZXF1ZXN0Mzg0NDAxNTIx,7040,Add ability to run replication protocol over redis.,"{'login': 'erikjohnston', 'id': 8428120, 'node_id': 'MDQ6VXNlcjg0MjgxMjA=', 'avatar_url': 'https://avatars0.githubusercontent.com/u/8428120?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/erikjohnston', 'html_url': 'https://github.com/erikjohnston', 'followers_url': 'https://api.github.com/users/erikjohnston/followers', 'following_url': 'https://api.github.com/users/erikjohnston/following{/other_user}', 'gists_url': 'https://api.github.com/users/erikjohnston/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/erikjohnston/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/erikjohnston/subscriptions', 'organizations_url': 'https://api.github.com/users/erikjohnston/orgs', 'repos_url': 'https://api.github.com/users/erikjohnston/repos', 'events_url': 'https://api.github.com/users/erikjohnston/events{/privacy}', 'received_events_url': 'https://api.github.com/users/erikjohnston/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,1,2020-03-05T17:16:15Z,2020-04-22T12:07:43Z,2020-04-22T12:07:42Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7040', 'html_url': 'https://github.com/matrix-org/synapse/pull/7040', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7040.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7040.patch'}","This still requires adding config and CI.
Based on #7187",
1248,https://api.github.com/repos/matrix-org/synapse/issues/7039,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7039/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7039/comments,https://api.github.com/repos/matrix-org/synapse/issues/7039/events,https://github.com/matrix-org/synapse/issues/7039,575757610,MDU6SXNzdWU1NzU3NTc2MTA=,7039,Postgres error on startup: ERROR: ON CONFLICT DO UPDATE command cannot affect row a second time,"{'login': 't-aus-m', 'id': 12219297, 'node_id': 'MDQ6VXNlcjEyMjE5Mjk3', 'avatar_url': 'https://avatars2.githubusercontent.com/u/12219297?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/t-aus-m', 'html_url': 'https://github.com/t-aus-m', 'followers_url': 'https://api.github.com/users/t-aus-m/followers', 'following_url': 'https://api.github.com/users/t-aus-m/following{/other_user}', 'gists_url': 'https://api.github.com/users/t-aus-m/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/t-aus-m/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/t-aus-m/subscriptions', 'organizations_url': 'https://api.github.com/users/t-aus-m/orgs', 'repos_url': 'https://api.github.com/users/t-aus-m/repos', 'events_url': 'https://api.github.com/users/t-aus-m/events{/privacy}', 'received_events_url': 'https://api.github.com/users/t-aus-m/received_events', 'type': 'User', 'site_admin': False}","[{'id': 1311133228, 'node_id': 'MDU6TGFiZWwxMzExMTMzMjI4', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/info-needed', 'name': 'info-needed', 'color': 'a1e8ea', 'default': False, 'description': ''}]",closed,False,,[],,15,2020-03-04T20:46:41Z,2020-03-17T19:36:01Z,2020-03-17T19:33:48Z,NONE,,,"
### Description
After upgrading my homeserver to the current versions using docker, postgres is throwing an error that prevents my homeserver from starting.
### Steps to reproduce
- upgrade to current versions
- rebuild container
- show logs
```
db_1 | 2020-03-04 20:19:04.586 UTC [38] ERROR: ON CONFLICT DO UPDATE command cannot affect row a second time
db_1 | 2020-03-04 20:19:04.586 UTC [38] HINT: Ensure that no rows proposed for insertion within the same command have duplicate constrained values.
db_1 | 2020-03-04 20:19:04.586 UTC [38] STATEMENT: INSERT INTO room_stats_historical (room_id, current_state_events, joined_members, invited_members, left_members, banned_members, local_users_in_room, total_events, total_event_bytes, end_ts, bucket_size) SELECT room_id, current_state_events, joined_members, invited_members, left_members, banned_members, local_users_in_room, 50, 64353, 1583366400000, 86400000 FROM room_stats_current WHERE room_id = '!someroom:homeserver.tld' ON CONFLICT (room_id, end_ts) DO UPDATE SET current_state_events = EXCLUDED.current_state_events, joined_members = EXCLUDED.joined_members, invited_members = EXCLUDED.invited_members, left_members = EXCLUDED.left_members, banned_members = EXCLUDED.banned_members, local_users_in_room = EXCLUDED.local_users_in_room, total_events = EXCLUDED.total_events + room_stats_historical.total_events, total_event_bytes = EXCLUDED.total_event_bytes + room_stats_historical.total_event_bytes
```
I would expect the server to start properly without any errors.
### Version information
- **Homeserver**: llit.eu
- **Version**: 1.10.1, also tested with 1.11.1
- **Install method**: docker
- **Platform**: docker based an debian
",
1249,https://api.github.com/repos/matrix-org/synapse/issues/7038,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7038/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7038/comments,https://api.github.com/repos/matrix-org/synapse/issues/7038/events,https://github.com/matrix-org/synapse/issues/7038,575754905,MDU6SXNzdWU1NzU3NTQ5MDU=,7038,authentication via LDAP is still broken,"{'login': 'git-minix', 'id': 30546356, 'node_id': 'MDQ6VXNlcjMwNTQ2MzU2', 'avatar_url': 'https://avatars1.githubusercontent.com/u/30546356?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/git-minix', 'html_url': 'https://github.com/git-minix', 'followers_url': 'https://api.github.com/users/git-minix/followers', 'following_url': 'https://api.github.com/users/git-minix/following{/other_user}', 'gists_url': 'https://api.github.com/users/git-minix/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/git-minix/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/git-minix/subscriptions', 'organizations_url': 'https://api.github.com/users/git-minix/orgs', 'repos_url': 'https://api.github.com/users/git-minix/repos', 'events_url': 'https://api.github.com/users/git-minix/events{/privacy}', 'received_events_url': 'https://api.github.com/users/git-minix/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,3,2020-03-04T20:42:58Z,2020-08-05T15:38:46Z,2020-03-04T21:34:00Z,NONE,,,"### Description
Also with matrix-synapse version 1.11.0+stretch1 the LDAP auth is broken
see closed issue https://github.com/matrix-org/synapse/issues/6772 and the hotfix from erikjohnston
### Steps to reproduce
Open Riot Web
Log in with any existing user
Error message: Fehler: Problem bei der Kommunikation mit dem angegebenen Home-Server. (M_UNKNOWN)
### Version information
matrix-synapse version 1.11.0+stretch1
Debian 9.12
- **Install method**:
apt install
The old Hotfix works
```
diff --git a/synapse/module_api/__init__.py b/synapse/module_api/__init__.py
index d680ee95e..80298ecee 100644
--- a/synapse/module_api/__init__.py
+++ b/synapse/module_api/__init__.py
@@ -37,6 +37,7 @@ class ModuleApi(object):
def __init__(self, hs, auth_handler):
self._hs = hs
+ self.hs = hs
self._store = hs.get_datastore()
self._auth = hs.get_auth()
```
Is there a permanent solution? I have expected that this old critical bug (since version 1.9) is fixed in the recent versions.",
1250,https://api.github.com/repos/matrix-org/synapse/issues/7037,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7037/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7037/comments,https://api.github.com/repos/matrix-org/synapse/issues/7037/events,https://github.com/matrix-org/synapse/pull/7037,575704376,MDExOlB1bGxSZXF1ZXN0MzgzODE2ODcw,7037,Modify the auth rules and redaction rules for aliases.,"{'login': 'clokep', 'id': 517124, 'node_id': 'MDQ6VXNlcjUxNzEyNA==', 'avatar_url': 'https://avatars2.githubusercontent.com/u/517124?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/clokep', 'html_url': 'https://github.com/clokep', 'followers_url': 'https://api.github.com/users/clokep/followers', 'following_url': 'https://api.github.com/users/clokep/following{/other_user}', 'gists_url': 'https://api.github.com/users/clokep/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/clokep/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/clokep/subscriptions', 'organizations_url': 'https://api.github.com/users/clokep/orgs', 'repos_url': 'https://api.github.com/users/clokep/repos', 'events_url': 'https://api.github.com/users/clokep/events{/privacy}', 'received_events_url': 'https://api.github.com/users/clokep/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,1,2020-03-04T19:34:56Z,2020-03-09T12:58:27Z,2020-03-09T12:58:26Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7037', 'html_url': 'https://github.com/matrix-org/synapse/pull/7037', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7037.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7037.patch'}","Part of #6898. This adds an experimental room version that does *not* have special behavior of auth rules and redaction rules for `m.room.aliases` events.
This heavily builds on work from #6787, but modifies it to implement MSC2432 and MSC2261 instead of MSC2260.
I chose to rename the experimental room version since the flag seemed well named to re-use.
~~This is based on #6875.~~
Fixes #6465 ",
1251,https://api.github.com/repos/matrix-org/synapse/issues/7036,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7036/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7036/comments,https://api.github.com/repos/matrix-org/synapse/issues/7036/events,https://github.com/matrix-org/synapse/issues/7036,575618095,MDU6SXNzdWU1NzU2MTgwOTU=,7036,can't adapt type 'dict' when doing something with room keys,"{'login': 'turt2live', 'id': 1190097, 'node_id': 'MDQ6VXNlcjExOTAwOTc=', 'avatar_url': 'https://avatars2.githubusercontent.com/u/1190097?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/turt2live', 'html_url': 'https://github.com/turt2live', 'followers_url': 'https://api.github.com/users/turt2live/followers', 'following_url': 'https://api.github.com/users/turt2live/following{/other_user}', 'gists_url': 'https://api.github.com/users/turt2live/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/turt2live/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/turt2live/subscriptions', 'organizations_url': 'https://api.github.com/users/turt2live/orgs', 'repos_url': 'https://api.github.com/users/turt2live/repos', 'events_url': 'https://api.github.com/users/turt2live/events{/privacy}', 'received_events_url': 'https://api.github.com/users/turt2live/received_events', 'type': 'User', 'site_admin': False}","[{'id': 121086029, 'node_id': 'MDU6TGFiZWwxMjEwODYwMjk=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/bug', 'name': 'bug', 'color': 'fc2929', 'default': True, 'description': None}]",closed,False,"{'login': 'babolivier', 'id': 5547783, 'node_id': 'MDQ6VXNlcjU1NDc3ODM=', 'avatar_url': 'https://avatars3.githubusercontent.com/u/5547783?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/babolivier', 'html_url': 'https://github.com/babolivier', 'followers_url': 'https://api.github.com/users/babolivier/followers', 'following_url': 'https://api.github.com/users/babolivier/following{/other_user}', 'gists_url': 'https://api.github.com/users/babolivier/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/babolivier/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/babolivier/subscriptions', 'organizations_url': 'https://api.github.com/users/babolivier/orgs', 'repos_url': 'https://api.github.com/users/babolivier/repos', 'events_url': 'https://api.github.com/users/babolivier/events{/privacy}', 'received_events_url': 'https://api.github.com/users/babolivier/received_events', 'type': 'User', 'site_admin': False}","[{'login': 'babolivier', 'id': 5547783, 'node_id': 'MDQ6VXNlcjU1NDc3ODM=', 'avatar_url': 'https://avatars3.githubusercontent.com/u/5547783?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/babolivier', 'html_url': 'https://github.com/babolivier', 'followers_url': 'https://api.github.com/users/babolivier/followers', 'following_url': 'https://api.github.com/users/babolivier/following{/other_user}', 'gists_url': 'https://api.github.com/users/babolivier/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/babolivier/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/babolivier/subscriptions', 'organizations_url': 'https://api.github.com/users/babolivier/orgs', 'repos_url': 'https://api.github.com/users/babolivier/repos', 'events_url': 'https://api.github.com/users/babolivier/events{/privacy}', 'received_events_url': 'https://api.github.com/users/babolivier/received_events', 'type': 'User', 'site_admin': False}]",,4,2020-03-04T17:48:39Z,2020-03-09T10:05:43Z,2020-03-09T09:55:02Z,MEMBER,,,"```
[homeserver_1] 2020-03-04 17:46:42,842 - synapse.http.server - 110 - ERROR - PUT-58- Failed handle request via 'RoomKeysServlet':
Traceback (most recent call last):
File ""/home/matrix/synapse/lib/python3.6/site-packages/synapse/http/server.py"", line 78, in wrapped_request_handler
await h(self, request)
File ""/home/matrix/synapse/lib/python3.6/site-packages/synapse/http/server.py"", line 331, in _async_render
callback_return = await callback_return
File ""/home/matrix/synapse/lib/python3.6/site-packages/synapse/rest/client/v2_alpha/room_keys.py"", line 134, in on_PUT
ret = await self.e2e_room_keys_handler.upload_room_keys(user_id, version, body)
File ""/home/matrix/synapse/lib/python3.6/site-packages/twisted/internet/defer.py"", line 1416, in _inlineCallbacks
result = result.throwExceptionIntoGenerator(g)
File ""/home/matrix/synapse/lib/python3.6/site-packages/twisted/python/failure.py"", line 491, in throwExceptionIntoGenerator
return g.throw(self.type, self.value, self.tb)
File ""/home/matrix/synapse/lib/python3.6/site-packages/synapse/handlers/e2e_room_keys.py"", line 226, in upload_room_keys
user_id, version, room_id, session_id, room_key
File ""/home/matrix/synapse/lib/python3.6/site-packages/twisted/internet/defer.py"", line 1416, in _inlineCallbacks
result = result.throwExceptionIntoGenerator(g)
File ""/home/matrix/synapse/lib/python3.6/site-packages/twisted/python/failure.py"", line 491, in throwExceptionIntoGenerator
return g.throw(self.type, self.value, self.tb)
File ""/home/matrix/synapse/lib/python3.6/site-packages/synapse/storage/data_stores/main/e2e_room_keys.py"", line 55, in update_e2e_room_key
desc=""update_e2e_room_key"",
File ""/home/matrix/synapse/lib/python3.6/site-packages/twisted/internet/defer.py"", line 1416, in _inlineCallbacks
result = result.throwExceptionIntoGenerator(g)
File ""/home/matrix/synapse/lib/python3.6/site-packages/twisted/python/failure.py"", line 491, in throwExceptionIntoGenerator
return g.throw(self.type, self.value, self.tb)
File ""/home/matrix/synapse/lib/python3.6/site-packages/synapse/storage/database.py"", line 495, in runInteraction
**kwargs
File ""/home/matrix/synapse/lib/python3.6/site-packages/twisted/internet/defer.py"", line 1416, in _inlineCallbacks
result = result.throwExceptionIntoGenerator(g)
File ""/home/matrix/synapse/lib/python3.6/site-packages/twisted/python/failure.py"", line 491, in throwExceptionIntoGenerator
return g.throw(self.type, self.value, self.tb)
File ""/home/matrix/synapse/lib/python3.6/site-packages/synapse/storage/database.py"", line 543, in runWithConnection
self._db_pool.runWithConnection(inner_func, *args, **kwargs)
File ""/home/matrix/synapse/lib/python3.6/site-packages/twisted/python/threadpool.py"", line 250, in inContext
result = inContext.theWork()
File ""/home/matrix/synapse/lib/python3.6/site-packages/twisted/python/threadpool.py"", line 266, in
inContext.theWork = lambda: context.call(ctx, func, *args, **kw)
File ""/home/matrix/synapse/lib/python3.6/site-packages/twisted/python/context.py"", line 122, in callWithContext
return self.currentContext().callWithContext(ctx, func, *args, **kw)
File ""/home/matrix/synapse/lib/python3.6/site-packages/twisted/python/context.py"", line 85, in callWithContext
return func(*args,**kw)
File ""/home/matrix/synapse/lib/python3.6/site-packages/twisted/enterprise/adbapi.py"", line 306, in _runWithConnection
compat.reraise(excValue, excTraceback)
File ""/home/matrix/synapse/lib/python3.6/site-packages/twisted/python/compat.py"", line 464, in reraise
raise exception.with_traceback(traceback)
File ""/home/matrix/synapse/lib/python3.6/site-packages/twisted/enterprise/adbapi.py"", line 297, in _runWithConnection
result = func(conn, *args, **kw)
File ""/home/matrix/synapse/lib/python3.6/site-packages/synapse/storage/database.py"", line 540, in inner_func
return func(conn, *args, **kwargs)
File ""/home/matrix/synapse/lib/python3.6/site-packages/synapse/storage/database.py"", line 378, in new_transaction
r = func(cursor, *args, **kwargs)
File ""/home/matrix/synapse/lib/python3.6/site-packages/synapse/storage/database.py"", line 1211, in simple_update_one_txn
rowcount = cls.simple_update_txn(txn, table, keyvalues, updatevalues)
File ""/home/matrix/synapse/lib/python3.6/site-packages/synapse/storage/database.py"", line 1181, in simple_update_txn
txn.execute(update_sql, list(updatevalues.values()) + list(keyvalues.values()))
File ""/home/matrix/synapse/lib/python3.6/site-packages/synapse/storage/database.py"", line 175, in execute
self._do_execute(self.txn.execute, sql, *args)
File ""/home/matrix/synapse/lib/python3.6/site-packages/synapse/storage/database.py"", line 201, in _do_execute
return func(sql, *args)
psycopg2.ProgrammingError: can't adapt type 'dict'
[homeserver_1] 2020-03-04 17:46:42,941 - synapse.access.http.8118 - 302 - INFO - PUT-58- 174.3.196.16 - 8118 - {@travis:t2l.io} Processed request: 0.144sec/0.000sec (0.093sec, 0.000sec) (0.002sec/0.047sec/3) 67B 500 ""PUT /_matrix/client/unstable/room_keys/keys?version=2 HTTP/1.0"" ""Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/80.0.3987.122 Safari/537.36"" [0 dbevts]
```
Synapse 1.11.1",
1252,https://api.github.com/repos/matrix-org/synapse/issues/7035,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7035/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7035/comments,https://api.github.com/repos/matrix-org/synapse/issues/7035/events,https://github.com/matrix-org/synapse/pull/7035,575602926,MDExOlB1bGxSZXF1ZXN0MzgzNzI3MDEy,7035,Hide extremities dummy events from clients,"{'login': 'babolivier', 'id': 5547783, 'node_id': 'MDQ6VXNlcjU1NDc3ODM=', 'avatar_url': 'https://avatars3.githubusercontent.com/u/5547783?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/babolivier', 'html_url': 'https://github.com/babolivier', 'followers_url': 'https://api.github.com/users/babolivier/followers', 'following_url': 'https://api.github.com/users/babolivier/following{/other_user}', 'gists_url': 'https://api.github.com/users/babolivier/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/babolivier/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/babolivier/subscriptions', 'organizations_url': 'https://api.github.com/users/babolivier/orgs', 'repos_url': 'https://api.github.com/users/babolivier/repos', 'events_url': 'https://api.github.com/users/babolivier/events{/privacy}', 'received_events_url': 'https://api.github.com/users/babolivier/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,0,2020-03-04T17:30:17Z,2020-03-05T10:51:21Z,2020-03-05T10:51:20Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7035', 'html_url': 'https://github.com/matrix-org/synapse/pull/7035', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7035.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7035.patch'}",Fix https://github.com/matrix-org/synapse/issues/6174,
1253,https://api.github.com/repos/matrix-org/synapse/issues/7034,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7034/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7034/comments,https://api.github.com/repos/matrix-org/synapse/issues/7034/events,https://github.com/matrix-org/synapse/pull/7034,575496614,MDExOlB1bGxSZXF1ZXN0MzgzNjM1ODM4,7034,Backout special casing of `m.room.aliases` events,"{'login': 'clokep', 'id': 517124, 'node_id': 'MDQ6VXNlcjUxNzEyNA==', 'avatar_url': 'https://avatars2.githubusercontent.com/u/517124?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/clokep', 'html_url': 'https://github.com/clokep', 'followers_url': 'https://api.github.com/users/clokep/followers', 'following_url': 'https://api.github.com/users/clokep/following{/other_user}', 'gists_url': 'https://api.github.com/users/clokep/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/clokep/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/clokep/subscriptions', 'organizations_url': 'https://api.github.com/users/clokep/orgs', 'repos_url': 'https://api.github.com/users/clokep/repos', 'events_url': 'https://api.github.com/users/clokep/events{/privacy}', 'received_events_url': 'https://api.github.com/users/clokep/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,4,2020-03-04T15:22:59Z,2020-03-17T11:37:06Z,2020-03-17T11:37:05Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7034', 'html_url': 'https://github.com/matrix-org/synapse/pull/7034', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7034.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7034.patch'}","As part of #6898 this backs out the changes in #6790 and #6794.
These PRs added special-cases for `m.room.aliases` events. Per MSC 2432 it is undesirable for `m.room.aliases` events to have any special treatment.
Note that these PRs were added for the v1.10.0rc1 release.
This was mostly just done with `git revert` and fixing some conflicts. It doesn't seem like any of the changes were desirable, but the copying of the permissions might have been good to do regardless.",
1254,https://api.github.com/repos/matrix-org/synapse/issues/7033,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7033/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7033/comments,https://api.github.com/repos/matrix-org/synapse/issues/7033/events,https://github.com/matrix-org/synapse/issues/7033,575371615,MDU6SXNzdWU1NzUzNzE2MTU=,7033,Failed to send_join via any server when joining #rust:matrix.org.,"{'login': 'cyphar', 'id': 2888411, 'node_id': 'MDQ6VXNlcjI4ODg0MTE=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/2888411?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/cyphar', 'html_url': 'https://github.com/cyphar', 'followers_url': 'https://api.github.com/users/cyphar/followers', 'following_url': 'https://api.github.com/users/cyphar/following{/other_user}', 'gists_url': 'https://api.github.com/users/cyphar/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/cyphar/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/cyphar/subscriptions', 'organizations_url': 'https://api.github.com/users/cyphar/orgs', 'repos_url': 'https://api.github.com/users/cyphar/repos', 'events_url': 'https://api.github.com/users/cyphar/events{/privacy}', 'received_events_url': 'https://api.github.com/users/cyphar/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,8,2020-03-04T12:44:08Z,2020-07-21T19:07:51Z,2020-03-04T12:49:23Z,NONE,,,"### Description
I've been running my own homeserver for over a year now, and it works great. But I just tried to join `#rust:matrix.org` and synapse fails to join with the following error shown on the client:
```
Failed to send_join via any server
```
The full backtrace for one of these events [is attached](https://github.com/matrix-org/synapse/files/4287289/homeserver.log.txt). Looks like the core issue is this `AttributeError`:
```
Traceback (most recent call last):
File ""/usr/lib/python3.7/site-packages/synapse/federation/federation_client.py"", line 402, in _try_destination_list
res = await callback(destination)
File ""/usr/lib/python3.7/site-packages/synapse/federation/federation_client.py"", line 589, in send_request
valid_pdus_map = {p.event_id: p for p in valid_pdus}
File ""/usr/lib/python3.7/site-packages/synapse/federation/federation_client.py"", line 589, in
valid_pdus_map = {p.event_id: p for p in valid_pdus}
AttributeError: 'coroutine' object has no attribute 'event_id'
```
### Steps to reproduce
- Run matrix-synapse 1.11.0.
- Try to join `#rust:matrix.org`.
- Note the behaviour listed above.
### Version information
- **Homeserver**: `cyphar.com`
- **Version**: `1.11.0`.
- **Install method**: Package manager.
- **Platform**: openSUSE Tumbleweed, inside an LXD container on openSUSE Leap 15.1.",
1255,https://api.github.com/repos/matrix-org/synapse/issues/7032,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7032/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7032/comments,https://api.github.com/repos/matrix-org/synapse/issues/7032/events,https://github.com/matrix-org/synapse/issues/7032,575313450,MDU6SXNzdWU1NzUzMTM0NTA=,7032,It is not exist easy way to check what Synapse version currently installed and running.,"{'login': 'jpVm5jYYRE1VIKL', 'id': 22169129, 'node_id': 'MDQ6VXNlcjIyMTY5MTI5', 'avatar_url': 'https://avatars3.githubusercontent.com/u/22169129?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/jpVm5jYYRE1VIKL', 'html_url': 'https://github.com/jpVm5jYYRE1VIKL', 'followers_url': 'https://api.github.com/users/jpVm5jYYRE1VIKL/followers', 'following_url': 'https://api.github.com/users/jpVm5jYYRE1VIKL/following{/other_user}', 'gists_url': 'https://api.github.com/users/jpVm5jYYRE1VIKL/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/jpVm5jYYRE1VIKL/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/jpVm5jYYRE1VIKL/subscriptions', 'organizations_url': 'https://api.github.com/users/jpVm5jYYRE1VIKL/orgs', 'repos_url': 'https://api.github.com/users/jpVm5jYYRE1VIKL/repos', 'events_url': 'https://api.github.com/users/jpVm5jYYRE1VIKL/events{/privacy}', 'received_events_url': 'https://api.github.com/users/jpVm5jYYRE1VIKL/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,3,2020-03-04T11:02:59Z,2020-03-04T11:46:10Z,2020-03-04T11:23:45Z,NONE,,,"**Description:**
It is not exist easy way to check what Synapse version currently installed and running.
It will be nice to have something to have opportunity to check or at least document it
",
1256,https://api.github.com/repos/matrix-org/synapse/issues/7031,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7031/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7031/comments,https://api.github.com/repos/matrix-org/synapse/issues/7031/events,https://github.com/matrix-org/synapse/issues/7031,575309102,MDU6SXNzdWU1NzUzMDkxMDI=,7031,Is it possible to change the storage to a mysql database,"{'login': 'FreeManNumOne', 'id': 15258115, 'node_id': 'MDQ6VXNlcjE1MjU4MTE1', 'avatar_url': 'https://avatars3.githubusercontent.com/u/15258115?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/FreeManNumOne', 'html_url': 'https://github.com/FreeManNumOne', 'followers_url': 'https://api.github.com/users/FreeManNumOne/followers', 'following_url': 'https://api.github.com/users/FreeManNumOne/following{/other_user}', 'gists_url': 'https://api.github.com/users/FreeManNumOne/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/FreeManNumOne/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/FreeManNumOne/subscriptions', 'organizations_url': 'https://api.github.com/users/FreeManNumOne/orgs', 'repos_url': 'https://api.github.com/users/FreeManNumOne/repos', 'events_url': 'https://api.github.com/users/FreeManNumOne/events{/privacy}', 'received_events_url': 'https://api.github.com/users/FreeManNumOne/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,4,2020-03-04T10:56:18Z,2020-03-04T11:43:34Z,2020-03-04T11:24:26Z,NONE,,,Is it possible to change the storage to a mysql database,
1257,https://api.github.com/repos/matrix-org/synapse/issues/7030,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7030/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7030/comments,https://api.github.com/repos/matrix-org/synapse/issues/7030/events,https://github.com/matrix-org/synapse/pull/7030,575281974,MDExOlB1bGxSZXF1ZXN0MzgzNDU1OTE0,7030,Break down monthly active users by appservice_id ,"{'login': 'neilisfragile', 'id': 451032, 'node_id': 'MDQ6VXNlcjQ1MTAzMg==', 'avatar_url': 'https://avatars2.githubusercontent.com/u/451032?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/neilisfragile', 'html_url': 'https://github.com/neilisfragile', 'followers_url': 'https://api.github.com/users/neilisfragile/followers', 'following_url': 'https://api.github.com/users/neilisfragile/following{/other_user}', 'gists_url': 'https://api.github.com/users/neilisfragile/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/neilisfragile/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/neilisfragile/subscriptions', 'organizations_url': 'https://api.github.com/users/neilisfragile/orgs', 'repos_url': 'https://api.github.com/users/neilisfragile/repos', 'events_url': 'https://api.github.com/users/neilisfragile/events{/privacy}', 'received_events_url': 'https://api.github.com/users/neilisfragile/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,0,2020-03-04T10:12:46Z,2020-03-06T18:14:21Z,2020-03-06T18:14:20Z,CONTRIBUTOR,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7030', 'html_url': 'https://github.com/matrix-org/synapse/pull/7030', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7030.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7030.patch'}","and emit via prometheus. Fixes #6994.
",
1258,https://api.github.com/repos/matrix-org/synapse/issues/7029,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7029/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7029/comments,https://api.github.com/repos/matrix-org/synapse/issues/7029/events,https://github.com/matrix-org/synapse/issues/7029,575021894,MDU6SXNzdWU1NzUwMjE4OTQ=,7029,GC aliases which point to rooms we know no longer exist on our server,"{'login': 'ara4n', 'id': 1294269, 'node_id': 'MDQ6VXNlcjEyOTQyNjk=', 'avatar_url': 'https://avatars2.githubusercontent.com/u/1294269?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/ara4n', 'html_url': 'https://github.com/ara4n', 'followers_url': 'https://api.github.com/users/ara4n/followers', 'following_url': 'https://api.github.com/users/ara4n/following{/other_user}', 'gists_url': 'https://api.github.com/users/ara4n/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/ara4n/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/ara4n/subscriptions', 'organizations_url': 'https://api.github.com/users/ara4n/orgs', 'repos_url': 'https://api.github.com/users/ara4n/repos', 'events_url': 'https://api.github.com/users/ara4n/events{/privacy}', 'received_events_url': 'https://api.github.com/users/ara4n/received_events', 'type': 'User', 'site_admin': False}","[{'id': 121086031, 'node_id': 'MDU6TGFiZWwxMjEwODYwMzE=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/enhancement', 'name': 'enhancement', 'color': '84b6eb', 'default': True, 'description': None}]",open,False,,[],,1,2020-03-03T23:16:32Z,2020-03-09T10:04:53Z,,MEMBER,,,,
1259,https://api.github.com/repos/matrix-org/synapse/issues/7028,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7028/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7028/comments,https://api.github.com/repos/matrix-org/synapse/issues/7028/events,https://github.com/matrix-org/synapse/issues/7028,574986197,MDU6SXNzdWU1NzQ5ODYxOTc=,7028,Mozilla SSO should try to squash usernames to lowercase rather than barf uglily on uppercase,"{'login': 'ara4n', 'id': 1294269, 'node_id': 'MDQ6VXNlcjEyOTQyNjk=', 'avatar_url': 'https://avatars2.githubusercontent.com/u/1294269?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/ara4n', 'html_url': 'https://github.com/ara4n', 'followers_url': 'https://api.github.com/users/ara4n/followers', 'following_url': 'https://api.github.com/users/ara4n/following{/other_user}', 'gists_url': 'https://api.github.com/users/ara4n/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/ara4n/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/ara4n/subscriptions', 'organizations_url': 'https://api.github.com/users/ara4n/orgs', 'repos_url': 'https://api.github.com/users/ara4n/repos', 'events_url': 'https://api.github.com/users/ara4n/events{/privacy}', 'received_events_url': 'https://api.github.com/users/ara4n/received_events', 'type': 'User', 'site_admin': False}","[{'id': 1311133228, 'node_id': 'MDU6TGFiZWwxMzExMTMzMjI4', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/info-needed', 'name': 'info-needed', 'color': 'a1e8ea', 'default': False, 'description': ''}]",closed,False,,[],,2,2020-03-03T22:12:58Z,2020-03-17T21:38:13Z,2020-03-17T21:38:13Z,MEMBER,,,,
1260,https://api.github.com/repos/matrix-org/synapse/issues/7027,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7027/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7027/comments,https://api.github.com/repos/matrix-org/synapse/issues/7027/events,https://github.com/matrix-org/synapse/issues/7027,574967367,MDU6SXNzdWU1NzQ5NjczNjc=,7027,Searching previous room versions doesn't work if your user is not a member of the older versions of the room,"{'login': 'ara4n', 'id': 1294269, 'node_id': 'MDQ6VXNlcjEyOTQyNjk=', 'avatar_url': 'https://avatars2.githubusercontent.com/u/1294269?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/ara4n', 'html_url': 'https://github.com/ara4n', 'followers_url': 'https://api.github.com/users/ara4n/followers', 'following_url': 'https://api.github.com/users/ara4n/following{/other_user}', 'gists_url': 'https://api.github.com/users/ara4n/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/ara4n/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/ara4n/subscriptions', 'organizations_url': 'https://api.github.com/users/ara4n/orgs', 'repos_url': 'https://api.github.com/users/ara4n/repos', 'events_url': 'https://api.github.com/users/ara4n/events{/privacy}', 'received_events_url': 'https://api.github.com/users/ara4n/received_events', 'type': 'User', 'site_admin': False}","[{'id': 121086029, 'node_id': 'MDU6TGFiZWwxMjEwODYwMjk=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/bug', 'name': 'bug', 'color': 'fc2929', 'default': True, 'description': None}, {'id': 477043173, 'node_id': 'MDU6TGFiZWw0NzcwNDMxNzM=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/p2', 'name': 'p2', 'color': 'fbca04', 'default': False, 'description': None}, {'id': 1281928350, 'node_id': 'MDU6TGFiZWwxMjgxOTI4MzUw', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/type:roomupgrades', 'name': 'type:roomupgrades', 'color': 'f9d0c4', 'default': False, 'description': ''}]",open,False,,[],,1,2020-03-03T21:43:05Z,2020-03-09T10:03:55Z,,MEMBER,,,,
1261,https://api.github.com/repos/matrix-org/synapse/issues/7026,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7026/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7026/comments,https://api.github.com/repos/matrix-org/synapse/issues/7026/events,https://github.com/matrix-org/synapse/pull/7026,574949412,MDExOlB1bGxSZXF1ZXN0MzgzMTgyMTYx,7026,Remove unused federation endpoint (`query_auth`),"{'login': 'clokep', 'id': 517124, 'node_id': 'MDQ6VXNlcjUxNzEyNA==', 'avatar_url': 'https://avatars2.githubusercontent.com/u/517124?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/clokep', 'html_url': 'https://github.com/clokep', 'followers_url': 'https://api.github.com/users/clokep/followers', 'following_url': 'https://api.github.com/users/clokep/following{/other_user}', 'gists_url': 'https://api.github.com/users/clokep/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/clokep/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/clokep/subscriptions', 'organizations_url': 'https://api.github.com/users/clokep/orgs', 'repos_url': 'https://api.github.com/users/clokep/repos', 'events_url': 'https://api.github.com/users/clokep/events{/privacy}', 'received_events_url': 'https://api.github.com/users/clokep/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,1,2020-03-03T21:15:01Z,2020-03-17T12:20:12Z,2020-03-17T12:04:50Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7026', 'html_url': 'https://github.com/matrix-org/synapse/pull/7026', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7026.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7026.patch'}","This removes the unused federation endpoint at `/_matrix/federation/v1/query_auth/{roomId}/{eventId}`.
As part of this it also:
* Moves `_check_sigs_and_hash_and_fetch` from `FederationBase` to `FederationClient` (since it calls into `FederationClient.get_pdu`).
* Converts `_check_sigs_and_hash_and_fetch` to be async/await.
* Fixes type issues that `mypy` found.
~~I need to put up an MSC for this work still, but I wanted to see it run through CI.~~ See [MSC2451](https://github.com/matrix-org/matrix-doc/pull/2451).
Fixes #6997 ",
1262,https://api.github.com/repos/matrix-org/synapse/issues/7025,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7025/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7025/comments,https://api.github.com/repos/matrix-org/synapse/issues/7025/events,https://github.com/matrix-org/synapse/issues/7025,574751573,MDU6SXNzdWU1NzQ3NTE1NzM=,7025,make the develop branch the default,"{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,6,2020-03-03T15:33:17Z,2020-05-20T15:07:56Z,2020-05-20T15:07:56Z,MEMBER,,,"the use of a non-default develop branch is inconsistent with common practice in git.
* In the synapse 1.12 release notes, we will announce our intention change the default branch.
* Once synapse 1.13 is released, we will make `develop` our default branch
* [ ] maybe? update CONTRIBUTING.rst",
1263,https://api.github.com/repos/matrix-org/synapse/issues/7024,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7024/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7024/comments,https://api.github.com/repos/matrix-org/synapse/issues/7024/events,https://github.com/matrix-org/synapse/pull/7024,574708506,MDExOlB1bGxSZXF1ZXN0MzgyOTg0MjQ1,7024,Move catchup of replication streams to worker.,"{'login': 'erikjohnston', 'id': 8428120, 'node_id': 'MDQ6VXNlcjg0MjgxMjA=', 'avatar_url': 'https://avatars0.githubusercontent.com/u/8428120?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/erikjohnston', 'html_url': 'https://github.com/erikjohnston', 'followers_url': 'https://api.github.com/users/erikjohnston/followers', 'following_url': 'https://api.github.com/users/erikjohnston/following{/other_user}', 'gists_url': 'https://api.github.com/users/erikjohnston/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/erikjohnston/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/erikjohnston/subscriptions', 'organizations_url': 'https://api.github.com/users/erikjohnston/orgs', 'repos_url': 'https://api.github.com/users/erikjohnston/repos', 'events_url': 'https://api.github.com/users/erikjohnston/events{/privacy}', 'received_events_url': 'https://api.github.com/users/erikjohnston/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,3,2020-03-03T14:30:12Z,2020-03-25T14:55:14Z,2020-03-25T14:54:01Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7024', 'html_url': 'https://github.com/matrix-org/synapse/pull/7024', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7024.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7024.patch'}","This changes the replication protocol so that the server does not send down `RDATA` for rows that happened before the client connected. Instead, the server will send a `POSITION` and clients then query the database (or master out of band) to get up to date.
~~Based on ~~#7010~~ and #7011~~",
1264,https://api.github.com/repos/matrix-org/synapse/issues/7023,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7023/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7023/comments,https://api.github.com/repos/matrix-org/synapse/issues/7023/events,https://github.com/matrix-org/synapse/issues/7023,574572885,MDU6SXNzdWU1NzQ1NzI4ODU=,7023,Email address is not automatically added to user profile when logging in with SAML2,"{'login': 'richvdh', 'id': 1389908, 'node_id': 'MDQ6VXNlcjEzODk5MDg=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1389908?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/richvdh', 'html_url': 'https://github.com/richvdh', 'followers_url': 'https://api.github.com/users/richvdh/followers', 'following_url': 'https://api.github.com/users/richvdh/following{/other_user}', 'gists_url': 'https://api.github.com/users/richvdh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/richvdh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/richvdh/subscriptions', 'organizations_url': 'https://api.github.com/users/richvdh/orgs', 'repos_url': 'https://api.github.com/users/richvdh/repos', 'events_url': 'https://api.github.com/users/richvdh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/richvdh/received_events', 'type': 'User', 'site_admin': False}","[{'id': 477046074, 'node_id': 'MDU6TGFiZWw0NzcwNDYwNzQ=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/auth', 'name': 'auth', 'color': 'ededed', 'default': False, 'description': None}, {'id': 121086031, 'node_id': 'MDU6TGFiZWwxMjEwODYwMzE=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/enhancement', 'name': 'enhancement', 'color': '84b6eb', 'default': True, 'description': None}, {'id': 477043173, 'node_id': 'MDU6TGFiZWw0NzcwNDMxNzM=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/p2', 'name': 'p2', 'color': 'fbca04', 'default': False, 'description': None}]",closed,False,,[],,2,2020-03-03T10:39:31Z,2020-05-27T16:40:41Z,2020-05-27T16:40:40Z,MEMBER,,,"As part of the SAML2 login flow, we normally get an email address back from the SAML2 provider. We should take this address and add it to the homeserver account for use in things like notifications and potential binding with an IS.
(would need to be configurable: some people would rather not have this information automatically added to matrix accounts.)",
1265,https://api.github.com/repos/matrix-org/synapse/issues/7022,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7022/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7022/comments,https://api.github.com/repos/matrix-org/synapse/issues/7022/events,https://github.com/matrix-org/synapse/pull/7022,574300525,MDExOlB1bGxSZXF1ZXN0MzgyNjQ5ODY0,7022,Add validation of format for 3pid and add validation of 3pid in admin api,"{'login': 'dklimpel', 'id': 5740567, 'node_id': 'MDQ6VXNlcjU3NDA1Njc=', 'avatar_url': 'https://avatars2.githubusercontent.com/u/5740567?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/dklimpel', 'html_url': 'https://github.com/dklimpel', 'followers_url': 'https://api.github.com/users/dklimpel/followers', 'following_url': 'https://api.github.com/users/dklimpel/following{/other_user}', 'gists_url': 'https://api.github.com/users/dklimpel/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/dklimpel/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/dklimpel/subscriptions', 'organizations_url': 'https://api.github.com/users/dklimpel/orgs', 'repos_url': 'https://api.github.com/users/dklimpel/repos', 'events_url': 'https://api.github.com/users/dklimpel/events{/privacy}', 'received_events_url': 'https://api.github.com/users/dklimpel/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,"{'login': 'clokep', 'id': 517124, 'node_id': 'MDQ6VXNlcjUxNzEyNA==', 'avatar_url': 'https://avatars2.githubusercontent.com/u/517124?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/clokep', 'html_url': 'https://github.com/clokep', 'followers_url': 'https://api.github.com/users/clokep/followers', 'following_url': 'https://api.github.com/users/clokep/following{/other_user}', 'gists_url': 'https://api.github.com/users/clokep/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/clokep/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/clokep/subscriptions', 'organizations_url': 'https://api.github.com/users/clokep/orgs', 'repos_url': 'https://api.github.com/users/clokep/repos', 'events_url': 'https://api.github.com/users/clokep/events{/privacy}', 'received_events_url': 'https://api.github.com/users/clokep/received_events', 'type': 'User', 'site_admin': False}","[{'login': 'clokep', 'id': 517124, 'node_id': 'MDQ6VXNlcjUxNzEyNA==', 'avatar_url': 'https://avatars2.githubusercontent.com/u/517124?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/clokep', 'html_url': 'https://github.com/clokep', 'followers_url': 'https://api.github.com/users/clokep/followers', 'following_url': 'https://api.github.com/users/clokep/following{/other_user}', 'gists_url': 'https://api.github.com/users/clokep/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/clokep/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/clokep/subscriptions', 'organizations_url': 'https://api.github.com/users/clokep/orgs', 'repos_url': 'https://api.github.com/users/clokep/repos', 'events_url': 'https://api.github.com/users/clokep/events{/privacy}', 'received_events_url': 'https://api.github.com/users/clokep/received_events', 'type': 'User', 'site_admin': False}]",,2,2020-03-02T22:51:51Z,2020-06-05T16:48:40Z,2020-06-05T16:48:40Z,CONTRIBUTOR,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7022', 'html_url': 'https://github.com/matrix-org/synapse/pull/7022', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7022.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7022.patch'}","Fix #6398 (Threepid whitespace is not trimmed before inserting to database)
and also add the check to admin api ``PUT /_synapse/admin/v2/users/``
## Pull Request Checklist
* [x] Pull request is based on the develop branch
* [x] Pull request includes a [changelog file](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#changelog). The entry should:
- Be a short description of your change which makes sense to users. ""Fixed a bug that prevented receiving messages from other servers."" instead of ""Moved X method from `EventStore` to `EventWorkerStore`."".
- Use markdown where necessary, mostly for `code blocks`.
- End with either a period (.) or an exclamation mark (!).
- Start with a capital letter.
* [x] Pull request includes a [sign off](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#sign-off)
* [x] Code style is correct (run the [linters](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#code-style))
Signed-off-by: Dirk Klimpel dirk@klimpel.org
",
1266,https://api.github.com/repos/matrix-org/synapse/issues/7021,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7021/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7021/comments,https://api.github.com/repos/matrix-org/synapse/issues/7021/events,https://github.com/matrix-org/synapse/pull/7021,574263270,MDExOlB1bGxSZXF1ZXN0MzgyNjIwMTE4,7021,Fix inconsistent handling of upper and lower cases of email addresses.,"{'login': 'dklimpel', 'id': 5740567, 'node_id': 'MDQ6VXNlcjU3NDA1Njc=', 'avatar_url': 'https://avatars2.githubusercontent.com/u/5740567?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/dklimpel', 'html_url': 'https://github.com/dklimpel', 'followers_url': 'https://api.github.com/users/dklimpel/followers', 'following_url': 'https://api.github.com/users/dklimpel/following{/other_user}', 'gists_url': 'https://api.github.com/users/dklimpel/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/dklimpel/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/dklimpel/subscriptions', 'organizations_url': 'https://api.github.com/users/dklimpel/orgs', 'repos_url': 'https://api.github.com/users/dklimpel/repos', 'events_url': 'https://api.github.com/users/dklimpel/events{/privacy}', 'received_events_url': 'https://api.github.com/users/dklimpel/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,"{'login': 'dklimpel', 'id': 5740567, 'node_id': 'MDQ6VXNlcjU3NDA1Njc=', 'avatar_url': 'https://avatars2.githubusercontent.com/u/5740567?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/dklimpel', 'html_url': 'https://github.com/dklimpel', 'followers_url': 'https://api.github.com/users/dklimpel/followers', 'following_url': 'https://api.github.com/users/dklimpel/following{/other_user}', 'gists_url': 'https://api.github.com/users/dklimpel/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/dklimpel/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/dklimpel/subscriptions', 'organizations_url': 'https://api.github.com/users/dklimpel/orgs', 'repos_url': 'https://api.github.com/users/dklimpel/repos', 'events_url': 'https://api.github.com/users/dklimpel/events{/privacy}', 'received_events_url': 'https://api.github.com/users/dklimpel/received_events', 'type': 'User', 'site_admin': False}","[{'login': 'dklimpel', 'id': 5740567, 'node_id': 'MDQ6VXNlcjU3NDA1Njc=', 'avatar_url': 'https://avatars2.githubusercontent.com/u/5740567?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/dklimpel', 'html_url': 'https://github.com/dklimpel', 'followers_url': 'https://api.github.com/users/dklimpel/followers', 'following_url': 'https://api.github.com/users/dklimpel/following{/other_user}', 'gists_url': 'https://api.github.com/users/dklimpel/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/dklimpel/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/dklimpel/subscriptions', 'organizations_url': 'https://api.github.com/users/dklimpel/orgs', 'repos_url': 'https://api.github.com/users/dklimpel/repos', 'events_url': 'https://api.github.com/users/dklimpel/events{/privacy}', 'received_events_url': 'https://api.github.com/users/dklimpel/received_events', 'type': 'User', 'site_admin': False}]",,7,2020-03-02T21:34:43Z,2020-07-03T14:06:08Z,2020-07-03T13:03:14Z,CONTRIBUTOR,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7021', 'html_url': 'https://github.com/matrix-org/synapse/pull/7021', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7021.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7021.patch'}","Fix #7016
### Pull Request Checklist
* [x] Pull request is based on the develop branch
* [x] Pull request includes a [changelog file](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#changelog). The entry should:
- Be a short description of your change which makes sense to users. ""Fixed a bug that prevented receiving messages from other servers."" instead of ""Moved X method from `EventStore` to `EventWorkerStore`."".
- Use markdown where necessary, mostly for `code blocks`.
- End with either a period (.) or an exclamation mark (!).
- Start with a capital letter.
* [x] Pull request includes a [sign off](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#sign-off)
* [x] Code style is correct (run the [linters](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#code-style))
Signed-off-by: Dirk Klimpel dirk@klimpel.org",
1267,https://api.github.com/repos/matrix-org/synapse/issues/7020,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7020/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7020/comments,https://api.github.com/repos/matrix-org/synapse/issues/7020/events,https://github.com/matrix-org/synapse/pull/7020,574225680,MDExOlB1bGxSZXF1ZXN0MzgyNTg5NjY1,7020,Convert remote key resource REST layer to async/await.,"{'login': 'clokep', 'id': 517124, 'node_id': 'MDQ6VXNlcjUxNzEyNA==', 'avatar_url': 'https://avatars2.githubusercontent.com/u/517124?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/clokep', 'html_url': 'https://github.com/clokep', 'followers_url': 'https://api.github.com/users/clokep/followers', 'following_url': 'https://api.github.com/users/clokep/following{/other_user}', 'gists_url': 'https://api.github.com/users/clokep/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/clokep/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/clokep/subscriptions', 'organizations_url': 'https://api.github.com/users/clokep/orgs', 'repos_url': 'https://api.github.com/users/clokep/repos', 'events_url': 'https://api.github.com/users/clokep/events{/privacy}', 'received_events_url': 'https://api.github.com/users/clokep/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,0,2020-03-02T20:24:21Z,2020-03-05T16:29:58Z,2020-03-05T16:29:57Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7020', 'html_url': 'https://github.com/matrix-org/synapse/pull/7020', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7020.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7020.patch'}",I wanted to try converting some basic code from deferreds to async/await. After this PR `Deferreds` aren't used in the `synapse.rest.keys` module.,
1268,https://api.github.com/repos/matrix-org/synapse/issues/7019,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7019/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7019/comments,https://api.github.com/repos/matrix-org/synapse/issues/7019/events,https://github.com/matrix-org/synapse/pull/7019,574084986,MDExOlB1bGxSZXF1ZXN0MzgyNDc1Mjk0,7019,Always return a deferred from `get_current_state_deltas`.,"{'login': 'erikjohnston', 'id': 8428120, 'node_id': 'MDQ6VXNlcjg0MjgxMjA=', 'avatar_url': 'https://avatars0.githubusercontent.com/u/8428120?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/erikjohnston', 'html_url': 'https://github.com/erikjohnston', 'followers_url': 'https://api.github.com/users/erikjohnston/followers', 'following_url': 'https://api.github.com/users/erikjohnston/following{/other_user}', 'gists_url': 'https://api.github.com/users/erikjohnston/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/erikjohnston/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/erikjohnston/subscriptions', 'organizations_url': 'https://api.github.com/users/erikjohnston/orgs', 'repos_url': 'https://api.github.com/users/erikjohnston/repos', 'events_url': 'https://api.github.com/users/erikjohnston/events{/privacy}', 'received_events_url': 'https://api.github.com/users/erikjohnston/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,0,2020-03-02T16:17:32Z,2020-03-02T16:52:17Z,2020-03-02T16:52:16Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7019', 'html_url': 'https://github.com/matrix-org/synapse/pull/7019', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7019.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7019.patch'}","This currently causes presence notify code to log exceptions when there
is no state changes to process. This doesn't actually cause any problems
as we'd simply do nothing anyway.
Broke in #6991.",
1269,https://api.github.com/repos/matrix-org/synapse/issues/7018,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7018/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7018/comments,https://api.github.com/repos/matrix-org/synapse/issues/7018/events,https://github.com/matrix-org/synapse/pull/7018,574055410,MDExOlB1bGxSZXF1ZXN0MzgyNDUxMDA5,7018,Fix py35-old CI by using native tox.,"{'login': 'erikjohnston', 'id': 8428120, 'node_id': 'MDQ6VXNlcjg0MjgxMjA=', 'avatar_url': 'https://avatars0.githubusercontent.com/u/8428120?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/erikjohnston', 'html_url': 'https://github.com/erikjohnston', 'followers_url': 'https://api.github.com/users/erikjohnston/followers', 'following_url': 'https://api.github.com/users/erikjohnston/following{/other_user}', 'gists_url': 'https://api.github.com/users/erikjohnston/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/erikjohnston/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/erikjohnston/subscriptions', 'organizations_url': 'https://api.github.com/users/erikjohnston/orgs', 'repos_url': 'https://api.github.com/users/erikjohnston/repos', 'events_url': 'https://api.github.com/users/erikjohnston/events{/privacy}', 'received_events_url': 'https://api.github.com/users/erikjohnston/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,2,2020-03-02T15:33:27Z,2020-03-02T16:17:13Z,2020-03-02T16:17:12Z,MEMBER,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7018', 'html_url': 'https://github.com/matrix-org/synapse/pull/7018', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7018.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7018.patch'}","I'm not really sure how this was going wrong, but this seems like the
right approach anyway.",
1270,https://api.github.com/repos/matrix-org/synapse/issues/7017,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7017/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7017/comments,https://api.github.com/repos/matrix-org/synapse/issues/7017/events,https://github.com/matrix-org/synapse/issues/7017,573918350,MDU6SXNzdWU1NzM5MTgzNTA=,7017,Synapse application logs sometimes log HTTP status codes as text.,"{'login': 'lampholder', 'id': 1922197, 'node_id': 'MDQ6VXNlcjE5MjIxOTc=', 'avatar_url': 'https://avatars2.githubusercontent.com/u/1922197?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/lampholder', 'html_url': 'https://github.com/lampholder', 'followers_url': 'https://api.github.com/users/lampholder/followers', 'following_url': 'https://api.github.com/users/lampholder/following{/other_user}', 'gists_url': 'https://api.github.com/users/lampholder/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/lampholder/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/lampholder/subscriptions', 'organizations_url': 'https://api.github.com/users/lampholder/orgs', 'repos_url': 'https://api.github.com/users/lampholder/repos', 'events_url': 'https://api.github.com/users/lampholder/events{/privacy}', 'received_events_url': 'https://api.github.com/users/lampholder/received_events', 'type': 'User', 'site_admin': False}","[{'id': 121086029, 'node_id': 'MDU6TGFiZWwxMjEwODYwMjk=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/bug', 'name': 'bug', 'color': 'fc2929', 'default': True, 'description': None}, {'id': 477043173, 'node_id': 'MDU6TGFiZWw0NzcwNDMxNzM=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/p2', 'name': 'p2', 'color': 'fbca04', 'default': False, 'description': None}]",closed,False,"{'login': 'anoadragon453', 'id': 1342360, 'node_id': 'MDQ6VXNlcjEzNDIzNjA=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1342360?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/anoadragon453', 'html_url': 'https://github.com/anoadragon453', 'followers_url': 'https://api.github.com/users/anoadragon453/followers', 'following_url': 'https://api.github.com/users/anoadragon453/following{/other_user}', 'gists_url': 'https://api.github.com/users/anoadragon453/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/anoadragon453/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/anoadragon453/subscriptions', 'organizations_url': 'https://api.github.com/users/anoadragon453/orgs', 'repos_url': 'https://api.github.com/users/anoadragon453/repos', 'events_url': 'https://api.github.com/users/anoadragon453/events{/privacy}', 'received_events_url': 'https://api.github.com/users/anoadragon453/received_events', 'type': 'User', 'site_admin': False}","[{'login': 'anoadragon453', 'id': 1342360, 'node_id': 'MDQ6VXNlcjEzNDIzNjA=', 'avatar_url': 'https://avatars1.githubusercontent.com/u/1342360?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/anoadragon453', 'html_url': 'https://github.com/anoadragon453', 'followers_url': 'https://api.github.com/users/anoadragon453/followers', 'following_url': 'https://api.github.com/users/anoadragon453/following{/other_user}', 'gists_url': 'https://api.github.com/users/anoadragon453/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/anoadragon453/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/anoadragon453/subscriptions', 'organizations_url': 'https://api.github.com/users/anoadragon453/orgs', 'repos_url': 'https://api.github.com/users/anoadragon453/repos', 'events_url': 'https://api.github.com/users/anoadragon453/events{/privacy}', 'received_events_url': 'https://api.github.com/users/anoadragon453/received_events', 'type': 'User', 'site_admin': False}]",,6,2020-03-02T11:43:33Z,2020-04-03T13:26:34Z,2020-04-03T13:26:33Z,MEMBER,,,"`event_creator1.log-20200228` at `2020-02-28 00:45:13,117 - synapse.access.http.8095` the HTTP status code appears as `HTTPStatus.FORBIDDEN` instead of 403.
",
1271,https://api.github.com/repos/matrix-org/synapse/issues/7016,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7016/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7016/comments,https://api.github.com/repos/matrix-org/synapse/issues/7016/events,https://github.com/matrix-org/synapse/issues/7016,573915348,MDU6SXNzdWU1NzM5MTUzNDg=,7016,Handling of upper and lower case of e-mail addresses,"{'login': 'dklimpel', 'id': 5740567, 'node_id': 'MDQ6VXNlcjU3NDA1Njc=', 'avatar_url': 'https://avatars2.githubusercontent.com/u/5740567?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/dklimpel', 'html_url': 'https://github.com/dklimpel', 'followers_url': 'https://api.github.com/users/dklimpel/followers', 'following_url': 'https://api.github.com/users/dklimpel/following{/other_user}', 'gists_url': 'https://api.github.com/users/dklimpel/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/dklimpel/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/dklimpel/subscriptions', 'organizations_url': 'https://api.github.com/users/dklimpel/orgs', 'repos_url': 'https://api.github.com/users/dklimpel/repos', 'events_url': 'https://api.github.com/users/dklimpel/events{/privacy}', 'received_events_url': 'https://api.github.com/users/dklimpel/received_events', 'type': 'User', 'site_admin': False}","[{'id': 121086031, 'node_id': 'MDU6TGFiZWwxMjEwODYwMzE=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/enhancement', 'name': 'enhancement', 'color': '84b6eb', 'default': True, 'description': None}, {'id': 477043173, 'node_id': 'MDU6TGFiZWw0NzcwNDMxNzM=', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/p2', 'name': 'p2', 'color': 'fbca04', 'default': False, 'description': None}]",closed,False,,[],,9,2020-03-02T11:37:20Z,2020-07-03T13:03:14Z,2020-07-03T13:03:14Z,CONTRIBUTOR,,,"Due to the handling of upper and lower case of e-mail addresses, you can register the same e-mail address several times.
I will create a PR.
### Description
### Steps to reproduce
- register mail address to an account
- register the same address to an other account (different case typing)
### Version information
- **Homeserver**: Own
If not matrix.org:
- **Version**: 1.11.0
- **Install method**: Debian Package
- **Platform**: Azure VM
",
1272,https://api.github.com/repos/matrix-org/synapse/issues/7015,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7015/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7015/comments,https://api.github.com/repos/matrix-org/synapse/issues/7015/events,https://github.com/matrix-org/synapse/pull/7015,573412078,MDExOlB1bGxSZXF1ZXN0MzgxOTQ1Mjc4,7015,Fix last date for ACMEv1 install,"{'login': 'udaybansal19', 'id': 43824981, 'node_id': 'MDQ6VXNlcjQzODI0OTgx', 'avatar_url': 'https://avatars0.githubusercontent.com/u/43824981?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/udaybansal19', 'html_url': 'https://github.com/udaybansal19', 'followers_url': 'https://api.github.com/users/udaybansal19/followers', 'following_url': 'https://api.github.com/users/udaybansal19/following{/other_user}', 'gists_url': 'https://api.github.com/users/udaybansal19/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/udaybansal19/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/udaybansal19/subscriptions', 'organizations_url': 'https://api.github.com/users/udaybansal19/orgs', 'repos_url': 'https://api.github.com/users/udaybansal19/repos', 'events_url': 'https://api.github.com/users/udaybansal19/events{/privacy}', 'received_events_url': 'https://api.github.com/users/udaybansal19/received_events', 'type': 'User', 'site_admin': False}",[],closed,False,,[],,0,2020-02-29T21:11:05Z,2020-02-29T23:37:24Z,2020-02-29T23:37:24Z,CONTRIBUTOR,,"{'url': 'https://api.github.com/repos/matrix-org/synapse/pulls/7015', 'html_url': 'https://github.com/matrix-org/synapse/pull/7015', 'diff_url': 'https://github.com/matrix-org/synapse/pull/7015.diff', 'patch_url': 'https://github.com/matrix-org/synapse/pull/7015.patch'}",Support for getting TLS certificates through ACMEv1 ended on November 2019.,
1273,https://api.github.com/repos/matrix-org/synapse/issues/7014,https://api.github.com/repos/matrix-org/synapse,https://api.github.com/repos/matrix-org/synapse/issues/7014/labels{/name},https://api.github.com/repos/matrix-org/synapse/issues/7014/comments,https://api.github.com/repos/matrix-org/synapse/issues/7014/events,https://github.com/matrix-org/synapse/issues/7014,573335375,MDU6SXNzdWU1NzMzMzUzNzU=,7014,Duplicate keyvalue hurts Unique-Constraint redactions_event_id_key,"{'login': 'Chatcloud', 'id': 53553858, 'node_id': 'MDQ6VXNlcjUzNTUzODU4', 'avatar_url': 'https://avatars0.githubusercontent.com/u/53553858?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Chatcloud', 'html_url': 'https://github.com/Chatcloud', 'followers_url': 'https://api.github.com/users/Chatcloud/followers', 'following_url': 'https://api.github.com/users/Chatcloud/following{/other_user}', 'gists_url': 'https://api.github.com/users/Chatcloud/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/Chatcloud/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/Chatcloud/subscriptions', 'organizations_url': 'https://api.github.com/users/Chatcloud/orgs', 'repos_url': 'https://api.github.com/users/Chatcloud/repos', 'events_url': 'https://api.github.com/users/Chatcloud/events{/privacy}', 'received_events_url': 'https://api.github.com/users/Chatcloud/received_events', 'type': 'User', 'site_admin': False}","[{'id': 1311133228, 'node_id': 'MDU6TGFiZWwxMzExMTMzMjI4', 'url': 'https://api.github.com/repos/matrix-org/synapse/labels/info-needed', 'name': 'info-needed', 'color': 'a1e8ea', 'default': False, 'description': ''}]",closed,False,,[],,4,2020-02-29T16:57:06Z,2020-04-02T14:19:29Z,2020-04-02T14:19:29Z,NONE,,,"```
2020-02-29 12:15:16,052 - synapse.storage.data_stores.main.events - 90 - ERROR - persist_events-135 - IntegrityError, retrying.
Traceback (most recent call last):
File ""/opt/venvs/matrix-synapse/lib/python3.6/site-packages/synapse/storage/data_stores/main/events.py"", line 88, in f
res = yield func(self, *args, delete_existing=False, **kwargs)
File ""/opt/venvs/matrix-synapse/lib/python3.6/site-packages/twisted/internet/defer.py"", line 1416, in _inlineCallbacks
result = result.throwExceptionIntoGenerator(g)
File ""/opt/venvs/matrix-synapse/lib/python3.6/site-packages/twisted/python/failure.py"", line 512, in throwExceptionIntoGenerator
return g.throw(self.type, self.value, self.tb)
File ""/opt/venvs/matrix-synapse/lib/python3.6/site-packages/synapse/storage/data_stores/main/events.py"", line 215, in _persist_events_and_state_updates
new_forward_extremeties=new_forward_extremeties,
File ""/opt/venvs/matrix-synapse/lib/python3.6/site-packages/twisted/internet/defer.py"", line 1416, in _inlineCallbacks
result = result.throwExceptionIntoGenerator(g)
File ""/opt/venvs/matrix-synapse/lib/python3.6/site-packages/twisted/python/failure.py"", line 512, in throwExceptionIntoGenerator
return g.throw(self.type, self.value, self.tb)
File ""/opt/venvs/matrix-synapse/lib/python3.6/site-packages/synapse/storage/database.py"", line 495, in runInteraction
**kwargs
File ""/opt/venvs/matrix-synapse/lib/python3.6/site-packages/twisted/internet/defer.py"", line 1416, in _inlineCallbacks
result = result.throwExceptionIntoGenerator(g)
File ""/opt/venvs/matrix-synapse/lib/python3.6/site-packages/twisted/python/failure.py"", line 512, in throwExceptionIntoGenerator
return g.throw(self.type, self.value, self.tb)
File ""/opt/venvs/matrix-synapse/lib/python3.6/site-packages/synapse/storage/database.py"", line 543, in runWithConnection
self._db_pool.runWithConnection(inner_func, *args, **kwargs)
File ""/opt/venvs/matrix-synapse/lib/python3.6/site-packages/twisted/python/threadpool.py"", line 250, in inContext
result = inContext.theWork()
File ""/opt/venvs/matrix-synapse/lib/python3.6/site-packages/twisted/python/threadpool.py"", line 266, in
inContext.theWork = lambda: context.call(ctx, func, *args, **kw)
File ""/opt/venvs/matrix-synapse/lib/python3.6/site-packages/twisted/python/context.py"", line 122, in callWithContext
return self.currentContext().callWithContext(ctx, func, *args, **kw)
File ""/opt/venvs/matrix-synapse/lib/python3.6/site-packages/twisted/python/context.py"", line 85, in callWithContext
return func(*args,**kw)
File ""/opt/venvs/matrix-synapse/lib/python3.6/site-packages/twisted/enterprise/adbapi.py"", line 306, in _runWithConnection
compat.reraise(excValue, excTraceback)
File ""/opt/venvs/matrix-synapse/lib/python3.6/site-packages/twisted/python/compat.py"", line 464, in reraise
raise exception.with_traceback(traceback)
File ""/opt/venvs/matrix-synapse/lib/python3.6/site-packages/twisted/enterprise/adbapi.py"", line 297, in _runWithConnection
result = func(conn, *args, **kw)
File ""/opt/venvs/matrix-synapse/lib/python3.6/site-packages/synapse/storage/database.py"", line 540, in inner_func
return func(conn, *args, **kwargs)
File ""/opt/venvs/matrix-synapse/lib/python3.6/site-packages/synapse/storage/database.py"", line 378, in new_transaction
r = func(cursor, *args, **kwargs)
File ""/opt/venvs/matrix-synapse/lib/python3.6/site-packages/synapse/logging/utils.py"", line 79, in wrapped
return f(*args, **kwargs)
File ""/opt/venvs/matrix-synapse/lib/python3.6/site-packages/synapse/storage/data_stores/main/events.py"", line 455, in _persist_events_txn
backfilled=backfilled,
File ""/opt/venvs/matrix-synapse/lib/python3.6/site-packages/synapse/storage/data_stores/main/events.py"", line 995, in _update_metadata_tables_txn
self._store_redaction(txn, event)
File ""/opt/venvs/matrix-synapse/lib/python3.6/site-packages/synapse/storage/data_stores/main/events.py"", line 1105, in _store_redaction
""received_ts"": self._clock.time_msec(),
File ""/opt/venvs/matrix-synapse/lib/python3.6/site-packages/synapse/storage/database.py"", line 621, in simple_insert_txn
txn.execute(sql, vals)
File ""/opt/venvs/matrix-synapse/lib/python3.6/site-packages/synapse/storage/database.py"", line 175, in execute
self._do_execute(self.txn.execute, sql, *args)
File ""/opt/venvs/matrix-synapse/lib/python3.6/site-packages/synapse/storage/database.py"", line 201, in _do_execute
return func(sql, *args)
psycopg2.errors.UniqueViolation: FEHLER: doppelter Schlüsselwert verletzt Unique-Constraint »redactions_event_id_key«
DETAIL: Schlüssel »(event_id)=($iP9Egcwwd1_ovRma_UwwJIh_LX2FxEYF2QIjbaaHGcE)« existiert bereits.
2020-02-29 12:15:16,081 - synapse.storage.data_stores.main.events - 90 - ERROR - persist_events-135 - IntegrityError, retrying.
Traceback (most recent call last):
File ""/opt/venvs/matrix-synapse/lib/python3.6/site-packages/synapse/storage/data_stores/main/events.py"", line 88, in f
res = yield func(self, *args, delete_existing=False, **kwargs)
File ""/opt/venvs/matrix-synapse/lib/python3.6/site-packages/twisted/internet/defer.py"", line 1416, in _inlineCallbacks
result = result.throwExceptionIntoGenerator(g)
File ""/opt/venvs/matrix-synapse/lib/python3.6/site-packages/twisted/python/failure.py"", line 512, in throwExceptionIntoGenerator
return g.throw(self.type, self.value, self.tb)
File ""/opt/venvs/matrix-synapse/lib/python3.6/site-packages/synapse/storage/data_stores/main/events.py"", line 215, in _persist_events_and_state_updates
new_forward_extremeties=new_forward_extremeties,
File ""/opt/venvs/matrix-synapse/lib/python3.6/site-packages/twisted/internet/defer.py"", line 1416, in _inlineCallbacks
result = result.throwExceptionIntoGenerator(g)
File ""/opt/venvs/matrix-synapse/lib/python3.6/site-packages/twisted/python/failure.py"", line 512, in throwExceptionIntoGenerator
return g.throw(self.type, self.value, self.tb)
File ""/opt/venvs/matrix-synapse/lib/python3.6/site-packages/synapse/storage/database.py"", line 495, in runInteraction
**kwargs
File ""/opt/venvs/matrix-synapse/lib/python3.6/site-packages/twisted/internet/defer.py"", line 1416, in _inlineCallbacks
result = result.throwExceptionIntoGenerator(g)
File ""/opt/venvs/matrix-synapse/lib/python3.6/site-packages/twisted/python/failure.py"", line 512, in throwExceptionIntoGenerator
return g.throw(self.type, self.value, self.tb)
File ""/opt/venvs/matrix-synapse/lib/python3.6/site-packages/synapse/storage/database.py"", line 543, in runWithConnection
self._db_pool.runWithConnection(inner_func, *args, **kwargs)
File ""/opt/venvs/matrix-synapse/lib/python3.6/site-packages/twisted/python/threadpool.py"", line 250, in inContext
result = inContext.theWork()
File ""/opt/venvs/matrix-synapse/lib/python3.6/site-packages/twisted/python/threadpool.py"", line 266, in