2022-08-11 16:23:35 +00:00
|
|
|
|
// Copyright 2022 The Matrix.org Foundation C.I.C.
|
|
|
|
|
//
|
|
|
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
|
|
|
// you may not use this file except in compliance with the License.
|
|
|
|
|
// You may obtain a copy of the License at
|
|
|
|
|
//
|
|
|
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
|
//
|
|
|
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
|
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
|
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
|
|
|
// See the License for the specific language governing permissions and
|
|
|
|
|
// limitations under the License.
|
|
|
|
|
|
|
|
|
|
package internal
|
|
|
|
|
|
|
|
|
|
import (
|
|
|
|
|
"context"
|
|
|
|
|
"math"
|
|
|
|
|
"time"
|
|
|
|
|
|
|
|
|
|
"github.com/matrix-org/gomatrixserverlib"
|
2023-04-19 14:50:33 +00:00
|
|
|
|
"github.com/matrix-org/gomatrixserverlib/spec"
|
2022-08-11 16:23:35 +00:00
|
|
|
|
"github.com/prometheus/client_golang/prometheus"
|
2022-10-10 10:19:16 +00:00
|
|
|
|
"github.com/sirupsen/logrus"
|
2022-08-11 16:23:35 +00:00
|
|
|
|
"github.com/tidwall/gjson"
|
2022-10-10 10:19:16 +00:00
|
|
|
|
|
|
|
|
|
"github.com/matrix-org/dendrite/roomserver/api"
|
2023-04-27 11:54:20 +00:00
|
|
|
|
"github.com/matrix-org/dendrite/roomserver/types"
|
2022-10-10 10:19:16 +00:00
|
|
|
|
"github.com/matrix-org/dendrite/syncapi/storage"
|
2022-08-11 16:23:35 +00:00
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
func init() {
|
|
|
|
|
prometheus.MustRegister(calculateHistoryVisibilityDuration)
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// calculateHistoryVisibilityDuration stores the time it takes to
|
2023-02-14 11:47:47 +00:00
|
|
|
|
// calculate the history visibility.
|
2022-08-11 16:23:35 +00:00
|
|
|
|
var calculateHistoryVisibilityDuration = prometheus.NewHistogramVec(
|
|
|
|
|
prometheus.HistogramOpts{
|
|
|
|
|
Namespace: "dendrite",
|
|
|
|
|
Subsystem: "syncapi",
|
|
|
|
|
Name: "calculateHistoryVisibility_duration_millis",
|
|
|
|
|
Help: "How long it takes to calculate the history visibility",
|
|
|
|
|
Buckets: []float64{ // milliseconds
|
|
|
|
|
5, 10, 25, 50, 75, 100, 250, 500,
|
|
|
|
|
1000, 2000, 3000, 4000, 5000, 6000,
|
|
|
|
|
7000, 8000, 9000, 10000, 15000, 20000,
|
|
|
|
|
},
|
|
|
|
|
},
|
|
|
|
|
[]string{"api"},
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
var historyVisibilityPriority = map[gomatrixserverlib.HistoryVisibility]uint8{
|
2023-04-19 14:50:33 +00:00
|
|
|
|
spec.WorldReadable: 0,
|
2022-08-11 16:23:35 +00:00
|
|
|
|
gomatrixserverlib.HistoryVisibilityShared: 1,
|
|
|
|
|
gomatrixserverlib.HistoryVisibilityInvited: 2,
|
|
|
|
|
gomatrixserverlib.HistoryVisibilityJoined: 3,
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// eventVisibility contains the history visibility and membership state at a given event
|
|
|
|
|
type eventVisibility struct {
|
|
|
|
|
visibility gomatrixserverlib.HistoryVisibility
|
|
|
|
|
membershipAtEvent string
|
|
|
|
|
membershipCurrent string
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// allowed checks the eventVisibility if the user is allowed to see the event.
|
|
|
|
|
// Rules as defined by https://spec.matrix.org/v1.3/client-server-api/#server-behaviour-5
|
|
|
|
|
func (ev eventVisibility) allowed() (allowed bool) {
|
|
|
|
|
switch ev.visibility {
|
|
|
|
|
case gomatrixserverlib.HistoryVisibilityWorldReadable:
|
|
|
|
|
// If the history_visibility was set to world_readable, allow.
|
|
|
|
|
return true
|
|
|
|
|
case gomatrixserverlib.HistoryVisibilityJoined:
|
|
|
|
|
// If the user’s membership was join, allow.
|
2023-04-19 14:50:33 +00:00
|
|
|
|
if ev.membershipAtEvent == spec.Join {
|
2022-08-11 16:23:35 +00:00
|
|
|
|
return true
|
|
|
|
|
}
|
|
|
|
|
return false
|
|
|
|
|
case gomatrixserverlib.HistoryVisibilityShared:
|
|
|
|
|
// If the user’s membership was join, allow.
|
|
|
|
|
// If history_visibility was set to shared, and the user joined the room at any point after the event was sent, allow.
|
2023-04-19 14:50:33 +00:00
|
|
|
|
if ev.membershipAtEvent == spec.Join || ev.membershipCurrent == spec.Join {
|
2022-08-11 16:23:35 +00:00
|
|
|
|
return true
|
|
|
|
|
}
|
|
|
|
|
return false
|
|
|
|
|
case gomatrixserverlib.HistoryVisibilityInvited:
|
|
|
|
|
// If the user’s membership was join, allow.
|
2023-04-19 14:50:33 +00:00
|
|
|
|
if ev.membershipAtEvent == spec.Join {
|
2022-08-11 16:23:35 +00:00
|
|
|
|
return true
|
|
|
|
|
}
|
2023-04-19 14:50:33 +00:00
|
|
|
|
if ev.membershipAtEvent == spec.Invite {
|
2022-08-11 16:23:35 +00:00
|
|
|
|
return true
|
|
|
|
|
}
|
|
|
|
|
return false
|
|
|
|
|
default:
|
|
|
|
|
return false
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2023-04-27 11:54:20 +00:00
|
|
|
|
// ApplyHistoryVisibilityFilter applies the room history visibility filter on types.HeaderedEvents.
|
2022-08-11 16:23:35 +00:00
|
|
|
|
// Returns the filtered events and an error, if any.
|
|
|
|
|
func ApplyHistoryVisibilityFilter(
|
|
|
|
|
ctx context.Context,
|
2022-09-30 11:48:10 +00:00
|
|
|
|
syncDB storage.DatabaseTransaction,
|
2022-08-11 16:23:35 +00:00
|
|
|
|
rsAPI api.SyncRoomserverAPI,
|
2023-04-27 11:54:20 +00:00
|
|
|
|
events []*types.HeaderedEvent,
|
2022-08-11 16:23:35 +00:00
|
|
|
|
alwaysIncludeEventIDs map[string]struct{},
|
|
|
|
|
userID, endpoint string,
|
2023-04-27 11:54:20 +00:00
|
|
|
|
) ([]*types.HeaderedEvent, error) {
|
2022-08-11 16:23:35 +00:00
|
|
|
|
if len(events) == 0 {
|
|
|
|
|
return events, nil
|
|
|
|
|
}
|
|
|
|
|
start := time.Now()
|
|
|
|
|
|
|
|
|
|
// try to get the current membership of the user
|
|
|
|
|
membershipCurrent, _, err := syncDB.SelectMembershipForUser(ctx, events[0].RoomID(), userID, math.MaxInt64)
|
|
|
|
|
if err != nil {
|
|
|
|
|
return nil, err
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// Get the mapping from eventID -> eventVisibility
|
2023-04-27 11:54:20 +00:00
|
|
|
|
eventsFiltered := make([]*types.HeaderedEvent, 0, len(events))
|
2023-02-07 13:31:23 +00:00
|
|
|
|
visibilities := visibilityForEvents(ctx, rsAPI, events, userID, events[0].RoomID())
|
2022-08-11 16:23:35 +00:00
|
|
|
|
for _, ev := range events {
|
|
|
|
|
evVis := visibilities[ev.EventID()]
|
|
|
|
|
evVis.membershipCurrent = membershipCurrent
|
|
|
|
|
// Always include specific state events for /sync responses
|
|
|
|
|
if alwaysIncludeEventIDs != nil {
|
|
|
|
|
if _, ok := alwaysIncludeEventIDs[ev.EventID()]; ok {
|
|
|
|
|
eventsFiltered = append(eventsFiltered, ev)
|
|
|
|
|
continue
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
// NOTSPEC: Always allow user to see their own membership events (spec contains more "rules")
|
2023-06-12 11:19:25 +00:00
|
|
|
|
|
|
|
|
|
user, err := spec.NewUserID(userID, true)
|
|
|
|
|
if err != nil {
|
|
|
|
|
return nil, err
|
|
|
|
|
}
|
|
|
|
|
senderID, err := rsAPI.QuerySenderIDForUser(ctx, ev.RoomID(), *user)
|
|
|
|
|
if err == nil {
|
|
|
|
|
if ev.Type() == spec.MRoomMember && ev.StateKeyEquals(string(senderID)) {
|
|
|
|
|
eventsFiltered = append(eventsFiltered, ev)
|
|
|
|
|
continue
|
|
|
|
|
}
|
2022-08-11 16:23:35 +00:00
|
|
|
|
}
|
|
|
|
|
// Always allow history evVis events on boundaries. This is done
|
|
|
|
|
// by setting the effective evVis to the least restrictive
|
|
|
|
|
// of the old vs new.
|
|
|
|
|
// https://spec.matrix.org/v1.3/client-server-api/#server-behaviour-5
|
|
|
|
|
if hisVis, err := ev.HistoryVisibility(); err == nil {
|
|
|
|
|
prevHisVis := gjson.GetBytes(ev.Unsigned(), "prev_content.history_visibility").String()
|
|
|
|
|
oldPrio, ok := historyVisibilityPriority[gomatrixserverlib.HistoryVisibility(prevHisVis)]
|
|
|
|
|
// if we can't get the previous history visibility, default to shared.
|
|
|
|
|
if !ok {
|
|
|
|
|
oldPrio = historyVisibilityPriority[gomatrixserverlib.HistoryVisibilityShared]
|
|
|
|
|
}
|
|
|
|
|
// no OK check, since this should have been validated when setting the value
|
|
|
|
|
newPrio := historyVisibilityPriority[hisVis]
|
|
|
|
|
if oldPrio < newPrio {
|
|
|
|
|
evVis.visibility = gomatrixserverlib.HistoryVisibility(prevHisVis)
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
// do the actual check
|
|
|
|
|
allowed := evVis.allowed()
|
|
|
|
|
if allowed {
|
|
|
|
|
eventsFiltered = append(eventsFiltered, ev)
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
calculateHistoryVisibilityDuration.With(prometheus.Labels{"api": endpoint}).Observe(float64(time.Since(start).Milliseconds()))
|
|
|
|
|
return eventsFiltered, nil
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// visibilityForEvents returns a map from eventID to eventVisibility containing the visibility and the membership
|
|
|
|
|
// of `userID` at the given event.
|
|
|
|
|
// Returns an error if the roomserver can't calculate the memberships.
|
|
|
|
|
func visibilityForEvents(
|
|
|
|
|
ctx context.Context,
|
|
|
|
|
rsAPI api.SyncRoomserverAPI,
|
2023-04-27 11:54:20 +00:00
|
|
|
|
events []*types.HeaderedEvent,
|
2022-08-11 16:23:35 +00:00
|
|
|
|
userID, roomID string,
|
2023-02-07 13:31:23 +00:00
|
|
|
|
) map[string]eventVisibility {
|
2022-08-11 16:23:35 +00:00
|
|
|
|
eventIDs := make([]string, len(events))
|
|
|
|
|
for i := range events {
|
|
|
|
|
eventIDs[i] = events[i].EventID()
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
result := make(map[string]eventVisibility, len(eventIDs))
|
|
|
|
|
|
|
|
|
|
// get the membership events for all eventIDs
|
|
|
|
|
membershipResp := &api.QueryMembershipAtEventResponse{}
|
2023-02-07 13:31:23 +00:00
|
|
|
|
|
2022-08-11 16:23:35 +00:00
|
|
|
|
err := rsAPI.QueryMembershipAtEvent(ctx, &api.QueryMembershipAtEventRequest{
|
|
|
|
|
RoomID: roomID,
|
|
|
|
|
EventIDs: eventIDs,
|
|
|
|
|
UserID: userID,
|
|
|
|
|
}, membershipResp)
|
|
|
|
|
if err != nil {
|
2022-10-10 10:19:16 +00:00
|
|
|
|
logrus.WithError(err).Error("visibilityForEvents: failed to fetch membership at event, defaulting to 'leave'")
|
2022-08-11 16:23:35 +00:00
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// Create a map from eventID -> eventVisibility
|
|
|
|
|
for _, event := range events {
|
|
|
|
|
eventID := event.EventID()
|
|
|
|
|
vis := eventVisibility{
|
2023-04-19 14:50:33 +00:00
|
|
|
|
membershipAtEvent: spec.Leave, // default to leave, to not expose events by accident
|
2022-08-11 16:23:35 +00:00
|
|
|
|
visibility: event.Visibility,
|
|
|
|
|
}
|
2023-02-07 13:31:23 +00:00
|
|
|
|
ev, ok := membershipResp.Membership[eventID]
|
|
|
|
|
if !ok || ev == nil {
|
2022-08-11 16:23:35 +00:00
|
|
|
|
result[eventID] = vis
|
|
|
|
|
continue
|
|
|
|
|
}
|
2023-02-07 13:31:23 +00:00
|
|
|
|
|
|
|
|
|
membership, err := ev.Membership()
|
|
|
|
|
if err != nil {
|
|
|
|
|
result[eventID] = vis
|
|
|
|
|
continue
|
2022-08-11 16:23:35 +00:00
|
|
|
|
}
|
2023-02-07 13:31:23 +00:00
|
|
|
|
vis.membershipAtEvent = membership
|
|
|
|
|
|
2022-08-11 16:23:35 +00:00
|
|
|
|
result[eventID] = vis
|
|
|
|
|
}
|
2023-02-07 13:31:23 +00:00
|
|
|
|
return result
|
2022-08-11 16:23:35 +00:00
|
|
|
|
}
|