Rudimentary pagination of rooms in the rooms filter

syncapi/storage/sqlite3/memberships_table.go

@@ -20,6 +20,7 @@ import (
 	"fmt"
 	"strings"
 
+	"github.com/matrix-org/dendrite/internal"
 	"github.com/matrix-org/dendrite/internal/sqlutil"
 	"github.com/matrix-org/dendrite/syncapi/storage/tables"
 	"github.com/matrix-org/dendrite/syncapi/types"
@@ -63,9 +64,14 @@ const selectMembershipSQL = "" +
 	" ORDER BY stream_pos DESC" +
 	" LIMIT 1"
 
+const selectMembershipsSQL = "" +
+	"SELECT room_id, membership FROM syncapi_memberships" +
+	" WHERE user_id = $1"
+
 type membershipsStatements struct {
-	db                   *sql.DB
-	upsertMembershipStmt *sql.Stmt
+	db                    *sql.DB
+	upsertMembershipStmt  *sql.Stmt
+	selectMembershipsStmt *sql.Stmt
 }
 
 func NewSqliteMembershipsTable(db *sql.DB) (tables.Memberships, error) {
@@ -79,6 +85,9 @@ func NewSqliteMembershipsTable(db *sql.DB) (tables.Memberships, error) {
 	if s.upsertMembershipStmt, err = db.Prepare(upsertMembershipSQL); err != nil {
 		return nil, err
 	}
+	if s.selectMembershipsStmt, err = db.Prepare(selectMembershipsSQL); err != nil {
+		return nil, err
+	}
 	return s, nil
 }
 
@@ -117,3 +126,24 @@ func (s *membershipsStatements) SelectMembership(
 	err = sqlutil.TxStmt(txn, stmt).QueryRowContext(ctx, params...).Scan(&eventID, &streamPos, &topologyPos)
 	return
 }
+
+func (s *membershipsStatements) SelectMemberships(
+	ctx context.Context, txn *sql.Tx, userID string,
+) (map[string]string, error) {
+	var roomID, membership string
+	result := map[string]string{}
+	stmt := sqlutil.TxStmt(txn, s.selectMembershipsStmt)
+	rows, err := stmt.QueryContext(ctx, userID)
+	if err != nil {
+		return nil, fmt.Errorf("stmt.QueryContext: %w", err)
+	}
+	defer internal.CloseAndLogIfError(ctx, rows, "failed to close rows")
+	for rows.Next() {
+		err = rows.Scan(&roomID, &membership)
+		if err != nil {
+			return nil, fmt.Errorf("rows.Scan: %w", err)
+		}
+		result[roomID] = membership
+	}
+	return result, nil
+}

syncapi/storage/sqlite3/output_room_events_table.go

@@ -21,6 +21,7 @@ import (
 	"encoding/json"
 	"fmt"
 	"sort"
+	"strings"
 
 	"github.com/matrix-org/dendrite/internal"
 	"github.com/matrix-org/dendrite/roomserver/api"
@@ -90,6 +91,13 @@ const selectStateInRangeSQL = "" +
 const deleteEventsForRoomSQL = "" +
 	"DELETE FROM syncapi_output_room_events WHERE room_id = $1"
 
+const bulkSelectMaxStreamPositionsSQL = "" +
+	"SELECT room_id, MAX(id) AS id FROM syncapi_output_room_events" +
+	" WHERE room_id IN ($1)" +
+	" GROUP BY room_id" +
+	" ORDER BY id DESC" +
+	" LIMIT $2 OFFSET $3"
+
 type outputRoomEventsStatements struct {
 	db                      *sql.DB
 	streamIDStatements      *streamIDStatements
@@ -424,6 +432,40 @@ func (s *outputRoomEventsStatements) DeleteEventsForRoom(
 	return err
 }
 
+func (s *outputRoomEventsStatements) BulkSelectMaxStreamPositions(
+	ctx context.Context, txn *sql.Tx, roomIDs []string, offset, count int,
+) (map[string]types.StreamPosition, error) {
+	origSQL := strings.Replace(bulkSelectMaxStreamPositionsSQL, "$2", fmt.Sprintf("$%d", len(roomIDs)+1), 1)
+	origSQL = strings.Replace(origSQL, "$3", fmt.Sprintf("$%d", len(roomIDs)+2), 1)
+	origSQL = strings.Replace(origSQL, "($1)", sqlutil.QueryVariadic(len(roomIDs)), 1)
+	origStmt, err := s.db.Prepare(origSQL)
+	if err != nil {
+		return nil, fmt.Errorf("s.db.Prepare: %w", err)
+	}
+	params := []interface{}{}
+	for _, roomID := range roomIDs {
+		params = append(params, roomID)
+	}
+	params = append(params, count, offset)
+	result := map[string]types.StreamPosition{}
+	stmt := sqlutil.TxStmt(txn, origStmt)
+	rows, err := stmt.QueryContext(ctx, params...)
+	if err != nil {
+		return nil, fmt.Errorf("stmt.QueryContext: %w", err)
+	}
+	defer internal.CloseAndLogIfError(ctx, rows, "failed to close rows")
+	for rows.Next() {
+		var roomID string
+		var pos types.StreamPosition
+		err = rows.Scan(&roomID, &pos)
+		if err != nil {
+			return nil, fmt.Errorf("rows.Scan: %w", err)
+		}
+		result[roomID] = pos
+	}
+	return result, nil
+}
+
 func rowsToStreamEvents(rows *sql.Rows) ([]types.StreamEvent, error) {
 	var result []types.StreamEvent
 	for rows.Next() {