hoernschen/dendrite
1
0
Fork 0
mirror of https://github.com/hoernschen/dendrite.git synced 2025-08-02 06:12:45 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Add ineffassign to the pre-commit hooks (#139)

Browse source 
* Add ineffassign to the pre-comiit hooks

* Fix travis.yml

* Only apply ineffassign to the /src directory
This commit is contained in:
Mark Haines 2017-06-12 19:52:03 +01:00 • committed by GitHub
parent 472155837b
commit 5e490e773f
3 changed files with 2 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

5
src/github.com/matrix-org/dendrite/common/test/client.go
View file

@ -136,12 +136,8 @@ func (r *Request) Run(label string, timeout time.Duration, serverCmdChan chan er
// - the server to exit with an error (error sent on serverCmdChan)
// - our test timeout to expire
// We don't need to clean up since the main() function handles that in the event we panic
var testPassed bool
select {
case <-time.After(timeout):
if testPassed {
break
}
fmt.Printf("==TESTING== %v TIMEOUT\n", label)
if reqErr := r.LastErr.Get(); reqErr != nil {
fmt.Println("Last /sync request error:")
@ -157,7 +153,6 @@ func (r *Request) Run(label string, timeout time.Duration, serverCmdChan chan er
panic(err)
}
case <-done:
testPassed = true
fmt.Printf("==TESTING== %v PASSED\n", label)
}
}