Fix pipeline, emoji and syntax (#713)

Fixes #697

Switched to golangci-lint, fixes issues with buildkite and does some linting fixes to appease the new linters.

common/config/config.go

@@ -585,7 +585,7 @@ func (config *Dendrite) check(monolithic bool) error {
 	}
 
 	// Due to how Golang manages its interface types, this condition is not redundant.
-	// In order to get the proper behavior, it is necessary to return an explicit nil
+	// In order to get the proper behaviour, it is necessary to return an explicit nil
 	// and not a nil configErrors.
 	// This is because the following equalities hold:
 	// error(nil) == nil

common/log.go

@@ -76,7 +76,7 @@ func SetupHookLogging(hooks []config.LogrusHook, componentName string) {
 		// Check we received a proper logging level
 		level, err := logrus.ParseLevel(hook.Level)
 		if err != nil {
-			logrus.Fatalf("Unrecognized logging level %s: %q", hook.Level, err)
+			logrus.Fatalf("Unrecognised logging level %s: %q", hook.Level, err)
 		}
 
 		// Perform a first filter on the logs according to the lowest level of all
@@ -90,7 +90,7 @@ func SetupHookLogging(hooks []config.LogrusHook, componentName string) {
 			checkFileHookParams(hook.Params)
 			setupFileHook(hook, level, componentName)
 		default:
-			logrus.Fatalf("Unrecognized logging hook type: %s", hook.Type)
+			logrus.Fatalf("Unrecognised logging hook type: %s", hook.Type)
 		}
 	}
 }

common/partition_offset_table.go

@@ -50,7 +50,6 @@ type PartitionOffsetStatements struct {
 // Prepare converts the raw SQL statements into prepared statements.
 // Takes a prefix to prepend to the table name used to store the partition offsets.
 // This allows multiple components to share the same database schema.
-// nolint: safesql
 func (s *PartitionOffsetStatements) Prepare(db *sql.DB, prefix string) (err error) {
 	_, err = db.Exec(strings.Replace(partitionOffsetsSchema, "${prefix}", prefix, -1))
 	if err != nil {

common/test/client.go

@@ -34,7 +34,7 @@ type Request struct {
 	LastErr          *LastRequestErr
 }
 
-// LastRequestErr is a synchronized error wrapper
+// LastRequestErr is a synchronised error wrapper
 // Useful for obtaining the last error from a set of requests
 type LastRequestErr struct {
 	sync.Mutex

common/types.go

@@ -43,7 +43,7 @@ type DisplayName struct {
 
 // WeakBoolean is a type that will Unmarshal to true or false even if the encoded
 // representation is "true"/1 or "false"/0, as well as whatever other forms are
-// recognized by strconv.ParseBool
+// recognised by strconv.ParseBool
 type WeakBoolean bool
 
 // UnmarshalJSON is overridden here to allow strings vaguely representing a true