hoernschen/dendrite
1
0
Fork 0
mirror of https://github.com/hoernschen/dendrite.git synced 2024-12-27 23:48:27 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix nightmare bug where sqlite doesn't let you use out of order sub strings

Browse source
This commit is contained in:
Matthew Hodgson 2020-09-09 02:14:06 +01:00
parent faa070bbc2
commit de53608f98
1 changed files with 5 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
syncapi/storage/sqlite3/peeks_table.go
View file

@ -53,8 +53,9 @@ const deletePeeksSQL = "" +
// we care about all the peeks which were created in this range, deleted in this range, // we care about all the peeks which were created in this range, deleted in this range,
// or were created before this range but haven't been deleted yet. // or were created before this range but haven't been deleted yet.
// BEWARE: sqlite chokes on out of order substitution strings.
const selectPeeksInRangeSQL = "" + const selectPeeksInRangeSQL = "" +
"SELECT room_id, deleted, (id > $3 AND id <= $4) AS changed FROM syncapi_peeks WHERE user_id = $1 AND device_id = $2 AND ((id <= $3 AND NOT deleted) OR (id > $3 AND id <= $4))" "SELECT id, room_id, deleted FROM syncapi_peeks WHERE user_id = $1 AND device_id = $2 AND ((id <= $3 AND NOT deleted=true) OR (id > $3 AND id <= $4))"
const selectPeekingDevicesSQL = "" + const selectPeekingDevicesSQL = "" +
"SELECT room_id, user_id, device_id FROM syncapi_peeks WHERE deleted=false" "SELECT room_id, user_id, device_id FROM syncapi_peeks WHERE deleted=false"
@ -148,11 +149,11 @@ func (s *peekStatements) SelectPeeksInRange(
for rows.Next() { for rows.Next() {
peek := types.Peek{} peek := types.Peek{}
var changed bool var id types.StreamPosition
if err = rows.Scan(&peek.RoomID, &peek.Deleted, &changed); err != nil { if err = rows.Scan(&id, &peek.RoomID, &peek.Deleted); err != nil {
return return
} }
peek.New = changed && !peek.Deleted peek.New = (id > r.Low() && id <= r.High()) && !peek.Deleted
peeks = append(peeks, peek) peeks = append(peeks, peek)
} }