From f9151302aa358eccd2a78cc13e5cde7fd55454e0 Mon Sep 17 00:00:00 2001 From: Neil Alexander Date: Mon, 21 Jun 2021 16:00:09 +0100 Subject: [PATCH] Don't redact, instead just silently drop --- federationapi/routing/send.go | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/federationapi/routing/send.go b/federationapi/routing/send.go index 02b68d8a..314ca801 100644 --- a/federationapi/routing/send.go +++ b/federationapi/routing/send.go @@ -235,14 +235,13 @@ func (t *txnReq) processTransaction(ctx context.Context) (*gomatrixserverlib.Res continue } if err = gomatrixserverlib.VerifyAllEventSignatures(ctx, []*gomatrixserverlib.Event{event}, t.keys); err != nil { - event = event.Redact() + util.GetLogger(ctx).WithError(err).Warnf("Transaction: Couldn't validate signature of event %q", event.EventID()) /* - util.GetLogger(ctx).WithError(err).Warnf("Transaction: Couldn't validate signature of event %q", event.EventID()) results[event.EventID()] = gomatrixserverlib.PDUResult{ Error: err.Error(), } - continue */ + continue } pdus = append(pdus, event.Redact().Headered(verRes.RoomVersion)) }