Commit graph

12 commits

Author SHA1 Message Date
Erik Johnston
ff78a99604 Disable the maligned lint ()
We don't really care about ensuring our structs are small, and sometimes
its clearer to group struct fields together.
2017-12-05 11:37:34 +00:00
Erik Johnston
561315e1d6
Add gofmt linter ()
* Check that gofmt has been run

* gofmt files

* Tabs and spaces
2017-11-16 10:12:02 +00:00
Richard van der Hoff
8fff0e887c Update gometalinter config ()
* Update gometalinter config

gometalinter now uses `maligned` instead of `aligncheck`
(https://github.com/alecthomas/gometalinter/pull/367), so we need to update our
config accordingly.

* Update gometalinter

* Disable gotype linter

gotype does not seem to play nicely with the gb vendor directory. In
particular, it wants each of our dependencies to be built and installed (see
https://github.com/golang/go/issues/10969), but (empirically) it will not
accept them being installed in `pkg` but insists on them being in `vendor/pkg`.

This presents a problem because `gb build` builds the packages into `pkg`
(which doesn't seem entirely unreasonable since `.` comes before `vendor` in
`$GOPATH`). `go install github.com/x/y` does install in `vendor/pkg` but
requires us to know the name of each package.

The general conclusion of https://github.com/alecthomas/gometalinter/issues/91
seems to have been that the easiest thing to do is to disable `gotype` for now.

* Fix `unparam` lint

* Fix goshadow lint
2017-11-15 10:25:48 +00:00
Erik Johnston
7a30f2085a Add goconst linter () 2017-09-20 15:25:25 +01:00
Erik Johnston
340a84cdc0 Add staticcheck lint () 2017-09-20 14:54:17 +01:00
Erik Johnston
584acbe9a9 Add 'unused' lint ()
* Add 'unused' lint

* Keep testdata consts
2017-09-20 14:47:29 +01:00
Erik Johnston
cc2f755cb3 Add gosimple linter () 2017-09-20 14:15:38 +01:00
Erik Johnston
b72142ace5 Add vet linter () 2017-09-20 13:40:22 +01:00
Erik Johnston
8a36a7e89b Add errcheck linter ()
* Add errcheck linter

* Add config for 'fast' linters

* Fix errcheck lint stuff

* Fix errcheck lint
2017-09-20 10:59:19 +01:00
Mark Haines
532cc082a9 Increase the linter deadline from 1 min to 5 min. ()
Hopefully will avoid spurious test failures like
https://travis-ci.org/matrix-org/dendrite/builds/272960127
2017-09-13 11:08:27 +01:00
Erik Johnston
fad997303b Turn on 'unparam' linting ()
* Turn on 'unparam' linting

* Increase deadline

* Fix mediaapi integeration test
2017-09-07 12:50:39 +01:00
Erik Johnston
2dcb3a11a5 Use gometalinter ()
* Remove unused struct field

* Ignore unused test data

* Remove unused variables

* Remove deadcode

* Fix up vetshadow warnings

* Convert to using gometalinter

* Update travis

* Use vendored versions of gometalinter

* Make gometalinter install its stuff

* Vendor misspell
2017-09-05 17:40:46 +01:00